Repository navigation
[backport core/1.48] fix(billing): recover past-due plan changes (FE-1251) - #14524
Conversation
## Why
Past-due Stripe subscriptions return `TRANSITION_NOT_ALLOWED` during
plan preview. The UI showed a generic error with no recovery path.
## Change
For preview failures only:
- recognize `SUBSCRIPTION_PAYMENT_REQUIRED`, or the current production
response when `billing_status` is `payment_failed`
- open the existing Stripe billing portal in a new tab while preserving
the checkout state
```mermaid
flowchart LR
subgraph Before
A[Change plan] --> B[Preview fails]
B --> C[Generic error]
C --> D[User blocked]
end
subgraph After
E[Change plan] --> F[Preview fails]
F --> G{Payment failed?}
G -- No --> H[Existing error handling]
G -- Yes --> I[Stripe billing portal in new tab]
end
```
## Test
- 96 checkout tests
- typecheck, lint, format, and knip
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎭 Playwright: ✅ 1759 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-01T00:37:29.626Z",
"gitSha": "66b9debff69091b70da2ff04d2c2610ecddb1609",
"branch": "backport-14513-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2178.989999999999,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 615.646,
"heapDeltaBytes": 4132568,
"heapUsedBytes": 72258188,
"domNodes": 14,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 21.284000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.0059999999803,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.531999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.90500000000003,
"heapDeltaBytes": 3665480,
"heapUsedBytes": 71277108,
"domNodes": 20,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 19.63,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.0639999999653,
"styleRecalcs": 72,
"styleRecalcDurationMs": 37.172000000000004,
"layouts": 12,
"layoutDurationMs": 3.483,
"taskDurationMs": 910.9659999999999,
"heapDeltaBytes": -20214640,
"heapUsedBytes": 47568500,
"domNodes": -274,
"jsHeapTotalBytes": 22278144,
"scriptDurationMs": 128.051,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1830.9410000000526,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.721000000000004,
"layouts": 12,
"layoutDurationMs": 3.3809999999999993,
"taskDurationMs": 918.6410000000001,
"heapDeltaBytes": -16518516,
"heapUsedBytes": 51477872,
"domNodes": -273,
"jsHeapTotalBytes": 22016000,
"scriptDurationMs": 127.388,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.8410000000085,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.930999999999997,
"layouts": 6,
"layoutDurationMs": 0.6739999999999999,
"taskDurationMs": 430.564,
"heapDeltaBytes": 7303276,
"heapUsedBytes": 75144648,
"domNodes": 78,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 25.384999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0299999999943,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.331,
"layouts": 6,
"layoutDurationMs": 0.6449999999999999,
"taskDurationMs": 380.971,
"heapDeltaBytes": 7312444,
"heapUsedBytes": 75152612,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 20.463,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 582.8250000000139,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.683000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.774,
"heapDeltaBytes": -12188176,
"heapUsedBytes": 55899964,
"domNodes": 20,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 59.483999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 575.9610000000066,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9929999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 376.842,
"heapDeltaBytes": -12064816,
"heapUsedBytes": 55782144,
"domNodes": 18,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 59.815,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.6070000000177,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.8489999999999,
"heapDeltaBytes": 6335232,
"heapUsedBytes": 65070344,
"domNodes": -277,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 125.283,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.6670000000786,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.695999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.9340000000001,
"heapDeltaBytes": 6410624,
"heapUsedBytes": 65241900,
"domNodes": -277,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 119.562,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2288.2589999999823,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.550999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1398.646,
"heapDeltaBytes": -3710552,
"heapUsedBytes": 56103384,
"domNodes": -280,
"jsHeapTotalBytes": 5308416,
"scriptDurationMs": 471.12699999999995,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2224.313000000052,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.345000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1377.2389999999998,
"heapDeltaBytes": 4603784,
"heapUsedBytes": 64592264,
"domNodes": -279,
"jsHeapTotalBytes": 4202496,
"scriptDurationMs": 453.66100000000006,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3330.9580000000096,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.373999999999999,
"layouts": 60,
"layoutDurationMs": 7.608999999999999,
"taskDurationMs": 1631.39,
"heapDeltaBytes": 7442828,
"heapUsedBytes": 69409052,
"domNodes": -283,
"jsHeapTotalBytes": 7405568,
"scriptDurationMs": 565.581,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3314.377000000036,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.864,
"layouts": 60,
"layoutDurationMs": 7.4750000000000005,
"taskDurationMs": 1579.7910000000002,
"heapDeltaBytes": 2799960,
"heapUsedBytes": 64868832,
"domNodes": -282,
"jsHeapTotalBytes": 8192000,
"scriptDurationMs": 551.083,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.214000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.466,
"heapDeltaBytes": 7149908,
"heapUsedBytes": 67564388,
"domNodes": -279,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 122.689,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2010.7490000000325,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.442000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 703.047,
"heapDeltaBytes": 6250004,
"heapUsedBytes": 66633932,
"domNodes": -278,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 113.454,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.2829999999635,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.689,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.4260000000001,
"heapDeltaBytes": -12010284,
"heapUsedBytes": 55854140,
"domNodes": 14,
"jsHeapTotalBytes": 22675456,
"scriptDurationMs": 125.89699999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.2809999999763,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.575000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.022,
"heapDeltaBytes": -11515432,
"heapUsedBytes": 56556080,
"domNodes": 20,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 120.97500000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.5230000000352,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.956999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.841,
"heapDeltaBytes": -20413112,
"heapUsedBytes": 47548452,
"domNodes": -273,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 18.278000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.3270000000466,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.587,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 549.985,
"heapDeltaBytes": -22302952,
"heapUsedBytes": 45606652,
"domNodes": 20,
"jsHeapTotalBytes": 20705280,
"scriptDurationMs": 18.547,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.842000000032,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.00600000000001,
"layouts": 16,
"layoutDurationMs": 4.715,
"taskDurationMs": 773.7740000000001,
"heapDeltaBytes": -5668892,
"heapUsedBytes": 62307524,
"domNodes": 61,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 94.621,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1728.0809999999747,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.061,
"layouts": 16,
"layoutDurationMs": 4.807,
"taskDurationMs": 801.797,
"heapDeltaBytes": -5667220,
"heapUsedBytes": 62288980,
"domNodes": 60,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 100.06400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.9610000000107,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.473,
"layouts": 14,
"layoutDurationMs": 13.762999999999998,
"taskDurationMs": 1062.0430000000001,
"heapDeltaBytes": 153164,
"heapUsedBytes": 72740948,
"domNodes": 13673,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 37.996,
"eventListeners": 2371,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9037.74199999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.601000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5115.263,
"heapDeltaBytes": 18238488,
"heapUsedBytes": 77503408,
"domNodes": -274,
"jsHeapTotalBytes": 7843840,
"scriptDurationMs": 1577.675,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8339.042999999947,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.900999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4617.839,
"heapDeltaBytes": 10046744,
"heapUsedBytes": 68718072,
"domNodes": -275,
"jsHeapTotalBytes": 6533120,
"scriptDurationMs": 1417.559,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17485.589000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17466.307,
"heapDeltaBytes": -62780976,
"heapUsedBytes": 166836460,
"domNodes": -8312,
"jsHeapTotalBytes": -12521472,
"scriptDurationMs": 626.318,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17275.94799999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17225.135,
"heapDeltaBytes": -20449908,
"heapUsedBytes": 183943500,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 572.742,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21250.675000000003,
"styleRecalcs": 144,
"styleRecalcDurationMs": 18.625999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21218.403000000002,
"heapDeltaBytes": -54885632,
"heapUsedBytes": 164276988,
"domNodes": -8312,
"jsHeapTotalBytes": -14618624,
"scriptDurationMs": 967.3240000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 324,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20608.90699999993,
"styleRecalcs": 141,
"styleRecalcDurationMs": 17.69299999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20569.56,
"heapDeltaBytes": -37269896,
"heapUsedBytes": 170699704,
"domNodes": -8312,
"jsHeapTotalBytes": -13393920,
"scriptDurationMs": 901.274,
"eventListeners": -16381,
"totalBlockingTimeMs": 177,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 486.6990000000442,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.211999999999996,
"layouts": 2,
"layoutDurationMs": 0.41200000000000003,
"taskDurationMs": 137.652,
"heapDeltaBytes": -15874616,
"heapUsedBytes": 50987780,
"domNodes": 132,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 11.552,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 483.7399999998979,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.103,
"layouts": 3,
"layoutDurationMs": 1.389,
"taskDurationMs": 134.65,
"heapDeltaBytes": -15905992,
"heapUsedBytes": 51101364,
"domNodes": 143,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 10.846,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.48 #14524 +/- ##
==========================================
Coverage 79.32% 79.33%
==========================================
Files 1746 1746
Lines 99333 99375 +42
Branches 32589 32607 +18
==========================================
+ Hits 78799 78840 +41
- Misses 20132 20133 +1
Partials 402 402
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14513 to
core/1.48.Clean cherry-pick.
Validation: 96 focused tests, typecheck, and knip.