Repository navigation
[backport cloud/1.48] fix(billing): recover past-due plan changes (FE-1251) - #14523
Conversation
## Why
Past-due Stripe subscriptions return `TRANSITION_NOT_ALLOWED` during
plan preview. The UI showed a generic error with no recovery path.
## Change
For preview failures only:
- recognize `SUBSCRIPTION_PAYMENT_REQUIRED`, or the current production
response when `billing_status` is `payment_failed`
- open the existing Stripe billing portal in a new tab while preserving
the checkout state
```mermaid
flowchart LR
subgraph Before
A[Change plan] --> B[Preview fails]
B --> C[Generic error]
C --> D[User blocked]
end
subgraph After
E[Change plan] --> F[Preview fails]
F --> G{Payment failed?}
G -- No --> H[Existing error handling]
G -- Yes --> I[Stripe billing portal in new tab]
end
```
## Test
- 96 checkout tests
- typecheck, lint, format, and knip
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1763 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-01T00:37:00.147Z",
"gitSha": "353cb4eaa552f40fdae08487e7301f817e05c6d9",
"branch": "backport-14513-to-cloud-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.597000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.541000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.232,
"heapDeltaBytes": 3965688,
"heapUsedBytes": 71948904,
"domNodes": 20,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 18.019000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.0529999999908,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.533000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.47799999999995,
"heapDeltaBytes": 3884836,
"heapUsedBytes": 71977624,
"domNodes": 20,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 15.570999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.4339999999836,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.767999999999994,
"layouts": 12,
"layoutDurationMs": 3.6319999999999997,
"taskDurationMs": 840.398,
"heapDeltaBytes": -16709344,
"heapUsedBytes": 51140520,
"domNodes": -273,
"jsHeapTotalBytes": 21229568,
"scriptDurationMs": 116.00599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.1800000000549,
"styleRecalcs": 72,
"styleRecalcDurationMs": 35.184999999999995,
"layouts": 12,
"layoutDurationMs": 3.379,
"taskDurationMs": 833.006,
"heapDeltaBytes": -14732420,
"heapUsedBytes": 53130048,
"domNodes": -274,
"jsHeapTotalBytes": 21491712,
"scriptDurationMs": 115.37599999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.0400000000163,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.704999999999997,
"layouts": 6,
"layoutDurationMs": 0.6830000000000002,
"taskDurationMs": 378.16099999999994,
"heapDeltaBytes": 7256216,
"heapUsedBytes": 75139748,
"domNodes": 77,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 19.227,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3410000000285,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.495,
"layouts": 6,
"layoutDurationMs": 0.6510000000000001,
"taskDurationMs": 347.4,
"heapDeltaBytes": 7242280,
"heapUsedBytes": 75192312,
"domNodes": 77,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 17.108999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.9440000000327,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.84999999999997,
"heapDeltaBytes": -12046032,
"heapUsedBytes": 55888060,
"domNodes": 22,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 59.212,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 575.0960000000305,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.723999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.637,
"heapDeltaBytes": -12398044,
"heapUsedBytes": 55508008,
"domNodes": 22,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 55.971999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.8899999999803,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.999999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.212,
"heapDeltaBytes": 6516696,
"heapUsedBytes": 66156292,
"domNodes": -273,
"jsHeapTotalBytes": 3997696,
"scriptDurationMs": 111.017,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2021.9829999999774,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.088999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 644.682,
"heapDeltaBytes": 6350712,
"heapUsedBytes": 64909140,
"domNodes": -274,
"jsHeapTotalBytes": 4784128,
"scriptDurationMs": 100.057,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2144.453999999996,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.959,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1242.826,
"heapDeltaBytes": 1697364,
"heapUsedBytes": 61531664,
"domNodes": -275,
"jsHeapTotalBytes": 5775360,
"scriptDurationMs": 420.38200000000006,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2145.1769999999897,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.477000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1228.71,
"heapDeltaBytes": 5747780,
"heapUsedBytes": 65342448,
"domNodes": -277,
"jsHeapTotalBytes": 5251072,
"scriptDurationMs": 421.67299999999994,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3181.0820000000035,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.18,
"layouts": 60,
"layoutDurationMs": 7.002,
"taskDurationMs": 1481.1480000000001,
"heapDeltaBytes": -2406416,
"heapUsedBytes": 59000020,
"domNodes": -281,
"jsHeapTotalBytes": 6881280,
"scriptDurationMs": 514.744,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3129.3849999999566,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.644999999999998,
"layouts": 60,
"layoutDurationMs": 6.976999999999999,
"taskDurationMs": 1453.33,
"heapDeltaBytes": -5656748,
"heapUsedBytes": 56225052,
"domNodes": -280,
"jsHeapTotalBytes": 7667712,
"scriptDurationMs": 507.83299999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.0430000000056,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.588,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.624,
"heapDeltaBytes": 6254424,
"heapUsedBytes": 66676544,
"domNodes": -279,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 99.514,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.1020000000044,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.2,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.7809999999998,
"heapDeltaBytes": 7296128,
"heapUsedBytes": 68067164,
"domNodes": -276,
"jsHeapTotalBytes": 3735552,
"scriptDurationMs": 105.737,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.4190000000258,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.754999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.946,
"heapDeltaBytes": -11770504,
"heapUsedBytes": 56124100,
"domNodes": 20,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 118.63000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 584.3939999999748,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.275,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.917,
"heapDeltaBytes": -11603480,
"heapUsedBytes": 56179240,
"domNodes": 20,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 114.32000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2026.410999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.850000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.617,
"heapDeltaBytes": 3377224,
"heapUsedBytes": 71090540,
"domNodes": 18,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 13.399,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2031.7250000000513,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.348,
"heapDeltaBytes": -22431660,
"heapUsedBytes": 45713612,
"domNodes": -272,
"jsHeapTotalBytes": 19918848,
"scriptDurationMs": 13.046999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.4430000000116,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.760000000000005,
"layouts": 16,
"layoutDurationMs": 3.625,
"taskDurationMs": 767.224,
"heapDeltaBytes": -18886540,
"heapUsedBytes": 49069056,
"domNodes": -273,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 87.00300000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.2279999999382,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.555,
"layouts": 16,
"layoutDurationMs": 4.157,
"taskDurationMs": 718.78,
"heapDeltaBytes": -5663392,
"heapUsedBytes": 62339264,
"domNodes": 62,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 84.743,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0609999999742,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.365000000000002,
"layouts": 14,
"layoutDurationMs": 12.390000000000002,
"taskDurationMs": 898.1619999999999,
"heapDeltaBytes": 9116880,
"heapUsedBytes": 100387332,
"domNodes": 13673,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.811000000000003,
"eventListeners": 2371,
"totalBlockingTimeMs": 127,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.548999999985,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.23,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4413.5960000000005,
"heapDeltaBytes": 11747632,
"heapUsedBytes": 70604912,
"domNodes": -274,
"jsHeapTotalBytes": 7319552,
"scriptDurationMs": 1432.236,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8255.910000000085,
"styleRecalcs": 249,
"styleRecalcDurationMs": 33.83,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4263.09,
"heapDeltaBytes": 9802928,
"heapUsedBytes": 69616400,
"domNodes": -275,
"jsHeapTotalBytes": 6561792,
"scriptDurationMs": 1325.6670000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16491.03500000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16472.62,
"heapDeltaBytes": -67340896,
"heapUsedBytes": 154485768,
"domNodes": -8312,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 519.946,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16547.793999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16527.554,
"heapDeltaBytes": -42484680,
"heapUsedBytes": 165831352,
"domNodes": -8312,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 561.591,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19755.877999999997,
"styleRecalcs": 135,
"styleRecalcDurationMs": 14.727999999999962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19728.926,
"heapDeltaBytes": -38656376,
"heapUsedBytes": 169365464,
"domNodes": -8313,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 818.39,
"eventListeners": -16381,
"totalBlockingTimeMs": 150,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20336.415999999987,
"styleRecalcs": 140,
"styleRecalcDurationMs": 15.729999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20285.841,
"heapDeltaBytes": -43570260,
"heapUsedBytes": 164158568,
"domNodes": -8312,
"jsHeapTotalBytes": -14880768,
"scriptDurationMs": 905.934,
"eventListeners": -16383,
"totalBlockingTimeMs": 146,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 480.70999999998776,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.421999999999997,
"layouts": 5,
"layoutDurationMs": 1.6609999999999998,
"taskDurationMs": 131.00300000000001,
"heapDeltaBytes": -15467228,
"heapUsedBytes": 51503740,
"domNodes": 152,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 11.755999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 485.4930000000195,
"styleRecalcs": 12,
"styleRecalcDurationMs": 19.777000000000005,
"layouts": 3,
"layoutDurationMs": 0.674,
"taskDurationMs": 128.13000000000002,
"heapDeltaBytes": -16072992,
"heapUsedBytes": 50983836,
"domNodes": 117,
"jsHeapTotalBytes": 7471104,
"scriptDurationMs": 8.488000000000001,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.48 #14523 +/- ##
=============================================
Coverage ? 69.15%
=============================================
Files ? 1659
Lines ? 85710
Branches ? 24694
=============================================
Hits ? 59277
Misses ? 26323
Partials ? 110
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14513 to
cloud/1.48.Clean cherry-pick.
Validation: 96 focused tests, typecheck, and knip.