Skip to content

feat(billing): visual pass for the embedded checkout - #14447

Closed
comfydesigner wants to merge 5 commits into
proper-alipay-and-3ds-supportfrom
comfydesigner/payment-element-visual-pass
Closed

comfydesigner wants to merge 5 commits into
proper-alipay-and-3ds-supportfrom
comfydesigner/payment-element-visual-pass

Conversation

@comfydesigner

@comfydesigner comfydesigner commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

Visual pass over the embedded Stripe checkout (proper-alipay-and-3ds-support). Review commit-by-commit — each is a self-contained stage:

  1. Two-column payment step — dual-tone summary panel, pinned dialog footprint
  2. Edge-to-edge split — summary as flush sidebar, single title with inline back arrow, brand type scale, tabular numerals, one merged legal line, 3DS-aware CTA hierarchy (Complete verification inverted and first; Pay demotes to tertiary while a verification is pending)
  3. Success collapse — same pinned height, width animates 1280→512 (300ms ease-in-out), darker surface, promo-applied feedback behind an optional prop, Close demotes while Send invites is primary
  4. Mobile pass — width floor for the w-fit shell (was collapsing to ~190px), vertical dual tone, arrow/X aligned in one header row, 24px insets
  5. Mobile fixes — 85vh cap (dialog exceeded the viewport), corner clipping, height tween via Web Animations API (height transitions with an auto endpoint never engage in Chromium; a CSS FLIP gets eaten by the step-content patch, so WAAPI owns mobile height and CSS keeps desktop width)

Intentional behavior changes to review as decisions, not side effects:

  • Scrim click no longer closes the dialog (dismissableMask: false) — applies to every step including plan-change confirms; X is the only close (Esc still works)
  • One legal line: Stripe's card mandate is suppressed (terms.card: 'never'); subscription.preview.termsAgreement now carries the recurring-charge authorization and is shared with the transition previews
  • Toasts stay clickable above modals (.p-toast pointer-events) — global; also extracted to a standalone PR against main since it fixes all Reka modals

Known follow-ups (not in this PR):

  • Promo validation/requote endpoint and success promo data (promoApplied prop ships dark until the backend supplies code/renewal fields)
  • Expanding back to the payment step animates to a pre-Stripe-mount height, then grows when the iframe lands
  • Yearly team pricing on the success card still displays monthly-normalized
  • Planned next: customers with a saved payment method get a narrow (512px) confirm — summary + saved card + Pay — instead of the capture form; the wide split becomes first-capture-only, with "Change" expanding back into it. Needs the preview response to carry a default-payment-method summary. Open question for this branch: does the capture form currently show for customers who already have a saved method?

Plan-change flows (SubscriptionTransitionPreviewWorkspace, downgrade dialog) are untouched.

image Screenshot 2026-07-30 at 7 08 06 PM
Screen.Recording.2026-07-30.at.6.29.52.PM.mov

- Confirm-payment step takes the pricing table's exact dialog footprint
  (pinned h, not min-h - the Stripe iframe stretched the dialog after
  mount) and hides the stacked Choose a Plan header
- Order summary sits in a full-height rounded panel on the left (same
  recipe as the pricing table's inner box); payment column scrolls
  independently on the right
- Payment selector flattened: outer card, element wrapper box, card
  icon, and redundant plan-price chip removed
- Promo code moved to the order summary as a flush text trigger that
  expands to an input (Figma 5379-30077 states A/B); code still rides
  along at confirm unchanged
- Alipay renewal note only shows when Alipay is selected (element
  change event)
- Selection uses base-foreground instead of brand blue; deal badges
  ($5 back) use primary-background via colorSuccess, matching the
  Save 20% pill; pay button inverted
- Stripe description no longer enumerates payment methods (varies by
  country and config)
- Features toggle was rendering in the UA font (raw button); font-inter
  added

All layout changes gate on usePaymentElement - mobile and the redirect
flow are unchanged.
- Summary becomes a flush full-height sidebar (42%) on base-background
  with the title and an inline back arrow; payment column takes the rest,
  scrolling independently inside the pinned 740px dialog
- Price on the brand type scale (24px in the sidebar), tabular numerals
  on money and credits, features toggle removed (pricing table already
  covers features), Back to all plans dropped in favor of the arrow
- Scrim click no longer closes the checkout (dismissableMask: false);
  the X is the only close, so a stray click can't discard card details
  or pending 3DS state
- One legal line: Stripe's card mandate suppressed (terms.card 'never');
  the terms note now carries the recurring-charge authorization
- Toasts stay clickable above Reka modals (.p-toast pointer-events);
  clicks no longer fall through a toast onto the dialog X
- Pending 3DS verification: Complete verification is inverted and takes
  the top of the column; the pay button demotes to tertiary (and is
  disabled by its loading state) while a verification is pending
- Accordion rows fill with base-background, unselected strokes
  transparent; deal badges keyed to primary via colorSuccess; promo
  trigger flush-left at input height
…ay CTA

- Success after an embedded checkout keeps the pinned 740px height and
  narrows to 512px with a 300ms ease-in-out width transition
  (motion-safe); surface goes base-background with the plan card
  elevated, borderless, and the duplicate Choose a Plan header hidden
- Promo trigger is a filled secondary button that expands to an
  auto-focused input and collapses back on blur while empty
- Pay CTA and terms pin to the bottom of the payment column; only the
  form region scrolls
- Promo-applied feedback on success ({code} applied. Renews at {amount}
  on {date}) behind an optional prop; backend does not supply the data
  yet
- Close demotes to muted-textonly while Send invites is primary; invite
  title unbolded; invite field matches the plan card surface on the dark
  variant via tagsInputClass; extra padding under Close
- Tabular numerals on the success card and promo line
- Embedded steps get a real width floor below xl (min(430px, 92vw)) -
  the w-fit dialog shell was hugging min-content down to ~190px on
  phones
- The dual tone runs vertically on mobile: the summary bleeds
  base-background to the dialog edges, payment continues on the shell
  below, both at a 24px edge inset
- Close joins the header row next to the back arrow below xl (the
  floating dialog X hides), so the two controls align and the title
  centers between them
- Plan price drops to the 24px brand scale at every width
- The payment step's dialog could exceed the viewport on phones (the
  shell's max-h did not hold); it now pins to 85vh with the existing
  internal scroll
- Success surface clips its corners at every width, not just xl
- Payment column matches the summary panel's 24px edge inset on mobile
- The payment/success height change tweens via the Web Animations API
  (300ms, ease-in-out, reduced-motion guarded): height transitions with
  an auto endpoint never engage in Chromium, and a CSS-transition FLIP
  is eaten by the same patch cycle that swaps the step content, so the
  tween runs outside the CSS transition machinery entirely; CSS keeps
  the desktop width transition
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 31, 2026
@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 00d0911f-2b15-49a9-9dec-7145a2f4ba9a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dosubot

dosubot Bot commented Jul 31, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Jul 31, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1751 passed, 5 failed · 5 flaky

❌ Failed Tests

📊 Browser Reports

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/31/2026, 01:53:07 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
subgraph-idle: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 151ms TBT · 98.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.1 MB heap
vue-large-graph-pan: · 53.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 477ms TBT · 172.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.1 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 609ms
canvas-idle: script duration 18ms
canvas-idle: TBT 0ms
canvas-idle: heap used 73.4 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 6
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 983ms
canvas-mouse-sweep: script duration 134ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 49.3 MB
canvas-mouse-sweep: DOM nodes -291
canvas-mouse-sweep: event listeners -150
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 473ms
canvas-zoom-sweep: script duration 21ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 76.3 MB
canvas-zoom-sweep: DOM nodes 79
canvas-zoom-sweep: event listeners 22
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 421ms
dom-widget-clipping: script duration 58ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 57.5 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 5
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 868ms
large-graph-idle: script duration 118ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 63.8 MB
large-graph-idle: DOM nodes -294
large-graph-idle: event listeners -161
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1521ms
large-graph-pan: script duration 496ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 65.7 MB
large-graph-pan: DOM nodes -294
large-graph-pan: event listeners -146
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1823ms
large-graph-zoom: script duration 626ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.7 MB
large-graph-zoom: DOM nodes -300
large-graph-zoom: event listeners -149
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 816ms
minimap-idle: script duration 115ms
minimap-idle: TBT 0ms
minimap-idle: heap used 68.8 MB
minimap-idle: DOM nodes -293
minimap-idle: event listeners -147
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 478ms
subgraph-dom-widget-clipping: script duration 127ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 58.5 MB
subgraph-dom-widget-clipping: DOM nodes 17
subgraph-dom-widget-clipping: event listeners 11
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 583ms
subgraph-idle: script duration 17ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 71.6 MB
subgraph-idle: DOM nodes 17
subgraph-idle: event listeners 6
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 915ms
subgraph-mouse-sweep: script duration 106ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.3 MB
subgraph-mouse-sweep: DOM nodes 63
subgraph-mouse-sweep: event listeners 7
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 1009ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 151ms
subgraph-transition-enter: heap used 98.7 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2369
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5539ms
viewport-pan-sweep: script duration 1656ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.5 MB
viewport-pan-sweep: DOM nodes -288
viewport-pan-sweep: event listeners -142
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17978ms
vue-large-graph-idle: script duration 648ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.1 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16389
vue-large-graph-pan: avg frame time 19ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 22336ms
vue-large-graph-pan: script duration 1055ms
vue-large-graph-pan: TBT 477ms
vue-large-graph-pan: heap used 172.5 MB
vue-large-graph-pan: DOM nodes -8312
vue-large-graph-pan: event listeners -16382
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 26ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 144ms
workflow-execution: script duration 11ms
workflow-execution: TBT 0ms
workflow-execution: heap used 52.1 MB
workflow-execution: DOM nodes 134
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-07-31T02:03:53.962Z",
  "gitSha": "3c21803e1fd4f23e3cd144d8fe9aa7df30c8bd8f",
  "branch": "comfydesigner/payment-element-visual-pass",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2106.3159999999925,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.302000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.444,
      "heapDeltaBytes": 5235860,
      "heapUsedBytes": 76986776,
      "domNodes": 18,
      "jsHeapTotalBytes": 19259392,
      "scriptDurationMs": 17.598,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2081.439000000046,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.859000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.215,
      "heapDeltaBytes": 5393984,
      "heapUsedBytes": 76902744,
      "domNodes": 16,
      "jsHeapTotalBytes": 19259392,
      "scriptDurationMs": 18.685,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1925.2459999999587,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.119,
      "layouts": 12,
      "layoutDurationMs": 3.811,
      "taskDurationMs": 963.409,
      "heapDeltaBytes": -20035168,
      "heapUsedBytes": 51372176,
      "domNodes": -294,
      "jsHeapTotalBytes": 20697088,
      "scriptDurationMs": 130.885,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1906.4359999999851,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.753,
      "layouts": 12,
      "layoutDurationMs": 3.5260000000000002,
      "taskDurationMs": 1001.851,
      "heapDeltaBytes": -19576660,
      "heapUsedBytes": 51922672,
      "domNodes": -288,
      "jsHeapTotalBytes": 19386368,
      "scriptDurationMs": 137.493,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1690.0979999999777,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.259999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.694,
      "taskDurationMs": 451.3740000000001,
      "heapDeltaBytes": 8271632,
      "heapUsedBytes": 79929540,
      "domNodes": 78,
      "jsHeapTotalBytes": 19521536,
      "scriptDurationMs": 18.972,
      "eventListeners": 22,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.440000000045,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.705000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.8079999999999999,
      "taskDurationMs": 495.28900000000004,
      "heapDeltaBytes": 8215132,
      "heapUsedBytes": 79989100,
      "domNodes": 79,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 23.88,
      "eventListeners": 22,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 637.4409999999671,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.238000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.32000000000005,
      "heapDeltaBytes": -11445348,
      "heapUsedBytes": 60176496,
      "domNodes": 16,
      "jsHeapTotalBytes": 20307968,
      "scriptDurationMs": 57.891,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 640.1580000000422,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.478000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.69800000000004,
      "heapDeltaBytes": -11193276,
      "heapUsedBytes": 60480808,
      "domNodes": 18,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 58.75,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.4280000000335,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.908000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 765.8129999999999,
      "heapDeltaBytes": 7934620,
      "heapUsedBytes": 70281428,
      "domNodes": -293,
      "jsHeapTotalBytes": 5562368,
      "scriptDurationMs": 100.40700000000001,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2097.323999999958,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.077,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 970.2599999999999,
      "heapDeltaBytes": 1254704,
      "heapUsedBytes": 63618156,
      "domNodes": -295,
      "jsHeapTotalBytes": 4251648,
      "scriptDurationMs": 136.073,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2284.3840000000455,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.591999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1413.518,
      "heapDeltaBytes": 4374576,
      "heapUsedBytes": 67869424,
      "domNodes": -293,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 457.887,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2508.0760000000737,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.961999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1629.2049999999997,
      "heapDeltaBytes": 6250188,
      "heapUsedBytes": 69912080,
      "domNodes": -294,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 534.884,
      "eventListeners": -145,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3346.078000000034,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 14.312000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.395,
      "taskDurationMs": 1650.905,
      "heapDeltaBytes": 5941148,
      "heapUsedBytes": 71053508,
      "domNodes": -302,
      "jsHeapTotalBytes": 7397376,
      "scriptDurationMs": 552.51,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3943.9310000000205,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.643999999999998,
      "layouts": 60,
      "layoutDurationMs": 8.299000000000001,
      "taskDurationMs": 1995.4619999999998,
      "heapDeltaBytes": 6125452,
      "heapUsedBytes": 70948148,
      "domNodes": -297,
      "jsHeapTotalBytes": 6873088,
      "scriptDurationMs": 699.898,
      "eventListeners": -150,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.7860000000205,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.872000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 802.265,
      "heapDeltaBytes": 7871540,
      "heapUsedBytes": 71822808,
      "domNodes": -292,
      "jsHeapTotalBytes": 5300224,
      "scriptDurationMs": 113.04400000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.8000000000184,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.261,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 829.6489999999999,
      "heapDeltaBytes": 8180852,
      "heapUsedBytes": 72386556,
      "domNodes": -293,
      "jsHeapTotalBytes": 5038080,
      "scriptDurationMs": 116.75200000000001,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 647.3100000000045,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.435,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.158,
      "heapDeltaBytes": -10664244,
      "heapUsedBytes": 61111768,
      "domNodes": 20,
      "jsHeapTotalBytes": 20570112,
      "scriptDurationMs": 121.72,
      "eventListeners": 11,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 736.0419999999976,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 11.942000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.155,
      "heapDeltaBytes": -10196388,
      "heapUsedBytes": 61666668,
      "domNodes": 14,
      "jsHeapTotalBytes": 19521536,
      "scriptDurationMs": 132.339,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.3350000000219,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.794000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.7729999999999,
      "heapDeltaBytes": 4902088,
      "heapUsedBytes": 76375104,
      "domNodes": 18,
      "jsHeapTotalBytes": 19783680,
      "scriptDurationMs": 13.979000000000001,
      "eventListeners": 5,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.8119999999826,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.823000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.062,
      "heapDeltaBytes": 3858388,
      "heapUsedBytes": 73744936,
      "domNodes": 16,
      "jsHeapTotalBytes": 20307968,
      "scriptDurationMs": 19.776999999999997,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666674,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1707.3100000000068,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 36.359,
      "layouts": 16,
      "layoutDurationMs": 4.313,
      "taskDurationMs": 845.381,
      "heapDeltaBytes": -3827756,
      "heapUsedBytes": 67585816,
      "domNodes": 62,
      "jsHeapTotalBytes": 19521536,
      "scriptDurationMs": 99.679,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1823.8479999999981,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 44.95100000000001,
      "layouts": 16,
      "layoutDurationMs": 5.021999999999999,
      "taskDurationMs": 984.6429999999999,
      "heapDeltaBytes": -4412284,
      "heapUsedBytes": 67197508,
      "domNodes": 63,
      "jsHeapTotalBytes": 20045824,
      "scriptDurationMs": 112.64800000000001,
      "eventListeners": 7,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.003999999963,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.666,
      "layouts": 14,
      "layoutDurationMs": 13.123000000000003,
      "taskDurationMs": 1009.3349999999999,
      "heapDeltaBytes": 29945756,
      "heapUsedBytes": 103537616,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 36.287,
      "eventListeners": 2369,
      "totalBlockingTimeMs": 151,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8842.443000000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.815,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5157.1720000000005,
      "heapDeltaBytes": 9825508,
      "heapUsedBytes": 72292700,
      "domNodes": -291,
      "jsHeapTotalBytes": 5738496,
      "scriptDurationMs": 1525.765,
      "eventListeners": -159,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9911.735999999906,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 41.065000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5920.785000000001,
      "heapDeltaBytes": 26106920,
      "heapUsedBytes": 88239780,
      "domNodes": -285,
      "jsHeapTotalBytes": 7573504,
      "scriptDurationMs": 1786.378,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18480.330000000038,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18066.587,
      "heapDeltaBytes": -60809084,
      "heapUsedBytes": 169745904,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10948608,
      "scriptDurationMs": 599.491,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18177.27100000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17889.351,
      "heapDeltaBytes": -60359272,
      "heapUsedBytes": 170177128,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10424320,
      "scriptDurationMs": 697.02,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22295.14700000004,
      "styleRecalcs": 172,
      "styleRecalcDurationMs": 21.430000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22114.275999999998,
      "heapDeltaBytes": -35968656,
      "heapUsedBytes": 180246304,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10219520,
      "scriptDurationMs": 1034.701,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 452,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22850.740999999973,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 23.343999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22558.502,
      "heapDeltaBytes": -34265220,
      "heapUsedBytes": 181557772,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14413824,
      "scriptDurationMs": 1075.589,
      "eventListeners": -16383,
      "totalBlockingTimeMs": 501,
      "frameDurationMs": 18.886666666666738,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 523.9439999999718,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 33.135999999999996,
      "layouts": 3,
      "layoutDurationMs": 0.655,
      "taskDurationMs": 165.723,
      "heapDeltaBytes": -16185560,
      "heapUsedBytes": 54496676,
      "domNodes": 126,
      "jsHeapTotalBytes": 7462912,
      "scriptDurationMs": 12.312999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 497.19600000003084,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 18.568,
      "layouts": 3,
      "layoutDurationMs": 1.3679999999999999,
      "taskDurationMs": 121.755,
      "heapDeltaBytes": -16014696,
      "heapUsedBytes": 54783416,
      "domNodes": 141,
      "jsHeapTotalBytes": 6938624,
      "scriptDurationMs": 9.196000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Aug 25, 2026
## Summary

Consolidates the complete embedded subscription checkout frontend onto
current `main` as the single review tip, including the design stack,
safety gates, exact quote contract UI, saved methods, and 3DS recovery.

## Changes

- **What**: Replays and reconciles the frontend work from Comfy-Org#14447,
Comfy-Org#14449, Comfy-Org#14476, and Comfy-Org#14482 without modifying those provenance PRs or
branches.
- **Dependencies**: Requires the combined backend environment for
end-to-end preview validation.

## Review Focus

Review exact quote freshness, reactivation safeguards, saved-method
confirmation, and retryable/reconciliation 3DS states together.

Checks run locally: typecheck, browser fixture typecheck, format,
lint/oxlint, knip, 231 billing-focused Vitest tests, and cloud
Playwright test discovery.

## Screenshots (if applicable)

AS IS / TO BE screenshots and preview will be attached after the
combined environment exists.

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfydesigner

Copy link
Copy Markdown
Contributor Author

Closing — this landed via #14483 rather than being superseded by it.

Verified against current main:

  • SubscriptionAddPaymentPreviewWorkspace has the edge-to-edge split verbatim: xl:w-[42%] xl:shrink-0 xl:border-r on the summary panel, xl:flex-row on the root, xl:px-16 on the form column, and the max-xl:-mx-4 vertical treatment below xl. The explanatory comment from this branch is there too.
  • UnifiedStripePaymentSelector matches: root is flex min-h-0 flex-col gap-6 xl:flex-1, the form region carries xl:min-h-0 xl:flex-1 xl:overflow-x-hidden xl:overflow-y-auto xl:pr-1, and the card chrome and credit-card icon block this PR removed are gone.
  • Sampling the added lines across SubscriptionSuccessWorkspace, SubscriptionRequiredDialogContentUnified, and SubscriptionAddPaymentPreviewWorkspace: 31 of 36 already present.

A rebase would leave a near-empty diff behind about a dozen conflicts, since the branch still carries the pre-consolidation stack. Not worth it.

Thanks @hunter-gits for carrying the visual pass forward in the consolidation.

huntcsg added a commit that referenced this pull request Aug 25, 2026
Consolidates the complete embedded subscription checkout frontend onto
current `main` as the single review tip, including the design stack,
safety gates, exact quote contract UI, saved methods, and 3DS recovery.

- **What**: Replays and reconciles the frontend work from #14447,
branches.
- **Dependencies**: Requires the combined backend environment for
end-to-end preview validation.

Review exact quote freshness, reactivation safeguards, saved-method
confirmation, and retryable/reconciliation 3DS states together.

Checks run locally: typecheck, browser fixture typecheck, format,
lint/oxlint, knip, 231 billing-focused Vitest tests, and cloud
Playwright test discovery.

AS IS / TO BE screenshots and preview will be attached after the
combined environment exists.

---------

Co-authored-by: Amp <amp@ampcode.com>
huntcsg added a commit that referenced this pull request Aug 25, 2026
Consolidates the complete embedded subscription checkout frontend onto
current `main` as the single review tip, including the design stack,
safety gates, exact quote contract UI, saved methods, and 3DS recovery.

- **What**: Replays and reconciles the frontend work from #14447,
branches.
- **Dependencies**: Requires the combined backend environment for
end-to-end preview validation.

Review exact quote freshness, reactivation safeguards, saved-method
confirmation, and retryable/reconciliation 3DS states together.

Checks run locally: typecheck, browser fixture typecheck, format,
lint/oxlint, knip, 231 billing-focused Vitest tests, and cloud
Playwright test discovery.

AS IS / TO BE screenshots and preview will be attached after the
combined environment exists.

---------

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant