Repository navigation
Conversation
Replace the static careers hero image with the new brand video via the existing SiteVideo component (autoplay/loop/muted, poster fallback). Covers /careers and /zh-CN/careers, which share the component. Assets are hosted on the media.comfy.org CDN under website/careers/. Adopting SiteVideo makes it and video.ts's VideoFormat genuinely used, so drop their now-stale stacked-PR knip ignore markers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🌐 Website E2ETip All tests passed.
🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-14416.vercel.app This commit: https://website-frontend-abdyurhl0-comfyui.vercel.app Last updated: 2026-07-30T21:04:57Z for |
🎭 Playwright: ✅ 1769 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 8.17 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.62 kB (baseline 3.62 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.29 MB (baseline 1.29 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 111 kB (baseline 111 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 552 kB (baseline 552 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 28.7 kB (baseline 28.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 70 kB (baseline 70 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.43 MB (baseline 3.43 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 385 kB (baseline 385 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.6 MB (baseline 12.6 MB) • ⚪ 0 BBundles that do not match a named category Status: 278 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-30T21:17:22.354Z",
"gitSha": "5562c19c77c60cf326c34a29118c3b204a4254c5",
"branch": "claude/website-editing-capabilities-211a43",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2233.701999999994,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.669999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.3199999999999,
"heapDeltaBytes": -20927556,
"heapUsedBytes": 46907732,
"domNodes": -279,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 24.508,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.5890000000213,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.017999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.829,
"heapDeltaBytes": 4755284,
"heapUsedBytes": 72495260,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 19.589,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.3279999999913,
"styleRecalcs": 73,
"styleRecalcDurationMs": 37.415000000000006,
"layouts": 12,
"layoutDurationMs": 3.595,
"taskDurationMs": 928.5580000000001,
"heapDeltaBytes": -13927612,
"heapUsedBytes": 53905104,
"domNodes": -281,
"jsHeapTotalBytes": 22798336,
"scriptDurationMs": 120.75700000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.4379999999874,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.46,
"layouts": 12,
"layoutDurationMs": 3.663,
"taskDurationMs": 903.241,
"heapDeltaBytes": -14805708,
"heapUsedBytes": 53073376,
"domNodes": -280,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 118.12899999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.9530000000473,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.435000000000002,
"layouts": 6,
"layoutDurationMs": 0.6219999999999999,
"taskDurationMs": 403.362,
"heapDeltaBytes": 7966076,
"heapUsedBytes": 75761680,
"domNodes": 75,
"jsHeapTotalBytes": 19787776,
"scriptDurationMs": 20.462999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.7469999999757,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.495000000000005,
"layouts": 6,
"layoutDurationMs": 0.675,
"taskDurationMs": 407.7,
"heapDeltaBytes": 7848364,
"heapUsedBytes": 75738192,
"domNodes": 77,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 21.493,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 622.0210000000179,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.5680000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.0439999999999,
"heapDeltaBytes": -11999944,
"heapUsedBytes": 56020792,
"domNodes": 18,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 59.342000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 644.2530000000488,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.123999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.471,
"heapDeltaBytes": -12217380,
"heapUsedBytes": 55741224,
"domNodes": 18,
"jsHeapTotalBytes": 22409216,
"scriptDurationMs": 58.105999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2058.885000000032,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.618,
"heapDeltaBytes": 7903856,
"heapUsedBytes": 67339924,
"domNodes": -282,
"jsHeapTotalBytes": 5828608,
"scriptDurationMs": 115.59,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2068.489999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.771,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 778.8629999999998,
"heapDeltaBytes": 8434544,
"heapUsedBytes": 67355756,
"domNodes": -283,
"jsHeapTotalBytes": 5828608,
"scriptDurationMs": 123.16199999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2153.51000000004,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.284,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1301.033,
"heapDeltaBytes": 4724008,
"heapUsedBytes": 65663772,
"domNodes": -285,
"jsHeapTotalBytes": 4743168,
"scriptDurationMs": 415.32800000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2165.9989999999425,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1272.301,
"heapDeltaBytes": 4352932,
"heapUsedBytes": 64818660,
"domNodes": -283,
"jsHeapTotalBytes": 5005312,
"scriptDurationMs": 412.13100000000003,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3195.7350000000133,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.607000000000001,
"layouts": 60,
"layoutDurationMs": 8.055000000000001,
"taskDurationMs": 1539.307,
"heapDeltaBytes": -2166620,
"heapUsedBytes": 59414884,
"domNodes": -289,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 544.993,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3243.8529999999446,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.977,
"layouts": 60,
"layoutDurationMs": 8.489999999999998,
"taskDurationMs": 1549.9389999999999,
"heapDeltaBytes": 303064,
"heapUsedBytes": 61540172,
"domNodes": -286,
"jsHeapTotalBytes": 7925760,
"scriptDurationMs": 543.1469999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.9299999999935,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.9739999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 746.3299999999999,
"heapDeltaBytes": 7940020,
"heapUsedBytes": 68204192,
"domNodes": -283,
"jsHeapTotalBytes": 4255744,
"scriptDurationMs": 114.15700000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.6539999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.100000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 752.5200000000001,
"heapDeltaBytes": 8357776,
"heapUsedBytes": 69214508,
"domNodes": -285,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 112.318,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.6329999999934,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.225999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.272,
"heapDeltaBytes": -11649576,
"heapUsedBytes": 56196820,
"domNodes": 20,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 123.96600000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.1709999999948,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.534999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.606,
"heapDeltaBytes": -12115160,
"heapUsedBytes": 56166568,
"domNodes": 20,
"jsHeapTotalBytes": 21622784,
"scriptDurationMs": 124.886,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.79000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.513,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 535.326,
"heapDeltaBytes": 4711424,
"heapUsedBytes": 72672252,
"domNodes": 20,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 18.559999999999995,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2008.5050000000138,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.169999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.5430000000001,
"heapDeltaBytes": 4374148,
"heapUsedBytes": 72277172,
"domNodes": 18,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 15.817000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.9160000000134,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.61,
"layouts": 16,
"layoutDurationMs": 4.574999999999999,
"taskDurationMs": 841.825,
"heapDeltaBytes": -17241584,
"heapUsedBytes": 50737524,
"domNodes": -282,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 97.914,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.6169999999656,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.379,
"layouts": 16,
"layoutDurationMs": 4.594,
"taskDurationMs": 817.323,
"heapDeltaBytes": -4595396,
"heapUsedBytes": 63359980,
"domNodes": 67,
"jsHeapTotalBytes": 20836352,
"scriptDurationMs": 95.01700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.9199999999655,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.344999999999995,
"layouts": 13,
"layoutDurationMs": 11.210999999999999,
"taskDurationMs": 963.7190000000002,
"heapDeltaBytes": 32922960,
"heapUsedBytes": 99520308,
"domNodes": 13673,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 35.76,
"eventListeners": 2371,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8214.119000000039,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.873999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4468.697999999999,
"heapDeltaBytes": 10471776,
"heapUsedBytes": 69498332,
"domNodes": -282,
"jsHeapTotalBytes": 6840320,
"scriptDurationMs": 1352.3890000000001,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8285.660000000007,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.519,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4527.200000000001,
"heapDeltaBytes": 6942944,
"heapUsedBytes": 66260848,
"domNodes": -282,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 1370.192,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18360.50499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18326.016000000003,
"heapDeltaBytes": -56290136,
"heapUsedBytes": 167854060,
"domNodes": -8312,
"jsHeapTotalBytes": -9637888,
"scriptDurationMs": 554.5169999999999,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18116.918000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18093.858999999997,
"heapDeltaBytes": -39754692,
"heapUsedBytes": 168883916,
"domNodes": -8312,
"jsHeapTotalBytes": -11214848,
"scriptDurationMs": 597.2299999999999,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22568.00400000003,
"styleRecalcs": 165,
"styleRecalcDurationMs": 24.260000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22518.594999999998,
"heapDeltaBytes": -57429916,
"heapUsedBytes": 169039048,
"domNodes": -8312,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 919.9989999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 634,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16849.751000000084,
"styleRecalcs": 113,
"styleRecalcDurationMs": 17.33600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16820.578,
"heapDeltaBytes": -50324260,
"heapUsedBytes": 177429860,
"domNodes": -8312,
"jsHeapTotalBytes": -13905920,
"scriptDurationMs": 930.5250000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 463.36500000001024,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.667999999999996,
"layouts": 2,
"layoutDurationMs": 0.43499999999999983,
"taskDurationMs": 116.33300000000001,
"heapDeltaBytes": -15831140,
"heapUsedBytes": 51076700,
"domNodes": 130,
"jsHeapTotalBytes": 7204864,
"scriptDurationMs": 10.31,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 119.3269999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 15.095,
"layouts": 3,
"layoutDurationMs": 0.8140000000000001,
"taskDurationMs": 81.12299999999999,
"heapDeltaBytes": 3015020,
"heapUsedBytes": 70093356,
"domNodes": 110,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 7.206,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe careers hero replaces its static image with ChangesCareers hero video
Estimated code review effort: 2 (Simple) | ~10 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
A reactive-props-destructure default that references another prop (`muted = autoplay`, `preload = autoplay ? ...`) compiles to a default factory with an unscoped `autoplay` reference, throwing `ReferenceError: autoplay is not defined` during SSR prerender. SiteVideo had no adopters until the careers hero, so this surfaced only now and broke the build. Resolve both values with computed refs instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/website/src/components/careers/HeroSection.vue`:
- Around line 25-35: Update the SiteVideo instance in HeroSection to provide
users an accessible way to pause or stop the autoplaying loop by enabling its
controls or using an equivalent pause mechanism. If the video is decorative,
also remove its alt text so it is not announced by assistive technology.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 8b91fd80-14e3-4511-982b-2b20525f1359
📒 Files selected for processing (3)
apps/website/src/components/careers/HeroSection.vueapps/website/src/utils/video.tsknip.config.ts
💤 Files with no reviewable changes (2)
- apps/website/src/utils/video.ts
- knip.config.ts
Provide a pause/stop mechanism for the autoplaying looping hero video (WCAG 2.2.2). The hero renders as static HTML with no client JS, so native controls are the zero-JS way to let users stop the motion. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14416 +/- ##
==========================================
- Coverage 78.89% 77.62% -1.27%
==========================================
Files 1689 1760 +71
Lines 94940 104661 +9721
Branches 33889 37723 +3834
==========================================
+ Hits 74903 81248 +6345
- Misses 19664 22936 +3272
- Partials 373 477 +104
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Thank you for adding the careers hero video and for addressing the autoplay accessibility concern. Your newer #15390 implements the same change against current main with the shared VideoPlayer, localized accessible controls, reduced-motion handling, audio support, and tests, so it supersedes this version. Please continue the work in #15390, or open a fresh PR against current main if that implementation also needs to change. |
Summary
Replace the static careers hero image with the new brand video, using the existing
SiteVideocomponent.Changes
<img>incareers/HeroSection.vueforSiteVideo(autoplay/loop/muted,hero-poster.jpgfallback). This covers both/careersand/zh-CN/careers, which share the component. Also drops the now-stale@knipIgnoreUsedByStackedPRmarker onvideo.ts'sVideoFormatand removesSiteVideo.vuefrom the knip ignore list, since adopting the component makes both genuinely used.Review Focus
media.comfy.org/website/careers/(hero-1280.webm,hero-1280.mp4,hero-poster.jpg), generated viaapps/website/scripts/process-videos.sh. They are already uploaded and serving publicly, so the hero renders on merge.Screenshots (if applicable)
Hero now plays the looping video in place of the previous still image.