Skip to content

[backport cloud/1.48] fix: isolate drafts during workspace auth recovery - #14319

Merged
comfy-pr-bot merged 2 commits into
cloud/1.48from
backport-14306-to-cloud-1.48
Jul 30, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.48from
backport-14306-to-cloud-1.48

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #14306 to cloud/1.48

Automatically created by backport workflow.

## Summary

Follow-up to #14290 and [review
#4813556736](#14290 (review)):
closes the remaining draft-isolation holes in runtime auth recovery and
`unified_cloud_auth` workspace scoping.

The latest staging reproduction is captured in [this Slack
report](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785370090022269?thread_ts=1785169746.169899&cid=C0932CGKT5K).
Staging currently contains the #14290 backport, but not this follow-up.

## Root cause

There were two independent gaps:

1. Runtime auth recovery cleared `currentWorkspace` before workflow
persistence crossed the terminal transition boundary. A pending
team-workspace save could flush after scope resolution fell back to
`personal`, and expiry paths could leave the mounted editor persisting
under that scope. One throwing flush callback could also skip later
callbacks, the write fence, and restore-state cleanup.
2. Under `unified_cloud_auth`, successful token minting populated only
`unifiedToken`; it did not populate or persist the workspace identity.
Workflow persistence derives its draft/tab namespace from
`Comfy.Workspace.Current`, so every team workspace fell back to the
shared `personal` namespace even during a normal workspace session.

The review's initialization concern remains intentionally unchanged:
`WorkspaceAuthGate` keeps the routed editor unmounted until
initialization finishes, so no persistence debounce exists during
startup fallback. Installing a terminal fence there without a reload
would permanently block workflow writes.

## Reproduction

1. Enable `unified_cloud_auth` and open workspace A.
2. Open multiple workflow tabs and make an unsaved edit.
3. Switch to workspace B and wait for the reload.
4. Observe workspace A's tabs/active workflow/draft restored in
workspace B.
5. Edit in B and switch back to A; B's state can now replace or appear
alongside A's state.

**AS IS:** both workspaces resolve workflow persistence to
`Comfy.Workflow.*:personal`, so drafts and restore pointers are shared.

**TO BE:** each successful unified mint commits the response workspace
identity before the editor mounts or resumes. Workspace A and B resolve
distinct draft/index/restore namespaces; terminal auth failure flushes
and fences the source workspace before identity is cleared and the page
reloads.

## Changes

- Flush and fence workflow persistence while the source workspace
identity is still active, then clear auth context and reload for
terminal runtime recovery paths.
- Keep revoked-workspace handling ordered before auth context removal
and report whether it already requested reload.
- Make transition flush callbacks independent and the transition
boundary idempotent.
- Persist the authoritative workspace returned by unified token minting
without writing unified credentials into the legacy token slots.
- Clear stale workspace identity before a unified switch and route
permanent unified refresh/re-mint failures through the same terminal
persistence boundary.

## Review focus

Confirm:

- unified workspace A and B resolve distinct workflow persistence keys;
- unified credentials remain separate from legacy workspace token
storage;
- runtime recovery ordering is source flush → write fence →
revoked-workspace handling → auth clear → reload;
- startup initialization remains unchanged.

## Screenshots and recordings

- [AS IS
screenshot](https://ampcode.com/user-content/artifacts/5de321d78b00b1b147cbd0bdae37d8f4957ed65dba9e542d5da1c49d842bb441-file.png)
and [reproduction
GIF](https://ampcode.com/user-content/artifacts/6b84ba3dd1a98b1dbcae0df5ec7579d7501fe748b04fd391bd3f12d401ec6468-file.gif)
- [TO BE
screenshot](https://ampcode.com/user-content/artifacts/f5a4c0b0ddca66b9a5eb72dac19f296d1d65e341f58277890d376b2788b90693-file.png)
and [verification
GIF](https://ampcode.com/user-content/artifacts/a6cef058cfd29cbeec913fd3369adc3373ab730f861a37854d44bf4acb96f97a-file.gif)
- [Latest staging AS IS
recording](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785370090022269?thread_ts=1785169746.169899&cid=C0932CGKT5K)

## Red → Green proof

The unified workspace-scoping regression test was run unchanged before
and after the fix:

- **RED:** unified switch completed, but `currentWorkspace` was `null`;
persistence resolved to `personal` instead of `workspace-123`.
- **GREEN:** sequential unified switches resolve
`Comfy.Workflow.DraftIndex.v2:workspace-123` and
`Comfy.Workflow.DraftIndex.v2:workspace-456`, while legacy token storage
remains empty.

The earlier runtime recovery tests also prove RED → GREEN for revocation
ordering, expiry fencing/reload, and exception-safe persistence cleanup.

## Verification

- `useWorkspaceAuth.test.ts`: 93 passed
- `teamWorkspaceStore.test.ts`: 78 passed
- `storageIO.test.ts`: 24 passed
- `storageKeys.test.ts`: 12 passed
- `useWorkflowPersistenceV2.test.ts`: 20 passed
- `vue-tsc --noEmit`
- ESLint and oxfmt on changed files
- `git diff --check`

Staging remains expected to reproduce until this PR is merged,
backported to Cloud 1.48, deployed, and the workspace A → B → A flow is
reverified there.

---------

Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com>
Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jul 30, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) July 30, 2026 02:06
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 30, 2026
@dosubot

dosubot Bot commented Jul 30, 2026

Copy link
Copy Markdown

📄 Knowledge review

Dosu skipped reviewing this PR because your organization has used its 200 included credits for the month. Your usage will reset on 2026-08-01. To have Dosu review this PR before then, ask your organization admin to upgrade to a pro account.


Leave Feedback Ask Dosu about ComfyUI_frontend Add Dosu to your team

@github-actions

github-actions Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/30/2026, 02:38:42 AM UTC

Links

🎭 Playwright: ✅ 1738 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1717 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 135ms TBT · 92.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 158.8 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 417ms TBT · 152.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 529ms
canvas-idle: script duration 21ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.6 MB
canvas-idle: DOM nodes 18
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 48ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 982ms
canvas-mouse-sweep: script duration 135ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 48.2 MB
canvas-mouse-sweep: DOM nodes -273
canvas-mouse-sweep: event listeners -148
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 404ms
canvas-zoom-sweep: script duration 23ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 380ms
dom-widget-clipping: script duration 60ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 53.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 708ms
large-graph-idle: script duration 117ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 61.7 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -143
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1319ms
large-graph-pan: script duration 443ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 62.2 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners -143
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 15ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1539ms
large-graph-zoom: script duration 544ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.0 MB
large-graph-zoom: DOM nodes -135
large-graph-zoom: event listeners -70
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 9ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 720ms
minimap-idle: script duration 117ms
minimap-idle: TBT 0ms
minimap-idle: heap used 64.4 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -145
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 408ms
subgraph-dom-widget-clipping: script duration 120ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 53.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 514ms
subgraph-idle: script duration 17ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 56.0 MB
subgraph-idle: DOM nodes -128
subgraph-idle: event listeners -72
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 37ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 787ms
subgraph-mouse-sweep: script duration 93ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 51.4 MB
subgraph-mouse-sweep: DOM nodes 64
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 961ms
subgraph-transition-enter: script duration 38ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 92.8 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2371
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 4711ms
viewport-pan-sweep: script duration 1472ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 66.7 MB
viewport-pan-sweep: DOM nodes -276
viewport-pan-sweep: event listeners -126
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17362ms
vue-large-graph-idle: script duration 571ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 158.8 MB
vue-large-graph-idle: DOM nodes -8312
vue-large-graph-idle: event listeners -16387
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 152
vue-large-graph-pan: task duration 21344ms
vue-large-graph-pan: script duration 953ms
vue-large-graph-pan: TBT 417ms
vue-large-graph-pan: heap used 152.7 MB
vue-large-graph-pan: DOM nodes -8314
vue-large-graph-pan: event listeners -16382
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 0ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 2
workflow-execution: style recalc count 13
workflow-execution: task duration 110ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 48.8 MB
workflow-execution: DOM nodes 123
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-07-30T02:49:16.867Z",
  "gitSha": "71a4fb72b0e6a8fe41d0554411bf90a4a40aeaf2",
  "branch": "backport-14306-to-cloud-1.48",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2066.3640000000214,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.415000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 573.1160000000001,
      "heapDeltaBytes": 3975404,
      "heapUsedBytes": 71893832,
      "domNodes": 18,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 22.282000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2030.2319999999554,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.157999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.3660000000001,
      "heapDeltaBytes": 3973764,
      "heapUsedBytes": 71904996,
      "domNodes": 18,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 19.002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2058.047999999985,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 52.97599999999999,
      "layouts": 12,
      "layoutDurationMs": 4.059,
      "taskDurationMs": 1048.078,
      "heapDeltaBytes": -15785712,
      "heapUsedBytes": 52054168,
      "domNodes": -273,
      "jsHeapTotalBytes": 22016000,
      "scriptDurationMs": 143.16899999999998,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.3069999999916,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.639,
      "layouts": 12,
      "layoutDurationMs": 3.867,
      "taskDurationMs": 915.2439999999999,
      "heapDeltaBytes": -18778056,
      "heapUsedBytes": 49005484,
      "domNodes": -273,
      "jsHeapTotalBytes": 20705280,
      "scriptDurationMs": 126.723,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1761.2430000000359,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.205999999999996,
      "layouts": 6,
      "layoutDurationMs": 0.65,
      "taskDurationMs": 414.03800000000007,
      "heapDeltaBytes": 7315412,
      "heapUsedBytes": 75227608,
      "domNodes": 75,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 23.678,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.8540000000603,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.097,
      "layouts": 6,
      "layoutDurationMs": 0.7010000000000001,
      "taskDurationMs": 393.24399999999997,
      "heapDeltaBytes": 7385712,
      "heapUsedBytes": 75219488,
      "domNodes": 78,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 21.517000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 560.7339999999681,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.731,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.032,
      "heapDeltaBytes": -12073380,
      "heapUsedBytes": 55836064,
      "domNodes": 18,
      "jsHeapTotalBytes": 21102592,
      "scriptDurationMs": 58.89999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 603.8389999999936,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.626999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 383.396,
      "heapDeltaBytes": -12360228,
      "heapUsedBytes": 55591572,
      "domNodes": 16,
      "jsHeapTotalBytes": 21889024,
      "scriptDurationMs": 60.81400000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.517000000004,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.671999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 722.7610000000001,
      "heapDeltaBytes": 6588844,
      "heapUsedBytes": 65202724,
      "domNodes": -275,
      "jsHeapTotalBytes": 5832704,
      "scriptDurationMs": 121.04099999999998,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2014.3360000000712,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.522,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 693.9950000000001,
      "heapDeltaBytes": 4253728,
      "heapUsedBytes": 64220892,
      "domNodes": -276,
      "jsHeapTotalBytes": 5308416,
      "scriptDurationMs": 113.143,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2213.9810000000466,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 14.957999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1327.1399999999999,
      "heapDeltaBytes": 5860168,
      "heapUsedBytes": 65433624,
      "domNodes": -278,
      "jsHeapTotalBytes": 4202496,
      "scriptDurationMs": 449.19100000000003,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2171.2760000000344,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.084999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1310.4530000000002,
      "heapDeltaBytes": 4309404,
      "heapUsedBytes": 64932020,
      "domNodes": -280,
      "jsHeapTotalBytes": 6037504,
      "scriptDurationMs": 437.358,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3197.293000000002,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.847,
      "layouts": 60,
      "layoutDurationMs": 7.309000000000001,
      "taskDurationMs": 1511.8590000000002,
      "heapDeltaBytes": 23046848,
      "heapUsedBytes": 84419960,
      "domNodes": 14,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 545.466,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3210.1699999999482,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 14.133999999999997,
      "layouts": 60,
      "layoutDurationMs": 7.425999999999999,
      "taskDurationMs": 1566.7689999999998,
      "heapDeltaBytes": -1093052,
      "heapUsedBytes": 60347360,
      "domNodes": -283,
      "jsHeapTotalBytes": 8192000,
      "scriptDurationMs": 542.307,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.4030000000353,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.735000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 742.0600000000001,
      "heapDeltaBytes": 6663028,
      "heapUsedBytes": 67557884,
      "domNodes": -275,
      "jsHeapTotalBytes": 4784128,
      "scriptDurationMs": 122.071,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.7950000000355,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.561999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 697.217,
      "heapDeltaBytes": 6906344,
      "heapUsedBytes": 67422492,
      "domNodes": -277,
      "jsHeapTotalBytes": 3997696,
      "scriptDurationMs": 112.85199999999999,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 584.7299999999791,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.682999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 405.45200000000006,
      "heapDeltaBytes": -11719196,
      "heapUsedBytes": 56209000,
      "domNodes": 20,
      "jsHeapTotalBytes": 21626880,
      "scriptDurationMs": 119.47200000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.7620000000734,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.98199999999997,
      "heapDeltaBytes": -12054400,
      "heapUsedBytes": 55777828,
      "domNodes": 20,
      "jsHeapTotalBytes": 21889024,
      "scriptDurationMs": 121.218,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.3609999999794,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.277,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.88200000000006,
      "heapDeltaBytes": 3746632,
      "heapUsedBytes": 71793660,
      "domNodes": 18,
      "jsHeapTotalBytes": 20578304,
      "scriptDurationMs": 16.471,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.4130000000714,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.994999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.8050000000001,
      "heapDeltaBytes": -22227588,
      "heapUsedBytes": 45681164,
      "domNodes": -273,
      "jsHeapTotalBytes": 20705280,
      "scriptDurationMs": 16.659999999999997,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.5050000000124,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 37.065,
      "layouts": 16,
      "layoutDurationMs": 4.018,
      "taskDurationMs": 827.519,
      "heapDeltaBytes": -22446500,
      "heapUsedBytes": 45563700,
      "domNodes": 63,
      "jsHeapTotalBytes": 20705280,
      "scriptDurationMs": 95.33699999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1680.1600000000008,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.416999999999994,
      "layouts": 16,
      "layoutDurationMs": 3.7860000000000005,
      "taskDurationMs": 745.501,
      "heapDeltaBytes": -5585236,
      "heapUsedBytes": 62303700,
      "domNodes": 65,
      "jsHeapTotalBytes": 21364736,
      "scriptDurationMs": 90.67199999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.044000000013,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 30.300999999999995,
      "layouts": 14,
      "layoutDurationMs": 12.793,
      "taskDurationMs": 961.387,
      "heapDeltaBytes": 5217272,
      "heapUsedBytes": 97309616,
      "domNodes": 13673,
      "jsHeapTotalBytes": 13631488,
      "scriptDurationMs": 38.181000000000004,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8606.59099999998,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 38.038000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4811.856000000001,
      "heapDeltaBytes": 10546436,
      "heapUsedBytes": 70312800,
      "domNodes": -276,
      "jsHeapTotalBytes": 8105984,
      "scriptDurationMs": 1530.6299999999999,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8399.15600000006,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.435,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4609.53,
      "heapDeltaBytes": 10336548,
      "heapUsedBytes": 69559276,
      "domNodes": -276,
      "jsHeapTotalBytes": 7057408,
      "scriptDurationMs": 1414.1709999999998,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17353.755000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17339.116,
      "heapDeltaBytes": -41799996,
      "heapUsedBytes": 166520596,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14618624,
      "scriptDurationMs": 551.7449999999999,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17434.428000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17384.971,
      "heapDeltaBytes": -61505420,
      "heapUsedBytes": 166473668,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13307904,
      "scriptDurationMs": 591.109,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21012.163000000044,
      "styleRecalcs": 146,
      "styleRecalcDurationMs": 19.030000000000047,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20983.689,
      "heapDeltaBytes": -53135588,
      "heapUsedBytes": 165912448,
      "domNodes": -8316,
      "jsHeapTotalBytes": -13045760,
      "scriptDurationMs": 915.1870000000001,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 304,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21735.765000000014,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 21.531999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21704.815,
      "heapDeltaBytes": -57508912,
      "heapUsedBytes": 154244940,
      "domNodes": -8312,
      "jsHeapTotalBytes": -10424320,
      "scriptDurationMs": 991.318,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 529,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 448.6519999999814,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 20.963999999999995,
      "layouts": 2,
      "layoutDurationMs": 0.30999999999999994,
      "taskDurationMs": 114.60399999999998,
      "heapDeltaBytes": -15776196,
      "heapUsedBytes": 51338860,
      "domNodes": 130,
      "jsHeapTotalBytes": 7208960,
      "scriptDurationMs": 10.081,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 462.5670000000355,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 16.579000000000004,
      "layouts": 2,
      "layoutDurationMs": 0.3939999999999998,
      "taskDurationMs": 105.544,
      "heapDeltaBytes": -16245192,
      "heapUsedBytes": 50982504,
      "domNodes": 115,
      "jsHeapTotalBytes": 7471104,
      "scriptDurationMs": 10.067000000000002,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@codecov

codecov Bot commented Jul 30, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...rc/platform/workspace/stores/workspaceAuthStore.ts 82.92% 6 Missing and 1 partial ⚠️
@@              Coverage Diff              @@
##             cloud/1.48   #14319   +/-   ##
=============================================
  Coverage              ?   79.24%           
=============================================
  Files                 ?     1744           
  Lines                 ?    99006           
  Branches              ?    32468           
=============================================
  Hits                  ?    78453           
  Misses                ?    20153           
  Partials              ?      400           
Flag Coverage Δ
unit 68.95% <86.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/platform/workflow/persistence/base/storageIO.ts 92.19% <100.00%> (ø)
...rc/platform/workspace/stores/teamWorkspaceStore.ts 66.99% <100.00%> (ø)
...rc/platform/workspace/stores/workspaceAuthStore.ts 88.39% <82.92%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit 8a27c75 into cloud/1.48 Jul 30, 2026
81 of 83 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-14306-to-cloud-1.48 branch July 30, 2026 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants