Repository navigation
[backport core/1.48] fix: isolate drafts during workspace auth recovery - #14318
comfy-pr-bot wants to merge 1 commit into
Conversation
## Summary Follow-up to #14290 and [review #4813556736](#14290 (review)): closes the remaining draft-isolation holes in runtime auth recovery and `unified_cloud_auth` workspace scoping. The latest staging reproduction is captured in [this Slack report](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785370090022269?thread_ts=1785169746.169899&cid=C0932CGKT5K). Staging currently contains the #14290 backport, but not this follow-up. ## Root cause There were two independent gaps: 1. Runtime auth recovery cleared `currentWorkspace` before workflow persistence crossed the terminal transition boundary. A pending team-workspace save could flush after scope resolution fell back to `personal`, and expiry paths could leave the mounted editor persisting under that scope. One throwing flush callback could also skip later callbacks, the write fence, and restore-state cleanup. 2. Under `unified_cloud_auth`, successful token minting populated only `unifiedToken`; it did not populate or persist the workspace identity. Workflow persistence derives its draft/tab namespace from `Comfy.Workspace.Current`, so every team workspace fell back to the shared `personal` namespace even during a normal workspace session. The review's initialization concern remains intentionally unchanged: `WorkspaceAuthGate` keeps the routed editor unmounted until initialization finishes, so no persistence debounce exists during startup fallback. Installing a terminal fence there without a reload would permanently block workflow writes. ## Reproduction 1. Enable `unified_cloud_auth` and open workspace A. 2. Open multiple workflow tabs and make an unsaved edit. 3. Switch to workspace B and wait for the reload. 4. Observe workspace A's tabs/active workflow/draft restored in workspace B. 5. Edit in B and switch back to A; B's state can now replace or appear alongside A's state. **AS IS:** both workspaces resolve workflow persistence to `Comfy.Workflow.*:personal`, so drafts and restore pointers are shared. **TO BE:** each successful unified mint commits the response workspace identity before the editor mounts or resumes. Workspace A and B resolve distinct draft/index/restore namespaces; terminal auth failure flushes and fences the source workspace before identity is cleared and the page reloads. ## Changes - Flush and fence workflow persistence while the source workspace identity is still active, then clear auth context and reload for terminal runtime recovery paths. - Keep revoked-workspace handling ordered before auth context removal and report whether it already requested reload. - Make transition flush callbacks independent and the transition boundary idempotent. - Persist the authoritative workspace returned by unified token minting without writing unified credentials into the legacy token slots. - Clear stale workspace identity before a unified switch and route permanent unified refresh/re-mint failures through the same terminal persistence boundary. ## Review focus Confirm: - unified workspace A and B resolve distinct workflow persistence keys; - unified credentials remain separate from legacy workspace token storage; - runtime recovery ordering is source flush → write fence → revoked-workspace handling → auth clear → reload; - startup initialization remains unchanged. ## Screenshots and recordings - [AS IS screenshot](https://ampcode.com/user-content/artifacts/5de321d78b00b1b147cbd0bdae37d8f4957ed65dba9e542d5da1c49d842bb441-file.png) and [reproduction GIF](https://ampcode.com/user-content/artifacts/6b84ba3dd1a98b1dbcae0df5ec7579d7501fe748b04fd391bd3f12d401ec6468-file.gif) - [TO BE screenshot](https://ampcode.com/user-content/artifacts/f5a4c0b0ddca66b9a5eb72dac19f296d1d65e341f58277890d376b2788b90693-file.png) and [verification GIF](https://ampcode.com/user-content/artifacts/a6cef058cfd29cbeec913fd3369adc3373ab730f861a37854d44bf4acb96f97a-file.gif) - [Latest staging AS IS recording](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785370090022269?thread_ts=1785169746.169899&cid=C0932CGKT5K) ## Red → Green proof The unified workspace-scoping regression test was run unchanged before and after the fix: - **RED:** unified switch completed, but `currentWorkspace` was `null`; persistence resolved to `personal` instead of `workspace-123`. - **GREEN:** sequential unified switches resolve `Comfy.Workflow.DraftIndex.v2:workspace-123` and `Comfy.Workflow.DraftIndex.v2:workspace-456`, while legacy token storage remains empty. The earlier runtime recovery tests also prove RED → GREEN for revocation ordering, expiry fencing/reload, and exception-safe persistence cleanup. ## Verification - `useWorkspaceAuth.test.ts`: 93 passed - `teamWorkspaceStore.test.ts`: 78 passed - `storageIO.test.ts`: 24 passed - `storageKeys.test.ts`: 12 passed - `useWorkflowPersistenceV2.test.ts`: 20 passed - `vue-tsc --noEmit` - ESLint and oxfmt on changed files - `git diff --check` Staging remains expected to reproduce until this PR is merged, backported to Cloud 1.48, deployed, and the workspace A → B → A flow is reverified there. --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1734 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-30T02:18:29.612Z",
"gitSha": "4e909e28f36aaf4558f4c773bb1ef85e57685982",
"branch": "backport-14306-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.5360000000082,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.9110000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.619,
"heapDeltaBytes": 4037088,
"heapUsedBytes": 71953800,
"domNodes": 16,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 25.2,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2026.8930000000296,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.060999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.64700000000005,
"heapDeltaBytes": 3458008,
"heapUsedBytes": 71249672,
"domNodes": 18,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 16.77,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2062.1949999999742,
"styleRecalcs": 77,
"styleRecalcDurationMs": 49.11500000000001,
"layouts": 12,
"layoutDurationMs": 4.226000000000001,
"taskDurationMs": 1139.2980000000002,
"heapDeltaBytes": -15698292,
"heapUsedBytes": 52294296,
"domNodes": -275,
"jsHeapTotalBytes": 21753856,
"scriptDurationMs": 144.492,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.2909999999101,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.833,
"layouts": 12,
"layoutDurationMs": 3.544,
"taskDurationMs": 894.943,
"heapDeltaBytes": -16054368,
"heapUsedBytes": 51764172,
"domNodes": -274,
"jsHeapTotalBytes": 20180992,
"scriptDurationMs": 117.34,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1775.6270000000427,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.56,
"layouts": 6,
"layoutDurationMs": 0.7539999999999999,
"taskDurationMs": 467.34899999999993,
"heapDeltaBytes": 7327460,
"heapUsedBytes": 75186480,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 27.696,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.1389999999383,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.368000000000002,
"layouts": 6,
"layoutDurationMs": 0.7010000000000001,
"taskDurationMs": 420.64799999999997,
"heapDeltaBytes": 7161332,
"heapUsedBytes": 75146152,
"domNodes": 79,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 25.068999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 627.268000000015,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.681,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.676,
"heapDeltaBytes": -11708648,
"heapUsedBytes": 56115824,
"domNodes": 20,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 59.207,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 627.6780000000599,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.077000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 403.069,
"heapDeltaBytes": -12440988,
"heapUsedBytes": 55536472,
"domNodes": 20,
"jsHeapTotalBytes": 21364736,
"scriptDurationMs": 58.819,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.4500000000207,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.859999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 819.581,
"heapDeltaBytes": 7042244,
"heapUsedBytes": 65967436,
"domNodes": -277,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 123.68799999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2041.1379999999326,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.565999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 798.9419999999999,
"heapDeltaBytes": 6349424,
"heapUsedBytes": 65047704,
"domNodes": -275,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 122.83100000000002,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2263.9110000000073,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.825999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1396.055,
"heapDeltaBytes": 5379712,
"heapUsedBytes": 65545672,
"domNodes": -277,
"jsHeapTotalBytes": 6037504,
"scriptDurationMs": 443.98199999999997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2184.564000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.408000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1281.6319999999998,
"heapDeltaBytes": 4340212,
"heapUsedBytes": 63982620,
"domNodes": -278,
"jsHeapTotalBytes": 4202496,
"scriptDurationMs": 408.56699999999995,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3294.906000000026,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.649,
"layouts": 60,
"layoutDurationMs": 8.9,
"taskDurationMs": 1666.7160000000001,
"heapDeltaBytes": 3182020,
"heapUsedBytes": 65269640,
"domNodes": -282,
"jsHeapTotalBytes": 7929856,
"scriptDurationMs": 583.971,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3232.4949999999717,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.523000000000001,
"layouts": 60,
"layoutDurationMs": 8.22,
"taskDurationMs": 1540.959,
"heapDeltaBytes": -838204,
"heapUsedBytes": 62945984,
"domNodes": -281,
"jsHeapTotalBytes": 7929856,
"scriptDurationMs": 527.143,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.204000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.896,
"heapDeltaBytes": 6720772,
"heapUsedBytes": 67063312,
"domNodes": -277,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 123.333,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.3340000000198,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.6049999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.494,
"heapDeltaBytes": 6890412,
"heapUsedBytes": 67198456,
"domNodes": -277,
"jsHeapTotalBytes": 4521984,
"scriptDurationMs": 120.65299999999999,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 641.2540000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.372000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.289,
"heapDeltaBytes": -12189220,
"heapUsedBytes": 55846192,
"domNodes": 18,
"jsHeapTotalBytes": 21889024,
"scriptDurationMs": 124.707,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 644.4940000000088,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.426,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.72099999999995,
"heapDeltaBytes": -11686552,
"heapUsedBytes": 56123680,
"domNodes": 22,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 127.608,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.8499999999763,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.1039999999999,
"heapDeltaBytes": 3856948,
"heapUsedBytes": 71662100,
"domNodes": 18,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 19.887999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2024.7870000000603,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.402999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.1270000000001,
"heapDeltaBytes": 3450848,
"heapUsedBytes": 71356192,
"domNodes": 22,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 18.224999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1751.8660000000068,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.178,
"layouts": 16,
"layoutDurationMs": 5.126,
"taskDurationMs": 873.42,
"heapDeltaBytes": -21795172,
"heapUsedBytes": 46101980,
"domNodes": 60,
"jsHeapTotalBytes": 21491712,
"scriptDurationMs": 98.455,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.4369999999717,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.487,
"layouts": 16,
"layoutDurationMs": 4.737,
"taskDurationMs": 850.3779999999999,
"heapDeltaBytes": -21324256,
"heapUsedBytes": 46687048,
"domNodes": -273,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 99.42999999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0020000000095,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.384999999999994,
"layouts": 14,
"layoutDurationMs": 11.719999999999997,
"taskDurationMs": 969.5579999999999,
"heapDeltaBytes": 33266064,
"heapUsedBytes": 99628144,
"domNodes": 13673,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 35.763000000000005,
"eventListeners": 2371,
"totalBlockingTimeMs": 117,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8383.753000000013,
"styleRecalcs": 250,
"styleRecalcDurationMs": 43.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4840.95,
"heapDeltaBytes": 10417300,
"heapUsedBytes": 69273020,
"domNodes": -276,
"jsHeapTotalBytes": 7319552,
"scriptDurationMs": 1417.4940000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8266.041000000087,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.17299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4464.551,
"heapDeltaBytes": 11119300,
"heapUsedBytes": 69908680,
"domNodes": -275,
"jsHeapTotalBytes": 7057408,
"scriptDurationMs": 1348.415,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18414.423999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18371.099000000002,
"heapDeltaBytes": -29931864,
"heapUsedBytes": 177638156,
"domNodes": -8312,
"jsHeapTotalBytes": -11735040,
"scriptDurationMs": 612.632,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18261.609000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18228.198000000004,
"heapDeltaBytes": -61579136,
"heapUsedBytes": 165670096,
"domNodes": -8312,
"jsHeapTotalBytes": -15925248,
"scriptDurationMs": 582.015,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23224.429999999986,
"styleRecalcs": 174,
"styleRecalcDurationMs": 28.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23179.034,
"heapDeltaBytes": -69365336,
"heapUsedBytes": 156499812,
"domNodes": -8312,
"jsHeapTotalBytes": -17240064,
"scriptDurationMs": 938.7540000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 944,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22223.53099999998,
"styleRecalcs": 162,
"styleRecalcDurationMs": 23.42099999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22182.599,
"heapDeltaBytes": -53280508,
"heapUsedBytes": 166284576,
"domNodes": -8312,
"jsHeapTotalBytes": -13832192,
"scriptDurationMs": 919.3639999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 602,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 455.853999999988,
"styleRecalcs": 14,
"styleRecalcDurationMs": 19.185000000000002,
"layouts": 2,
"layoutDurationMs": 0.42599999999999993,
"taskDurationMs": 112.54999999999998,
"heapDeltaBytes": -16116684,
"heapUsedBytes": 50849368,
"domNodes": 130,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 10.254000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 465.4610000000048,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.499000000000002,
"layouts": 2,
"layoutDurationMs": 0.3600000000000001,
"taskDurationMs": 111.531,
"heapDeltaBytes": -16159932,
"heapUsedBytes": 50709872,
"domNodes": 119,
"jsHeapTotalBytes": 7733248,
"scriptDurationMs": 9.820999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.48 #14318 +/- ##
==========================================
Coverage 79.24% 79.25%
==========================================
Files 1744 1744
Lines 98992 99018 +26
Branches 31709 31722 +13
==========================================
+ Hits 78445 78474 +29
+ Misses 20147 20144 -3
Partials 400 400
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
cloud/1.48 isn't shipping, cloud/1.49 is shipping today afternoon. |
Pull request was closed
Backport of #14306 to
core/1.48Automatically created by backport workflow.