Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1753 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-30T01:04:00.812Z",
"gitSha": "6a581fb96daad5cf8639fb22b96f7eb192c172dd",
"branch": "deepme987/onboarding/role-pins-lite",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2113.4030000000052,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.408999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.613,
"heapDeltaBytes": 4021500,
"heapUsedBytes": 71902948,
"domNodes": 20,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 20.761000000000003,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.935999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.328000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.273,
"heapDeltaBytes": 3885016,
"heapUsedBytes": 71906448,
"domNodes": 18,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 20.134999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2085.3439999999637,
"styleRecalcs": 79,
"styleRecalcDurationMs": 49.62500000000001,
"layouts": 12,
"layoutDurationMs": 6.26,
"taskDurationMs": 1105.2140000000002,
"heapDeltaBytes": -16193440,
"heapUsedBytes": 51777056,
"domNodes": -274,
"jsHeapTotalBytes": 20963328,
"scriptDurationMs": 144.41,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.0339999999378,
"styleRecalcs": 74,
"styleRecalcDurationMs": 39.351,
"layouts": 12,
"layoutDurationMs": 3.378,
"taskDurationMs": 901.3879999999999,
"heapDeltaBytes": -16568232,
"heapUsedBytes": 51540156,
"domNodes": -275,
"jsHeapTotalBytes": 22011904,
"scriptDurationMs": 123.61500000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.803000000024,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.713,
"layouts": 6,
"layoutDurationMs": 0.7010000000000001,
"taskDurationMs": 442.207,
"heapDeltaBytes": 7231580,
"heapUsedBytes": 75131680,
"domNodes": 77,
"jsHeapTotalBytes": 20312064,
"scriptDurationMs": 27.263999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.3749999999955,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.773999999999997,
"layouts": 6,
"layoutDurationMs": 0.704,
"taskDurationMs": 392.177,
"heapDeltaBytes": 7311712,
"heapUsedBytes": 75259616,
"domNodes": 77,
"jsHeapTotalBytes": 20049920,
"scriptDurationMs": 21.162,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 622.9899999999589,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.749000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.917,
"heapDeltaBytes": -12113708,
"heapUsedBytes": 55984728,
"domNodes": 20,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 61.175999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 630.5170000000544,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.765,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.793,
"heapDeltaBytes": -12147624,
"heapUsedBytes": 55852472,
"domNodes": 20,
"jsHeapTotalBytes": 21884928,
"scriptDurationMs": 63.550999999999995,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2043.7780000000316,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 712.33,
"heapDeltaBytes": 7028440,
"heapUsedBytes": 66310428,
"domNodes": -275,
"jsHeapTotalBytes": 4780032,
"scriptDurationMs": 119.228,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.3139999999667,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.339000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.1370000000002,
"heapDeltaBytes": 6957424,
"heapUsedBytes": 66312680,
"domNodes": -277,
"jsHeapTotalBytes": 4255744,
"scriptDurationMs": 116.369,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2184.4260000000304,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.353000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1304.328,
"heapDeltaBytes": -4416572,
"heapUsedBytes": 56065904,
"domNodes": -279,
"jsHeapTotalBytes": 6352896,
"scriptDurationMs": 431.104,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2182.5509999999895,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1332.879,
"heapDeltaBytes": -4244520,
"heapUsedBytes": 55687332,
"domNodes": -277,
"jsHeapTotalBytes": 5042176,
"scriptDurationMs": 440.496,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3348.7159999999676,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.73,
"layouts": 60,
"layoutDurationMs": 7.535,
"taskDurationMs": 1575.18,
"heapDeltaBytes": 6299032,
"heapUsedBytes": 67876696,
"domNodes": -281,
"jsHeapTotalBytes": 7401472,
"scriptDurationMs": 558.2439999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3197.4500000000035,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.552999999999997,
"layouts": 60,
"layoutDurationMs": 7.378000000000001,
"taskDurationMs": 1519.1000000000001,
"heapDeltaBytes": 23371748,
"heapUsedBytes": 84798400,
"domNodes": 14,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 543.761,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.1910000000498,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.698,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 784.778,
"heapDeltaBytes": 6463444,
"heapUsedBytes": 67172412,
"domNodes": -278,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 128.89999999999998,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.8860000000195,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.413999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 846.1180000000002,
"heapDeltaBytes": 6622820,
"heapUsedBytes": 67427564,
"domNodes": -277,
"jsHeapTotalBytes": 4517888,
"scriptDurationMs": 136.15699999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.953000000015,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.620999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.6599999999999,
"heapDeltaBytes": -11524112,
"heapUsedBytes": 56445324,
"domNodes": 20,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 126.12099999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.4939999999269,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.780000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.468,
"heapDeltaBytes": -11419356,
"heapUsedBytes": 56480296,
"domNodes": 20,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 121.31500000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2024.065999999948,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.431,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.18199999999996,
"heapDeltaBytes": 3637716,
"heapUsedBytes": 71872864,
"domNodes": 18,
"jsHeapTotalBytes": 20574208,
"scriptDurationMs": 15.265,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2012.783000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.923999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.2280000000001,
"heapDeltaBytes": -22455064,
"heapUsedBytes": 45677572,
"domNodes": 18,
"jsHeapTotalBytes": 19914752,
"scriptDurationMs": 17.5,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.8200000000206,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.434999999999995,
"layouts": 16,
"layoutDurationMs": 4.303999999999999,
"taskDurationMs": 765.026,
"heapDeltaBytes": -5613344,
"heapUsedBytes": 62398384,
"domNodes": 64,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 94.469,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1698.4489999999823,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.886,
"layouts": 16,
"layoutDurationMs": 4.81,
"taskDurationMs": 796.547,
"heapDeltaBytes": -5655064,
"heapUsedBytes": 62377760,
"domNodes": 62,
"jsHeapTotalBytes": 21360640,
"scriptDurationMs": 96.91000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.1289999999453,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.448000000000004,
"layouts": 13,
"layoutDurationMs": 13.093,
"taskDurationMs": 1018.9490000000001,
"heapDeltaBytes": 29028124,
"heapUsedBytes": 98978608,
"domNodes": 13673,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 49.07399999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8736.852999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.372,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4935.891,
"heapDeltaBytes": 12276812,
"heapUsedBytes": 71594944,
"domNodes": -276,
"jsHeapTotalBytes": 6791168,
"scriptDurationMs": 1498.0580000000002,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8424.105000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.171,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4672.463000000001,
"heapDeltaBytes": 7237856,
"heapUsedBytes": 66105132,
"domNodes": -276,
"jsHeapTotalBytes": 6791168,
"scriptDurationMs": 1448.6490000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17586.18899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17539.144,
"heapDeltaBytes": -38939528,
"heapUsedBytes": 165735264,
"domNodes": -8312,
"jsHeapTotalBytes": -14618624,
"scriptDurationMs": 572.6139999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17301.036999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17260.899,
"heapDeltaBytes": -43074592,
"heapUsedBytes": 166908644,
"domNodes": -8316,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 579.3900000000001,
"eventListeners": -16385,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21263.062999999987,
"styleRecalcs": 145,
"styleRecalcDurationMs": 18.28200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21227.849,
"heapDeltaBytes": -71219056,
"heapUsedBytes": 151266136,
"domNodes": -8312,
"jsHeapTotalBytes": -13307904,
"scriptDurationMs": 967.6250000000002,
"eventListeners": -16385,
"totalBlockingTimeMs": 322,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20998.642000000018,
"styleRecalcs": 141,
"styleRecalcDurationMs": 17.867000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20940.290999999997,
"heapDeltaBytes": -70152108,
"heapUsedBytes": 154174532,
"domNodes": -8312,
"jsHeapTotalBytes": -16187392,
"scriptDurationMs": 892.73,
"eventListeners": -16383,
"totalBlockingTimeMs": 223,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 472.43200000002616,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.882,
"layouts": 3,
"layoutDurationMs": 1.459,
"taskDurationMs": 135.937,
"heapDeltaBytes": -15679084,
"heapUsedBytes": 51613016,
"domNodes": 152,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 13.306999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 489.45499999990716,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.112000000000002,
"layouts": 3,
"layoutDurationMs": 1.3140000000000003,
"taskDurationMs": 129.594,
"heapDeltaBytes": -16002892,
"heapUsedBytes": 51054044,
"domNodes": 117,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 11.584,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## deepme987/onboarding/getting-started-lite #14296 +/- ##
============================================================================
Coverage ? 77.69%
============================================================================
Files ? 1762
Lines ? 102279
Branches ? 35820
============================================================================
Hits ? 79463
Misses ? 22340
Partials ? 476
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
This reverts commit 3501399.
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
…87/onboarding/role-pins-lite
|
Collapsed into #14298 — the stack merges as one PR. |
🔧 Auto-fixes AppliedThis PR has been automatically updated to fix linting and formatting issues.
Changes made:
|
Summary
Lean rebuild of #14142 (3/6). A curated template pins its role nodes —
{id, type}per role — andresolveTourRolesre-validates every pin against the live graph: the node must exist, still hold the pinned type, and a pin living inside a subgraph is host-mapped to the root-graph node that hosts it (only root nodes have elements to spotlight). A failed pin degrades to null so its step is omitted, never a wrong spotlight.mediaKindderives from the sink type.Changes
TOUR_ROLE_PINStyped againstCURATED_TEMPLATE_IDS(a curated card without pins fails typecheck), the resolver reusingresolveNode+getExecutionIdByNode+getRootParentNode, tests incl. the subgraph host-mapping case.Review Focus
tourSequenceintermediate vocabulary, the soft Playwright drift-guard spec, storedmediaKind.