Repository navigation
[backport cloud/1.48] fix: isolate workflow state across auth transitions - #14288
Conversation
## Summary Fixes **QA report items CF148-005 and CF148-006** by failing workspace initialization closed and synchronously clearing workflow persistence before Cloud logout navigation. Reported in the [Cloud 1.48 QA thread](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785337736169649?thread_ts=1785169746.169899&cid=C0932CGKT5K). ## Changes - **CF148-005**: Workspace initialization no longer reports `ready` after scoped-token exchange fails, so stale canvas/draft state cannot render under another selected workspace. - **CF148-006**: Successful Cloud logout clears V2 and migratable legacy workflow state before navigation; a terminal write barrier prevents queued persistence writes from recreating cleared state. - Cleanup remains targeted and preserves unrelated local/session storage. ## When these issues were introduced - **CF148-005**: The fail-open workspace initialization behavior was introduced on **2026-01-21** by PR #8194 ([`66e6f2498`](66e6f24)). Global app gating later became fail-open in PR #8350. PR #14183 fixed the app-level startup gate; this PR adds the store-level defense. - **CF148-006**: The race became possible on **2026-02-21** in PR #8520 ([`40aa7c5974`](40aa7c5)), when workflow cleanup became a Vue watcher callback while Cloud logout already hard-navigated immediately (hard navigation was introduced by PR #6564). ## Review Focus Confirm failed workspace authentication never reaches `ready`, and that only terminal Cloud logout blocks later workflow writes. ## Screenshots The captures use deterministic mocked Cloud transitions to make both failure modes reproducible. ### CF148-005 — AS IS Workspace B is selected while a Workspace A-only dirty draft remains visible. ### CF148-005 — TO BE Failed workspace authentication keeps the app gated; no previous workspace canvas or draft renders.   ### CF148-006 — AS IS A closed workflow returns after logout and the next login because cleanup can lose the race with navigation. ### CF148-006 — TO BE Workflow storage is cleared synchronously before redirect and terminal late writes are rejected, so no stale workflow restores after login.   ## Verification - `pnpm test:unit src/composables/auth/useAuthActions.test.ts src/platform/workspace/stores/teamWorkspaceStore.test.ts src/platform/workflow/persistence/base/storageIO.test.ts` — 119 passed - `pnpm typecheck` - `pnpm lint:unstaged` - `pnpm knip` - `git diff --check` --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1734 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-29T19:04:31.831Z",
"gitSha": "0392f217d026c3ba8c8e88dffc705d2cab1cd305",
"branch": "backport-14266-to-cloud-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2132.23499999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.3670000000001,
"heapDeltaBytes": 4050460,
"heapUsedBytes": 71992684,
"domNodes": 22,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 31.343000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 1997.3430000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.612999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.22499999999997,
"heapDeltaBytes": 3489460,
"heapUsedBytes": 71344288,
"domNodes": 20,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 15.351000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1745.8389999999895,
"styleRecalcs": 73,
"styleRecalcDurationMs": 31.986,
"layouts": 12,
"layoutDurationMs": 3.111,
"taskDurationMs": 785.033,
"heapDeltaBytes": -19267352,
"heapUsedBytes": 48741700,
"domNodes": -273,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 106.87100000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1718.0870000000255,
"styleRecalcs": 71,
"styleRecalcDurationMs": 28.320999999999998,
"layouts": 12,
"layoutDurationMs": 3.0069999999999997,
"taskDurationMs": 718.365,
"heapDeltaBytes": -16328336,
"heapUsedBytes": 51568248,
"domNodes": -273,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 97.057,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.5479999999734,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.411,
"layouts": 6,
"layoutDurationMs": 0.5109999999999999,
"taskDurationMs": 321.473,
"heapDeltaBytes": 7209372,
"heapUsedBytes": 74859552,
"domNodes": 77,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 18.961,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.2329999999893,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.099000000000004,
"layouts": 6,
"layoutDurationMs": 0.5720000000000001,
"taskDurationMs": 342.28000000000003,
"heapDeltaBytes": 7032844,
"heapUsedBytes": 75038108,
"domNodes": 77,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 20.273,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 553.606000000002,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.942999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.9839999999999,
"heapDeltaBytes": -11997660,
"heapUsedBytes": 55772824,
"domNodes": 20,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 48.449,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 508.78700000004073,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.064000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 301.776,
"heapDeltaBytes": -12542152,
"heapUsedBytes": 55138784,
"domNodes": 18,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 45.037,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2022.8990000000522,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.7410000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 724.7669999999999,
"heapDeltaBytes": 6711744,
"heapUsedBytes": 66821052,
"domNodes": -276,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 109.21700000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2036.0549999999193,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.152000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.7699999999999,
"heapDeltaBytes": 7794964,
"heapUsedBytes": 66600780,
"domNodes": -274,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 83.172,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2252.2769999999923,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.726999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1168.974,
"heapDeltaBytes": 852048,
"heapUsedBytes": 60468120,
"domNodes": -276,
"jsHeapTotalBytes": 5779456,
"scriptDurationMs": 380.887,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2083.5500000000593,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.158,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 975.4750000000001,
"heapDeltaBytes": 1180760,
"heapUsedBytes": 60657900,
"domNodes": -275,
"jsHeapTotalBytes": 5255168,
"scriptDurationMs": 320.62,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3455.336999999986,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.56,
"layouts": 60,
"layoutDurationMs": 7.862000000000001,
"taskDurationMs": 1464.777,
"heapDeltaBytes": 12567584,
"heapUsedBytes": 76325008,
"domNodes": -277,
"jsHeapTotalBytes": 7671808,
"scriptDurationMs": 512.8770000000001,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3118.3660000000373,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.521999999999998,
"layouts": 60,
"layoutDurationMs": 7.022,
"taskDurationMs": 1228.205,
"heapDeltaBytes": -5021728,
"heapUsedBytes": 56194760,
"domNodes": -279,
"jsHeapTotalBytes": 7147520,
"scriptDurationMs": 418.403,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2007.8469999999697,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.4749999999999,
"heapDeltaBytes": 6598968,
"heapUsedBytes": 67117924,
"domNodes": -279,
"jsHeapTotalBytes": 5050368,
"scriptDurationMs": 83.004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2041.5070000000242,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.323999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 632.9390000000001,
"heapDeltaBytes": 7212508,
"heapUsedBytes": 67482988,
"domNodes": -275,
"jsHeapTotalBytes": 4263936,
"scriptDurationMs": 102.595,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 535.1350000000252,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.185999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.257,
"heapDeltaBytes": -11710480,
"heapUsedBytes": 56150780,
"domNodes": 20,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 100.546,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 536.0719999999901,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.499,
"heapDeltaBytes": -11001348,
"heapUsedBytes": 57058684,
"domNodes": 20,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 100.663,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2024.676999999997,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.535,
"heapDeltaBytes": 3926368,
"heapUsedBytes": 72073680,
"domNodes": 22,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 19.379,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.6939999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.190999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.882,
"heapDeltaBytes": 3406960,
"heapUsedBytes": 71484632,
"domNodes": 18,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 12.181000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1715.7209999999736,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.632999999999996,
"layouts": 16,
"layoutDurationMs": 4.2940000000000005,
"taskDurationMs": 789.4949999999999,
"heapDeltaBytes": -19263188,
"heapUsedBytes": 48872132,
"domNodes": -273,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 93.337,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.550000000031,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.152,
"layouts": 16,
"layoutDurationMs": 3.764,
"taskDurationMs": 659.832,
"heapDeltaBytes": -18997452,
"heapUsedBytes": 49055268,
"domNodes": -274,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 76.739,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1303.0619999999544,
"styleRecalcs": 18,
"styleRecalcDurationMs": 24.261,
"layouts": 14,
"layoutDurationMs": 9.436,
"taskDurationMs": 833.7270000000001,
"heapDeltaBytes": 29426148,
"heapUsedBytes": 95882272,
"domNodes": 13673,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 32.355999999999995,
"eventListeners": 2371,
"totalBlockingTimeMs": 85,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8155.831999999975,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.75000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3849.917,
"heapDeltaBytes": 8942212,
"heapUsedBytes": 68879380,
"domNodes": -275,
"jsHeapTotalBytes": 6565888,
"scriptDurationMs": 1151.166,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8109.7460000000865,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.716,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3569.283,
"heapDeltaBytes": 28901964,
"heapUsedBytes": 87605608,
"domNodes": -275,
"jsHeapTotalBytes": 5779456,
"scriptDurationMs": 1090.3740000000003,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 14680.065999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14657.098000000002,
"heapDeltaBytes": -61725188,
"heapUsedBytes": 167781940,
"domNodes": -8312,
"jsHeapTotalBytes": -14065664,
"scriptDurationMs": 413.507,
"eventListeners": -16391,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14993.516999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14968.773000000001,
"heapDeltaBytes": -46609608,
"heapUsedBytes": 157992856,
"domNodes": -3314,
"jsHeapTotalBytes": -11702272,
"scriptDurationMs": 499.074,
"eventListeners": -16393,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17135.606999999993,
"styleRecalcs": 117,
"styleRecalcDurationMs": 15.031000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17120.088,
"heapDeltaBytes": -42199464,
"heapUsedBytes": 163904732,
"domNodes": -8316,
"jsHeapTotalBytes": -13303808,
"scriptDurationMs": 721.766,
"eventListeners": -16387,
"totalBlockingTimeMs": 14,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17611.116999999922,
"styleRecalcs": 122,
"styleRecalcDurationMs": 15.768000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17585.93,
"heapDeltaBytes": -51159008,
"heapUsedBytes": 157277468,
"domNodes": -8312,
"jsHeapTotalBytes": -16191488,
"scriptDurationMs": 754.3439999999999,
"eventListeners": -16385,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.25299999995696,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.181,
"layouts": 3,
"layoutDurationMs": 0.9959999999999999,
"taskDurationMs": 109.587,
"heapDeltaBytes": -16006136,
"heapUsedBytes": 51159768,
"domNodes": 130,
"jsHeapTotalBytes": 7737344,
"scriptDurationMs": 10.164,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 448.92300000003615,
"styleRecalcs": 13,
"styleRecalcDurationMs": 14.827,
"layouts": 3,
"layoutDurationMs": 0.539,
"taskDurationMs": 96.35300000000001,
"heapDeltaBytes": -16064064,
"heapUsedBytes": 51007248,
"domNodes": 119,
"jsHeapTotalBytes": 7475200,
"scriptDurationMs": 8.479000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.48 #14288 +/- ##
=============================================
Coverage ? 79.12%
=============================================
Files ? 1743
Lines ? 98619
Branches ? 31569
=============================================
Hits ? 78034
Misses ? 20182
Partials ? 403
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14266 to
cloud/1.48Automatically created by backport workflow.