Repository navigation
[backport core/1.48] fix: isolate workflow state across auth transitions - #14287
Conversation
## Summary Fixes **QA report items CF148-005 and CF148-006** by failing workspace initialization closed and synchronously clearing workflow persistence before Cloud logout navigation. Reported in the [Cloud 1.48 QA thread](https://comfy-organization.slack.com/archives/C0932CGKT5K/p1785337736169649?thread_ts=1785169746.169899&cid=C0932CGKT5K). ## Changes - **CF148-005**: Workspace initialization no longer reports `ready` after scoped-token exchange fails, so stale canvas/draft state cannot render under another selected workspace. - **CF148-006**: Successful Cloud logout clears V2 and migratable legacy workflow state before navigation; a terminal write barrier prevents queued persistence writes from recreating cleared state. - Cleanup remains targeted and preserves unrelated local/session storage. ## When these issues were introduced - **CF148-005**: The fail-open workspace initialization behavior was introduced on **2026-01-21** by PR #8194 ([`66e6f2498`](66e6f24)). Global app gating later became fail-open in PR #8350. PR #14183 fixed the app-level startup gate; this PR adds the store-level defense. - **CF148-006**: The race became possible on **2026-02-21** in PR #8520 ([`40aa7c5974`](40aa7c5)), when workflow cleanup became a Vue watcher callback while Cloud logout already hard-navigated immediately (hard navigation was introduced by PR #6564). ## Review Focus Confirm failed workspace authentication never reaches `ready`, and that only terminal Cloud logout blocks later workflow writes. ## Screenshots The captures use deterministic mocked Cloud transitions to make both failure modes reproducible. ### CF148-005 — AS IS Workspace B is selected while a Workspace A-only dirty draft remains visible. ### CF148-005 — TO BE Failed workspace authentication keeps the app gated; no previous workspace canvas or draft renders.   ### CF148-006 — AS IS A closed workflow returns after logout and the next login because cleanup can lose the race with navigation. ### CF148-006 — TO BE Workflow storage is cleared synchronously before redirect and terminal late writes are rejected, so no stale workflow restores after login.   ## Verification - `pnpm test:unit src/composables/auth/useAuthActions.test.ts src/platform/workspace/stores/teamWorkspaceStore.test.ts src/platform/workflow/persistence/base/storageIO.test.ts` — 119 passed - `pnpm typecheck` - `pnpm lint:unstaged` - `pnpm knip` - `git diff --check` --------- Co-authored-by: dante01yoon <6510430+dante01yoon@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com>
📄 Knowledge reviewDosu skipped reviewing this PR because your organization has used its |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1734 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-29T19:05:09.881Z",
"gitSha": "2a791b0d1615ffd4af0c9045a825ca7ffd62aea9",
"branch": "backport-14266-to-core-1.48",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2121.035000000006,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.5960000000001,
"heapDeltaBytes": -21162588,
"heapUsedBytes": 46820816,
"domNodes": -273,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 22.189999999999998,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2068.0090000000177,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.927999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.0880000000001,
"heapDeltaBytes": -21218896,
"heapUsedBytes": 46669292,
"domNodes": -275,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 24.381,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1804.0789999999731,
"styleRecalcs": 71,
"styleRecalcDurationMs": 35.714000000000006,
"layouts": 12,
"layoutDurationMs": 3.581,
"taskDurationMs": 875.295,
"heapDeltaBytes": -15648736,
"heapUsedBytes": 52247936,
"domNodes": -277,
"jsHeapTotalBytes": 22020096,
"scriptDurationMs": 112.137,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1966.7859999999564,
"styleRecalcs": 75,
"styleRecalcDurationMs": 46.763,
"layouts": 12,
"layoutDurationMs": 3.7800000000000002,
"taskDurationMs": 1033.6670000000001,
"heapDeltaBytes": -13746332,
"heapUsedBytes": 54368832,
"domNodes": -274,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 132.18999999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1753.370000000018,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.632,
"layouts": 6,
"layoutDurationMs": 0.6430000000000001,
"taskDurationMs": 382.161,
"heapDeltaBytes": 7342252,
"heapUsedBytes": 75113448,
"domNodes": 78,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 19.687,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.321999999931,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.194,
"layouts": 6,
"layoutDurationMs": 0.8140000000000001,
"taskDurationMs": 470.30499999999995,
"heapDeltaBytes": 7365792,
"heapUsedBytes": 75169048,
"domNodes": 78,
"jsHeapTotalBytes": 20320256,
"scriptDurationMs": 28.703999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 577.4729999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.638,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.754,
"heapDeltaBytes": -11979048,
"heapUsedBytes": 55850760,
"domNodes": 18,
"jsHeapTotalBytes": 21893120,
"scriptDurationMs": 53.907,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 594.9259999999867,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.62,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.67,
"heapDeltaBytes": -12272852,
"heapUsedBytes": 55630380,
"domNodes": 18,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 60.851,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.034000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.158000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 668.5489999999999,
"heapDeltaBytes": 5880836,
"heapUsedBytes": 64502916,
"domNodes": -275,
"jsHeapTotalBytes": 5574656,
"scriptDurationMs": 93.57900000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.46899999994,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.2989999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 795.4140000000001,
"heapDeltaBytes": 6745564,
"heapUsedBytes": 65980328,
"domNodes": -277,
"jsHeapTotalBytes": 4001792,
"scriptDurationMs": 126.40299999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2182.434999999998,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.203000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1285.2430000000002,
"heapDeltaBytes": 5169432,
"heapUsedBytes": 65506020,
"domNodes": -280,
"jsHeapTotalBytes": 4468736,
"scriptDurationMs": 426.38300000000004,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2195.461000000023,
"styleRecalcs": 68,
"styleRecalcDurationMs": 16.349000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1394.5700000000002,
"heapDeltaBytes": 5197452,
"heapUsedBytes": 65153408,
"domNodes": -279,
"jsHeapTotalBytes": 4993024,
"scriptDurationMs": 455.34799999999996,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3165.6399999999962,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.926000000000002,
"layouts": 60,
"layoutDurationMs": 8.36,
"taskDurationMs": 1467.503,
"heapDeltaBytes": 22981860,
"heapUsedBytes": 84332376,
"domNodes": 12,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 526.986,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3364.584000000036,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.73,
"layouts": 60,
"layoutDurationMs": 9.117999999999999,
"taskDurationMs": 1727.657,
"heapDeltaBytes": 6667084,
"heapUsedBytes": 68338776,
"domNodes": -282,
"jsHeapTotalBytes": 8458240,
"scriptDurationMs": 605.2470000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.5510000000072,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.404000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.0369999999999,
"heapDeltaBytes": 7166832,
"heapUsedBytes": 67671868,
"domNodes": -278,
"jsHeapTotalBytes": 4788224,
"scriptDurationMs": 95.468,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.3070000000507,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.401000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 852.687,
"heapDeltaBytes": 6403164,
"heapUsedBytes": 66895656,
"domNodes": -277,
"jsHeapTotalBytes": 4001792,
"scriptDurationMs": 130.29399999999998,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.0610000000065,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.942999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.14400000000006,
"heapDeltaBytes": -11569436,
"heapUsedBytes": 56407532,
"domNodes": 18,
"jsHeapTotalBytes": 21368832,
"scriptDurationMs": 123.526,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 626.8239999999423,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.929999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.35099999999994,
"heapDeltaBytes": -12171732,
"heapUsedBytes": 55771792,
"domNodes": 20,
"jsHeapTotalBytes": 22417408,
"scriptDurationMs": 125.90200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.8690000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.0550000000001,
"heapDeltaBytes": -21337288,
"heapUsedBytes": 46768704,
"domNodes": -274,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 13.908999999999997,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.269000000008,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.376,
"heapDeltaBytes": 3420384,
"heapUsedBytes": 71346448,
"domNodes": 16,
"jsHeapTotalBytes": 20844544,
"scriptDurationMs": 19.139999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.4519999999911,
"styleRecalcs": 74,
"styleRecalcDurationMs": 38.566,
"layouts": 16,
"layoutDurationMs": 4.879,
"taskDurationMs": 863.48,
"heapDeltaBytes": -17133744,
"heapUsedBytes": 50770804,
"domNodes": -277,
"jsHeapTotalBytes": 21495808,
"scriptDurationMs": 99.45000000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1753.7529999999606,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.45499999999999,
"layouts": 16,
"layoutDurationMs": 4.9510000000000005,
"taskDurationMs": 907.7010000000001,
"heapDeltaBytes": -18475168,
"heapUsedBytes": 49589828,
"domNodes": -274,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 104.605,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3490000000015,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.409000000000006,
"layouts": 14,
"layoutDurationMs": 12.149000000000001,
"taskDurationMs": 1049.3260000000002,
"heapDeltaBytes": 31035084,
"heapUsedBytes": 97850232,
"domNodes": 13673,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 38.62199999999999,
"eventListeners": 2371,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8286.995000000046,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.624,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4690.437,
"heapDeltaBytes": 11277600,
"heapUsedBytes": 70058860,
"domNodes": -277,
"jsHeapTotalBytes": 6799360,
"scriptDurationMs": 1464.1639999999998,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8316.418999999996,
"styleRecalcs": 249,
"styleRecalcDurationMs": 44.725,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4851.264999999999,
"heapDeltaBytes": 8161640,
"heapUsedBytes": 66820364,
"domNodes": -275,
"jsHeapTotalBytes": 7323648,
"scriptDurationMs": 1463.2050000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18626.762999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18572.732000000004,
"heapDeltaBytes": -51023920,
"heapUsedBytes": 168443776,
"domNodes": -8316,
"jsHeapTotalBytes": -11177984,
"scriptDurationMs": 614.321,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18641.56200000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18621.045,
"heapDeltaBytes": -41773924,
"heapUsedBytes": 165591608,
"domNodes": -8312,
"jsHeapTotalBytes": -17502208,
"scriptDurationMs": 617.973,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21876.484000000004,
"styleRecalcs": 153,
"styleRecalcDurationMs": 20.979000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21802.176,
"heapDeltaBytes": -52304624,
"heapUsedBytes": 176810784,
"domNodes": -8316,
"jsHeapTotalBytes": -14966784,
"scriptDurationMs": 884.259,
"eventListeners": -16381,
"totalBlockingTimeMs": 346,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 23922.570000000065,
"styleRecalcs": 179,
"styleRecalcDurationMs": 30.33199999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23881.307,
"heapDeltaBytes": -46793292,
"heapUsedBytes": 161448828,
"domNodes": -8312,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 1010.872,
"eventListeners": -16383,
"totalBlockingTimeMs": 1109,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 120.79499999998689,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.628999999999998,
"layouts": 3,
"layoutDurationMs": 0.7839999999999998,
"taskDurationMs": 87.909,
"heapDeltaBytes": 3229476,
"heapUsedBytes": 70221216,
"domNodes": 120,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.841000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 479.31100000005245,
"styleRecalcs": 13,
"styleRecalcDurationMs": 25.368999999999996,
"layouts": 4,
"layoutDurationMs": 1.51,
"taskDurationMs": 127.88900000000002,
"heapDeltaBytes": -16014708,
"heapUsedBytes": 51030236,
"domNodes": 117,
"jsHeapTotalBytes": 7475200,
"scriptDurationMs": 11.242,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.48 #14287 +/- ##
==========================================
Coverage 79.13% 79.13%
==========================================
Files 1743 1743
Lines 98628 98631 +3
Branches 32315 32316 +1
==========================================
+ Hits 78048 78055 +7
+ Misses 20177 20173 -4
Partials 403 403
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #14266 to
core/1.48Automatically created by backport workflow.