Repository navigation
wip nux lite - #14255
wip nux lite#14255AustinMroz wants to merge 1 commit into
Conversation
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.15 MB gzip 🔴 +1.04 kBDetailsSummary
Category Glance App Entry Points — 3.63 kB (baseline 3.63 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • 🟢 -2.58 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.9 kB (baseline 64.8 kB) • 🔴 +87 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.43 MB (baseline 3.42 MB) • 🔴 +2.62 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • 🔴 +2.92 kBBundles that do not match a named category
Status: 78 added / 78 removed / 199 unchanged ⚡ Performance
|
📝 WalkthroughWalkthroughAdds a graph onboarding tour with localized steps, dynamic node targeting, coachmarks on graph nodes and the queue button, alternating spotlight interaction behavior, and a graph tour trigger based on persisted tutorial state. ChangesGraph onboarding tour
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Graph
participant useGraphNodeManager
participant onboardingTours
participant TourSpotlight
participant Canvas
Graph->>useGraphNodeManager: expose validated tourStep
useGraphNodeManager->>Graph: attach v-coachmark target
onboardingTours->>Graph: read node properties.tourStep
onboardingTours->>Canvas: select and fit eligible nodes
onboardingTours->>TourSpotlight: provide graph CoachStep sequence
TourSpotlight->>Graph: position spotlight and apply interaction gating
🚥 Pre-merge checks | ✅ 4 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/locales/en/main.json`:
- Around line 4741-4753: Add the missing localized title and body entries for
the graph.assets coachmark alongside the existing graph.nodeReference,
graph.nodePrompt, and graph.run entries in the main locale translations,
ensuring the final assets step has content consumed by
onboardingCoachmarks.graph.assets.
In `@src/platform/onboarding/onboardingTours.ts`:
- Around line 112-116: Update the node-step resolution flow around TOURS.graph
so it does not call canvas selection or view-animation methods while merely
determining visible nodes. Remove or defer the selectItems and
fitViewToSelectionAnimated transition to an explicit tour-start action,
preserving the user’s existing selection and viewport during graph reads.
- Around line 53-55: Move the coach ID definitions and an own-property,
dependency-free isNodeCoachKey guard into the leaf onboarding module, while
keeping isCoachKey behavior separate as needed. In
src/platform/onboarding/onboardingTours.ts lines 53-55, expose the node-specific
guard without runtime dependencies; in
src/composables/graph/useGraphNodeManager.ts lines 457-479, use isNodeCoachKey
before mapping properties.tourStep to a node coachmark ID so inherited or
non-node coach IDs cannot create duplicate targets.
In `@src/platform/onboarding/TourSpotlight.vue`:
- Line 27: Update the FocusScope configuration in TourSpotlight so interactive
steps where allowsTargetInteraction is true disable both focus trapping and
focus looping, while preserving the existing trapped, looping behavior for
non-interactive steps.
In `@src/platform/onboarding/useTourTriggers.ts`:
- Around line 37-39: Update the autoOpen computed expression in the graph tour
trigger to respect settingStore.get('Comfy.TutorialCompleted') instead of
unconditionally evaluating to true. Preserve automatic opening only when the
tutorial-completed setting indicates the tutorial has not been completed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 029aa35d-bb15-4d3c-84e4-07a040adf498
📒 Files selected for processing (8)
src/components/actionbar/ComfyRunButton/ComfyQueueButton.vuesrc/composables/graph/useGraphNodeManager.tssrc/locales/en/main.jsonsrc/platform/onboarding/TourSpotlight.vuesrc/platform/onboarding/coachmarkLayout.tssrc/platform/onboarding/onboardingTours.tssrc/platform/onboarding/useTourTriggers.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vue
A WIP lighter weight alternative implementation for new user tour.