Skip to content

fix: recover cloud sessions whose auth token the provider rejected - #14207

Closed
CodeJuggernaut wants to merge 18 commits into
mainfrom
fix/cloud-session-expiry-401
Closed

CodeJuggernaut wants to merge 18 commits into
mainfrom
fix/cloud-session-expiry-401

Conversation

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Summary

An expired cloud auth token left the app dead-ended: bare canvas, no chrome, no login prompt, and the Jobs poller spamming 401 once per poll. This converts a provider-rejected credential into a suspended session with an in-place recovery banner, so the user keeps their unsaved work instead of losing it.

Changes

  • What:
    • New sessionExpiry module owns suspend/resume state. Suspension is driven solely by Firebase's own sign-out (_logoutIfInvalidated, which fires on exactly user-disabled / user-token-expired), never by observing 401s — a 401 is per-endpoint and overloaded, so inferring session death from one would disrupt working users.
    • Suspension never navigates. SessionExpiredBanner (rendered through the shared NotificationPopup) warns the user to export unsaved changes and offers "Sign in again", which re-authenticates through the same provider they originally used, in a popup, and resumes in place.
    • Request seams (api.fetchApi, the Jobs poller) short-circuit while suspended, ending the 401 storm.
    • Draft ownership: drafts survive an expiry so re-authenticating restores the user's work, and are cleared only on a deliberate sign-out or when a different account signs in. The decision and the identity record are one atomic call, and both live in the auth hook rather than a canvas-scoped composable, because that composable's watchers are disposed on the first navigation while the hook's are not.
    • The cloud router guard no longer redirects a suspended session to the login route, which would unmount the canvas and destroy the work the banner just told the user to export.
  • Breaking: none.
  • Dependencies: none.

Review Focus

  • docs/adr/0011-derived-credential-lifecycle.md is edited. It stated that recovery is lazy and a backgrounded tab waits for the next read; terminal rejection is now identity-driven, so that is no longer accurate. Worth an architect's eye — this is a factual currency update, not a new architectural decision.
  • Accepted trade-off, deliberate: there is no cross-tab marker for "this sign-out was on purpose". A shared marker can only say a sign-out happened recently, never this one, so for as long as it lives a genuine expiry in any tab reads as deliberate and wipes drafts. The cost of omitting it is that a second open tab shows the expiry banner after you sign out elsewhere; the cost of including it is losing work. Chose the banner.
  • A different account signing in from the banner reloads the page. Clearing storage alone is not enough while the previous user's workflow is still open in memory — the persistence watcher would write it straight back under the new account. Only reachable via re-auth in place; every other route to a new account already does a full page load.
  • createSession() → createSessionOrThrow() in the resolve hook. This gates the resume on the cookie actually minting (previously it resumed unconditionally, since createSession swallows every error). Note it also means the Firebase ID token mints the cookie on that path; two existing login paths already do the same, but whoever owns /auth/session may want to confirm the scope is identical on a unified_cloud_auth deployment.
  • The router guard has no unit test. This repo has no router test harness — no test file constructs or exercises src/router.ts's guards. Rather than fabricate coverage, flagging it: an E2E test is the natural home.

Screenshots (if applicable)

Not included — real-browser verification could not be completed in this environment.

…ssion

A cloud session whose token had expired left the app on a bare canvas with no
chrome and no way out, while pollers re-issued 401s indefinitely. Nothing
converted a rejected token into a logout.

A 401 is now a trigger, never a verdict. It opens one investigation:
force-refresh the Firebase identity, then re-establish the session cookie with
that fresh identity. Only those two authoritative oracles may conclude the
session is dead, so an endpoint-specific 401 cannot sign anyone out, and
neither can an unreachable oracle. On a dead verdict the session cookie and
Firebase state are cleared and the app redirects to /cloud/login.

Concurrent 401s share one investigation and termination latches, so a poll loop
firing hundreds of 401s produces exactly one logout. Requests short-circuit
once terminated, so no further traffic is generated before the redirect.

Reporting lives in fetchWithUnifiedRemint and the axios interceptor, the two
seams every authenticated cloud request already passes through, rather than in
each caller. Only requests that carried a Bearer report, so the anonymous
first-load path is untouched.
The synthetic 401 returned by a terminated session still reached
fetchJobsRaw, which logs on any non-ok response. So the console kept
emitting "[Jobs API] Failed to fetch jobs: 401" between the verdict and
the redirect, even though no network request was being made.

Guard queueStore.update instead. It is the entry point for both the queue
and history fetches, so one check silences the loudest offender and stops
it re-polling, rather than editing each poll site.
What

- run the redirect in a finally so a throwing teardown cannot latch the
  kill switch with no way out
- memoize and guard the lazy imports so reportUnauthorized never rejects
- trigger on "signed in yet 401" instead of "carried a bearer token"
- treat only 401 from the session mint as a revoked session, not 403
- guard fetchJobsRaw rather than one of its four callers
- race the investigation against a timeout
- give the synthetic 401 a parseable body and a statusText
- skip the cooldown when no user is signed in yet
- drop the toast and its strings, and cover the report seam with tests

Why

- a revoked identity stops producing bearer tokens, so gating the report
  on one went blind in exactly the case this fix exists for
- 403 from the session mint means the identity was accepted and the
  authorization refused, which this repo already decodes that way
- terminate() latched before three unguarded statements, so a chunk-load
  failure would strand the app worse than the original bug
- the queueStore guard covered one of four callers reaching the log line

Notes

- reporting is deliberately not behind unified_cloud_auth; the dead-end
  predates that flag and reproduces with it off. Both stale contract
  comments now say so.
- the concurrent-import dedupe also fixed a test failure where 10+
  parallel reports raced module mock resolution
What

- back off exponentially on consecutive healthy verdicts, capped at 15m
- reset the backoff as soon as a verdict stops being healthy
- log a warning when a session is ended, so the event is observable

Why

- widening the trigger to "signed in yet 401" means an endpoint that 401s
  for its own reasons keeps reporting forever while the session is fine
- a flat 60s cooldown made that ~480 probes of the auth endpoint per day,
  and each probe is another chance for a transient 401 to read as a
  revoked identity
- detection speed is unaffected: a dying session returns dead on its first
  probe, and the first probe is never delayed
- the redirect is otherwise silent, so a false positive would be both
  indistinguishable from a real expiry and invisible in telemetry
… 401s

What

- replace the 401-triggered investigation with two expiry-driven triggers:
  Firebase's own involuntary sign-out, and a permanent failure of the
  scheduled Cloud JWT refresh
- delete the investigation, single-flight, tri-state verdict, cooldown,
  backoff, probe timeout and memoized loaders they required
- restore remintRetry.ts and useSessionCookie.ts to their prior contracts
- keep the terminated-session short-circuit in fetchApi and fetchJobsRaw

Why

- a 401 is per-endpoint and overloaded: missing entitlement, a resource
  outside the workspace, a feature the account lacks. Inferring session
  death from one is a guess, and a wrong guess signs out a working user
- @firebase/auth _logoutIfInvalidated already signs the user out on
  exactly auth/user-disabled and auth/user-token-expired, and on nothing
  else; ProactiveRefresh runs that check at expiry minus five minutes
- POST /api/auth/token is the single identity-exchange endpoint per the
  cloud service docs, and workspaceAuthStore already refreshes against it
  on an expiresAt timer; its permanent-failure branch cleared the token
  but left the app running, which is the dead-end being fixed
- both signals are driven by a known expiry, so nothing polls, and no
  endpoint's 401 can end a session

Notes

- the false-positive class is now designed out rather than bounded: no
  per-endpoint response participates in the decision
What

- narrow the Cloud JWT refresh trigger from every permanent auth error to
  INVALID_FIREBASE_TOKEN alone

Why

- PERMANENT_AUTH_ERROR_CODES also covers ACCESS_DENIED and
  WORKSPACE_NOT_FOUND, which /api/auth/token returns as 403 and 404 for a
  denied or deleted workspace
- both leave the user's credential valid, so treating them as a dead
  session would sign out a working user whose workspace changed
- clearing the unified token on those codes is still correct; only the
  redirect is now withheld
What

- bracket the three in-process sign-outs so they cannot read as an expiry:
  the deliberate logout, the requires-recent-login recovery, and the
  signup rollback that deletes a half-created Firebase user
- share one public-route list between the router and the expiry redirect
- corroborate a rejected identity with a forced refresh before ending the
  session, instead of trusting one un-retried 401 from our own backend
- release the terminated latch if the browser refuses to navigate
- assert the redirect in the workspace refresh tests, which previously
  drove all three status codes without checking it

Why

- user.delete() and the reauth recovery both call signOut(), so a failed
  signup or a password change hard-redirected a user whose credential was
  never expired
- the guard listed /cloud/oauth/consent, a legacy redirect stub; the live
  consent screen is /oauth/consent, so an OAuth flow was unprotected while
  the test asserting it passed
- /api/auth/token answering 401 means our backend disagrees with an
  identity provider that just issued a token; one disagreement is the same
  overloaded-401 inference this design removes
- a cancelled beforeunload left the latch set for the life of the tab,
  failing every cloud call silently

Notes

- reverting the identity-only narrowing now fails two tests; it previously
  passed all 91
What

- read the deliberate-sign-out flag synchronously at the logout hook, before
  the awaited deleteSession, instead of inside endExpiredSession
- stop the cloud-JWT refresh from ending a session at all; it now only asks
  the identity provider to re-issue, and Firebase decides
- route the router's public-path check through the shared predicate
- cover the hook with a test that models the real async interleaving

Why

- the flag was released when authStore.logout() resolved, which has no
  network call, while the hook only read it after a DELETE round-trip, so
  it was always back to zero: every deliberate sign-out still redirected,
  and the requires-recent-login recovery was destroyed mid-dialog
- a 401 from our own backend is not a verdict on the credential;
  requestToken collapses every 401 into INVALID_FIREBASE_TOKEN, so acting
  on it re-introduced the overloaded-401 inference this design removes
- the router matched the shared list exactly while the redirect matched by
  prefix, so one list carried two semantics

Notes

- the old bracket tests called endExpiredSession synchronously inside the
  bracket, a sequence no caller produces; they passed against inert code
What

- ask the identity provider to revalidate when the reactive re-mint hits an
  identity rejection, mirroring the scheduled refresh
- gate it on the identity code so a denied or missing workspace does not
  trigger a refresh

Why

- clearUnifiedContext nulls the unified token, and getAuthHeader returns
  null rather than falling back, so getIdToken is never called again
- Firebase's check is lazy-on-read in this app, so with nothing calling
  getIdToken a revoked credential is never noticed and the session never
  ends: the original dead-end, reproduced through the reactive path
- asking is not deciding; this adds no terminator, and endExpiredSession
  still has exactly one caller

Notes

- when the provider says the identity is alive the app is left token-less
  with no re-mint, since unifiedTarget is already cleared. That is existing
  clearUnifiedContext behaviour, not introduced here.
What

- keep the session terminated when the browser refuses to navigate, and
  re-attempt instead of releasing the latch
- guard fetchJobDetail, and correct the claim about which fetchers the
  chokepoint covers
- log when identity revalidation fails, rather than swallowing it
- cover both traffic-stopping seams, and the non-cloud guard, with tests
- correct the docstring that still named a second caller

Why

- the release restored the 401 storm in a default configuration: unsaved
  workflows arm the unload prompt, and a user who stays kept a dead
  session with both guards inert and no second redirect possible
- fetchJobDetail bypasses fetchJobsRaw, so it kept logging a wrong reason
- revalidation is the only thing left that can ask the provider once the
  unified context is cleared; a silent failure there is invisible
- the two guards that stop the traffic had no tests at all, and the
  non-cloud guard survived mutation because its suite pins isCloud true

Notes

- the query-string public-route case was vacuous; location.pathname never
  carries a query. Replaced with the prefix case that motivated startsWith.
What

- assert the guard is held for the whole sign-out and released after, at
  the real call site rather than through a mocked collaborator
- cover fetchJobDetail's terminated-session early return
- pin the revalidation warning so a silent failure cannot return
- reattach the endExpiredSession docstring to its own function

Why

- the guard could be deleted from its call sites with the suite fully
  green, so the property the change exists to protect was undefended
- terminated is now permanent, so a silent regression of that guard costs
  a dead tab rather than a ten second window
- the warning is the only observability on the path that decides whether
  a session is dead

Notes

- dropping the arming call now fails the new test; it previously passed
What

- retry the redirect on an interval rather than attempting it once
- cover the reauthentication recovery, which had no tests at all
- teach the error-handling test double to honour recovery strategies

Why

- a user with unsaved workflows gets the browser unload prompt; cancelling
  it left a tab with all traffic stopped and no further attempt, which
  looks exactly like the silent breakage this change removes
- the latch still never releases: the session is dead, so resuming cloud
  traffic would bring back the 401 storm
- the recovery signs out only to re-prompt in place, so it is the path
  where a stray redirect does the most damage, and nothing tested it
- the test double ignored the recovery argument, so that whole branch was
  unreachable from the suite
What

- suspend the session rather than navigating away, so the canvas and any
  unsaved work survive; resume it when a user signs back in
- show a banner warning the user to export unsaved changes, with an action
  that re-authenticates through the provider they originally used
- remember the signed-in identity while the session is healthy, since an
  expiry clears it before anything can read it
- keep persisted drafts across an expiry, and clear them only when a
  different account signs in on the machine
- retire the redirect, its retry timer and the shared public-route list

Why

- redirecting destroyed the unsaved graph, which survives on main today;
  the drafts were already being cleared the moment Firebase signed the
  user out, so the previous behaviour lost both
- the OAuth providers already sign in through a popup that returns to its
  opener, so re-authenticating never has to leave the page
- email has no popup, and an uncaptured provider must not be guessed, so
  both fall back to the existing in-app sign-in dialog
- a false positive now costs a banner rather than a destroyed page

Notes

- deliberate sign-out still clears drafts, so the shared-machine property
  the wipe was written for is preserved
What

- gate the logout wipe on the deliberate-sign-out flag, which is readable
  synchronously, instead of a suspension set behind an awaited network call
- persist the last signed-in uid, and treat "nothing recorded" as the same
  user rather than a stranger
- suspend before the awaited teardown, and resume only once the session
  cookie is back
- make the deliberate-sign-out signal cross-tab
- keep the banner clear of the menubar, and mount it only on cloud
- cover all five draft outcomes, and drop assertions that could not fail

Why

- the suspension guard could never be true at the point it was read, so an
  expiry wiped the drafts it was meant to keep
- remembered identity is module state, null on every load, so an ordinary
  refresh read the returning user as a stranger and cleared their work
- Firebase propagates a sign-out to every tab, but a per-tab counter does
  not, so a deliberate sign-out suspended sibling tabs
- the banner sat over the export menu its own copy points the user at
- the persistence hooks were stubbed inert, which is why both defects
  passed a green suite

Notes

- the workspace-auth assertions referenced symbols that no longer exist on
  a store that never imported them; they could not fail and are removed
What

- remove the cross-tab marker once the outermost sign-out completes
- forget the remembered identity on a deliberate sign-out
- assert the counter's nesting behaviour instead of a storage key that
  nothing ever removed
- assert the reactive mirror the banner actually binds to
- reset the session singleton between persistence tests

Why

- the marker was written but never cleared, so the guard stayed armed for
  ten seconds after every sign-out; a genuine expiry in that window was
  read as deliberate, which skipped the banner, left cloud traffic
  flowing, and wiped the drafts the previous commit set out to protect
- the nesting test asserted a key that could not be absent, so the entire
  counter was mutation-uncovered
- suspend and resume could each skip the ref with no test failing, which
  is the difference between the banner appearing and not
- one test's unbalanced bracket leaked into the next, so the suite failed
  under shuffle and the cold-start case passed for the wrong reason

Notes

- these tests only fail where localStorage exists. Node 26 has none unless
  --localstorage-file is passed, so the earlier runs silently skipped every
  storage path; verified against a browser-like run.
An expired cloud token left the app dead-ended: bare canvas, no chrome,
no login prompt, and the Jobs poller retrying 401 once per poll.

Suspension is driven only by Firebase signing the user out, which it does
on exactly user-disabled and user-token-expired. A 401 is per-endpoint and
overloaded, so inferring session death from one would disrupt users whose
credential is fine.

Suspending never navigates. A banner on the shared notification surface
warns the user to export unsaved changes and offers to sign in again
through the provider they originally used, in a popup, resuming in place.
Request seams short-circuit while suspended, ending the 401 storm.

Drafts survive an expiry so re-authenticating restores the user's work,
and are cleared only on a deliberate sign-out or when a different account
signs in. That decision and the identity record are one atomic call, and
both live in the auth hook rather than a canvas-scoped composable, whose
watchers are disposed on the first navigation.

The cloud route guard no longer redirects a suspended session to login,
which would unmount the canvas and destroy the work the banner just told
the user to export.

Minting the session cookie now gates the resume, and the banner drives its
own restore: the auth-state observer only reports a uid change, so a retry
by the same user after a failed mint would otherwise never clear.
@CodeJuggernaut
CodeJuggernaut requested a review from a team July 28, 2026 18:30
@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 28, 2026
@github-actions

github-actions Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1755 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1734 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/29/2026, 03:31:12 PM UTC

Links

📦 Bundle: 8.15 MB gzip 🔴 +7.2 kB

Details

Summary

  • Raw size: 34.2 MB baseline 34.2 MB — 🔴 +17.6 kB
  • Gzip: 8.15 MB baseline 8.14 MB — 🔴 +7.2 kB
  • Brotli: 5.64 MB baseline 5.63 MB — 🔴 +5.99 kB
  • Bundles: 420 current • 418 baseline • 153 added / 151 removed

Category Glance
Other 🔴 +13.6 kB (12.5 MB) · Data & Services 🔴 +3.49 kB (3.43 MB) · Utilities & Hooks 🔴 +3.31 kB (372 kB) · Graph Workspace 🟢 -3.28 kB (1.28 MB) · Panels & Settings 🔴 +346 B (551 kB) · App Entry Points 🔴 +108 B (3.74 kB) · + 5 more

App Entry Points — 3.74 kB (baseline 3.63 kB) • 🔴 +108 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-d2D9LzCn.js (new) — 3.74 kB 🔴 +3.74 kB 🔴 +1.88 kB 🔴 +1.64 kB
assets/index-CsWqoSZA.js (removed) 3.63 kB — 🟢 -3.63 kB 🟢 -1.82 kB 🟢 -1.58 kB

Status: 1 added / 1 removed

Graph Workspace — 1.28 MB (baseline 1.28 MB) • 🟢 -3.28 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DjInXjPN.js (removed) 1.28 MB — 🟢 -1.28 MB 🟢 -275 kB 🟢 -207 kB
assets/GraphView-BsvaVLKE.js (new) — 1.28 MB 🔴 +1.28 MB 🔴 +275 kB 🔴 +207 kB

Status: 1 added / 1 removed / 1 unchanged

Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-DSlXnsOc.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.26 kB 🟢 -5.54 kB
assets/CloudSurveyView-XjrFpXsP.js (new) — 25 kB 🔴 +25 kB 🔴 +6.26 kB 🔴 +5.54 kB
assets/CloudLoginView-BwJDyqQf.js (new) — 11.6 kB 🔴 +11.6 kB 🔴 +3.14 kB 🔴 +2.76 kB
assets/CloudLoginView-C9fVR7y7.js (removed) 11.6 kB — 🟢 -11.6 kB 🟢 -3.14 kB 🟢 -2.75 kB
assets/CloudSignupView-KxSu0OC1.js (new) — 9.96 kB 🔴 +9.96 kB 🔴 +2.81 kB 🔴 +2.46 kB
assets/CloudSignupView-XPWLSrn-.js (removed) 9.96 kB — 🟢 -9.96 kB 🟢 -2.81 kB 🟢 -2.47 kB
assets/CloudLayoutView-C8xroFVG.js (new) — 9.54 kB 🔴 +9.54 kB 🔴 +2.35 kB 🔴 +2.03 kB
assets/CloudLayoutView-Cr356rip.js (removed) 9.54 kB — 🟢 -9.54 kB 🟢 -2.35 kB 🟢 -2.02 kB
assets/UserCheckView-3WqeBDkU.js (removed) 8.8 kB — 🟢 -8.8 kB 🟢 -2.22 kB 🟢 -1.93 kB
assets/UserCheckView-DlZ7E2Ln.js (new) — 8.8 kB 🔴 +8.8 kB 🔴 +2.22 kB 🔴 +1.93 kB
assets/WidgetTextPreview-BAYehdVD.js (removed) 6.13 kB — 🟢 -6.13 kB 🟢 -2.16 kB 🟢 -1.92 kB
assets/WidgetTextPreview-CFeqt-w2.js (new) — 6.13 kB 🔴 +6.13 kB 🔴 +2.16 kB 🔴 +1.91 kB
assets/CloudSubscriptionRedirectView-Burm4LR1.js (removed) 6.06 kB — 🟢 -6.06 kB 🟢 -2.26 kB 🟢 -1.97 kB
assets/CloudSubscriptionRedirectView-CXZ_VtVe.js (new) — 6.06 kB 🔴 +6.06 kB 🔴 +2.26 kB 🔴 +1.96 kB
assets/UserSelectView-BOOGLuAk.js (new) — 5.54 kB 🔴 +5.54 kB 🔴 +1.99 kB 🔴 +1.74 kB
assets/UserSelectView-vyIvkPmT.js (removed) 5.54 kB — 🟢 -5.54 kB 🟢 -1.99 kB 🟢 -1.74 kB
assets/CloudForgotPasswordView-BX92UhkI.js (new) — 5.15 kB 🔴 +5.15 kB 🔴 +1.76 kB 🔴 +1.54 kB
assets/CloudForgotPasswordView-Cy2ntLUq.js (removed) 5.15 kB — 🟢 -5.15 kB 🟢 -1.76 kB 🟢 -1.54 kB
assets/CloudAuthTimeoutView-lynN79Q6.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.57 kB 🟢 -1.36 kB
assets/CloudAuthTimeoutView-ng2a_MzC.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.57 kB 🔴 +1.37 kB
assets/OAuthLayoutView-DcODhJAX.js (new) — 1.36 kB 🔴 +1.36 kB 🔴 +736 B 🔴 +621 B
assets/OAuthLayoutView-wSs82b-U.js (removed) 1.36 kB — 🟢 -1.36 kB 🟢 -735 B 🟢 -620 B
assets/WidgetTextPreview-DGZm6-pC.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +95 B
assets/WidgetTextPreview-Y1VNL8kJ.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -89 B

Status: 12 added / 12 removed / 4 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • 🔴 +346 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-Bg4a7Yab.js (removed) 49.5 kB — 🟢 -49.5 kB 🟢 -9.97 kB 🟢 -8.83 kB
assets/KeybindingPanel-DAV7xIrM.js (new) — 49.5 kB 🔴 +49.5 kB 🔴 +9.97 kB 🔴 +8.84 kB
assets/SecretsPanel-B6GLqi8m.js (removed) 31.3 kB — 🟢 -31.3 kB 🟢 -7.62 kB 🟢 -6.67 kB
assets/SecretsPanel-G3UjCghD.js (new) — 31.3 kB 🔴 +31.3 kB 🔴 +7.62 kB 🔴 +6.67 kB
assets/CreditsPanel-DXNVgrkD.js (removed) 16 kB — 🟢 -16 kB 🟢 -4.66 kB 🟢 -4.12 kB
assets/CreditsPanel-V7ufJZ0X.js (new) — 16 kB 🔴 +16 kB 🔴 +4.66 kB 🔴 +4.09 kB
assets/SubscriptionPanel-D27Fvsd9.js (new) — 11.5 kB 🔴 +11.5 kB 🔴 +3.67 kB 🔴 +3.23 kB
assets/SubscriptionPanel-yK4knELj.js (removed) 11.5 kB — 🟢 -11.5 kB 🟢 -3.65 kB 🟢 -3.2 kB
assets/AboutPanel-DCnu4TjK.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.06 kB 🟢 -2.74 kB
assets/AboutPanel-DOs-WkiW.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.06 kB 🔴 +2.74 kB
assets/ExtensionPanel-9IMICb3g.js (removed) 9.24 kB — 🟢 -9.24 kB 🟢 -2.54 kB 🟢 -2.25 kB
assets/ExtensionPanel-DMcP9PXF.js (new) — 9.24 kB 🔴 +9.24 kB 🔴 +2.54 kB 🔴 +2.25 kB
assets/ServerConfigPanel-Bj-XX5-x.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.97 kB 🟢 -1.75 kB
assets/ServerConfigPanel-CKVVg8EE.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.97 kB 🔴 +1.75 kB
assets/UserPanel-BWWqzxvt.js (new) — 5.78 kB 🔴 +5.78 kB 🔴 +1.81 kB 🔴 +1.57 kB
assets/UserPanel-kTE_DBrE.js (removed) 5.78 kB — 🟢 -5.78 kB 🟢 -1.81 kB 🟢 -1.57 kB
assets/refreshRemoteConfig-Eyr5dd8a.js (new) — 3.28 kB 🔴 +3.28 kB 🔴 +1.41 kB 🔴 +1.25 kB
assets/refreshRemoteConfig-BDYaUUl9.js (removed) 2.97 kB — 🟢 -2.97 kB 🟢 -1.27 kB 🟢 -1.11 kB
assets/cloudRemoteConfig-CpPTu4F2.js (new) — 988 B 🔴 +988 B 🔴 +535 B 🔴 +446 B
assets/cloudRemoteConfig-CQatJLIF.js (removed) 988 B — 🟢 -988 B 🟢 -538 B 🟢 -454 B
assets/refreshRemoteConfig-D7jHlU8f.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +81 B
assets/refreshRemoteConfig-DwSkRaXk.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -82 B

Status: 11 added / 11 removed / 15 unchanged

User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-D3OqYyqs.js (new) — 12.3 kB 🔴 +12.3 kB 🔴 +4.18 kB 🔴 +3.65 kB
assets/SignUpForm-MfYfc2iA.js (removed) 12.3 kB — 🟢 -12.3 kB 🟢 -4.18 kB 🟢 -3.65 kB
assets/auth-DO7yDh-R.js (removed) 3.69 kB — 🟢 -3.69 kB 🟢 -1.3 kB 🟢 -1.12 kB
assets/auth-DySMnNX5.js (new) — 3.69 kB 🔴 +3.69 kB 🔴 +1.3 kB 🔴 +1.12 kB
assets/usePostAuthRedirect-BjfekIaC.js (new) — 3.33 kB 🔴 +3.33 kB 🔴 +1.27 kB 🔴 +1.11 kB
assets/usePostAuthRedirect-D-eJ9zRm.js (removed) 3.33 kB — 🟢 -3.33 kB 🟢 -1.27 kB 🟢 -1.11 kB
assets/UpdatePasswordContent-CNcS5N-d.js (removed) 1.91 kB — 🟢 -1.91 kB 🟢 -872 B 🟢 -760 B
assets/UpdatePasswordContent-DqsToCwF.js (new) — 1.91 kB 🔴 +1.91 kB 🔴 +871 B 🔴 +760 B
assets/authStore-BIMDnozM.js (removed) 128 B — 🟢 -128 B 🟢 -104 B 🟢 -104 B
assets/authStore-CQ12jFOu.js (new) — 128 B 🔴 +128 B 🔴 +104 B 🔴 +107 B
assets/workspaceAuthStore-CpX0kzuZ.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +105 B
assets/workspaceAuthStore-iu3p1_8P.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -104 B
assets/auth-BQYobRFX.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -74 B
assets/auth-CEquikxy.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +89 B

Status: 7 added / 7 removed / 3 unchanged

Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-BVqej7nn.js (removed) 89.9 kB — 🟢 -89.9 kB 🟢 -19.2 kB 🟢 -16.4 kB
assets/ComfyHubPublishDialog-DO4ycCu5.js (new) — 89.9 kB 🔴 +89.9 kB 🔴 +19.2 kB 🔴 +16.5 kB
assets/useShareDialog-Tx_2kbCb.js (removed) 23.7 kB — 🟢 -23.7 kB 🟢 -5.58 kB 🟢 -4.96 kB
assets/useShareDialog-VGopMmYf.js (new) — 23.7 kB 🔴 +23.7 kB 🔴 +5.58 kB 🔴 +4.96 kB
assets/feedbackDialog-Bh6bILTf.js (removed) 4.5 kB — 🟢 -4.5 kB 🟢 -1.9 kB 🟢 -1.62 kB
assets/feedbackDialog-BN2WK0y9.js (new) — 4.5 kB 🔴 +4.5 kB 🔴 +1.9 kB 🔴 +1.62 kB
assets/ComfyHubPublishDialog-CB-jGoFl.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -93 B
assets/ComfyHubPublishDialog-ChgkfTaN.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +94 B
assets/useSubscriptionDialog-BobDoMPd.js (new) — 108 B 🔴 +108 B 🔴 +102 B 🔴 +96 B
assets/useSubscriptionDialog-EfmIlsoH.js (removed) 108 B — 🟢 -108 B 🟢 -102 B 🟢 -93 B

Status: 5 added / 5 removed / 1 unchanged

UI Components — 64.8 kB (baseline 64.8 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-D9baAEh2.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.76 kB 🟢 -3.34 kB
assets/ComfyQueueButton-XxxRaMlN.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.77 kB 🔴 +3.34 kB
assets/useTerminalTabs-D9ioTRRp.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.72 kB 🟢 -3.29 kB
assets/useTerminalTabs-Dr06AYI1.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.72 kB 🔴 +3.29 kB
assets/InviteMembersForm-B1UZTOzy.js (removed) 8.02 kB — 🟢 -8.02 kB 🟢 -2.68 kB 🟢 -2.39 kB
assets/InviteMembersForm-BgQCyvy-.js (new) — 8.02 kB 🔴 +8.02 kB 🔴 +2.67 kB 🔴 +2.4 kB
assets/SubscribeButton-DJSt-ruN.js (new) — 2.18 kB 🔴 +2.18 kB 🔴 +986 B 🔴 +863 B
assets/SubscribeButton-ik8Qx8jQ.js (removed) 2.18 kB — 🟢 -2.18 kB 🟢 -988 B 🟢 -864 B
assets/cloudFeedbackTopbarButton-CksdAVWU.js (new) — 768 B 🔴 +768 B 🔴 +451 B 🔴 +413 B
assets/cloudFeedbackTopbarButton-DVecPQbn.js (removed) 768 B — 🟢 -768 B 🟢 -452 B 🟢 -411 B
assets/ComfyQueueButton-CRdopC41.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +92 B
assets/ComfyQueueButton-PlVg1-BR.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -90 B

Status: 6 added / 6 removed / 8 unchanged

Data & Services — 3.43 MB (baseline 3.42 MB) • 🔴 +3.49 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-Cm11S8r1.js (new) — 3.15 MB 🔴 +3.15 MB 🔴 +730 kB 🔴 +550 kB
assets/settingStore-CpHIULBI.js (removed) 3.15 MB — 🟢 -3.15 MB 🟢 -729 kB 🟢 -549 kB
assets/load3dService-Bm-DA3eG.js (new) — 132 kB 🔴 +132 kB 🔴 +29.3 kB 🔴 +24.7 kB
assets/load3dService-Crmlpzva.js (removed) 132 kB — 🟢 -132 kB 🟢 -29.2 kB 🟢 -24.6 kB
assets/api-GWZO2tJc.js (new) — 92.2 kB 🔴 +92.2 kB 🔴 +25.5 kB 🔴 +21.9 kB
assets/api-Cf-_NNkp.js (removed) 91.4 kB — 🟢 -91.4 kB 🟢 -25.3 kB 🟢 -21.7 kB
assets/workflowShareService-CMDj9ksf.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.92 kB 🔴 +4.36 kB
assets/workflowShareService-DHv3C81N.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.92 kB 🟢 -4.36 kB
assets/keybindingService-BeuaHJzJ.js (new) — 7.28 kB 🔴 +7.28 kB 🔴 +1.9 kB 🔴 +1.62 kB
assets/keybindingService-ZEhjMk7R.js (removed) 7.28 kB — 🟢 -7.28 kB 🟢 -1.9 kB 🟢 -1.62 kB
assets/releaseStore-BLScDsBQ.js (new) — 6.77 kB 🔴 +6.77 kB 🔴 +2.06 kB 🔴 +1.81 kB
assets/releaseStore-BWYial9Z.js (removed) 6.77 kB — 🟢 -6.77 kB 🟢 -2.06 kB 🟢 -1.8 kB
assets/systemStatsStore-D0sPpudS.js (removed) 4.99 kB — 🟢 -4.99 kB 🟢 -1.77 kB 🟢 -1.5 kB
assets/systemStatsStore-ib3tYKrU.js (new) — 4.99 kB 🔴 +4.99 kB 🔴 +1.77 kB 🔴 +1.5 kB
assets/userStore-Bol_RHGq.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +932 B 🔴 +818 B
assets/userStore-D2aHHYMC.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -930 B 🟢 -826 B
assets/audioService-B_GjMe3e.js (new) — 1.76 kB 🔴 +1.76 kB 🔴 +863 B 🔴 +749 B
assets/audioService-D6RiZq5F.js (removed) 1.76 kB — 🟢 -1.76 kB 🟢 -862 B 🟢 -747 B
assets/dialogService-Ck3HYUHk.js (removed) 98 B — 🟢 -98 B 🟢 -97 B 🟢 -97 B
assets/dialogService-DiPSCUUA.js (new) — 98 B 🔴 +98 B 🔴 +97 B 🔴 +83 B
assets/releaseStore-C-Xz1ZQm.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -82 B
assets/releaseStore-DOdOBdGW.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +88 B
assets/settingStore-BjsGHE4i.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -89 B
assets/settingStore-Cy7FSllO.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +82 B
assets/assetsStore-4t8MBry8.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +85 B
assets/assetsStore-B9B5AZCz.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -83 B
assets/api-UAWmlRj7.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B
assets/api-w9hJJ97x.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B

Status: 14 added / 14 removed / 3 unchanged

Utilities & Hooks — 372 kB (baseline 369 kB) • 🔴 +3.31 kB

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-Dojufzbh.js (new) — 238 kB 🔴 +238 kB 🔴 +53.3 kB 🔴 +43.2 kB
assets/useConflictDetection-BQOQPqlZ.js (removed) 235 kB — 🟢 -235 kB 🟢 -52.5 kB 🟢 -42.7 kB
assets/useLoad3d-Cpmnv2Ys.js (removed) 25.8 kB — 🟢 -25.8 kB 🟢 -5.82 kB 🟢 -5.15 kB
assets/useLoad3d-fui5F2X_.js (new) — 25.8 kB 🔴 +25.8 kB 🔴 +5.82 kB 🔴 +5.15 kB
assets/useLoad3dViewer-a7Pz71se.js (new) — 21.3 kB 🔴 +21.3 kB 🔴 +5 kB 🔴 +4.4 kB
assets/useLoad3dViewer-D-ZVg5m0.js (removed) 21.3 kB — 🟢 -21.3 kB 🟢 -5 kB 🟢 -4.38 kB
assets/useFeatureFlags-BWu1DbPZ.js (new) — 7.26 kB 🔴 +7.26 kB 🔴 +2.17 kB 🔴 +1.83 kB
assets/useFeatureFlags-CmJS7siG.js (removed) 7.26 kB — 🟢 -7.26 kB 🟢 -2.17 kB 🟢 -1.83 kB
assets/useDowngradeToPersonal-eZkh-5yD.js (removed) 5.9 kB — 🟢 -5.9 kB 🟢 -1.8 kB 🟢 -1.57 kB
assets/useDowngradeToPersonal-umKs92Dg.js (new) — 5.9 kB 🔴 +5.9 kB 🔴 +1.8 kB 🔴 +1.57 kB
assets/useExternalLink-Bl0Ph4gB.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.09 kB 🔴 +949 B
assets/useExternalLink-D5II54f4.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.09 kB 🟢 -947 B
assets/downloadUtil-B9ifpnQU.js (new) — 2.45 kB 🔴 +2.45 kB 🔴 +1.11 kB 🔴 +899 B
assets/downloadUtil-DahO98Sa.js (removed) 2.45 kB — 🟢 -2.45 kB 🟢 -1.11 kB 🟢 -898 B
assets/assetPreviewUtil-BGdUjLxY.js (removed) 2.41 kB — 🟢 -2.41 kB 🟢 -1 kB 🟢 -873 B
assets/assetPreviewUtil-BOZeHvT3.js (new) — 2.41 kB 🔴 +2.41 kB 🔴 +1 kB 🔴 +874 B
assets/useUpstreamValue-BDwLYkmh.js (new) — 2.04 kB 🔴 +2.04 kB 🔴 +788 B 🔴 +702 B
assets/useUpstreamValue-D8A-LXKN.js (removed) 2.04 kB — 🟢 -2.04 kB 🟢 -788 B 🟢 -703 B
assets/useWorkspaceTierLabel-Be0O3pJN.js (new) — 1.99 kB 🔴 +1.99 kB 🔴 +847 B 🔴 +732 B
assets/useWorkspaceTierLabel-DxrcH-BO.js (removed) 1.99 kB — 🟢 -1.99 kB 🟢 -844 B 🟢 -728 B
assets/useErrorHandling-CSWMCP82.js (new) — 1.54 kB 🔴 +1.54 kB 🔴 +647 B 🔴 +551 B
assets/useErrorHandling-mWe1Mlf7.js (removed) 1.54 kB — 🟢 -1.54 kB 🟢 -646 B 🟢 -547 B
assets/subscriptionCheckoutUtil-Crz_ldqf.js (new) — 903 B 🔴 +903 B 🔴 +535 B 🔴 +456 B
assets/subscriptionCheckoutUtil-J9TkF82y.js (removed) 903 B — 🟢 -903 B 🟢 -537 B 🟢 -455 B
assets/useSessionCookie-Bt2GtnOg.js (removed) 746 B — 🟢 -746 B 🟢 -388 B 🟢 -336 B
assets/useSessionCookie-DhI_CsAW.js (new) — 746 B 🔴 +746 B 🔴 +390 B 🔴 +333 B
assets/useLoad3d-C_KxukuU.js (removed) 311 B — 🟢 -311 B 🟢 -162 B 🟢 -147 B
assets/useLoad3d-yc_-_erP.js (new) — 311 B 🔴 +311 B 🔴 +165 B 🔴 +148 B
assets/useSessionCookie-BFCzqvAE.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +80 B
assets/useSessionCookie-DyH8BRMf.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -85 B
assets/useFeatureFlags-C-MA-0bD.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -79 B
assets/useFeatureFlags-TYizg0L4.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +80 B
assets/useLoad3dViewer-CZ8Yeeeg.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -86 B
assets/useLoad3dViewer-DndJ4xwB.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +92 B
assets/useCurrentUser-BjbFi01H.js (removed) 94 B — 🟢 -94 B 🟢 -95 B 🟢 -85 B
assets/useCurrentUser-mexqxaEm.js (new) — 94 B 🔴 +94 B 🔴 +95 B 🔴 +85 B

Status: 18 added / 18 removed / 17 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.5 MB (baseline 12.5 MB) • 🔴 +13.6 kB

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-Dmu5RrvZ.js (new) — 195 kB 🔴 +195 kB 🔴 +57.1 kB 🔴 +47.9 kB
assets/main-CNXm6Bpt.js (removed) 195 kB — 🟢 -195 kB 🟢 -57 kB 🟢 -47.9 kB
assets/core-YB5L-Xyw.js (new) — 111 kB 🔴 +111 kB 🔴 +28.7 kB 🔴 +24.3 kB
assets/core-Joe3u90m.js (removed) 111 kB — 🟢 -111 kB 🟢 -28.7 kB 🟢 -24.3 kB
assets/WidgetSelect-CqEvbDhi.js (new) — 88 kB 🔴 +88 kB 🔴 +20 kB 🔴 +17.1 kB
assets/WidgetSelect-h0RqTUfB.js (removed) 88 kB — 🟢 -88 kB 🟢 -20 kB 🟢 -17.1 kB
assets/Load3D-Ba2-03Q3.js (removed) 71.3 kB — 🟢 -71.3 kB 🟢 -11.7 kB 🟢 -10 kB
assets/Load3D-BB1-6nMC.js (new) — 71.3 kB 🔴 +71.3 kB 🔴 +11.7 kB 🔴 +10 kB
assets/WorkspaceSettingsPanelContent-D51QxzyI.js (removed) 61.6 kB — 🟢 -61.6 kB 🟢 -13.2 kB 🟢 -11.5 kB
assets/WorkspaceSettingsPanelContent-h142bKed.js (new) — 61.6 kB 🔴 +61.6 kB 🔴 +13.2 kB 🔴 +11.5 kB
assets/Preview3d-CCE1jPmI.js (removed) 50.9 kB — 🟢 -50.9 kB 🟢 -8.34 kB 🟢 -7.26 kB
assets/Preview3d-yhwJnRDJ.js (new) — 50.9 kB 🔴 +50.9 kB 🔴 +8.34 kB 🔴 +7.27 kB
assets/main-CMvNSw5c.js (new) — 50.7 kB 🔴 +50.7 kB 🔴 +15.1 kB 🔴 +13 kB
assets/main-D74HssDn.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -13.8 kB 🟢 -11.9 kB
assets/SubscriptionTransitionPreviewWorkspace-DmYJjtOR.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +9.67 kB 🔴 +8.47 kB
assets/SubscriptionTransitionPreviewWorkspace-e_najudi.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -9.64 kB 🟢 -8.46 kB
assets/SubscriptionRequiredDialogContentUnified-DLZAA8xq.js (removed) 42.1 kB — 🟢 -42.1 kB 🟢 -9.37 kB 🟢 -8.16 kB
assets/SubscriptionRequiredDialogContentUnified-v3-B8tW_.js (new) — 42.1 kB 🔴 +42.1 kB 🔴 +9.37 kB 🔴 +8.16 kB
assets/MembersPanelContent-C5SlxPQQ.js (removed) 41.9 kB — 🟢 -41.9 kB 🟢 -8.8 kB 🟢 -7.84 kB
assets/MembersPanelContent-ConRfIZp.js (new) — 41.9 kB 🔴 +41.9 kB 🔴 +8.8 kB 🔴 +7.84 kB
assets/WidgetBoundingBoxes-CdfRU5gp.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +9.19 kB 🔴 +8.15 kB
assets/WidgetBoundingBoxes-Dxpax5P9.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -9.19 kB 🟢 -8.16 kB
assets/WidgetPainter-B1lWLGf6.js (removed) 32.7 kB — 🟢 -32.7 kB 🟢 -7.9 kB 🟢 -7 kB
assets/WidgetPainter-C4UbbUhj.js (new) — 32.7 kB 🔴 +32.7 kB 🔴 +7.9 kB 🔴 +6.98 kB
assets/Load3dViewerContent-2Xs8uOh2.js (removed) 30.8 kB — 🟢 -30.8 kB 🟢 -6.29 kB 🟢 -5.45 kB
assets/Load3dViewerContent-C4oRZVRP.js (new) — 30.8 kB 🔴 +30.8 kB 🔴 +6.29 kB 🔴 +5.46 kB
assets/HdrViewerContent-CaadbiyX.js (new) — 29.8 kB 🔴 +29.8 kB 🔴 +8.28 kB 🔴 +7.3 kB
assets/HdrViewerContent-FoIdcV40.js (removed) 29.8 kB — 🟢 -29.8 kB 🟢 -8.28 kB 🟢 -7.3 kB
assets/SubscriptionPanelContentWorkspace-BfEM2RpP.js (removed) 26.6 kB — 🟢 -26.6 kB 🟢 -6.21 kB 🟢 -5.45 kB
assets/SubscriptionPanelContentWorkspace-CR9V2qB2.js (new) — 26.6 kB 🔴 +26.6 kB 🔴 +6.21 kB 🔴 +5.46 kB
assets/SubscriptionRequiredDialogContent-CBC9VtZI.js (new) — 26.1 kB 🔴 +26.1 kB 🔴 +6.17 kB 🔴 +5.44 kB
assets/SubscriptionRequiredDialogContent-yXr64P3t.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -6.17 kB 🟢 -5.43 kB
assets/SubscriptionRequiredDialogContentWorkspace-AmwcYY21.js (removed) 24.9 kB — 🟢 -24.9 kB 🟢 -5.76 kB 🟢 -5.07 kB
assets/SubscriptionRequiredDialogContentWorkspace-DKbkKgOv.js (new) — 24.9 kB 🔴 +24.9 kB 🔴 +5.76 kB 🔴 +5.06 kB
assets/WidgetImageCrop-BJufwRZF.js (removed) 23.3 kB — 🟢 -23.3 kB 🟢 -5.75 kB 🟢 -5.04 kB
assets/WidgetImageCrop-D68gNVLr.js (new) — 23.3 kB 🔴 +23.3 kB 🔴 +5.75 kB 🔴 +5.04 kB
assets/load3d-_1QWFWvt.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.44 kB 🔴 +4.69 kB
assets/load3d-Dzr5emKF.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.43 kB 🟢 -4.69 kB
assets/CurrentUserPopoverWorkspace-B-WiGAgb.js (removed) 20.5 kB — 🟢 -20.5 kB 🟢 -4.71 kB 🟢 -4.19 kB
assets/CurrentUserPopoverWorkspace-BfPLTEDS.js (new) — 20.5 kB 🔴 +20.5 kB 🔴 +4.71 kB 🔴 +4.2 kB
assets/SignInContent-DjThtZ8G.js (removed) 20.3 kB — 🟢 -20.3 kB 🟢 -5.13 kB 🟢 -4.48 kB
assets/SignInContent-DWp5kn9L.js (new) — 20.3 kB 🔴 +20.3 kB 🔴 +5.13 kB 🔴 +4.48 kB
assets/WidgetInputNumber-DdgahLgo.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.83 kB 🔴 +4.29 kB
assets/WidgetInputNumber-ZTHK_km-.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.83 kB 🟢 -4.29 kB
assets/CreditsTile-C1e90Skg.js (removed) 17.2 kB — 🟢 -17.2 kB 🟢 -4.57 kB 🟢 -4.03 kB
assets/CreditsTile-CXCS-QsI.js (new) — 17.2 kB 🔴 +17.2 kB 🔴 +4.57 kB 🔴 +4.04 kB
assets/WidgetRange-Cv7XkeK5.js (new) — 16.7 kB 🔴 +16.7 kB 🔴 +4.31 kB 🔴 +3.86 kB
assets/WidgetRange-SJNjAi3h.js (removed) 16.7 kB — 🟢 -16.7 kB 🟢 -4.31 kB 🟢 -3.86 kB
assets/WidgetRecordAudio-CEXZgF6g.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.63 kB 🟢 -4.13 kB
assets/WidgetRecordAudio-lVnoJQGU.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.63 kB 🔴 +4.12 kB
assets/WaveAudioPlayer-B9jfJia2.js (new) — 12.8 kB 🔴 +12.8 kB 🔴 +3.5 kB 🔴 +3.07 kB
assets/WaveAudioPlayer-CnA5vjFc.js (removed) 12.8 kB — 🟢 -12.8 kB 🟢 -3.5 kB 🟢 -3.06 kB
assets/i18n-CuDDk8VH.js (removed) 12.6 kB — 🟢 -12.6 kB 🟢 -3.34 kB 🟢 -2.81 kB
assets/i18n-DLTn61re.js (new) — 12.6 kB 🔴 +12.6 kB 🔴 +3.33 kB 🔴 +2.81 kB
assets/WidgetCurve-B2rjvi9Q.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.51 kB 🟢 -3.17 kB
assets/WidgetCurve-CDaJkhCJ.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.5 kB 🔴 +3.16 kB
assets/AudioPreviewPlayer-CNSyB-ed.js (new) — 10.6 kB 🔴 +10.6 kB 🔴 +3.08 kB 🔴 +2.74 kB
assets/AudioPreviewPlayer-Cz1AegVz.js (removed) 10.6 kB — 🟢 -10.6 kB 🟢 -3.08 kB 🟢 -2.75 kB
assets/TeamWorkspacesDialogContent-bdkWOaBc.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -3 kB 🟢 -2.66 kB
assets/TeamWorkspacesDialogContent-Dan51Cpe.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +3 kB 🔴 +2.65 kB
assets/onboardingCloudRoutes-CbRg10iE.js (new) — 9.1 kB 🔴 +9.1 kB 🔴 +2.79 kB 🔴 +2.38 kB
assets/onboardingCloudRoutes-CD2C-6zf.js (removed) 9.02 kB — 🟢 -9.02 kB 🟢 -2.76 kB 🟢 -2.39 kB
assets/Load3DConfiguration-DoUNUXMc.js (new) — 8.97 kB 🔴 +8.97 kB 🔴 +2.63 kB 🔴 +2.32 kB
assets/Load3DConfiguration-sKuo6_h9.js (removed) 8.97 kB — 🟢 -8.97 kB 🟢 -2.63 kB 🟢 -2.32 kB
assets/SetMemberCreditLimitDialogContent-azn2Epnx.js (removed) 8.54 kB — 🟢 -8.54 kB 🟢 -2.37 kB 🟢 -2.07 kB
assets/SetMemberCreditLimitDialogContent-C4smyEDv.js (new) — 8.54 kB 🔴 +8.54 kB 🔴 +2.37 kB 🔴 +2.07 kB
assets/nodeTemplates-BOTc77_3.js (new) — 8.33 kB 🔴 +8.33 kB 🔴 +2.87 kB 🔴 +2.52 kB
assets/nodeTemplates-C1mzIhNM.js (removed) 8.33 kB — 🟢 -8.33 kB 🟢 -2.87 kB 🟢 -2.54 kB
assets/NightlySurveyController-awHq1bHV.js (new) — 7.56 kB 🔴 +7.56 kB 🔴 +2.59 kB 🔴 +2.26 kB
assets/NightlySurveyController-BroSC1AZ.js (removed) 7.56 kB — 🟢 -7.56 kB 🟢 -2.59 kB 🟢 -2.28 kB
assets/WidgetWithControl-D6yJnf4r.js (new) — 6.41 kB 🔴 +6.41 kB 🔴 +2.61 kB 🔴 +2.3 kB
assets/WidgetWithControl-CdV01juI.js (removed) 6.37 kB — 🟢 -6.37 kB 🟢 -2.59 kB 🟢 -2.3 kB
assets/tierBenefits-C8rCniju.js (removed) 6.25 kB — 🟢 -6.25 kB 🟢 -2 kB 🟢 -1.74 kB
assets/tierBenefits-DWo4tdRx.js (new) — 6.25 kB 🔴 +6.25 kB 🔴 +2 kB 🔴 +1.74 kB
assets/CancelSubscriptionDialogContent-Cb2D9ofF.js (removed) 5.98 kB — 🟢 -5.98 kB 🟢 -2.04 kB 🟢 -1.79 kB
assets/CancelSubscriptionDialogContent-siI37AGd.js (new) — 5.98 kB 🔴 +5.98 kB 🔴 +2.04 kB 🔴 +1.79 kB
assets/load3dPreviewExtensions-C1bdN7XR.js (new) — 5.94 kB 🔴 +5.94 kB 🔴 +1.84 kB 🔴 +1.62 kB
assets/load3dPreviewExtensions-D7E11lCL.js (removed) 5.94 kB — 🟢 -5.94 kB 🟢 -1.84 kB 🟢 -1.62 kB
assets/main-CqK-TlJi.js (new) — 5.91 kB 🔴 +5.91 kB 🔴 +1.9 kB 🔴 +1.59 kB
assets/main-hQS29BSI.js (removed) 5.91 kB — 🟢 -5.91 kB 🟢 -1.9 kB 🟢 -1.6 kB
assets/CreateWorkspaceDialogContent-CtPiuBpu.js (removed) 5.19 kB — 🟢 -5.19 kB 🟢 -1.83 kB 🟢 -1.58 kB
assets/CreateWorkspaceDialogContent-qSloTrEJ.js (new) — 5.19 kB 🔴 +5.19 kB 🔴 +1.83 kB 🔴 +1.58 kB
assets/ChangeMemberRoleDialogContent-CnKbxjCw.js (new) — 5.04 kB 🔴 +5.04 kB 🔴 +1.67 kB 🔴 +1.46 kB
assets/ChangeMemberRoleDialogContent-DcndEtdU.js (removed) 5.04 kB — 🟢 -5.04 kB 🟢 -1.67 kB 🟢 -1.46 kB
assets/missingModelDownload-JTXXWlk0.js (removed) 5.03 kB — 🟢 -5.03 kB 🟢 -1.95 kB 🟢 -1.7 kB
assets/missingModelDownload-XbkoZz2L.js (new) — 5.03 kB 🔴 +5.03 kB 🔴 +1.95 kB 🔴 +1.7 kB
assets/EditWorkspaceDialogContent-BQWty8SP.js (removed) 5 kB — 🟢 -5 kB 🟢 -1.79 kB 🟢 -1.55 kB
assets/EditWorkspaceDialogContent-D9uiNGOZ.js (new) — 5 kB 🔴 +5 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/WidgetTextarea--wh9V3Ze.js (new) — 4.86 kB 🔴 +4.86 kB 🔴 +1.9 kB 🔴 +1.66 kB
assets/WidgetTextarea-CHTVv_jm.js (removed) 4.86 kB — 🟢 -4.86 kB 🟢 -1.9 kB 🟢 -1.66 kB
assets/saveMesh-C5htNjTv.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.55 kB 🟢 -1.37 kB
assets/saveMesh-CLh8u4j5.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.55 kB 🔴 +1.37 kB
assets/WorkspacePanelContent-Bbgdbl6h.js (new) — 4.78 kB 🔴 +4.78 kB 🔴 +1.63 kB 🔴 +1.43 kB
assets/WorkspacePanelContent-BiPJL2rH.js (removed) 4.78 kB — 🟢 -4.78 kB 🟢 -1.63 kB 🟢 -1.43 kB
assets/InviteMemberDialogContent-BP2qHycT.js (removed) 4.75 kB — 🟢 -4.75 kB 🟢 -1.62 kB 🟢 -1.4 kB
assets/InviteMemberDialogContent-g4sAkDsJ.js (new) — 4.75 kB 🔴 +4.75 kB 🔴 +1.61 kB 🔴 +1.4 kB
assets/ValueControlPopover-CvVgLsDf.js (new) — 4.54 kB 🔴 +4.54 kB 🔴 +1.58 kB 🔴 +1.41 kB
assets/ValueControlPopover-DtCMsOtq.js (removed) 4.54 kB — 🟢 -4.54 kB 🟢 -1.58 kB 🟢 -1.42 kB
assets/ApiNodesSignInContent-CddMAMn-.js (new) — 4.14 kB 🔴 +4.14 kB 🔴 +1.34 kB 🔴 +1.17 kB
assets/ApiNodesSignInContent-Cka-1tT2.js (removed) 4.14 kB — 🟢 -4.14 kB 🟢 -1.34 kB 🟢 -1.18 kB
assets/restoreCloudSession-CbUH1OAv.js (new) — 3.99 kB 🔴 +3.99 kB 🔴 +1.81 kB 🔴 +1.54 kB
assets/DeleteWorkspaceDialogContent-C3LAZkyb.js (removed) 3.91 kB — 🟢 -3.91 kB 🟢 -1.48 kB 🟢 -1.26 kB
assets/DeleteWorkspaceDialogContent-D9upvSsl.js (new) — 3.91 kB 🔴 +3.91 kB 🔴 +1.47 kB 🔴 +1.26 kB
assets/LeaveWorkspaceDialogContent-b9HthEhL.js (removed) 3.73 kB — 🟢 -3.73 kB 🟢 -1.42 kB 🟢 -1.21 kB
assets/LeaveWorkspaceDialogContent-DMLeIbeK.js (new) — 3.73 kB 🔴 +3.73 kB 🔴 +1.42 kB 🔴 +1.22 kB
assets/RemoveMemberDialogContent-BeWnqRhN.js (new) — 3.71 kB 🔴 +3.71 kB 🔴 +1.37 kB 🔴 +1.18 kB
assets/RemoveMemberDialogContent-DRF7LToy.js (removed) 3.71 kB — 🟢 -3.71 kB 🟢 -1.37 kB 🟢 -1.18 kB
assets/RevokeInviteDialogContent-CBDg61E0.js (new) — 3.62 kB 🔴 +3.62 kB 🔴 +1.38 kB 🔴 +1.2 kB
assets/RevokeInviteDialogContent-CIVsjh9Q.js (removed) 3.62 kB — 🟢 -3.62 kB 🟢 -1.38 kB 🟢 -1.2 kB
assets/sessionExpiry-FCIPqc0T.js (new) — 3.53 kB 🔴 +3.53 kB 🔴 +1.56 kB 🔴 +1.31 kB
assets/InviteMemberUpsellDialogContent-BfoiGQTw.js (removed) 3.51 kB — 🟢 -3.51 kB 🟢 -1.26 kB 🟢 -1.1 kB
assets/InviteMemberUpsellDialogContent-ThDhIoHz.js (new) — 3.51 kB 🔴 +3.51 kB 🔴 +1.26 kB 🔴 +1.1 kB
assets/workspaceCheckoutTelemetry-0iikJkPQ.js (new) — 3.46 kB 🔴 +3.46 kB 🔴 +1.55 kB 🔴 +1.35 kB
assets/workspaceCheckoutTelemetry-B2dyNMfR.js (removed) 3.46 kB — 🟢 -3.46 kB 🟢 -1.55 kB 🟢 -1.35 kB
assets/Media3DTop-D3X72bmm.js (removed) 3.26 kB — 🟢 -3.26 kB 🟢 -1.29 kB 🟢 -1.13 kB
assets/Media3DTop-Dr6Oph37.js (new) — 3.26 kB 🔴 +3.26 kB 🔴 +1.29 kB 🔴 +1.13 kB
assets/GlobalToast-CWYMm80S.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.25 kB 🟢 -1.11 kB
assets/GlobalToast-KH91b_Ro.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.25 kB 🔴 +1.1 kB
assets/load3dAdvanced-CsQXK55s.js (new) — 2.87 kB 🔴 +2.87 kB 🔴 +1.13 kB 🔴 +978 B
assets/load3dAdvanced-t8v9pYVa.js (removed) 2.87 kB — 🟢 -2.87 kB 🟢 -1.13 kB 🟢 -976 B
assets/cloudSessionCookie-C1xUOVkM.js (new) — 2.54 kB 🔴 +2.54 kB 🔴 +1.21 kB 🔴 +1 kB
assets/SubscribeToRun-C57sFxjE.js (removed) 2.45 kB — 🟢 -2.45 kB 🟢 -1.06 kB 🟢 -942 B
assets/SubscribeToRun-CCtIKR9J.js (new) — 2.45 kB 🔴 +2.45 kB 🔴 +1.06 kB 🔴 +924 B
assets/MediaAudioTop-BWM2Hdmw.js (removed) 1.67 kB — 🟢 -1.67 kB 🟢 -837 B 🟢 -694 B
assets/MediaAudioTop-Kxu7MejO.js (new) — 1.67 kB 🔴 +1.67 kB 🔴 +837 B 🔴 +695 B
assets/signInSchema-vH_x2R7C.js (new) — 1.6 kB 🔴 +1.6 kB 🔴 +584 B 🔴 +551 B
assets/signInSchema-YIDw4H1V.js (removed) 1.6 kB — 🟢 -1.6 kB 🟢 -585 B 🟢 -551 B
assets/CloudRunButtonWrapper-DBz1lZ6E.js (new) — 1.11 kB 🔴 +1.11 kB 🔴 +547 B 🔴 +482 B
assets/CloudRunButtonWrapper-DVqs74yb.js (removed) 1.11 kB — 🟢 -1.11 kB 🟢 -548 B 🟢 -485 B
assets/cloudSessionCookie-Chug2AdZ.js (removed) 989 B — 🟢 -989 B 🟢 -461 B 🟢 -416 B
assets/cloudBadges-BFKuvN4k.js (new) — 971 B 🔴 +971 B 🔴 +546 B 🔴 +484 B
assets/cloudBadges-BRrn1bf2.js (removed) 971 B — 🟢 -971 B 🟢 -546 B 🟢 -461 B
assets/Load3DAdvanced-CQJL1mi2.js (removed) 813 B — 🟢 -813 B 🟢 -454 B 🟢 -408 B
assets/Load3DAdvanced-hPX-qBzh.js (new) — 813 B 🔴 +813 B 🔴 +453 B 🔴 +404 B
assets/nightlyBadges-BDnYED0j.js (new) — 462 B 🔴 +462 B 🔴 +301 B 🔴 +287 B
assets/nightlyBadges-BL-IfMEn.js (removed) 462 B — 🟢 -462 B 🟢 -303 B 🟢 -250 B
assets/missingModelDownload-Bgvrt3CN.js (new) — 228 B 🔴 +228 B 🔴 +150 B 🔴 +128 B
assets/missingModelDownload-w7Ndz1pb.js (removed) 228 B — 🟢 -228 B 🟢 -149 B 🟢 -128 B
assets/SubscriptionPanelContentWorkspace-BiIZ55OR.js (new) — 179 B 🔴 +179 B 🔴 +117 B 🔴 +90 B
assets/SubscriptionPanelContentWorkspace-BsrU_HY7.js (removed) 179 B — 🟢 -179 B 🟢 -117 B 🟢 -94 B
assets/Load3dViewerContent-DePXFGu0.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -91 B
assets/Load3dViewerContent-j7vd_PxQ.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +95 B
assets/Load3DAdvanced-BKprjqxa.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +88 B
assets/Load3DAdvanced-j_bSrlQL.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -88 B
assets/WidgetLegacy-BJhu6ybw.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -103 B
assets/WidgetLegacy-DVFoJdvk.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +101 B
assets/workflowDraftStoreV2-BKoEd2IT.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -110 B
assets/workflowDraftStoreV2-BtL6nLht.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +108 B
assets/Load3D-B9W6aVhB.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +87 B
assets/Load3D-C7cQgVda.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -80 B
assets/i18n-5U2WW9yW.js (new) — 97 B 🔴 +97 B 🔴 +92 B 🔴 +86 B
assets/i18n-osX2x87i.js (removed) 97 B — 🟢 -97 B 🟢 -92 B 🟢 -89 B
assets/changeTracker-BlBMY9AM.js (new) — 91 B 🔴 +91 B 🔴 +93 B 🔴 +89 B
assets/changeTracker-Dll_NdtS.js (removed) 91 B — 🟢 -91 B 🟢 -93 B 🟢 -82 B

Status: 78 added / 76 removed / 199 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 162ms TBT · 78.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.2 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 697ms TBT · 168.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.9 MB heap

⚠️ 15 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 343ms 597ms +74% ⚠️ z=6.5
canvas-mouse-sweep: layout duration 2ms 4ms +75% ⚠️ z=2.0
canvas-mouse-sweep: style recalc duration 21ms 49ms +135% ⚠️ z=2.1
canvas-mouse-sweep: task duration 600ms 1042ms +74% ⚠️ z=3.0
canvas-zoom-sweep: task duration 273ms 468ms +71% ⚠️ z=6.1
dom-widget-clipping: task duration 267ms 423ms +58% ⚠️ z=3.5
large-graph-idle: task duration 487ms 843ms +73% ⚠️ z=5.5
large-graph-idle: script duration 62ms 140ms +127% ⚠️ z=3.6
large-graph-pan: task duration 884ms 1507ms +70% ⚠️ z=9.9
large-graph-pan: script duration 273ms 515ms +89% ⚠️ z=5.4
minimap-idle: task duration 472ms 855ms +81% ⚠️ z=6.9
minimap-idle: script duration 59ms 145ms +147% ⚠️ z=4.8
subgraph-dom-widget-clipping: task duration 279ms 441ms +58% ⚠️ z=3.4
subgraph-idle: task duration 328ms 581ms +77% ⚠️ z=6.7
subgraph-mouse-sweep: task duration 518ms 914ms +76% ⚠️ z=2.1
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms -0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 6ms 11ms +89% z=-0.3
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 9 -15% z=-4.7
canvas-idle: task duration 343ms 597ms +74% ⚠️ z=6.5
canvas-idle: script duration 13ms 24ms +90% z=-0.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 68.3 MB 68.8 MB +1% —
canvas-idle: DOM nodes 20 17 -15% z=-4.4
canvas-idle: event listeners 6 5 -17% z=-1.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 2ms 4ms +75% ⚠️ z=2.0
canvas-mouse-sweep: style recalc duration 21ms 49ms +135% ⚠️ z=2.1
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 80 +11% z=0.6
canvas-mouse-sweep: task duration 600ms 1042ms +74% ⚠️ z=3.0
canvas-mouse-sweep: script duration 71ms 143ms +100% z=1.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.9 MB 46.4 MB -7% —
canvas-mouse-sweep: DOM nodes -271 -106 -61% z=-64.9
canvas-mouse-sweep: event listeners -146 -148 +1% z=-37.5
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=1.4
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms +17% z=0.2
canvas-zoom-sweep: style recalc duration 11ms 21ms +82% z=1.0
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 32 -2% z=0.5
canvas-zoom-sweep: task duration 273ms 468ms +71% ⚠️ z=6.1
canvas-zoom-sweep: script duration 14ms 27ms +92% z=0.0
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 71.8 MB 71.8 MB +0% —
canvas-zoom-sweep: DOM nodes 79 78 -2% z=-2.2
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: p95 frame time 17ms 17ms +0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 6ms 7ms +22% z=-3.4
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 10 -23% z=-6.2
dom-widget-clipping: task duration 267ms 423ms +58% ⚠️ z=3.5
dom-widget-clipping: script duration 36ms 65ms +82% z=-0.9
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.0 MB 53.2 MB +0% —
dom-widget-clipping: DOM nodes 22 16 -27% z=-4.3
dom-widget-clipping: event listeners 2 2 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 6ms 9ms +50% z=-3.5
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 10 7 -30% z=-14.7
large-graph-idle: task duration 487ms 843ms +73% ⚠️ z=5.5
large-graph-idle: script duration 62ms 140ms +127% ⚠️ z=3.6
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 64.3 MB 63.3 MB -1% —
large-graph-idle: DOM nodes -273 -275 +1% z=-331.6
large-graph-idle: event listeners -142 -144 +1% z=-27.9
large-graph-pan: avg frame time 17ms 17ms -0% z=-0.8
large-graph-pan: p95 frame time 17ms 17ms +0% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 12ms 15ms +20% z=-3.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 68 -1% z=-2.4
large-graph-pan: task duration 884ms 1507ms +70% ⚠️ z=9.9
large-graph-pan: script duration 273ms 515ms +89% ⚠️ z=5.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 61.2 MB 57.9 MB -5% —
large-graph-pan: DOM nodes -275 -279 +1% z=-180.6
large-graph-pan: event listeners -144 -144 +0% z=-179.9
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -0% —
large-graph-zoom: layout duration 8ms 9ms +12% —
large-graph-zoom: style recalc duration 14ms 15ms +8% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 67 63 -6% —
large-graph-zoom: task duration 1062ms 1769ms +67% —
large-graph-zoom: script duration 332ms 645ms +94% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 51.6 MB 69.0 MB +34% —
large-graph-zoom: DOM nodes 16 -138 -959% —
large-graph-zoom: event listeners -146 -68 -53% —
minimap-idle: avg frame time 17ms 17ms -0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +1% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 10ms +90% z=0.2
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 10 8 -25% z=-3.0
minimap-idle: task duration 472ms 855ms +81% ⚠️ z=6.9
minimap-idle: script duration 59ms 145ms +147% ⚠️ z=4.8
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 64.4 MB 65.5 MB +2% —
minimap-idle: DOM nodes -274 -279 +2% z=-217.6
minimap-idle: event listeners -142 -145 +2% z=-226.5
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 7ms 11ms +50% z=-2.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 48 45 -6% z=-5.0
subgraph-dom-widget-clipping: task duration 279ms 441ms +58% ⚠️ z=3.4
subgraph-dom-widget-clipping: script duration 77ms 128ms +68% z=-0.0
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 53.3 MB 53.7 MB +1% —
subgraph-dom-widget-clipping: DOM nodes 22 16 -27% z=-5.5
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=-1.4
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms -1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 6ms 9ms +35% z=-2.3
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 12 9 -25% z=-2.9
subgraph-idle: task duration 328ms 581ms +77% ⚠️ z=6.7
subgraph-idle: script duration 11ms 21ms +99% z=0.3
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 68.5 MB 56.4 MB -18% —
subgraph-idle: DOM nodes 24 -128 -631% z=-99.9
subgraph-idle: event listeners 6 -72 -1300% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% —
subgraph-mouse-sweep: layout duration 3ms 5ms +83% z=1.8
subgraph-mouse-sweep: style recalc duration 23ms 44ms +95% z=0.4
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 76 -2% z=-2.4
subgraph-mouse-sweep: task duration 518ms 914ms +76% ⚠️ z=2.1
subgraph-mouse-sweep: script duration 56ms 110ms +95% z=1.3
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 59.5 MB 59.9 MB +1% —
subgraph-mouse-sweep: DOM nodes 65 62 -5% z=-2.4
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms -1% —
subgraph-transition-enter: layout duration 8ms 14ms +73% —
subgraph-transition-enter: style recalc duration 22ms 35ms +62% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 19 19 +0% —
subgraph-transition-enter: task duration 620ms 1158ms +87% —
subgraph-transition-enter: script duration 20ms 51ms +156% —
subgraph-transition-enter: TBT 82ms 162ms +98% —
subgraph-transition-enter: heap used 92.7 MB 78.1 MB -16% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2369 2371 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 37ms 43ms +15% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 249 +0% —
viewport-pan-sweep: task duration 3124ms 5323ms +70% —
viewport-pan-sweep: script duration 928ms 1690ms +82% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 63.5 MB 73.9 MB +16% —
viewport-pan-sweep: DOM nodes -273 -276 +1% —
viewport-pan-sweep: event listeners -128 -127 -1% —
vue-large-graph-idle: avg frame time 17ms 18ms +7% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 11145ms 18457ms +66% —
vue-large-graph-idle: script duration 387ms 620ms +60% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 165.4 MB 160.2 MB -3% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16391 -16386 -0% —
vue-large-graph-pan: avg frame time 17ms 18ms +3% —
vue-large-graph-pan: p95 frame time 17ms 17ms -0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 15ms 26ms +79% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 66 163 +147% —
vue-large-graph-pan: task duration 13525ms 22943ms +70% —
vue-large-graph-pan: script duration 646ms 1015ms +57% —
vue-large-graph-pan: TBT 33ms 697ms +2012% —
vue-large-graph-pan: heap used 161.0 MB 168.7 MB +5% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16389 -16379 -0% —
workflow-execution: avg frame time 17ms 17ms -0% z=0.1
workflow-execution: p95 frame time 17ms 17ms -1% —
workflow-execution: layout duration 1ms 0ms -66% z=-8.0
workflow-execution: style recalc duration 17ms 20ms +20% z=-1.9
workflow-execution: layout count 3 2 -33% z=-5.4
workflow-execution: style recalc count 15 14 -10% z=-2.1
workflow-execution: task duration 97ms 123ms +26% z=0.0
workflow-execution: script duration 8ms 12ms +58% z=-5.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.7 MB 48.9 MB +0% —
workflow-execution: DOM nodes 123 124 +0% z=-5.2
workflow-execution: event listeners 67 66 -1% z=3.2
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-07-29T15:42:06.728Z",
  "gitSha": "ee30d8dd8f8996b958f1bc4c1bdf50dd5a6f03c6",
  "branch": "fix/cloud-session-expiry-401",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2078.2740000000217,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 11.303,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 635.357,
      "heapDeltaBytes": 4111472,
      "heapUsedBytes": 71980136,
      "domNodes": 16,
      "jsHeapTotalBytes": 20578304,
      "scriptDurationMs": 24.846000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2020.7889999999225,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.738999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.133,
      "heapDeltaBytes": 4395632,
      "heapUsedBytes": 72398608,
      "domNodes": 18,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 24.042,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2022.8950000000054,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 51.039,
      "layouts": 12,
      "layoutDurationMs": 4.0440000000000005,
      "taskDurationMs": 1045.747,
      "heapDeltaBytes": -22037852,
      "heapUsedBytes": 45973656,
      "domNodes": 64,
      "jsHeapTotalBytes": 20705280,
      "scriptDurationMs": 140.61700000000002,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1966.3620000000037,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.312,
      "layouts": 12,
      "layoutDurationMs": 3.9760000000000004,
      "taskDurationMs": 1037.381,
      "heapDeltaBytes": -16522368,
      "heapUsedBytes": 51316424,
      "domNodes": -275,
      "jsHeapTotalBytes": 21491712,
      "scriptDurationMs": 144.926,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.0939999999619,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 21.273,
      "layouts": 6,
      "layoutDurationMs": 0.644,
      "taskDurationMs": 460.6480000000001,
      "heapDeltaBytes": 7315404,
      "heapUsedBytes": 75378496,
      "domNodes": 77,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 27.006000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1772.322000000031,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.206999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.662,
      "taskDurationMs": 474.56399999999996,
      "heapDeltaBytes": 7362140,
      "heapUsedBytes": 75296876,
      "domNodes": 78,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 27.253,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 607.6810000000137,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.151000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.553,
      "heapDeltaBytes": -12005984,
      "heapUsedBytes": 55877520,
      "domNodes": 16,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 64.108,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 642.6559999999881,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.2669999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 430.8109999999999,
      "heapDeltaBytes": -12248068,
      "heapUsedBytes": 55691076,
      "domNodes": 16,
      "jsHeapTotalBytes": 21626880,
      "scriptDurationMs": 65.729,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.5870000000305,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.711000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 828.9720000000001,
      "heapDeltaBytes": 7376712,
      "heapUsedBytes": 66526992,
      "domNodes": -274,
      "jsHeapTotalBytes": 4521984,
      "scriptDurationMs": 135.036,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.8139999999457,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 9.371,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 856.7539999999999,
      "heapDeltaBytes": 7529148,
      "heapUsedBytes": 66276076,
      "domNodes": -276,
      "jsHeapTotalBytes": 4784128,
      "scriptDurationMs": 145.551,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2288.0400000000236,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.356999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1422.642,
      "heapDeltaBytes": -4832180,
      "heapUsedBytes": 55971972,
      "domNodes": -279,
      "jsHeapTotalBytes": 5308416,
      "scriptDurationMs": 468.69,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2469.6910000000116,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 17.456000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1592.099,
      "heapDeltaBytes": 5368072,
      "heapUsedBytes": 65487760,
      "domNodes": -279,
      "jsHeapTotalBytes": 5251072,
      "scriptDurationMs": 561.827,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3421.1310000000026,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 14.826000000000002,
      "layouts": 60,
      "layoutDurationMs": 8.650000000000002,
      "taskDurationMs": 1711.89,
      "heapDeltaBytes": 25381256,
      "heapUsedBytes": 87031080,
      "domNodes": 8,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 632.522,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3659.6210000000156,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 16.102,
      "layouts": 60,
      "layoutDurationMs": 8.485999999999999,
      "taskDurationMs": 1826.824,
      "heapDeltaBytes": -4201696,
      "heapUsedBytes": 57748800,
      "domNodes": -283,
      "jsHeapTotalBytes": 7143424,
      "scriptDurationMs": 657.894,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2063.623000000007,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.473000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 834.299,
      "heapDeltaBytes": 7713828,
      "heapUsedBytes": 68787216,
      "domNodes": -278,
      "jsHeapTotalBytes": 4521984,
      "scriptDurationMs": 145.156,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2081.613999999945,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 10.044999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 876.196,
      "heapDeltaBytes": 7882036,
      "heapUsedBytes": 68476212,
      "domNodes": -279,
      "jsHeapTotalBytes": 4259840,
      "scriptDurationMs": 145.707,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 657.8719999999976,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.624999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.56600000000003,
      "heapDeltaBytes": -12022380,
      "heapUsedBytes": 55939132,
      "domNodes": 18,
      "jsHeapTotalBytes": 22937600,
      "scriptDurationMs": 132.34300000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 637.6619999999775,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.953,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 421.986,
      "heapDeltaBytes": -11414116,
      "heapUsedBytes": 56599640,
      "domNodes": 14,
      "jsHeapTotalBytes": 21626880,
      "scriptDurationMs": 124.14599999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.9219999999982,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.597000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.8040000000001,
      "heapDeltaBytes": 3964848,
      "heapUsedBytes": 71925484,
      "domNodes": 18,
      "jsHeapTotalBytes": 20578304,
      "scriptDurationMs": 19.857999999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2055.547000000047,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.696,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.6,
      "heapDeltaBytes": -21635684,
      "heapUsedBytes": 46345800,
      "domNodes": -273,
      "jsHeapTotalBytes": 19656704,
      "scriptDurationMs": 22.208999999999996,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.5829999999914,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.166000000000004,
      "layouts": 16,
      "layoutDurationMs": 5.102,
      "taskDurationMs": 867.13,
      "heapDeltaBytes": -5256060,
      "heapUsedBytes": 62658924,
      "domNodes": 62,
      "jsHeapTotalBytes": 20578304,
      "scriptDurationMs": 105.23599999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1789.4770000000335,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 46.638,
      "layouts": 16,
      "layoutDurationMs": 5.472,
      "taskDurationMs": 961.811,
      "heapDeltaBytes": -5126012,
      "heapUsedBytes": 63035628,
      "domNodes": 61,
      "jsHeapTotalBytes": 20578304,
      "scriptDurationMs": 114.02400000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1509.3879999999444,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 34.80899999999999,
      "layouts": 15,
      "layoutDurationMs": 13.664,
      "taskDurationMs": 1157.71,
      "heapDeltaBytes": -2274672,
      "heapUsedBytes": 81940856,
      "domNodes": 13673,
      "jsHeapTotalBytes": 9961472,
      "scriptDurationMs": 50.96500000000001,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 162,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9066.227999999966,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.363,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5273.497,
      "heapDeltaBytes": 18833376,
      "heapUsedBytes": 77625840,
      "domNodes": -275,
      "jsHeapTotalBytes": 6270976,
      "scriptDurationMs": 1679.844,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9284.344000000034,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 42.751999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5372.648,
      "heapDeltaBytes": 18545156,
      "heapUsedBytes": 77371980,
      "domNodes": -276,
      "jsHeapTotalBytes": 7057408,
      "scriptDurationMs": 1699.269,
      "eventListeners": -126,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18102.057,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18074.594,
      "heapDeltaBytes": -63394504,
      "heapUsedBytes": 167705252,
      "domNodes": -8312,
      "jsHeapTotalBytes": -13045760,
      "scriptDurationMs": 603.143,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18866.01899999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18839.463,
      "heapDeltaBytes": -56234272,
      "heapUsedBytes": 168247388,
      "domNodes": -8312,
      "jsHeapTotalBytes": -11993088,
      "scriptDurationMs": 636.512,
      "eventListeners": -16385,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 23252.65399999995,
      "styleRecalcs": 167,
      "styleRecalcDurationMs": 26.466999999999963,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23204.766,
      "heapDeltaBytes": -50021536,
      "heapUsedBytes": 176893420,
      "domNodes": -8312,
      "jsHeapTotalBytes": -14180352,
      "scriptDurationMs": 1012.6070000000001,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 806,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22707.447,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 25.436000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22681.772,
      "heapDeltaBytes": -23307752,
      "heapUsedBytes": 176909728,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15753216,
      "scriptDurationMs": 1017.754,
      "eventListeners": -16379,
      "totalBlockingTimeMs": 588,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.9120000000221,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 22.319,
      "layouts": 2,
      "layoutDurationMs": 0.42899999999999994,
      "taskDurationMs": 128.295,
      "heapDeltaBytes": -15766708,
      "heapUsedBytes": 51540572,
      "domNodes": 130,
      "jsHeapTotalBytes": 7995392,
      "scriptDurationMs": 12.414,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 466.90399999999954,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 17.595,
      "layouts": 2,
      "layoutDurationMs": 0.3370000000000001,
      "taskDurationMs": 117.52099999999999,
      "heapDeltaBytes": -16003740,
      "heapUsedBytes": 51060328,
      "domNodes": 117,
      "jsHeapTotalBytes": 7471104,
      "scriptDurationMs": 11.601,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Jul 28, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: baadd4ad-1163-4819-909c-d7a9428699fe

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The PR adds cloud-session suspension and restoration, identity-aware draft ownership, provider-specific reauthentication, voluntary sign-out sequencing, suspended-session request gating, identity revalidation, and related tests and documentation.

Changes

Cloud Session Lifecycle

Layer / File(s) Summary
Session state and restoration
docs/adr/..., src/platform/auth/...
Adds suspension state, remembered identity, provider resolution, public-route detection, and guarded cloud-session restoration with workspace and socket recovery.
Identity-aware persistence and logout
src/extensions/core/..., src/platform/workflow/persistence/..., src/stores/authStore.ts
Coordinates account adoption, draft retention or clearing, session-cookie teardown, deliberate versus involuntary logout, and rollback signaling.
Reauthentication and sign-out interactions
src/components/auth/..., src/composables/auth/..., src/App.vue, src/locales/en/main.json
Adds the session-expiry banner, provider-aware reauthentication, sign-out bracketing, rollback coverage, and localized session-expiry text.
Suspended-session gating and identity revalidation
src/platform/workspace/..., src/router*, src/scripts/api*, src/stores/..., src/platform/remote/...
Revalidates Firebase identity after identity-revocation errors and prevents authenticated routing, API, socket, job, remote-config, queue, and asset requests while sessions are suspended.

Estimated code review effort: 4 (Complex) | ~60 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WorkspaceAuthStore
  participant Firebase
  participant SessionExpiry
  participant SessionExpiredBanner
  participant useSessionReauth
  participant restoreCloudSession
  WorkspaceAuthStore->>Firebase: getIdToken(true) after identity revocation
  Firebase-->>WorkspaceAuthStore: refreshed or rejected credential
  WorkspaceAuthStore->>SessionExpiry: update suspended session state
  SessionExpiry-->>SessionExpiredBanner: reactive suspension state
  SessionExpiredBanner->>useSessionReauth: reauthenticate()
  useSessionReauth->>restoreCloudSession: restoreCloudSession()
  restoreCloudSession->>SessionExpiry: resume session after cookie validation
Loading

Possibly related issues

  • Comfy-Org/ComfyUI_frontend#13970 — Both changes address session-cookie recovery and account-change handling.

Possibly related PRs

Suggested labels: needs-backport, cloud/1.48

Suggested reviewers: austinmroz

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: recovering cloud sessions after provider-rejected auth tokens.
Description check ✅ Passed The description matches the template and covers summary, changes, review focus, breaking changes, dependencies, and screenshots.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed Although src/frontend files changed and no browser_tests files were added, the PR description gives a concrete reason E2E wasn’t added (no router test harness; E2E is the right home).
Adr Compliance For Entity/Litegraph Changes ✅ Passed No changed files are under src/lib/litegraph/, src/ecs/, or graph-entity paths, so ADR 0003/0008 checks are not applicable.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/cloud-session-expiry-401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 28, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.01124% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/composables/auth/useCurrentUser.ts 0.00% 14 Missing ⚠️
src/App.vue 0.00% 1 Missing ⚠️
src/router.ts 66.66% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #14207      +/-   ##
==========================================
- Coverage   80.05%   79.83%   -0.23%     
==========================================
  Files        1699     1760      +61     
  Lines      117937   122774    +4837     
  Branches    40381    42122    +1741     
==========================================
+ Hits        94411    98012    +3601     
- Misses      22888    24072    +1184     
- Partials      638      690      +52     
Flag Coverage Δ
unit 69.56% <91.52%> (+1.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/auth/SessionExpiredBanner.vue 100.00% <100.00%> (ø)
src/composables/auth/useAuthActions.ts 69.59% <100.00%> (+2.19%) ⬆️
src/composables/auth/useSessionReauth.ts 100.00% <100.00%> (ø)
src/extensions/core/cloudSessionCookie.ts 87.50% <100.00%> (+87.50%) ⬆️
src/platform/auth/authProvider.ts 100.00% <100.00%> (ø)
src/platform/auth/session/publicRoutes.ts 100.00% <100.00%> (ø)
src/platform/auth/session/restoreCloudSession.ts 100.00% <100.00%> (ø)
src/platform/auth/session/sessionExpiry.ts 100.00% <100.00%> (ø)
src/platform/remote/comfyui/jobs/fetchJobs.ts 92.52% <100.00%> (+0.14%) ⬆️
src/platform/remoteConfig/refreshRemoteConfig.ts 86.27% <100.00%> (+0.27%) ⬆️
... and 10 more

... and 171 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/auth/SessionExpiredBanner.test.ts`:
- Around line 45-79: Update the SessionExpiredBanner tests to query the banner
by its accessible alert role and query the action using getByRole('button', {
name: 'auth.sessionExpired.action' }). Replace all session-expired-banner test
ID lookups and the unnamed button query while preserving the existing assertions
and test behavior.

In `@src/composables/auth/useAuthActions.ts`:
- Around line 118-123: Extract the repeated voluntary sign-out bracket into an
exported asVoluntarySignOut helper in sessionExpiry.ts, preserving
beginVoluntarySignOut before the callback and endVoluntarySignOut in a finally
block. In src/composables/auth/useAuthActions.ts lines 118-123 and 261-266,
replace each manual bracket with the helper; in src/stores/authStore.ts lines
499-508, wrap credential.user.delete() with the helper while preserving the
existing best-effort catch and warning.

In `@src/locales/en/main.json`:
- Around line 2451-2455: Update the sessionExpired localization copy to use
neutral, reason-agnostic wording that also fits auth/user-disabled cases;
replace the title and action text that specifically imply expiration or signing
in again, while preserving the existing detail and resumeFailed entries unless
corresponding wording also implies an expired session.

In `@src/platform/workspace/stores/workspaceAuthStore.ts`:
- Around line 82-94: Extend identity revalidation to the legacy refreshToken()
path, including its related error-handling branches, so INVALID_FIREBASE_TOKEN
is confirmed with Firebase before clearWorkspaceContext() is called. Reuse
isIdentityRevoked and askProviderToRevalidate, preserving existing behavior for
confirmed revocation and non-identity workspace errors; ensure the same parity
applies to the referenced legacy refresh flows.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 3e5ccbca-0aac-440e-a96c-4b8bb31a4495

📥 Commits

Reviewing files that changed from the base of the PR and between 0661299 and 04891fe.

📒 Files selected for processing (31)
  • docs/adr/0011-derived-credential-lifecycle.md
  • src/App.vue
  • src/components/auth/SessionExpiredBanner.test.ts
  • src/components/auth/SessionExpiredBanner.vue
  • src/composables/auth/signOutSeam.test.ts
  • src/composables/auth/useAuthActions.test.ts
  • src/composables/auth/useAuthActions.ts
  • src/composables/auth/useCurrentUser.ts
  • src/composables/auth/useSessionReauth.test.ts
  • src/composables/auth/useSessionReauth.ts
  • src/extensions/core/cloudSessionCookie.test.ts
  • src/extensions/core/cloudSessionCookie.ts
  • src/locales/en/main.json
  • src/platform/auth/authProvider.test.ts
  • src/platform/auth/authProvider.ts
  • src/platform/auth/session/restoreCloudSession.test.ts
  • src/platform/auth/session/restoreCloudSession.ts
  • src/platform/auth/session/sessionExpiry.test.ts
  • src/platform/auth/session/sessionExpiry.ts
  • src/platform/remote/comfyui/jobs/fetchJobs.test.ts
  • src/platform/remote/comfyui/jobs/fetchJobs.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts
  • src/platform/workspace/stores/useWorkspaceAuth.test.ts
  • src/platform/workspace/stores/workspaceAuthStore.ts
  • src/router.test.ts
  • src/router.ts
  • src/scripts/api.suspendedSession.test.ts
  • src/scripts/api.ts
  • src/stores/authStore.test.ts
  • src/stores/authStore.ts
💤 Files with no reviewable changes (1)
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.ts

Comment on lines +45 to +79
it('stays out of the way while the session is healthy', () => {
render(SessionExpiredBanner)

expect(screen.queryByTestId('session-expired-banner')).toBeNull()
})

it('warns about unsaved work when the session is suspended', () => {
mocks.suspended.value = true

render(SessionExpiredBanner)

expect(screen.getByTestId('session-expired-banner')).toBeTruthy()
// The warning is the point: the user must know to export before acting.
expect(screen.getByText('auth.sessionExpired.detail')).toBeTruthy()
})

it('re-authenticates in place when the action is used', async () => {
mocks.suspended.value = true
render(SessionExpiredBanner)

await userEvent.click(screen.getByRole('button'))

expect(mocks.reauthenticate).toHaveBeenCalledTimes(1)
})

it('announces itself assertively, since it blocks all cloud work', () => {
mocks.suspended.value = true

render(SessionExpiredBanner)

// The shared popup is a polite status by default; this one interrupts,
// because the user has unsaved work and every cloud request is failing.
const banner = screen.getByTestId('session-expired-banner')
expect(banner.getAttribute('role')).toBe('alert')
expect(banner.getAttribute('aria-live')).toBe('assertive')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Query the banner through accessible roles and names.

Use queryByRole('alert'), getByRole('alert'), and
getByRole('button', { name: 'auth.sessionExpired.action' }) instead of
test IDs or an unnamed button query. This validates the accessibility contract
rather than root markup.

Suggested test changes
- expect(screen.queryByTestId('session-expired-banner')).toBeNull()
+ expect(screen.queryByRole('alert')).toBeNull()

- expect(screen.getByTestId('session-expired-banner')).toBeTruthy()
+ expect(screen.getByRole('alert')).toBeTruthy()

- await userEvent.click(screen.getByRole('button'))
+ await userEvent.click(
+   screen.getByRole('button', { name: 'auth.sessionExpired.action' })
+ )

- const banner = screen.getByTestId('session-expired-banner')
+ const banner = screen.getByRole('alert')

Based on learnings, tests should prefer roles and accessible names over
data-testid selectors.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
it('stays out of the way while the session is healthy', () => {
render(SessionExpiredBanner)
expect(screen.queryByTestId('session-expired-banner')).toBeNull()
})
it('warns about unsaved work when the session is suspended', () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
expect(screen.getByTestId('session-expired-banner')).toBeTruthy()
// The warning is the point: the user must know to export before acting.
expect(screen.getByText('auth.sessionExpired.detail')).toBeTruthy()
})
it('re-authenticates in place when the action is used', async () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
await userEvent.click(screen.getByRole('button'))
expect(mocks.reauthenticate).toHaveBeenCalledTimes(1)
})
it('announces itself assertively, since it blocks all cloud work', () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
// The shared popup is a polite status by default; this one interrupts,
// because the user has unsaved work and every cloud request is failing.
const banner = screen.getByTestId('session-expired-banner')
expect(banner.getAttribute('role')).toBe('alert')
expect(banner.getAttribute('aria-live')).toBe('assertive')
it('stays out of the way while the session is healthy', () => {
render(SessionExpiredBanner)
expect(screen.queryByRole('alert')).toBeNull()
})
it('warns about unsaved work when the session is suspended', () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
expect(screen.getByRole('alert')).toBeTruthy()
// The warning is the point: the user must know to export before acting.
expect(screen.getByText('auth.sessionExpired.detail')).toBeTruthy()
})
it('re-authenticates in place when the action is used', async () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
await userEvent.click(
screen.getByRole('button', { name: 'auth.sessionExpired.action' })
)
expect(mocks.reauthenticate).toHaveBeenCalledTimes(1)
})
it('announces itself assertively, since it blocks all cloud work', () => {
mocks.suspended.value = true
render(SessionExpiredBanner)
// The shared popup is a polite status by default; this one interrupts,
// because the user has unsaved work and every cloud request is failing.
const banner = screen.getByRole('alert')
expect(banner.getAttribute('role')).toBe('alert')
expect(banner.getAttribute('aria-live')).toBe('assertive')
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/auth/SessionExpiredBanner.test.ts` around lines 45 - 79,
Update the SessionExpiredBanner tests to query the banner by its accessible
alert role and query the action using getByRole('button', { name:
'auth.sessionExpired.action' }). Replace all session-expired-banner test ID
lookups and the unnamed button query while preserving the existing assertions
and test behavior.

Sources: Path instructions, Learnings

Comment on lines +118 to +123
beginVoluntarySignOut()
try {
await authStore.logout()
} finally {
endVoluntarySignOut()
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract the repeated voluntary-sign-out bracket into a shared helper. The same beginVoluntarySignOut(); try { ... } finally { endVoluntarySignOut() } idiom is hand-rolled three times across two files. Since a missing bracket at any future sign-out call site would misclassify a deliberate sign-out as a credential-rejection expiry (or vice versa), centralizing it in sessionExpiry.ts (e.g. export async function asVoluntarySignOut<T>(fn: () => Promise<T>): Promise<T> { beginVoluntarySignOut(); try { return await fn() } finally { endVoluntarySignOut() } }) removes the duplication and the risk that a new call site forgets it.

  • src/composables/auth/useAuthActions.ts#L118-L123: replace the bracket in logout() with await asVoluntarySignOut(() => authStore.logout()).
  • src/composables/auth/useAuthActions.ts#L261-L266: replace the bracket in createReauthenticationRecovery's recover() with the same helper call.
  • src/stores/authStore.ts#L499-L508: replace the bracket around credential.user.delete() with the same helper call (keeping the existing catch/warn for the best-effort delete).
📍 Affects 2 files
  • src/composables/auth/useAuthActions.ts#L118-L123 (this comment)
  • src/composables/auth/useAuthActions.ts#L261-L266
  • src/stores/authStore.ts#L499-L508
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/composables/auth/useAuthActions.ts` around lines 118 - 123, Extract the
repeated voluntary sign-out bracket into an exported asVoluntarySignOut helper
in sessionExpiry.ts, preserving beginVoluntarySignOut before the callback and
endVoluntarySignOut in a finally block. In
src/composables/auth/useAuthActions.ts lines 118-123 and 261-266, replace each
manual bracket with the helper; in src/stores/authStore.ts lines 499-508, wrap
credential.user.delete() with the helper while preserving the existing
best-effort catch and warning.

Comment thread src/locales/en/main.json
Comment on lines +2451 to +2455
"sessionExpired": {
"title": "Your session expired",
"detail": "Export any unsaved changes before continuing, or you may lose them.",
"action": "Sign in again",
"resumeFailed": "We couldn't restore your session. Please try signing in again."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use neutral copy for disabled-account suspension.

This banner also handles auth/user-disabled, so “Your session expired” and
“Sign in again” misstate the cause for users who must contact support. Use
reason-aware messaging or neutral “session ended” copy.

Suggested neutral copy
- "title": "Your session expired",
+ "title": "Your session has ended",
  "detail": "Export any unsaved changes before continuing, or you may lose them.",
- "action": "Sign in again",
+ "action": "Sign in",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"sessionExpired": {
"title": "Your session expired",
"detail": "Export any unsaved changes before continuing, or you may lose them.",
"action": "Sign in again",
"resumeFailed": "We couldn't restore your session. Please try signing in again."
"sessionExpired": {
"title": "Your session has ended",
"detail": "Export any unsaved changes before continuing, or you may lose them.",
"action": "Sign in",
"resumeFailed": "We couldn't restore your session. Please try signing in again."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/locales/en/main.json` around lines 2451 - 2455, Update the sessionExpired
localization copy to use neutral, reason-agnostic wording that also fits
auth/user-disabled cases; replace the title and action text that specifically
imply expiration or signing in again, while preserving the existing detail and
resumeFailed entries unless corresponding wording also implies an expired
session.

Comment on lines +82 to +94
/**
* The subset of permanent failures that mean the IDENTITY was rejected, rather
* than that this workspace is gone or off-limits. `/api/auth/token` answers 401
* for a bad Firebase token but 403 for a denied workspace and 404 for a missing
* one — the latter two leave the user's credential perfectly valid, so they must
* never end the session.
*/
function isIdentityRevoked(err: unknown): boolean {
return (
err instanceof WorkspaceAuthError && err.code === 'INVALID_FIREBASE_TOKEN'
)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🔵 Trivial | ⚡ Quick win

Identity-revalidation fix is unified-only; legacy refreshToken() still has the same overloaded-401 problem.

isIdentityRevoked/askProviderToRevalidate are wired into refreshUnified() and remintUnifiedOnce(), but the pre-existing legacy refreshToken() (used when unified_cloud_auth is off) still treats a backend INVALID_FIREBASE_TOKEN (401) as authoritative and calls clearWorkspaceContext() without ever asking Firebase to confirm the credential is actually dead — exactly the "requestToken collapses every 401 into INVALID_FIREBASE_TOKEN regardless of why" problem this PR's own comment calls out. A transient backend 401 on the legacy path can still tear down a valid workspace context.

The existing TODO(unified) note a few lines above (forgetRevokedActiveWorkspace parity) suggests legacy/unified parity gaps are being deferred deliberately, so this may be intentional — please confirm whether the same revalidation should also apply to refreshToken(), or if it's out of scope until the legacy path is retired.

Also applies to: 842-863, 887-889, 940-951

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/workspace/stores/workspaceAuthStore.ts` around lines 82 - 94,
Extend identity revalidation to the legacy refreshToken() path, including its
related error-handling branches, so INVALID_FIREBASE_TOKEN is confirmed with
Firebase before clearWorkspaceContext() is called. Reuse isIdentityRevoked and
askProviderToRevalidate, preserving existing behavior for confirmed revocation
and non-identity workspace errors; ensure the same parity applies to the
referenced legacy refresh flows.

Corrects a claim in 04891fe's message, which is pushed and cannot be
amended. That message said the auth-state observer "only reports a uid
change, so a retry by the same user after a failed mint would otherwise
never clear". That is wrong. The hook rides whenever(resolvedUserInfo),
a plain watch over a computed that rebuilds its object, so the sign-out's
null and the re-sign-in's value are two transitions and it does fire. The
banner still drives the restore itself because a re-sign-in that never
cleared currentUser raises no transition at all; restoreCloudSession is
single-flight, so both firing is harmless.

Scope before connect. The socket's handshake token fixes its scope, and
nothing re-handshakes on a workspace change: everywhere else the app
changes workspace by reloading. Connecting first left a recovered team
user on a personal-scoped stream for the life of the page. The wait is
bounded above what the workspace initializer can spend on its own retries,
so a stalled workspace list costs the scope rather than realtime too.

The socket guard is re-checked after the token await. Suspension normally
lands during that await, because the auth store resets the socket before
it assigns currentUser and the watcher that suspends runs off that
assignment, so an entry-only check was always already past.

Suspension no longer answers an empty list where the user has data. The
queue, the job history and the outputs gallery hold their last snapshot
instead of reporting nothing, and the ten-minute feature-flag poll stops
wiping the flags that carry the export affordances the banner points at.

A revalidation re-checks that its captured scope is still current before
minting, using the request generation rather than the target, which a
workspace switch clears for its whole duration.

Run while suspended now surfaces the expiry instead of rendering nothing
and reporting success.

Fixes the draft-ownership reload decision, which read a different
collection than the loop that disarms the unload prompt, so a saved but
open document belonging to the previous user did not trigger the bounce.

Tests cover the release of the deliberate-sign-out bracket on every
failure path. Skipping it once arms the marker for the tab's life, after
which a real expiry reads as deliberate and wipes the drafts.
@CodeJuggernaut

Copy link
Copy Markdown
Contributor Author

Correction to an earlier commit message on this branch.

04891fe77e said the auth-state observer "only reports a uid change, so a retry by the same user after a failed mint would otherwise never clear." That is wrong, and it was the stated reason the banner drives its own restore.

The hook rides whenever(resolvedUserInfo), which is a plain watch over a computed that rebuilds its object, so the sign-out's null and the re-sign-in's value are two transitions and it does fire. The banner still calls restoreCloudSession directly for a different reason: a re-sign-in that never cleared currentUser raises no transition at all. restoreCloudSession is single-flight, so both firing is harmless.

That commit is pushed and cannot be amended, so the correction lives in a7effea9e3's body and here.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 9

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
src/composables/auth/useAuthActions.test.ts (1)

100-129: 📐 Maintainability & Code Quality | 🔵 Trivial | 🏗️ Heavy lift

The mock now reimplements the real wrapper's recovery semantics.

Recovery matching, swallow-on-recovery-failure, and fall-through to the error handler are duplicated here, so the reauthentication tests below can keep passing while useErrorHandling drifts. Since this module is owned by the repo, consider exercising the real wrapper and mocking only its outward-facing collaborators.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/composables/auth/useAuthActions.test.ts` around lines 100 - 129, Update
the test mock around the async action wrapper to use the real useErrorHandling
wrapper instead of duplicating recovery matching, swallowing, and error-handler
fallback behavior. Mock only the wrapper’s outward-facing collaborators, and
preserve the existing reauthentication test coverage through the real
implementation.

Source: Path instructions

src/extensions/core/cloudSessionCookie.ts (1)

57-62: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Stop restoration after scheduling the account-mismatch reload.

window.location.reload() does not terminate this async hook. restoreCloudSession() can resume authenticated traffic while the previous account’s canvas remains mounted, allowing persistence to recreate data just cleared for the new account. Return immediately after requesting the reload.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/extensions/core/cloudSessionCookie.ts` around lines 57 - 62, Update the
account-mismatch branch in the cloud session restoration hook to return
immediately after calling window.location.reload(). Ensure restoreCloudSession()
is not reached once a reload is scheduled, while preserving the existing
restoration flow when no open workflows require reloading.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/adr/0011-derived-credential-lifecycle.md`:
- Around line 88-90: Correct the broken sentence in the FE-1390 paragraph by
adding the missing relative pronoun so it clearly states that recovery restores
the workspace context that the sign-out reset restores. Preserve the surrounding
meaning and wording.

In `@src/composables/auth/useAuthActions.test.ts`:
- Around line 461-465: Update the beforeEach setup in the auth action tests to
install createTestingPinia instead of createPinia, configuring stubActions:
false so the tests execute real Pinia action logic while preserving the existing
mock reset and cloud-state initialization.

In `@src/composables/auth/useSessionReauth.ts`:
- Around line 49-56: Gate restoreCloudSession in useSessionReauth on an explicit
successful reauthentication result rather than authStore.currentUser, preserving
the same-user behavior while skipping canceled popups. In
src/composables/auth/useSessionReauth.test.ts lines 99-108, add coverage for a
resolved canceled sign-in with the original currentUser still present and assert
restoration is not called.

In `@src/extensions/core/cloudSessionCookie.test.ts`:
- Around line 315-424: Extract the repeated window.location descriptor setup and
restoration into shared test lifecycle logic or a helper that returns the reload
spy. Update the affected tests around onAuthUserResolved to use this utility,
preserving configurable restoration after each test and each test’s existing
reload assertions.

In `@src/platform/auth/session/restoreCloudSession.test.ts`:
- Around line 131-138: Move the console.warn spy setup from individual tests
into the restoreCloudSession test suite’s beforeEach lifecycle hook, and restore
it in afterEach (or use vi.restoreAllMocks()). Remove each test’s local spy
creation and manual mockRestore calls while preserving the existing
warning-suppression behavior.

In `@src/platform/auth/session/restoreCloudSession.ts`:
- Around line 111-113: Handle rejections from api.reconnectSocket in the
wasSuspended recovery path instead of discarding its promise. Update the finally
callback around restoreWorkspaceScope so reconnectSocket’s failure is explicitly
caught or otherwise consumed, while preserving the existing reconnect attempt
after workspace restoration.
- Around line 90-95: Update the recovery logic around mintAtLogin so the
non-unified path still invokes the existing getAuthHeader flow, including
ensureWorkspaceAuthHeader/Firebase token retrieval. Limit mintAtLogin to
unifiedCloudAuthEnabled, and preserve the current mintReportedFailure handling
without replacing the legacy credential recovery path.

In `@src/platform/remoteConfig/refreshRemoteConfig.ts`:
- Around line 49-53: Recheck suspension after awaited requests and before
mutating retained state: in
src/platform/remoteConfig/refreshRemoteConfig.ts#L49-L53, skip
unauthorized-response handling and config clearing when suspension began in
flight; in src/stores/assetsStore.ts#L156-L160, defer destructive initial-load
reset until a valid result exists and discard in-flight results after
suspension; in src/stores/queueStore.ts#L525-L529, recheck after
Promise.allSettled() before applying either result; add a regression test in
src/stores/queueStore.test.ts#L1145-L1170 that suspends after requests start but
before they settle.

In `@src/stores/authStore.test.ts`:
- Around line 536-543: Ensure the console.warn spy created in this registration
test is restored on every exit path by wrapping the awaited registration
assertion and related checks in a try/finally block, with warn.mockRestore() in
finally. Keep the existing rejection and sign-out assertions unchanged.

---

Outside diff comments:
In `@src/composables/auth/useAuthActions.test.ts`:
- Around line 100-129: Update the test mock around the async action wrapper to
use the real useErrorHandling wrapper instead of duplicating recovery matching,
swallowing, and error-handler fallback behavior. Mock only the wrapper’s
outward-facing collaborators, and preserve the existing reauthentication test
coverage through the real implementation.

In `@src/extensions/core/cloudSessionCookie.ts`:
- Around line 57-62: Update the account-mismatch branch in the cloud session
restoration hook to return immediately after calling window.location.reload().
Ensure restoreCloudSession() is not reached once a reload is scheduled, while
preserving the existing restoration flow when no open workflows require
reloading.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ee5c8024-39aa-43e8-aa05-4217b18c4caf

📥 Commits

Reviewing files that changed from the base of the PR and between 04891fe and a7effea.

📒 Files selected for processing (33)
  • docs/adr/0011-derived-credential-lifecycle.md
  • src/components/auth/SessionExpiredBanner.test.ts
  • src/components/auth/SessionExpiredBanner.vue
  • src/composables/auth/signOutSeam.test.ts
  • src/composables/auth/useAuthActions.test.ts
  • src/composables/auth/useSessionReauth.test.ts
  • src/composables/auth/useSessionReauth.ts
  • src/extensions/core/cloudSessionCookie.test.ts
  • src/extensions/core/cloudSessionCookie.ts
  • src/platform/auth/authProvider.ts
  • src/platform/auth/session/publicRoutes.test.ts
  • src/platform/auth/session/publicRoutes.ts
  • src/platform/auth/session/restoreCloudSession.test.ts
  • src/platform/auth/session/restoreCloudSession.ts
  • src/platform/auth/session/sessionExpiry.test.ts
  • src/platform/auth/session/sessionExpiry.ts
  • src/platform/remote/comfyui/jobs/fetchJobs.test.ts
  • src/platform/remote/comfyui/jobs/fetchJobs.ts
  • src/platform/remoteConfig/refreshRemoteConfig.test.ts
  • src/platform/remoteConfig/refreshRemoteConfig.ts
  • src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts
  • src/platform/workspace/stores/teamWorkspaceStore.ts
  • src/platform/workspace/stores/useWorkspaceAuth.test.ts
  • src/platform/workspace/stores/workspaceAuthStore.ts
  • src/router.test.ts
  • src/router.ts
  • src/scripts/api.suspendedSession.test.ts
  • src/scripts/api.ts
  • src/stores/assetsStore.test.ts
  • src/stores/assetsStore.ts
  • src/stores/authStore.test.ts
  • src/stores/queueStore.test.ts
  • src/stores/queueStore.ts

Comment on lines +315 to +424
it('disarms a closed-but-dirty document without bouncing an empty page', async () => {
const original = Object.getOwnPropertyDescriptor(window, 'location')
const reload = vi.fn()
Object.defineProperty(window, 'location', {
value: { reload },
writable: true,
configurable: true
})

try {
const closedButDirty = { isModified: true }
const { onAuthUserResolved } = await loadHook()
await onAuthUserResolved({ id: 'uid-a' })
mocks.openWorkflows = []
mocks.modifiedWorkflows = [closedButDirty]

await onAuthUserResolved({ id: 'uid-b' })

// Nothing is on screen to inherit, so no bounce; but the stale mark would
// arm the unload prompt against the new user for a document that is not
// theirs and is already gone from storage.
expect(reload).not.toHaveBeenCalled()
expect(closedButDirty.isModified).toBe(false)
} finally {
if (original) Object.defineProperty(window, 'location', original)
}
})

it('bounces even when the open document has no unsaved changes', async () => {
const original = Object.getOwnPropertyDescriptor(window, 'location')
const reload = vi.fn()
Object.defineProperty(window, 'location', {
value: { reload },
writable: true,
configurable: true
})

try {
const { onAuthUserResolved } = await loadHook()
await onAuthUserResolved({ id: 'uid-a' })
// Saved, so it is open but absent from `modifiedWorkflows`. Deciding the
// reload off that collection leaves uid-a's canvas mounted for uid-b.
mocks.openWorkflows = [{ isModified: false }]
mocks.modifiedWorkflows = []

await onAuthUserResolved({ id: 'uid-b' })

expect(reload).toHaveBeenCalledTimes(1)
} finally {
if (original) Object.defineProperty(window, 'location', original)
}
})

it('clears every modified workflow, including ones already closed', async () => {
const original = Object.getOwnPropertyDescriptor(window, 'location')
const reload = vi.fn()
Object.defineProperty(window, 'location', {
value: { reload },
writable: true,
configurable: true
})

try {
const openA = { isModified: true }
const openB = { isModified: true }
// Closed earlier with "close anyway", so unload() left it modified. The
// unload prompt reads this collection, so it alone can veto the reload.
const closedButDirty = { isModified: true }

const { onAuthUserResolved } = await loadHook()
await onAuthUserResolved({ id: 'uid-a' })
mocks.openWorkflows = [openA, openB]
mocks.modifiedWorkflows = [openA, openB, closedButDirty]

await onAuthUserResolved({ id: 'uid-b' })

expect(openA.isModified).toBe(false)
expect(openB.isModified).toBe(false)
expect(closedButDirty.isModified).toBe(false)
expect(reload).toHaveBeenCalledTimes(1)
} finally {
if (original) Object.defineProperty(window, 'location', original)
}
})

it('does not close anything, so the persistence writers stay quiet', async () => {
const original = Object.getOwnPropertyDescriptor(window, 'location')
Object.defineProperty(window, 'location', {
value: { reload: vi.fn() },
writable: true,
configurable: true
})

try {
const open = { isModified: true }
const { onAuthUserResolved } = await loadHook()
await onAuthUserResolved({ id: 'uid-a' })
mocks.openWorkflows = [open]
mocks.modifiedWorkflows = [open]

await onAuthUserResolved({ id: 'uid-b' })

// Closing re-activates other documents, which re-arms the persistence
// watchers against the storage cleared one line earlier. The reload
// discards the canvas anyway.
expect(mocks.closeWorkflow).not.toHaveBeenCalled()
} finally {
if (original) Object.defineProperty(window, 'location', original)
}
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract the window.location stub/restore boilerplate.

The same descriptor save → defineProperty({ reload }) → restore-in-finally block is repeated in five tests. A helper (or beforeEach/afterEach pair returning the reload spy) keeps each test to its actual behavior.

♻️ Sketch
+let reload: ReturnType<typeof vi.fn>
+let originalLocation: PropertyDescriptor | undefined
+
+beforeEach(() => {
+  originalLocation = Object.getOwnPropertyDescriptor(window, 'location')
+  reload = vi.fn()
+  Object.defineProperty(window, 'location', {
+    value: { reload },
+    writable: true,
+    configurable: true
+  })
+})
+
+afterEach(() => {
+  if (originalLocation)
+    Object.defineProperty(window, 'location', originalLocation)
+})
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/extensions/core/cloudSessionCookie.test.ts` around lines 315 - 424,
Extract the repeated window.location descriptor setup and restoration into
shared test lifecycle logic or a helper that returns the reload spy. Update the
affected tests around onAuthUserResolved to use this utility, preserving
configurable restoration after each test and each test’s existing reload
assertions.

Comment on lines +131 to +138
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
suspendSession()

await restoreCloudSession()

expect(isSessionSuspended()).toBe(true)
expect(mocks.addToast).toHaveBeenCalledTimes(1)
warn.mockRestore()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Hoist the console.warn silencing into the suite lifecycle.

The spy is re-created and manually restored in roughly a dozen tests; when an assertion fails before mockRestore(), the spy leaks into later tests. A single beforeEach/afterEach pair (or vi.restoreAllMocks() in afterEach) removes both the duplication and the leak.

♻️ Sketch
+let warn: ReturnType<typeof vi.spyOn>
+
+beforeEach(() => {
+  warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
+})
+
+afterEach(() => {
+  warn.mockRestore()
+})
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/auth/session/restoreCloudSession.test.ts` around lines 131 -
138, Move the console.warn spy setup from individual tests into the
restoreCloudSession test suite’s beforeEach lifecycle hook, and restore it in
afterEach (or use vi.restoreAllMocks()). Remove each test’s local spy creation
and manual mockRestore calls while preserving the existing warning-suppression
behavior.

Comment on lines +90 to +95
// `mintAtLogin` returns false without saying anything when the flag is off,
// so reading the bare boolean as "it already told them" silences the only
// failure message the whole non-unified path has.
mintReportedFailure =
useFeatureFlags().flags.unifiedCloudAuthEnabled &&
!(await useWorkspaceAuthStore().mintAtLogin())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
ast-grep outline src/platform/workspace/stores/workspaceAuthStore.ts --items all
rg -nP -C4 '\bmintAtLogin\s*\(' src --type=ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 26864


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== restoreCloudSession.ts relevant section =="
sed -n '1,140p' src/platform/auth/session/restoreCloudSession.ts

echo
echo "== workspaceAuthStore.ts relevant sections =="
sed -n '620,680p' src/platform/workspace/stores/workspaceAuthStore.ts
sed -n '800,855p' src/platform/workspace/stores/workspaceAuthStore.ts

echo
echo "== tests around restore and non-unified mint =="
rg -n -C 6 "still reports a failed recovery when unified auth is off|mints the request credential|unifiedCloudAuthEnabled|mintAtLogin" src/platform --type=ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 50382


🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== all callers of restoreCloudSession =="
rg -n -C 4 '\brestoreCloudSession\s*\(' src tests --type=ts --type=vue || true

echo
echo "== authStore login hook section =="
sed -n '140,190p' src/stores/authStore.ts

echo
echo "== authStore request credential helpers and auth header sections =="
sed -n '200,290p' src/stores/authStore.ts

echo
echo "== workspaceAuthStore unified vs non-unified header/token sections =="
sed -n '936,1018p' src/platform/workspace/stores/workspaceAuthStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 27536


Preserve the existing non-unified credential path during recovery.

mintAtLogin() only mints the unified Cloud JWT and skips minting workspace tokens, while the non-unified getAuthHeader() chain can still need ensureWorkspaceAuthHeader()/Firebase tokens. This changes the recovery behavior compared with the previous path.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/auth/session/restoreCloudSession.ts` around lines 90 - 95,
Update the recovery logic around mintAtLogin so the non-unified path still
invokes the existing getAuthHeader flow, including
ensureWorkspaceAuthHeader/Firebase token retrieval. Limit mintAtLogin to
unifiedCloudAuthEnabled, and preserve the current mintReportedFailure handling
without replacing the legacy credential recovery path.

Comment on lines +111 to +113
if (wasSuspended) {
void restoreWorkspaceScope().finally(() => void api.reconnectSocket())
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

void api.reconnectSocket() leaves a rejection unhandled.

restoreWorkspaceScope swallows its own errors, but a rejecting reconnectSocket here escapes as an unhandled rejection on the recovery path.

🛡️ Proposed fix
     if (wasSuspended) {
-      void restoreWorkspaceScope().finally(() => void api.reconnectSocket())
+      void restoreWorkspaceScope().finally(() =>
+        void Promise.resolve(api.reconnectSocket()).catch((error) => {
+          console.warn('Realtime could not be reconnected:', error)
+        })
+      )
     }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
if (wasSuspended) {
void restoreWorkspaceScope().finally(() => void api.reconnectSocket())
}
if (wasSuspended) {
void restoreWorkspaceScope().finally(() =>
void Promise.resolve(api.reconnectSocket()).catch((error) => {
console.warn('Realtime could not be reconnected:', error)
})
)
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/auth/session/restoreCloudSession.ts` around lines 111 - 113,
Handle rejections from api.reconnectSocket in the wasSuspended recovery path
instead of discarding its promise. Update the finally callback around
restoreWorkspaceScope so reconnectSocket’s failure is explicitly caught or
otherwise consumed, while preserving the existing reconnect attempt after
workspace restoration.

Comment on lines +49 to +53
// A suspended session answers this with a synthetic 401, and the handler
// below reads a 401 as "the server disowned these flags" and wipes them. The
// 10-minute poller would then strip the export affordances out from under a
// banner telling the user to go export their work.
if (useAuth && isSessionSuspended()) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Recheck suspension after awaited requests before mutating retained state. These guards only protect calls that begin after suspension. If suspension starts while a request is in flight, synthetic/failed results can still clear remote config, gallery history, or job history.

  • src/platform/remoteConfig/refreshRemoteConfig.ts#L49-L53: recheck before processing an unauthorized response or clearing config.
  • src/stores/assetsStore.ts#L156-L160: defer destructive initial-load reset until a valid result is ready, and discard results when suspension begins in flight.
  • src/stores/queueStore.ts#L525-L529: recheck after Promise.allSettled() and before applying either result.
  • src/stores/queueStore.test.ts#L1145-L1170: add a regression case that suspends after requests begin but before their promises settle.
📍 Affects 4 files
  • src/platform/remoteConfig/refreshRemoteConfig.ts#L49-L53 (this comment)
  • src/stores/assetsStore.ts#L156-L160
  • src/stores/queueStore.ts#L525-L529
  • src/stores/queueStore.test.ts#L1145-L1170
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/remoteConfig/refreshRemoteConfig.ts` around lines 49 - 53,
Recheck suspension after awaited requests and before mutating retained state: in
src/platform/remoteConfig/refreshRemoteConfig.ts#L49-L53, skip
unauthorized-response handling and config clearing when suspension began in
flight; in src/stores/assetsStore.ts#L156-L160, defer destructive initial-load
reset until a valid result exists and discard in-flight results after
suspension; in src/stores/queueStore.ts#L525-L529, recheck after
Promise.allSettled() before applying either result; add a regression test in
src/stores/queueStore.test.ts#L1145-L1170 that suspends after requests start but
before they settle.

Comment on lines +536 to +543
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})

await expect(
store.register('new@example.com', 'password', 'turnstile-bad')
).rejects.toThrow()

expect(isVoluntarySignOutInProgress()).toBe(false)
warn.mockRestore()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Locate and inspect the referenced test file and nearby teardown/setup context.
if [ -f "src/stores/authStore.test.ts" ]; then
  echo "## file exists"
  wc -l src/stores/authStore.test.ts
  echo "## outline"
  ast-grep outline src/stores/authStore.test.ts --view expanded || true
  echo "## relevant lines 500-560"
  cat -n -s src/stores/authStore.test.ts | sed -n '500,560p'
  echo "## beforeEach/reset occurrences"
  rg -n "beforeEach|resetAllMocks|restoreAllMocks|mockRestore|console\s*\.\s*warn|warn\s*=" src/stores/authStore.test.ts
else
  echo "file missing"
  git ls-files | rg 'authStore\.test\.ts$' || true
fi

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 4103


Restore the console spy on every exit path.

If registration or an assertion fails, warn.mockRestore() is skipped and console.warn can remain mocked for subsequent tests. Wrap the test body or expected assertions in try/finally.

Proposed fix
-      await expect(
-        store.register('new@example.com', 'password', 'turnstile-bad')
-      ).rejects.toThrow()
-
-      expect(isVoluntarySignOutInProgress()).toBe(false)
-      warn.mockRestore()
+      try {
+        await expect(
+          store.register('new@example.com', 'password', 'turnstile-bad')
+        ).rejects.toThrow()
+
+        expect(isVoluntarySignOutInProgress()).toBe(false)
+      } finally {
+        warn.mockRestore()
+      }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
await expect(
store.register('new@example.com', 'password', 'turnstile-bad')
).rejects.toThrow()
expect(isVoluntarySignOutInProgress()).toBe(false)
warn.mockRestore()
const warn = vi.spyOn(console, 'warn').mockImplementation(() => {})
try {
await expect(
store.register('new@example.com', 'password', 'turnstile-bad')
).rejects.toThrow()
expect(isVoluntarySignOutInProgress()).toBe(false)
} finally {
warn.mockRestore()
}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/stores/authStore.test.ts` around lines 536 - 543, Ensure the console.warn
spy created in this registration test is restored on every exit path by wrapping
the awaited registration assertion and related checks in a try/finally block,
with warn.mockRestore() in finally. Keep the existing rejection and sign-out
assertions unchanged.

Source: Path instructions

A populated currentUser does not prove the popup signed anyone in. A
restore that fails after a successful sign-in leaves one behind, so the
next cancelled popup passed the guard and reported a failure the user
never triggered. The shared actions already return a credential on
success and nothing when they reported a failure, which is the only
honest signal available here.

Also uses createTestingPinia in the re-auth suite, per the documented
Vitest pattern, and repairs a dropped relative pronoun and a stray line
break in the ADR paragraph.
@CodeJuggernaut

Copy link
Copy Markdown
Contributor Author

Addressed in 87c029c9bd.

Gating the restore on the sign-in result. You were right that a populated currentUser does not prove the popup signed anyone in: a restore that fails after a successful sign-in leaves one behind, so the next cancelled popup passed the guard and reported a failure the user never triggered. The shared actions already return a credential on success and undefined when they reported a failure, so the guard now reads that instead. Added a regression test for exactly that sequence (sign in, restore fails, cancel the retry); removing the guard fails it.

createTestingPinia. Taken. Worth noting the other three beforeEach blocks in that file predate this PR and use createPinia, so the file is now mixed; I only changed the block this PR added rather than reformatting neighbours.

ADR wording. Fixed the dropped relative pronoun and a stray line break my in-place edit left behind.

Not taking two, with reasons rather than silence:

  • Extracting the sign-out bracket into a helper. Three call sites, and the risk you name is real, but a wrapper hides the one property that matters, that the release runs in a finally. There are now tests pinning that release on the failure path at all three sites, which defends the invariant without hiding it.
  • Neutral copy for auth/user-disabled. Fair point that "Your session expired" misstates the cause for a disabled account. Reason-aware copy needs the disable reason plumbed to the banner, which is beyond this PR's scope; leaving it for a follow-up rather than half-doing it here.

Local: typecheck, lint, format, knip clean; 13574 passing.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

The three points from the last review are addressed in 87c029c9bd; the standing CHANGES_REQUESTED predates it.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown
Contributor

@CodeJuggernaut: I’ll review the current PR state, including the changes in 87c029c9bd.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-main lint preflight at this exact head has nine redundant Vitest cleanup findings plus two production throw new Error(...) findings. Because this PR is authored outside the fleet identities, branch policy permits review comments but not a direct push.

}))

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove this vi.clearAllMocks()? Current main enables automatic Vitest cleanup, so the new comfy/no-redundant-vitest-cleanup rule rejects this per-test reset.

describe('reauthentication recovery', () => {
beforeEach(() => {
setActivePinia(createTestingPinia({ stubActions: false }))
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove the vi.clearAllMocks() calls in each beforeEach in this file (146, 308, 387, and 464)? Current main performs that cleanup centrally and flags these as redundant.

}))

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you drop this vi.clearAllMocks() now that current main provides automatic mock cleanup? The merged-tree lint rejects it via comfy/no-redundant-vitest-cleanup.

}

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove this vi.clearAllMocks()? It duplicates current main's global Vitest cleanup and fails comfy/no-redundant-vitest-cleanup.

}

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove this vi.clearAllMocks()? Current main clears mocks centrally, and the merged-tree lint flags this reset as redundant.

}

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you drop this vi.clearAllMocks() under the current-main Vitest setup? The automatic cleanup makes this redundant and the new lint rule rejects it.

Comment thread src/router.test.ts
}, 60_000)

beforeEach(() => {
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove this vi.clearAllMocks()? Current main supplies automatic mock cleanup, so this fails comfy/no-redundant-vitest-cleanup.

// Call history too, not just implementations: the entry-guard assertion
// below is `not.toHaveBeenCalled()`, which any earlier case that reaches
// the token lookup would otherwise decide.
vi.clearAllMocks()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you remove only this global vi.clearAllMocks() while retaining the targeted fetch reset and wsConstructed reset below? Current main handles mock cleanup centrally, but those two local state resets still carry behavior.

await Promise.race([
workspaceStore.initialize(),
promiseTimeout(WORKSPACE_SCOPE_TIMEOUT_MS).then(() => {
throw new Error('Workspace scope restore timed out')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be cleaner to race workspaceStore.initialize() directly against promiseTimeout(WORKSPACE_SCOPE_TIMEOUT_MS)? promiseTimeout already rejects on expiry, so the extra throw new Error(...) is unnecessary and current main rejects it via comfy/no-new-error-throw.

!(await useWorkspaceAuthStore().mintAtLogin())

if (!(await useAuthStore().getAuthHeader())) {
throw new Error('Session restored without a usable request credential')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this missing-credential case return an explicit failed restore result that the existing recovery boundary reports, instead of using throw new Error(...) for recoverable control flow? Current main's comfy/no-new-error-throw rule points this path to ADR-0019's explicit failure contract.

@christian-byrne

Copy link
Copy Markdown
Contributor

Sentry confirms the expired-session path is still live on agent.comfy.org.

  • One user’s release 1.54.3 session ran successfully for hours, then jobs and billing calls began returning 401.
  • The billing capability failure is handled, but it created a new Sentry group.
  • This is evidence for this PR, not a separate bug.
Full context for agent readers

Sentry CLOUD-FRONTEND-PROD-1GG recorded WorkspaceApiError: invalid auth token with error_type=billing_capabilities_read_failure, outcome=denied, and status=401. Breadcrumbs show repeated successful /api/features, /api/jobs, and /api/billing/capabilities requests before the token expired; the final sequence contains jobs 401s followed by /api/billing/capabilities 401. This matches the dead-session recovery path this PR owns. Count: 1 event / 1 user in the observer window ending 2026-09-05T04:07:23Z.

No duplicate program or Linear bug was created. The program carrier remains act-fe-14207-lintfix; the Sentry permalink is attached there for the next PR progression pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants