Repository navigation
refactor(vue-nodes): address DrJKL review on the size-Proxy (trim comments, cut spec-mechanics tests, hoist mutations) - #14025
Conversation
…ments, cut spec-mechanics tests, hoist mutations) - Trim the TODO(litegraph-stable-resize-api) block to a one-line intent pointer instead of enumerating a resize API that does not exist yet. - Cut change-detector tests that assert ECMAScript TypedArray/Proxy spec mechanics (typed-array semantics, buffer contract, cached-Proxy identity, sibling pos subarray, fluent-mutator chain); keep the behavioral cases (single commit per grow, no-feedback-loop guard, in-place set, detached no-commit, serialize-no-leak). - Hoist useLayoutMutations() to module scope (captures only the layoutStore singleton); reuse it in set pos and _sizeUpdated. - Trim the 3-line justification comment in useLayoutSync to one line. - Drop the dead Math.max(..., 200) in the devtools reflow node. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 30 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1732 passed, 0 failed📊 Browser Reports
📦 Bundle: 8.08 MB gzip 🟢 -228 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 1 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 4 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 15 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 1 unchanged UI Components — 64.7 kB (baseline 64.7 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 8 unchanged Data & Services — 3.37 MB (baseline 3.37 MB) • 🟢 -489 BStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 357 kB (baseline 357 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 17 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.4 MB (baseline 12.4 MB) • 🟢 -292 BBundles that do not match a named category
Status: 75 added / 75 removed / 199 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-23T04:15:49.111Z",
"gitSha": "625df5633f58ef0cd9181665e9a89d0e6c31a7d1",
"branch": "followup/13867-drjkl",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2209.6050000000105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.502,
"heapDeltaBytes": 3624864,
"heapUsedBytes": 71316028,
"domNodes": 18,
"jsHeapTotalBytes": 20324352,
"scriptDurationMs": 24.682000000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2015.9869999999955,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.796999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.2790000000001,
"heapDeltaBytes": 3583152,
"heapUsedBytes": 71021448,
"domNodes": 20,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 21.078,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.7380000000046,
"styleRecalcs": 73,
"styleRecalcDurationMs": 34.644999999999996,
"layouts": 12,
"layoutDurationMs": 3.3159999999999994,
"taskDurationMs": 833.8899999999999,
"heapDeltaBytes": -1704192,
"heapUsedBytes": 65779572,
"domNodes": 56,
"jsHeapTotalBytes": 21897216,
"scriptDurationMs": 114.576,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.6689999999694,
"styleRecalcs": 76,
"styleRecalcDurationMs": 42.33500000000001,
"layouts": 12,
"layoutDurationMs": 4.066,
"taskDurationMs": 930.08,
"heapDeltaBytes": -16027128,
"heapUsedBytes": 51421664,
"domNodes": -267,
"jsHeapTotalBytes": 20975616,
"scriptDurationMs": 121.603,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.5970000000407,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.147999999999996,
"layouts": 6,
"layoutDurationMs": 0.696,
"taskDurationMs": 385.698,
"heapDeltaBytes": 7111280,
"heapUsedBytes": 74575852,
"domNodes": 79,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 20.342,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1569999999538,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.618000000000002,
"layouts": 6,
"layoutDurationMs": 0.6460000000000001,
"taskDurationMs": 389.37200000000007,
"heapDeltaBytes": 7070212,
"heapUsedBytes": 74605000,
"domNodes": 78,
"jsHeapTotalBytes": 20586496,
"scriptDurationMs": 20.876999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 586.010999999985,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.721999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.528,
"heapDeltaBytes": -12038560,
"heapUsedBytes": 55275704,
"domNodes": 18,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 58.001999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 623.2269999999858,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.110999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.78700000000003,
"heapDeltaBytes": -12280760,
"heapUsedBytes": 55267512,
"domNodes": 20,
"jsHeapTotalBytes": 21110784,
"scriptDurationMs": 58.038999999999994,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2029.6200000000226,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.478000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 706.0509999999999,
"heapDeltaBytes": 6665780,
"heapUsedBytes": 65770784,
"domNodes": -269,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 107.72699999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.209000000019,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 760.0530000000001,
"heapDeltaBytes": 6259212,
"heapUsedBytes": 65022100,
"domNodes": -268,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 119.74300000000001,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2169.0530000000194,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.203999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1257.06,
"heapDeltaBytes": 5247816,
"heapUsedBytes": 64955872,
"domNodes": -270,
"jsHeapTotalBytes": 5259264,
"scriptDurationMs": 413.731,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2189.5339999999806,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.597999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1351.885,
"heapDeltaBytes": 5440032,
"heapUsedBytes": 65236000,
"domNodes": -271,
"jsHeapTotalBytes": 4734976,
"scriptDurationMs": 452.333,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3227.5869999999713,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.705000000000004,
"layouts": 60,
"layoutDurationMs": 8.184999999999999,
"taskDurationMs": 1547.2769999999998,
"heapDeltaBytes": -1796568,
"heapUsedBytes": 59513340,
"domNodes": -273,
"jsHeapTotalBytes": 8200192,
"scriptDurationMs": 534.89,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3283.9079999999967,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.28,
"layouts": 60,
"layoutDurationMs": 8.719000000000001,
"taskDurationMs": 1628.094,
"heapDeltaBytes": 381304,
"heapUsedBytes": 64267864,
"domNodes": -270,
"jsHeapTotalBytes": 7938048,
"scriptDurationMs": 572.727,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.0760000000082,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.790000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 690.3359999999999,
"heapDeltaBytes": 6555632,
"heapUsedBytes": 66736216,
"domNodes": -270,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 103.787,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.358000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.328000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 730.072,
"heapDeltaBytes": 6651352,
"heapUsedBytes": 66934976,
"domNodes": -269,
"jsHeapTotalBytes": 4268032,
"scriptDurationMs": 111.99300000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.8079999999859,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.37399999999997,
"heapDeltaBytes": -11920436,
"heapUsedBytes": 55693704,
"domNodes": 20,
"jsHeapTotalBytes": 21635072,
"scriptDurationMs": 122.052,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.7499999999663,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.109,
"heapDeltaBytes": -11821104,
"heapUsedBytes": 55897472,
"domNodes": 20,
"jsHeapTotalBytes": 22159360,
"scriptDurationMs": 122.737,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2019.358000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.883,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.76499999999993,
"heapDeltaBytes": 3327496,
"heapUsedBytes": 70845104,
"domNodes": 18,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 14.687999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2026.5109999999709,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.056999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.621,
"heapDeltaBytes": 3348704,
"heapUsedBytes": 70847840,
"domNodes": 20,
"jsHeapTotalBytes": 21110784,
"scriptDurationMs": 20.285999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.9060000000045,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.381,
"layouts": 16,
"layoutDurationMs": 4.494,
"taskDurationMs": 756.062,
"heapDeltaBytes": -5594964,
"heapUsedBytes": 61812832,
"domNodes": 66,
"jsHeapTotalBytes": 21372928,
"scriptDurationMs": 90.55199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.9910000000173,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.105000000000004,
"layouts": 16,
"layoutDurationMs": 4.556,
"taskDurationMs": 792.083,
"heapDeltaBytes": -5605104,
"heapUsedBytes": 62137604,
"domNodes": 63,
"jsHeapTotalBytes": 20848640,
"scriptDurationMs": 96.179,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1386.5190000000212,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.58000000000001,
"layouts": 13,
"layoutDurationMs": 11.554000000000002,
"taskDurationMs": 972.8230000000002,
"heapDeltaBytes": 31343416,
"heapUsedBytes": 99114888,
"domNodes": 13673,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 37.029,
"eventListeners": 2371,
"totalBlockingTimeMs": 118,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8262.276999999984,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4426.763,
"heapDeltaBytes": 1984160,
"heapUsedBytes": 60659672,
"domNodes": -267,
"jsHeapTotalBytes": 6627328,
"scriptDurationMs": 1362.989,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8201.920000000086,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4458.491,
"heapDeltaBytes": 10004068,
"heapUsedBytes": 69443596,
"domNodes": -265,
"jsHeapTotalBytes": 7094272,
"scriptDurationMs": 1321.529,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18077.665999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18051.654999999995,
"heapDeltaBytes": -46055364,
"heapUsedBytes": 166591088,
"domNodes": -8311,
"jsHeapTotalBytes": -11472896,
"scriptDurationMs": 566.397,
"eventListeners": -16382,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18097.288000000048,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18062.144,
"heapDeltaBytes": -45642212,
"heapUsedBytes": 167053612,
"domNodes": -8311,
"jsHeapTotalBytes": -11997184,
"scriptDurationMs": 575.488,
"eventListeners": -16380,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22143.44599999998,
"styleRecalcs": 156,
"styleRecalcDurationMs": 22.165999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22095.024,
"heapDeltaBytes": -31777500,
"heapUsedBytes": 177818756,
"domNodes": -8311,
"jsHeapTotalBytes": -14966784,
"scriptDurationMs": 877.3109999999999,
"eventListeners": -16374,
"totalBlockingTimeMs": 443,
"frameDurationMs": 18.33666666666662,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22520.52900000001,
"styleRecalcs": 166,
"styleRecalcDurationMs": 25.38299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22441.05,
"heapDeltaBytes": -41010392,
"heapUsedBytes": 176544436,
"domNodes": -8311,
"jsHeapTotalBytes": -13918208,
"scriptDurationMs": 913.257,
"eventListeners": -16380,
"totalBlockingTimeMs": 635,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 458.2849999999894,
"styleRecalcs": 12,
"styleRecalcDurationMs": 17.619000000000003,
"layouts": 2,
"layoutDurationMs": 0.4319999999999999,
"taskDurationMs": 114.68,
"heapDeltaBytes": -16188344,
"heapUsedBytes": 50557384,
"domNodes": 128,
"jsHeapTotalBytes": 8265728,
"scriptDurationMs": 10.375,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 461.8239999999787,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.304999999999996,
"layouts": 2,
"layoutDurationMs": 0.42599999999999993,
"taskDurationMs": 120.30999999999999,
"heapDeltaBytes": -16283056,
"heapUsedBytes": 50389880,
"domNodes": 119,
"jsHeapTotalBytes": 8003584,
"scriptDurationMs": 10.173,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
| * TODO(litegraph-stable-resize-api): interim shim — remove once a stable resize | ||
| * API replaces direct typed-array size access. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14025 +/- ##
========================================
Coverage 78.70% 78.70%
========================================
Files 1697 1697
Lines 118480 118467 -13
Branches 36894 37561 +667
========================================
- Hits 93245 93238 -7
+ Misses 24551 24539 -12
- Partials 684 690 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@christian-byrne Successfully backported to #14027 |
|
@christian-byrne Successfully backported to #14028 |
Summary
Follow-up to the merged #13867 (runtime size-Proxy reflow) addressing DrJKL's post-merge review: trim speculative comments, cut change-detector tests, and hoist a per-call allocation.
Changes
LGraphNode.ts— trim theTODO(litegraph-stable-resize-api)block (~9 lines enumerating a not-yet-existingComfy.Node.Resize/NodeHandleAPI, drafted in feat(api): Comfy.Node.Resize command + NodeHandle.setSize (first slice of the stable resize API) #13929) to a one-line intent pointer; hoistuseLayoutMutations()to module scope (it captures only thelayoutStoresingleton) and reuse it inset posand_sizeUpdated.nodeSizeReflow.test.ts— cut five change-detector tests that assert ECMAScript TypedArray/Proxy spec mechanics (typed-array semantics, buffer contract, cached-Proxy identity, siblingpossubarray, fluent-mutator chain). Keep the behavioral cases: single commit per grow, per-axis sequential writes, whole-array assign, no-feedback-loop guard, in-place.set(), detached no-commit, and serialize-no-leak.useLayoutSync.ts— collapse a 3-line justification comment to one line.tools/devtools/web/runtimeReflow.js— drop the deadMath.max(..., 200)(start height + 120 already exceeds 200).Review Focus
layoutMutationsis safe becauseuseLayoutMutations()closes over only thelayoutStoremodule singleton (verified inlayoutMutations.ts).double as unknown asat thepage.evaluateboundary inruntimeReflow.tsis left as-is per DrJKL's note (acceptable last-resort interop assertion).Follow-up to #13867.