Skip to content

[backport cloud/1.47] fix(vue-nodes): reflow node when custom nodes grow size at runtime (size Proxy) - #14017

Merged
christian-byrne merged 1 commit into
cloud/1.47from
backport-13867-to-cloud-1.47
Jul 23, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.47from
backport-13867-to-cloud-1.47

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #13867 to cloud/1.47

Automatically created by backport workflow.

…ize Proxy) (#13867)

Fixes #13863

## Problem

Custom nodes grow a node at runtime by writing `node.size[1]` directly
(an
element mutation) and calling `setDirtyCanvas(...)`, instead of going
through
`node.setSize()` / the `set size` setter. On Vue Nodes the node keeps
its old
height until the user manually resizes it.

Root cause: a Vue node's geometry is owned by `layoutStore`. The only
litegraph
path that mirrored height into `layoutStore` was the `set size`
**setter**. A
direct `node.size[1] = ...` element mutation bypassed the setter, and
`setDirtyCanvas` is a no-op for Vue nodes, so the store never learned
the new
height. This is a copy-pasted idiom, not one pack's quirk — two variants
hit
the seam:

1. **Widget-count growth** — `addCustomWidget(...)` then `node.size[1] =
...`:
   rgthree Power Lora Loader, yolain ComfyUI-Easy-Use, comfyui-0246,
ComfyUI-N-Nodes, comfyui-mixlab-nodes, comfyui-advanced-latent-control.
2. **Image-preview growth with NO widget change** — on `img.onload`,
   `node.imgs = [...]; node.size[1] = Math.max(200, ...)`: ltdrdata
   ComfyUI-Impact-Pack, ComfyUI-N-Nodes.

## Fix

Intercept the size mutation directly. `get size` returns a cached
`Proxy` over
the node's backing `_size` array whose `set` trap commits the new size
to
`layoutStore` through a shared `_sizeUpdated()` — the same path the `set
size`
setter now uses. So both `node.size = [w, h]` and the element-mutation
idioms
`node.size[0] = w` / `node.size[1] = h` reflow the Vue node, with no
polling and
no per-pack fix.

The Proxy is created once per node and reused. Index writes pass
straight
through to the backing `Float64Array`; function and `length` access is
forwarded
to the real typed array, so spread, iteration and `.length` keep
working, and
serialization is unaffected (it reads `size[0]`/`size[1]` into a plain
array).

Loop safety (no exploding node): `_sizeUpdated()` commits only when the
size
actually changed (`isSizeEqual` guard), tagged `LayoutSource.Canvas`.
The
layout → litegraph write-back in `useLayoutSync` applies the value
through the
setter, so when it re-applies the size the node already holds, the guard
makes
it a no-op — no feedback loop through `handleLayoutChange`.

This replaces the earlier `useRuntimeWidgetReflow`
reconcile-on-animation-frame
shim; the mutation itself now commits, so the poll is gone.

`// TODO(litegraph-stable-resize-api)`: remove the Proxy once litegraph
exposes
a public resize/commit API that custom nodes call instead of mutating
`node.size[1]` directly.

## Tests

- `nodeSizeReflow.test.ts` (unit): a single `size[1]=` element mutation
commits
exactly one `resizeNode` to `layoutStore`; the setter commits once; an
equal
write-back does not re-commit (loop-safe); typed-array semantics
(spread,
`Array.from`, `.length`) survive the Proxy; no commit before the node
joins a
  graph.
- DevTools `Node Runtime Reflow` node emulates both idioms on the client
  (`growByWidget()` and `growByPreview()`).
- `runtimeWidgetReflow.spec.ts` (e2e, `@vue-nodes`): the rendered node
height
  grows for BOTH triggers with no manual resize.

## Direction / migration

This Proxy is not a dead-end shim — it is the **deprecation on-ramp for
a stable resize API that does not exist yet**. Its `set` trap already
commits the legacy `node.size[1] =` idiom through `resizeNode`, the
**same** layout-store primitive the sanctioned future API will call.

Target end-state (see `research/architecture/toward-new-api-plan.md` §2,
follow-ups A2/A3/A4):

- A public **`Comfy.Node.Resize` command** + **`NodeHandle.setSize()` /
`autosize()` / `on('resize')`** (v2 extension handles) that custom nodes
call instead of mutating `node.size[1]`.
- Both terminate in the one authoritative `resizeNode(nodeId, size,
source)` primitive — no second write path.

Once that API lands, this trap should emit a **one-time
`warnDeprecated`** naming the sanctioned call — turning direct element
writes into a migrate-me signal rather than a silent shim (the
array-element equivalent of `defineDeprecatedProperty`). That runtime
warn is a **deliberate later fast-follow (A4)**, intentionally not in
this PR. Ecosystem gap rows: `S2.N19` / `S10.D3` / `S11.G4`.

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Jul 23, 2026
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 23, 2026
@github-actions

github-actions Bot commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1701 passed, 0 failed · 4 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1682 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/23/2026, 03:06:35 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 45.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 51.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 97.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.8 MB heap
vue-large-graph-pan: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 1ms TBT · 170.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 384ms
canvas-idle: script duration 18ms
canvas-idle: TBT 0ms
canvas-idle: heap used 52.1 MB
canvas-idle: DOM nodes -276
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 73
canvas-mouse-sweep: task duration 661ms
canvas-mouse-sweep: script duration 100ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.1 MB
canvas-mouse-sweep: DOM nodes -92
canvas-mouse-sweep: event listeners -97
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 265ms
canvas-zoom-sweep: script duration 18ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 63.6 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 327ms
dom-widget-clipping: script duration 46ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 45.1 MB
dom-widget-clipping: DOM nodes -271
dom-widget-clipping: event listeners -199
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 480ms
large-graph-idle: script duration 94ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 61.5 MB
large-graph-idle: DOM nodes -124
large-graph-idle: event listeners -98
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 16ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 69
large-graph-pan: task duration 888ms
large-graph-pan: script duration 332ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 58.8 MB
large-graph-pan: DOM nodes -123
large-graph-pan: event listeners -96
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 17ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1090ms
large-graph-zoom: script duration 433ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 69.0 MB
large-graph-zoom: DOM nodes 11
large-graph-zoom: event listeners 8
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 8
minimap-idle: task duration 436ms
minimap-idle: script duration 86ms
minimap-idle: TBT 0ms
minimap-idle: heap used 66.2 MB
minimap-idle: DOM nodes 16
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 306ms
subgraph-dom-widget-clipping: script duration 96ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 61.3 MB
subgraph-dom-widget-clipping: DOM nodes -121
subgraph-dom-widget-clipping: event listeners -93
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 343ms
subgraph-idle: script duration 15ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.0 MB
subgraph-idle: DOM nodes -122
subgraph-idle: event listeners -95
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 612ms
subgraph-mouse-sweep: script duration 79ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 51.8 MB
subgraph-mouse-sweep: DOM nodes -210
subgraph-mouse-sweep: event listeners -196
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 27ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 653ms
subgraph-transition-enter: script duration 26ms
subgraph-transition-enter: TBT 112ms
subgraph-transition-enter: heap used 97.5 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2531
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 53ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3220ms
viewport-pan-sweep: script duration 1138ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.7 MB
viewport-pan-sweep: DOM nodes -266
viewport-pan-sweep: event listeners -181
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11115ms
vue-large-graph-idle: script duration 474ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.8 MB
vue-large-graph-idle: DOM nodes -3300
vue-large-graph-idle: event listeners -16373
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 66
vue-large-graph-pan: task duration 13835ms
vue-large-graph-pan: script duration 674ms
vue-large-graph-pan: TBT 1ms
vue-large-graph-pan: heap used 170.4 MB
vue-large-graph-pan: DOM nodes -3301
vue-large-graph-pan: event listeners -16369
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 152ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 46.6 MB
workflow-execution: DOM nodes -165
workflow-execution: event listeners -132
Raw data
{
  "timestamp": "2026-07-23T03:15:10.205Z",
  "gitSha": "e0a7ba76bba222dff03d36473efd38597149ba36",
  "branch": "backport-13867-to-cloud-1.47",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2082.3749999999563,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.742999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 373.652,
      "heapDeltaBytes": -7244012,
      "heapUsedBytes": 45580080,
      "domNodes": -285,
      "jsHeapTotalBytes": 16642048,
      "scriptDurationMs": 14.921,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.4100000000653,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.364999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 393.499,
      "heapDeltaBytes": -7188420,
      "heapUsedBytes": 63664260,
      "domNodes": -267,
      "jsHeapTotalBytes": 19681280,
      "scriptDurationMs": 20.779000000000003,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1727.0380000001069,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 34.795,
      "layouts": 12,
      "layoutDurationMs": 3.7479999999999998,
      "taskDurationMs": 670.522,
      "heapDeltaBytes": -13129084,
      "heapUsedBytes": 57768404,
      "domNodes": -237,
      "jsHeapTotalBytes": 18632704,
      "scriptDurationMs": 94.314,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1710.6430000000046,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 32.277,
      "layouts": 12,
      "layoutDurationMs": 3.3390000000000004,
      "taskDurationMs": 651.189,
      "heapDeltaBytes": 22359292,
      "heapUsedBytes": 74538204,
      "domNodes": 53,
      "jsHeapTotalBytes": 19398656,
      "scriptDurationMs": 104.769,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1709.2249999999467,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 13.311000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.6110000000000001,
      "taskDurationMs": 247.32500000000002,
      "heapDeltaBytes": 7265164,
      "heapUsedBytes": 71717152,
      "domNodes": 78,
      "jsHeapTotalBytes": 24117248,
      "scriptDurationMs": 15.8,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.642999999991,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.8,
      "layouts": 6,
      "layoutDurationMs": 0.539,
      "taskDurationMs": 281.921,
      "heapDeltaBytes": 2303296,
      "heapUsedBytes": 61668052,
      "domNodes": 78,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 20.938,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 457.10399999995843,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.936000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.375,
      "heapDeltaBytes": -24444116,
      "heapUsedBytes": 46536908,
      "domNodes": -267,
      "jsHeapTotalBytes": 6574080,
      "scriptDurationMs": 44.056,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 579.7869999998966,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.02,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.057,
      "heapDeltaBytes": -23289732,
      "heapUsedBytes": 48133596,
      "domNodes": -274,
      "jsHeapTotalBytes": 4739072,
      "scriptDurationMs": 47.322,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.449000000037,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.456999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 408.57300000000004,
      "heapDeltaBytes": -6056544,
      "heapUsedBytes": 61457332,
      "domNodes": -268,
      "jsHeapTotalBytes": -1974272,
      "scriptDurationMs": 72.948,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2027.66500000007,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.764000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 550.8140000000001,
      "heapDeltaBytes": -6300868,
      "heapUsedBytes": 67565876,
      "domNodes": 20,
      "jsHeapTotalBytes": 8794112,
      "scriptDurationMs": 114.98899999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2091.3590000000113,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 16.733999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 854.3820000000001,
      "heapDeltaBytes": -9234704,
      "heapUsedBytes": 61793744,
      "domNodes": -258,
      "jsHeapTotalBytes": -1245184,
      "scriptDurationMs": 320.66299999999995,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2043.7819999999647,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.892999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 922.11,
      "heapDeltaBytes": 6484252,
      "heapUsedBytes": 61600748,
      "domNodes": 12,
      "jsHeapTotalBytes": 204800,
      "scriptDurationMs": 342.386,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3045.693999999912,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.305999999999997,
      "layouts": 60,
      "layoutDurationMs": 6.6610000000000005,
      "taskDurationMs": 1026.751,
      "heapDeltaBytes": 17375660,
      "heapUsedBytes": 72499360,
      "domNodes": 12,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 412.711,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3038.9189999999644,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 17.14,
      "layouts": 60,
      "layoutDurationMs": 7.721,
      "taskDurationMs": 1152.647,
      "heapDeltaBytes": 17377816,
      "heapUsedBytes": 72154900,
      "domNodes": 10,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 453.888,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.957000000014,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 4.199999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.581,
      "heapDeltaBytes": 13213524,
      "heapUsedBytes": 69367876,
      "domNodes": 14,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 75.561,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1988.2089999999835,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.735999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.68100000000004,
      "heapDeltaBytes": 12744168,
      "heapUsedBytes": 69536812,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 96.96199999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 477.06700000003366,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.940000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 285.145,
      "heapDeltaBytes": 12423976,
      "heapUsedBytes": 77323056,
      "domNodes": 22,
      "jsHeapTotalBytes": 23855104,
      "scriptDurationMs": 93.66199999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 540.4579999999441,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.584999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 326.44,
      "heapDeltaBytes": -2490500,
      "heapUsedBytes": 51149700,
      "domNodes": -264,
      "jsHeapTotalBytes": -135168,
      "scriptDurationMs": 98.44,
      "eventListeners": -193,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.4629999999634,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.51,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.094,
      "heapDeltaBytes": -7494364,
      "heapUsedBytes": 63471008,
      "domNodes": -264,
      "jsHeapTotalBytes": 19943424,
      "scriptDurationMs": 12.04,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.8789999999935,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.596,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 359.192,
      "heapDeltaBytes": -1259388,
      "heapUsedBytes": 58213340,
      "domNodes": 20,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 17.842999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1704.1419999999334,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.587999999999994,
      "layouts": 16,
      "layoutDurationMs": 3.6450000000000005,
      "taskDurationMs": 568.0489999999999,
      "heapDeltaBytes": -16249796,
      "heapUsedBytes": 54671340,
      "domNodes": -194,
      "jsHeapTotalBytes": 19156992,
      "scriptDurationMs": 73.87599999999999,
      "eventListeners": -197,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1721.9769999999244,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 36.247,
      "layouts": 16,
      "layoutDurationMs": 4.178,
      "taskDurationMs": 656.6139999999999,
      "heapDeltaBytes": -16895556,
      "heapUsedBytes": 54018168,
      "domNodes": -226,
      "jsHeapTotalBytes": 18108416,
      "scriptDurationMs": 84.64099999999999,
      "eventListeners": -195,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.3040000000819,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 26.587999999999994,
      "layouts": 16,
      "layoutDurationMs": 11.926999999999998,
      "taskDurationMs": 653.4629999999999,
      "heapDeltaBytes": 29633572,
      "heapUsedBytes": 102222628,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 25.535999999999998,
      "eventListeners": 2531,
      "totalBlockingTimeMs": 112,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8116.960999999947,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 50.92,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2973.382,
      "heapDeltaBytes": 23947492,
      "heapUsedBytes": 87340656,
      "domNodes": -274,
      "jsHeapTotalBytes": 819200,
      "scriptDurationMs": 1068.6140000000003,
      "eventListeners": -179,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8110.492000000022,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 55.622,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3467.212,
      "heapDeltaBytes": 22751592,
      "heapUsedBytes": 90195636,
      "domNodes": -257,
      "jsHeapTotalBytes": 1376256,
      "scriptDurationMs": 1207.5130000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 10685.386999999992,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10674.660000000002,
      "heapDeltaBytes": -49756020,
      "heapUsedBytes": 163501680,
      "domNodes": -3300,
      "jsHeapTotalBytes": 19136512,
      "scriptDurationMs": 418.597,
      "eventListeners": -16370,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11564.104000000043,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11554.885,
      "heapDeltaBytes": -16803920,
      "heapUsedBytes": 192519756,
      "domNodes": -3300,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 529.089,
      "eventListeners": -16376,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 13469.719000000056,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 18.337999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13451.908,
      "heapDeltaBytes": -26478208,
      "heapUsedBytes": 180168852,
      "domNodes": -3300,
      "jsHeapTotalBytes": 5943296,
      "scriptDurationMs": 676.736,
      "eventListeners": -16366,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14237.462999999934,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 18.904000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14218.449,
      "heapDeltaBytes": -37553488,
      "heapUsedBytes": 177202064,
      "domNodes": -3302,
      "jsHeapTotalBytes": 16924672,
      "scriptDurationMs": 672.1109999999999,
      "eventListeners": -16372,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.56399999996756,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 16.868000000000002,
      "layouts": 3,
      "layoutDurationMs": 2.21,
      "taskDurationMs": 132.649,
      "heapDeltaBytes": -3203560,
      "heapUsedBytes": 50252168,
      "domNodes": -143,
      "jsHeapTotalBytes": -1183744,
      "scriptDurationMs": 8.873000000000001,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 467.850999999996,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 18.369000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.32800000000000007,
      "taskDurationMs": 170.881,
      "heapDeltaBytes": -23351884,
      "heapUsedBytes": 47528052,
      "domNodes": -187,
      "jsHeapTotalBytes": 5263360,
      "scriptDurationMs": 9.189000000000002,
      "eventListeners": -134,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.47   #14017   +/-   ##
=============================================
  Coverage              ?   66.93%           
=============================================
  Files                 ?     1582           
  Lines                 ?    81826           
  Branches              ?    23275           
=============================================
  Hits                  ?    54772           
  Misses                ?    26709           
  Partials              ?      345           
Flag Coverage Δ
unit 66.93% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/renderer/core/layout/sync/useLayoutSync.ts 93.75% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit b3d463f into cloud/1.47 Jul 23, 2026
68 checks passed
@christian-byrne
christian-byrne deleted the backport-13867-to-cloud-1.47 branch July 23, 2026 03:25
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport Backporting a PR onto a release candidate size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants