Repository navigation
[backport cloud/1.47] fix(vue-nodes): reflow node when custom nodes grow size at runtime (size Proxy) - #14017
Conversation
…ize Proxy) (#13867) Fixes #13863 ## Problem Custom nodes grow a node at runtime by writing `node.size[1]` directly (an element mutation) and calling `setDirtyCanvas(...)`, instead of going through `node.setSize()` / the `set size` setter. On Vue Nodes the node keeps its old height until the user manually resizes it. Root cause: a Vue node's geometry is owned by `layoutStore`. The only litegraph path that mirrored height into `layoutStore` was the `set size` **setter**. A direct `node.size[1] = ...` element mutation bypassed the setter, and `setDirtyCanvas` is a no-op for Vue nodes, so the store never learned the new height. This is a copy-pasted idiom, not one pack's quirk — two variants hit the seam: 1. **Widget-count growth** — `addCustomWidget(...)` then `node.size[1] = ...`: rgthree Power Lora Loader, yolain ComfyUI-Easy-Use, comfyui-0246, ComfyUI-N-Nodes, comfyui-mixlab-nodes, comfyui-advanced-latent-control. 2. **Image-preview growth with NO widget change** — on `img.onload`, `node.imgs = [...]; node.size[1] = Math.max(200, ...)`: ltdrdata ComfyUI-Impact-Pack, ComfyUI-N-Nodes. ## Fix Intercept the size mutation directly. `get size` returns a cached `Proxy` over the node's backing `_size` array whose `set` trap commits the new size to `layoutStore` through a shared `_sizeUpdated()` — the same path the `set size` setter now uses. So both `node.size = [w, h]` and the element-mutation idioms `node.size[0] = w` / `node.size[1] = h` reflow the Vue node, with no polling and no per-pack fix. The Proxy is created once per node and reused. Index writes pass straight through to the backing `Float64Array`; function and `length` access is forwarded to the real typed array, so spread, iteration and `.length` keep working, and serialization is unaffected (it reads `size[0]`/`size[1]` into a plain array). Loop safety (no exploding node): `_sizeUpdated()` commits only when the size actually changed (`isSizeEqual` guard), tagged `LayoutSource.Canvas`. The layout → litegraph write-back in `useLayoutSync` applies the value through the setter, so when it re-applies the size the node already holds, the guard makes it a no-op — no feedback loop through `handleLayoutChange`. This replaces the earlier `useRuntimeWidgetReflow` reconcile-on-animation-frame shim; the mutation itself now commits, so the poll is gone. `// TODO(litegraph-stable-resize-api)`: remove the Proxy once litegraph exposes a public resize/commit API that custom nodes call instead of mutating `node.size[1]` directly. ## Tests - `nodeSizeReflow.test.ts` (unit): a single `size[1]=` element mutation commits exactly one `resizeNode` to `layoutStore`; the setter commits once; an equal write-back does not re-commit (loop-safe); typed-array semantics (spread, `Array.from`, `.length`) survive the Proxy; no commit before the node joins a graph. - DevTools `Node Runtime Reflow` node emulates both idioms on the client (`growByWidget()` and `growByPreview()`). - `runtimeWidgetReflow.spec.ts` (e2e, `@vue-nodes`): the rendered node height grows for BOTH triggers with no manual resize. ## Direction / migration This Proxy is not a dead-end shim — it is the **deprecation on-ramp for a stable resize API that does not exist yet**. Its `set` trap already commits the legacy `node.size[1] =` idiom through `resizeNode`, the **same** layout-store primitive the sanctioned future API will call. Target end-state (see `research/architecture/toward-new-api-plan.md` §2, follow-ups A2/A3/A4): - A public **`Comfy.Node.Resize` command** + **`NodeHandle.setSize()` / `autosize()` / `on('resize')`** (v2 extension handles) that custom nodes call instead of mutating `node.size[1]`. - Both terminate in the one authoritative `resizeNode(nodeId, size, source)` primitive — no second write path. Once that API lands, this trap should emit a **one-time `warnDeprecated`** naming the sanctioned call — turning direct element writes into a migrate-me signal rather than a silent shim (the array-element equivalent of `defineDeprecatedProperty`). That runtime warn is a **deliberate later fast-follow (A4)**, intentionally not in this PR. Ecosystem gap rows: `S2.N19` / `S10.D3` / `S11.G4`. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🎭 Playwright: ✅ 1701 passed, 0 failed · 4 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-23T03:15:10.205Z",
"gitSha": "e0a7ba76bba222dff03d36473efd38597149ba36",
"branch": "backport-13867-to-cloud-1.47",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2082.3749999999563,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.742999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.652,
"heapDeltaBytes": -7244012,
"heapUsedBytes": 45580080,
"domNodes": -285,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 14.921,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2040.4100000000653,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.364999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.499,
"heapDeltaBytes": -7188420,
"heapUsedBytes": 63664260,
"domNodes": -267,
"jsHeapTotalBytes": 19681280,
"scriptDurationMs": 20.779000000000003,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.0380000001069,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.795,
"layouts": 12,
"layoutDurationMs": 3.7479999999999998,
"taskDurationMs": 670.522,
"heapDeltaBytes": -13129084,
"heapUsedBytes": 57768404,
"domNodes": -237,
"jsHeapTotalBytes": 18632704,
"scriptDurationMs": 94.314,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1710.6430000000046,
"styleRecalcs": 71,
"styleRecalcDurationMs": 32.277,
"layouts": 12,
"layoutDurationMs": 3.3390000000000004,
"taskDurationMs": 651.189,
"heapDeltaBytes": 22359292,
"heapUsedBytes": 74538204,
"domNodes": 53,
"jsHeapTotalBytes": 19398656,
"scriptDurationMs": 104.769,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.2249999999467,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.311000000000002,
"layouts": 6,
"layoutDurationMs": 0.6110000000000001,
"taskDurationMs": 247.32500000000002,
"heapDeltaBytes": 7265164,
"heapUsedBytes": 71717152,
"domNodes": 78,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 15.8,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.642999999991,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.8,
"layouts": 6,
"layoutDurationMs": 0.539,
"taskDurationMs": 281.921,
"heapDeltaBytes": 2303296,
"heapUsedBytes": 61668052,
"domNodes": 78,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 20.938,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 457.10399999995843,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.936000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 316.375,
"heapDeltaBytes": -24444116,
"heapUsedBytes": 46536908,
"domNodes": -267,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 44.056,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 579.7869999998966,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.057,
"heapDeltaBytes": -23289732,
"heapUsedBytes": 48133596,
"domNodes": -274,
"jsHeapTotalBytes": 4739072,
"scriptDurationMs": 47.322,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.449000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.456999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.57300000000004,
"heapDeltaBytes": -6056544,
"heapUsedBytes": 61457332,
"domNodes": -268,
"jsHeapTotalBytes": -1974272,
"scriptDurationMs": 72.948,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2027.66500000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.764000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.8140000000001,
"heapDeltaBytes": -6300868,
"heapUsedBytes": 67565876,
"domNodes": 20,
"jsHeapTotalBytes": 8794112,
"scriptDurationMs": 114.98899999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2091.3590000000113,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.733999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.3820000000001,
"heapDeltaBytes": -9234704,
"heapUsedBytes": 61793744,
"domNodes": -258,
"jsHeapTotalBytes": -1245184,
"scriptDurationMs": 320.66299999999995,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2043.7819999999647,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.892999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 922.11,
"heapDeltaBytes": 6484252,
"heapUsedBytes": 61600748,
"domNodes": 12,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 342.386,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3045.693999999912,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.305999999999997,
"layouts": 60,
"layoutDurationMs": 6.6610000000000005,
"taskDurationMs": 1026.751,
"heapDeltaBytes": 17375660,
"heapUsedBytes": 72499360,
"domNodes": 12,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 412.711,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3038.9189999999644,
"styleRecalcs": 64,
"styleRecalcDurationMs": 17.14,
"layouts": 60,
"layoutDurationMs": 7.721,
"taskDurationMs": 1152.647,
"heapDeltaBytes": 17377816,
"heapUsedBytes": 72154900,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 453.888,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2003.957000000014,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.199999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.581,
"heapDeltaBytes": 13213524,
"heapUsedBytes": 69367876,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 75.561,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1988.2089999999835,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.735999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.68100000000004,
"heapDeltaBytes": 12744168,
"heapUsedBytes": 69536812,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 96.96199999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 477.06700000003366,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.940000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.145,
"heapDeltaBytes": 12423976,
"heapUsedBytes": 77323056,
"domNodes": 22,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 93.66199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 540.4579999999441,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.584999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.44,
"heapDeltaBytes": -2490500,
"heapUsedBytes": 51149700,
"domNodes": -264,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 98.44,
"eventListeners": -193,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.4629999999634,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.51,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.094,
"heapDeltaBytes": -7494364,
"heapUsedBytes": 63471008,
"domNodes": -264,
"jsHeapTotalBytes": 19943424,
"scriptDurationMs": 12.04,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.8789999999935,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.596,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.192,
"heapDeltaBytes": -1259388,
"heapUsedBytes": 58213340,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 17.842999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.1419999999334,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.587999999999994,
"layouts": 16,
"layoutDurationMs": 3.6450000000000005,
"taskDurationMs": 568.0489999999999,
"heapDeltaBytes": -16249796,
"heapUsedBytes": 54671340,
"domNodes": -194,
"jsHeapTotalBytes": 19156992,
"scriptDurationMs": 73.87599999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.9769999999244,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.247,
"layouts": 16,
"layoutDurationMs": 4.178,
"taskDurationMs": 656.6139999999999,
"heapDeltaBytes": -16895556,
"heapUsedBytes": 54018168,
"domNodes": -226,
"jsHeapTotalBytes": 18108416,
"scriptDurationMs": 84.64099999999999,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 916.3040000000819,
"styleRecalcs": 20,
"styleRecalcDurationMs": 26.587999999999994,
"layouts": 16,
"layoutDurationMs": 11.926999999999998,
"taskDurationMs": 653.4629999999999,
"heapDeltaBytes": 29633572,
"heapUsedBytes": 102222628,
"domNodes": 13673,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 25.535999999999998,
"eventListeners": 2531,
"totalBlockingTimeMs": 112,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8116.960999999947,
"styleRecalcs": 249,
"styleRecalcDurationMs": 50.92,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2973.382,
"heapDeltaBytes": 23947492,
"heapUsedBytes": 87340656,
"domNodes": -274,
"jsHeapTotalBytes": 819200,
"scriptDurationMs": 1068.6140000000003,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8110.492000000022,
"styleRecalcs": 251,
"styleRecalcDurationMs": 55.622,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3467.212,
"heapDeltaBytes": 22751592,
"heapUsedBytes": 90195636,
"domNodes": -257,
"jsHeapTotalBytes": 1376256,
"scriptDurationMs": 1207.5130000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10685.386999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10674.660000000002,
"heapDeltaBytes": -49756020,
"heapUsedBytes": 163501680,
"domNodes": -3300,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 418.597,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11564.104000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11554.885,
"heapDeltaBytes": -16803920,
"heapUsedBytes": 192519756,
"domNodes": -3300,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 529.089,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13469.719000000056,
"styleRecalcs": 65,
"styleRecalcDurationMs": 18.337999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13451.908,
"heapDeltaBytes": -26478208,
"heapUsedBytes": 180168852,
"domNodes": -3300,
"jsHeapTotalBytes": 5943296,
"scriptDurationMs": 676.736,
"eventListeners": -16366,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14237.462999999934,
"styleRecalcs": 67,
"styleRecalcDurationMs": 18.904000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14218.449,
"heapDeltaBytes": -37553488,
"heapUsedBytes": 177202064,
"domNodes": -3302,
"jsHeapTotalBytes": 16924672,
"scriptDurationMs": 672.1109999999999,
"eventListeners": -16372,
"totalBlockingTimeMs": 1,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 470.56399999996756,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.868000000000002,
"layouts": 3,
"layoutDurationMs": 2.21,
"taskDurationMs": 132.649,
"heapDeltaBytes": -3203560,
"heapUsedBytes": 50252168,
"domNodes": -143,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 8.873000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 467.850999999996,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.369000000000003,
"layouts": 2,
"layoutDurationMs": 0.32800000000000007,
"taskDurationMs": 170.881,
"heapDeltaBytes": -23351884,
"heapUsedBytes": 47528052,
"domNodes": -187,
"jsHeapTotalBytes": 5263360,
"scriptDurationMs": 9.189000000000002,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.47 #14017 +/- ##
=============================================
Coverage ? 66.93%
=============================================
Files ? 1582
Lines ? 81826
Branches ? 23275
=============================================
Hits ? 54772
Misses ? 26709
Partials ? 345
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #13867 to
cloud/1.47Automatically created by backport workflow.