Repository navigation
[backport core/1.47] fix(vue-nodes): reflow node when custom nodes grow size at runtime (size Proxy) - #14016
Conversation
…ize Proxy) (#13867) Fixes #13863 ## Problem Custom nodes grow a node at runtime by writing `node.size[1]` directly (an element mutation) and calling `setDirtyCanvas(...)`, instead of going through `node.setSize()` / the `set size` setter. On Vue Nodes the node keeps its old height until the user manually resizes it. Root cause: a Vue node's geometry is owned by `layoutStore`. The only litegraph path that mirrored height into `layoutStore` was the `set size` **setter**. A direct `node.size[1] = ...` element mutation bypassed the setter, and `setDirtyCanvas` is a no-op for Vue nodes, so the store never learned the new height. This is a copy-pasted idiom, not one pack's quirk — two variants hit the seam: 1. **Widget-count growth** — `addCustomWidget(...)` then `node.size[1] = ...`: rgthree Power Lora Loader, yolain ComfyUI-Easy-Use, comfyui-0246, ComfyUI-N-Nodes, comfyui-mixlab-nodes, comfyui-advanced-latent-control. 2. **Image-preview growth with NO widget change** — on `img.onload`, `node.imgs = [...]; node.size[1] = Math.max(200, ...)`: ltdrdata ComfyUI-Impact-Pack, ComfyUI-N-Nodes. ## Fix Intercept the size mutation directly. `get size` returns a cached `Proxy` over the node's backing `_size` array whose `set` trap commits the new size to `layoutStore` through a shared `_sizeUpdated()` — the same path the `set size` setter now uses. So both `node.size = [w, h]` and the element-mutation idioms `node.size[0] = w` / `node.size[1] = h` reflow the Vue node, with no polling and no per-pack fix. The Proxy is created once per node and reused. Index writes pass straight through to the backing `Float64Array`; function and `length` access is forwarded to the real typed array, so spread, iteration and `.length` keep working, and serialization is unaffected (it reads `size[0]`/`size[1]` into a plain array). Loop safety (no exploding node): `_sizeUpdated()` commits only when the size actually changed (`isSizeEqual` guard), tagged `LayoutSource.Canvas`. The layout → litegraph write-back in `useLayoutSync` applies the value through the setter, so when it re-applies the size the node already holds, the guard makes it a no-op — no feedback loop through `handleLayoutChange`. This replaces the earlier `useRuntimeWidgetReflow` reconcile-on-animation-frame shim; the mutation itself now commits, so the poll is gone. `// TODO(litegraph-stable-resize-api)`: remove the Proxy once litegraph exposes a public resize/commit API that custom nodes call instead of mutating `node.size[1]` directly. ## Tests - `nodeSizeReflow.test.ts` (unit): a single `size[1]=` element mutation commits exactly one `resizeNode` to `layoutStore`; the setter commits once; an equal write-back does not re-commit (loop-safe); typed-array semantics (spread, `Array.from`, `.length`) survive the Proxy; no commit before the node joins a graph. - DevTools `Node Runtime Reflow` node emulates both idioms on the client (`growByWidget()` and `growByPreview()`). - `runtimeWidgetReflow.spec.ts` (e2e, `@vue-nodes`): the rendered node height grows for BOTH triggers with no manual resize. ## Direction / migration This Proxy is not a dead-end shim — it is the **deprecation on-ramp for a stable resize API that does not exist yet**. Its `set` trap already commits the legacy `node.size[1] =` idiom through `resizeNode`, the **same** layout-store primitive the sanctioned future API will call. Target end-state (see `research/architecture/toward-new-api-plan.md` §2, follow-ups A2/A3/A4): - A public **`Comfy.Node.Resize` command** + **`NodeHandle.setSize()` / `autosize()` / `on('resize')`** (v2 extension handles) that custom nodes call instead of mutating `node.size[1]`. - Both terminate in the one authoritative `resizeNode(nodeId, size, source)` primitive — no second write path. Once that API lands, this trap should emit a **one-time `warnDeprecated`** naming the sanctioned call — turning direct element writes into a migrate-me signal rather than a silent shim (the array-element equivalent of `defineDeprecatedProperty`). That runtime warn is a **deliberate later fast-follow (A4)**, intentionally not in this PR. Ecosystem gap rows: `S2.N19` / `S10.D3` / `S11.G4`. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🎭 Playwright: ✅ 1705 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
✅ No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-23T03:15:19.381Z",
"gitSha": "3c7446b62913f485ffddc1d7f9c54a1e2be8f807",
"branch": "backport-13867-to-core-1.47",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.3440000000128,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.402000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.61300000000006,
"heapDeltaBytes": -1437748,
"heapUsedBytes": 57520772,
"domNodes": 18,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 14.126,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2056.1820000000353,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.972000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.47299999999996,
"heapDeltaBytes": -7577300,
"heapUsedBytes": 62831064,
"domNodes": -279,
"jsHeapTotalBytes": 18501632,
"scriptDurationMs": 15.008999999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1971.8990000000076,
"styleRecalcs": 78,
"styleRecalcDurationMs": 42.901,
"layouts": 12,
"layoutDurationMs": 4.446999999999999,
"taskDurationMs": 909.298,
"heapDeltaBytes": -13392456,
"heapUsedBytes": 57056200,
"domNodes": -239,
"jsHeapTotalBytes": 19288064,
"scriptDurationMs": 133.6,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.7149999999829,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.88700000000001,
"layouts": 12,
"layoutDurationMs": 3.4890000000000003,
"taskDurationMs": 786.198,
"heapDeltaBytes": 761680,
"heapUsedBytes": 52907488,
"domNodes": -257,
"jsHeapTotalBytes": 16904192,
"scriptDurationMs": 124.093,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.510999999989,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.402,
"layouts": 6,
"layoutDurationMs": 0.5120000000000001,
"taskDurationMs": 326.41700000000003,
"heapDeltaBytes": 4527968,
"heapUsedBytes": 57305584,
"domNodes": -241,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 18.057,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.1920000000018,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.616,
"layouts": 6,
"layoutDurationMs": 0.657,
"taskDurationMs": 280.652,
"heapDeltaBytes": 2251756,
"heapUsedBytes": 61194488,
"domNodes": 78,
"jsHeapTotalBytes": 23855104,
"scriptDurationMs": 16.604,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 569.1749999999729,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.061,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.82,
"heapDeltaBytes": 7634964,
"heapUsedBytes": 59825928,
"domNodes": -290,
"jsHeapTotalBytes": 10350592,
"scriptDurationMs": 56.77600000000001,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 595.0970000000098,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.11,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.274,
"heapDeltaBytes": 9013160,
"heapUsedBytes": 61129248,
"domNodes": -291,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 58.843,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2020.3300000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.326000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.42800000000005,
"heapDeltaBytes": -6477540,
"heapUsedBytes": 66439536,
"domNodes": 20,
"jsHeapTotalBytes": 10366976,
"scriptDurationMs": 101.03000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2044.477000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.432000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.447,
"heapDeltaBytes": -7129536,
"heapUsedBytes": 59984320,
"domNodes": -271,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 99.265,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2099.423999999999,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.506999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1044.373,
"heapDeltaBytes": -9677652,
"heapUsedBytes": 61213064,
"domNodes": -273,
"jsHeapTotalBytes": -1114112,
"scriptDurationMs": 409.6,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2085.9689999999773,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.540000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1092.368,
"heapDeltaBytes": 13463452,
"heapUsedBytes": 82155740,
"domNodes": 20,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 434.581,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3074.1459999999847,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.333000000000002,
"layouts": 60,
"layoutDurationMs": 6.751999999999999,
"taskDurationMs": 1253.6019999999999,
"heapDeltaBytes": 17418712,
"heapUsedBytes": 70584424,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 508.22,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3093.514999999911,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.906000000000004,
"layouts": 60,
"layoutDurationMs": 7.104,
"taskDurationMs": 1336.87,
"heapDeltaBytes": 20887196,
"heapUsedBytes": 74904508,
"domNodes": -276,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 567.3050000000001,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2023.4200000000442,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.227999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.806,
"heapDeltaBytes": -3921232,
"heapUsedBytes": 61236232,
"domNodes": -272,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 100.37499999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2062.5210000000607,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.434999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.247,
"heapDeltaBytes": -6363380,
"heapUsedBytes": 63193356,
"domNodes": -270,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 100.143,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.8510000000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.578000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.756,
"heapDeltaBytes": -22806316,
"heapUsedBytes": 47712116,
"domNodes": -278,
"jsHeapTotalBytes": 4870144,
"scriptDurationMs": 114.11699999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.8099999999531,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.10599999999994,
"heapDeltaBytes": -21989964,
"heapUsedBytes": 48407664,
"domNodes": -272,
"jsHeapTotalBytes": 5656576,
"scriptDurationMs": 115.089,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2044.3109999999933,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.328,
"heapDeltaBytes": -3109760,
"heapUsedBytes": 49296684,
"domNodes": -291,
"jsHeapTotalBytes": 18214912,
"scriptDurationMs": 12.121,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2027.0490000000336,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.850999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.901,
"heapDeltaBytes": -7522620,
"heapUsedBytes": 62909840,
"domNodes": -275,
"jsHeapTotalBytes": 18501632,
"scriptDurationMs": 13.304,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.3489999999983,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.262,
"layouts": 16,
"layoutDurationMs": 3.853,
"taskDurationMs": 682.92,
"heapDeltaBytes": -16846312,
"heapUsedBytes": 53542528,
"domNodes": -235,
"jsHeapTotalBytes": 20336640,
"scriptDurationMs": 87.423,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.3710000000483,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.152,
"layouts": 16,
"layoutDurationMs": 4.451999999999999,
"taskDurationMs": 688.385,
"heapDeltaBytes": 19027972,
"heapUsedBytes": 71286828,
"domNodes": -249,
"jsHeapTotalBytes": 17166336,
"scriptDurationMs": 86.64099999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.3890000000451,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.150000000000006,
"layouts": 14,
"layoutDurationMs": 15.444000000000003,
"taskDurationMs": 758.103,
"heapDeltaBytes": 27557320,
"heapUsedBytes": 95726020,
"domNodes": 13673,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 29.495999999999995,
"eventListeners": 2533,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8154.356000000007,
"styleRecalcs": 251,
"styleRecalcDurationMs": 51.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3655.733,
"heapDeltaBytes": 15801044,
"heapUsedBytes": 85369792,
"domNodes": -271,
"jsHeapTotalBytes": 720896,
"scriptDurationMs": 1370.16,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8119.728000000009,
"styleRecalcs": 250,
"styleRecalcDurationMs": 53.142,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3763.3179999999998,
"heapDeltaBytes": -10607584,
"heapUsedBytes": 62997004,
"domNodes": 18,
"jsHeapTotalBytes": 17444864,
"scriptDurationMs": 1387.046,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11004.844999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10990.023000000001,
"heapDeltaBytes": -22242992,
"heapUsedBytes": 170598052,
"domNodes": -3300,
"jsHeapTotalBytes": 12554240,
"scriptDurationMs": 479.35400000000004,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11614.84299999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11599.253999999999,
"heapDeltaBytes": -24931420,
"heapUsedBytes": 167968980,
"domNodes": -3300,
"jsHeapTotalBytes": 3641344,
"scriptDurationMs": 500.785,
"eventListeners": -16380,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15006.85199999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 16.02199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14983.417,
"heapDeltaBytes": -20729016,
"heapUsedBytes": 178892200,
"domNodes": -3302,
"jsHeapTotalBytes": 16400384,
"scriptDurationMs": 749.506,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14835.336999999981,
"styleRecalcs": 67,
"styleRecalcDurationMs": 18.747000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14813.280999999999,
"heapDeltaBytes": -44212624,
"heapUsedBytes": 161334880,
"domNodes": -3300,
"jsHeapTotalBytes": 12292096,
"scriptDurationMs": 819.369,
"eventListeners": -16374,
"totalBlockingTimeMs": 65,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 444.8600000000056,
"styleRecalcs": 14,
"styleRecalcDurationMs": 18.825000000000003,
"layouts": 2,
"layoutDurationMs": 0.42199999999999993,
"taskDurationMs": 97.20700000000002,
"heapDeltaBytes": 4898856,
"heapUsedBytes": 69468436,
"domNodes": 132,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.882,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 443.5519999999542,
"styleRecalcs": 14,
"styleRecalcDurationMs": 21.984999999999996,
"layouts": 4,
"layoutDurationMs": 1.28,
"taskDurationMs": 103.176,
"heapDeltaBytes": 4686016,
"heapUsedBytes": 62142076,
"domNodes": 119,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 9.426,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.47 #14016 +/- ##
=============================================
- Coverage 78.18% 78.18% -0.01%
=============================================
Files 1658 1658
Lines 92814 92811 -3
Branches 32812 32141 -671
=============================================
- Hits 72567 72564 -3
Misses 19638 19638
Partials 609 609
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #13867 to
core/1.47Automatically created by backport workflow.