Repository navigation
feat: apply charcoal palette and rework theme surfaces across the editor - #13842
mariana953 wants to merge 41 commits into
Conversation
Extend the charcoal scale with two darker steps (charcoal-900 #111111, charcoal-950 #09090a) for deeper dark-theme surfaces.
Add semantic tokens for the tab treatment and region strokes, defined per theme (:root derives from each palette's comfy_base vars; .dark-theme uses the tuned charcoal values): - --workflow-tab-divider / -selected-surface / -hover-surface - --region-stroke, --sidebar-surface, --base-background-sunken Restyle the workflow tabs to use them: filled selected tab (not an underline), hover state, right-edge dividers only, close button shown on hover only, and no stray border on the first tab. Unsaved-dot loses its mismatched background.
Drop the borders and shadows on the manage-extensions pill, run actionbar, sidebar and topbar so they read as flat surfaces divided by strokes; match their height and padding to the workflow tabs; make the Share button icon-only; and tighten the bottom canvas toolbar padding. Sidebar right and topbar bottom borders use the theme-aware --region-stroke token; the connected sidebar uses --sidebar-surface.
Give every built-in palette the same subtle dot-grid canvas background: a white dot for the dark palettes (dark/arc/nord/github) and a black dot for light, at low opacity, so the canvas texture is aligned across themes while adapting to each background. The dark palette's canvas also moves to charcoal-950 (#09090A).
The .dark-theme class is applied to every dark palette (solarized, arc, nord, github), so hardcoding charcoal there leaked the default dark colors into all of them. Tag the root with data-color-palette and move the tuned charcoal (sidebar/selected/hover surfaces, sunken) under :root[data-color-palette='dark'] only; other palettes fall back to deriving from their own comfy_base vars (--bg-color/--content-hover-bg), so the sidebar and selected tab share the canvas base level per theme.
Scope the light palette (data-color-palette='light') to the DS light values instead of derived guesses: sidebar and selected tab = smoke-200 (base/background), tab hover = smoke-400 (workflow tab background-hovered), divider = smoke-400, region stroke = smoke-300.
- Remove the now-unused actionbar.share i18n key (Share button is icon-only; the tooltip key stays) - Consume charcoal-950 via the --base-background-sunken token: the app body backdrop uses it in the default dark palette, matching the sunken canvas (no more dead token) - Add a behavioral test that the active tab still closes (its close button is now hover-revealed instead of shown while selected)
The DS light sidebar value (smoke-200) read too grey in-app; nudge the sidebar surface one step lighter to near-white while keeping the selected tab at smoke-200 so it stays distinct from the white tab bar.
Replace the dot-grid BACKGROUND_IMAGE with a thin line grid (white on dark palettes, black on light) while keeping the current canvas colors (charcoal-950 on dark).
Reduce --workflow-tabs-height from 38px to 34px so the workflow tab bar and the topbar action pills hug their 32px controls (Run button, icon buttons) instead of leaving ~3px of vertical slack. Tabs and the run block now read at the same visual height.
Raise the line-grid stroke-opacity baked into each palette's BACKGROUND_IMAGE (dark/arc/nord/github 0.07 -> 0.10, light 0.08 -> 0.12). Only lifts the base pattern opacity; litegraph's zoom_modify_alpha ramp is untouched, so the grid stays subtle at default zoom and gets more visible as you zoom in.
Halve the rendered opacity of the sidebar/topbar region strokes and the workflow tab dividers: the derived tokens drop from 50% to 25% of each palette's --border-color, and the light palette's smoke values gain a 50% mix. Each theme keeps its own colour logic, only the weight changes.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
Walkthrough
🚥 Pre-merge checks | ✅ 4 | ❌ 2
Finishing Touches
Warning Review ran into problems🔥 Problems
|
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/components/topbar/WorkflowTab.vue (1)
41-50: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick winUse an explicit CSS token instead of a foreground alias utility.
Based on learnings, avoid using Tailwind foreground alias utility classes like
hover:text-base-foregroundas they are intentionally descoped/unknown in App Mode. Instead, use the arbitrary-value CSS token syntax.💚 Proposed fix
<Button - class="close-button invisible w-auto p-0 hover:bg-transparent hover:text-base-foreground" + class="close-button invisible w-auto p-0 hover:bg-transparent hover:text-(--base-foreground)" variant="muted-textonly"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/topbar/WorkflowTab.vue` around lines 41 - 50, Replace the hover:text-base-foreground utility on the close-workflow Button in WorkflowTab with the arbitrary-value CSS token syntax using the explicit foreground token. Preserve the existing hover background behavior and all other button classes and behavior.Source: Learnings
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/topbar/WorkflowTab.test.ts`:
- Around line 238-240: Replace the data-testid lookup in the WorkflowTab test
with an accessible query targeting the close button by its role and accessible
name, while preserving the existing user.click interaction.
In `@src/components/TopMenuSection.vue`:
- Around line 209-223: Update the `actionbarContainerClass` base class to use
Tailwind v4’s parenthesized CSS-variable syntax for `workflow-tabs-height`,
matching the existing convention elsewhere in `TopMenuSection.vue`; leave the
surrounding classes and conditional logic unchanged.
---
Outside diff comments:
In `@src/components/topbar/WorkflowTab.vue`:
- Around line 41-50: Replace the hover:text-base-foreground utility on the
close-workflow Button in WorkflowTab with the arbitrary-value CSS token syntax
using the explicit foreground token. Preserve the existing hover background
behavior and all other button classes and behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 6ba09d39-593c-4584-9996-dbdbff4ad240
📒 Files selected for processing (16)
packages/design-system/src/css/_palette.csspackages/design-system/src/css/style.csssrc/assets/palettes/arc.jsonsrc/assets/palettes/dark.jsonsrc/assets/palettes/github.jsonsrc/assets/palettes/light.jsonsrc/assets/palettes/nord.jsonsrc/components/TopMenuSection.vuesrc/components/graph/GraphCanvas.vuesrc/components/graph/GraphCanvasMenu.vuesrc/components/sidebar/SideToolbar.vuesrc/components/topbar/WorkflowTab.test.tssrc/components/topbar/WorkflowTab.vuesrc/components/topbar/WorkflowTabs.vuesrc/locales/en/main.jsonsrc/views/GraphView.vue
💤 Files with no reviewable changes (1)
- src/locales/en/main.json
Revert the padding tweaks on the top menu section: root pt-2 back to pt-1, and the extensions pill and actionbar container back to px-2. The bar keeps its aligned height, borderless chrome and icon-only share button; only the spacing returns to what main had.
litegraph only repaints its clear colour below 1.5x zoom; above that the canvas is left transparent and the body shows through. The backdrop was reading --base-background-sunken, which only the default dark palette defines, so light and the custom palettes fell back to transparent and rendered black once zoomed in. Fall back to each palette's own --bg-color so every theme keeps its canvas colour at any zoom level.
The run actionbar and the extensions pill were pinned to a fixed --workflow-tabs-height with no vertical padding, so their 32px controls sat flush against the pill edges. Drop the fixed height and give both py-1, matching the graph mode pill which wraps its own 32px button in p-1. All three now render as 40px pills with 4px of breathing room.
The subgraph breadcrumb wraps the graph mode pill in -mt-3 + pt-4, a net 4px offset that left the actions column sitting 4px higher than it. Pad the actions column by the same amount so the graph pill, the extensions pill and the run actionbar share one baseline: all three now render at the same top, bottom and height.
Arc's canvas was lighter than its own menu surface, inverting the depth the dark palette establishes and leaving nodes flat against the background. Drop it to the same lightness offset dark uses between menu and canvas, measured in OKLCH so arc keeps its own hue and chroma. bg-color moves with it: litegraph stops repainting its clear colour above 1.5x zoom and the body backdrop falls back to --bg-color, so the two have to agree or the background jumps when zoomed in.
Dark stacks three levels: canvas (charcoal-950) below sidebar and selected tab (charcoal-900) below the menu and tab bar (charcoal-800). Custom palettes only aliased the sidebar to --bg-color, which is their canvas colour, so the sidebar dissolved into the canvas and the depth disappeared. Express each level as a lightness offset from the palette's own menu colour and replay it in OKLCH, which keeps the offsets perceptually even while preserving each palette's hue and chroma. --base-background-sunken is derived the same way, so the body backdrop tracks the canvas in every theme rather than falling back to --bg-color. Canvas colours in arc/nord/github are retuned to that offset, and solarized gains the CLEAR_BACKGROUND_COLOR it never had (it was inheriting whatever the previous palette left on the canvas). arc's bg-color returns to its original value, no longer needing to track the canvas for the backdrop.
🎨 Storybook: 🚧 Building...🎭 Playwright: ❌ 2000 passed, 1 failed❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.33 MB gzip 🟢 -3.9 kBDetailsSummary
Category Glance App Entry Points — 3.71 kB (baseline 3.71 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.38 MB (baseline 1.38 MB) • 🟢 -198 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 591 kB (baseline 591 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 112 kB (baseline 112 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.46 MB (baseline 3.46 MB) • 🟢 -5.79 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 551 kB (baseline 551 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 15.1 MB (baseline 15.1 MB) • 🟢 -19 BBundles that do not match a named category
Status: 78 added / 78 removed / 212 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-25T16:39:12.354Z",
"gitSha": "b0c4b3df70910569a24cd8033d1edd09fed1c919",
"branch": "feat/topbar-theme-refresh",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2155.680000000018,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.881999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 667.326,
"heapDeltaBytes": -13627076,
"heapUsedBytes": 56115096,
"domNodes": -285,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.930000000000001,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2055.900000000065,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.14599999999996,
"heapDeltaBytes": -11971056,
"heapUsedBytes": 57770204,
"domNodes": -286,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.213000000000001,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2233.573999999976,
"styleRecalcs": 81,
"styleRecalcDurationMs": 40.457,
"layouts": 14,
"layoutDurationMs": 4.348,
"taskDurationMs": 1209.315,
"heapDeltaBytes": 4775108,
"heapUsedBytes": 74564112,
"domNodes": -287,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 150.594,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2157.5109999999995,
"styleRecalcs": 82,
"styleRecalcDurationMs": 41.676,
"layouts": 14,
"layoutDurationMs": 4.363,
"taskDurationMs": 1186.194,
"heapDeltaBytes": 1833416,
"heapUsedBytes": 72601512,
"domNodes": -283,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 144.964,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1767.2319999999786,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.737000000000002,
"layouts": 6,
"layoutDurationMs": 0.6499999999999999,
"taskDurationMs": 355.96399999999994,
"heapDeltaBytes": 4132548,
"heapUsedBytes": 73828832,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.534,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.669000000049,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.151,
"layouts": 6,
"layoutDurationMs": 0.816,
"taskDurationMs": 355.03499999999997,
"heapDeltaBytes": 4100108,
"heapUsedBytes": 73911708,
"domNodes": 79,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 11.025,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 724.2859999999496,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.838999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.999,
"heapDeltaBytes": -6358000,
"heapUsedBytes": 63482244,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 30.838,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 716.6630000000396,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.851000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.995,
"heapDeltaBytes": -6407332,
"heapUsedBytes": 63441028,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 32.264,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2048.73699999996,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.64,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.282,
"heapDeltaBytes": -18639244,
"heapUsedBytes": 72390964,
"domNodes": -273,
"jsHeapTotalBytes": -1581056,
"scriptDurationMs": 38.257000000000005,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2073.789999999917,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.065,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 573.702,
"heapDeltaBytes": -18280148,
"heapUsedBytes": 73032248,
"domNodes": -271,
"jsHeapTotalBytes": -2105344,
"scriptDurationMs": 40.336,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3254.3149999999628,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.780000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2576.742,
"heapDeltaBytes": -7335004,
"heapUsedBytes": 84452660,
"domNodes": -276,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 918.6469999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3246.703000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.201,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2544.029,
"heapDeltaBytes": -7690440,
"heapUsedBytes": 84099156,
"domNodes": -275,
"jsHeapTotalBytes": -307200,
"scriptDurationMs": 908.671,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4307.394999999986,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.073,
"layouts": 60,
"layoutDurationMs": 8.148,
"taskDurationMs": 2564.002,
"heapDeltaBytes": 650764,
"heapUsedBytes": 72979804,
"domNodes": -262,
"jsHeapTotalBytes": -2142208,
"scriptDurationMs": 867.452,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 4385.102999999958,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.218,
"layouts": 60,
"layoutDurationMs": 8.322999999999999,
"taskDurationMs": 2576.1779999999994,
"heapDeltaBytes": 9158616,
"heapUsedBytes": 75364908,
"domNodes": -258,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 906.513,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3173.5539999999673,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.911999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2054.3259999999996,
"heapDeltaBytes": 16698984,
"heapUsedBytes": 84338124,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 205.745,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3177.854000000025,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.9369999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2098.045,
"heapDeltaBytes": 16607280,
"heapUsedBytes": 84238772,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 214.765,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2042.158000000029,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.403999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.994,
"heapDeltaBytes": -21519444,
"heapUsedBytes": 73312168,
"domNodes": -271,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 37.345,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2062.6609999999346,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.595,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.352,
"heapDeltaBytes": -22131736,
"heapUsedBytes": 70719412,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 38.462999999999994,
"eventListeners": -156,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 729.1180000000281,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.571,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.22,
"heapDeltaBytes": -7912468,
"heapUsedBytes": 62541104,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 135.911,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 729.5520000000124,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.264,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.536,
"heapDeltaBytes": 17857512,
"heapUsedBytes": 87647860,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 135.184,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.5669999999614,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.331,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.27299999999997,
"heapDeltaBytes": -5007284,
"heapUsedBytes": 65674972,
"domNodes": -301,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.414999999999998,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.1430000000046,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.364999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.35300000000007,
"heapDeltaBytes": 10237192,
"heapUsedBytes": 81314600,
"domNodes": -300,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.464999999999998,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1858.9269999999942,
"styleRecalcs": 80,
"styleRecalcDurationMs": 37.107,
"layouts": 18,
"layoutDurationMs": 4.656000000000001,
"taskDurationMs": 1096.346,
"heapDeltaBytes": -8893608,
"heapUsedBytes": 61699440,
"domNodes": -300,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 107.778,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1855.4520000000139,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.132,
"layouts": 18,
"layoutDurationMs": 4.868000000000001,
"taskDurationMs": 1084.6680000000001,
"heapDeltaBytes": -4789136,
"heapUsedBytes": 65719680,
"domNodes": -300,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 109.86,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.7979999999934,
"styleRecalcs": 19,
"styleRecalcDurationMs": 30.689999999999994,
"layouts": 14,
"layoutDurationMs": 13.255000000000003,
"taskDurationMs": 911.0600000000002,
"heapDeltaBytes": -11311312,
"heapUsedBytes": 83959344,
"domNodes": 13671,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 28.658999999999995,
"eventListeners": 2381,
"totalBlockingTimeMs": 120,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 12299.075000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.223000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8853.678,
"heapDeltaBytes": -23262572,
"heapUsedBytes": 68070904,
"domNodes": -248,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 3099.554,
"eventListeners": -130,
"totalBlockingTimeMs": 7,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12432.546999999999,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.428,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9086.685000000001,
"heapDeltaBytes": -24332976,
"heapUsedBytes": 66536744,
"domNodes": -275,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 3150.9850000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18314.534000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17598.828999999998,
"heapDeltaBytes": -32736640,
"heapUsedBytes": 180038512,
"domNodes": -6550,
"jsHeapTotalBytes": -1081344,
"scriptDurationMs": 351.69800000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18544.136999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17827.893999999997,
"heapDeltaBytes": -28219820,
"heapUsedBytes": 177455592,
"domNodes": -6552,
"jsHeapTotalBytes": 2347008,
"scriptDurationMs": 362.45400000000006,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 22711.866999999984,
"styleRecalcs": 178,
"styleRecalcDurationMs": 21.492999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22467.858,
"heapDeltaBytes": -24186852,
"heapUsedBytes": 188065948,
"domNodes": -6552,
"jsHeapTotalBytes": -6537216,
"scriptDurationMs": 928.322,
"eventListeners": -7467,
"totalBlockingTimeMs": 253,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23245.20899999993,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.050999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22992.104000000003,
"heapDeltaBytes": -44786200,
"heapUsedBytes": 165623196,
"domNodes": -6550,
"jsHeapTotalBytes": -5079040,
"scriptDurationMs": 956.989,
"eventListeners": -7471,
"totalBlockingTimeMs": 115,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "workflow-execution",
"durationMs": 174.81099999997696,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.922,
"layouts": 7,
"layoutDurationMs": 2.063,
"taskDurationMs": 118.33300000000001,
"heapDeltaBytes": 3745836,
"heapUsedBytes": 70985168,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.851000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 129.55199999998968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.168000000000003,
"layouts": 2,
"layoutDurationMs": 0.718,
"taskDurationMs": 97.94800000000001,
"heapDeltaBytes": 3672188,
"heapUsedBytes": 71138004,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.747999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
AustinMroz
left a comment
There was a problem hiding this comment.
The PR has grown to be be a good bit larger than the title suggests, The title could do with an update, but the PR itself already handles most of my complaints (which I appreciate).
- The modified background grid no longer aligns with with grid-snapping (enabled by holding shift).
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #13842 +/- ##
==========================================
- Coverage 79.98% 79.46% -0.53%
==========================================
Files 2250 2283 +33
Lines 114156 117338 +3182
Branches 32072 32597 +525
==========================================
+ Hits 91313 93242 +1929
- Misses 22372 23573 +1201
- Partials 471 523 +52
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 97 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for the follow-up work since my last review — the custom-palette backdrop regression I flagged is resolved: --base-background-sunken now follows the palette's own CLEAR_BACKGROUND_COLOR via --canvas-clear-background, and the new colorPalette.spec.ts e2e covers exactly the obsidian/obsidian_dark case. I also verified completePalette merges litegraph_base with the default palette, so the unconditional setProperty in colorPaletteService can't receive undefined.
That said, I'm requesting changes because the PR has grown well past its stated scope and the regression net for the riskiest parts is weakened rather than strengthened (Austin raised the same size concern earlier). Please split this into separate PRs:
- Charcoal application to the editor chrome (topbar, tabs, sidebar, canvas grid, backdrop fix for dark/light) — the PR's stated goal, with only the snapshot updates that change belongs to.
- Custom-palette OKLCH depth rework (
:root.dark-theme[data-color-palette]:not([data-color-palette='dark'])token remap) — this restyles buttons, modals, menus, and borders across the entire app for solarized/arc/nord/github and every user-defined custom palette. It deserves its own review with per-palette before/after evidence. - Clipboard paste-priority fix (
useCopy.ts/usePaste.ts) — completely unrelated to theming and not mentioned anywhere in the PR description. A behavior fix needs its own PR with the issue verified/linked, root cause, and e2e coverage.
The core problem with keeping this as one PR: 40+ screenshot baselines are regenerated wholesale in the same change that introduces the app-wide token remap, so any unintended visual regression is baked into the new baselines instead of being caught by them. Splitting restores that safety net per change.
Unanchored notes:
- Per our PR standard, please embed the AS-IS / TO-BE screenshots or gif (per palette, captured in the real app) directly in the PR description rather than only linking the Slack thread — the PR record should stand on its own.
- Please also update the PR title/description to reflect the actual scope once split (the dark table still lists
#111111for charcoal-900; see inline nit).
Splits out the two pieces that do not belong here, per review: - the clipboard paste-priority fix, which is a behaviour change unrelated to theming and now carries its own PR with root cause and coverage - .claude/launch.json, local dev-server configuration that should never have been committed; it is gitignored now
The OKLCH ladder remapped ~25 semantic tokens — buttons, modals, menus, borders, node components — for every non-dark palette, including user-defined ones whose menu colour cannot be anticipated. That is an app-wide restyle rather than the editor-chrome change this PR describes, and it deserves its own review with per-palette evidence. The chrome derivations this PR is actually about (sidebar, selected tab, canvas backdrop) stay.
|
/update-playwright |
7 similar comments
|
/update-playwright |
|
/update-playwright |
|
/update-playwright |
|
/update-playwright |
|
/update-playwright |
|
/update-playwright |
|
/update-playwright |
|
@dante01yoon split done — this PR is now the charcoal application to the editor chrome and nothing else. Out of here since your review:
One dependency the split creates: #15884 has to merge first. This PR keeps the compact tab bar, which is what lets Diff is down from +283 to +119, with no snapshot regeneration needed — the remaining 70 checks pass. |
|
Split now complete, @dante01yoon. The three pieces and their order:
Nothing was dropped in the split — the 41 lines removed here are byte-identical to what #15893 adds. |
Review follow-up. data-color-palette lived in a GraphView watcher, so the token blocks and the body backdrop that key off it waited for that view to mount. colorPaletteService already writes the palette's other documentElement state, so it belongs there. Also switches the close button to the token syntax: the foreground alias utilities are descoped in App Mode.
Per @AustinMroz's review: the rationale belongs in the PR description, not inline.
Revert the palette/canvas/design-system/topbar-tab files to the branch base so this PR carries only the run bar and active indicator; those theme changes belong to Comfy-Org#13842. Swap the toast's comfy--stop for a filled span so the active indicator needs no new design-system icon, and remove the now-unused ProcessToast.
Revert the palette/canvas/design-system/topbar-tab files to the branch base so this PR carries only the run bar and active indicator; those theme changes belong to Comfy-Org#13842. Swap the toast's comfy--stop for a filled span so the active indicator needs no new design-system icon, and remove the now-unused ProcessToast.
|
Continued in #19437: same branch brought up to date with Generated by Claude Code |
dante01yoon
left a comment
There was a problem hiding this comment.
Thanks for splitting this up. The PR is now scoped to the charcoal chrome plus the backdrop fix. The custom-palette OKLCH remap moved to #15893 and the paste fix to #15884. That resolves the main concern from my last review. The visual evidence table is also a big help.
The head hasn't moved since 25 August, and three things stop me approving:
- Needs a rebase. GitHub reports the branch as
CONFLICTINGwithmain. The only red check isplaywright-tests-chromium-sharded (5, 16), failingimagePastePriority.spec.ts:9. That is exactly the case the description says depends on #15884, and #15884 merged on 8 October. A rebase should turn it green. Since the snapshot baselines in this PR are two months old, please let the screenshot workflow regenerate them on the rebased head rather than carrying the old PNGs over. - Added code comments (two, inline).
AGENTS.mddoesn't allow these, even after the trim commit. - The new unit test doesn't prove the behavior its title names (inline).
Unanchored:
- The "Theme depth" table in the description lists light canvas
#ededef.light.jsonstill declaresCLEAR_BACKGROUND_COLOR: lightgray, and your evidence table showsrgb(211,211,211). Please make the two tables agree. - The description says
GraphView.vuestampsdata-color-palette. Afterd769a044it'scolorPaletteService.ts.
Re-assigning to you. Ping me once it's rebased.
| app.canvas.background_image = palette.BACKGROUND_IMAGE | ||
| app.canvas.clear_background_color = palette.CLEAR_BACKGROUND_COLOR | ||
| } | ||
| // Past 1.5x zoom LiteGraph stops filling its clear background. |
There was a problem hiding this comment.
issue: This comment needs to go (AGENTS.md: "NEVER add code comments"). The rationale already lives in the PR description. If the code needs to say it, a name like publishCanvasClearBackground(palette.CLEAR_BACKGROUND_COLOR) would carry it without a comment.
| () => getComputedStyle(document.body).backgroundColor | ||
| ) | ||
|
|
||
| // Same menu colour, different clear colours. |
There was a problem hiding this comment.
issue: Same comment rule applies in tests. Per AGENTS.md, a test comment becomes a test.step name or goes away. For example: await test.step('palettes sharing a menu colour keep their own clear colour', async () => { ... }).
| ) | ||
| }) | ||
|
|
||
| it('still closes the active tab now that its close button is hover-revealed', async () => { |
There was a problem hiding this comment.
issue: This passes on main and with the hover-only CSS removed. happy-dom doesn't evaluate visibility or :hover from the scoped WorkflowTabs.vue styles, and user.click dispatches to an invisible element anyway. So the only extra thing it checks over delegates close to workflow service with the tab workflow is activeWorkflowKey, which the close path doesn't read. The behavior that actually changed is that the active tab's close button is hidden until hover or focus-within. That is CSS-only, so it needs a browser test: assert toBeHidden() at rest and toBeVisible() after hover() / focus() on the active tab. Otherwise please drop this case rather than keep a title that claims coverage it doesn't have.
| *.local | ||
| # Claude configuration | ||
| .claude/*.local.json | ||
| .claude/launch.json |
There was a problem hiding this comment.
nit-pick (non-blocking): .claude/launch.json is a local tooling entry unrelated to theming. Could it go in your global gitignore or a separate chore PR?
Revert the palette/canvas/design-system/topbar-tab files to the branch base so this PR carries only the run bar and active indicator; those theme changes belong to Comfy-Org#13842. Swap the toast's comfy--stop for a filled span so the active indicator needs no new design-system icon, and remove the now-unused ProcessToast.
b2fc2ce to
c9619dd
Compare
|
@mariana953 is attempting to deploy a commit to the ComfyUI Team on Vercel. A member of the Team first needs to authorize it. |
Summary
Applies the new charcoal steps to the editor chrome so the palette additions actually land in the product: a flatter topbar, filled selected tabs, a sunken canvas with a subtle line grid, and theme-aware surface tokens so every palette keeps its own colour logic.
Important
Part 1 of 3. Split per @dante01yoon's review. This PR is the stated scope: charcoal on the editor chrome, plus the backdrop fix.
imagePastePriority.spec.tsactually run, so that fix has to land first.data-color-palette, which is stamped here.Merge order: #15884, then this, then #15893.
What changed
Theme-aware surface tokens (
style.css): new semantic tokens rather than hardcoded colours, because the topbar/tab styles apply to all themes:--sidebar-surface--workflow-tab-selected-surface--workflow-tab-hover-surface--workflow-tab-divider--region-stroke--base-background-sunkenThe tuned charcoal/smoke values live under
:root[data-color-palette='dark'|'light'], so both keep their exact design-system values.Theme depth. Dark stacks three levels: canvas (charcoal-950) below sidebar and selected tab (charcoal-900) below the menu and tab bar (charcoal-800). Light mirrors it with the smoke values.
#171718#111112#09090a#ffffff#f7f7f8#ededefExtending that depth to custom palettes is #15893, not this PR.
Backdrop fix (all palettes). Past 1.5x zoom litegraph stops painting its clear background and the body shows through, so
--base-background-sunkennow follows the palette's ownCLEAR_BACKGROUND_COLOR, published as--canvas-clear-backgroundwhen the palette loads. Before this, obsidian and obsidian_dark both paintedrgb(36,36,36)regardless of their own canvas colour. Solarized had noCLEAR_BACKGROUND_COLORat all and inherited whatever the previously selected palette left behind; it now declares one. Covered by the newcolorPalette.spec.tse2e.Chrome flattening: removed resting borders and shadows from the top toolbar, tab bar, sidebar and canvas toolbar. Region strokes and tab dividers render at 25% of each palette's
--border-color(50% mix on the light palette's smoke values) so the divisions read as hairlines.Topbar alignment:
--workflow-tabs-heightdrops to 34px so the tab bar hugs its 32px controls. The graph mode pill, the extensions pill and the run actionbar share one baseline and one height (40px, 4px vertical padding each).Tabs: selected tab is a filled surface instead of an underline; the close button reveals on hover only (including on the active tab); the first tab no longer has a stray left border.
Canvas: every palette gains a subtle 24px line grid via
litegraph_base.BACKGROUND_IMAGE. litegraph'szoom_modify_alpharamp is untouched, so the grid stays quiet at default zoom and firms up as you zoom in.Points worth reviewer attention
data-color-paletteattribute:GraphView.vuenow stamps the palette id ondocumentElement. Necessary because.dark-themeis applied to every non-light palette, so any charcoal placed there leaked into solarized/arc/nord/github.color-mixfor stroke weight: region strokes and tab dividers are derived as a percentage of--border-colorrather than as explicit tokens. Happy to swap for named tokens if the design system prefers.pt-1on the actions column: compensates for the net 4px offset the subgraph breadcrumb applies to the graph pill (-mt-3+pt-4). Done on this side to avoid touching breadcrumb layout.actionbar.sharestring is removed fromen; other locales are regenerated at release, per repo convention), and the active tab's close button is hover-only. A regression test covers the latter..dark-themehardcodes ~88 semantic tokens to charcoal and those leak into every dark palette. Pre-existing onmain, and a larger design + FE initiative.Testing
vitest run src/components/topbar/: 62 passing, including a new test that the active tab still closes.vue-tsc --noEmitandstylelintclean.Demo
Screen recording and production comparison screenshots are in the Slack thread.
🤖 Generated with Claude Code
Visual evidence (25 August)
Same workflow, same framing (zoom 0.741) on
mainand on this branch.LiteGraph stops painting its clear colour past 1.5x zoom and the
bodyshows through, so the two have to agree:mainpainted#09090Argb(32,32,32)rgb(9,9,10)lightgrayrgb(221,221,221)rgb(211,211,211)#222222rgb(36,36,36)rgb(34,34,34)#000rgb(36,36,36)rgb(0,0,0)The last two rows are the regression @dante01yoon found: both palettes share
--comfy-menu-bg, so deriving the backdrop from it collapsed two different canvases onto one colour. They are thecolorPalette.spec.tsfixtures, standing in for a user-imported palette, which is why the shipped palettes never surfaced it.dark
main)light
main)obsidian
main)obsidian dark
main)