Skip to content

fix(assets): harden history head-refresh trailing chain against a rejected leading refresh - #13783

Merged
mattmillerai merged 3 commits into
matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourcedfrom
matt/be-3421-harden-head-refresh-trailing-chain
Aug 18, 2026
Merged

mattmillerai merged 3 commits into
matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourcedfrom
matt/be-3421-harden-head-refresh-trailing-chain

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

ELI-5

When new jobs finish, the Generated tab re-fetches the top of the history list. To avoid hammering the server, overlapping refreshes share one in-flight fetch and schedule at most one "trailing" follow-up refresh (so a fetch that started a hair too early still catches the completion that triggered it).

The bug: that trailing follow-up was chained with .then(...). If the leading refresh's promise ever rejected, the .then callback would never run, the trailing slot would stay stuck holding a settled-rejected promise, and every future refresh would return that same dead promise forever — the head-refresh mechanism freezes permanently.

The fix swallows the leading rejection before scheduling the trailing refresh, so the trailing slot always clears and a fresh refresh runs. The original caller still sees the rejection.

Why this is future-proofing (and how it's tested)

This freeze is unreachable today: doRefreshHistoryHead and everything it delegates to (updateHistory, the fetch helpers) catch internally, so the leading promise never actually rejects. This PR guards against a later refactor that adds an uncaught await on that path — consistent with the review thread that deferred it out of the source PR.

I verified this empirically: making fetchHistoryPage reject and calling refreshHistoryHead() never produces a rejected promise through the store's public API.

Judgment call — extraction vs. the one-line fix. The minimal in-place change would be headRefreshInFlight.catch(() => {}).then(...). But because the store swallows all internal errors, the leading promise can't be made to reject through the public API, so a regression test for the fix cannot fail without the fix when written at the store level. To get a real red-green test, I extracted the trailing-edge coalescing state machine into a small pure function, createTrailingRefreshCoalescer, and unit-tested it directly by injecting a run that rejects. Behavior is identical — refreshHistoryHead is now createTrailingRefreshCoalescer(() => doRefreshHistoryHead()). If reviewers prefer the surgical one-liner instead, it's a trivial revert of the extraction.

Red-green confirmed: reverting the .catch(() => {}) makes the new "keeps refreshing after a rejected leading run" test fail (trailing promise rejects and the run count stalls); restoring it passes.

Stacked PR

Based on matt/fe-962-... (#12769), where this code lives — it is not yet on main. GitHub will retarget this PR to main when #12769 merges.

Changes

  • createTrailingRefreshCoalescer (new, pure, module-scope): coalesces concurrent calls into one leading run + one trailing run; swallows the leading rejection for the trailing chain only.
  • refreshHistoryHead now delegates to it (no behavior change).
  • 3 unit tests for the coalescer, including the rejected-leading-run regression.

Tests

  • pnpm vitest run src/stores/assetsStore.test.ts — 101 passed.
  • pnpm typecheck, eslint, oxfmt --check on the changed files — clean.

@mattmillerai mattmillerai added the agent-coded Opened by the agent-work code loop label Jul 18, 2026
@mattmillerai
mattmillerai marked this pull request as ready for review July 18, 2026 01:58
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 18, 2026
@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 82c1566e-c1cc-4461-a1af-c0f2e308fd7f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch matt/be-3421-harden-head-refresh-trailing-chain

Comment @coderabbitai help to get the list of available commands.

@mattmillerai mattmillerai added the cursor-review Trigger multi-model Cursor agent review on this PR label Jul 18, 2026
@github-actions

github-actions Bot commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/26/2026, 05:16:20 AM UTC

Links

🎭 Playwright: ✅ 1713 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1692 / ❌ 0 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 55.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 52.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 138ms TBT · 94.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.5 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 47ms TBT · 171.1 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 50.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 472ms
canvas-idle: script duration 24ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.7 MB
canvas-idle: DOM nodes 17
canvas-idle: event listeners 4
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 42ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 893ms
canvas-mouse-sweep: script duration 133ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 50.1 MB
canvas-mouse-sweep: DOM nodes -267
canvas-mouse-sweep: event listeners -133
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 20ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 386ms
canvas-zoom-sweep: script duration 27ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.9 MB
canvas-zoom-sweep: DOM nodes 78
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 363ms
dom-widget-clipping: script duration 60ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 54.7 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 9
large-graph-idle: task duration 699ms
large-graph-idle: script duration 112ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 61.4 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -129
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1215ms
large-graph-pan: script duration 415ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 66.1 MB
large-graph-pan: DOM nodes -271
large-graph-pan: event listeners -130
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 16ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 65
large-graph-zoom: task duration 1472ms
large-graph-zoom: script duration 526ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 57.2 MB
large-graph-zoom: DOM nodes -274
large-graph-zoom: event listeners -133
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 10ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 686ms
minimap-idle: script duration 112ms
minimap-idle: TBT 0ms
minimap-idle: heap used 63.2 MB
minimap-idle: DOM nodes -268
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 15ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 407ms
subgraph-dom-widget-clipping: script duration 132ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 55.4 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 472ms
subgraph-idle: script duration 21ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.8 MB
subgraph-idle: DOM nodes 19
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 39ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 775ms
subgraph-mouse-sweep: script duration 102ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 52.9 MB
subgraph-mouse-sweep: DOM nodes -100
subgraph-mouse-sweep: event listeners -65
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 867ms
subgraph-transition-enter: script duration 36ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 94.3 MB
subgraph-transition-enter: DOM nodes 13673
subgraph-transition-enter: event listeners 2371
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4220ms
viewport-pan-sweep: script duration 1337ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.7 MB
viewport-pan-sweep: DOM nodes -268
viewport-pan-sweep: event listeners -114
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 13296ms
vue-large-graph-idle: script duration 573ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 160.5 MB
vue-large-graph-idle: DOM nodes -8311
vue-large-graph-idle: event listeners -16385
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 82
vue-large-graph-pan: task duration 15937ms
vue-large-graph-pan: script duration 897ms
vue-large-graph-pan: TBT 47ms
vue-large-graph-pan: heap used 171.1 MB
vue-large-graph-pan: DOM nodes -8313
vue-large-graph-pan: event listeners -16381
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 4
workflow-execution: style recalc count 17
workflow-execution: task duration 136ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 50.0 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-07-26T05:26:43.139Z",
  "gitSha": "fc0851dc79c77cfe497940e158d77090d34a90f3",
  "branch": "matt/be-3421-harden-head-refresh-trailing-chain",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2021.2629999999763,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.062,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 506.98900000000003,
      "heapDeltaBytes": 3828636,
      "heapUsedBytes": 73121072,
      "domNodes": 16,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 26.509,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2032.3230000000194,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.976999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.77500000000003,
      "heapDeltaBytes": 3892972,
      "heapUsedBytes": 73039480,
      "domNodes": 18,
      "jsHeapTotalBytes": 18759680,
      "scriptDurationMs": 22.2,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1870.7989999999768,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 41.444,
      "layouts": 12,
      "layoutDurationMs": 3.74,
      "taskDurationMs": 897.555,
      "heapDeltaBytes": -16730640,
      "heapUsedBytes": 52418012,
      "domNodes": -266,
      "jsHeapTotalBytes": 19410944,
      "scriptDurationMs": 131.593,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1876.7909999999688,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 42.185,
      "layouts": 12,
      "layoutDurationMs": 4.75,
      "taskDurationMs": 888.822,
      "heapDeltaBytes": -16661844,
      "heapUsedBytes": 52598736,
      "domNodes": -267,
      "jsHeapTotalBytes": 19410944,
      "scriptDurationMs": 134.007,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.6979999999717,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.102,
      "layouts": 6,
      "layoutDurationMs": 0.8039999999999998,
      "taskDurationMs": 405.15500000000003,
      "heapDeltaBytes": 7129588,
      "heapUsedBytes": 76345388,
      "domNodes": 78,
      "jsHeapTotalBytes": 19021824,
      "scriptDurationMs": 28.426999999999996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.600999999956,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 20.060000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.7789999999999999,
      "taskDurationMs": 367.11899999999997,
      "heapDeltaBytes": 7154180,
      "heapUsedBytes": 76476264,
      "domNodes": 77,
      "jsHeapTotalBytes": 19283968,
      "scriptDurationMs": 25.755999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 595.3480000000013,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.537999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 375.786,
      "heapDeltaBytes": -11838236,
      "heapUsedBytes": 57341500,
      "domNodes": 18,
      "jsHeapTotalBytes": 20332544,
      "scriptDurationMs": 61.377,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 592.07600000002,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.998999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.45000000000005,
      "heapDeltaBytes": -11660600,
      "heapUsedBytes": 57471716,
      "domNodes": 18,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 58.287,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.014000000037,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.812999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 719.9949999999999,
      "heapDeltaBytes": 4720744,
      "heapUsedBytes": 64329984,
      "domNodes": -269,
      "jsHeapTotalBytes": 5062656,
      "scriptDurationMs": 113.69699999999999,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2018.5000000000173,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.084,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 678.4879999999999,
      "heapDeltaBytes": 4764632,
      "heapUsedBytes": 64346872,
      "domNodes": -269,
      "jsHeapTotalBytes": 4800512,
      "scriptDurationMs": 109.97000000000001,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2177.6930000000334,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 14.517,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1256.467,
      "heapDeltaBytes": 21944796,
      "heapUsedBytes": 82603480,
      "domNodes": -271,
      "jsHeapTotalBytes": 5529600,
      "scriptDurationMs": 429.55199999999996,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2136.476000000016,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.668,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1174.234,
      "heapDeltaBytes": -4427384,
      "heapUsedBytes": 56010028,
      "domNodes": -270,
      "jsHeapTotalBytes": 6111232,
      "scriptDurationMs": 401.33,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3212.144999999964,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 15.473,
      "layouts": 60,
      "layoutDurationMs": 7.9670000000000005,
      "taskDurationMs": 1501.431,
      "heapDeltaBytes": -1995040,
      "heapUsedBytes": 60155260,
      "domNodes": -275,
      "jsHeapTotalBytes": 7946240,
      "scriptDurationMs": 535.41,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3200.3449999999702,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.566,
      "layouts": 60,
      "layoutDurationMs": 7.6530000000000005,
      "taskDurationMs": 1442.3249999999998,
      "heapDeltaBytes": -2149104,
      "heapUsedBytes": 59879444,
      "domNodes": -272,
      "jsHeapTotalBytes": 7421952,
      "scriptDurationMs": 516.9319999999999,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.5259999999703,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.914,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 715.7310000000001,
      "heapDeltaBytes": 4673236,
      "heapUsedBytes": 65919396,
      "domNodes": -266,
      "jsHeapTotalBytes": 4800512,
      "scriptDurationMs": 113.889,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.9040000000969,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 10.369,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.9250000000001,
      "heapDeltaBytes": 5231588,
      "heapUsedBytes": 66579988,
      "domNodes": -269,
      "jsHeapTotalBytes": 5062656,
      "scriptDurationMs": 110.953,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 592.2479999999837,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.907,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 401.733,
      "heapDeltaBytes": -11131464,
      "heapUsedBytes": 58085400,
      "domNodes": 18,
      "jsHeapTotalBytes": 20332544,
      "scriptDurationMs": 132.913,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 616.4360000000215,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 18.793,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 411.54400000000004,
      "heapDeltaBytes": -11321436,
      "heapUsedBytes": 58026848,
      "domNodes": 22,
      "jsHeapTotalBytes": 20332544,
      "scriptDurationMs": 131.537,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.7760000000026,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.056000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 487.86899999999997,
      "heapDeltaBytes": 3788256,
      "heapUsedBytes": 73023004,
      "domNodes": 18,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 23.341000000000005,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2011.5030000000615,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.277000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.47,
      "heapDeltaBytes": 3906888,
      "heapUsedBytes": 73359676,
      "domNodes": 20,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 19.189999999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1742.5069999999891,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.74999999999999,
      "layouts": 16,
      "layoutDurationMs": 4.727,
      "taskDurationMs": 764.349,
      "heapDeltaBytes": -5312584,
      "heapUsedBytes": 63934088,
      "domNodes": 65,
      "jsHeapTotalBytes": 19546112,
      "scriptDurationMs": 104.503,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.4810000000116,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.195,
      "layouts": 16,
      "layoutDurationMs": 4.06,
      "taskDurationMs": 785.1049999999999,
      "heapDeltaBytes": -22212288,
      "heapUsedBytes": 47052840,
      "domNodes": -265,
      "jsHeapTotalBytes": 19410944,
      "scriptDurationMs": 100.04100000000001,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1266.4950000000204,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.205999999999996,
      "layouts": 14,
      "layoutDurationMs": 13.669000000000004,
      "taskDurationMs": 867.483,
      "heapDeltaBytes": 7289356,
      "heapUsedBytes": 98911388,
      "domNodes": 13673,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 36.341,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8217.662999999959,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.218,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4300.887,
      "heapDeltaBytes": 14823468,
      "heapUsedBytes": 74524852,
      "domNodes": -267,
      "jsHeapTotalBytes": 6316032,
      "scriptDurationMs": 1359.906,
      "eventListeners": -113,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999952,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8186.148000000003,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.799,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4138.3910000000005,
      "heapDeltaBytes": 16326716,
      "heapUsedBytes": 75917348,
      "domNodes": -269,
      "jsHeapTotalBytes": 7626752,
      "scriptDurationMs": 1314.211,
      "eventListeners": -115,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 13637.091999999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13609.410999999998,
      "heapDeltaBytes": -43601476,
      "heapUsedBytes": 164914836,
      "domNodes": -8311,
      "jsHeapTotalBytes": -10162176,
      "scriptDurationMs": 587.178,
      "eventListeners": -16386,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12996.579999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12982.374,
      "heapDeltaBytes": -53592548,
      "heapUsedBytes": 171712216,
      "domNodes": -8311,
      "jsHeapTotalBytes": -10162176,
      "scriptDurationMs": 559.4,
      "eventListeners": -16384,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16237.768000000016,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 14.904000000000028,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16214.899,
      "heapDeltaBytes": -21008488,
      "heapUsedBytes": 179095316,
      "domNodes": -8314,
      "jsHeapTotalBytes": -14180352,
      "scriptDurationMs": 909.527,
      "eventListeners": -16382,
      "totalBlockingTimeMs": 75,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15684.521999999903,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 14.102000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15659.530000000002,
      "heapDeltaBytes": -28570152,
      "heapUsedBytes": 179714140,
      "domNodes": -8311,
      "jsHeapTotalBytes": -15228928,
      "scriptDurationMs": 884.9149999999998,
      "eventListeners": -16380,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 509.6499999999651,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.721999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.214,
      "taskDurationMs": 149.73999999999998,
      "heapDeltaBytes": -15701840,
      "heapUsedBytes": 52837484,
      "domNodes": 154,
      "jsHeapTotalBytes": 6438912,
      "scriptDurationMs": 13.075999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.7390000000605,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 21.81,
      "layouts": 4,
      "layoutDurationMs": 1.3499999999999999,
      "taskDurationMs": 122.122,
      "heapDeltaBytes": -16522804,
      "heapUsedBytes": 52024396,
      "domNodes": 119,
      "jsHeapTotalBytes": 6701056,
      "scriptDurationMs": 11.470999999999998,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @mattmillerai.

Found 4 finding(s).

Severity Count
🟡 Medium 1
🟢 Low 2
⚪ Nit 1

Panel: 6/8 reviewers contributed findings.

Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)

Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
Comment thread src/stores/assetsStore.ts Resolved
@codecov

codecov Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                                             Coverage Diff                                              @@
##           matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourced   #13783      +/-   ##
============================================================================================================
- Coverage                                                                     76.27%   76.20%   -0.08%     
============================================================================================================
  Files                                                                          1696     1693       -3     
  Lines                                                                        118176   117758     -418     
  Branches                                                                      39060    37936    -1124     
============================================================================================================
- Hits                                                                          90143    89733     -410     
+ Misses                                                                        27279    27271       -8     
  Partials                                                                        754      754              
Flag Coverage Δ
unit 67.76% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/stores/assetsStore.ts 67.43% <100.00%> (-2.61%) ⬇️

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…escer

Return an already-queued trailing run before anything else so a call
landing in the microtask gap after the leading run clears inFlight but
before the trailing run clears its slot coalesces into the trailing run
instead of starting a second leading run, preserving the
at-most-one-trailing guarantee.

Normalize a synchronous throw from run() into a rejected promise so the
exported coalescer never throws out of invoke() and never latches a
half-initialized slot.
@mattmillerai

Copy link
Copy Markdown
Member Author

🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:

…nation-in-the-generated-tab-jobs-sourced' into matt/be-3421-harden-head-refresh-trailing-chain

# Conflicts:
#	src/stores/assetsStore.ts
@mattmillerai

Copy link
Copy Markdown
Member Author

STACKED — merging lands on matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourced (owned by @mattmillerai, PR #12769), NOT main.

Pushing a merge-conflict resolution now: the base branch advanced (#12769 picked up review-feedback commits) after this PR's last push, which put GitHub's merge check in a dirty state. The merge was already resolved locally (clean, no conflict markers, tests/typecheck/lint/format all green) — just needed to be pushed.

@mattmillerai
mattmillerai merged commit 995e240 into matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourced Aug 18, 2026
55 checks passed
@mattmillerai
mattmillerai deleted the matt/be-3421-harden-head-refresh-trailing-chain branch August 18, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded Opened by the agent-work code loop cursor-review Trigger multi-model Cursor agent review on this PR size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant