Repository navigation
fix(assets): harden history head-refresh trailing chain against a rejected leading refresh - #13783
Conversation
…ected leading refresh
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1713 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-07-26T05:26:43.139Z",
"gitSha": "fc0851dc79c77cfe497940e158d77090d34a90f3",
"branch": "matt/be-3421-harden-head-refresh-trailing-chain",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.2629999999763,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.062,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.98900000000003,
"heapDeltaBytes": 3828636,
"heapUsedBytes": 73121072,
"domNodes": 16,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 26.509,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2032.3230000000194,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.976999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.77500000000003,
"heapDeltaBytes": 3892972,
"heapUsedBytes": 73039480,
"domNodes": 18,
"jsHeapTotalBytes": 18759680,
"scriptDurationMs": 22.2,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1870.7989999999768,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.444,
"layouts": 12,
"layoutDurationMs": 3.74,
"taskDurationMs": 897.555,
"heapDeltaBytes": -16730640,
"heapUsedBytes": 52418012,
"domNodes": -266,
"jsHeapTotalBytes": 19410944,
"scriptDurationMs": 131.593,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.7909999999688,
"styleRecalcs": 75,
"styleRecalcDurationMs": 42.185,
"layouts": 12,
"layoutDurationMs": 4.75,
"taskDurationMs": 888.822,
"heapDeltaBytes": -16661844,
"heapUsedBytes": 52598736,
"domNodes": -267,
"jsHeapTotalBytes": 19410944,
"scriptDurationMs": 134.007,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.6979999999717,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.102,
"layouts": 6,
"layoutDurationMs": 0.8039999999999998,
"taskDurationMs": 405.15500000000003,
"heapDeltaBytes": 7129588,
"heapUsedBytes": 76345388,
"domNodes": 78,
"jsHeapTotalBytes": 19021824,
"scriptDurationMs": 28.426999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.600999999956,
"styleRecalcs": 31,
"styleRecalcDurationMs": 20.060000000000002,
"layouts": 6,
"layoutDurationMs": 0.7789999999999999,
"taskDurationMs": 367.11899999999997,
"heapDeltaBytes": 7154180,
"heapUsedBytes": 76476264,
"domNodes": 77,
"jsHeapTotalBytes": 19283968,
"scriptDurationMs": 25.755999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 595.3480000000013,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.537999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.786,
"heapDeltaBytes": -11838236,
"heapUsedBytes": 57341500,
"domNodes": 18,
"jsHeapTotalBytes": 20332544,
"scriptDurationMs": 61.377,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 592.07600000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.998999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.45000000000005,
"heapDeltaBytes": -11660600,
"heapUsedBytes": 57471716,
"domNodes": 18,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 58.287,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2033.014000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.812999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 719.9949999999999,
"heapDeltaBytes": 4720744,
"heapUsedBytes": 64329984,
"domNodes": -269,
"jsHeapTotalBytes": 5062656,
"scriptDurationMs": 113.69699999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2018.5000000000173,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 678.4879999999999,
"heapDeltaBytes": 4764632,
"heapUsedBytes": 64346872,
"domNodes": -269,
"jsHeapTotalBytes": 4800512,
"scriptDurationMs": 109.97000000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2177.6930000000334,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1256.467,
"heapDeltaBytes": 21944796,
"heapUsedBytes": 82603480,
"domNodes": -271,
"jsHeapTotalBytes": 5529600,
"scriptDurationMs": 429.55199999999996,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2136.476000000016,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1174.234,
"heapDeltaBytes": -4427384,
"heapUsedBytes": 56010028,
"domNodes": -270,
"jsHeapTotalBytes": 6111232,
"scriptDurationMs": 401.33,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3212.144999999964,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.473,
"layouts": 60,
"layoutDurationMs": 7.9670000000000005,
"taskDurationMs": 1501.431,
"heapDeltaBytes": -1995040,
"heapUsedBytes": 60155260,
"domNodes": -275,
"jsHeapTotalBytes": 7946240,
"scriptDurationMs": 535.41,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3200.3449999999702,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.566,
"layouts": 60,
"layoutDurationMs": 7.6530000000000005,
"taskDurationMs": 1442.3249999999998,
"heapDeltaBytes": -2149104,
"heapUsedBytes": 59879444,
"domNodes": -272,
"jsHeapTotalBytes": 7421952,
"scriptDurationMs": 516.9319999999999,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.5259999999703,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.914,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 715.7310000000001,
"heapDeltaBytes": 4673236,
"heapUsedBytes": 65919396,
"domNodes": -266,
"jsHeapTotalBytes": 4800512,
"scriptDurationMs": 113.889,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.9040000000969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.369,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.9250000000001,
"heapDeltaBytes": 5231588,
"heapUsedBytes": 66579988,
"domNodes": -269,
"jsHeapTotalBytes": 5062656,
"scriptDurationMs": 110.953,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 592.2479999999837,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.907,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.733,
"heapDeltaBytes": -11131464,
"heapUsedBytes": 58085400,
"domNodes": 18,
"jsHeapTotalBytes": 20332544,
"scriptDurationMs": 132.913,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.4360000000215,
"styleRecalcs": 48,
"styleRecalcDurationMs": 18.793,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.54400000000004,
"heapDeltaBytes": -11321436,
"heapUsedBytes": 58026848,
"domNodes": 22,
"jsHeapTotalBytes": 20332544,
"scriptDurationMs": 131.537,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.7760000000026,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.056000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.86899999999997,
"heapDeltaBytes": 3788256,
"heapUsedBytes": 73023004,
"domNodes": 18,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 23.341000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2011.5030000000615,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.277000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.47,
"heapDeltaBytes": 3906888,
"heapUsedBytes": 73359676,
"domNodes": 20,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 19.189999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5069999999891,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.74999999999999,
"layouts": 16,
"layoutDurationMs": 4.727,
"taskDurationMs": 764.349,
"heapDeltaBytes": -5312584,
"heapUsedBytes": 63934088,
"domNodes": 65,
"jsHeapTotalBytes": 19546112,
"scriptDurationMs": 104.503,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.4810000000116,
"styleRecalcs": 78,
"styleRecalcDurationMs": 37.195,
"layouts": 16,
"layoutDurationMs": 4.06,
"taskDurationMs": 785.1049999999999,
"heapDeltaBytes": -22212288,
"heapUsedBytes": 47052840,
"domNodes": -265,
"jsHeapTotalBytes": 19410944,
"scriptDurationMs": 100.04100000000001,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1266.4950000000204,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.205999999999996,
"layouts": 14,
"layoutDurationMs": 13.669000000000004,
"taskDurationMs": 867.483,
"heapDeltaBytes": 7289356,
"heapUsedBytes": 98911388,
"domNodes": 13673,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 36.341,
"eventListeners": 2371,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8217.662999999959,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.218,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4300.887,
"heapDeltaBytes": 14823468,
"heapUsedBytes": 74524852,
"domNodes": -267,
"jsHeapTotalBytes": 6316032,
"scriptDurationMs": 1359.906,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8186.148000000003,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.799,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4138.3910000000005,
"heapDeltaBytes": 16326716,
"heapUsedBytes": 75917348,
"domNodes": -269,
"jsHeapTotalBytes": 7626752,
"scriptDurationMs": 1314.211,
"eventListeners": -115,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 13637.091999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13609.410999999998,
"heapDeltaBytes": -43601476,
"heapUsedBytes": 164914836,
"domNodes": -8311,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 587.178,
"eventListeners": -16386,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12996.579999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12982.374,
"heapDeltaBytes": -53592548,
"heapUsedBytes": 171712216,
"domNodes": -8311,
"jsHeapTotalBytes": -10162176,
"scriptDurationMs": 559.4,
"eventListeners": -16384,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16237.768000000016,
"styleRecalcs": 84,
"styleRecalcDurationMs": 14.904000000000028,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16214.899,
"heapDeltaBytes": -21008488,
"heapUsedBytes": 179095316,
"domNodes": -8314,
"jsHeapTotalBytes": -14180352,
"scriptDurationMs": 909.527,
"eventListeners": -16382,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 15684.521999999903,
"styleRecalcs": 80,
"styleRecalcDurationMs": 14.102000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15659.530000000002,
"heapDeltaBytes": -28570152,
"heapUsedBytes": 179714140,
"domNodes": -8311,
"jsHeapTotalBytes": -15228928,
"scriptDurationMs": 884.9149999999998,
"eventListeners": -16380,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 509.6499999999651,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.721999999999998,
"layouts": 3,
"layoutDurationMs": 1.214,
"taskDurationMs": 149.73999999999998,
"heapDeltaBytes": -15701840,
"heapUsedBytes": 52837484,
"domNodes": 154,
"jsHeapTotalBytes": 6438912,
"scriptDurationMs": 13.075999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 457.7390000000605,
"styleRecalcs": 16,
"styleRecalcDurationMs": 21.81,
"layouts": 4,
"layoutDurationMs": 1.3499999999999999,
"taskDurationMs": 122.122,
"heapDeltaBytes": -16522804,
"heapUsedBytes": 52024396,
"domNodes": 119,
"jsHeapTotalBytes": 6701056,
"scriptDurationMs": 11.470999999999998,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mattmillerai.
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/8 reviewers contributed findings.
Reviewers that did not contribute: kimi-k2.5:adversarial (empty), kimi-k2.5:edge-case (empty)
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourced #13783 +/- ##
============================================================================================================
- Coverage 76.27% 76.20% -0.08%
============================================================================================================
Files 1696 1693 -3
Lines 118176 117758 -418
Branches 39060 37936 -1124
============================================================================================================
- Hits 90143 89733 -410
+ Misses 27279 27271 -8
Partials 754 754
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 49 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…escer Return an already-queued trailing run before anything else so a call landing in the microtask gap after the leading run clears inFlight but before the trailing run clears its slot coalesces into the trailing run instead of starting a second leading run, preserving the at-most-one-trailing guarantee. Normalize a synchronous throw from run() into a rejected promise so the exported coalescer never throws out of invoke() and never latches a half-initialized slot.
|
🤖 The reviews loop filed Linear follow-up ticket(s) for review thread(s) deferred as out of scope for this PR:
|
…nation-in-the-generated-tab-jobs-sourced' into matt/be-3421-harden-head-refresh-trailing-chain # Conflicts: # src/stores/assetsStore.ts
|
STACKED — merging lands on Pushing a merge-conflict resolution now: the base branch advanced (#12769 picked up review-feedback commits) after this PR's last push, which put GitHub's merge check in a |
995e240
into
matt/fe-962-fe-adopt-cursor-pagination-in-the-generated-tab-jobs-sourced
ELI-5
When new jobs finish, the Generated tab re-fetches the top of the history list. To avoid hammering the server, overlapping refreshes share one in-flight fetch and schedule at most one "trailing" follow-up refresh (so a fetch that started a hair too early still catches the completion that triggered it).
The bug: that trailing follow-up was chained with
.then(...). If the leading refresh's promise ever rejected, the.thencallback would never run, the trailing slot would stay stuck holding a settled-rejected promise, and every future refresh would return that same dead promise forever — the head-refresh mechanism freezes permanently.The fix swallows the leading rejection before scheduling the trailing refresh, so the trailing slot always clears and a fresh refresh runs. The original caller still sees the rejection.
Why this is future-proofing (and how it's tested)
This freeze is unreachable today:
doRefreshHistoryHeadand everything it delegates to (updateHistory, the fetch helpers) catch internally, so the leading promise never actually rejects. This PR guards against a later refactor that adds an uncaughtawaiton that path — consistent with the review thread that deferred it out of the source PR.I verified this empirically: making
fetchHistoryPagereject and callingrefreshHistoryHead()never produces a rejected promise through the store's public API.Judgment call — extraction vs. the one-line fix. The minimal in-place change would be
headRefreshInFlight.catch(() => {}).then(...). But because the store swallows all internal errors, the leading promise can't be made to reject through the public API, so a regression test for the fix cannot fail without the fix when written at the store level. To get a real red-green test, I extracted the trailing-edge coalescing state machine into a small pure function,createTrailingRefreshCoalescer, and unit-tested it directly by injecting arunthat rejects. Behavior is identical —refreshHistoryHeadis nowcreateTrailingRefreshCoalescer(() => doRefreshHistoryHead()). If reviewers prefer the surgical one-liner instead, it's a trivial revert of the extraction.Red-green confirmed: reverting the
.catch(() => {})makes the new "keeps refreshing after a rejected leading run" test fail (trailing promise rejects and the run count stalls); restoring it passes.Stacked PR
Based on
matt/fe-962-...(#12769), where this code lives — it is not yet onmain. GitHub will retarget this PR tomainwhen #12769 merges.Changes
createTrailingRefreshCoalescer(new, pure, module-scope): coalesces concurrent calls into one leading run + one trailing run; swallows the leading rejection for the trailing chain only.refreshHistoryHeadnow delegates to it (no behavior change).Tests
pnpm vitest run src/stores/assetsStore.test.ts— 101 passed.pnpm typecheck,eslint,oxfmt --checkon the changed files — clean.