Skip to content

refactor(subscription): migrate pricing table help popovers to Reka - #13642

Closed
dante01yoon wants to merge 3 commits into
mainfrom
jaewon/subscription-pricing-popover-reka
Closed

dante01yoon wants to merge 3 commits into
mainfrom
jaewon/subscription-pricing-popover-reka

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Summary

Migrate the "video estimate" help popover in both legacy pricing tables from primevue/popover to the Reka ui/popover primitive — removing PrimeVue from these components and unblocking the Subscription container's modal: true restoration (#13558).

Changes

  • What: PricingTableWorkspace.vue and PricingTable.vue replace the single body-teleported <Popover ref> + imperative togglePopover(event) with a per-tier declarative <Popover><PopoverTrigger as-child><PopoverContent> (Reka). The trigger is now a real <button> (keyboard-focusable, Reka wires aria-haspopup/aria-expanded); the content is unchanged (explanation + "try template" link).
  • Drops primevue/popover, the popover ref, and togglePopover from both files.
  • Test: extend the existing Popover stub in PricingTable.test.ts to also stub PopoverTrigger/PopoverContent (the Reka subcomponents need a PopoverRoot context the old single stub didn't provide).

Review Focus

  • Why this matters for Dialog architecture: retire the non-modal container workaround stack (root fix + regression harness, successor to FE-578) #13558: a Reka popover portals as a DismissableLayer and works under both modal: false (today's legacy-workspace path) and modal: true. The PrimeVue popover was the one body-teleported overlay blocking the Subscription modal: true flip; with it gone, the flip becomes a one-line follow-up. It also fixes a latent bug on the fully-legacy path (useSubscriptionDialog.ts renders it modal: true today, under which the old PrimeVue popover's "try template" link was pointer-dead) — the Reka popover works there now.
  • Verification: static gates green — typecheck, eslint, oxfmt, and 56 subscription unit tests (PricingTable.test.ts, SubscriptionPanelContentWorkspace.test.ts, useSubscriptionDialog.test.ts). Interactive/visual verification (popover opens on the help click, positions under the trigger, dismisses on outside-click/Escape) is still pending — there's no Storybook story for these two tables, so it's best checked in the cloud Subscription dialog; flagging rather than claiming it.
  • Out of scope: SelectButton (billing-cycle toggle) stays PrimeVue; the modal: true flip and the sm:max-w-7xl sizing idiom are separate follow-ups (the latter tracked on fix(subscription): size pricing dialogs with Reka props #13633).

@dante01yoon
dante01yoon requested a review from a team July 14, 2026 19:03
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1749 passed, 1 failed · 4 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1730 / ❌ 1 / ⚠️ 3 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 07/29/2026, 09:57:10 PM UTC

Links

📦 Bundle: 8.15 MB gzip 🔴 +23 B

Details

Summary

  • Raw size: 34.2 MB baseline 34.2 MB — 🔴 +495 B
  • Gzip: 8.15 MB baseline 8.15 MB — 🔴 +23 B
  • Brotli: 5.64 MB baseline 5.64 MB — 🔴 +26 B
  • Bundles: 419 current • 419 baseline • 4 added / 4 removed

Category Glance
Other 🔴 +495 B (12.5 MB) · Vendor & Third-Party ⚪ 0 B (15.7 MB) · Data & Services ⚪ 0 B (3.42 MB) · Graph Workspace ⚪ 0 B (1.28 MB) · Panels & Settings ⚪ 0 B (551 kB) · Utilities & Hooks ⚪ 0 B (371 kB) · + 5 more

App Entry Points — 3.66 kB (baseline 3.66 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-a9G2xmvj.js (removed) 3.66 kB — 🟢 -3.66 kB 🟢 -1.84 kB 🟢 -1.59 kB
assets/index-C7y4b1Fm.js (new) — 3.66 kB 🔴 +3.66 kB 🔴 +1.84 kB 🔴 +1.61 kB

Status: 1 added / 1 removed

Graph Workspace — 1.28 MB (baseline 1.28 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 2 unchanged

Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 16 unchanged

Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 26 unchanged

User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 10 unchanged

Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 6 unchanged

UI Components — 64.8 kB (baseline 64.8 kB) • ⚪ 0 B

Reusable component library chunks

Status: 14 unchanged

Data & Services — 3.42 MB (baseline 3.42 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 371 kB (baseline 371 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 35 unchanged

Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 12.5 MB (baseline 12.5 MB) • 🔴 +495 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/main-CK_RHcje.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +13.8 kB 🔴 +11.9 kB
assets/main-u9EYwFcy.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -13.8 kB 🟢 -11.9 kB
assets/SubscriptionRequiredDialogContent-NA1U4_mO.js (new) — 26.3 kB 🔴 +26.3 kB 🔴 +6.17 kB 🔴 +5.43 kB
assets/SubscriptionRequiredDialogContent-W0wSpGUZ.js (removed) 26.1 kB — 🟢 -26.1 kB 🟢 -6.17 kB 🟢 -5.43 kB
assets/SubscriptionRequiredDialogContentWorkspace-JDCXvKfJ.js (new) — 25.2 kB 🔴 +25.2 kB 🔴 +5.79 kB 🔴 +5.09 kB
assets/SubscriptionRequiredDialogContentWorkspace-ByuXQJAC.js (removed) 24.9 kB — 🟢 -24.9 kB 🟢 -5.77 kB 🟢 -5.07 kB

Status: 3 added / 3 removed / 273 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 49.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 115ms TBT · 93.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.1 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 159.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 235ms TBT · 159.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 48.8 MB heap

⚠️ 6 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: task duration 507ms 551ms +9% ⚠️ z=5.0
canvas-zoom-sweep: task duration 366ms 378ms +3% ⚠️ z=2.2
large-graph-idle: task duration 691ms 656ms -5% ⚠️ z=2.1
large-graph-pan: task duration 1284ms 1266ms -1% ⚠️ z=4.3
minimap-idle: task duration 683ms 658ms -4% ⚠️ z=2.8
subgraph-idle: task duration 444ms 504ms +13% ⚠️ z=4.3
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.4
canvas-idle: p95 frame time 17ms 17ms +0% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 7ms -20% z=-4.0
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 10 -5% z=-2.9
canvas-idle: task duration 507ms 551ms +9% ⚠️ z=5.0
canvas-idle: script duration 18ms 18ms -4% z=-3.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 68.3 MB 44.0 MB -36% —
canvas-idle: DOM nodes 20 -127 -733% z=-116.9
canvas-idle: event listeners 4 -147 -3775% z=-33.5
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 3ms 3ms -0% z=-0.6
canvas-mouse-sweep: style recalc duration 39ms 33ms -15% z=-3.0
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 74 73 -2% z=-2.6
canvas-mouse-sweep: task duration 859ms 843ms -2% z=-0.4
canvas-mouse-sweep: script duration 125ms 108ms -14% z=-4.3
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 49.3 MB 49.5 MB +0% —
canvas-mouse-sweep: DOM nodes -273 -274 +0% z=-129.8
canvas-mouse-sweep: event listeners -148 -148 +0% z=-37.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-1.1
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% —
canvas-zoom-sweep: layout duration 1ms 1ms -0% z=-0.4
canvas-zoom-sweep: style recalc duration 18ms 15ms -12% z=-2.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 -2% z=-1.7
canvas-zoom-sweep: task duration 366ms 378ms +3% ⚠️ z=2.2
canvas-zoom-sweep: script duration 19ms 18ms -1% z=-2.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 71.7 MB 71.8 MB +0% —
canvas-zoom-sweep: DOM nodes 78 77 -1% z=-2.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.2
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 7ms +2% z=-3.5
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 10 12 +15% z=-3.2
dom-widget-clipping: task duration 371ms 369ms -1% z=0.3
dom-widget-clipping: script duration 57ms 52ms -9% z=-4.8
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 53.2 MB 53.3 MB +0% —
dom-widget-clipping: DOM nodes 16 19 +19% z=-2.2
dom-widget-clipping: event listeners 2 0 -100% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms -1% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 9ms 6ms -27% z=-5.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 8 -11% z=-11.5
large-graph-idle: task duration 691ms 656ms -5% ⚠️ z=2.1
large-graph-idle: script duration 113ms 90ms -20% z=-1.2
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 62.6 MB 62.2 MB -1% —
large-graph-idle: DOM nodes -276 -276 -0% z=-332.1
large-graph-idle: event listeners -144 -144 +0% z=-27.9
large-graph-pan: avg frame time 17ms 17ms +0% z=1.3
large-graph-pan: p95 frame time 17ms 17ms -1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 14ms 15ms +9% z=-2.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 68 70 +2% z=-0.1
large-graph-pan: task duration 1284ms 1266ms -1% ⚠️ z=4.3
large-graph-pan: script duration 431ms 428ms -1% z=1.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 61.7 MB 62.8 MB +2% —
large-graph-pan: DOM nodes -278 -276 -1% z=-178.5
large-graph-pan: event listeners -144 -143 -1% z=-178.6
large-graph-zoom: avg frame time 17ms 17ms -0% —
large-graph-zoom: p95 frame time 17ms 17ms +0% —
large-graph-zoom: layout duration 7ms 8ms +6% —
large-graph-zoom: style recalc duration 14ms 15ms +0% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 66 +1% —
large-graph-zoom: task duration 1509ms 1442ms -4% —
large-graph-zoom: script duration 536ms 504ms -6% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 60.3 MB 53.7 MB -11% —
large-graph-zoom: DOM nodes -281 -281 -0% —
large-graph-zoom: event listeners -148 -148 +0% —
minimap-idle: avg frame time 17ms 17ms +0% z=-0.4
minimap-idle: p95 frame time 17ms 17ms +0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 8ms 7ms -17% z=-3.4
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 9 9 -6% z=-1.6
minimap-idle: task duration 683ms 658ms -4% ⚠️ z=2.8
minimap-idle: script duration 113ms 92ms -18% z=-0.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 63.9 MB 64.5 MB +1% —
minimap-idle: DOM nodes -278 -275 -1% z=-214.7
minimap-idle: event listeners -144 -144 +0% z=-225.0
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 10ms 10ms +1% z=-2.8
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=-0.8
subgraph-dom-widget-clipping: task duration 401ms 391ms -2% z=0.7
subgraph-dom-widget-clipping: script duration 120ms 120ms +0% z=-1.3
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 53.6 MB 53.3 MB -1% —
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=-1.1
subgraph-dom-widget-clipping: event listeners 6 6 +0% z=-1.7
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.2
subgraph-idle: p95 frame time 17ms 17ms +0% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 8ms -1% z=-2.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 -5% z=-2.1
subgraph-idle: task duration 444ms 504ms +13% ⚠️ z=4.3
subgraph-idle: script duration 13ms 13ms -1% z=-2.6
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 68.2 MB 44.7 MB -35% —
subgraph-idle: DOM nodes 20 -273 -1465% z=-197.2
subgraph-idle: event listeners 4 -148 -3800% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms -0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -0% —
subgraph-mouse-sweep: layout duration 4ms 4ms -3% z=-3.0
subgraph-mouse-sweep: style recalc duration 38ms 33ms -13% z=-2.9
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=-1.1
subgraph-mouse-sweep: task duration 795ms 747ms -6% z=-0.3
subgraph-mouse-sweep: script duration 91ms 79ms -13% z=-3.3
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 44.1 MB 44.4 MB +1% —
subgraph-mouse-sweep: DOM nodes 63 -105 -266% z=-76.7
subgraph-mouse-sweep: event listeners -148 -148 +0% variance too high
subgraph-transition-enter: avg frame time 17ms 17ms +0% —
subgraph-transition-enter: p95 frame time 17ms 17ms +0% —
subgraph-transition-enter: layout duration 13ms 11ms -11% —
subgraph-transition-enter: style recalc duration 30ms 28ms -5% —
subgraph-transition-enter: layout count 15 15 +0% —
subgraph-transition-enter: style recalc count 19 19 +0% —
subgraph-transition-enter: task duration 914ms 914ms +0% —
subgraph-transition-enter: script duration 34ms 32ms -5% —
subgraph-transition-enter: TBT 135ms 115ms -15% —
subgraph-transition-enter: heap used 92.3 MB 93.0 MB +1% —
subgraph-transition-enter: DOM nodes 13673 13673 +0% —
subgraph-transition-enter: event listeners 2371 2371 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +0% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 36ms 38ms +6% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 249 250 +0% —
viewport-pan-sweep: task duration 4403ms 4172ms -5% —
viewport-pan-sweep: script duration 1376ms 1248ms -9% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 63.6 MB 62.1 MB -2% —
viewport-pan-sweep: DOM nodes -275 -274 -0% —
viewport-pan-sweep: event listeners -128 -128 +0% —
vue-large-graph-idle: avg frame time 18ms 18ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17346ms 17318ms -0% —
vue-large-graph-idle: script duration 583ms 536ms -8% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 159.4 MB 159.0 MB -0% —
vue-large-graph-idle: DOM nodes -8312 -8312 +0% —
vue-large-graph-idle: event listeners -16386 -16388 +0% —
vue-large-graph-pan: avg frame time 18ms 18ms -3% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 19ms 18ms -3% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 143 144 +1% —
vue-large-graph-pan: task duration 21036ms 20879ms -1% —
vue-large-graph-pan: script duration 890ms 862ms -3% —
vue-large-graph-pan: TBT 295ms 235ms -20% —
vue-large-graph-pan: heap used 170.5 MB 159.0 MB -7% —
vue-large-graph-pan: DOM nodes -8312 -8312 +0% —
vue-large-graph-pan: event listeners -16383 -16381 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.1
workflow-execution: p95 frame time 17ms 17ms +1% —
workflow-execution: layout duration 1ms 1ms +44% z=-4.2
workflow-execution: style recalc duration 21ms 19ms -10% z=-2.3
workflow-execution: layout count 3 3 +0% z=-3.6
workflow-execution: style recalc count 14 16 +14% z=-0.9
workflow-execution: task duration 118ms 113ms -4% z=-0.9
workflow-execution: script duration 12ms 9ms -24% z=-6.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 48.7 MB 48.8 MB +0% —
workflow-execution: DOM nodes 121 137 +13% z=-3.4
workflow-execution: event listeners 65 65 +0% z=3.0
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-07-29T22:07:09.660Z",
  "gitSha": "c2d77b34352081a8b061fdaeecbf602607d19f70",
  "branch": "jaewon/subscription-pricing-popover-reka",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2130.696999999998,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.924000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.506,
      "heapDeltaBytes": -22558344,
      "heapUsedBytes": 45584256,
      "domNodes": 18,
      "jsHeapTotalBytes": 20967424,
      "scriptDurationMs": 20.225000000000005,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2044.2820000000097,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.667999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.308,
      "heapDeltaBytes": -21299220,
      "heapUsedBytes": 46674536,
      "domNodes": -271,
      "jsHeapTotalBytes": 20180992,
      "scriptDurationMs": 15.1,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1790.253999999976,
      "styleRecalcs": 72,
      "styleRecalcDurationMs": 33.71300000000001,
      "layouts": 12,
      "layoutDurationMs": 3.5319999999999996,
      "taskDurationMs": 846.846,
      "heapDeltaBytes": -14219036,
      "heapUsedBytes": 53739488,
      "domNodes": -275,
      "jsHeapTotalBytes": 20967424,
      "scriptDurationMs": 107.229,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1803.9719999999875,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 32.717000000000006,
      "layouts": 12,
      "layoutDurationMs": 3.4459999999999993,
      "taskDurationMs": 839.745,
      "heapDeltaBytes": -18095556,
      "heapUsedBytes": 49988912,
      "domNodes": -272,
      "jsHeapTotalBytes": 19918848,
      "scriptDurationMs": 108.001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1724.176,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.706999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.5569999999999999,
      "taskDurationMs": 371.40399999999994,
      "heapDeltaBytes": 7226668,
      "heapUsedBytes": 75229148,
      "domNodes": 77,
      "jsHeapTotalBytes": 20316160,
      "scriptDurationMs": 18.852999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1755.4379999999128,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.232,
      "layouts": 6,
      "layoutDurationMs": 0.696,
      "taskDurationMs": 383.899,
      "heapDeltaBytes": 7369840,
      "heapUsedBytes": 75250872,
      "domNodes": 77,
      "jsHeapTotalBytes": 20054016,
      "scriptDurationMs": 17.942,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 593.3990000000051,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.9670000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.651,
      "heapDeltaBytes": -12067392,
      "heapUsedBytes": 55811872,
      "domNodes": 18,
      "jsHeapTotalBytes": 21102592,
      "scriptDurationMs": 52.78099999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 594.3129999999996,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.263000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.894,
      "heapDeltaBytes": -12188116,
      "heapUsedBytes": 55907976,
      "domNodes": 20,
      "jsHeapTotalBytes": 20840448,
      "scriptDurationMs": 51.54,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.947000000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.349999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.332,
      "heapDeltaBytes": 5831728,
      "heapUsedBytes": 64719424,
      "domNodes": -274,
      "jsHeapTotalBytes": 5046272,
      "scriptDurationMs": 91.174,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.2899999999981,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.396999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 656.169,
      "heapDeltaBytes": 6751576,
      "heapUsedBytes": 65692600,
      "domNodes": -277,
      "jsHeapTotalBytes": 5570560,
      "scriptDurationMs": 89.389,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2196.8689999999924,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 13.548999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1318.0939999999998,
      "heapDeltaBytes": 6401004,
      "heapUsedBytes": 66550728,
      "domNodes": -276,
      "jsHeapTotalBytes": 5251072,
      "scriptDurationMs": 465.34,
      "eventListeners": -142,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2162.8409999999576,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.012999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1213.831,
      "heapDeltaBytes": 3229088,
      "heapUsedBytes": 65219368,
      "domNodes": -275,
      "jsHeapTotalBytes": 4726784,
      "scriptDurationMs": 390.526,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.7349999999547,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 13.780000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.7940000000000005,
      "taskDurationMs": 1436.2119999999998,
      "heapDeltaBytes": -5594224,
      "heapUsedBytes": 56272660,
      "domNodes": -281,
      "jsHeapTotalBytes": 7667712,
      "scriptDurationMs": 497.96899999999994,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3147.184999999922,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 15.244,
      "layouts": 60,
      "layoutDurationMs": 7.733,
      "taskDurationMs": 1448.714,
      "heapDeltaBytes": -5212884,
      "heapUsedBytes": 56284496,
      "domNodes": -280,
      "jsHeapTotalBytes": 7929856,
      "scriptDurationMs": 509.086,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.1049999999968,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.585000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 655.6060000000001,
      "heapDeltaBytes": 7181988,
      "heapUsedBytes": 67578728,
      "domNodes": -275,
      "jsHeapTotalBytes": 4259840,
      "scriptDurationMs": 92.07100000000001,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2037.9060000000209,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.026000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.9529999999999,
      "heapDeltaBytes": 7217296,
      "heapUsedBytes": 67786480,
      "domNodes": -274,
      "jsHeapTotalBytes": 4259840,
      "scriptDurationMs": 92.01200000000001,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 597.3599999999806,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 10.401,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 394.74899999999997,
      "heapDeltaBytes": -12139220,
      "heapUsedBytes": 55894208,
      "domNodes": 22,
      "jsHeapTotalBytes": 22151168,
      "scriptDurationMs": 120.52799999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.9749999999904,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.815,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.12600000000003,
      "heapDeltaBytes": -12052388,
      "heapUsedBytes": 55896304,
      "domNodes": 20,
      "jsHeapTotalBytes": 21626880,
      "scriptDurationMs": 119.78300000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.4860000000103,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.971000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.4460000000001,
      "heapDeltaBytes": -21601916,
      "heapUsedBytes": 46286156,
      "domNodes": -273,
      "jsHeapTotalBytes": 20443136,
      "scriptDurationMs": 12.904,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2027.5640000000408,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.803,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 505.61599999999993,
      "heapDeltaBytes": -20754616,
      "heapUsedBytes": 47383876,
      "domNodes": -273,
      "jsHeapTotalBytes": 20443136,
      "scriptDurationMs": 13.714,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1730.6099999999844,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 32.505,
      "layouts": 16,
      "layoutDurationMs": 3.665,
      "taskDurationMs": 746.241,
      "heapDeltaBytes": -21443572,
      "heapUsedBytes": 46826824,
      "domNodes": -273,
      "jsHeapTotalBytes": 20180992,
      "scriptDurationMs": 79.521,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.733999999969,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.229,
      "layouts": 16,
      "layoutDurationMs": 3.7939999999999996,
      "taskDurationMs": 747.636,
      "heapDeltaBytes": -21836340,
      "heapUsedBytes": 46194824,
      "domNodes": 64,
      "jsHeapTotalBytes": 20443136,
      "scriptDurationMs": 78.74000000000001,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1368.0140000000165,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.340000000000003,
      "layouts": 15,
      "layoutDurationMs": 11.158999999999999,
      "taskDurationMs": 914.1169999999998,
      "heapDeltaBytes": 29149492,
      "heapUsedBytes": 97496536,
      "domNodes": 13673,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 32.14900000000001,
      "eventListeners": 2371,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8194.320000000005,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 38.219,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4165.548999999999,
      "heapDeltaBytes": 8719392,
      "heapUsedBytes": 69636052,
      "domNodes": -273,
      "jsHeapTotalBytes": 7086080,
      "scriptDurationMs": 1238.7820000000002,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8198.551999999949,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.308,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4178.037,
      "heapDeltaBytes": 1852316,
      "heapUsedBytes": 60657440,
      "domNodes": -275,
      "jsHeapTotalBytes": 7405568,
      "scriptDurationMs": 1257.3799999999999,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17307.851000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17286.742000000006,
      "heapDeltaBytes": -41440204,
      "heapUsedBytes": 165748188,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15405056,
      "scriptDurationMs": 530.771,
      "eventListeners": -16389,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17370.06299999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17349.979,
      "heapDeltaBytes": -40222520,
      "heapUsedBytes": 167680756,
      "domNodes": -8312,
      "jsHeapTotalBytes": -12783616,
      "scriptDurationMs": 540.774,
      "eventListeners": -16387,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20660.327999999994,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 17.377999999999975,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20614.882,
      "heapDeltaBytes": -42084096,
      "heapUsedBytes": 166855552,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15405056,
      "scriptDurationMs": 838.4509999999999,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 239,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21171.892999999953,
      "styleRecalcs": 149,
      "styleRecalcDurationMs": 19.049999999999983,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21143.426000000003,
      "heapDeltaBytes": -42152580,
      "heapUsedBytes": 166534568,
      "domNodes": -8312,
      "jsHeapTotalBytes": -15142912,
      "scriptDurationMs": 886.1569999999999,
      "eventListeners": -16381,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 454.3689999999856,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 20.992,
      "layouts": 3,
      "layoutDurationMs": 1.2060000000000002,
      "taskDurationMs": 116.32900000000001,
      "heapDeltaBytes": -15643436,
      "heapUsedBytes": 51406468,
      "domNodes": 154,
      "jsHeapTotalBytes": 7471104,
      "scriptDurationMs": 9.38,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.55600000001596,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 17.451,
      "layouts": 3,
      "layoutDurationMs": 0.672,
      "taskDurationMs": 110.499,
      "heapDeltaBytes": -16072480,
      "heapUsedBytes": 51022324,
      "domNodes": 119,
      "jsHeapTotalBytes": 7208960,
      "scriptDurationMs": 8.633999999999999,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Jul 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The cloud and workspace pricing tables replace manually toggled PrimeVue popovers with composed PopoverTrigger and PopoverContent components. Tests cover opening the help popovers and validating their text and links.

Changes

Pricing table popover migration

Layer / File(s) Summary
Cloud pricing table popover
src/platform/cloud/subscription/components/PricingTable.vue, src/platform/cloud/subscription/components/PricingTable.test.ts
The video estimate help UI uses composed popover components, obsolete refs and toggle logic are removed, and tests cover the opened content and link.
Workspace pricing table popover
src/platform/workspace/components/PricingTableWorkspace.vue, src/platform/workspace/components/PricingTableWorkspace.test.ts
The workspace help UI uses composed popover components, imperative controls are removed, and a test suite validates the opened content and link.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: cloud/1.45, cloud/1.47

Suggested reviewers: christian-byrne


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❓ Inconclusive PR title and commit subjects aren’t provided, so the required bug-fix signal can’t be verified from the available metadata. Please provide the PR title and commit subjects (or the base...head commit list) so I can determine whether the bug-fix gate applies.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: migrating pricing table help popovers to Reka.
Description check ✅ Passed The description covers the required summary, changes, and review focus sections, with only optional screenshot/details omitted.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Adr Compliance For Entity/Litegraph Changes ✅ Passed Not applicable: the PR only changes subscription pricing table components/tests, not litegraph, ecs, or graph-entity files.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/subscription-pricing-popover-reka

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/subscription/components/PricingTable.vue`:
- Around line 179-216: Extract the duplicated video estimate help popover into a
shared VideoEstimateHelpPopover component, preserving its translations, styling,
trigger behavior, and external template link. Replace the inline block in
src/platform/cloud/subscription/components/PricingTable.vue lines 179-216 and
src/platform/workspace/components/PricingTableWorkspace.vue lines 194-231 with
the shared component, and ensure both PricingTable components import and render
it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f589285b-fb6b-4f3b-9b48-cc0dd3930a3d

📥 Commits

Reviewing files that changed from the base of the PR and between 1a98362 and d450728.

📒 Files selected for processing (3)
  • src/platform/cloud/subscription/components/PricingTable.test.ts
  • src/platform/cloud/subscription/components/PricingTable.vue
  • src/platform/workspace/components/PricingTableWorkspace.vue

Comment on lines +179 to +216
<Popover>
<PopoverTrigger as-child>
<button
type="button"
class="group flex cursor-pointer flex-row items-center gap-2 pt-2 text-left"
>
<i
class="pi pi-question-circle text-xs text-muted-foreground group-hover:text-base-foreground"
/>
<span
class="text-sm font-normal text-muted-foreground group-hover:text-base-foreground"
>
{{ t('subscription.videoEstimateHelp') }}
</span>
</button>
</PopoverTrigger>
<PopoverContent
align="start"
class="w-auto max-w-xs rounded-lg border border-interface-stroke bg-interface-panel-surface p-4 shadow-lg"
>
{{ t('subscription.videoEstimateHelp') }}
</span>
</div>
<div class="flex flex-col gap-2">
<p class="text-sm/normal text-base-foreground">
{{ t('subscription.videoEstimateExplanation') }}
</p>
<a
href="https://cloud.comfy.org/?template=video_wan2_2_14B_i2v"
target="_blank"
rel="noopener noreferrer"
class="flex gap-1 text-sm text-azure-600 no-underline hover:text-azure-400"
>
<span class="underline">
{{ t('subscription.videoEstimateTryTemplate') }}
</span>
<span class="no-underline" v-html="'&rarr;'"></span>
</a>
</div>
</PopoverContent>
</Popover>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value

Consider extracting this help popover into a shared component.

Both pricing tables implement the exact same popover structure, content, and external link for the video estimate help. Extracting this inline block into a shared component (e.g., VideoEstimateHelpPopover.vue) would reduce template duplication and ensure consistency if the explanation text or link changes in the future.

  • src/platform/cloud/subscription/components/PricingTable.vue#L179-L216: Replace this inline popover with the shared component.
  • src/platform/workspace/components/PricingTableWorkspace.vue#L194-L231: Replace this inline popover with the shared component.
📍 Affects 2 files
  • src/platform/cloud/subscription/components/PricingTable.vue#L179-L216 (this comment)
  • src/platform/workspace/components/PricingTableWorkspace.vue#L194-L231
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/cloud/subscription/components/PricingTable.vue` around lines 179
- 216, Extract the duplicated video estimate help popover into a shared
VideoEstimateHelpPopover component, preserving its translations, styling,
trigger behavior, and external template link. Replace the inline block in
src/platform/cloud/subscription/components/PricingTable.vue lines 179-216 and
src/platform/workspace/components/PricingTableWorkspace.vue lines 194-231 with
the shared component, and ensure both PricingTable components import and render
it.

@codecov

codecov Bot commented Jul 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #13642      +/-   ##
==========================================
- Coverage   78.20%   77.02%   -1.18%     
==========================================
  Files        1669     1695      +26     
  Lines       94321    99937    +5616     
  Branches    33279    35064    +1785     
==========================================
+ Hits        73763    76979    +3216     
- Misses      19928    22465    +2537     
+ Partials      630      493     -137     
Flag Coverage Δ
unit 68.08% <100.00%> (+1.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...orm/cloud/subscription/components/PricingTable.vue 94.37% <100.00%> (+0.58%) ⬆️
...orm/workspace/components/PricingTableWorkspace.vue 77.98% <100.00%> (+48.17%) ⬆️

... and 458 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall: solid migration direction — replacing the imperative PrimeVue popover with declarative Reka is the right call, and the span→button upgrade is a genuine a11y improvement. Found one issue that will cause a functional regression in production (z-index), a couple of a11y gaps, and some test coverage holes worth addressing before merge.

</button>
</PopoverTrigger>
<PopoverContent
align="start"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: PopoverContent inherits z-50 (z-index: 50) from PopoverContent.vue's base class. The cloud subscription dialog applies z-index: 1700 via v-reka-z-index. The popover portals to <body> with z-50, placing it behind the dialog overlay — it will be invisible and non-interactive for cloud-path users.

Fix: add z-[1800] (or an equivalent semantic token) to the class prop here, matching the pattern used by JobDetailsHoverPopover.vue:

<PopoverContent
  align="start"
  class="z-[1800] w-auto max-w-xs rounded-lg border border-interface-stroke bg-interface-panel-surface p-4 shadow-lg"
>

Same fix needed in PricingTableWorkspace.vue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still open and still anchored to live code (GitHub has not marked it outdated, so the hunk is unchanged since 2026-07-29). Keeping it — the z-index stacking is the one thing here that can make the popover unusable rather than just imperfect.

No rush from me. See the top-level note about whether this PR is still wanted.

target="_blank"
rel="noopener noreferrer"
class="flex gap-1 text-sm text-azure-600 no-underline hover:text-azure-400"
>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: text-azure-600 (#0b8ce9) on interface-panel-surface (white in light theme) gives a contrast ratio of ~3.53:1 — below the WCAG AA minimum of 4.5:1 for 14px normal-weight text. The hover state text-azure-400 is worse at ~2.24:1. Dark theme passes. A semantic token that resolves to a darker shade on light backgrounds (azure-700/800 range) would fix both themes without needing dark:.

Same link in PricingTableWorkspace.vue has the same issue.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping this one. Worth saying that it is not really about your PR: text-azure-600 on the panel surface is on main today (PricingTable.vue:246), so the contrast ratio is a pre-existing problem your change carried along rather than introduced. Not a merge blocker for you.

If this PR is closed, the contrast issue should be filed separately rather than lost with it.

@dante01yoon
dante01yoon force-pushed the jaewon/subscription-pricing-popover-reka branch from ff599f5 to 4f619a6 Compare July 23, 2026 02:29

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/platform/cloud/subscription/components/PricingTable.test.ts`:
- Around line 517-534: Extend the popover interaction tests by activating each
trigger a second time and asserting the explanation content is no longer
visible. Update the test at
src/platform/cloud/subscription/components/PricingTable.test.ts lines 517-534
for the “How is this calculated?” trigger, and the test at
src/platform/workspace/components/PricingTableWorkspace.test.ts lines 74-101 for
the details trigger; preserve the existing open-state content assertions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c598987b-03d1-4822-beae-c712026b9bdd

📥 Commits

Reviewing files that changed from the base of the PR and between ff599f5 and 4f619a6.

📒 Files selected for processing (4)
  • src/platform/cloud/subscription/components/PricingTable.test.ts
  • src/platform/cloud/subscription/components/PricingTable.vue
  • src/platform/workspace/components/PricingTableWorkspace.test.ts
  • src/platform/workspace/components/PricingTableWorkspace.vue

Comment on lines +517 to +534
it('opens the video estimate help popover from its trigger', async () => {
const user = userEvent.setup()
renderComponent()

expect(
screen.queryByText('Based on average usage.')
).not.toBeInTheDocument()

await user.click(
screen.getAllByRole('button', { name: 'How is this calculated?' })[0]
)

expect(screen.getByText('Based on average usage.')).toBeInTheDocument()
expect(screen.getByRole('link', { name: 'Try template' })).toHaveAttribute(
'href',
'https://cloud.comfy.org/?template=video_wan2_2_14B_i2v'
)
})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Assert that a second trigger activation closes the popover.

Both tests verify opening only; add a second click and assert the explanation is removed so a broken close transition is caught.

  • src/platform/cloud/subscription/components/PricingTable.test.ts#L517-L534: Click the help trigger again and assert the explanation is absent.
  • src/platform/workspace/components/PricingTableWorkspace.test.ts#L74-L101: Click the details trigger again and assert the explanation is absent.

As per path instructions, popover tests should verify user-visible open/close behavior and rendered content.

📍 Affects 2 files
  • src/platform/cloud/subscription/components/PricingTable.test.ts#L517-L534 (this comment)
  • src/platform/workspace/components/PricingTableWorkspace.test.ts#L74-L101
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/platform/cloud/subscription/components/PricingTable.test.ts` around lines
517 - 534, Extend the popover interaction tests by activating each trigger a
second time and asserting the explanation content is no longer visible. Update
the test at src/platform/cloud/subscription/components/PricingTable.test.ts
lines 517-534 for the “How is this calculated?” trigger, and the test at
src/platform/workspace/components/PricingTableWorkspace.test.ts lines 74-101 for
the details trigger; preserve the existing open-state content assertions.

Source: Path instructions

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review — re-reviewed at head 4f619a6. The push after my previous review addressed every substantive point. Confirming here so a maintainer can move this forward.

✅ z-index regression (was the blocking issue) — z-1800 on PopoverContent is correct and does resolve. This is Tailwind v4, where bare z-<number> utilities generate a real z-index: KeybindingPanel.vue uses z-1800, DropdownMenu/JobDetailsHoverPopover use z-1700, and DropdownMenu.zindex.test.ts asserts the pattern. 1800 clears the cloud dialog's 1700 (applied via v-reka-z-index), so the portaled popover paints above the dialog overlay. Regression resolved.

  • Non-blocking follow-up: the codebase's canonical "lift above the modal stack" pattern is now the useModalLiftedZIndex composable (landed in #14054, also used by #14043), which handles arbitrary stack depth instead of a hardcoded constant. z-1800 is fine for this single-dialog-depth case and matches existing hardcoded usages, but converging on the composable later would be more robust.

✅ Other items from my last review, all addressed:

  • Decorative icon now has aria-hidden="true".
  • Trigger button now has a focus-visible ring.
  • Link contrast: text-azure-600 → text-muted-foreground, clearing the WCAG AA failure on light backgrounds.
  • v-html="'&rarr;'" → plain Unicode → with aria-hidden.
  • Tests: behavioral open assertions added, plus a new PricingTableWorkspace.test.ts. The conditional stubs now gate content on open state, so the trigger→content wiring is genuinely exercised.

CI is fully green.

Remaining is minor / non-blocking:

  • CodeRabbit's suggestion to also assert the popover closes on a second trigger click (nice-to-have; the stubs already support it).
  • CodeRabbit's optional extraction of the duplicated block into a shared VideoEstimateHelpPopover.vue (marked Trivial / low-value — reasonable to defer).

From my side the blocking concerns are cleared. Recommend resolving the outstanding threads and merging once a maintainer re-approves. Nice work on the migration.

@christian-byrne

Copy link
Copy Markdown
Contributor

Sweeping my own stale review threads, and this one needs a decision more than it needs another review round.

State: open since 2026-07-29, no pushes in fifty days, CONFLICTING against main, CI failing. I have just resolved seven of my nine threads here — they were all non-blocking and there is no reason they should have sat on you that long. That is my process failing, not yours: our sweep only surfaces PRs whose state changes, so a PR that goes quiet goes invisible. We have fixed the sweep.

The two I kept are the popover z-index stacking and the text-azure-600 contrast, and the second is really a main issue your change inherited.

The substantive question: this is still not superseded. main still imports primevue/popover in PricingTable.vue, so the migration this PR does has not landed by another route. But fifty days and a conflicting rebase against everything that has moved through the billing surface since (the account-core rename, billing-contract, the pricing-surface centralization in #16189) is a real cost to revive.

Three options and I am fine with any of them:

  1. Revive it — rebase, and I will re-review the whole thing fresh rather than making you answer July comments.
  2. Close it, and I file the popover migration and the contrast issue as standalone issues so neither is lost.
  3. Tell me it is parked deliberately and I will stop surfacing it.

Your call. If I do not hear anything I will assume (2) in about a week and file the issues myself so nothing drops.

@dante01yoon dante01yoon closed this Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants