Repository navigation
refactor(subscription): migrate pricing table help popovers to Reka - #13642
dante01yoon wants to merge 3 commits into
Conversation
🎭 Playwright: ❌ 1749 passed, 1 failed · 4 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 8.15 MB gzip 🔴 +23 BDetailsSummary
Category Glance App Entry Points — 3.66 kB (baseline 3.66 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.28 MB (baseline 1.28 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 112 kB (baseline 112 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 16 unchanged Panels & Settings — 551 kB (baseline 551 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 26 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 121 kB (baseline 121 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 6 unchanged UI Components — 64.8 kB (baseline 64.8 kB) • ⚪ 0 BReusable component library chunks Status: 14 unchanged Data & Services — 3.42 MB (baseline 3.42 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 371 kB (baseline 371 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 35 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.5 MB (baseline 12.5 MB) • 🔴 +495 BBundles that do not match a named category
Status: 3 added / 3 removed / 273 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-29T22:07:09.660Z",
"gitSha": "c2d77b34352081a8b061fdaeecbf602607d19f70",
"branch": "jaewon/subscription-pricing-popover-reka",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2130.696999999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.924000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.506,
"heapDeltaBytes": -22558344,
"heapUsedBytes": 45584256,
"domNodes": 18,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 20.225000000000005,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2044.2820000000097,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.667999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.308,
"heapDeltaBytes": -21299220,
"heapUsedBytes": 46674536,
"domNodes": -271,
"jsHeapTotalBytes": 20180992,
"scriptDurationMs": 15.1,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1790.253999999976,
"styleRecalcs": 72,
"styleRecalcDurationMs": 33.71300000000001,
"layouts": 12,
"layoutDurationMs": 3.5319999999999996,
"taskDurationMs": 846.846,
"heapDeltaBytes": -14219036,
"heapUsedBytes": 53739488,
"domNodes": -275,
"jsHeapTotalBytes": 20967424,
"scriptDurationMs": 107.229,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1803.9719999999875,
"styleRecalcs": 73,
"styleRecalcDurationMs": 32.717000000000006,
"layouts": 12,
"layoutDurationMs": 3.4459999999999993,
"taskDurationMs": 839.745,
"heapDeltaBytes": -18095556,
"heapUsedBytes": 49988912,
"domNodes": -272,
"jsHeapTotalBytes": 19918848,
"scriptDurationMs": 108.001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.176,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.706999999999999,
"layouts": 6,
"layoutDurationMs": 0.5569999999999999,
"taskDurationMs": 371.40399999999994,
"heapDeltaBytes": 7226668,
"heapUsedBytes": 75229148,
"domNodes": 77,
"jsHeapTotalBytes": 20316160,
"scriptDurationMs": 18.852999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.4379999999128,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.232,
"layouts": 6,
"layoutDurationMs": 0.696,
"taskDurationMs": 383.899,
"heapDeltaBytes": 7369840,
"heapUsedBytes": 75250872,
"domNodes": 77,
"jsHeapTotalBytes": 20054016,
"scriptDurationMs": 17.942,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 593.3990000000051,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.9670000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.651,
"heapDeltaBytes": -12067392,
"heapUsedBytes": 55811872,
"domNodes": 18,
"jsHeapTotalBytes": 21102592,
"scriptDurationMs": 52.78099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.3129999999996,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.263000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.894,
"heapDeltaBytes": -12188116,
"heapUsedBytes": 55907976,
"domNodes": 20,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 51.54,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2019.947000000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.349999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.332,
"heapDeltaBytes": 5831728,
"heapUsedBytes": 64719424,
"domNodes": -274,
"jsHeapTotalBytes": 5046272,
"scriptDurationMs": 91.174,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2022.2899999999981,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.396999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.169,
"heapDeltaBytes": 6751576,
"heapUsedBytes": 65692600,
"domNodes": -277,
"jsHeapTotalBytes": 5570560,
"scriptDurationMs": 89.389,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2196.8689999999924,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.548999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1318.0939999999998,
"heapDeltaBytes": 6401004,
"heapUsedBytes": 66550728,
"domNodes": -276,
"jsHeapTotalBytes": 5251072,
"scriptDurationMs": 465.34,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2162.8409999999576,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.012999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1213.831,
"heapDeltaBytes": 3229088,
"heapUsedBytes": 65219368,
"domNodes": -275,
"jsHeapTotalBytes": 4726784,
"scriptDurationMs": 390.526,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3147.7349999999547,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.780000000000001,
"layouts": 60,
"layoutDurationMs": 7.7940000000000005,
"taskDurationMs": 1436.2119999999998,
"heapDeltaBytes": -5594224,
"heapUsedBytes": 56272660,
"domNodes": -281,
"jsHeapTotalBytes": 7667712,
"scriptDurationMs": 497.96899999999994,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3147.184999999922,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.244,
"layouts": 60,
"layoutDurationMs": 7.733,
"taskDurationMs": 1448.714,
"heapDeltaBytes": -5212884,
"heapUsedBytes": 56284496,
"domNodes": -280,
"jsHeapTotalBytes": 7929856,
"scriptDurationMs": 509.086,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.1049999999968,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.585000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.6060000000001,
"heapDeltaBytes": 7181988,
"heapUsedBytes": 67578728,
"domNodes": -275,
"jsHeapTotalBytes": 4259840,
"scriptDurationMs": 92.07100000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.9060000000209,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.026000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 660.9529999999999,
"heapDeltaBytes": 7217296,
"heapUsedBytes": 67786480,
"domNodes": -274,
"jsHeapTotalBytes": 4259840,
"scriptDurationMs": 92.01200000000001,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.3599999999806,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.401,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.74899999999997,
"heapDeltaBytes": -12139220,
"heapUsedBytes": 55894208,
"domNodes": 22,
"jsHeapTotalBytes": 22151168,
"scriptDurationMs": 120.52799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.9749999999904,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.815,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.12600000000003,
"heapDeltaBytes": -12052388,
"heapUsedBytes": 55896304,
"domNodes": 20,
"jsHeapTotalBytes": 21626880,
"scriptDurationMs": 119.78300000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2027.4860000000103,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.971000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.4460000000001,
"heapDeltaBytes": -21601916,
"heapUsedBytes": 46286156,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 12.904,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2027.5640000000408,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.61599999999993,
"heapDeltaBytes": -20754616,
"heapUsedBytes": 47383876,
"domNodes": -273,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 13.714,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.6099999999844,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.505,
"layouts": 16,
"layoutDurationMs": 3.665,
"taskDurationMs": 746.241,
"heapDeltaBytes": -21443572,
"heapUsedBytes": 46826824,
"domNodes": -273,
"jsHeapTotalBytes": 20180992,
"scriptDurationMs": 79.521,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.733999999969,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.229,
"layouts": 16,
"layoutDurationMs": 3.7939999999999996,
"taskDurationMs": 747.636,
"heapDeltaBytes": -21836340,
"heapUsedBytes": 46194824,
"domNodes": 64,
"jsHeapTotalBytes": 20443136,
"scriptDurationMs": 78.74000000000001,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.0140000000165,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.340000000000003,
"layouts": 15,
"layoutDurationMs": 11.158999999999999,
"taskDurationMs": 914.1169999999998,
"heapDeltaBytes": 29149492,
"heapUsedBytes": 97496536,
"domNodes": 13673,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 32.14900000000001,
"eventListeners": 2371,
"totalBlockingTimeMs": 115,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8194.320000000005,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4165.548999999999,
"heapDeltaBytes": 8719392,
"heapUsedBytes": 69636052,
"domNodes": -273,
"jsHeapTotalBytes": 7086080,
"scriptDurationMs": 1238.7820000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8198.551999999949,
"styleRecalcs": 249,
"styleRecalcDurationMs": 38.308,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4178.037,
"heapDeltaBytes": 1852316,
"heapUsedBytes": 60657440,
"domNodes": -275,
"jsHeapTotalBytes": 7405568,
"scriptDurationMs": 1257.3799999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17307.851000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17286.742000000006,
"heapDeltaBytes": -41440204,
"heapUsedBytes": 165748188,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 530.771,
"eventListeners": -16389,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17370.06299999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17349.979,
"heapDeltaBytes": -40222520,
"heapUsedBytes": 167680756,
"domNodes": -8312,
"jsHeapTotalBytes": -12783616,
"scriptDurationMs": 540.774,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20660.327999999994,
"styleRecalcs": 139,
"styleRecalcDurationMs": 17.377999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20614.882,
"heapDeltaBytes": -42084096,
"heapUsedBytes": 166855552,
"domNodes": -8312,
"jsHeapTotalBytes": -15405056,
"scriptDurationMs": 838.4509999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 239,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21171.892999999953,
"styleRecalcs": 149,
"styleRecalcDurationMs": 19.049999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21143.426000000003,
"heapDeltaBytes": -42152580,
"heapUsedBytes": 166534568,
"domNodes": -8312,
"jsHeapTotalBytes": -15142912,
"scriptDurationMs": 886.1569999999999,
"eventListeners": -16381,
"totalBlockingTimeMs": 231,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 454.3689999999856,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.992,
"layouts": 3,
"layoutDurationMs": 1.2060000000000002,
"taskDurationMs": 116.32900000000001,
"heapDeltaBytes": -15643436,
"heapUsedBytes": 51406468,
"domNodes": 154,
"jsHeapTotalBytes": 7471104,
"scriptDurationMs": 9.38,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 464.55600000001596,
"styleRecalcs": 13,
"styleRecalcDurationMs": 17.451,
"layouts": 3,
"layoutDurationMs": 0.672,
"taskDurationMs": 110.499,
"heapDeltaBytes": -16072480,
"heapUsedBytes": 51022324,
"domNodes": 119,
"jsHeapTotalBytes": 7208960,
"scriptDurationMs": 8.633999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
📝 WalkthroughWalkthroughThe cloud and workspace pricing tables replace manually toggled PrimeVue popovers with composed ChangesPricing table popover migration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/subscription/components/PricingTable.vue`:
- Around line 179-216: Extract the duplicated video estimate help popover into a
shared VideoEstimateHelpPopover component, preserving its translations, styling,
trigger behavior, and external template link. Replace the inline block in
src/platform/cloud/subscription/components/PricingTable.vue lines 179-216 and
src/platform/workspace/components/PricingTableWorkspace.vue lines 194-231 with
the shared component, and ensure both PricingTable components import and render
it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f589285b-fb6b-4f3b-9b48-cc0dd3930a3d
📒 Files selected for processing (3)
src/platform/cloud/subscription/components/PricingTable.test.tssrc/platform/cloud/subscription/components/PricingTable.vuesrc/platform/workspace/components/PricingTableWorkspace.vue
| <Popover> | ||
| <PopoverTrigger as-child> | ||
| <button | ||
| type="button" | ||
| class="group flex cursor-pointer flex-row items-center gap-2 pt-2 text-left" | ||
| > | ||
| <i | ||
| class="pi pi-question-circle text-xs text-muted-foreground group-hover:text-base-foreground" | ||
| /> | ||
| <span | ||
| class="text-sm font-normal text-muted-foreground group-hover:text-base-foreground" | ||
| > | ||
| {{ t('subscription.videoEstimateHelp') }} | ||
| </span> | ||
| </button> | ||
| </PopoverTrigger> | ||
| <PopoverContent | ||
| align="start" | ||
| class="w-auto max-w-xs rounded-lg border border-interface-stroke bg-interface-panel-surface p-4 shadow-lg" | ||
| > | ||
| {{ t('subscription.videoEstimateHelp') }} | ||
| </span> | ||
| </div> | ||
| <div class="flex flex-col gap-2"> | ||
| <p class="text-sm/normal text-base-foreground"> | ||
| {{ t('subscription.videoEstimateExplanation') }} | ||
| </p> | ||
| <a | ||
| href="https://cloud.comfy.org/?template=video_wan2_2_14B_i2v" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| class="flex gap-1 text-sm text-azure-600 no-underline hover:text-azure-400" | ||
| > | ||
| <span class="underline"> | ||
| {{ t('subscription.videoEstimateTryTemplate') }} | ||
| </span> | ||
| <span class="no-underline" v-html="'→'"></span> | ||
| </a> | ||
| </div> | ||
| </PopoverContent> | ||
| </Popover> |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low value
Consider extracting this help popover into a shared component.
Both pricing tables implement the exact same popover structure, content, and external link for the video estimate help. Extracting this inline block into a shared component (e.g., VideoEstimateHelpPopover.vue) would reduce template duplication and ensure consistency if the explanation text or link changes in the future.
src/platform/cloud/subscription/components/PricingTable.vue#L179-L216: Replace this inline popover with the shared component.src/platform/workspace/components/PricingTableWorkspace.vue#L194-L231: Replace this inline popover with the shared component.
📍 Affects 2 files
src/platform/cloud/subscription/components/PricingTable.vue#L179-L216(this comment)src/platform/workspace/components/PricingTableWorkspace.vue#L194-L231
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/subscription/components/PricingTable.vue` around lines 179
- 216, Extract the duplicated video estimate help popover into a shared
VideoEstimateHelpPopover component, preserving its translations, styling,
trigger behavior, and external template link. Replace the inline block in
src/platform/cloud/subscription/components/PricingTable.vue lines 179-216 and
src/platform/workspace/components/PricingTableWorkspace.vue lines 194-231 with
the shared component, and ensure both PricingTable components import and render
it.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13642 +/- ##
==========================================
- Coverage 78.20% 77.02% -1.18%
==========================================
Files 1669 1695 +26
Lines 94321 99937 +5616
Branches 33279 35064 +1785
==========================================
+ Hits 73763 76979 +3216
- Misses 19928 22465 +2537
+ Partials 630 493 -137
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 458 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Overall: solid migration direction — replacing the imperative PrimeVue popover with declarative Reka is the right call, and the span→button upgrade is a genuine a11y improvement. Found one issue that will cause a functional regression in production (z-index), a couple of a11y gaps, and some test coverage holes worth addressing before merge.
| </button> | ||
| </PopoverTrigger> | ||
| <PopoverContent | ||
| align="start" |
There was a problem hiding this comment.
issue: PopoverContent inherits z-50 (z-index: 50) from PopoverContent.vue's base class. The cloud subscription dialog applies z-index: 1700 via v-reka-z-index. The popover portals to <body> with z-50, placing it behind the dialog overlay — it will be invisible and non-interactive for cloud-path users.
Fix: add z-[1800] (or an equivalent semantic token) to the class prop here, matching the pattern used by JobDetailsHoverPopover.vue:
<PopoverContent
align="start"
class="z-[1800] w-auto max-w-xs rounded-lg border border-interface-stroke bg-interface-panel-surface p-4 shadow-lg"
>Same fix needed in PricingTableWorkspace.vue.
There was a problem hiding this comment.
Still open and still anchored to live code (GitHub has not marked it outdated, so the hunk is unchanged since 2026-07-29). Keeping it — the z-index stacking is the one thing here that can make the popover unusable rather than just imperfect.
No rush from me. See the top-level note about whether this PR is still wanted.
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| class="flex gap-1 text-sm text-azure-600 no-underline hover:text-azure-400" | ||
| > |
There was a problem hiding this comment.
issue: text-azure-600 (#0b8ce9) on interface-panel-surface (white in light theme) gives a contrast ratio of ~3.53:1 — below the WCAG AA minimum of 4.5:1 for 14px normal-weight text. The hover state text-azure-400 is worse at ~2.24:1. Dark theme passes. A semantic token that resolves to a darker shade on light backgrounds (azure-700/800 range) would fix both themes without needing dark:.
Same link in PricingTableWorkspace.vue has the same issue.
There was a problem hiding this comment.
Keeping this one. Worth saying that it is not really about your PR: text-azure-600 on the panel surface is on main today (PricingTable.vue:246), so the contrast ratio is a pre-existing problem your change carried along rather than introduced. Not a merge blocker for you.
If this PR is closed, the contrast issue should be filed separately rather than lost with it.
ff599f5 to
4f619a6
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/cloud/subscription/components/PricingTable.test.ts`:
- Around line 517-534: Extend the popover interaction tests by activating each
trigger a second time and asserting the explanation content is no longer
visible. Update the test at
src/platform/cloud/subscription/components/PricingTable.test.ts lines 517-534
for the “How is this calculated?” trigger, and the test at
src/platform/workspace/components/PricingTableWorkspace.test.ts lines 74-101 for
the details trigger; preserve the existing open-state content assertions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: c598987b-03d1-4822-beae-c712026b9bdd
📒 Files selected for processing (4)
src/platform/cloud/subscription/components/PricingTable.test.tssrc/platform/cloud/subscription/components/PricingTable.vuesrc/platform/workspace/components/PricingTableWorkspace.test.tssrc/platform/workspace/components/PricingTableWorkspace.vue
| it('opens the video estimate help popover from its trigger', async () => { | ||
| const user = userEvent.setup() | ||
| renderComponent() | ||
|
|
||
| expect( | ||
| screen.queryByText('Based on average usage.') | ||
| ).not.toBeInTheDocument() | ||
|
|
||
| await user.click( | ||
| screen.getAllByRole('button', { name: 'How is this calculated?' })[0] | ||
| ) | ||
|
|
||
| expect(screen.getByText('Based on average usage.')).toBeInTheDocument() | ||
| expect(screen.getByRole('link', { name: 'Try template' })).toHaveAttribute( | ||
| 'href', | ||
| 'https://cloud.comfy.org/?template=video_wan2_2_14B_i2v' | ||
| ) | ||
| }) |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Assert that a second trigger activation closes the popover.
Both tests verify opening only; add a second click and assert the explanation is removed so a broken close transition is caught.
src/platform/cloud/subscription/components/PricingTable.test.ts#L517-L534: Click the help trigger again and assert the explanation is absent.src/platform/workspace/components/PricingTableWorkspace.test.ts#L74-L101: Click the details trigger again and assert the explanation is absent.
As per path instructions, popover tests should verify user-visible open/close behavior and rendered content.
📍 Affects 2 files
src/platform/cloud/subscription/components/PricingTable.test.ts#L517-L534(this comment)src/platform/workspace/components/PricingTableWorkspace.test.ts#L74-L101
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/platform/cloud/subscription/components/PricingTable.test.ts` around lines
517 - 534, Extend the popover interaction tests by activating each trigger a
second time and asserting the explanation content is no longer visible. Update
the test at src/platform/cloud/subscription/components/PricingTable.test.ts
lines 517-534 for the “How is this calculated?” trigger, and the test at
src/platform/workspace/components/PricingTableWorkspace.test.ts lines 74-101 for
the details trigger; preserve the existing open-state content assertions.
Source: Path instructions
christian-byrne
left a comment
There was a problem hiding this comment.
Follow-up review — re-reviewed at head 4f619a6. The push after my previous review addressed every substantive point. Confirming here so a maintainer can move this forward.
✅ z-index regression (was the blocking issue) — z-1800 on PopoverContent is correct and does resolve. This is Tailwind v4, where bare z-<number> utilities generate a real z-index: KeybindingPanel.vue uses z-1800, DropdownMenu/JobDetailsHoverPopover use z-1700, and DropdownMenu.zindex.test.ts asserts the pattern. 1800 clears the cloud dialog's 1700 (applied via v-reka-z-index), so the portaled popover paints above the dialog overlay. Regression resolved.
- Non-blocking follow-up: the codebase's canonical "lift above the modal stack" pattern is now the
useModalLiftedZIndexcomposable (landed in #14054, also used by #14043), which handles arbitrary stack depth instead of a hardcoded constant.z-1800is fine for this single-dialog-depth case and matches existing hardcoded usages, but converging on the composable later would be more robust.
✅ Other items from my last review, all addressed:
- Decorative icon now has
aria-hidden="true". - Trigger button now has a
focus-visiblering. - Link contrast:
text-azure-600→text-muted-foreground, clearing the WCAG AA failure on light backgrounds. v-html="'→'"→ plain Unicode→witharia-hidden.- Tests: behavioral open assertions added, plus a new
PricingTableWorkspace.test.ts. The conditional stubs now gate content on open state, so the trigger→content wiring is genuinely exercised.
CI is fully green.
Remaining is minor / non-blocking:
- CodeRabbit's suggestion to also assert the popover closes on a second trigger click (nice-to-have; the stubs already support it).
- CodeRabbit's optional extraction of the duplicated block into a shared
VideoEstimateHelpPopover.vue(marked Trivial / low-value — reasonable to defer).
From my side the blocking concerns are cleared. Recommend resolving the outstanding threads and merging once a maintainer re-approves. Nice work on the migration.
|
Sweeping my own stale review threads, and this one needs a decision more than it needs another review round. State: open since 2026-07-29, no pushes in fifty days, The two I kept are the popover z-index stacking and the The substantive question: this is still not superseded. Three options and I am fine with any of them:
Your call. If I do not hear anything I will assume (2) in about a week and file the issues myself so nothing drops. |
Summary
Migrate the "video estimate" help popover in both legacy pricing tables from
primevue/popoverto the Rekaui/popoverprimitive — removing PrimeVue from these components and unblocking the Subscription container'smodal: truerestoration (#13558).Changes
PricingTableWorkspace.vueandPricingTable.vuereplace the single body-teleported<Popover ref>+ imperativetogglePopover(event)with a per-tier declarative<Popover><PopoverTrigger as-child><PopoverContent>(Reka). The trigger is now a real<button>(keyboard-focusable, Reka wiresaria-haspopup/aria-expanded); the content is unchanged (explanation + "try template" link).primevue/popover, thepopoverref, andtogglePopoverfrom both files.Popoverstub inPricingTable.test.tsto also stubPopoverTrigger/PopoverContent(the Reka subcomponents need aPopoverRootcontext the old single stub didn't provide).Review Focus
DismissableLayerand works under bothmodal: false(today's legacy-workspace path) andmodal: true. The PrimeVue popover was the one body-teleported overlay blocking the Subscriptionmodal: trueflip; with it gone, the flip becomes a one-line follow-up. It also fixes a latent bug on the fully-legacy path (useSubscriptionDialog.tsrenders itmodal: truetoday, under which the old PrimeVue popover's "try template" link was pointer-dead) — the Reka popover works there now.typecheck,eslint,oxfmt, and 56 subscription unit tests (PricingTable.test.ts,SubscriptionPanelContentWorkspace.test.ts,useSubscriptionDialog.test.ts). Interactive/visual verification (popover opens on the help click, positions under the trigger, dismisses on outside-click/Escape) is still pending — there's no Storybook story for these two tables, so it's best checked in the cloud Subscription dialog; flagging rather than claiming it.SelectButton(billing-cycle toggle) stays PrimeVue; themodal: trueflip and thesm:max-w-7xlsizing idiom are separate follow-ups (the latter tracked on fix(subscription): size pricing dialogs with Reka props #13633).