Repository navigation
Conversation
|
Important Review skippedToo many files! This PR contains 290 files, which is 140 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (290)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1683 passed, 0 failed · 6 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.77 MB gzip 🔴 +146 BDetailsSummary
Category Glance App Entry Points — 47.4 kB (baseline 47.4 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.26 MB (baseline 1.26 MB) • 🔴 +4 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 98 kB (baseline 98 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.5 kB (baseline 57.5 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.37 MB (baseline 3.37 MB) • 🔴 +85 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 67 added / 67 removed / 98 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-05T06:27:54.867Z",
"gitSha": "c6e2cd259b0327efa8b561efef08f203fd68034f",
"branch": "codex/coverage-consolidated",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2039.7419999999897,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.57,
"heapDeltaBytes": -1373832,
"heapUsedBytes": 57385612,
"domNodes": 20,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 22.642000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2033.284999999978,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.259999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.45,
"heapDeltaBytes": -1558508,
"heapUsedBytes": 50740612,
"domNodes": -291,
"jsHeapTotalBytes": 17428480,
"scriptDurationMs": 14.296999999999997,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1984.0209999999843,
"styleRecalcs": 77,
"styleRecalcDurationMs": 45.75600000000001,
"layouts": 12,
"layoutDurationMs": 3.8240000000000003,
"taskDurationMs": 934.8649999999999,
"heapDeltaBytes": -5630300,
"heapUsedBytes": 55471224,
"domNodes": 58,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 142.77,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.9769999999962,
"styleRecalcs": 74,
"styleRecalcDurationMs": 34.119,
"layouts": 12,
"layoutDurationMs": 3.242,
"taskDurationMs": 754.4380000000001,
"heapDeltaBytes": -7028308,
"heapUsedBytes": 51996820,
"domNodes": 56,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 119.00200000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.5779999999986,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.448999999999998,
"layouts": 6,
"layoutDurationMs": 0.7040000000000002,
"taskDurationMs": 332.77099999999996,
"heapDeltaBytes": 3360408,
"heapUsedBytes": 55184544,
"domNodes": -239,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 18.481,
"eventListeners": -186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1744.5739999999432,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.645,
"layouts": 6,
"layoutDurationMs": 0.7509999999999999,
"taskDurationMs": 420.58899999999994,
"heapDeltaBytes": -3701848,
"heapUsedBytes": 65788176,
"domNodes": -227,
"jsHeapTotalBytes": 12210176,
"scriptDurationMs": 28.738,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 589.6360000000413,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 379.338,
"heapDeltaBytes": -4848684,
"heapUsedBytes": 47029308,
"domNodes": -266,
"jsHeapTotalBytes": 1175552,
"scriptDurationMs": 58.722,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 594.0879999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.532000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 377.32699999999994,
"heapDeltaBytes": 3492508,
"heapUsedBytes": 72979996,
"domNodes": -281,
"jsHeapTotalBytes": 6967296,
"scriptDurationMs": 54.348,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.7350000000074,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.435,
"heapDeltaBytes": -9371792,
"heapUsedBytes": 57490440,
"domNodes": -269,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 89.964,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2000.8639999999787,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.344000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.40500000000003,
"heapDeltaBytes": 10947500,
"heapUsedBytes": 70039116,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 86.649,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2137.9870000000096,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.119999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1117.0120000000002,
"heapDeltaBytes": 11908040,
"heapUsedBytes": 85878036,
"domNodes": 18,
"jsHeapTotalBytes": 10805248,
"scriptDurationMs": 395.96700000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2147.0800000000168,
"styleRecalcs": 70,
"styleRecalcDurationMs": 19.299999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1130.455,
"heapDeltaBytes": 11980052,
"heapUsedBytes": 85186460,
"domNodes": 18,
"jsHeapTotalBytes": 12115968,
"scriptDurationMs": 416.62399999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3068.993999999975,
"styleRecalcs": 64,
"styleRecalcDurationMs": 16.353,
"layouts": 60,
"layoutDurationMs": 6.968999999999999,
"taskDurationMs": 1239.8419999999999,
"heapDeltaBytes": 13502848,
"heapUsedBytes": 66568508,
"domNodes": -281,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 470.263,
"eventListeners": -195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3085.1630000000796,
"styleRecalcs": 63,
"styleRecalcDurationMs": 16.133000000000003,
"layouts": 60,
"layoutDurationMs": 7.2540000000000004,
"taskDurationMs": 1271.211,
"heapDeltaBytes": 11738116,
"heapUsedBytes": 66316640,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 479.241,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2027.5550000000067,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.764,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.9809999999999,
"heapDeltaBytes": -9559236,
"heapUsedBytes": 59291992,
"domNodes": -269,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 87.622,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2012.3689999999215,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.805999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.9069999999999,
"heapDeltaBytes": 6591760,
"heapUsedBytes": 60576836,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.206,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 603.7200000000098,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.856,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.482,
"heapDeltaBytes": -22626448,
"heapUsedBytes": 46740968,
"domNodes": -274,
"jsHeapTotalBytes": 6180864,
"scriptDurationMs": 118.40900000000002,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.3499999999767,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.639000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.19800000000004,
"heapDeltaBytes": -2673064,
"heapUsedBytes": 49627420,
"domNodes": -271,
"jsHeapTotalBytes": 389120,
"scriptDurationMs": 120.157,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2049.490999999989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.25300000000004,
"heapDeltaBytes": -8148472,
"heapUsedBytes": 61275424,
"domNodes": -277,
"jsHeapTotalBytes": 19288064,
"scriptDurationMs": 15.286,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1994.166000000007,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.567000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.76099999999997,
"heapDeltaBytes": -1908892,
"heapUsedBytes": 56964196,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 17.657,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1741.0770000000184,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.574,
"layouts": 16,
"layoutDurationMs": 4.181,
"taskDurationMs": 719.72,
"heapDeltaBytes": -16673164,
"heapUsedBytes": 52910412,
"domNodes": -234,
"jsHeapTotalBytes": 19288064,
"scriptDurationMs": 95.453,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.8280000000118,
"styleRecalcs": 75,
"styleRecalcDurationMs": 40.205,
"layouts": 16,
"layoutDurationMs": 4.659999999999999,
"taskDurationMs": 742.6460000000001,
"heapDeltaBytes": -10502884,
"heapUsedBytes": 48384596,
"domNodes": 61,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 101.09,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 966.9279999999958,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.581,
"layouts": 14,
"layoutDurationMs": 15.458,
"taskDurationMs": 749.5640000000001,
"heapDeltaBytes": -69296,
"heapUsedBytes": 87865192,
"domNodes": 13673,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 25.962,
"eventListeners": 2531,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8118.265999999949,
"styleRecalcs": 249,
"styleRecalcDurationMs": 49.899,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3617.335,
"heapDeltaBytes": -15529752,
"heapUsedBytes": 68432260,
"domNodes": -263,
"jsHeapTotalBytes": 6049792,
"scriptDurationMs": 1210.7740000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8184.428000000025,
"styleRecalcs": 251,
"styleRecalcDurationMs": 53.36300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3855.0180000000005,
"heapDeltaBytes": 1800704,
"heapUsedBytes": 69050712,
"domNodes": -268,
"jsHeapTotalBytes": 1245184,
"scriptDurationMs": 1261.658,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12337.482999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12321.304999999998,
"heapDeltaBytes": -19755332,
"heapUsedBytes": 183605064,
"domNodes": -3300,
"jsHeapTotalBytes": 14127104,
"scriptDurationMs": 549.277,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12999.144,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12976.027000000002,
"heapDeltaBytes": -29726196,
"heapUsedBytes": 169572068,
"domNodes": -3300,
"jsHeapTotalBytes": 2854912,
"scriptDurationMs": 558.825,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15002.133000000014,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.92499999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14978.87,
"heapDeltaBytes": -36710644,
"heapUsedBytes": 172735164,
"domNodes": -8311,
"jsHeapTotalBytes": 14397440,
"scriptDurationMs": 794.3059999999999,
"eventListeners": -16364,
"totalBlockingTimeMs": 6,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 16504.57299999994,
"styleRecalcs": 104,
"styleRecalcDurationMs": 22.753999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16478.096,
"heapDeltaBytes": -31397028,
"heapUsedBytes": 167828560,
"domNodes": -3302,
"jsHeapTotalBytes": 20156416,
"scriptDurationMs": 846.0500000000001,
"eventListeners": -16370,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 176.2279999999805,
"styleRecalcs": 13,
"styleRecalcDurationMs": 29.004999999999995,
"layouts": 4,
"layoutDurationMs": 4.8950000000000005,
"taskDurationMs": 149.887,
"heapDeltaBytes": -4651048,
"heapUsedBytes": 48853584,
"domNodes": -117,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 37.144,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 480.9060000000045,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.802,
"layouts": 6,
"layoutDurationMs": 1.3049999999999997,
"taskDurationMs": 226.26800000000003,
"heapDeltaBytes": -21942592,
"heapUsedBytes": 48754656,
"domNodes": -177,
"jsHeapTotalBytes": 4608000,
"scriptDurationMs": 20.459000000000003,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13391 +/- ##
==========================================
+ Coverage 78.14% 83.32% +5.17%
==========================================
Files 1648 1649 +1
Lines 99977 99980 +3
Branches 35123 35127 +4
==========================================
+ Hits 78129 83306 +5177
+ Misses 21134 16081 -5053
+ Partials 714 593 -121
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 214 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai approve |
✅ Action performedComments resolved and changes approved. |
DrJKL
left a comment
There was a problem hiding this comment.
Zoe spotted one recurring test-pattern issue below. Thanks for the big coverage push — let's keep the i18n checks tickly and real where these components depend on translations.
| const actual = await importOriginal() | ||
| return { | ||
| ...actual, | ||
| storeToRefs: (store: object) => store |
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
| return this.readOnly.has(name) | ||
| } | ||
| } | ||
| })) |
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
|
|
||
| vi.mock('vue-i18n', () => ({ | ||
| useI18n: () => ({ | ||
| t: (key: string, fallback?: string) => fallback ?? key |
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
| }, | ||
| handleSearch: vi.fn() | ||
| })) | ||
|
|
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
| add: vi.fn() | ||
| })) | ||
| const mockIsFileTooLarge = vi.hoisted(() => vi.fn()) | ||
|
|
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
|
|
||
| import ComfyHubPublishNav from './ComfyHubPublishNav.vue' | ||
|
|
||
| vi.mock('vue-i18n', () => ({ |
There was a problem hiding this comment.
Zoe sees this test mocking vue-i18n directly. Per the repo testing guidance, component tests should install the real i18n plugin/test setup instead of stubbing useI18n/$t; otherwise missing keys, interpolation mistakes, and plugin-integration regressions can sneak by unnoticed. Could we render this with the shared real i18n setup?
f6e9e08 to
4dca460
Compare
…tableNodeDTO tests
Summary
Consolidates the test-only critical branch coverage work from 11 constituent PRs into a single squashed commit on top of
main.Coverage (critical suite,
pnpm test:coverage:critical)Full run: 1071 test files passed, 14937 tests passed (8 skipped), 0 failures.
Constituent PRs
This PR supersedes and consolidates the following coverage PRs, which can be closed in its favor:
#13362, #13364, #13365, #13366, #13367, #13369, #13371, #13372, #13373, #13374, #13387
Overlapping test files between branches (
useFeatureFlags.test.ts,useSettingUI.test.ts,SubgraphIONodeBase.test.ts,subgraphUtils.test.ts,arrange.test.ts,collections.test.ts) were merged by union, keeping both sides' test cases.Notes
🤖 Generated with Claude Code
Note
Low Risk
All changes are unit/integration tests with no runtime behavior changes; risk is limited to CI time and test maintenance.
Overview
This PR is test-only and expands Vitest coverage across shared utilities and graph/auth/billing composables—no production source files change.
New suites cover areas such as
runWhenGlobalIdle(native vs timeout fallback),useCurrentUser,useLegacyBilling,useTerminal, canvas helpers (useFocusNode,useAbsolutePosition,useCanvasPositionConversion,useOverflowObserver), and graph UI composables (useFrameNodes,useGroupMenuOptions,useMoreOptionsMenu,useNodeCustomization,useSelectionOperations,useVueNodeLifecycle).Existing tests gain branch and edge-case cases—for example
downloadFileempty/whitespace URLs,useAuthActionsbilling and account flows,useBoundingBoxesdraw/edit/background paths,useSelectionToolboxPositionvisibility and Vue layout,contextMenuConvertersubmenu/error handling,useErrorClearingHookscleanup and scan guards,useGraphNodeManagerwidget/property mapping, and image/selection/subgraph menu operations.Together these additions target higher critical-suite branch coverage (per PR description) by exercising error paths, mocks, and lifecycle hooks that were previously untested.
Reviewed by Cursor Bugbot for commit f6e9e08. Bugbot is set up for automated code reviews on this repo. Configure here.