Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThis PR adds and expands Vitest coverage across subgraph and litegraph internals, workflow management and persistence, and workflow sharing and ComfyHub publish flows. No production code changes or public API declarations change. ChangesSubgraph and litegraph internals tests
Workflow management, persistence, and validation
Workflow sharing and ComfyHub publish
Estimated code review effort: 5 (Critical) | ~120 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1691 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 7.78 MB gzip 🔴 +156 BDetailsSummary
Category Glance App Entry Points — 47.8 kB (baseline 47.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.26 MB (baseline 1.26 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 98 kB (baseline 98 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 546 kB (baseline 546 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 29.1 kB (baseline 29.1 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 117 kB (baseline 117 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.5 kB (baseline 57.5 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 270 kB (baseline 270 kB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.38 MB (baseline 3.38 MB) • 🔴 +10 BHelpers, composables, and utility bundles
Status: 16 added / 16 removed / 17 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.7 MB (baseline 11.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 67 added / 67 removed / 98 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-07-08T04:39:20.403Z",
"gitSha": "8fb775d571153d989d424ac7ce13fa56ff29f590",
"branch": "codex/coverage-workflow-subgraph-stores",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2053.929000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.561000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.976,
"heapDeltaBytes": 1534828,
"heapUsedBytes": 58469852,
"domNodes": 20,
"jsHeapTotalBytes": 18350080,
"scriptDurationMs": 19.713999999999995,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2045.8209999999895,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.49100000000004,
"heapDeltaBytes": -2434160,
"heapUsedBytes": 49626332,
"domNodes": -290,
"jsHeapTotalBytes": 17952768,
"scriptDurationMs": 22.240000000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2012.0539999999778,
"styleRecalcs": 75,
"styleRecalcDurationMs": 44.836,
"layouts": 12,
"layoutDurationMs": 3.745,
"taskDurationMs": 923.8919999999999,
"heapDeltaBytes": 7555496,
"heapUsedBytes": 60156536,
"domNodes": -229,
"jsHeapTotalBytes": 15855616,
"scriptDurationMs": 133.27800000000002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.4989999999957,
"styleRecalcs": 71,
"styleRecalcDurationMs": 34.092999999999996,
"layouts": 12,
"layoutDurationMs": 3.171,
"taskDurationMs": 756.1990000000001,
"heapDeltaBytes": -6637564,
"heapUsedBytes": 52114996,
"domNodes": 53,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 120.78100000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0470000000319,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.717000000000002,
"layouts": 6,
"layoutDurationMs": 0.6020000000000001,
"taskDurationMs": 305.288,
"heapDeltaBytes": -1280060,
"heapUsedBytes": 53370104,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 20.349999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.1309999999867,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.917,
"layouts": 6,
"layoutDurationMs": 0.856,
"taskDurationMs": 382.069,
"heapDeltaBytes": 16481972,
"heapUsedBytes": 68568016,
"domNodes": -214,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 24.553,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 593.6760000000163,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.238000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.5,
"heapDeltaBytes": 8794308,
"heapUsedBytes": 67198724,
"domNodes": 20,
"jsHeapTotalBytes": 17039360,
"scriptDurationMs": 61.216,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 613.7449999999944,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.491,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.28299999999996,
"heapDeltaBytes": -22805964,
"heapUsedBytes": 46732220,
"domNodes": -277,
"jsHeapTotalBytes": 5132288,
"scriptDurationMs": 62.12500000000001,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2004.9260000000118,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.97,
"heapDeltaBytes": -9168036,
"heapUsedBytes": 63835448,
"domNodes": 20,
"jsHeapTotalBytes": 11415552,
"scriptDurationMs": 101.761,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1998.9799999999605,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.022999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.057,
"heapDeltaBytes": -9772960,
"heapUsedBytes": 62380660,
"domNodes": 20,
"jsHeapTotalBytes": 11415552,
"scriptDurationMs": 101.098,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2143.7310000000025,
"styleRecalcs": 70,
"styleRecalcDurationMs": 20.044000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1127.603,
"heapDeltaBytes": 1619928,
"heapUsedBytes": 57837380,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 401.90000000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2130.6599999999207,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.755000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1121.329,
"heapDeltaBytes": 12973464,
"heapUsedBytes": 81440236,
"domNodes": -275,
"jsHeapTotalBytes": -1638400,
"scriptDurationMs": 392.24800000000005,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3113.8220000000274,
"styleRecalcs": 62,
"styleRecalcDurationMs": 16.323000000000004,
"layouts": 60,
"layoutDurationMs": 7.606999999999999,
"taskDurationMs": 1289.23,
"heapDeltaBytes": 12707328,
"heapUsedBytes": 66427628,
"domNodes": -283,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 478.646,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3109.1069999999945,
"styleRecalcs": 63,
"styleRecalcDurationMs": 17.555,
"layouts": 60,
"layoutDurationMs": 7.619000000000001,
"taskDurationMs": 1326.727,
"heapDeltaBytes": 12582276,
"heapUsedBytes": 66788468,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 500.169,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2040.583999999967,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.200000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.7760000000001,
"heapDeltaBytes": -2443480,
"heapUsedBytes": 59556508,
"domNodes": -276,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 92.252,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.128999999889,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.284000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.24,
"heapDeltaBytes": -2100188,
"heapUsedBytes": 59868340,
"domNodes": -278,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 110.50999999999999,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 605.7920000000081,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.107000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.763,
"heapDeltaBytes": -23336852,
"heapUsedBytes": 46263176,
"domNodes": -285,
"jsHeapTotalBytes": 5918720,
"scriptDurationMs": 130.929,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.972000000037,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 412.68300000000005,
"heapDeltaBytes": 10842108,
"heapUsedBytes": 63093548,
"domNodes": -290,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 127.81399999999998,
"eventListeners": -197,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1999.3880000000104,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.607999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 371.944,
"heapDeltaBytes": -1940168,
"heapUsedBytes": 57001916,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 17.047,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.505,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.28599999999994,
"heapDeltaBytes": -1948416,
"heapUsedBytes": 50282620,
"domNodes": -291,
"jsHeapTotalBytes": 18739200,
"scriptDurationMs": 18.48,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.1949999999852,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.480999999999995,
"layouts": 16,
"layoutDurationMs": 5.074999999999999,
"taskDurationMs": 779.463,
"heapDeltaBytes": -5096432,
"heapUsedBytes": 47133712,
"domNodes": -256,
"jsHeapTotalBytes": 17952768,
"scriptDurationMs": 101.135,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1755.8720000000676,
"styleRecalcs": 77,
"styleRecalcDurationMs": 46.423,
"layouts": 16,
"layoutDurationMs": 4.923,
"taskDurationMs": 810.518,
"heapDeltaBytes": -17100532,
"heapUsedBytes": 52716072,
"domNodes": -232,
"jsHeapTotalBytes": 20074496,
"scriptDurationMs": 102.962,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.120000000039,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.73,
"layouts": 15,
"layoutDurationMs": 16.868,
"taskDurationMs": 895.7049999999999,
"heapDeltaBytes": 4499964,
"heapUsedBytes": 76843168,
"domNodes": 13673,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 42.138,
"eventListeners": 2533,
"totalBlockingTimeMs": 178,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8249.20800000001,
"styleRecalcs": 250,
"styleRecalcDurationMs": 55.121,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3827.692,
"heapDeltaBytes": -394636,
"heapUsedBytes": 59966120,
"domNodes": -265,
"jsHeapTotalBytes": 5173248,
"scriptDurationMs": 1255.483,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.569000000048,
"styleRecalcs": 250,
"styleRecalcDurationMs": 58.04899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3934.105,
"heapDeltaBytes": -1062356,
"heapUsedBytes": 71322156,
"domNodes": 20,
"jsHeapTotalBytes": 17096704,
"scriptDurationMs": 1288.4450000000002,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13015.785999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12997.997000000001,
"heapDeltaBytes": -37937544,
"heapUsedBytes": 166382820,
"domNodes": -3302,
"jsHeapTotalBytes": 16486400,
"scriptDurationMs": 536.068,
"eventListeners": -16374,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12774.094999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12758.446999999998,
"heapDeltaBytes": -36291376,
"heapUsedBytes": 170700092,
"domNodes": -3300,
"jsHeapTotalBytes": 4427776,
"scriptDurationMs": 549.963,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15374.687999999991,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.08600000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15349.128,
"heapDeltaBytes": -56422840,
"heapUsedBytes": 164699248,
"domNodes": -3300,
"jsHeapTotalBytes": 2592768,
"scriptDurationMs": 828.8489999999999,
"eventListeners": -16374,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15507.90900000004,
"styleRecalcs": 79,
"styleRecalcDurationMs": 19.80599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15481.525000000001,
"heapDeltaBytes": -51772748,
"heapUsedBytes": 154498560,
"domNodes": -3300,
"jsHeapTotalBytes": 5476352,
"scriptDurationMs": 839.788,
"eventListeners": -16376,
"totalBlockingTimeMs": 18,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 446.39000000000806,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.834,
"layouts": 4,
"layoutDurationMs": 1.3300000000000003,
"taskDurationMs": 116.06000000000002,
"heapDeltaBytes": 5172992,
"heapUsedBytes": 70123132,
"domNodes": 168,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.746,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 492.7789999999277,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.013999999999996,
"layouts": 4,
"layoutDurationMs": 1.191,
"taskDurationMs": 205.04799999999997,
"heapDeltaBytes": -4681724,
"heapUsedBytes": 48945148,
"domNodes": -172,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 18.746,
"eventListeners": -132,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #13367 +/- ##
==========================================
+ Coverage 77.32% 78.45% +1.12%
==========================================
Files 1640 1648 +8
Lines 95356 96844 +1488
Branches 32835 33162 +327
==========================================
+ Hits 73738 75975 +2237
+ Misses 20925 20194 -731
+ Partials 693 675 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 115 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ec91893 to
afe0888
Compare
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/platform/workflow/management/stores/workflowLists.test.ts`:
- Around line 11-34: The repeated vi.mock setup for app, api,
useWorkflowThumbnail, and useWorkflowDraftStoreV2 is duplicated across multiple
workflow store test suites; extract this boilerplate into a shared helper or
test setup utility such as a mockWorkflowStoreDeps module and reuse it from
workflowLists.test.ts, workflowNodeLocator.test.ts, and workflowTabs.test.ts so
changes to these dependencies stay consistent in one place.
In `@src/stores/subgraphNavigationStore.navigateToHash.test.ts`:
- Around line 267-283: The canvas-unavailable setup in this test duplicates the
unsafe cast-and-restore pattern already used by withCanvasUnavailable in the
viewport test. Extract that logic into a shared test helper (for example in a
subgraphNavigation test-utils module under src/stores/ or src/test-utils/) and
update this test to call the helper instead of manually mutating app.canvas;
keep the reusable behavior centered around the withCanvasUnavailable-style
helper and the app.canvas restoration logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 89d6f294-f894-4f27-bd77-b4d4e3224dab
📒 Files selected for processing (7)
src/platform/workflow/management/stores/workflowLists.test.tssrc/platform/workflow/management/stores/workflowNodeLocator.test.tssrc/platform/workflow/management/stores/workflowTabs.test.tssrc/platform/workflow/templates/repositories/workflowTemplatesStore.test.tssrc/stores/subgraphNavigationStore.navigateToHash.test.tssrc/stores/subgraphNavigationStore.viewport.test.tssrc/stores/subgraphStore.test.ts
afe0888 to
48b85f3
Compare
|
@coderabbitai approve |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/stores/subgraphStore.test.ts`:
- Around line 469-485: The test around mockFetch and useToastStore().add leaves
console.error mocked as a no-op, which can leak into later tests. In this spec,
restore the console.error spy after the assertion by cleaning up the spy created
with vi.spyOn(console, 'error') so other tests still surface real errors. Keep
the change localized to this compact-detail test case.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5a7e1fd6-034c-4454-b15f-22ae1d9bdf59
📒 Files selected for processing (8)
src/platform/workflow/management/stores/workflowLists.test.tssrc/platform/workflow/management/stores/workflowNodeLocator.test.tssrc/platform/workflow/management/stores/workflowTabs.test.tssrc/platform/workflow/templates/repositories/workflowTemplatesStore.test.tssrc/stores/__tests__/subgraphNavigationTestUtils.tssrc/stores/subgraphNavigationStore.navigateToHash.test.tssrc/stores/subgraphNavigationStore.viewport.test.tssrc/stores/subgraphStore.test.ts
✅ Action performedComments resolved and changes approved. |
f76fc71 to
7b3921a
Compare
There was a problem hiding this comment.
Actionable comments posted: 21
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/core/graph/subgraph/promotedInputWidget.test.ts`:
- Around line 43-50: The test helper node() is too narrowly typed for
LGraphNode.isSubgraphNode, so Partial<LGraphNode> overrides that replace it with
plain booleans or simple functions trigger TS2322. Update the helper in
promotedInputWidget.test.ts to avoid forcing isSubgraphNode to a fixed predicate
signature—either relax the override typing for that field or explicitly model
the helper’s overrides so test cases can pass false/true implementations without
breaking typecheck. Keep the fix centered on node() and the call sites that pass
isSubgraphNode overrides.
In `@src/core/graph/subgraph/promotionUtils.test.ts`:
- Around line 1427-1436: The test setup in createTestSubgraph is missing the
required type field on the plain input, which breaks type-checking. Update the
inputs array in this reorderSubgraphInputsByWidgetOrder test to include a valid
ISlotType for the plain input, using the existing createTestSubgraph and
createTestSubgraphNode helpers so the scenario still validates that plain inputs
remain after ordered promoted widgets.
- Around line 350-376: The menu callback is being invoked with the wrong
receiver because `options[0]?.callback` is called as a method even though it
declares `this: ContextMenuDivElement`. Update the two tests in
`addWidgetPromotionOptions` coverage to call the callback as an unbound function
instead of relying on property invocation, so the
`callback`/`promoteValueWidgetViaSubgraphInput` flow type-checks correctly.
- Around line 841-874: The preview widget setup in this test is using
LGraphNode.addWidget(), which is typed against TWidgetType and won’t accept
'preview'. Replace that call in the autoExposeKnownPreviewNodes test with the
test widget helper using widget({ name: 'preview', serialize: false, type:
'preview' }) and attach it to interiorNode.widgets so the preview exposure path
still exercises the same behavior without a type error.
In `@src/core/graph/widgets/dynamicWidgets.test.ts`:
- Around line 26-29: The test file repeats the same `fromAny<{
configuringGraphLevel: number }, unknown>(app).configuringGraphLevel = N`
stubbing pattern several times, so extract it into a small helper such as
`setConfiguringGraphLevel(level)` near the affected `dynamicWidgets.test.ts`
setup. Replace each direct assignment in the relevant test cases with the helper
to keep the intent clear and remove duplication while preserving the existing
`app`-based stubbing behavior.
- Around line 150-165: The test double in COMFY_DYNAMICCOMBO_V3 is being cast
too directly to Parameters<typeof dynamicWidgets.COMFY_DYNAMICCOMBO_V3>[3],
which causes a TypeScript overlap error. Update the comboApp fixture in
dynamicWidgets.test.ts to cast through unknown first, or otherwise narrow the
fixture so it matches the expected app type cleanly. Keep the rest of the test
logic unchanged, including the assertion that COMBO is not called.
In `@src/extensions/core/groupNode.test.ts`:
- Around line 85-87: The helper in addCustomNodeDefs is using optional chaining
on extension().addCustomNodeDefs, which can hide a broken extension contract
during test setup. Update this call to require the method to exist and fail
immediately in groupNode.test.ts rather than silently no-oping, so a missing
addCustomNodeDefs implementation is caught by the beforeEach setup instead of
surfacing later in unrelated tests.
- Around line 492-526: The test in GroupNodeConfig.registerFromWorkflow uses a
conditional branch around missingNodeTypes[1], which can skip the core
assertions and create a false positive. Refactor the assertion in
groupNode.test.ts to verify the second entry’s action shape directly instead of
guarding with if (typeof action !== 'string'), so the callback behavior and
Broken group removal are always checked. Use the existing symbols
missingNodeTypes, action.action.callback, and groupNodes.Broken to locate the
test block.
In `@src/lib/litegraph/src/subgraph/ExecutableNodeDTO.test.ts`:
- Around line 28-35: The test in ExecutableNodeDTO.test.ts uses a weak bare
toThrow() assertion for the no-graph case, so tighten it to match the specific
error message or error type emitted by ExecutableNodeDTO when constructing from
a detached LGraphNode. Update the expectation in the “should throw when the node
has no graph” test to assert the NullGraphError message pattern, consistent with
the other message-checking tests in this file.
- Around line 477-497: The bypass test in ExecutableNodeDTO.test.ts does not
prove first-input selection because LGraphNode only has one input and
resolveOutput(1, '*', ...) can still return undefined for an unconnected slot.
Update the ExecutableNodeDTO bypass case to mirror the stronger resolveOutput
tests by adding a second input, wiring an upstream node into the first input,
leaving the second unconnected (or otherwise distinguishable), and asserting the
resolved value/node comes from the first input when
ExecutableNodeDTO.resolveOutput is called in BYPASS mode.
In `@src/lib/litegraph/src/subgraph/SubgraphInputSlot.test.ts`:
- Line 1: Rename the test file for the SubgraphInput class to match the
source/test pairing used in this folder: update SubgraphInputSlot.test.ts so it
becomes SubgraphInput.test.ts. Keep the existing Vitest imports and test content
intact, and make sure any references to the test file name in the subgraph test
suite or related imports/paths are updated to point to SubgraphInput.test.ts.
In `@src/lib/litegraph/src/subgraph/SubgraphNode.test.ts`:
- Around line 106-118: The test in SubgraphNode.test.ts conditionally asserts on
import.meta.env.DEV, but this guard is redundant in Vitest because DEV is true
in test mode and can hide missing assertions. Update the “warns when external
code assigns widgets directly” test to assert the console.warn call directly
after setting subgraphNode.widgets, using the existing createTestSubgraphNode
and warn spy, and remove the import.meta.env.DEV branch entirely.
In `@src/lib/litegraph/src/utils/collections.test.ts`:
- Around line 28-39: The getAllNestedItems test is not proving that pinned
descendants are skipped because leaf is reachable through multiple paths, so the
Set result can still pass even if pinned children are traversed. Update the test
in collections.test.ts by introducing a child unique to the pinned Positionable
and assert that this unique item is not present in the result, while still
checking the existing parent/leaf expectations. Use the existing
getAllNestedItems helper and the pinned/parent setup to make the regression
meaningful.
In
`@src/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.ts`:
- Around line 301-319: The migration cases in useWorkflowPersistenceV2.test.ts
are only verifying that migrateV1toV2 is called with mocked arguments, which is
not behavioral coverage. Update the tests around mountWorkflowPersistence to
assert an observable outcome of the composable instead of the mock call, or
remove these cases if migrateV1toV2 already has its own unit tests; use the
existing symbols migrateV1toV2 and mountWorkflowPersistence to locate the logic.
In
`@src/platform/workflow/sharing/components/profile/ComfyHubCreateProfileForm.test.ts`:
- Around line 95-112: Update the test helper prop typing in
ComfyHubCreateProfileForm.test so renderForm uses Partial<ComponentProps<typeof
ComfyHubCreateProfileForm>> instead of InstanceType<typeof
ComfyHubCreateProfileForm>['$props']; keep the helper behavior the same and
adjust the type import if needed so the prop signature matches the rest of the
test suite.
In `@src/platform/workflow/sharing/components/publish/ComfyHubFinishStep.test.ts`:
- Around line 10-13: The test is re-declaring a local asset shape instead of
using the shared contract, which can drift from production types. Update
ComfyHubFinishStep.test to remove the PrivateAsset interface and import the
actual asset type used by workflowShareService/useComfyHubPublishSubmission,
such as AssetInfo, then use that type wherever getShareableAssets() results are
mocked or asserted so the test stays aligned with the component’s real API.
- Around line 131-146: The test in ComfyHubFinishStep.test is using an अस्पष्ट
single-letter text assertion, which makes the intent unclear and brittle. Update
the assertion around the renderStep()/screen.getByText('A') check to target the
specific avatar-initial or accessible element it is meant to verify, preferably
via a role or aria-label query. If no accessible hook exists, add a short
comment explaining what the “A” represents so the test intent is explicit and
stable.
- Around line 148-161: Split the combined check in ComfyHubFinishStep.test into
two separate tests instead of calling renderStep() twice in one it block; the
current test mixes the “ready when no assets are private” case with the “not
ready when asset loading fails” case, which weakens isolation. Keep the existing
assertions around screen.queryByText('comfyHubPublish.additionalInfo') and
screen.queryByText('shareWorkflow.checkingAssets'), but move each scenario into
its own test so each renderStep() call has a fresh component instance and
independent state.
In `@src/platform/workflow/sharing/components/ShareWorkflowDialogContent.test.ts`:
- Around line 677-701: The ShareWorkflowDialogContent test suite leaves the
console.error spy active after the “shows an error toast when saving fails”
case, which can suppress stderr in later tests. Update the test cleanup in this
spec so the spy created with vi.spyOn(console, 'error') is fully restored,
either by using vi.restoreAllMocks() in afterEach or by calling mockRestore() on
the console.error spy, while keeping the rest of the test behavior unchanged.
In `@src/platform/workflow/sharing/composables/useSliderFromMouse.test.ts`:
- Around line 12-14: The test setup in useSliderFromMouse.test.ts uses shared
module-level refs (elementX, elementWidth, and isOutside) that are mutated by
multiple it cases, making the suite order-dependent. Reset these refs to their
initial values in a beforeEach, or move their creation into a helper invoked per
test, so each test starts from a clean state. Keep the fix centered around the
useSliderFromMouse test cases and the shared ref declarations.
- Around line 16-25: Add the missing fields to the `useMouseInElement` mock in
`useSliderFromMouse.test.ts` so it matches `UseMouseInElementReturn`; include
`x`, `y`, and `stop` alongside the existing refs in the
`vi.mocked(useMouseInElement).mockReturnValue(...)` setup. Keep the mock shape
aligned with the composable contract used by `useSliderFromMouse` so `pnpm
typecheck` passes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b79e5663-8c1c-49ce-bfeb-c036813e5481
📒 Files selected for processing (51)
src/core/graph/subgraph/migration/proxyWidgetMigration.test.tssrc/core/graph/subgraph/promotedInputWidget.test.tssrc/core/graph/subgraph/promotionUtils.test.tssrc/core/graph/widgets/dynamicTypes.test.tssrc/core/graph/widgets/dynamicWidgets.test.tssrc/core/graph/widgets/matchTypeConfiguring.test.tssrc/extensions/core/groupNode.test.tssrc/lib/litegraph/src/node/NodeSlot.test.tssrc/lib/litegraph/src/subgraph/ExecutableNodeDTO.test.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.test.tssrc/lib/litegraph/src/subgraph/SubgraphInputNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphInputSlot.test.tssrc/lib/litegraph/src/subgraph/SubgraphNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphOutputNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphOutputSlot.test.tssrc/lib/litegraph/src/subgraph/subgraphDeduplication.test.tssrc/lib/litegraph/src/subgraph/subgraphUtils.test.tssrc/lib/litegraph/src/utils/arrange.test.tssrc/lib/litegraph/src/utils/collections.test.tssrc/platform/workflow/core/services/workflowActionsService.test.tssrc/platform/workflow/core/services/workflowService.test.tssrc/platform/workflow/management/composables/useWorkflowsSidebarTab.test.tssrc/platform/workflow/management/stores/workflowLists.test.tssrc/platform/workflow/management/stores/workflowNodeLocator.test.tssrc/platform/workflow/management/stores/workflowStore.test.tssrc/platform/workflow/management/stores/workflowTabs.test.tssrc/platform/workflow/persistence/base/storageIO.test.tssrc/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.tssrc/platform/workflow/persistence/composables/useWorkflowTabState.test.tssrc/platform/workflow/persistence/migration/migrateV1toV2.test.tssrc/platform/workflow/persistence/stores/workflowDraftStoreV2.test.tssrc/platform/workflow/sharing/components/ShareWorkflowDialogContent.test.tssrc/platform/workflow/sharing/components/profile/ComfyHubCreateProfileForm.test.tssrc/platform/workflow/sharing/components/profile/ComfyHubPublishIntroPanel.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubExamplesStep.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubFinishStep.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubProfilePromptPanel.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishFooter.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishNav.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishWizardContent.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubThumbnailStep.test.tssrc/platform/workflow/sharing/components/publish/ReorderableExampleImage.test.tssrc/platform/workflow/sharing/composables/useComfyHubPublishSubmission.test.tssrc/platform/workflow/sharing/composables/useComfyHubPublishWizard.test.tssrc/platform/workflow/sharing/composables/useShareDialog.test.tssrc/platform/workflow/sharing/composables/useSliderFromMouse.test.tssrc/platform/workflow/sharing/services/comfyHubService.test.tssrc/platform/workflow/sharing/services/workflowShareService.test.tssrc/platform/workflow/templates/repositories/workflowTemplatesStore.test.tssrc/platform/workflow/validation/composables/useWorkflowValidation.test.ts
7b3921a to
99f22cf
Compare
|
@coderabbitai approve |
Rate Limit Exceeded
|
|
@coderabbitai approve |
Rate Limit Exceeded
|
|
@coderabbitai approve |
- Replace all fromAny<T, unknown>() calls with fromPartial<T>() where the
partial type constraint is satisfiable
- Replace as unknown as T patterns for TSTypeReference targets with
fromPartial<T>() calls; use eslint-disable where the target type cannot
accept a partial (LGraphNode constructor conflict, ReadonlySet undefined)
- Use as unknown as { TypeLiteral } for vi.spyOn on protected methods
(TSTypeLiteral outer type does not trigger the double-assertion rule)
- Use bracket access (app as unknown as { configuringGraphLevel })
for private field mutation in tests (TSTypeLiteral outer)
- Replace vi.mock('vue-i18n') with real createI18n instances
- Use real Response instances in comfyHubService tests
- Fix textBaseline: '' to 'alphabetic' in CanvasRenderingContext2D mocks
- Remove pathToRootGraph from Subgraph partials (property does not exist)
- Cast LoadedComfyWorkflow to ComfyWorkflowClass to allow null changeTracker
|
@coderabbitai full review |
✅ Action performedFull review finished. |
There was a problem hiding this comment.
Actionable comments posted: 4
♻️ Duplicate comments (2)
src/extensions/core/groupNode.test.ts (1)
62-76: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valuePrefer
satisfies ComfyNodeDefoveras ComfyNodeDef.This was flagged in a prior review round but appears unaddressed —
makeNodeDefstill builds a fully-populatedComfyNodeDefand casts withasinstead of validating the complete shape withsatisfies.♻️ Proposed fix
function makeNodeDef(overrides: Partial<ComfyNodeDef> = {}): ComfyNodeDef { - return { + return ({ name: 'TestNode', display_name: 'Test Node', description: '', category: 'test', input: { required: {}, optional: {} }, output: [], output_name: [], output_is_list: [], output_node: false, python_module: 'test', ...overrides - } as ComfyNodeDef + }) satisfies ComfyNodeDef }Based on learnings, prefer
satisfies InterfaceTypefor shape validation over type assertions when the helper builds a complete interface shape (not an intentionally partial fixture).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/extensions/core/groupNode.test.ts` around lines 62 - 76, The helper makeNodeDef is still using a type assertion instead of shape validation; update it to use satisfies ComfyNodeDef on the returned object so the full node definition is checked structurally rather than cast. Keep the helper’s complete ComfyNodeDef shape intact, and apply the change in makeNodeDef without altering its override merging behavior.Source: Learnings
src/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.ts (1)
716-746: 🩺 Stability & Availability | 🟠 Major | ⚡ Quick winUnstub the
URLglobal after the test.
vi.stubGlobal('URL', ...)at Line 718 replaces the global for the rest of the suite; this repo's Vitest setup does not auto-unstub globals. Addvi.unstubAllGlobals()(or restore the originalURL) after the assertions.🔧 Proposed fix
expect(revokeObjectURL).toHaveBeenCalledWith('blob:uploaded') expect(revokeObjectURL).not.toHaveBeenCalledWith( 'https://example.com/remote.png' ) + vi.unstubAllGlobals() })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.ts` around lines 716 - 746, The test for revoking uploaded example image object URLs stubs the global URL via vi.stubGlobal in ComfyHubPublishDialog.test, but it never restores it, so the replacement leaks into later tests. After the assertions in the revokes uploaded example image object URLs on unmount test, add cleanup to unstub the global (for example with vi.unstubAllGlobals() or by restoring the original URL) so the suite remains isolated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/litegraph/src/subgraph/subgraphUtils.test.ts`:
- Around line 387-392: The test assertions are hardcoding subgraph sentinel IDs
instead of using the shared constants, so update the checks in
subgraphUtils.test.ts to reference SUBGRAPH_INPUT_ID and import
SUBGRAPH_OUTPUT_ID where needed. Adjust the affected expectations in the link
assertions so they derive origin_id/target_id from those constants rather than
magic strings, including the later duplicated assertions noted in the review.
- Around line 313-328: The multiClone fallback test is checking the wrong
reference, so it does not prove the cloned node’s properties are independent of
the original. Update the assertion in the multiClone test to compare
result[0].properties directly against node.properties rather than against
node.serialize().properties, using the LGraphNode setup in the multiClone
describe block and keeping the deep-equality check alongside the reference
inequality check.
In
`@src/platform/workflow/sharing/components/profile/ComfyHubPublishIntroPanel.test.ts`:
- Around line 19-21: The `renderPanel` test helper is still typing props with
`InstanceType<typeof ComfyHubPublishIntroPanel>['$props']`, which is
inconsistent with the sibling test and less clear. Update the helper in
`ComfyHubPublishIntroPanel.test` to use `Partial<ComponentProps<typeof
ComfyHubPublishIntroPanel>>` from `vue-component-type-helpers`, matching the
`ComfyHubCreateProfileForm.test` pattern and keeping prop typing consistent
across these test helpers.
In `@src/platform/workflow/sharing/components/publish/ComfyHubPublishNav.test.ts`:
- Around line 49-55: The test in ComfyHubPublishNav.test repeats the same
screen.getByRole('listitem', { current: 'step' }) lookup twice; store that
element in a variable once and reuse it for both assertions. Keep the assertions
in the same test, but reference the cached list item instead of querying it
again.
---
Duplicate comments:
In `@src/extensions/core/groupNode.test.ts`:
- Around line 62-76: The helper makeNodeDef is still using a type assertion
instead of shape validation; update it to use satisfies ComfyNodeDef on the
returned object so the full node definition is checked structurally rather than
cast. Keep the helper’s complete ComfyNodeDef shape intact, and apply the change
in makeNodeDef without altering its override merging behavior.
In
`@src/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.ts`:
- Around line 716-746: The test for revoking uploaded example image object URLs
stubs the global URL via vi.stubGlobal in ComfyHubPublishDialog.test, but it
never restores it, so the replacement leaks into later tests. After the
assertions in the revokes uploaded example image object URLs on unmount test,
add cleanup to unstub the global (for example with vi.unstubAllGlobals() or by
restoring the original URL) so the suite remains isolated.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3eb60318-5384-4a18-bd22-9bfcc9bbbfc3
📒 Files selected for processing (54)
src/core/graph/subgraph/migration/proxyWidgetMigration.test.tssrc/core/graph/subgraph/promotedInputWidget.test.tssrc/core/graph/subgraph/promotionUtils.test.tssrc/core/graph/widgets/dynamicTypes.test.tssrc/core/graph/widgets/dynamicWidgets.test.tssrc/core/graph/widgets/matchTypeConfiguring.test.tssrc/extensions/core/groupNode.test.tssrc/extensions/core/groupNode.tssrc/lib/litegraph/src/node/NodeSlot.test.tssrc/lib/litegraph/src/subgraph/ExecutableNodeDTO.test.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.test.tssrc/lib/litegraph/src/subgraph/SubgraphInputNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphInputSlot.test.tssrc/lib/litegraph/src/subgraph/SubgraphNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphOutputNode.test.tssrc/lib/litegraph/src/subgraph/SubgraphOutputSlot.test.tssrc/lib/litegraph/src/subgraph/subgraphDeduplication.test.tssrc/lib/litegraph/src/subgraph/subgraphUtils.test.tssrc/lib/litegraph/src/utils/arrange.test.tssrc/lib/litegraph/src/utils/arrange.tssrc/lib/litegraph/src/utils/collections.test.tssrc/lib/litegraph/src/utils/collections.tssrc/platform/workflow/core/services/workflowActionsService.test.tssrc/platform/workflow/core/services/workflowService.test.tssrc/platform/workflow/management/composables/useWorkflowsSidebarTab.test.tssrc/platform/workflow/management/stores/workflowLists.test.tssrc/platform/workflow/management/stores/workflowNodeLocator.test.tssrc/platform/workflow/management/stores/workflowStore.test.tssrc/platform/workflow/management/stores/workflowTabs.test.tssrc/platform/workflow/persistence/base/storageIO.test.tssrc/platform/workflow/persistence/composables/useWorkflowPersistenceV2.test.tssrc/platform/workflow/persistence/composables/useWorkflowTabState.test.tssrc/platform/workflow/persistence/migration/migrateV1toV2.test.tssrc/platform/workflow/persistence/stores/workflowDraftStoreV2.test.tssrc/platform/workflow/sharing/components/ShareWorkflowDialogContent.test.tssrc/platform/workflow/sharing/components/profile/ComfyHubCreateProfileForm.test.tssrc/platform/workflow/sharing/components/profile/ComfyHubPublishIntroPanel.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubExamplesStep.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubFinishStep.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubProfilePromptPanel.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishDialog.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishFooter.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishNav.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubPublishWizardContent.test.tssrc/platform/workflow/sharing/components/publish/ComfyHubThumbnailStep.test.tssrc/platform/workflow/sharing/components/publish/ReorderableExampleImage.test.tssrc/platform/workflow/sharing/composables/useComfyHubPublishSubmission.test.tssrc/platform/workflow/sharing/composables/useComfyHubPublishWizard.test.tssrc/platform/workflow/sharing/composables/useShareDialog.test.tssrc/platform/workflow/sharing/composables/useSliderFromMouse.test.tssrc/platform/workflow/sharing/services/comfyHubService.test.tssrc/platform/workflow/sharing/services/workflowShareService.test.tssrc/platform/workflow/templates/repositories/workflowTemplatesStore.test.tssrc/platform/workflow/validation/composables/useWorkflowValidation.test.ts
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
@coderabbitai full review |
✅ Action performedFull review finished. |
ComfyHubPublishNav tests asserted border/background utility classes to distinguish completed/current/upcoming steps, violating the repo rule against testing non-behavioral styles. Expose a stable data-step-state hook on each step and assert that instead; drop the redundant background class assertion already covered by the sub-step label and aria-current. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 30b2ef6. Configure here.
Revert the data-step-state binding added in the prior commit so this PR touches no implementation. The step-state semantic hook and its completed/upcoming coverage move to a follow-up PR. The style-class assertions stay removed; current-step behavior is covered via aria-current. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- Replace as-Response casts with real Response instances in workflowStore.test.ts (mockImplementation for the multi-call openedWorkflowIndexShift case, since a Response body can only be read once) - Add companion assertions to bare not.toThrow() checks so guarded branches prove their effect (console spy calls, unaffected store state, invoked stub methods) in subgraphUtils, migrateV1toV2, workflowDraftStoreV2, and storageIO tests - Restore vi.stubGlobal mutations (URL, Path2D, fetch) via unstubAllGlobals in ComfyHubPublishDialog, NodeSlot, and workflowTemplatesStore tests; restore a stray console.warn spy in ExecutableNodeDTO test - Drop unnecessary full-module LGraphNode mock in collections.test.ts in favor of the real class, importing via the litegraph barrel to avoid a circular-import crash when run standalone
Match the sibling SubgraphInputNode/SubgraphOutputNode test pattern: capture the original ContextMenu class and restore it in afterEach so the mock doesn't leak into later specs sharing the same worker.
|
Closing this stale generated coverage batch. The critical coverage gate is already on main, while this branch adds over 11,000 lines against fast-moving workflow/subgraph code. |

Note
Test proposal: https://app.notion.com/p/comfy-org/Test-Coverage-PR-Split-38e6d73d3650815a977ce2e9213cd653?source=copy_link
Summary
Critical branch coverage
Tests
pnpm test:coverage:criticalon clean aggregate: 1065 files passed, 14720 tests passed, 8 skipped.Side-effect policy
This PR is test-only. It does not include production code, scripts, config, or workflow changes. Any mandatory production fix or side effect must be a separate follow-up PR with an explicit justification.
Created by Codex
Note
Low Risk
Changes are almost entirely tests; the sole production edit is a narrow TypeScript type on group-node external links, with no runtime logic changes.
Overview
Adds a large batch of Vitest coverage aimed at workflow/subgraph and litegraph paths so aggregate critical branch coverage can reach 90%. No new product features—mostly new or extended
*.test.tsfiles.Proxy widget migration (
proxyWidgetMigration.test.ts): nested promoted inputs, type fallbacks, primitive bypass/quarantine edge cases, legacy prefix normalization, and quarantine append behavior.Promotion & promoted inputs: new
promotedInputWidget.test.ts; expandedpromotionUtils.test.ts(menus, canvas toggle, preview exposure, reordering, idempotency); moreSubgraphNodeserialization, preview hydration, and duplicate-input rebind tests.Dynamic widgets & types: new
dynamicTypes.test.ts; much broaderdynamicWidgets.test.tsandmatchTypeConfiguring.test.ts(autogrow, match-type, configure-time behavior, error paths).Litegraph subgraph layer: new tests for IO nodes/slots,
SubgraphIONodeBase,ExecutableNodeDTOresolution errors and bypass/virtual paths,NodeSlotrendering/serialization, andsubgraphDeduplication(ID remap + cycle sort).Group nodes (
groupNode.test.ts): registration,GroupNodeConfiglink/input/output mapping, primitive/reroute defs;groupNode.tsonly widensexternallink tuples to allownulltypes.Reviewed by Cursor Bugbot for commit d815c7c. Bugbot is set up for automated code reviews on this repo. Configure here.