Skip to content

Align missing media detection contract for promoted subgraph widgets - #13270

Closed
jaeone94 wants to merge 5 commits into
jaeone/extract-promoted-widget-error-clearingfrom
jaeone/promoted-missing-media-scan
Closed

jaeone94 wants to merge 5 commits into
jaeone/extract-promoted-widget-error-clearingfrom
jaeone/promoted-missing-media-scan

Conversation

@jaeone94

Copy link
Copy Markdown
Collaborator

Summary

Align missing-media detection with the ADR 0009 promoted subgraph widget contract so media candidates are created from the editable host widget value while still using the concrete interior widget as the media schema and option source.

Why This PR Exists

This PR is a missing-media follow-up to the ADR 0009 / promoted subgraph widget work introduced by #12197, and to the missing-model contract redesign in #13059.

#12197 changed promoted subgraph widgets so the editable value belongs to the host SubgraphNode widget. Linked interior widgets are no longer guaranteed to mirror that selected value. #13059 updated missing-model detection around that contract: the host promoted widget is the selected-value owner, while the concrete interior widget remains the definition source for options, asset-browser eligibility, and node metadata.

Missing media still had the older shape. It skipped subgraph hosts during full scans and keyed candidates only to concrete interior paths. That made media behavior diverge from the new promoted-widget model contract, especially for nested promoted inputs where the displayed value can live on the outer host while the media node type and combo options live on the leaf node.

This PR ports the same identity split to missing media:

  • selected media value and candidate identity come from the editable host promoted widget;
  • concrete media node type, widget name, combo options, media kind, and upload state come from the resolved interior source widget;
  • linked interior widgets are skipped as selected-value sources;
  • source execution paths are retained for activity checks and removal of host-keyed candidates.

This branch is stacked on #13269, which extracts promoted-widget error clearing orchestration. The functional contract here follows #13059; the stack base is mainly to keep the promoted error-clearing work ordered.

Changes

  • What:
    • Scans promoted input widgets on SubgraphNode hosts for missing-media candidates.
    • Skips linked interior media widgets as candidate sources so stale interior values do not create duplicate or false media entries.
    • Splits media scan targets into:
      • host widget value and host candidate identity;
      • concrete source widget and source node definition data.
    • Resolves concrete source widgets for media node type, expected media widget name, combo options, and upload state.
    • Adds sourceExecutionId to promoted missing-media candidates so activity checks can follow the concrete source path while store identity remains host-keyed.
    • Uses source-aware candidate activity for the initial missing-media pipeline and async verification completion.
    • Removes host-keyed missing-media candidates when their interior source execution scope becomes inactive or is removed.
    • Reuses the existing ancestor host re-scan path so media candidates can reappear when an interior promoted source path becomes active again.
    • Adds unit coverage for nested promoted media scan identity, host-value/source-option separation, inactive intermediate subgraphs, async verification staleness, source-scope removal, plain linked widget skipping, and source-scope path-boundary edges.
  • Breaking: None expected.
  • Dependencies: None.

New Missing-Media Contract

A missing-media candidate is created from an unlinked final editable media value owner.

That value owner can be:

  • a normal media node widget; or
  • the outermost promoted media widget displayed on a SubgraphNode host.

For promoted media widgets:

  • the host promoted widget supplies the selected media value;
  • the host execution id and host widget name are the candidate identity;
  • the concrete source widget supplies combo options and media node metadata;
  • the concrete source node supplies upload state;
  • the concrete source execution path is retained as sourceExecutionId for activity checks only;
  • linked interior widgets are skipped as candidate sources because their values are not authoritative when driven by a promoted input.

For a nested chain:

Outer promoted widget A -> inner promoted widget B -> concrete media widget C

only A creates the candidate. B and C are linked along the promoted-input path and are skipped as selected-value sources, while C still supplies the concrete media widget definition used to evaluate A.

Source-Scope Activity

Promoted media candidates are stored and displayed with host identity, but their activity cannot be decided from the host id alone. A host-keyed candidate can depend on an interior source path that later becomes bypassed, muted, removed, or active again.

This PR therefore follows the same split as the missing-model path:

  • candidate identity: host execution id + host promoted widget name, used for storage, grouping, highlight, navigation, and clearing;
  • candidate activity: concrete source execution path, used for scan-time checks, pipeline filtering, async verification, source-scope removal, and re-exposure after mode changes.

The source-scope removal tests intentionally cover both exact source-path matches and numeric sibling path boundaries, so a scope such as 6 cannot remove candidates under 60:....

Review Focus

Please review the promoted media identity split carefully:

  • host promoted widgets should supply the candidate value and store identity;
  • concrete source widgets should supply media definition data and options;
  • linked interior widgets should not emit their own missing-media candidates;
  • sourceExecutionId should be used only for activity and source-scope removal;
  • async media verification should not surface stale promoted candidates after their source path becomes inactive;
  • normal non-subgraph media widgets should preserve existing behavior, except linked-input widgets are now skipped consistently with the promoted model/media contract.

Non-Goals

  • This PR does not change the missing-model contract from #13059.
  • This PR does not infer media values from serialized widget values.
  • This PR does not synchronize linked interior widget values back from promoted host widgets.
  • This PR does not add E2E coverage; the behavior is covered at scan/store/hook unit boundaries because the media path does not require new UI controls beyond the already-covered promoted widget surfaces.
  • This PR does not rename the shared scan-target vocabulary used by both missing model and missing media. That can be handled separately if we want a readability-only pass across both modules.

Validation

  • pnpm test:unit src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaStore.test.ts src/composables/graph/useErrorClearingHooks.test.ts
    • 3 files passed, 108 tests passed.
  • pnpm typecheck
  • pnpm format:check src/platform/missingMedia/missingMediaStore.ts src/platform/missingMedia/missingMediaStore.test.ts src/platform/missingMedia/missingMediaScan.test.ts
  • targeted oxlint --type-aware for changed missing-media files
  • commit hooks ran oxfmt, oxlint, eslint, and pnpm typecheck for staged files.
  • pre-push hook ran pnpm knip --cache.

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f15cd48c-9ad2-4bd3-86d8-9971b890dba4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaeone/promoted-missing-media-scan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jun 28, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1689 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1670 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 06/28/2026, 10:42:49 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 156ms TBT · 77.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 162.6 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 177.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 355ms
canvas-idle: script duration 15ms
canvas-idle: TBT 0ms
canvas-idle: heap used 53.9 MB
canvas-idle: DOM nodes 20
canvas-idle: event listeners 5
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 810ms
canvas-mouse-sweep: script duration 120ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 54.7 MB
canvas-mouse-sweep: DOM nodes -95
canvas-mouse-sweep: event listeners -98
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 289ms
canvas-zoom-sweep: script duration 18ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 57.9 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 323ms
dom-widget-clipping: script duration 55ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 63.7 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 9ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 11
large-graph-idle: task duration 506ms
large-graph-idle: script duration 89ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 59.4 MB
large-graph-idle: DOM nodes 21
large-graph-idle: event listeners 6
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 18ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 70
large-graph-pan: task duration 1011ms
large-graph-pan: script duration 381ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.7 MB
large-graph-pan: DOM nodes 18
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 18ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 1232ms
large-graph-zoom: script duration 461ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 65.8 MB
large-graph-zoom: DOM nodes 15
large-graph-zoom: event listeners 8
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 9
minimap-idle: task duration 486ms
minimap-idle: script duration 87ms
minimap-idle: TBT 0ms
minimap-idle: heap used 61.4 MB
minimap-idle: DOM nodes 17
minimap-idle: event listeners 6
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 348ms
subgraph-dom-widget-clipping: script duration 119ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 63.6 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 11
subgraph-idle: task duration 347ms
subgraph-idle: script duration 13ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 53.9 MB
subgraph-idle: DOM nodes 21
subgraph-idle: event listeners 4
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 644ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 46.2 MB
subgraph-mouse-sweep: DOM nodes 63
subgraph-mouse-sweep: event listeners 4
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 17
subgraph-transition-enter: task duration 726ms
subgraph-transition-enter: script duration 27ms
subgraph-transition-enter: TBT 156ms
subgraph-transition-enter: heap used 77.5 MB
subgraph-transition-enter: DOM nodes 13833
subgraph-transition-enter: event listeners 2533
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 53ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 3775ms
viewport-pan-sweep: script duration 1368ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.3 MB
viewport-pan-sweep: DOM nodes 18
viewport-pan-sweep: event listeners 20
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11980ms
vue-large-graph-idle: script duration 505ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 162.6 MB
vue-large-graph-idle: DOM nodes -3302
vue-large-graph-idle: event listeners -16376
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 65
vue-large-graph-pan: task duration 14182ms
vue-large-graph-pan: script duration 768ms
vue-large-graph-pan: TBT 0ms
vue-large-graph-pan: heap used 177.4 MB
vue-large-graph-pan: DOM nodes -3302
vue-large-graph-pan: event listeners -16371
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 5
workflow-execution: style recalc count 17
workflow-execution: task duration 111ms
workflow-execution: script duration 16ms
workflow-execution: TBT 0ms
workflow-execution: heap used 64.4 MB
workflow-execution: DOM nodes 162
workflow-execution: event listeners 70
Raw data
{
  "timestamp": "2026-06-28T10:52:34.407Z",
  "gitSha": "a9117f898e98cf03be90524bd3235772536e63d3",
  "branch": "jaeone/promoted-missing-media-scan",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2010.7739999999978,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.099000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.67,
      "heapDeltaBytes": -2374672,
      "heapUsedBytes": 56395792,
      "domNodes": 20,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 14.859,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2016.9520000000034,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.391,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 357.41399999999993,
      "heapDeltaBytes": -2218140,
      "heapUsedBytes": 56570704,
      "domNodes": 20,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 15.328,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2008.4429999999998,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.669000000000004,
      "layouts": 12,
      "layoutDurationMs": 3.443,
      "taskDurationMs": 899.368,
      "heapDeltaBytes": -12981700,
      "heapUsedBytes": 56135300,
      "domNodes": -245,
      "jsHeapTotalBytes": 19562496,
      "scriptDurationMs": 121.72099999999999,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1765.2089999999703,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.262,
      "layouts": 12,
      "layoutDurationMs": 3.2929999999999997,
      "taskDurationMs": 720.8489999999999,
      "heapDeltaBytes": -4213152,
      "heapUsedBytes": 58596616,
      "domNodes": 56,
      "jsHeapTotalBytes": 26476544,
      "scriptDurationMs": 117.986,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1706.9970000000012,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.608,
      "layouts": 6,
      "layoutDurationMs": 0.5109999999999999,
      "taskDurationMs": 289.217,
      "heapDeltaBytes": 1872392,
      "heapUsedBytes": 60666928,
      "domNodes": 77,
      "jsHeapTotalBytes": 25952256,
      "scriptDurationMs": 17.299000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1708.8929999999891,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.049,
      "layouts": 6,
      "layoutDurationMs": 0.715,
      "taskDurationMs": 288.16600000000005,
      "heapDeltaBytes": 1902268,
      "heapUsedBytes": 60671536,
      "domNodes": 77,
      "jsHeapTotalBytes": 25690112,
      "scriptDurationMs": 17.713,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 547.1390000000156,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.543,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 327.613,
      "heapDeltaBytes": 8528464,
      "heapUsedBytes": 67463904,
      "domNodes": 16,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 54.900999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 525.9140000000002,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.874000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 318.05799999999994,
      "heapDeltaBytes": 7389528,
      "heapUsedBytes": 66164416,
      "domNodes": 18,
      "jsHeapTotalBytes": 18612224,
      "scriptDurationMs": 55.55499999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2055.541000000005,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.382000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 519.0129999999999,
      "heapDeltaBytes": -9780836,
      "heapUsedBytes": 62309272,
      "domNodes": 22,
      "jsHeapTotalBytes": 10629120,
      "scriptDurationMs": 91.576,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2011.0129999999913,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.562999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.70500000000004,
      "heapDeltaBytes": -9787348,
      "heapUsedBytes": 62348912,
      "domNodes": 20,
      "jsHeapTotalBytes": 9318400,
      "scriptDurationMs": 86.925,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2085.8970000000454,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 18.585,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1009.876,
      "heapDeltaBytes": 10573488,
      "heapUsedBytes": 83603520,
      "domNodes": 18,
      "jsHeapTotalBytes": 10543104,
      "scriptDurationMs": 377.81499999999994,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2116.222999999991,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 18.398999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1012.9169999999998,
      "heapDeltaBytes": 10843176,
      "heapUsedBytes": 83627412,
      "domNodes": 18,
      "jsHeapTotalBytes": 9494528,
      "scriptDurationMs": 384.563,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3138.586000000032,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 19.088000000000005,
      "layouts": 60,
      "layoutDurationMs": 7.2540000000000004,
      "taskDurationMs": 1233.54,
      "heapDeltaBytes": 14247264,
      "heapUsedBytes": 69202932,
      "domNodes": 16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 463.943,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3031.8629999999303,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 17.794,
      "layouts": 60,
      "layoutDurationMs": 7.186,
      "taskDurationMs": 1230.839,
      "heapDeltaBytes": -5714968,
      "heapUsedBytes": 68798012,
      "domNodes": 14,
      "jsHeapTotalBytes": 9580544,
      "scriptDurationMs": 458.322,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.0469999999777,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.518000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.052,
      "heapDeltaBytes": -9087396,
      "heapUsedBytes": 64688564,
      "domNodes": 16,
      "jsHeapTotalBytes": 8007680,
      "scriptDurationMs": 89.35799999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2008.1710000000612,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.563,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.32800000000003,
      "heapDeltaBytes": -9479252,
      "heapUsedBytes": 64016232,
      "domNodes": 18,
      "jsHeapTotalBytes": 8007680,
      "scriptDurationMs": 85.57999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 564.3469999999979,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.56,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 346.77000000000004,
      "heapDeltaBytes": 7674880,
      "heapUsedBytes": 66555572,
      "domNodes": 20,
      "jsHeapTotalBytes": 19660800,
      "scriptDurationMs": 119.40200000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 546.9620000000077,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.588999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.00100000000003,
      "heapDeltaBytes": 7994492,
      "heapUsedBytes": 66861144,
      "domNodes": 20,
      "jsHeapTotalBytes": 19660800,
      "scriptDurationMs": 118.593,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2006.9819999999936,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 11.081,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 344.33000000000004,
      "heapDeltaBytes": -2444156,
      "heapUsedBytes": 56455212,
      "domNodes": 20,
      "jsHeapTotalBytes": 25165824,
      "scriptDurationMs": 13.046,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.769000000053,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.431000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.07,
      "heapDeltaBytes": -2217476,
      "heapUsedBytes": 56640620,
      "domNodes": 22,
      "jsHeapTotalBytes": 25427968,
      "scriptDurationMs": 13.609000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.3119999999917,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 33.751,
      "layouts": 16,
      "layoutDurationMs": 4.039,
      "taskDurationMs": 644.05,
      "heapDeltaBytes": -10497920,
      "heapUsedBytes": 48542752,
      "domNodes": 61,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 89.49799999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1700.918999999999,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 35.296,
      "layouts": 16,
      "layoutDurationMs": 3.811,
      "taskDurationMs": 643.8929999999999,
      "heapDeltaBytes": -10517376,
      "heapUsedBytes": 48331852,
      "domNodes": 65,
      "jsHeapTotalBytes": 26214400,
      "scriptDurationMs": 87.66,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 941.4579999999546,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 27.541999999999998,
      "layouts": 5,
      "layoutDurationMs": 14.034,
      "taskDurationMs": 725.6310000000001,
      "heapDeltaBytes": 4449992,
      "heapUsedBytes": 81245696,
      "domNodes": 13833,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 27.317000000000007,
      "eventListeners": 2533,
      "totalBlockingTimeMs": 156,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8157.082000000002,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 52.833,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3593.426,
      "heapDeltaBytes": -3599188,
      "heapUsedBytes": 68288336,
      "domNodes": 18,
      "jsHeapTotalBytes": 16572416,
      "scriptDurationMs": 1219.392,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8191.395999999941,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 52.297,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3955.9429999999998,
      "heapDeltaBytes": 9124856,
      "heapUsedBytes": 81214480,
      "domNodes": 18,
      "jsHeapTotalBytes": 26533888,
      "scriptDurationMs": 1516.1079999999997,
      "eventListeners": 20,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12039.764999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12016.704000000002,
      "heapDeltaBytes": -26369256,
      "heapUsedBytes": 169580552,
      "domNodes": -3302,
      "jsHeapTotalBytes": 18321408,
      "scriptDurationMs": 510.22300000000007,
      "eventListeners": -16376,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11963.319999999952,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11943.883000000002,
      "heapDeltaBytes": -14884284,
      "heapUsedBytes": 171386784,
      "domNodes": -3302,
      "jsHeapTotalBytes": 20709376,
      "scriptDurationMs": 499.73599999999993,
      "eventListeners": -16376,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14185.737000000017,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.208,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14163.141,
      "heapDeltaBytes": -6181928,
      "heapUsedBytes": 187627892,
      "domNodes": -3302,
      "jsHeapTotalBytes": 19021824,
      "scriptDurationMs": 770.732,
      "eventListeners": -16372,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14223.471999999902,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 16.182000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14200.61,
      "heapDeltaBytes": -12278432,
      "heapUsedBytes": 184316368,
      "domNodes": -3302,
      "jsHeapTotalBytes": 20594688,
      "scriptDurationMs": 765.846,
      "eventListeners": -16370,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.38099999999804,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 20.238,
      "layouts": 5,
      "layoutDurationMs": 1.4189999999999998,
      "taskDurationMs": 115.90700000000001,
      "heapDeltaBytes": 5368716,
      "heapUsedBytes": 65287428,
      "domNodes": 166,
      "jsHeapTotalBytes": 3407872,
      "scriptDurationMs": 16.112000000000002,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 452.2580000000289,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.27,
      "layouts": 4,
      "layoutDurationMs": 0.9800000000000002,
      "taskDurationMs": 105.48500000000001,
      "heapDeltaBytes": 4929448,
      "heapUsedBytes": 69728708,
      "domNodes": 157,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 15.581,
      "eventListeners": 71,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

@github-actions

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

@codecov

codecov Bot commented Jun 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                               Coverage Diff                               @@
##           jaeone/extract-promoted-widget-error-clearing   #13270    +/-   ##
===============================================================================
  Coverage                                          78.16%   78.16%            
===============================================================================
  Files                                               1634     1634            
  Lines                                             113766   113787    +21     
  Branches                                           38192    38837   +645     
===============================================================================
+ Hits                                               88920    88941    +21     
  Misses                                             23945    23945            
  Partials                                             901      901            
Flag Coverage Δ
unit 65.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/graph/useErrorClearingHooks.ts 96.15% <100.00%> (-0.06%) ⬇️
src/platform/missingMedia/missingMediaScan.ts 97.57% <100.00%> (+0.22%) ⬆️
src/platform/missingMedia/missingMediaStore.ts 88.80% <100.00%> (+1.18%) ⬆️
src/scripts/app.ts 78.26% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaeone94
jaeone94 force-pushed the jaeone/extract-promoted-widget-error-clearing branch from 31c4f2c to 1000fbe Compare July 2, 2026 00:36
@jaeone94

jaeone94 commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator Author

Closing — superseded by #14578, which landed the same change: missing-media error surfacing moved from the interior widget to the promoted host widget, matching the ADR 0009 ownership model.

That PR shipped it as a red-green pair (30 failing unit tests across 6 files plus 3 E2E scenarios, then the implementation), replaced the hardcoded MEDIA_NODE_WIDGETS map with the upload flags the backend already declares, and also closed the promotion half of the ownership transfer that this branch never reached.

This branch has been conflicting and untouched since early July, so there is nothing left here worth rebasing forward.

@jaeone94 jaeone94 closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant