Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1689 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-06-28T10:52:34.407Z",
"gitSha": "a9117f898e98cf03be90524bd3235772536e63d3",
"branch": "jaeone/promoted-missing-media-scan",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2010.7739999999978,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.099000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.67,
"heapDeltaBytes": -2374672,
"heapUsedBytes": 56395792,
"domNodes": 20,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 14.859,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2016.9520000000034,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.391,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.41399999999993,
"heapDeltaBytes": -2218140,
"heapUsedBytes": 56570704,
"domNodes": 20,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 15.328,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2008.4429999999998,
"styleRecalcs": 78,
"styleRecalcDurationMs": 47.669000000000004,
"layouts": 12,
"layoutDurationMs": 3.443,
"taskDurationMs": 899.368,
"heapDeltaBytes": -12981700,
"heapUsedBytes": 56135300,
"domNodes": -245,
"jsHeapTotalBytes": 19562496,
"scriptDurationMs": 121.72099999999999,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1765.2089999999703,
"styleRecalcs": 74,
"styleRecalcDurationMs": 35.262,
"layouts": 12,
"layoutDurationMs": 3.2929999999999997,
"taskDurationMs": 720.8489999999999,
"heapDeltaBytes": -4213152,
"heapUsedBytes": 58596616,
"domNodes": 56,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 117.986,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9970000000012,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.608,
"layouts": 6,
"layoutDurationMs": 0.5109999999999999,
"taskDurationMs": 289.217,
"heapDeltaBytes": 1872392,
"heapUsedBytes": 60666928,
"domNodes": 77,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 17.299000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.8929999999891,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.049,
"layouts": 6,
"layoutDurationMs": 0.715,
"taskDurationMs": 288.16600000000005,
"heapDeltaBytes": 1902268,
"heapUsedBytes": 60671536,
"domNodes": 77,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 17.713,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 547.1390000000156,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 327.613,
"heapDeltaBytes": 8528464,
"heapUsedBytes": 67463904,
"domNodes": 16,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 54.900999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 525.9140000000002,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.874000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.05799999999994,
"heapDeltaBytes": 7389528,
"heapUsedBytes": 66164416,
"domNodes": 18,
"jsHeapTotalBytes": 18612224,
"scriptDurationMs": 55.55499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.541000000005,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.382000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.0129999999999,
"heapDeltaBytes": -9780836,
"heapUsedBytes": 62309272,
"domNodes": 22,
"jsHeapTotalBytes": 10629120,
"scriptDurationMs": 91.576,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2011.0129999999913,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.562999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.70500000000004,
"heapDeltaBytes": -9787348,
"heapUsedBytes": 62348912,
"domNodes": 20,
"jsHeapTotalBytes": 9318400,
"scriptDurationMs": 86.925,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2085.8970000000454,
"styleRecalcs": 70,
"styleRecalcDurationMs": 18.585,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1009.876,
"heapDeltaBytes": 10573488,
"heapUsedBytes": 83603520,
"domNodes": 18,
"jsHeapTotalBytes": 10543104,
"scriptDurationMs": 377.81499999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2116.222999999991,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.398999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1012.9169999999998,
"heapDeltaBytes": 10843176,
"heapUsedBytes": 83627412,
"domNodes": 18,
"jsHeapTotalBytes": 9494528,
"scriptDurationMs": 384.563,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3138.586000000032,
"styleRecalcs": 67,
"styleRecalcDurationMs": 19.088000000000005,
"layouts": 60,
"layoutDurationMs": 7.2540000000000004,
"taskDurationMs": 1233.54,
"heapDeltaBytes": 14247264,
"heapUsedBytes": 69202932,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 463.943,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3031.8629999999303,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.794,
"layouts": 60,
"layoutDurationMs": 7.186,
"taskDurationMs": 1230.839,
"heapDeltaBytes": -5714968,
"heapUsedBytes": 68798012,
"domNodes": 14,
"jsHeapTotalBytes": 9580544,
"scriptDurationMs": 458.322,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.0469999999777,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.518000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.052,
"heapDeltaBytes": -9087396,
"heapUsedBytes": 64688564,
"domNodes": 16,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 89.35799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2008.1710000000612,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.32800000000003,
"heapDeltaBytes": -9479252,
"heapUsedBytes": 64016232,
"domNodes": 18,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 85.57999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 564.3469999999979,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.56,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.77000000000004,
"heapDeltaBytes": 7674880,
"heapUsedBytes": 66555572,
"domNodes": 20,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 119.40200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 546.9620000000077,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.588999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.00100000000003,
"heapDeltaBytes": 7994492,
"heapUsedBytes": 66861144,
"domNodes": 20,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 118.593,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2006.9819999999936,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.33000000000004,
"heapDeltaBytes": -2444156,
"heapUsedBytes": 56455212,
"domNodes": 20,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 13.046,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.769000000053,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.07,
"heapDeltaBytes": -2217476,
"heapUsedBytes": 56640620,
"domNodes": 22,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 13.609000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.3119999999917,
"styleRecalcs": 75,
"styleRecalcDurationMs": 33.751,
"layouts": 16,
"layoutDurationMs": 4.039,
"taskDurationMs": 644.05,
"heapDeltaBytes": -10497920,
"heapUsedBytes": 48542752,
"domNodes": 61,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 89.49799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.918999999999,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.296,
"layouts": 16,
"layoutDurationMs": 3.811,
"taskDurationMs": 643.8929999999999,
"heapDeltaBytes": -10517376,
"heapUsedBytes": 48331852,
"domNodes": 65,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 87.66,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 941.4579999999546,
"styleRecalcs": 17,
"styleRecalcDurationMs": 27.541999999999998,
"layouts": 5,
"layoutDurationMs": 14.034,
"taskDurationMs": 725.6310000000001,
"heapDeltaBytes": 4449992,
"heapUsedBytes": 81245696,
"domNodes": 13833,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 27.317000000000007,
"eventListeners": 2533,
"totalBlockingTimeMs": 156,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.082000000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 52.833,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3593.426,
"heapDeltaBytes": -3599188,
"heapUsedBytes": 68288336,
"domNodes": 18,
"jsHeapTotalBytes": 16572416,
"scriptDurationMs": 1219.392,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8191.395999999941,
"styleRecalcs": 250,
"styleRecalcDurationMs": 52.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3955.9429999999998,
"heapDeltaBytes": 9124856,
"heapUsedBytes": 81214480,
"domNodes": 18,
"jsHeapTotalBytes": 26533888,
"scriptDurationMs": 1516.1079999999997,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12039.764999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12016.704000000002,
"heapDeltaBytes": -26369256,
"heapUsedBytes": 169580552,
"domNodes": -3302,
"jsHeapTotalBytes": 18321408,
"scriptDurationMs": 510.22300000000007,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11963.319999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11943.883000000002,
"heapDeltaBytes": -14884284,
"heapUsedBytes": 171386784,
"domNodes": -3302,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 499.73599999999993,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14185.737000000017,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14163.141,
"heapDeltaBytes": -6181928,
"heapUsedBytes": 187627892,
"domNodes": -3302,
"jsHeapTotalBytes": 19021824,
"scriptDurationMs": 770.732,
"eventListeners": -16372,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14223.471999999902,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.182000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14200.61,
"heapDeltaBytes": -12278432,
"heapUsedBytes": 184316368,
"domNodes": -3302,
"jsHeapTotalBytes": 20594688,
"scriptDurationMs": 765.846,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.38099999999804,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.238,
"layouts": 5,
"layoutDurationMs": 1.4189999999999998,
"taskDurationMs": 115.90700000000001,
"heapDeltaBytes": 5368716,
"heapUsedBytes": 65287428,
"domNodes": 166,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 16.112000000000002,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 452.2580000000289,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.27,
"layouts": 4,
"layoutDurationMs": 0.9800000000000002,
"taskDurationMs": 105.48500000000001,
"heapDeltaBytes": 4929448,
"heapUsedBytes": 69728708,
"domNodes": 157,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 15.581,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
🎨 Storybook: 🚧 Building... |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## jaeone/extract-promoted-widget-error-clearing #13270 +/- ##
===============================================================================
Coverage 78.16% 78.16%
===============================================================================
Files 1634 1634
Lines 113766 113787 +21
Branches 38192 38837 +645
===============================================================================
+ Hits 88920 88941 +21
Misses 23945 23945
Partials 901 901
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
31c4f2c to
1000fbe
Compare
|
Closing — superseded by #14578, which landed the same change: missing-media error surfacing moved from the interior widget to the promoted host widget, matching the ADR 0009 ownership model. That PR shipped it as a red-green pair (30 failing unit tests across 6 files plus 3 E2E scenarios, then the implementation), replaced the hardcoded This branch has been conflicting and untouched since early July, so there is nothing left here worth rebasing forward. |
Summary
Align missing-media detection with the ADR 0009 promoted subgraph widget contract so media candidates are created from the editable host widget value while still using the concrete interior widget as the media schema and option source.
Why This PR Exists
This PR is a missing-media follow-up to the ADR 0009 / promoted subgraph widget work introduced by #12197, and to the missing-model contract redesign in #13059.
#12197 changed promoted subgraph widgets so the editable value belongs to the host
SubgraphNodewidget. Linked interior widgets are no longer guaranteed to mirror that selected value. #13059 updated missing-model detection around that contract: the host promoted widget is the selected-value owner, while the concrete interior widget remains the definition source for options, asset-browser eligibility, and node metadata.Missing media still had the older shape. It skipped subgraph hosts during full scans and keyed candidates only to concrete interior paths. That made media behavior diverge from the new promoted-widget model contract, especially for nested promoted inputs where the displayed value can live on the outer host while the media node type and combo options live on the leaf node.
This PR ports the same identity split to missing media:
This branch is stacked on #13269, which extracts promoted-widget error clearing orchestration. The functional contract here follows #13059; the stack base is mainly to keep the promoted error-clearing work ordered.
Changes
SubgraphNodehosts for missing-media candidates.sourceExecutionIdto promoted missing-media candidates so activity checks can follow the concrete source path while store identity remains host-keyed.New Missing-Media Contract
A missing-media candidate is created from an unlinked final editable media value owner.
That value owner can be:
SubgraphNodehost.For promoted media widgets:
sourceExecutionIdfor activity checks only;For a nested chain:
Outer promoted widget A -> inner promoted widget B -> concrete media widget Conly
Acreates the candidate.BandCare linked along the promoted-input path and are skipped as selected-value sources, whileCstill supplies the concrete media widget definition used to evaluateA.Source-Scope Activity
Promoted media candidates are stored and displayed with host identity, but their activity cannot be decided from the host id alone. A host-keyed candidate can depend on an interior source path that later becomes bypassed, muted, removed, or active again.
This PR therefore follows the same split as the missing-model path:
The source-scope removal tests intentionally cover both exact source-path matches and numeric sibling path boundaries, so a scope such as
6cannot remove candidates under60:....Review Focus
Please review the promoted media identity split carefully:
sourceExecutionIdshould be used only for activity and source-scope removal;Non-Goals
Validation
pnpm test:unit src/platform/missingMedia/missingMediaScan.test.ts src/platform/missingMedia/missingMediaStore.test.ts src/composables/graph/useErrorClearingHooks.test.tspnpm typecheckpnpm format:check src/platform/missingMedia/missingMediaStore.ts src/platform/missingMedia/missingMediaStore.test.ts src/platform/missingMedia/missingMediaScan.test.tsoxlint --type-awarefor changed missing-media filesoxfmt,oxlint,eslint, andpnpm typecheckfor staged files.pnpm knip --cache.