Repository navigation
Brand local node IDs - #13085
Brand local node IDs#13085
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughIntroduces a branded ChangesNode ID type rollout
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1688 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 7.66 MB gzip 🔴 +1.51 kBDetailsSummary
Category Glance App Entry Points — 47.3 kB (baseline 46.9 kB) • 🔴 +460 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.25 MB (baseline 1.25 MB) • 🔴 +1.31 kBGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 97.7 kB (baseline 97.7 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 3 unchanged Panels & Settings — 545 kB (baseline 546 kB) • 🟢 -285 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 16 unchanged User & Accounts — 26.9 kB (baseline 26.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 3 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed / 1 unchanged UI Components — 57.2 kB (baseline 57.2 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 269 kB (baseline 269 kB) • 🔴 +70 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 3.36 MB (baseline 3.36 MB) • 🔴 +5.87 kBHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 13 unchanged Vendor & Third-Party — 15.3 MB (baseline 15.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 11.1 MB (baseline 11.1 MB) • 🟢 -272 BBundles that do not match a named category
Status: 74 added / 74 removed / 91 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-06-26T22:44:28.947Z",
"gitSha": "333be50caed21b8af822dec2924f33cffa12768b",
"branch": "drjkl/brand-node-id",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2012.7990000000011,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.210999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.12399999999997,
"heapDeltaBytes": -2333328,
"heapUsedBytes": 56383484,
"domNodes": 16,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 15.089999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2023.5009999999534,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.711,
"heapDeltaBytes": -1916248,
"heapUsedBytes": 56869648,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 18.23,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.6569999999997,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.241,
"layouts": 12,
"layoutDurationMs": 3.855,
"taskDurationMs": 822.449,
"heapDeltaBytes": -6637776,
"heapUsedBytes": 52017636,
"domNodes": 62,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 118.85600000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1742.9010000000176,
"styleRecalcs": 71,
"styleRecalcDurationMs": 31.676999999999996,
"layouts": 12,
"layoutDurationMs": 3.4140000000000006,
"taskDurationMs": 710.385,
"heapDeltaBytes": -7049708,
"heapUsedBytes": 51714684,
"domNodes": 53,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 107.782,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0199999999763,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.864,
"layouts": 6,
"layoutDurationMs": 0.7109999999999999,
"taskDurationMs": 293.58700000000005,
"heapDeltaBytes": 1593760,
"heapUsedBytes": 60320692,
"domNodes": 77,
"jsHeapTotalBytes": 25427968,
"scriptDurationMs": 17.861,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.2760000000317,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.212,
"layouts": 6,
"layoutDurationMs": 0.5690000000000001,
"taskDurationMs": 297.074,
"heapDeltaBytes": 2038160,
"heapUsedBytes": 60777312,
"domNodes": 77,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 17.732999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 514.1040000000032,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.546999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 313.81499999999994,
"heapDeltaBytes": 7692024,
"heapUsedBytes": 66394560,
"domNodes": 20,
"jsHeapTotalBytes": 19136512,
"scriptDurationMs": 53.244,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 563.9740000000302,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.629,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.02,
"heapDeltaBytes": 7445076,
"heapUsedBytes": 66182404,
"domNodes": 22,
"jsHeapTotalBytes": 19660800,
"scriptDurationMs": 53.114999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 1995.1890000000105,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.113999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.98800000000006,
"heapDeltaBytes": -10588936,
"heapUsedBytes": 61526064,
"domNodes": 20,
"jsHeapTotalBytes": 10104832,
"scriptDurationMs": 77.77099999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.7639999999856,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.939,
"heapDeltaBytes": -9462632,
"heapUsedBytes": 61980248,
"domNodes": 20,
"jsHeapTotalBytes": 9580544,
"scriptDurationMs": 81.586,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2053.635999999983,
"styleRecalcs": 69,
"styleRecalcDurationMs": 20.517,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 965.6709999999999,
"heapDeltaBytes": 10131504,
"heapUsedBytes": 82907552,
"domNodes": 20,
"jsHeapTotalBytes": 10805248,
"scriptDurationMs": 343.81500000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2148.894000000041,
"styleRecalcs": 71,
"styleRecalcDurationMs": 21.756999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1008.2489999999999,
"heapDeltaBytes": 10334368,
"heapUsedBytes": 83389264,
"domNodes": 20,
"jsHeapTotalBytes": 13164544,
"scriptDurationMs": 367.486,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3103.7749999999846,
"styleRecalcs": 67,
"styleRecalcDurationMs": 21.259999999999998,
"layouts": 60,
"layoutDurationMs": 8.251999999999999,
"taskDurationMs": 1241.743,
"heapDeltaBytes": 13780472,
"heapUsedBytes": 68787876,
"domNodes": 16,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 468.891,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3120.4849999999738,
"styleRecalcs": 67,
"styleRecalcDurationMs": 21.247,
"layouts": 60,
"layoutDurationMs": 8.213999999999999,
"taskDurationMs": 1284.173,
"heapDeltaBytes": 15108444,
"heapUsedBytes": 70322320,
"domNodes": 16,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 507.3540000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2011.5499999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.119000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.409,
"heapDeltaBytes": -9318668,
"heapUsedBytes": 64596600,
"domNodes": 18,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 75.156,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2005.1080000000638,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.21,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.58900000000006,
"heapDeltaBytes": -8907308,
"heapUsedBytes": 64101824,
"domNodes": 22,
"jsHeapTotalBytes": 9842688,
"scriptDurationMs": 76.64000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 531.6740000000095,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.565,
"heapDeltaBytes": 7707688,
"heapUsedBytes": 66550836,
"domNodes": 20,
"jsHeapTotalBytes": 19922944,
"scriptDurationMs": 121.791,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.6700000000269,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.411,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.377,
"heapDeltaBytes": 7759152,
"heapUsedBytes": 66582904,
"domNodes": 22,
"jsHeapTotalBytes": 20185088,
"scriptDurationMs": 139.38,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.285999999998,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.667,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.20799999999997,
"heapDeltaBytes": -2237620,
"heapUsedBytes": 56582056,
"domNodes": 22,
"jsHeapTotalBytes": 26476544,
"scriptDurationMs": 13.029999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1995.6559999999968,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.272,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.285,
"heapDeltaBytes": -806600,
"heapUsedBytes": 60959952,
"domNodes": 24,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 13.517000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.5419999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.496,
"layouts": 16,
"layoutDurationMs": 4.1770000000000005,
"taskDurationMs": 636.495,
"heapDeltaBytes": -10531584,
"heapUsedBytes": 48509016,
"domNodes": 64,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 82.56700000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.209999999969,
"styleRecalcs": 76,
"styleRecalcDurationMs": 32.99,
"layouts": 16,
"layoutDurationMs": 3.838,
"taskDurationMs": 625.755,
"heapDeltaBytes": -10533544,
"heapUsedBytes": 48310796,
"domNodes": 62,
"jsHeapTotalBytes": 27000832,
"scriptDurationMs": 82.665,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 931.4880000000016,
"styleRecalcs": 15,
"styleRecalcDurationMs": 28.491999999999997,
"layouts": 4,
"layoutDurationMs": 12.437999999999999,
"taskDurationMs": 715.1590000000001,
"heapDeltaBytes": 4425616,
"heapUsedBytes": 80917560,
"domNodes": 13833,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 33.552,
"eventListeners": 2531,
"totalBlockingTimeMs": 158,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8141.063000000031,
"styleRecalcs": 250,
"styleRecalcDurationMs": 59.885999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3404.368,
"heapDeltaBytes": -4186708,
"heapUsedBytes": 67692544,
"domNodes": 20,
"jsHeapTotalBytes": 17358848,
"scriptDurationMs": 1131.675,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8166.195000000016,
"styleRecalcs": 251,
"styleRecalcDurationMs": 58.76,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3586.829,
"heapDeltaBytes": -1507612,
"heapUsedBytes": 70157356,
"domNodes": 20,
"jsHeapTotalBytes": 18931712,
"scriptDurationMs": 1205.786,
"eventListeners": 20,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12634.427999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12617.842999999999,
"heapDeltaBytes": -12361064,
"heapUsedBytes": 170968964,
"domNodes": -3302,
"jsHeapTotalBytes": 21467136,
"scriptDurationMs": 501.178,
"eventListeners": -16378,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13011.596999999938,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12998.740000000002,
"heapDeltaBytes": -31541352,
"heapUsedBytes": 170828576,
"domNodes": -3302,
"jsHeapTotalBytes": 20942848,
"scriptDurationMs": 498.77399999999994,
"eventListeners": -16376,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15229.858000000037,
"styleRecalcs": 75,
"styleRecalcDurationMs": 19.928,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15205.365,
"heapDeltaBytes": -31917948,
"heapUsedBytes": 180936836,
"domNodes": -3302,
"jsHeapTotalBytes": 17973248,
"scriptDurationMs": 786.101,
"eventListeners": -16370,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15297.001000000022,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.44499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15272.438000000002,
"heapDeltaBytes": -26055160,
"heapUsedBytes": 172942224,
"domNodes": -3303,
"jsHeapTotalBytes": 20418560,
"scriptDurationMs": 760.87,
"eventListeners": -16370,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 447.0959999999877,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.206999999999997,
"layouts": 5,
"layoutDurationMs": 1.472,
"taskDurationMs": 108.517,
"heapDeltaBytes": 5368376,
"heapUsedBytes": 65450260,
"domNodes": 168,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 16.472,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 119.88900000005742,
"styleRecalcs": 11,
"styleRecalcDurationMs": 16.165,
"layouts": 4,
"layoutDurationMs": 1.232,
"taskDurationMs": 85.34700000000001,
"heapDeltaBytes": 3434116,
"heapUsedBytes": 63314464,
"domNodes": 144,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 14.068999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (3)
src/types/nodeIdentification.ts (1)
107-113: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winValidate serialized node IDs before branding them.
These helpers can still mint invalid IDs after the signature widening. For example,
createNodeLocatorId(uuid, '')returns${uuid}:, andcreateNodeExecutionId([123, ''])returns123:, but both values fail the corresponding parser/guard APIs. Since these entry points now accept rawSerializedNodeId, they should normalize each segment through the dedicated node-id helper layer and reject empty inputs before casting.Based on learnings, if a new ID brand is needed, its constructor/parser helpers should live in
src/types/*Id.tsand be used everywhere else instead of re-stringifying at call sites.Also applies to: 133-152
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/types/nodeIdentification.ts` around lines 107 - 113, The ID constructors are minting branded values from raw SerializedNodeId inputs without validation, so empty segments can produce values that fail the existing parsers/guards. Update createNodeLocatorId and createNodeExecutionId to route each segment through the dedicated node-id helper/parser layer, reject empty or invalid inputs before casting, and avoid re-stringifying branded IDs at the call sites.Source: Learnings
src/lib/litegraph/src/LGraphNode.ts (1)
497-505: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winSkip layout-store writes until the node has a real ID.
Line 505 and Line 527 still run during construction, when
this.idis the sentinel-1andthis.graphis unset. That means every unattached node writes its initial position/size under the same branded layout key, so fresh nodes can overwrite each other before the graph assigns a real ID.Suggested fix
public set pos(value) { if (!value || value.length < 2) return this._pos[0] = value[0] this._pos[1] = value[1] + if (this.id === -1 || !this.graph) return const mutations = useLayoutMutations() mutations.setSource(LayoutSource.Canvas) mutations.moveNode(toNodeId(this.id), { x: value[0], y: value[1] }) } @@ public set size(value) { if (!value || value.length < 2) return this._size[0] = value[0] this._size[1] = value[1] + if (this.id === -1 || !this.graph) return const mutations = useLayoutMutations() mutations.setSource(LayoutSource.Canvas) mutations.resizeNode(toNodeId(this.id), { width: value[0], height: value[1]Also applies to: 519-530
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/litegraph/src/LGraphNode.ts` around lines 497 - 505, Skip layout-store writes in LGraphNode’s pos and size setters until the node has a real graph-assigned ID. Guard the useLayoutMutations() calls in set pos and the related size path so they only run when this.id is not the sentinel -1 and this.graph is available, otherwise just update the local _pos/_size fields. Keep the layout sync logic in place for attached nodes, but avoid calling mutations.moveNode or the corresponding size mutation during construction.src/renderer/extensions/vueNodes/components/NodeWidgets.test.ts (1)
24-28: 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick winKeep
rootGraph.idat the graph-id boundary.Line 28 brands
rootGraph.idasNodeId, but this fixture is modeling the graph identifier, not a local node identifier. That makes the test less representative and can hide graph-id/node-id mixups because both brands erase to plain strings at runtime.Suggested fix
const GRAPH_ID = 'graph-test' useCanvasStore: () => ({ canvas: { graph: { rootGraph: { - id: toNodeId('graph-test') + id: GRAPH_ID } } } })🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/renderer/extensions/vueNodes/components/NodeWidgets.test.ts` around lines 24 - 28, The test fixture in NodeWidgets.test.ts is branding rootGraph.id as a NodeId via toNodeId, but it should model a graph identifier instead; update the mock in useCanvasStore so rootGraph.id uses the graph-id boundary/brand (matching the graph identifier type used elsewhere) and keep node-id branding for actual nodes only. This keeps the fixture representative and avoids masking graph-id versus node-id mixups in components like rootGraph and related NodeWidgets tests.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/renderer/extensions/linearMode/AppOutput.vue`:
- Around line 16-17: The SerializedNodeId comparison in matchesThis should not
use loose equality, since coercion can match the wrong output and affect
selectedOutputs handling. Update the comparison logic in matchesThis within
AppOutput.vue to compare normalized values explicitly (for example, by
converting both sides to the same type before checking equality) so only the
intended node ID matches.
In `@src/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.ts`:
- Around line 424-425: The cached canvas access in useSlotLinkInteraction should
be guarded before reading graph, since app.canvas may still be unavailable
during setup. Update the node lookup logic around canvas and nodeId so it first
verifies the canvas object exists, then safely accesses
canvas.graph?.getNodeById(nodeId) only when ready; if canvas is missing, return
null or skip the lookup to avoid a runtime throw.
---
Outside diff comments:
In `@src/lib/litegraph/src/LGraphNode.ts`:
- Around line 497-505: Skip layout-store writes in LGraphNode’s pos and size
setters until the node has a real graph-assigned ID. Guard the
useLayoutMutations() calls in set pos and the related size path so they only run
when this.id is not the sentinel -1 and this.graph is available, otherwise just
update the local _pos/_size fields. Keep the layout sync logic in place for
attached nodes, but avoid calling mutations.moveNode or the corresponding size
mutation during construction.
In `@src/renderer/extensions/vueNodes/components/NodeWidgets.test.ts`:
- Around line 24-28: The test fixture in NodeWidgets.test.ts is branding
rootGraph.id as a NodeId via toNodeId, but it should model a graph identifier
instead; update the mock in useCanvasStore so rootGraph.id uses the graph-id
boundary/brand (matching the graph identifier type used elsewhere) and keep
node-id branding for actual nodes only. This keeps the fixture representative
and avoids masking graph-id versus node-id mixups in components like rootGraph
and related NodeWidgets tests.
In `@src/types/nodeIdentification.ts`:
- Around line 107-113: The ID constructors are minting branded values from raw
SerializedNodeId inputs without validation, so empty segments can produce values
that fail the existing parsers/guards. Update createNodeLocatorId and
createNodeExecutionId to route each segment through the dedicated node-id
helper/parser layer, reject empty or invalid inputs before casting, and avoid
re-stringifying branded IDs at the call sites.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4529b98c-189e-49e3-aab3-4806bd2fe4c7
📒 Files selected for processing (146)
AGENTS.mdsrc/components/builder/AppModeWidgetList.vuesrc/components/curve/WidgetCurve.test.tssrc/components/graph/GraphCanvas.vuesrc/components/graph/widgets/TextPreviewWidget.test.tssrc/components/graph/widgets/TextPreviewWidget.vuesrc/components/imagecrop/WidgetImageCrop.test.tssrc/components/imagecrop/WidgetImageCrop.vuesrc/components/load3d/Load3D.test.tssrc/components/load3d/Load3D.vuesrc/components/load3d/Load3DAdvanced.test.tssrc/components/load3d/Load3DAdvanced.vuesrc/components/painter/WidgetPainter.vuesrc/components/range/WidgetRange.test.tssrc/components/rightSidePanel/parameters/SectionWidgets.vuesrc/components/rightSidePanel/parameters/TabNodes.vuesrc/components/rightSidePanel/parameters/TabNormalInputs.vuesrc/components/rightSidePanel/parameters/TabSubgraphInputs.vuesrc/components/rightSidePanel/parameters/WidgetActions.vuesrc/components/rightSidePanel/parameters/WidgetItem.vuesrc/components/rightSidePanel/shared.tssrc/composables/canvas/useSelectedLiteGraphItems.test.tssrc/composables/canvas/useSelectionToolboxPosition.tssrc/composables/graph/useArrangeNodes.tssrc/composables/graph/useGraphNodeManager.test.tssrc/composables/graph/useGraphNodeManager.tssrc/composables/graph/useVueNodeLifecycle.tssrc/composables/maskeditor/useMaskEditorLoader.tssrc/composables/node/useNodePricing.tssrc/composables/painter/usePainter.test.tssrc/composables/painter/usePainter.tssrc/composables/useImageCrop.test.tssrc/composables/useImageCrop.tssrc/composables/useUpstreamValue.test.tssrc/composables/useWorkflowStatusDismissal.tssrc/core/graph/subgraph/migration/proxyWidgetMigration.tssrc/core/graph/subgraph/preview/previewExposureChain.tssrc/core/graph/subgraph/promotedInputWidget.tssrc/core/graph/subgraph/promotedWidgetTypes.tssrc/core/graph/subgraph/promotionUtils.tssrc/core/graph/subgraph/resolveConcretePromotedWidget.tssrc/core/graph/subgraph/resolveSubgraphInputTarget.tssrc/extensions/core/load3dLazy.test.tssrc/lib/litegraph/src/LGraphCanvas.cloneZIndex.test.tssrc/lib/litegraph/src/LGraphCanvas.slotHitDetection.test.tssrc/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LGraphNode.tssrc/platform/assets/utils/outputAssetUtil.tssrc/platform/workflow/management/stores/comfyWorkflow.tssrc/platform/workflow/management/stores/workflowStore.test.tssrc/platform/workflow/management/stores/workflowStore.tssrc/renderer/core/canvas/canvasStore.tssrc/renderer/core/canvas/links/linkConnectorAdapter.tssrc/renderer/core/canvas/links/linkDropOrchestrator.tssrc/renderer/core/canvas/links/slotLinkDragUIState.tssrc/renderer/core/canvas/litegraph/litegraphLinkAdapter.tssrc/renderer/core/canvas/litegraph/slotCalculations.tssrc/renderer/core/layout/operations/layoutMutations.test.tssrc/renderer/core/layout/operations/layoutMutations.tssrc/renderer/core/layout/slots/slotIdentifier.tssrc/renderer/core/layout/store/layoutStore.test.tssrc/renderer/core/layout/store/layoutStore.tssrc/renderer/core/layout/sync/syncLayoutStoreFromGraph.tssrc/renderer/core/layout/sync/useLayoutSync.tssrc/renderer/core/layout/types.tssrc/renderer/core/layout/utils/layoutMath.test.tssrc/renderer/core/layout/utils/mappers.test.tssrc/renderer/core/layout/utils/mappers.tssrc/renderer/extensions/linearMode/AppOutput.vuesrc/renderer/extensions/minimap/composables/useMinimapGraph.tssrc/renderer/extensions/minimap/data/AbstractMinimapDataSource.tssrc/renderer/extensions/minimap/data/LayoutStoreDataSource.tssrc/renderer/extensions/minimap/data/LiteGraphDataSource.tssrc/renderer/extensions/minimap/data/MinimapDataSource.test.tssrc/renderer/extensions/minimap/types.tssrc/renderer/extensions/vueNodes/VideoPreview.vuesrc/renderer/extensions/vueNodes/components/ImagePreview.vuesrc/renderer/extensions/vueNodes/components/InputSlot.vuesrc/renderer/extensions/vueNodes/components/LGraphNode.subgraph.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.test.tssrc/renderer/extensions/vueNodes/components/LGraphNode.vuesrc/renderer/extensions/vueNodes/components/LGraphNodePreview.vuesrc/renderer/extensions/vueNodes/components/NodeContent.vuesrc/renderer/extensions/vueNodes/components/NodeHeader.test.tssrc/renderer/extensions/vueNodes/components/NodeSlots.test.tssrc/renderer/extensions/vueNodes/components/NodeSlots.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.test.tssrc/renderer/extensions/vueNodes/components/NodeWidgets.vuesrc/renderer/extensions/vueNodes/components/OutputSlot.test.tssrc/renderer/extensions/vueNodes/components/OutputSlot.vuesrc/renderer/extensions/vueNodes/composables/slotLinkDragContext.tssrc/renderer/extensions/vueNodes/composables/useNodeEventHandlers.test.tssrc/renderer/extensions/vueNodes/composables/useNodeEventHandlers.tssrc/renderer/extensions/vueNodes/composables/useNodePointerInteractions.test.tssrc/renderer/extensions/vueNodes/composables/useNodePointerInteractions.tssrc/renderer/extensions/vueNodes/composables/useNodeZIndex.test.tssrc/renderer/extensions/vueNodes/composables/useNodeZIndex.tssrc/renderer/extensions/vueNodes/composables/usePartitionedBadges.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.tssrc/renderer/extensions/vueNodes/composables/useSlotElementTracking.test.tssrc/renderer/extensions/vueNodes/composables/useSlotElementTracking.tssrc/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.test.tssrc/renderer/extensions/vueNodes/composables/useVueNodeResizeTracking.tssrc/renderer/extensions/vueNodes/interactions/resize/useNodeResize.tssrc/renderer/extensions/vueNodes/layout/useNodeDrag.test.tssrc/renderer/extensions/vueNodes/layout/useNodeDrag.tssrc/renderer/extensions/vueNodes/layout/useNodeLayout.tssrc/renderer/extensions/vueNodes/preview/useNodePreviewState.tssrc/renderer/extensions/vueNodes/stores/nodeSlotRegistryStore.tssrc/renderer/extensions/vueNodes/widgets/components/DisplayCarousel.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetDOM.test.tssrc/renderer/extensions/vueNodes/widgets/components/WidgetDOM.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetLegacy.vuesrc/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.test.tssrc/renderer/extensions/vueNodes/widgets/components/WidgetRecordAudio.vuesrc/renderer/extensions/vueNodes/widgets/composables/useProgressTextWidget.tssrc/renderer/glsl/useGLSLPreview.tssrc/renderer/glsl/useGLSLUniforms.tssrc/scripts/app.tssrc/services/litegraphService.tssrc/services/load3dService.tssrc/services/subgraphPseudoWidgetCache.test.tssrc/services/subgraphPseudoWidgetCache.tssrc/stores/appModeStore.tssrc/stores/executionErrorStore.tssrc/stores/maskEditorDataStore.test.tssrc/stores/maskEditorDataStore.tssrc/stores/nodeOutputStore.tssrc/stores/previewExposureStore.tssrc/stores/queueStore.tssrc/stores/widgetValueStore.tssrc/stores/workspace/favoritedWidgetsStore.tssrc/types/AGENTS.mdsrc/types/extensionTypes.tssrc/types/index.tssrc/types/nodeId.test.tssrc/types/nodeId.tssrc/types/nodeIdentification.test.tssrc/types/nodeIdentification.tssrc/types/simplifiedWidget.tssrc/types/widgetId.tssrc/types/widgetState.tssrc/utils/litegraphUtil.test.tssrc/utils/litegraphUtil.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/litegraph/src/LGraph.ts`:
- Line 240: The node index and related link caches are using plain object
records with SerializedNodeId keys, which can collide after stringification and
break mixed-ID lookups. Update LGraph’s _nodes_by_id, visited_links, and
remaining_links to use Map-based storage or a shared normalized-key helper, and
adjust getNodeById() plus the execution-order traversal code to read/write
through that same mechanism so IDs remain distinct.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: a5056c85-7e3c-4028-8b64-47f634a9da5a
📒 Files selected for processing (44)
src/components/builder/AppBuilder.vuesrc/components/sidebar/tabs/queue/MediaLightbox.test.tssrc/composables/graph/useMoreOptionsMenu.tssrc/composables/node/usePromotedPreviews.tssrc/lib/litegraph/src/LGraph.test.tssrc/lib/litegraph/src/LGraph.tssrc/lib/litegraph/src/LGraphCanvas.tssrc/lib/litegraph/src/LGraphNode.tssrc/lib/litegraph/src/LLink.tssrc/lib/litegraph/src/Reroute.tssrc/lib/litegraph/src/canvas/FloatingRenderLink.tssrc/lib/litegraph/src/canvas/MovingLinkBase.tssrc/lib/litegraph/src/infrastructure/LGraphCanvasEventMap.tssrc/lib/litegraph/src/infrastructure/LGraphEventMap.tssrc/lib/litegraph/src/interfaces.tssrc/lib/litegraph/src/linkDeduplication.tssrc/lib/litegraph/src/litegraph.tssrc/lib/litegraph/src/subgraph/ExecutableNodeDTO.tssrc/lib/litegraph/src/subgraph/SubgraphIONodeBase.tssrc/lib/litegraph/src/subgraph/SubgraphInputNode.tssrc/lib/litegraph/src/subgraph/SubgraphNode.tssrc/lib/litegraph/src/subgraph/SubgraphOutputNode.tssrc/lib/litegraph/src/subgraph/__fixtures__/subgraphHelpers.tssrc/lib/litegraph/src/subgraph/subgraphDeduplication.tssrc/lib/litegraph/src/types/NodeLike.tssrc/lib/litegraph/src/types/graphTriggers.tssrc/lib/litegraph/src/types/serialisation.tssrc/lib/litegraph/src/types/widgets.tssrc/lib/litegraph/src/widgets/BaseWidget.tssrc/platform/missingMedia/missingMediaScan.tssrc/platform/missingMedia/types.tssrc/platform/missingModel/types.tssrc/platform/workflow/core/utils/workflowFlattening.tssrc/platform/workflow/validation/schemas/workflowSchema.tssrc/scripts/api.tssrc/scripts/app.tssrc/stores/appModeStore.test.tssrc/stores/executionStore.tssrc/stores/subgraphStore.tssrc/types/litegraph-augmentation.d.tssrc/utils/errorReportUtil.tssrc/utils/executionErrorUtil.tssrc/utils/linkFixer.tssrc/utils/migration/migrateReroute.ts
💤 Files with no reviewable changes (1)
- src/platform/workflow/validation/schemas/workflowSchema.ts
✅ Files skipped from review due to trivial changes (5)
- src/lib/litegraph/src/subgraph/SubgraphInputNode.ts
- src/components/builder/AppBuilder.vue
- src/utils/linkFixer.ts
- src/lib/litegraph/src/subgraph/fixtures/subgraphHelpers.ts
- src/stores/subgraphStore.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/types/nodeIdentification.ts`:
- Around line 36-40: Validate each ID component before branding it so composed
IDs cannot contain the reserved ':' separator. Update requireNodeIdSegment to
reject any parsed value that would split locator/execution IDs, and apply the
same component validation in createNodeExecutionId and createNodeLocatorId
before returning branded values. Use parseNodeId, requireNodeIdSegment,
createNodeExecutionId, createNodeLocatorId, and isNodeLocatorId as the key
places to align the checks so branded IDs always round-trip correctly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 06392ace-1be9-48c6-9a44-60a6cd78e456
📒 Files selected for processing (6)
src/lib/litegraph/src/LGraphNode.tssrc/renderer/extensions/linearMode/AppOutput.vuesrc/renderer/extensions/vueNodes/components/NodeWidgets.test.tssrc/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.tssrc/types/nodeIdentification.test.tssrc/types/nodeIdentification.ts
🚧 Files skipped from review as they are similar to previous changes (4)
- src/renderer/extensions/linearMode/AppOutput.vue
- src/types/nodeIdentification.test.ts
- src/renderer/extensions/vueNodes/composables/useSlotLinkInteraction.ts
- src/lib/litegraph/src/LGraphNode.ts
bd3a0ee to
82108ea
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
browser_tests/fixtures/VueNodeHelpers.ts (1)
255-256: 🎯 Functional Correctness | 🟡 MinorParse slot keys from the tail
NodeIdis not numeric-only here; string IDs with-are used elsewhere, sokey.split('-')can misreadrawNodeId/type/slotId. Parse from the end instead so hyphenated node ids stay intact.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@browser_tests/fixtures/VueNodeHelpers.ts` around lines 255 - 256, The slot-key parsing in VueNodeHelpers is incorrectly splitting from the front, which breaks hyphenated node IDs. Update the parsing logic around the key.split usage so it extracts slotId and type from the tail and keeps the full rawNodeId intact before passing it to toNodeId. Make the change in the helper that handles these node keys so NodeId values containing dashes are preserved.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@browser_tests/fixtures/VueNodeHelpers.ts`:
- Around line 255-256: The slot-key parsing in VueNodeHelpers is incorrectly
splitting from the front, which breaks hyphenated node IDs. Update the parsing
logic around the key.split usage so it extracts slotId and type from the tail
and keeps the full rawNodeId intact before passing it to toNodeId. Make the
change in the helper that handles these node keys so NodeId values containing
dashes are preserved.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 825ef087-c82a-486b-bc04-07718569cfba
📒 Files selected for processing (4)
browser_tests/fixtures/VueNodeHelpers.tssrc/composables/canvas/useSelectionToolboxPosition.test.tssrc/composables/canvas/useSelectionToolboxPosition.tssrc/lib/litegraph/src/subgraph/SubgraphSerialization.test.ts
Removed loading of default workflow in color picker test.
017ac08 to
541885a
Compare
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/composables/graph/useGraphNodeManager.ts (1)
510-528: 🩺 Stability & Availability | 🟡 Minor | ⚡ Quick winNormalize map keys to
toNodeId(node.id)LiteGraph can still assign numeric node IDs by default, while the event handlers here look up entries through
toNodeId(...). KeynodeRefsandvueNodeDatawith the same normalized ID shape, or these updates will miss for numeric IDs.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/composables/graph/useGraphNodeManager.ts` around lines 510 - 528, The node synchronization in useGraphNodeManager is mixing raw LiteGraph IDs with normalized IDs, which can break lookups for numeric node IDs. Update the add/update and delete paths to consistently use toNodeId(node.id) when reading, writing, and removing entries in nodeRefs and vueNodeData, matching the event handlers’ ID normalization so all node updates target the same key shape.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/composables/graph/useGraphNodeManager.ts`:
- Around line 510-528: The node synchronization in useGraphNodeManager is mixing
raw LiteGraph IDs with normalized IDs, which can break lookups for numeric node
IDs. Update the add/update and delete paths to consistently use
toNodeId(node.id) when reading, writing, and removing entries in nodeRefs and
vueNodeData, matching the event handlers’ ID normalization so all node updates
target the same key shape.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 484cec55-02e1-4698-931d-a035122267e6
📒 Files selected for processing (20)
AGENTS.mdbrowser_tests/tests/propertiesPanel/errorsTabCloudMissingModels.spec.tssrc/components/rightSidePanel/parameters/SectionWidgets.test.tssrc/components/rightSidePanel/parameters/SectionWidgets.vuesrc/composables/graph/useErrorClearingHooks.test.tssrc/composables/graph/useErrorClearingHooks.tssrc/composables/graph/useGraphNodeManager.tssrc/core/graph/subgraph/promotedWidgetTypes.tssrc/core/graph/subgraph/resolveConcretePromotedWidget.tssrc/platform/missingModel/missingModelScan.test.tssrc/platform/missingModel/missingModelStore.test.tssrc/platform/missingModel/types.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.test.tssrc/renderer/extensions/vueNodes/composables/useProcessedWidgets.tssrc/services/litegraphService.tssrc/stores/executionErrorStore.tssrc/stores/subgraphStore.tssrc/types/nodeIdentification.tssrc/utils/graphTraversalUtil.test.tssrc/utils/graphTraversalUtil.ts
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
71e95f1
Summary
Adds a branded local
NodeIdhelper and starts separating local node identity from serialized workflow IDs.Changes
NodeIdparsing/branding helpers, migrates nearby widget identity types, keeps queue results at the serialized boundary, and removes misleading workflowNodeIdusage from execution error maps.Review Focus
Check that the first migration slice keeps serialized/API IDs as raw
number | stringwhile local UI/store IDs use the branded string type.Caveat
SUBGRAPH_INPUT_IDandSUBGRAPH_OUTPUT_IDare now branded localNodeIdstring values internally instead of numeric sentinels. Reviewers should double-check extension compatibility for callers that importConstantsand compare those values numerically.Screenshots (if applicable)
N/A