Repository navigation
feat(assets): group model library by model_type tags (FE-1076) #12948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
synap5e
merged 18 commits into
main
from
synap5e/fe-1076-fe-group-the-model-library-by-model_type-tags
Jul 28, 2026
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d435968
feat(assets): group model library by model_type tags
synap5e 01a51fc
refactor(assets): gate model_type grouping on supports_model_type_tags
synap5e 86faaee
refactor(assets): run model-asset store on non-cloud builds
synap5e 1897ec5
fix(assets): strip model_type: prefix from asset card type badge
synap5e 31c043e
fix(assets): strip model_type: prefix from the asset browser title
synap5e 979f01f
fix(assets): port model_type node-category resolution to resolveModel…
synap5e c8af4c5
fix(assets): keep reserved-tag constants local in assetMetadataUtils
synap5e 7117caf
test(assets): restore mocks after each resolveModelNodeFromAsset test
synap5e ccc6a1f
fix(assets): prefer resolvable model_type over incidental slash tags
synap5e c34bef8
fix(assets): align badge and loader resolution with model_type tags
synap5e 09877d7
fix(assets): surface refresh errors and harden pagination races
synap5e ece07cc
fix(assets): close pagination-termination and title-preservation gaps
synap5e d43ecf8
fix(assets): represent every category of a shared multi-type asset
synap5e 74e4e38
fix(assets): dedupe category candidates and share pagination tolerance
synap5e 8c3b946
test(assets): align cache tests with cursor pagination
synap5e b7c0e2d
fix(assets): exclude model_type: tags from legacy model folder list
synap5e 61210a2
fix(assets): keep is_immutable-omitting assets in ownership views
synap5e 1ba23b5
fix(assets): give asset browser search and upload accessible names
synap5e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: (non-blocking) two accessibility gaps in this file (pre-existing, but newly exercised by the upload and search paths):
1. Upload button -- no accessible name in icon mode: below 880 px the button renders icon-only; the label span is CSS-hidden with no
aria-labelfallback. Violates WCAG 2.1 SC 4.1.2. Fix: add:aria-label="$t('assetBrowser.uploadModel')"to the Button.2. SearchInput -- no accessible name:
SearchInputdoes not forwardaria-labelto its inner input, and placeholder text alone does not satisfy SC 4.1.2. Fix: add anaria-labelprop toSearchInputforwarded to the input, or wrap with a visually-hidden label.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both valid and pre-existing (this PR just newly exercises the upload and search paths). Taking them as a follow-up rather than widening this PR's scope, the fixes are small (
aria-labelon the icon-mode upload button, and forwardingaria-labelthroughSearchInput) but they touch shared components beyond the model_type grouping this PR is about.Posted by Claude Code on Simon's behalf.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Simon. Flagging our standard here: we're not deferring review items out of the PR that surfaces them — an "address later" without a tracked, linked owner is how these silently rot, and both of these are small, self-contained fixes. Let's land them in this PR rather than as an unbacked follow-up.
Concrete fix (both are additive, no behavior change to the grouping this PR is about):
:aria-label="$t('assetBrowser.uploadModel')"to the Button so it has an accessible name below 880px.aria-labelprop forwarded to the inner input (or wrap with a visually-hidden label). Placeholder text alone does not satisfy WCAG 2.1 SC 4.1.2.If touching the shared
SearchInputgenuinely can't ride here, then this thread stays open with a linked issue and an owner before merge — not resolved as "follow-up". Keeping it open.