Repository navigation
docs(litegraph): mark subgraph building blocks as @internal - #12232
christian-byrne wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe change marks internal subgraph classes, interfaces, and helper functions with ChangesSubgraph
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change narrows the future published API surface without changing runtime behavior, so no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
Full details: Description checkExplanation The description clearly explains the documentation-only change, affected symbols, preserved external-facing symbols, TypeDoc intent, validation, and sequencing. It does not use every template heading, but it provides the required information in equivalent sections. Full details: End-To-End Regression Coverage For FixesExplanation PASS. The PR title does not contain bug-fix language, and the description identifies the work as documentation-only. The custom check therefore does not require an end-to-end regression test under Full details: Website End-To-End Regression CoverageExplanation No website runtime files changed. The listed files are under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation PASS. The PR changes only files under ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.35 MB gzip 🔴 +3 BDetailsSummary
Category Glance App Entry Points — 31.8 kB (baseline 31.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.6 kB (baseline 82.6 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 526 kB (baseline 526 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 14 unchanged User & Accounts — 17.7 kB (baseline 17.7 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 57.9 kB (baseline 57.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 8 unchanged Data & Services — 3.16 MB (baseline 3.16 MB) • 🔴 +283 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 369 kB (baseline 369 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 19 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 9.13 MB (baseline 9.13 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 85 unchanged ⚡ Performance
🎭 Playwright: ✅ 1901 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ❌ FailedDetails⏰ Completed at: 09/02/2026, 09:24:01 PM UTC Links
📦 Bundle: 9.68 MB gzip 🔴 +66 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • 🔴 +255 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 18 added / 18 removed / 18 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category
Status: 72 added / 72 removed / 223 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T21:33:52.838Z",
"gitSha": "6e032a01e4f968aa9ec1c90b9c1d531e460b1828",
"branch": "litegraph/subgraph-internal-tags",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2104.5070000000123,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.154000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.007,
"heapDeltaBytes": -12481116,
"heapUsedBytes": 57269080,
"domNodes": -278,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 13.492000000000004,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2064.206000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.004999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.341,
"heapDeltaBytes": -12523444,
"heapUsedBytes": 57165788,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.168000000000001,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1993.600000000015,
"styleRecalcs": 82,
"styleRecalcDurationMs": 44.405,
"layouts": 14,
"layoutDurationMs": 4.787000000000001,
"taskDurationMs": 1011.8249999999999,
"heapDeltaBytes": -8245208,
"heapUsedBytes": 61489848,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 175.861,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1874.3030000000545,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.552,
"layouts": 14,
"layoutDurationMs": 4.640999999999999,
"taskDurationMs": 925.708,
"heapDeltaBytes": -8511916,
"heapUsedBytes": 61869248,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 162.989,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1684.4750000000204,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.898000000000003,
"layouts": 6,
"layoutDurationMs": 1.0589999999999997,
"taskDurationMs": 352.498,
"heapDeltaBytes": 5112268,
"heapUsedBytes": 75823600,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.231999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8890000000092,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.012,
"layouts": 6,
"layoutDurationMs": 1.0610000000000002,
"taskDurationMs": 350.642,
"heapDeltaBytes": 5016388,
"heapUsedBytes": 75835644,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.136999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 623.9269999999806,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.991000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.386,
"heapDeltaBytes": -8118720,
"heapUsedBytes": 62586360,
"domNodes": 22,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 161.57100000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.5729999999721,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.574000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.16099999999994,
"heapDeltaBytes": -8094088,
"heapUsedBytes": 62563752,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 160.896,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.8020000000133,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.100999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.646,
"heapDeltaBytes": 11708800,
"heapUsedBytes": 87029280,
"domNodes": -265,
"jsHeapTotalBytes": -1409024,
"scriptDurationMs": 36.247,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2055.209999999988,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.555999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.792,
"heapDeltaBytes": 11685164,
"heapUsedBytes": 86847512,
"domNodes": -270,
"jsHeapTotalBytes": -1671168,
"scriptDurationMs": 31.939999999999998,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2274.7120000000223,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.178999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1589.4419999999998,
"heapDeltaBytes": 19094592,
"heapUsedBytes": 84495384,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 807.7629999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2282.3920000000726,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.056000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.6660000000002,
"heapDeltaBytes": 23246028,
"heapUsedBytes": 88706660,
"domNodes": -277,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 821.329,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3489.4029999999816,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.365000000000002,
"layouts": 60,
"layoutDurationMs": 11.519000000000002,
"taskDurationMs": 1631.5020000000002,
"heapDeltaBytes": 8035780,
"heapUsedBytes": 75818876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 754.971,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3579.789000000005,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.540000000000001,
"layouts": 60,
"layoutDurationMs": 12.034999999999997,
"taskDurationMs": 1689.702,
"heapDeltaBytes": 9834740,
"heapUsedBytes": 76427980,
"domNodes": -7,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 770.385,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3032.987999999989,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.814000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1871.227,
"heapDeltaBytes": 17052728,
"heapUsedBytes": 84864140,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 935.6909999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3122.9419999999664,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.952000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1943.691,
"heapDeltaBytes": 22329220,
"heapUsedBytes": 89252240,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 963.7889999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.981999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5500000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.021,
"heapDeltaBytes": 22186316,
"heapUsedBytes": 88069196,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.458,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.496999999965,
"styleRecalcs": 4,
"styleRecalcDurationMs": 7.831000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 599.8430000000001,
"heapDeltaBytes": 11255316,
"heapUsedBytes": 87162144,
"domNodes": -272,
"jsHeapTotalBytes": -1933312,
"scriptDurationMs": 36.537,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.3859999999959,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.419999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.674,
"heapDeltaBytes": 15172540,
"heapUsedBytes": 88005172,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.06,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 636.2729999999601,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.84100000000007,
"heapDeltaBytes": 15178864,
"heapUsedBytes": 88171232,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.40699999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.7810000000327,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.693,
"heapDeltaBytes": -8673384,
"heapUsedBytes": 64152212,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.084,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.0330000000786,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.949999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.33400000000006,
"heapDeltaBytes": -14823144,
"heapUsedBytes": 58088752,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.686000000000002,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.8999999999855,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.171,
"layouts": 18,
"layoutDurationMs": 5.465999999999999,
"taskDurationMs": 812.753,
"heapDeltaBytes": 3179908,
"heapUsedBytes": 75664380,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.70599999999999,
"eventListeners": -228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.3600000000852,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.231,
"layouts": 18,
"layoutDurationMs": 4.9030000000000005,
"taskDurationMs": 809.677,
"heapDeltaBytes": -8366420,
"heapUsedBytes": 64436592,
"domNodes": -297,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 108.375,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.9929999999713,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.741,
"layouts": 15,
"layoutDurationMs": 16.479000000000003,
"taskDurationMs": 934.2320000000002,
"heapDeltaBytes": 69496,
"heapUsedBytes": 97912996,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.065999999999995,
"eventListeners": 2381,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8462.651999999991,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.175999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5818.6,
"heapDeltaBytes": -9484964,
"heapUsedBytes": 90683876,
"domNodes": -266,
"jsHeapTotalBytes": -98304,
"scriptDurationMs": 2749.3720000000003,
"eventListeners": -134,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8450.31400000005,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.958999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5778.892,
"heapDeltaBytes": 12520824,
"heapUsedBytes": 88411128,
"domNodes": -271,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 2667.681,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16588.27599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15637.758,
"heapDeltaBytes": -37046184,
"heapUsedBytes": 174119404,
"domNodes": -6548,
"jsHeapTotalBytes": -8441856,
"scriptDurationMs": 268.206,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17486.466999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16780.801999999996,
"heapDeltaBytes": -39418200,
"heapUsedBytes": 174350884,
"domNodes": -6548,
"jsHeapTotalBytes": -7282688,
"scriptDurationMs": 328.19300000000004,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21025.43800000001,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.558000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20670.622,
"heapDeltaBytes": -28158636,
"heapUsedBytes": 180620368,
"domNodes": -6548,
"jsHeapTotalBytes": -4694016,
"scriptDurationMs": 947.856,
"eventListeners": -7469,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20988.627000000066,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.326999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20638.894,
"heapDeltaBytes": -41527528,
"heapUsedBytes": 162673512,
"domNodes": -6552,
"jsHeapTotalBytes": 1851392,
"scriptDurationMs": 959.179,
"eventListeners": -7469,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6307.142999999996,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.13800000000005,
"layouts": 20,
"layoutDurationMs": 22.145999999999987,
"taskDurationMs": 6181.7080000000005,
"heapDeltaBytes": -24420124,
"heapUsedBytes": 180378500,
"domNodes": -6547,
"jsHeapTotalBytes": 17805312,
"scriptDurationMs": 119.74799999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 400,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6311.263000000054,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.93100000000003,
"layouts": 20,
"layoutDurationMs": 22.72700000000001,
"taskDurationMs": 6157.838,
"heapDeltaBytes": -27494888,
"heapUsedBytes": 182137824,
"domNodes": -6548,
"jsHeapTotalBytes": 7913472,
"scriptDurationMs": 114.40899999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 391,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8918.839000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8502.183,
"heapDeltaBytes": 6326692,
"heapUsedBytes": 174597292,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 158.771,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8452.740999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8169.879999999999,
"heapDeltaBytes": 2921500,
"heapUsedBytes": 176047152,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 134.108,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 102.85900000008041,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.424,
"layouts": 3,
"layoutDurationMs": 0.9370000000000002,
"taskDurationMs": 72.53600000000002,
"heapDeltaBytes": 3108984,
"heapUsedBytes": 71902312,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.416000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 124.24199999998109,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.403000000000002,
"layouts": 2,
"layoutDurationMs": 0.7559999999999999,
"taskDurationMs": 83.233,
"heapDeltaBytes": 3088156,
"heapUsedBytes": 71964040,
"domNodes": 111,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.331999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #12232 +/- ##
==========================================
+ Coverage 80.82% 82.43% +1.60%
==========================================
Files 2444 2032 -412
Lines 124795 117492 -7303
Branches 33024 29494 -3530
==========================================
- Hits 100869 96857 -4012
+ Misses 23423 20457 -2966
+ Partials 503 178 -325
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 429 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Custom node ecosystem search — breaking change validationThis PR adds Symbols tagged
Ecosystem cross-checkSampled the bigger-name symbols ( ConclusionNot a breaking change for custom nodes. Pure documentation/API-surface metadata. The only downstream effect is that anyone running API-extractor with |
Per AUDIT-LG.9 §subgraph correction, these subgraph cluster exports are internal building blocks with no production importers — they leak into the published @comfyorg/extension-api ABI but should not be part of the public surface: - EmptySubgraphInput, EmptySubgraphOutput - SubgraphSlot (SubgraphSlotBase.ts), SubgraphIONodeBase - PromotedWidgetViewManager - subgraphDeduplication (deduplicateSubgraphNodeIds, topologicalSortSubgraphs) - subgraphUtils (splitPositionables, getBoundaryLinks, multiClone, groupResolvedByOutput, mapSubgraphInputsAndLinks, mapSubgraphOutputsAndLinks, getDirectSubgraphIds, findUsedSubgraphIds, isSubgraphInput, isSubgraphOutput, isNodeSlot) - SubgraphOutput Add @internal JSDoc tags so TypeDoc (with excludeInternal: true) strips them from the published ABI. Preserves SubgraphNode, Subgraph, SubgraphInput, ExecutableNodeDTO, and subgraphTest/createTestSubgraph test fixtures — those are external-facing.
19ca845 to
b4785ed
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Rebased onto current Two conflicts:
Evidence
|
Tightens the published
@comfyorg/extension-apiABI by marking subgraph cluster building blocks@internalper AUDIT-LG.9 §subgraph correction.Marked @internal
EmptySubgraphInput,EmptySubgraphOutputSubgraphSlot(inSubgraphSlotBase.ts),SubgraphIONodeBasePromotedWidgetViewManagersubgraphDeduplicationexports (deduplicateSubgraphNodeIds,topologicalSortSubgraphs)subgraphUtilsexports (splitPositionables,getBoundaryLinks,multiClone,groupResolvedByOutput,mapSubgraphInputsAndLinks,mapSubgraphOutputsAndLinks,getDirectSubgraphIds,findUsedSubgraphIds,isSubgraphInput,isSubgraphOutput,isNodeSlot)SubgraphOutputPreserves (external-facing)
SubgraphNode,Subgraph,SubgraphInputExecutableNodeDTOsubgraphTest/createTestSubgraph*/subgraphHelpers(test fixtures)Effect
TypeDoc (with
excludeInternal: true) will strip the marked exports from the published@comfyorg/extension-apiABI snapshot once that pipeline lands (PKG2). The tags are inert today but encode the public/internal boundary at the source so the cluster surface is correct when TypeDoc starts running.TypeDoc config
packages/extension-api/does not exist onmainyet (PKG2 work), so there is no TypeDoc config to update in this PR. The@internaltags are forward-compatible with the standard TypeDocexcludeInternal: truedefault.Quality gates (Node 24)
pnpm lint: cleanpnpm format:check: cleanpnpm knip: clean (no new unused exports — all marked symbols still have internal callers)Sequencing
┆Issue is synchronized with this Notion page by Unito