Skip to content

[Phase A · Foundation] ext-api/i-foundation — declarations + service rename + scope registry - #12102

Closed
christian-byrne wants to merge 10 commits into
mainfrom
ext-api/i-foundation
Closed

christian-byrne wants to merge 10 commits into
mainfrom
ext-api/i-foundation

Conversation

@christian-byrne

@christian-byrne christian-byrne commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

Stack root for Phase A child PRs. Coworkers converting core extensions should branch off this branch.

Stacks on: #12101 (Phase A base — research bundle + first-pass surface)

Three foundation commits (in order)

  1. refactor(extension-api): polish public declaration files (D5/D6/D7/D10) — src/extension-api/{index,lifecycle,node,widget}.ts, names appendix (DOC1.E6), AGENTS.md
  2. feat(extension-api): rename to extension-api-service.ts + boot wiring (MIG1.E5) — canonical extension-api-service.ts, app boot wiring, sample *.v2.ts extensions aligned to refreshed surface
  3. feat(extension-api): scope registry + ECS world skeleton (I-SR.2) — src/world/ (entities/components/NodeEntityId), scope-registry.test.ts per D10 + D12

What stacks on this

  • ext-api/i-tf — test framework reorg + harness + content fill (I-TF.2/3/6)
  • ext-api/i-ext — three new core extension conversions (I-EXT)
  • future — coworker (Simon/Austin) extension-conversion PRs

Known minor

The deletion of the old src/services/extensionV2Service.ts ended up in the i-tf child PR rather than alongside the rename here. Final merged state is correct; flagging for reviewer awareness.

Refs

D5 events typing · D6 parallel paths · D7 widget shape · D10 lifecycle · D12 scope clone-on-copy · MIG1.E4/E5 boot wiring

Draft for review collaboration via inline comments.

┆Issue is synchronized with this Notion page by Unito

@coderabbitai

coderabbitai Bot commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec20ece8-211e-4bfd-a04f-47b9f6b3392b

📥 Commits

Reviewing files that changed from the base of the PR and between e010c47 and c614243.

📒 Files selected for processing (2)
  • .github/workflows/ci-tests-extension-api.yaml
  • src/services/extension-api-service.ts
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/ci-tests-extension-api.yaml
  • src/services/extension-api-service.ts

📝 Walkthrough

Walkthrough

This PR establishes a typed, publishable Extension API v2 (with barrel entry), a detailed handle/lifecycle/event service, stubs for ECS/world/entity integration, full shell/UI/option/event contract surfaces, upgrades core extensions to v2, wires app bootstrap through new services, brings a robust test harness, full backward-compat/migration test matrix, dedicated CI/docs tooling, and extensive cross-layer naming documentation.

Changes

Extension API v2: Public Surface, Core, Compatibility/Migration Test System, ECS, CI, and Naming Docs

Layer / File(s) Summary
Public API Barrel and Authoring Docs
src/extension-api/index.ts, src/extension-api/README.md, AGENTS.md, packages/extension-api/README.md, .github/workflows/ci-tests-extension-api.yaml, package.json scripts, packages/extension-api/*, vitest.extension-api.config.mts, docs/architecture/extension-api-v2/names-appendix.md
Defines the official extension API barrel entry point, public contract types, authoring guidelines, naming consistency docs, CI workflows, package configuration, and docs build infrastructure.
Node, Widget, Lifecycle, Events, Shell, and Identity Types
src/extension-api/node.ts, src/extension-api/widget.ts, src/extension-api/lifecycle.ts, src/extension-api/events.ts, src/extension-api/shell.ts, src/extension-api/identifiers.ts
Implements all core v2 Extension API contracts, including strongly typed node and widget handles, lifecycle options and hooks, event interfaces, shell UI extension types, and node identity helpers.
ECS World, ComponentKey, and Widget ECS Identity Stubs
src/world/entityIds.ts, src/world/componentKey.ts, src/world/worldInstance.ts, src/world/widgets/widgetComponents.ts
Provides Phase A stub modules for ECS world integration, entity id branding, component key factories, and widget component keys employed by handles and service layers; includes test-time mocking hooks.
Service Layer: Extension Lifecycle, Handles, and Reactive Management
src/services/extension-api-service.ts
Implements the extension lifecycle service using Vue effect scopes, synchronous lifecycle helpers, extension registration/mount/unmount, reactive node/widget handle creation, and app-level extension lifecycle invocation.
Extension Service Lifecycle Test Suite
src/services/__tests__/scope-registry.test.ts
Tests extension lifecycle hook invocation, scope creation/idempotency, copy/paste state isolation, and routing based on workflow mount status against a mocked ECS world.
Core Extensions V2 and Registry Updates
src/extensions/core/dynamicPrompts.v2.ts, src/extensions/core/imageCrop.v2.ts, src/extensions/core/previewAny.v2.ts, src/extensions/core/index.ts
Adds core v2 extensions including dynamic prompt support with serialization hooks, image cropping with size clamping, preview-any node with toggleable display, and updates core extension registration to use v2 modules.
App Bootstrap Integration with Extension Service
src/scripts/app.ts
Adjusts app setup to initialize and start the new extension system, replacing legacy extension lifecycle calls while keeping node registration and drop handlers intact.
Backward Compatibility, Contract, and Migration Test Suite Matrix
src/extension-api-v2/__tests__/**/*, src/extension-api-v2/__tests__/migration/*, src/extension-api-v2/__tests__/v1/*, src/extension-api-v2/__tests__/v2/*
Comprehensive test coverage scaffolding for BC/migration/contract tests across all significant lifecycle events, behaviors, and APIs for both v1 and v2 surfaces, including placeholder TODOs for future assertions.
Test Harness and Evidence Registry
src/extension-api-v2/harness.ts
Provides a lightweight in-memory test harness for extension contracts, including a mock world, simplified graph, and an evidence snippet registry used by compatibility test suites.

Sequence Diagram(s)

sequenceDiagram
    AppBootstrap->>ExtensionAPIService: startExtensionSystem(), invokeV2AppExtensions()
    ExtensionAPIService->>ECSWorld: entitiesWith(NodeTypeKey)
    ExtensionAPIService->>ExtensionCoreV2: mount extension scopes, run v2 hooks
    ExtensionAPIService->>TestHarness: expose handles/APIs for contract tests
Loading

Estimated code review effort

🎯 5 (Critical) | ⏱️ ~120 minutes

Poem

From barrel to bunny, the code hops anew,
With handles and hooks—and all types are true!
Naming's mapped, contracts test each layer,
ECS world stubs await future repair.
Extensions now v2, tests flow and CI sings,
Reviewers, take courage—and check all the things!
🐇✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ext-api/i-foundation

@github-actions

github-actions Bot commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/11/2026, 03:50:46 AM UTC

Links

@github-actions

github-actions Bot commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ -3 passed, 3 failed

❌ Failed Tests

📊 Browser Reports
  • chromium: ❌ Deployment failed
  • chromium-2x: View Report
  • chromium-0.5x: View Report
  • mobile-chrome: ❌ Deployment failed

@github-actions

github-actions Bot commented May 9, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.31 MB gzip 🔴 +4.2 kB

Details

Summary

  • Raw size: 24.5 MB baseline 24.5 MB — 🔴 +16.4 kB
  • Gzip: 5.31 MB baseline 5.3 MB — 🔴 +4.2 kB
  • Brotli: 4.1 MB baseline 4.1 MB — 🔴 +3.45 kB
  • Bundles: 260 current • 260 baseline • 183 added / 183 removed

Category Glance
Data & Services 🔴 +14 kB (3.15 MB) · Other 🔴 +2.32 kB (8.98 MB) · Vendor & Third-Party 🔴 +36 B (9.94 MB) · Graph Workspace 🔴 +1 B (1.24 MB) · Panels & Settings ⚪ 0 B (491 kB) · Utilities & Hooks ⚪ 0 B (367 kB) · + 5 more

App Entry Points — 31.6 kB (baseline 31.6 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-Bb8XR4iG.js (removed) 31.6 kB — 🟢 -31.6 kB 🟢 -9.81 kB 🟢 -8.46 kB
assets/index-C5JQlKhU.js (new) — 31.6 kB 🔴 +31.6 kB 🔴 +9.81 kB 🔴 +8.47 kB

Status: 1 added / 1 removed

Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🔴 +1 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-DSzeXvvl.js (new) — 1.24 MB 🔴 +1.24 MB 🔴 +265 kB 🔴 +199 kB
assets/GraphView-BtImCyFY.js (removed) 1.24 MB — 🟢 -1.24 MB 🟢 -265 kB 🟢 -199 kB

Status: 1 added / 1 removed

Views & Navigation — 82.4 kB (baseline 82.4 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-BDudCday.js (new) — 19.6 kB 🔴 +19.6 kB 🔴 +5.14 kB 🔴 +4.57 kB
assets/CloudSurveyView-InHtSi9Q.js (removed) 19.6 kB — 🟢 -19.6 kB 🟢 -5.13 kB 🟢 -4.57 kB
assets/CloudLoginView-BmpUOu3f.js (removed) 12.5 kB — 🟢 -12.5 kB 🟢 -3.51 kB 🟢 -3.1 kB
assets/CloudLoginView-H_wnNaOO.js (new) — 12.5 kB 🔴 +12.5 kB 🔴 +3.51 kB 🔴 +3.11 kB
assets/CloudSignupView-CKyCAKT6.js (new) — 10.3 kB 🔴 +10.3 kB 🔴 +3.02 kB 🔴 +2.65 kB
assets/CloudSignupView-D57QbIUS.js (removed) 10.3 kB — 🟢 -10.3 kB 🟢 -3.03 kB 🟢 -2.67 kB
assets/UserCheckView-Bj1-pV1X.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.34 kB 🔴 +2.04 kB
assets/UserCheckView-DurRHSoP.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.33 kB 🟢 -2.04 kB
assets/CloudLayoutView-BI-KeZ63.js (new) — 7.73 kB 🔴 +7.73 kB 🔴 +2.45 kB 🔴 +2.14 kB
assets/CloudLayoutView-Pyem83vv.js (removed) 7.73 kB — 🟢 -7.73 kB 🟢 -2.45 kB 🟢 -2.14 kB
assets/CloudForgotPasswordView-B_EDgDDA.js (new) — 6.14 kB 🔴 +6.14 kB 🔴 +2.18 kB 🔴 +1.92 kB
assets/CloudForgotPasswordView-Bzh-qURM.js (removed) 6.14 kB — 🟢 -6.14 kB 🟢 -2.18 kB 🟢 -1.92 kB
assets/CloudAuthTimeoutView-BX2KCJRe.js (removed) 5.5 kB — 🟢 -5.5 kB 🟢 -2.02 kB 🟢 -1.77 kB
assets/CloudAuthTimeoutView-CAo2M5rp.js (new) — 5.5 kB 🔴 +5.5 kB 🔴 +2.02 kB 🔴 +1.78 kB
assets/CloudSubscriptionRedirectView-C4OHd8Gr.js (new) — 5.28 kB 🔴 +5.28 kB 🔴 +2 kB 🔴 +1.79 kB
assets/CloudSubscriptionRedirectView-piOAbOtR.js (removed) 5.28 kB — 🟢 -5.28 kB 🟢 -2 kB 🟢 -1.8 kB
assets/UserSelectView-BQSY2Kd-.js (new) — 4.7 kB 🔴 +4.7 kB 🔴 +1.74 kB 🔴 +1.55 kB
assets/UserSelectView-BwZFltwr.js (removed) 4.7 kB — 🟢 -4.7 kB 🟢 -1.74 kB 🟢 -1.55 kB
assets/CloudSorryContactSupportView-BRoTZ0pe.js (removed) 1.21 kB — 🟢 -1.21 kB 🟢 -603 B 🟢 -523 B
assets/CloudSorryContactSupportView-DFU7wGJp.js (new) — 1.21 kB 🔴 +1.21 kB 🔴 +604 B 🔴 +528 B
assets/layout-CaWpmMr0.js (removed) 385 B — 🟢 -385 B 🟢 -267 B 🟢 -217 B
assets/layout-Da1hHXzg.js (new) — 385 B 🔴 +385 B 🔴 +269 B 🔴 +218 B

Status: 11 added / 11 removed

Panels & Settings — 491 kB (baseline 491 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-6ahZg42H.js (new) — 47.4 kB 🔴 +47.4 kB 🔴 +9.83 kB 🔴 +8.73 kB
assets/KeybindingPanel-CMoxWvxP.js (removed) 47.4 kB — 🟢 -47.4 kB 🟢 -9.84 kB 🟢 -8.72 kB
assets/SecretsPanel-DruKJ30P.js (removed) 22.9 kB — 🟢 -22.9 kB 🟢 -5.54 kB 🟢 -4.87 kB
assets/SecretsPanel-DWWnvHY8.js (new) — 22.9 kB 🔴 +22.9 kB 🔴 +5.54 kB 🔴 +4.87 kB
assets/LegacyCreditsPanel-C20yBN4y.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +5.91 kB 🔴 +5.23 kB
assets/LegacyCreditsPanel-v3_5nlZt.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -5.91 kB 🟢 -5.21 kB
assets/SubscriptionPanel-C9P70rjd.js (new) — 20 kB 🔴 +20 kB 🔴 +5.11 kB 🔴 +4.49 kB
assets/SubscriptionPanel-D98J3eNE.js (removed) 20 kB — 🟢 -20 kB 🟢 -5.11 kB 🟢 -4.52 kB
assets/AboutPanel-C27QHoaH.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.33 kB 🟢 -2.98 kB
assets/AboutPanel-DEqaXCV7.js (new) — 12 kB 🔴 +12 kB 🔴 +3.33 kB 🔴 +2.99 kB
assets/ExtensionPanel-BH-1dycT.js (removed) 9.97 kB — 🟢 -9.97 kB 🟢 -2.91 kB 🟢 -2.58 kB
assets/ExtensionPanel-yvQQB281.js (new) — 9.97 kB 🔴 +9.97 kB 🔴 +2.91 kB 🔴 +2.59 kB
assets/ServerConfigPanel-CsLrUHAL.js (new) — 7.05 kB 🔴 +7.05 kB 🔴 +2.36 kB 🔴 +2.11 kB
assets/ServerConfigPanel-DDCtRNqq.js (removed) 7.05 kB — 🟢 -7.05 kB 🟢 -2.36 kB 🟢 -2.1 kB
assets/UserPanel-C29EvUMO.js (removed) 6.76 kB — 🟢 -6.76 kB 🟢 -2.24 kB 🟢 -1.96 kB
assets/UserPanel-CKoA_vDY.js (new) — 6.76 kB 🔴 +6.76 kB 🔴 +2.25 kB 🔴 +1.97 kB
assets/cloudRemoteConfig-BpVhugtX.js (removed) 2.05 kB — 🟢 -2.05 kB 🟢 -991 B 🟢 -850 B
assets/cloudRemoteConfig-DHzNHZ7Q.js (new) — 2.05 kB 🔴 +2.05 kB 🔴 +989 B 🔴 +853 B
assets/refreshRemoteConfig-T8TaBqMU.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +649 B 🔴 +552 B
assets/refreshRemoteConfig-yoU1hkPB.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -648 B 🟢 -555 B

Status: 10 added / 10 removed / 12 unchanged

User & Accounts — 17.6 kB (baseline 17.6 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/PasswordFields-CovJmm-H.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.42 kB 🔴 +1.26 kB
assets/PasswordFields-CUDU_N3Q.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.42 kB 🟢 -1.25 kB
assets/auth-ClGKnDxK.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.29 kB 🔴 +1.11 kB
assets/auth-D4_MBQb1.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.29 kB 🟢 -1.1 kB
assets/SignUpForm-CUV0uIj9.js (new) — 3.19 kB 🔴 +3.19 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/SignUpForm-DEMNKY4b.js (removed) 3.19 kB — 🟢 -3.19 kB 🟢 -1.29 kB 🟢 -1.16 kB
assets/UpdatePasswordContent-CQ8VI61x.js (new) — 2.9 kB 🔴 +2.9 kB 🔴 +1.3 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-QvvDxVau.js (removed) 2.9 kB — 🟢 -2.9 kB 🟢 -1.3 kB 🟢 -1.15 kB
assets/WorkspaceProfilePic-D88PDmG_.js (removed) 1.66 kB — 🟢 -1.66 kB 🟢 -860 B 🟢 -748 B
assets/WorkspaceProfilePic-Y8BMODz0.js (new) — 1.66 kB 🔴 +1.66 kB 🔴 +862 B 🔴 +749 B
assets/authStore-Bx_3exRG.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -568 B 🟢 -502 B
assets/authStore-DgZCNW-9.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +563 B 🔴 +501 B
assets/auth-CH2DaSK5.js (new) — 348 B 🔴 +348 B 🔴 +215 B 🔴 +186 B
assets/auth-CMKyKR9B.js (removed) 348 B — 🟢 -348 B 🟢 -215 B 🟢 -189 B

Status: 7 added / 7 removed

Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-Cwj7qxyW.js (new) — 85.8 kB 🔴 +85.8 kB 🔴 +18.6 kB 🔴 +15.9 kB
assets/ComfyHubPublishDialog-DFfvuEQx.js (removed) 85.8 kB — 🟢 -85.8 kB 🟢 -18.6 kB 🟢 -15.9 kB
assets/useShareDialog-21vBpLw5.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +5.78 kB 🔴 +5.13 kB
assets/useShareDialog-HMs-1-G3.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -5.78 kB 🟢 -5.13 kB
assets/ComfyHubPublishDialog-DzDZLDFA.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -631 B 🟢 -571 B
assets/ComfyHubPublishDialog-PZrN-zfA.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +626 B 🔴 +556 B
assets/useSubscriptionDialog-9hhVB9T8.js (removed) 1.17 kB — 🟢 -1.17 kB 🟢 -561 B 🟢 -491 B
assets/useSubscriptionDialog-B5kTe48F.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +558 B 🔴 +489 B

Status: 4 added / 4 removed

UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-BRJifQKy.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/ComfyQueueButton-D_SPj01B.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/useTerminalTabs-C1VAC5Bz.js (new) — 11 kB 🔴 +11 kB 🔴 +3.73 kB 🔴 +3.28 kB
assets/useTerminalTabs-D3_Z3TgO.js (removed) 11 kB — 🟢 -11 kB 🟢 -3.73 kB 🟢 -3.28 kB
assets/TopbarBadge-B7wkvLuD.js (removed) 7.62 kB — 🟢 -7.62 kB 🟢 -1.87 kB 🟢 -1.64 kB
assets/TopbarBadge-Cj8tAZSg.js (new) — 7.62 kB 🔴 +7.62 kB 🔴 +1.87 kB 🔴 +1.64 kB
assets/ScrubableNumberInput-nOPtJWpe.js (new) — 6.27 kB 🔴 +6.27 kB 🔴 +2.13 kB 🔴 +1.88 kB
assets/ScrubableNumberInput-rH45omnc.js (removed) 6.27 kB — 🟢 -6.27 kB 🟢 -2.13 kB 🟢 -1.89 kB
assets/FormSearchInput-_JPk3wYq.js (removed) 5.11 kB — 🟢 -5.11 kB 🟢 -2.12 kB 🟢 -1.83 kB
assets/FormSearchInput-DDbOlPiN.js (new) — 5.11 kB 🔴 +5.11 kB 🔴 +2.12 kB 🔴 +1.83 kB
assets/toggle-group-CAQ3xe-M.js (removed) 4.03 kB — 🟢 -4.03 kB 🟢 -1.42 kB 🟢 -1.25 kB
assets/toggle-group-SR8T9M42.js (new) — 4.03 kB 🔴 +4.03 kB 🔴 +1.42 kB 🔴 +1.26 kB
assets/Button-D0wP46aD.js (removed) 3.52 kB — 🟢 -3.52 kB 🟢 -1.36 kB 🟢 -1.19 kB
assets/Button-DWuVxdPS.js (new) — 3.52 kB 🔴 +3.52 kB 🔴 +1.36 kB 🔴 +1.2 kB
assets/SubscribeButton-D8pfTbf3.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -919 B
assets/SubscribeButton-Doyxf4Sq.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +930 B
assets/WidgetButton-B0yH3AnE.js (new) — 2.07 kB 🔴 +2.07 kB 🔴 +963 B 🔴 +873 B
assets/WidgetButton-Cgn5Sko7.js (removed) 2.07 kB — 🟢 -2.07 kB 🟢 -963 B 🟢 -854 B
assets/cloudFeedbackTopbarButton-hqB_pqL8.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -936 B 🟢 -821 B
assets/cloudFeedbackTopbarButton-SbQcB-iP.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +931 B 🔴 +821 B
assets/Input-C9WotFdH.js (new) — 1.75 kB 🔴 +1.75 kB 🔴 +860 B 🔴 +748 B
assets/Input-GivLfvlA.js (removed) 1.75 kB — 🟢 -1.75 kB 🟢 -860 B 🟢 -749 B
assets/UserAvatar-Ci9huQps.js (new) — 1.28 kB 🔴 +1.28 kB 🔴 +670 B 🔴 +578 B
assets/UserAvatar-lH8fHbM_.js (removed) 1.28 kB — 🟢 -1.28 kB 🟢 -673 B 🟢 -580 B
assets/ComfyQueueButton-B7Eo0GHT.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +594 B 🔴 +529 B
assets/ComfyQueueButton-B9CCkzC5.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -597 B 🟢 -528 B
assets/CloudBadge-Cv_L3nhC.js (removed) 1.17 kB — 🟢 -1.17 kB 🟢 -591 B 🟢 -519 B
assets/CloudBadge-wkhMxb5I.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +593 B 🔴 +521 B

Status: 14 added / 14 removed

Data & Services — 3.15 MB (baseline 3.13 MB) • 🔴 +14 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-DZLJXvqq.js (new) — 2.08 MB 🔴 +2.08 MB 🔴 +474 kB 🔴 +359 kB
assets/dialogService-BTDqjkBQ.js (removed) 2.07 MB — 🟢 -2.07 MB 🟢 -470 kB 🟢 -356 kB
assets/api-1Bxb49sK.js (new) — 888 kB 🔴 +888 kB 🔴 +212 kB 🔴 +167 kB
assets/api-4i6tHu_z.js (removed) 888 kB — 🟢 -888 kB 🟢 -212 kB 🟢 -167 kB
assets/load3dService-CXYPZ61V.js (removed) 116 kB — 🟢 -116 kB 🟢 -25.3 kB 🟢 -21.6 kB
assets/load3dService-PhO4UXfb.js (new) — 116 kB 🔴 +116 kB 🔴 +25.3 kB 🔴 +21.6 kB
assets/workflowShareService-DE_bViBN.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.89 kB 🔴 +4.33 kB
assets/workflowShareService-DykExuYS.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.89 kB 🟢 -4.33 kB
assets/keybindingService-CJC2Qmo3.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.21 kB
assets/keybindingService-DzHmZfwc.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.21 kB
assets/releaseStore-BJgt74C6.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/releaseStore-Xozo0PxB.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/dialogStore-DDm-X5Ep.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.59 kB 🟢 -1.35 kB
assets/dialogStore-kb5zS55u.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.59 kB 🔴 +1.36 kB
assets/userStore-BZU5KY8y.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +935 B 🔴 +823 B
assets/userStore-NdhN7L7F.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -933 B 🟢 -818 B
assets/serverConfigStore-7ktu5Gpd.js (new) — 2.35 kB 🔴 +2.35 kB 🔴 +810 B 🔴 +706 B
assets/serverConfigStore-DG1G7iJC.js (removed) 2.35 kB — 🟢 -2.35 kB 🟢 -812 B 🟢 -706 B
assets/electronDownloadStore-DT1OBW3i.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +735 B 🔴 +656 B
assets/electronDownloadStore-tNdashPE.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -730 B 🟢 -652 B
assets/audioService-CrT6hri3.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -876 B 🟢 -759 B
assets/audioService-DcY1PFQD.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +876 B 🔴 +755 B
assets/releaseStore-BJNNbYt2.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +562 B 🔴 +501 B
assets/releaseStore-DOQwDH_z.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -565 B 🟢 -499 B
assets/workflowDraftStore-BscguKbe.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +557 B 🔴 +497 B
assets/workflowDraftStore-BuG_uDrI.js (removed) 1.17 kB — 🟢 -1.17 kB 🟢 -559 B 🟢 -495 B
assets/dialogService-CkEY7PWV.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +549 B 🔴 +489 B
assets/dialogService-F2auoJKL.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -551 B 🟢 -494 B
assets/settingStore-B4j5ZmJF.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -556 B 🟢 -490 B
assets/settingStore-B5E31hfP.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +552 B 🔴 +494 B
assets/assetsStore-Ca1BvUhy.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -556 B 🟢 -491 B
assets/assetsStore-DCD7E7uV.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +553 B 🔴 +495 B
assets/toastStore-DfZe8vn3.js (removed) 889 B — 🟢 -889 B 🟢 -430 B 🟢 -371 B
assets/toastStore-ZdYnj0du.js (new) — 889 B 🔴 +889 B 🔴 +430 B 🔴 +372 B

Status: 17 added / 17 removed

Utilities & Hooks — 367 kB (baseline 367 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-DDJIrUEj.js (removed) 234 kB — 🟢 -234 kB 🟢 -52 kB 🟢 -42.4 kB
assets/useConflictDetection-lwNCU_Hz.js (new) — 234 kB 🔴 +234 kB 🔴 +52 kB 🔴 +42.4 kB
assets/useLoad3d-Dxs8r0-4.js (new) — 22.7 kB 🔴 +22.7 kB 🔴 +5.22 kB 🔴 +4.61 kB
assets/useLoad3d-wOj6dOkY.js (removed) 22.7 kB — 🟢 -22.7 kB 🟢 -5.22 kB 🟢 -4.61 kB
assets/useLoad3dViewer-Ba54FZcM.js (new) — 21 kB 🔴 +21 kB 🔴 +4.92 kB 🔴 +4.3 kB
assets/useLoad3dViewer-Clx-5n36.js (removed) 21 kB — 🟢 -21 kB 🟢 -4.92 kB 🟢 -4.31 kB
assets/colorUtil-BJDzyU0o.js (new) — 9.01 kB 🔴 +9.01 kB 🔴 +2.68 kB 🔴 +2.36 kB
assets/colorUtil-DzftiAs1.js (removed) 9.01 kB — 🟢 -9.01 kB 🟢 -2.68 kB 🟢 -2.37 kB
assets/useFeatureFlags-BQbTbNOr.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.79 kB 🟢 -1.52 kB
assets/useFeatureFlags-D4cD45iM.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.8 kB 🔴 +1.53 kB
assets/useTypeformEmbed-C1Flx9JH.js (removed) 5.91 kB — 🟢 -5.91 kB 🟢 -2.28 kB 🟢 -1.89 kB
assets/useTypeformEmbed-CDK0oR01.js (new) — 5.91 kB 🔴 +5.91 kB 🔴 +2.28 kB 🔴 +1.89 kB
assets/useCopyToClipboard-CBmpNNVn.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useCopyToClipboard-CK15h7q-.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/downloadUtil-00Sk0erH.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.85 kB 🔴 +1.53 kB
assets/downloadUtil-BP3ZjI1m.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.85 kB 🟢 -1.53 kB
assets/useWorkspaceUI-CdWV8V7L.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -983 B 🟢 -811 B
assets/useWorkspaceUI-P__Qx2Ag.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +982 B 🔴 +813 B
assets/subscriptionCheckoutUtil-73ppEaO4.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.19 kB
assets/subscriptionCheckoutUtil-BqwUfit2.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.36 kB 🟢 -1.18 kB
assets/useExternalLink-BMVVXiL5.js (removed) 3.03 kB — 🟢 -3.03 kB 🟢 -1.16 kB 🟢 -1.02 kB
assets/useExternalLink-YEdWA5-Q.js (new) — 3.03 kB 🔴 +3.03 kB 🔴 +1.16 kB 🔴 +1.03 kB
assets/assetPreviewUtil-B-jxWjm-.js (new) — 2.43 kB 🔴 +2.43 kB 🔴 +1.01 kB 🔴 +876 B
assets/assetPreviewUtil-TqLXu-Wx.js (removed) 2.43 kB — 🟢 -2.43 kB 🟢 -1.01 kB 🟢 -875 B
assets/useFeatureUsageTracker-DMlZ3b1s.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +941 B 🔴 +804 B
assets/useFeatureUsageTracker-UAEMnBH1.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -943 B 🟢 -795 B
assets/useUpstreamValue-fQL8cZRc.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +805 B 🔴 +711 B
assets/useUpstreamValue-Sb_Fw6WV.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -807 B 🟢 -711 B
assets/useErrorHandling-BIfbkr-q.js (new) — 1.54 kB 🔴 +1.54 kB 🔴 +647 B 🔴 +549 B
assets/useErrorHandling-CdaiTGzN.js (removed) 1.54 kB — 🟢 -1.54 kB 🟢 -646 B 🟢 -552 B
assets/useWorkspaceTierLabel-DGdcyyAF.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -666 B 🟢 -554 B
assets/useWorkspaceTierLabel-DVoiVtAX.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +665 B 🔴 +578 B
assets/useLoad3d-BmHC_Bhv.js (removed) 1.33 kB — 🟢 -1.33 kB 🟢 -625 B 🟢 -556 B
assets/useLoad3d-Co0Z6r4s.js (new) — 1.33 kB 🔴 +1.33 kB 🔴 +619 B 🔴 +555 B
assets/useLoad3dViewer-DO6aY_8p.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -591 B 🟢 -526 B
assets/useLoad3dViewer-DSULEwM9.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +587 B 🔴 +524 B
assets/useCurrentUser-Br9LAYAs.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -556 B 🟢 -489 B
assets/useCurrentUser-CHpQzs1S.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +553 B 🔴 +489 B
assets/useWorkspaceSwitch-Bsdblmpm.js (removed) 747 B — 🟢 -747 B 🟢 -380 B 🟢 -329 B
assets/useWorkspaceSwitch-CaoC0d5r.js (new) — 747 B 🔴 +747 B 🔴 +384 B 🔴 +329 B

Status: 20 added / 20 removed / 11 unchanged

Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • 🔴 +36 B

External libraries and shared vendor chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/vendor-other-alUU8Bvv.js (removed) 1.82 MB — 🟢 -1.82 MB 🟢 -375 kB 🟢 -299 kB
assets/vendor-other-DnMkpTnF.js (new) — 1.82 MB 🔴 +1.82 MB 🔴 +375 kB 🔴 +299 kB
assets/vendor-primevue-C60vEtI0.js (new) — 1.73 MB 🔴 +1.73 MB 🔴 +312 kB 🔴 +188 kB
assets/vendor-primevue-vWujy6hz.js (removed) 1.73 MB — 🟢 -1.73 MB 🟢 -312 kB 🟢 -189 kB
assets/vendor-reka-ui-D_ztTlQM.js (new) — 482 kB 🔴 +482 kB 🔴 +88.2 kB 🔴 +68.2 kB
assets/vendor-reka-ui-fSH2wgmi.js (removed) 482 kB — 🟢 -482 kB 🟢 -88.2 kB 🟢 -68.2 kB
assets/vendor-vue-core-CfdhvHUb.js (new) — 329 kB 🔴 +329 kB 🔴 +83.1 kB 🔴 +70 kB
assets/vendor-vue-core-Dk0p6Qsn.js (removed) 329 kB — 🟢 -329 kB 🟢 -83.1 kB 🟢 -70 kB
assets/vendor-vueuse-BxchDBpH.js (removed) 151 kB — 🟢 -151 kB 🟢 -38 kB 🟢 -32.3 kB
assets/vendor-vueuse-INjrgTt5.js (new) — 151 kB 🔴 +151 kB 🔴 +38 kB 🔴 +32.3 kB
assets/vendor-i18n-C_NOa4hF.js (new) — 140 kB 🔴 +140 kB 🔴 +30.7 kB 🔴 +25.8 kB
assets/vendor-i18n-C9xUC0xo.js (removed) 140 kB — 🟢 -140 kB 🟢 -30.7 kB 🟢 -25.8 kB

Status: 6 added / 6 removed / 10 unchanged

Other — 8.98 MB (baseline 8.98 MB) • 🔴 +2.32 kB

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/i18n-BHllMyZU.js (new) — 601 kB 🔴 +601 kB 🔴 +117 kB 🔴 +91.5 kB
assets/i18n-ByLMHeit.js (removed) 601 kB — 🟢 -601 kB 🟢 -117 kB 🟢 -91.5 kB
assets/core-DNKpzCNU.js (new) — 79.6 kB 🔴 +79.6 kB 🔴 +20.6 kB 🔴 +17.6 kB
assets/core-CGErhd6n.js (removed) 77.3 kB — 🟢 -77.3 kB 🟢 -20 kB 🟢 -17.1 kB
assets/groupNode-D-I4PTpy.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/groupNode-DgXM8rNm.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/WidgetSelect-CWWPu45r.js (removed) 67.4 kB — 🟢 -67.4 kB 🟢 -14.6 kB 🟢 -12.7 kB
assets/WidgetSelect-Mc1UQfrY.js (new) — 67.4 kB 🔴 +67.4 kB 🔴 +14.6 kB 🔴 +12.7 kB
assets/SubscriptionRequiredDialogContentWorkspace-1rY6Qo30.js (new) — 48.8 kB 🔴 +48.8 kB 🔴 +9.53 kB 🔴 +8.21 kB
assets/SubscriptionRequiredDialogContentWorkspace-CQfnCJTg.js (removed) 48.8 kB — 🟢 -48.8 kB 🟢 -9.52 kB 🟢 -8.21 kB
assets/Load3DControls-CS7HYp32.js (removed) 46.1 kB — 🟢 -46.1 kB 🟢 -7.51 kB 🟢 -6.55 kB
assets/Load3DControls-CWSVjB2v.js (new) — 46.1 kB 🔴 +46.1 kB 🔴 +7.51 kB 🔴 +6.54 kB
assets/WorkspacePanelContent-Dpsf3jwI.js (new) — 34.2 kB 🔴 +34.2 kB 🔴 +7.41 kB 🔴 +6.57 kB
assets/WorkspacePanelContent-m6FlnnVM.js (removed) 34.2 kB — 🟢 -34.2 kB 🟢 -7.41 kB 🟢 -6.56 kB
assets/WidgetPainter-BzJhDlQI.js (new) — 33.5 kB 🔴 +33.5 kB 🔴 +8.29 kB 🔴 +7.33 kB
assets/WidgetPainter-CxS2Ujzy.js (removed) 33.5 kB — 🟢 -33.5 kB 🟢 -8.29 kB 🟢 -7.33 kB
assets/Load3dViewerContent-BpumJ4dX.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.2 kB 🔴 +5.37 kB
assets/Load3dViewerContent-DrPKcCwi.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.19 kB 🟢 -5.37 kB
assets/SubscriptionRequiredDialogContent-QgB2NlHx.js (new) — 27.5 kB 🔴 +27.5 kB 🔴 +6.99 kB 🔴 +6.18 kB
assets/SubscriptionRequiredDialogContent-QKquwETD.js (removed) 27.5 kB — 🟢 -27.5 kB 🟢 -6.98 kB 🟢 -6.16 kB
assets/WidgetImageCrop-CyC8xEn4.js (new) — 24.3 kB 🔴 +24.3 kB 🔴 +6.2 kB 🔴 +5.46 kB
assets/WidgetImageCrop-rwahLzK_.js (removed) 24.3 kB — 🟢 -24.3 kB 🟢 -6.2 kB 🟢 -5.45 kB
assets/SubscriptionPanelContentWorkspace-B2D0xBhJ.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.56 kB
assets/SubscriptionPanelContentWorkspace-DH1POWVH.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.58 kB
assets/SignInContent-BwFiwUDs.js (new) — 20.8 kB 🔴 +20.8 kB 🔴 +5.44 kB 🔴 +4.76 kB
assets/SignInContent-lMqpWyk3.js (removed) 20.8 kB — 🟢 -20.8 kB 🟢 -5.44 kB 🟢 -4.75 kB
assets/CurrentUserPopoverWorkspace-6qb8MpBg.js (removed) 20.8 kB — 🟢 -20.8 kB 🟢 -4.96 kB 🟢 -4.43 kB
assets/CurrentUserPopoverWorkspace-C0yfOpCP.js (new) — 20.8 kB 🔴 +20.8 kB 🔴 +4.96 kB 🔴 +4.44 kB
assets/WidgetInputNumber-BFAGVRy-.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.29 kB
assets/WidgetInputNumber-BjJPUMwu.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.83 kB 🔴 +4.29 kB
assets/Load3D-CSrdqRj7.js (new) — 18.5 kB 🔴 +18.5 kB 🔴 +4.39 kB 🔴 +3.84 kB
assets/Load3D-CUzswevg.js (removed) 18.5 kB — 🟢 -18.5 kB 🟢 -4.39 kB 🟢 -3.84 kB
assets/WidgetRecordAudio-C82LsLrg.js (removed) 17.5 kB — 🟢 -17.5 kB 🟢 -5.04 kB 🟢 -4.51 kB
assets/WidgetRecordAudio-REXTErf1.js (new) — 17.5 kB 🔴 +17.5 kB 🔴 +5.04 kB 🔴 +4.51 kB
assets/WidgetRange-BhP524sD.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.61 kB 🔴 +4.13 kB
assets/WidgetRange-CKgeVQu_.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.61 kB 🟢 -4.12 kB
assets/WidgetColorPicker-C6Itt8uO.js (new) — 16.2 kB 🔴 +16.2 kB 🔴 +3.99 kB 🔴 +3.55 kB
assets/WidgetColorPicker-y3SvRxyx.js (removed) 16.2 kB — 🟢 -16.2 kB 🟢 -3.99 kB 🟢 -3.57 kB
assets/load3d-3xf23qIe2.js (removed) 15.8 kB — 🟢 -15.8 kB 🟢 -4.6 kB 🟢 -3.98 kB
assets/load3d-B6wSPK-l2.js (new) — 15.8 kB 🔴 +15.8 kB 🔴 +4.6 kB 🔴 +3.98 kB
assets/WaveAudioPlayer-DhFYk2_j.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.22 kB
assets/WaveAudioPlayer-LzTNMYzD.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.22 kB
assets/WidgetCurve-BihwCXgQ.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +3.93 kB 🔴 +3.56 kB
assets/WidgetCurve-juVvt1ta.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -3.93 kB 🟢 -3.57 kB
assets/TeamWorkspacesDialogContent-BOlUyfvJ.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.42 kB 🟢 -3.05 kB
assets/TeamWorkspacesDialogContent-lPkYT2vQ.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.42 kB 🔴 +3.05 kB
assets/AudioPreviewPlayer-Bdt5CvrC.js (new) — 10.8 kB 🔴 +10.8 kB 🔴 +3.13 kB 🔴 +2.8 kB
assets/AudioPreviewPlayer-D9FGi1sx.js (removed) 10.8 kB — 🟢 -10.8 kB 🟢 -3.13 kB 🟢 -2.81 kB
assets/nodeTemplates-Cc70cXJM.js (removed) 9.84 kB — 🟢 -9.84 kB 🟢 -3.48 kB 🟢 -3.08 kB
assets/nodeTemplates-D5XTG0S8.js (new) — 9.84 kB 🔴 +9.84 kB 🔴 +3.48 kB 🔴 +3.07 kB
assets/SelectValue-BmcLomYe.js (new) — 9.8 kB 🔴 +9.8 kB 🔴 +2.45 kB 🔴 +2.16 kB
assets/SelectValue-CkUDpxB-.js (removed) 9.8 kB — 🟢 -9.8 kB 🟢 -2.45 kB 🟢 -2.16 kB
assets/NightlySurveyController-BzuW8sUG.js (new) — 8.97 kB 🔴 +8.97 kB 🔴 +3.15 kB 🔴 +2.78 kB
assets/NightlySurveyController-D_Z7TIJ2.js (removed) 8.97 kB — 🟢 -8.97 kB 🟢 -3.16 kB 🟢 -2.79 kB
assets/Load3DConfiguration-BCQ7pxTt.js (new) — 8.77 kB 🔴 +8.77 kB 🔴 +2.6 kB 🔴 +2.29 kB
assets/Load3DConfiguration-BLT4bp65.js (removed) 8.77 kB — 🟢 -8.77 kB 🟢 -2.6 kB 🟢 -2.3 kB
assets/InviteMemberDialogContent-BHWrhPwQ.js (new) — 7.94 kB 🔴 +7.94 kB 🔴 +2.53 kB 🔴 +2.22 kB
assets/InviteMemberDialogContent-BUSz7t0X.js (removed) 7.94 kB — 🟢 -7.94 kB 🟢 -2.53 kB 🟢 -2.21 kB
assets/WidgetImageCompare-BdNKUhm-.js (removed) 7.9 kB — 🟢 -7.9 kB 🟢 -2.3 kB 🟢 -2.01 kB
assets/WidgetImageCompare-CTzCg19J.js (new) — 7.9 kB 🔴 +7.9 kB 🔴 +2.3 kB 🔴 +2.01 kB
assets/onboardingCloudRoutes-C-ZOCnzy.js (new) — 6.73 kB 🔴 +6.73 kB 🔴 +2.12 kB 🔴 +1.82 kB
assets/onboardingCloudRoutes-KhFhBBQQ.js (removed) 6.73 kB — 🟢 -6.73 kB 🟢 -2.12 kB 🟢 -1.82 kB
assets/AnimationControls-nEY5uOAm.js (removed) 6.16 kB — 🟢 -6.16 kB 🟢 -1.88 kB 🟢 -1.66 kB
assets/AnimationControls-x_QD8bud.js (new) — 6.16 kB 🔴 +6.16 kB 🔴 +1.88 kB 🔴 +1.66 kB
assets/CreateWorkspaceDialogContent-CovU7DQs.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +2.24 kB 🔴 +1.96 kB
assets/CreateWorkspaceDialogContent-DwuEvpiE.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -2.24 kB 🟢 -1.96 kB
assets/WidgetWithControl-B-OQ0Old.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -2.44 kB 🟢 -2.17 kB
assets/WidgetWithControl-Dq1pKCkq.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +2.44 kB 🔴 +2.17 kB
assets/FreeTierDialogContent-B1jfZnpX.js (new) — 6.01 kB 🔴 +6.01 kB 🔴 +2.14 kB 🔴 +1.9 kB
assets/FreeTierDialogContent-DmEmqEfS.js (removed) 6.01 kB — 🟢 -6.01 kB 🟢 -2.13 kB 🟢 -1.9 kB
assets/EditWorkspaceDialogContent--rJ08OiM.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.2 kB 🔴 +1.93 kB
assets/EditWorkspaceDialogContent-M6NRazF4.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.2 kB 🟢 -1.94 kB
assets/WidgetTextarea-Cy7ljdNi.js (new) — 5.76 kB 🔴 +5.76 kB 🔴 +2.27 kB 🔴 +2.01 kB
assets/WidgetTextarea-D9FIZ1Dy.js (removed) 5.76 kB — 🟢 -5.76 kB 🟢 -2.27 kB 🟢 -2.02 kB
assets/Preview3d-BxMSQ3Vp.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -1.93 kB 🟢 -1.69 kB
assets/Preview3d-CgXWBWHI.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +1.92 kB 🔴 +1.68 kB
assets/ValueControlPopover-CEBWzvHh.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.02 kB 🟢 -1.8 kB
assets/ValueControlPopover-DxyAA02-.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.02 kB 🔴 +1.8 kB
assets/CancelSubscriptionDialogContent-BBAX2MAx.js (new) — 5.49 kB 🔴 +5.49 kB 🔴 +2.06 kB 🔴 +1.81 kB
assets/CancelSubscriptionDialogContent-DA9PGrSi.js (removed) 5.49 kB — 🟢 -5.49 kB 🟢 -2.06 kB 🟢 -1.81 kB
assets/CloudNotificationContent-CjzOAI0V.js (new) — 5.04 kB 🔴 +5.04 kB 🔴 +1.8 kB 🔴 +1.56 kB
assets/CloudNotificationContent-d9UbJMLQ.js (removed) 5.04 kB — 🟢 -5.04 kB 🟢 -1.8 kB 🟢 -1.56 kB
assets/DeleteWorkspaceDialogContent-bROBrcUE.js (new) — 4.85 kB 🔴 +4.85 kB 🔴 +1.88 kB 🔴 +1.63 kB
assets/DeleteWorkspaceDialogContent-DLiImDSg.js (removed) 4.85 kB — 🟢 -4.85 kB 🟢 -1.88 kB 🟢 -1.63 kB
assets/saveMesh-BCgGL487.js (new) — 4.7 kB 🔴 +4.7 kB 🔴 +1.87 kB 🔴 +1.66 kB
assets/saveMesh-stxFV50p.js (removed) 4.7 kB — 🟢 -4.7 kB 🟢 -1.87 kB 🟢 -1.66 kB
assets/LeaveWorkspaceDialogContent-C-gbsSoC.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.82 kB 🟢 -1.58 kB
assets/LeaveWorkspaceDialogContent-c3Yb6JZE.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.82 kB 🔴 +1.6 kB
assets/RemoveMemberDialogContent-B6Ju_kSa.js (new) — 4.66 kB 🔴 +4.66 kB 🔴 +1.78 kB 🔴 +1.55 kB
assets/RemoveMemberDialogContent-Bn5hV3CT.js (removed) 4.66 kB — 🟢 -4.66 kB 🟢 -1.77 kB 🟢 -1.55 kB
assets/RevokeInviteDialogContent-FNN9eEAJ.js (removed) 4.57 kB — 🟢 -4.57 kB 🟢 -1.79 kB 🟢 -1.57 kB
assets/RevokeInviteDialogContent-va1SJVe_.js (new) — 4.57 kB 🔴 +4.57 kB 🔴 +1.79 kB 🔴 +1.58 kB
assets/missingModelDownload-BZttPZwI.js (new) — 4.52 kB 🔴 +4.52 kB 🔴 +1.77 kB 🔴 +1.56 kB
assets/missingModelDownload-D5HyfmHk.js (removed) 4.52 kB — 🟢 -4.52 kB 🟢 -1.76 kB 🟢 -1.56 kB
assets/InviteMemberUpsellDialogContent-DdjD8Kh4.js (removed) 4.47 kB — 🟢 -4.47 kB 🟢 -1.65 kB 🟢 -1.45 kB
assets/InviteMemberUpsellDialogContent-RZZiS_f3.js (new) — 4.47 kB 🔴 +4.47 kB 🔴 +1.65 kB 🔴 +1.45 kB
assets/tierBenefits-DdkdKiXo.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.57 kB 🔴 +1.36 kB
assets/tierBenefits-DlQIGFBK.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.58 kB 🟢 -1.36 kB
assets/Media3DTop-CfL8kCYZ.js (new) — 4.35 kB 🔴 +4.35 kB 🔴 +1.78 kB 🔴 +1.57 kB
assets/Media3DTop-CWgwxmG0.js (removed) 4.35 kB — 🟢 -4.35 kB 🟢 -1.78 kB 🟢 -1.58 kB
assets/cloudSessionCookie-BVOrJho9.js (new) — 4.31 kB 🔴 +4.31 kB 🔴 +1.57 kB 🔴 +1.38 kB
assets/cloudSessionCookie-D17VP3LS.js (removed) 4.31 kB — 🟢 -4.31 kB 🟢 -1.58 kB 🟢 -1.38 kB
assets/ApiNodesSignInContent-b4rYrZrl.js (new) — 4.26 kB 🔴 +4.26 kB 🔴 +1.4 kB 🔴 +1.23 kB
assets/ApiNodesSignInContent-zmx0gHH9.js (removed) 4.26 kB — 🟢 -4.26 kB 🟢 -1.4 kB 🟢 -1.23 kB
assets/WidgetBoundingBox-C7_g5oxY.js (new) — 3.81 kB 🔴 +3.81 kB 🔴 +1.06 kB 🔴 +925 B
assets/WidgetBoundingBox-Clu0JAYg.js (removed) 3.81 kB — 🟢 -3.81 kB 🟢 -1.06 kB 🟢 -917 B
assets/WidgetGalleria-NVpsioma.js (new) — 3.8 kB 🔴 +3.8 kB 🔴 +1.47 kB 🔴 +1.31 kB
assets/WidgetGalleria-yIkIasN_.js (removed) 3.8 kB — 🟢 -3.8 kB 🟢 -1.48 kB 🟢 -1.32 kB
assets/Popover-CUkmic0v.js (removed) 3.77 kB — 🟢 -3.77 kB 🟢 -1.49 kB 🟢 -1.32 kB
assets/Popover-DaQljJEe.js (new) — 3.77 kB 🔴 +3.77 kB 🔴 +1.49 kB 🔴 +1.32 kB
assets/WidgetToggleSwitch-BAmh8L9q.js (new) — 3.73 kB 🔴 +3.73 kB 🔴 +1.43 kB 🔴 +1.27 kB
assets/WidgetToggleSwitch-DEBTBY1N.js (removed) 3.73 kB — 🟢 -3.73 kB 🟢 -1.43 kB 🟢 -1.26 kB
assets/Slider-_kNxwzO5.js (removed) 3.57 kB — 🟢 -3.57 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/Slider-DxyGJcTX.js (new) — 3.57 kB 🔴 +3.57 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/WidgetMarkdown-CUSdqF9a.js (removed) 3.2 kB — 🟢 -3.2 kB 🟢 -1.31 kB 🟢 -1.14 kB
assets/WidgetMarkdown-DaCHEC9K.js (new) — 3.2 kB 🔴 +3.2 kB 🔴 +1.31 kB 🔴 +1.14 kB
assets/WidgetInputText-CL9z5XWN.js (new) — 3.09 kB 🔴 +3.09 kB 🔴 +1.32 kB 🔴 +1.18 kB
assets/WidgetInputText-DqVhGQqv.js (removed) 3.09 kB — 🟢 -3.09 kB 🟢 -1.31 kB 🟢 -1.18 kB
assets/GlobalToast-BiP6PIrU.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.07 kB
assets/GlobalToast-CgdXpWkI.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.11 kB
assets/MediaVideoTop-C6CcY0f1.js (new) — 2.96 kB 🔴 +2.96 kB 🔴 +1.21 kB 🔴 +1.06 kB
assets/MediaVideoTop-gm5VhV4_.js (removed) 2.96 kB — 🟢 -2.96 kB 🟢 -1.21 kB 🟢 -1.06 kB
assets/ErrorPanelSurveyCta-CzEIcQ1O.js (removed) 2.74 kB — 🟢 -2.74 kB 🟢 -1.21 kB 🟢 -1.07 kB
assets/ErrorPanelSurveyCta-D58Fnsdh.js (new) — 2.74 kB 🔴 +2.74 kB 🔴 +1.21 kB 🔴 +1.07 kB
assets/WidgetLayoutField-CYb4B0Pv.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.06 kB 🔴 +974 B
assets/WidgetLayoutField-CZYTkQPh.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.06 kB 🟢 -936 B
assets/WidgetChart-Biz_lG73.js (removed) 2.41 kB — 🟢 -2.41 kB 🟢 -1.03 kB 🟢 -883 B
assets/WidgetChart-YpDrfDvi.js (new) — 2.41 kB 🔴 +2.41 kB 🔴 +1.02 kB 🔴 +888 B
assets/CloudRunButtonWrapper-BzGByAqg.js (removed) 2.23 kB — 🟢 -2.23 kB 🟢 -1.02 kB 🟢 -910 B
assets/CloudRunButtonWrapper-Cs9Z2WnC.js (new) — 2.23 kB 🔴 +2.23 kB 🔴 +1.02 kB 🔴 +908 B
assets/SubscribeToRun-B92ypKL1.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +984 B 🔴 +880 B
assets/SubscribeToRun-BU0cbT1g.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -981 B 🟢 -876 B
assets/MediaAudioTop-Bd9Fd_0Z.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -1 kB 🟢 -859 B
assets/MediaAudioTop-Bh9phmUe.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +1.01 kB 🔴 +862 B
assets/SubscriptionBenefits-CzAcK781.js (new) — 2.07 kB 🔴 +2.07 kB 🔴 +709 B 🔴 +612 B
assets/SubscriptionBenefits-DWVZmW6H.js (removed) 2.07 kB — 🟢 -2.07 kB 🟢 -709 B 🟢 -600 B
assets/MediaImageTop-CSJA8-Du.js (removed) 2.05 kB — 🟢 -2.05 kB 🟢 -995 B 🟢 -862 B
assets/MediaImageTop-DMW06jJe.js (new) — 2.05 kB 🔴 +2.05 kB 🔴 +995 B 🔴 +858 B
assets/cloudBadges-D8yc6nvn.js (new) — 1.96 kB 🔴 +1.96 kB 🔴 +978 B 🔴 +851 B
assets/cloudBadges-D9JQdT25.js (removed) 1.96 kB — 🟢 -1.96 kB 🟢 -978 B 🟢 -850 B
assets/BaseViewTemplate-B-71sry-.js (new) — 1.92 kB 🔴 +1.92 kB 🔴 +977 B 🔴 +868 B
assets/BaseViewTemplate-FhYTu9Zd.js (removed) 1.92 kB — 🟢 -1.92 kB 🟢 -981 B 🟢 -863 B
assets/cloudSubscription-BwRz9DEj.js (removed) 1.88 kB — 🟢 -1.88 kB 🟢 -900 B 🟢 -777 B
assets/cloudSubscription-CMNNSep1.js (new) — 1.88 kB 🔴 +1.88 kB 🔴 +901 B 🔴 +785 B
assets/graphHasMissingNodes-dmcE5C3O.js (removed) 1.84 kB — 🟢 -1.84 kB 🟢 -860 B 🟢 -776 B
assets/graphHasMissingNodes-SdKkXA9s.js (new) — 1.84 kB 🔴 +1.84 kB 🔴 +863 B 🔴 +761 B
assets/Loader-Aub07ehV.js (new) — 1.68 kB 🔴 +1.68 kB 🔴 +811 B 🔴 +742 B
assets/Loader-B582Rq-u.js (removed) 1.68 kB — 🟢 -1.68 kB 🟢 -808 B 🟢 -728 B
assets/signInSchema-Bk_ucI07.js (removed) 1.6 kB — 🟢 -1.6 kB 🟢 -585 B 🟢 -519 B
assets/signInSchema-CThZyUuE.js (new) — 1.6 kB 🔴 +1.6 kB 🔴 +586 B 🔴 +520 B
assets/Load3D-BcnGGttw.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +707 B 🔴 +633 B
assets/Load3D-Brjz8rST.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -715 B 🟢 -631 B
assets/previousFullPath-BY-kHAyl.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -694 B 🟢 -595 B
assets/previousFullPath-Ddr-DTDn.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +693 B 🔴 +603 B
assets/Textarea-4dVZqn6z.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -787 B 🟢 -682 B
assets/Textarea-DLDFuTPN.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +789 B 🔴 +687 B
assets/VideoPlayOverlay-D_hIbv6O.js (removed) 1.51 kB — 🟢 -1.51 kB 🟢 -760 B 🟢 -671 B
assets/VideoPlayOverlay-D3nFS4UO.js (new) — 1.51 kB 🔴 +1.51 kB 🔴 +763 B 🔴 +676 B
assets/nightlyBadges-C4HewOsl.js (new) — 1.49 kB 🔴 +1.49 kB 🔴 +746 B 🔴 +681 B
assets/nightlyBadges-Dn0aEj15.js (removed) 1.49 kB — 🟢 -1.49 kB 🟢 -746 B 🟢 -653 B
assets/Load3dViewerContent-BfPfSsgU.js (removed) 1.46 kB — 🟢 -1.46 kB 🟢 -666 B 🟢 -587 B
assets/Load3dViewerContent-C3g2GvrR.js (new) — 1.46 kB 🔴 +1.46 kB 🔴 +661 B 🔴 +600 B
assets/SubscriptionPanelContentWorkspace-BidqqKHb.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -621 B 🟢 -540 B
assets/SubscriptionPanelContentWorkspace-C6Rj2CwV.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +618 B 🔴 +536 B
assets/WidgetLegacy-C5_2P4zy.js (removed) 1.18 kB — 🟢 -1.18 kB 🟢 -567 B 🟢 -500 B
assets/WidgetLegacy-CaThVCTY.js (new) — 1.18 kB 🔴 +1.18 kB 🔴 +563 B 🔴 +499 B
assets/changeTracker-C_aqamWH.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +553 B 🔴 +491 B
assets/changeTracker-C7FCfPNJ.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -555 B 🟢 -489 B
assets/MediaOtherTop-CL9UoZRk.js (new) — 1.07 kB 🔴 +1.07 kB 🔴 +602 B 🔴 +498 B
assets/MediaOtherTop-DyyaAh_l.js (removed) 1.07 kB — 🟢 -1.07 kB 🟢 -600 B 🟢 -497 B
assets/MediaTextTop-7wRuG4XB.js (removed) 1.06 kB — 🟢 -1.06 kB 🟢 -599 B 🟢 -499 B
assets/MediaTextTop-DsCuI5gY.js (new) — 1.06 kB 🔴 +1.06 kB 🔴 +598 B 🔴 +499 B
assets/ComfyOrgHeader-BofPmv4x.js (new) — 960 B 🔴 +960 B 🔴 +527 B 🔴 +454 B
assets/ComfyOrgHeader-DzU7WrTP.js (removed) 960 B — 🟢 -960 B 🟢 -530 B 🟢 -452 B
assets/widgetTypes-CH3hrkAc.js (new) — 416 B 🔴 +416 B 🔴 +274 B 🔴 +236 B
assets/widgetTypes-kzdungfF.js (removed) 416 B — 🟢 -416 B 🟢 -273 B 🟢 -235 B
assets/src-BBztAU9m.js (removed) 410 B — 🟢 -410 B 🟢 -299 B 🟢 -245 B
assets/src-CdzWmYSP.js (new) — 410 B 🔴 +410 B 🔴 +300 B 🔴 +246 B
assets/missingModelDownload-BtddizRz.js (removed) 386 B — 🟢 -386 B 🟢 -226 B 🟢 -213 B
assets/missingModelDownload-DWZ-tgpS.js (new) — 386 B 🔴 +386 B 🔴 +229 B 🔴 +215 B
assets/WidgetBoundingBox-e4CT6Qa4.js (removed) 311 B — 🟢 -311 B 🟢 -195 B 🟢 -190 B
assets/WidgetBoundingBox-mtb5sSZ8.js (new) — 311 B 🔴 +311 B 🔴 +193 B 🔴 +184 B
assets/i18n-DVEBN396.js (removed) 137 B — 🟢 -137 B 🟢 -122 B 🟢 -108 B
assets/i18n-lVf1ZYFV.js (new) — 137 B 🔴 +137 B 🔴 +122 B 🔴 +108 B

Status: 92 added / 92 removed / 44 unchanged

⚡ Performance

⚠️ Performance tests failed. Check the CI workflow logs.

christian-byrne and others added 5 commits May 9, 2026 14:12
Adds the v2 extension API public surface:

  src/types/extensionV2.ts          (169 lines) — branded entity IDs,
    geometry primitives, slot/widget options, NodeHandle/WidgetHandle
    contracts. Pure types. The stable public surface extensions depend on.

  src/services/extensionV2Service.ts (413 lines) — surface-only impl.
    Thin pass-throughs to existing LGraphNode/widget/canvas. No new
    internal architecture; no patching guards yet (Phase A scope per D9).
    Reactive mounting via Vue EffectScope; scope registry keyed by
    extension:entityId.

  src/extensions/core/{dynamicPrompts,imageCrop,previewAny}.v2.ts
    Three smallest core extensions ported as proof-of-concept. Used
    as the I-COORD.1 reference for Simon + Austin to push back on
    the API shape with concrete code.

Phase A goals (per todo.md "Branch + phasing topology"):
  - Stable v2 surface coworkers can branch off
  - Internal methods are pass-throughs (no behavior change)
  - I-PG.A: no interception/blocking; v1 path coexists unchanged

Stacks under this branch (will be opened as draft PRs):
  - ext-v2/i-tf-test-framework
  - ext-v2/i-sr-scope-registry
  - ext-v2/i-ws-lazy-serialize
…-TF)

Adds the isolated vitest config, CI workflow, and all 41×3 compat-floor
stub triples so the blast_radius≥2.0 gate passes from day one.

- vitest.extension-api.config.mts — targets src/extension-api-v2/__tests__/
- .github/workflows/ci-tests-extension-api.yaml — two jobs: vitest run +
  python3 scripts/check-compat-floor.py (exits 1 on missing stubs)
- package.json — test:extension-api / :watch / :coverage scripts
- src/extension-api/ — public declaration files (NodeHandle, WidgetHandle,
  defineNodeExtension, typed events, lifecycle hooks)
- src/extension-api-v2/__tests__/v1|v2|migration — 123 stub files covering
  BC.01–BC.41 (all 34 compat-floor categories × 3 stub types)
- packages/extension-api/ — typedoc wrapper package

compat-floor gate: OK — 102 stub files present (34 categories × 3 types)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- src/extension-api/{index,lifecycle,node,widget}.ts polish (D5/D6/D7/D10)
- docs/architecture/extension-api-v2/names-appendix.md (DOC1.E6)
- AGENTS.md: cross-repo ownership note

Foundation step 1/3 of ext-api/i-foundation.
… (MIG1.E5)

- src/services/extension-api-service.ts (canonical name; replaces extensionV2Service.ts)
- src/scripts/app.ts: invoke v2 lifecycle alongside v1 at init+setup
- src/services/extensionService.ts: invokeV2AppExtensions helper
- src/types/extensionV2.ts: NodeEntityId/WidgetEntityId surface
- src/extensions/core/index.ts: register v2 sample extensions
- *.v2.ts samples: align to refreshed surface

Foundation step 2/3 of ext-api/i-foundation.
- src/world/: ECS World skeleton (entities, components, NodeEntityId)
- src/services/__tests__/scope-registry.test.ts: registry semantics
  per D10 (lifecycle context+ordering) and D12 (clone-on-copy)

Foundation step 3/3 of ext-api/i-foundation. Coworker fork point:
child PRs i-tf and i-ext stack on top of this branch.
@christian-byrne
christian-byrne force-pushed the ext-api/i-foundation branch from b412aff to 96addd0 Compare May 9, 2026 21:13
@christian-byrne
christian-byrne changed the base branch from ecs-vue-hoisted-client-state-hook-api to main May 9, 2026 21:13

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Architecture Review — Phase A Foundation

Role: Architect · Focus: layering violations, Phase B/C extensibility blockers

# Severity Location Finding
1 HIGH src/extension-api/node.ts:30 vs src/world/entityIds.ts:6 NodeEntityId type split — public API is number-branded, internal world is string-branded
2 HIGH src/world/worldInstance.ts:11 vs src/services/extension-api-service.ts:598 World.getComponent returns unknown; startExtensionSystem assumes a reactive World that doesn't exist
3 MED src/extension-api/lifecycle.ts:322 vs src/services/extension-api-service.ts:57 Circular import: extension-api-service imports lifecycle.ts which re-exports from extension-api-service
4 MED src/services/extensionV2Service.ts Dead file: imports from @/ecs/* (does not exist), never imported anywhere, not excluded from typecheck
5 MED src/services/extension-api-service.ts:26-28 pauseTracking/resetTracking are deliberate no-ops; the D3.5 comment describes real Vue internals that do not apply
6 MED src/services/extension-api-service.ts:403-411 node.on('executed'/'connected'/'disconnected'/'configured') dispatches to the stub returning undefined, breaking the Unsubscribe contract silently
7 LOW src/scripts/app.ts:865 vs :960 startExtensionSystem() watcher is created before init() runs and has no owning scope — watch leak on teardown
8 LOW src/services/extension-api-service.ts:247-253 node.on() falls through silently for unknown event names with no dev warning

1 — NodeEntityId type split breaks Phase B rebase (HIGH)

src/extension-api/node.ts:30 declares:

export type NodeEntityId = number & { readonly __brand: 'NodeEntityId' }

src/world/entityIds.ts:6 (the stub Phase B replaces with real ECS IDs) declares:

export type NodeEntityId = Brand<string, 'NodeEntityId'>

extension-api-service.ts imports the world type (line 40) and passes it to createNodeHandle() which returns a NodeHandle typed with the public type. TypeScript accepts this now only because World.getComponent returns unknown everywhere, silencing the incompatibility.

When Phase B lands Alex's real ECS, extensions that have stored or compared NodeHandle.entityId will silently carry string values in a number-branded type. Two NodeEntityId declarations will exist with incompatible underlying primitives.

Fix: Remove NodeEntityId/WidgetEntityId/SlotEntityId from src/extension-api/node.ts and re-export from @/world/entityIds. The public barrel already re-exports types from elsewhere; entity IDs should follow the same pattern so Phase B changes one definition.


2 — startExtensionSystem assumes a reactive World that D8 says is still unresolved (HIGH)

extension-api-service.ts:598:

watch(
  () => world.entitiesWith(NodeTypeKey),  // returns unknown[] from stub
  ...
)

The comment at line 589 says "world component buckets are reactive(Map)." But decisions/D8-world-vue-reactive-adapter.md marks World reactivity as "scoping / blocker" with three un-spiked options. The World stub returns a plain unknown[] with no Vue tracking — the watch never fires in Phase A (stub throws on getWorld()).

The deeper Phase B blocker: getWorld() is captured at startExtensionSystem() call time. ADR 0008 says World is per-workflow. After a workflow switch the watcher holds a stale World reference, so the mount/unmount diff never sees new-workflow entities. D8's Q5 (workflow swap semantics) is unresolved.

Fix: Add a TODO keyed to D8 (not only #11939) at line 589. The watcher should re-acquire the World reference inside its getter, or the system needs restart-on-workflow-change. The current comment ("reactive(Map)") will mislead the Phase B implementer — it describes a design decision that hasn't been made yet.


3 — Circular import between extension-api-service and lifecycle.ts (MED)

extension-api-service.ts:57  import type { … } from '@/extension-api/lifecycle'
lifecycle.ts:322              export { onNodeMounted, onNodeRemoved } from '@/services/extension-api-service'

lifecycle.ts re-exports onNodeMounted/onNodeRemoved from extension-api-service, and extension-api-service imports WidgetExtensionOptions from lifecycle.ts. Real circular dependency. ESM typically resolves this via hoisting, but any import-time side effect in either module breaks the cycle silently — and extension-api-service.ts has module-level globals (scopeRegistry, nodeExtensions arrays) that initialize on first import.

index.ts compounds this (imports from both at lines 52 and 64).

Fix: Move type declarations (WidgetExtensionOptions, NodeExtensionOptions, ExtensionOptions) to a dedicated src/extension-api/types.ts with no implementation imports. Both lifecycle.ts and extension-api-service.ts import from types.ts; neither imports from the other.


4 — extensionV2Service.ts is dead code that imports non-existent modules (MED)

src/services/extensionV2Service.ts imports:

import { useWorld } from '@/ecs/world'      // does not exist
import { dispatch } from '@/ecs/commands'   // does not exist
import { … } from '@/ecs/components'        // does not exist

It is imported from nowhere. The PR description flags deletion as landing in a child PR — but this file currently lives in the typecheck surface. pnpm typecheck will fail on it unless tsconfig.json explicitly excludes it.

The file also defines a divergent parallel implementation (entityId: number vs string, world.queryAll() vs world.entitiesWith()) that contradicts the design landed in this PR — its presence confuses the design record.

Fix: Delete the file in this PR. Simple deletion, zero downstream impact.


5 — pauseTracking/resetTracking no-ops contradict their stated purpose (MED)

extension-api-service.ts:26-28:

// They are Vue internals not publicly exported. Use no-op shims…
const pauseTracking = (): void => {}
const resetTracking = (): void => {}

mountExtensionsForNode (line 542) documents step 3 as "pauseTracking() prevents accidental reactive deps on setup args." Without real pauseTracking, any reactive reads inside a nodeCreated() hook that touch a ref/reactive in the current rendering scope create unintended dependencies — extensions calling node.getPosition() during setup inside a component render will accidentally bind the component's re-render to node position changes.

extensionV2Service.ts imports the real Vue internals (import { pauseTracking, resetTracking } from 'vue'), confirming the original intent.

Fix: Import from @vue/reactivity (already a peer dep), or explicitly document that Phase A intentionally accepts the tracking leak with a TODO(#D3.5) to restore it in Phase B. The current shim presents a false invariant.


6 — node.on('executed'/'connected'/...) breaks the Unsubscribe contract silently in Phase A (MED)

// extension-api-service.ts:407-411
dispatch({ type: 'SubscribeNodeEvent', nodeId, event, handler: fn })
return () => dispatch({ type: 'UnsubscribeNodeEvent', nodeId, event, handler: fn })

The dispatch stub returns undefined and does nothing. The subscription never registers; the returned Unsubscribe tries to cancel a subscription that never existed.

Both dynamicPrompts.v2.ts and previewAny.v2.ts use node.on('executed', ...) as their primary event. They silently do nothing in Phase A. Extensions Simon/Austin convert against this surface, pass their own tests, and fail at runtime.

Fix: Either exclude these events from Phase A's surface (mark @stability internal or omit from public barrel), or throw in dev when called:

if (import.meta.env.DEV) throw new Error('[extension-api] node.on("executed") is not wired in Phase A — lands in Phase B (#11939)')

Silent no-ops in a stable-contract API are the worst outcome.


7 — startExtensionSystem watcher has no owning scope (LOW)

watch() called outside a Vue component or explicit EffectScope creates a detached watcher Vue cannot clean up automatically. _clearExtensionsForTesting() (line 491) clears the registries but doesn't stop the watcher. Calling startExtensionSystem() multiple times (possible in tests) accumulates N watchers.

D8 Q5 (workflow-swap teardown) will require stopping this watcher when the World is replaced — the current design has no handle for that.

Fix: startExtensionSystem() should create a EffectScope(true) (detached), run the watch inside it, and return a stop() function. Or guard against double-call with a module-level started flag.


8 — Silent fallthrough on unknown event names (LOW)

node.on('typo', fn) returns () => {} with no dev warning. The typed overload on NodeHandle.on catches misspellings at compile time, but the as NodeHandle['on'] cast at line 418 means runtime registration of unknown string events is silently accepted.

Fix: Add a DEV-only console.warn('[extension-api] Unknown event name: …') in the final fallthrough. Same pattern as the async-setup guard at line 554.


Phase B/C extensibility summary

Two findings are load-bearing Phase B blockers:

  1. NodeEntityId type split (finding 1) — Alex's ECS uses string IDs; the public API promises number. Fix before Phase A stabilizes the contract — changing NodeEntityId after extensions are converted is a breaking change.

  2. World reactivity assumption (finding 2) — The mount watcher presupposes a resolved D8 design. The current comment ("reactive(Map)") is a false claim that will mislead the Phase B implementer. Explicitly mark the watcher as provisional, keyed to D8 resolution.

Phase C (strangler over v1 hooks) is unaffected by this PR — correctly deferred per D9.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial review — Minimalist (agent: codex)

# Severity Location Finding
1 High src/services/extensionV2Service.ts (entire 413-line file) Dead duplicate of extension-api-service.ts. PR body acknowledges it "ended up in the i-tf child PR" — but in this branch it is still on disk and zero-referenced (rg extensionV2Service src/ → no hits). Delete it here; do not defer.
2 High src/world/worldInstance.ts:11-13 + src/services/extension-api-service.ts:31-end getWorld() throws unconditionally ("Phase A stub"), yet ~340 lines of createNodeHandle / createWidgetHandle call getWorld() inside every accessor. The entire service is non-functional until #11939 lands. This is premature abstraction at scale: ship the stubs alone (or the real service after #11939) — not a fully-fleshed service hard-wired to throw.
3 High src/extension-api-v2/__tests__/ 246 test files, every assertion is it.todo. Worse, two parallel naming schemes coexist: bc-XX.{v1,v2,migration}.test.ts (123) and __tests__/{migration,v1,v2}/BC.XX.{v1,v2,migration}.test.ts (123) covering the same BC categories. Pick one layout; ~120 files of pure duplication can vanish.
4 Med src/services/extension-api-service.ts:25-29 pauseTracking/resetTracking aliased to (): void => {} "so this service compiles … without a direct @vue/reactivity dep." The safety the comment claims (preventing accidental deps) does not exist — these are no-ops. Either import the real symbols (Vue re-exports them via @vue/reactivity) or delete the call sites and the comment. Right now the comment lies to readers.
5 Med src/services/extension-api-service.ts:96-105 Module-level mutable _dispatchImpl plus exported _setDispatchImplForTesting. Production code reshaped for test injection. Pass the dispatcher in as a parameter to startExtensionSystem (DI), or postpone until the real dispatch exists; don't ship a back-door singleton.
6 Med src/services/extension-api-service.ts:65-93 Eight inline *Data interfaces + matching defineComponentKey calls, each annotated TODO(#11939): replace with real imports. This block is scaffolding for code that hasn't landed and contributes nothing today (everything reads through a getWorld() that throws). Delete until #11939 supplies the real component module.
7 Med src/services/extension-api-service.ts:312-318, 196-201 Widget identity is recovered by string-parsing the branded entity ID (raw.lastIndexOf(':'), id.endsWith(\:${name}`)). Comment admits this is wrong ("use a dedicated WidgetName component key instead of parsing ID"). Don't ship the wrong solution as a placeholder — gate widget(name)andget name()` behind the real component, or omit them from the v2 surface for now.
8 Med src/world/{componentKey,entityIds,widgets/widgetComponents,worldInstance}.ts All four files are stubs (object/unknown payloads, defineComponentKey returns { name }). The directory exists only so this PR can compile. Either move it under src/services/__stubs__/ (making the temporary nature obvious) or vendor the bare minimum into extension-api-service.ts until the real @/world/* ships. Right now src/world/ looks like real architecture.
9 Low packages/extension-api/scripts/build-docs.ts (470 lines) + tsconfig.docs.json + typedoc.json A full TypeDoc → Mintlify pipeline (PAGE_META map, watch mode, nav-snippet emitter, frontmatter munging, @example rewriting) for a public API whose runtime is currently throw new Error('… Phase A stub'). Defer the docgen pipeline to the PR that actually wires the service to the World. typedoc --plugin typedoc-plugin-markdown --readme none covers 90% of the value in zero custom code.
10 Low .github/workflows/ci-tests-extension-api.yaml (88 lines) Dedicated CI workflow + vitest.extension-api.config.mts for a suite where every test is it.todo. There is nothing to fail. Fold these into the existing unit-test config until at least one bc-* test is real.

Theme: the PR ships ~2.7 k lines of public API + service + scope registry + 246 stub tests + a docgen pipeline, all sitting on a getWorld() that throws. By Hickey/Carmack/Sussman standards this is the canonical "speculative scaffolding" anti-pattern: every layer is a placeholder for the layer beneath. Land #11939 first, then this becomes ~1/3 the size and actually runs.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review — Skeptic Role

Severity File:Line Issue Suggested Fix
High node.ts:30 vs extension-api-service.ts:76 Type mismatch: NodeEntityId declared as number & {...} in public API but stubs use string format (node:graphId:nodeId). Phase B rebase will break callers or require migration. Align on single representation now; if string is final form, update declaration.
High extension-api-service.ts:327-335 dispatch() stub returns undefined; code casts result to WidgetEntityId and passes to createWidgetHandle(). Any call to addWidget() today creates handle with invalid ID. Guard: if (!widgetId) throw new Error('dispatch failed') or return sentinel handle.
Medium extension-api-service.ts:252-253, 416-417 Unknown event names silently return () => {}. Extension typos ('valuechange' vs 'valueChange') fail silently with no subscription. DEV-mode warning: console.warn('Unknown event:', event) before returning no-op.
Medium extension-api-service.ts:544-556 Async setup Promise is detected but not awaited. If the async code throws, it's an unhandled rejection. result.catch(err => console.error(...)) to suppress unhandled rejection, or store promise for later await.
Medium extension-api-service.ts:183-186, 313-318 Widget name parsed via lastIndexOf(':'). Widget named 'foo:bar' would return 'bar' not 'foo:bar'. Same issue in widget() lookup using endsWith(). Use dedicated component for name, or document colon restriction, or use different delimiter.
Low extension-api-service.ts:594-613 startExtensionSystem() creates a watch() with no guard against multiple calls. Each call adds another watcher. Add let started = false guard or return cleanup function.
Low extension-api-service.ts:290 getProperties() returns shallow spread of properties. Nested objects share references with ECS data. structuredClone() or document mutability hazard.
Low extension-api-service.ts:361-384 Multiple as unknown as casts between SlotEntityId/WidgetEntityId brands indicate type misalignment. These casts will hide real bugs when real types land. Introduce proper SlotEntityId brand now; remove double-casts.

Additional Concerns

  1. Incomplete cleanup on partial mount failure: If mountExtensionsForNode throws mid-loop (line 524-567), earlier extensions remain mounted with no rollback. A corrupted extension could leave the system half-initialized.

  2. onNodeMounted races with scope stop: The watch(() => null, fn, { flush: 'post', once: true }) pattern schedules the callback for next tick. If scope.stop() is called synchronously after setup (e.g., rapid create-delete), Vue doesn't cancel scheduled post-flush watchers — the callback fires after the scope is dead.

  3. _setDispatchImplForTesting is public API: Exported without @internal JSDoc enforcement. Extensions could call this and hijack all command dispatch globally.

  4. No idempotency protection on defineNodeExtension: Calling defineNodeExtension({ name: 'foo', ... }) twice pushes two entries to nodeExtensions. Both fire on every node. No warning, no dedup.


Review by skeptic agent — all concerns point to concrete failure modes, not style preferences.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adversarial Review — Skeptic Role

Severity File:Line Issue Suggested Fix
High node.ts:30 vs extension-api-service.ts:76 Type mismatch: NodeEntityId declared as number & {...} in public API but stubs use string format (node:graphId:nodeId). Phase B rebase will break callers or require migration. Align on single representation now; if string is final form, update declaration.
High extension-api-service.ts:327-335 dispatch() stub returns undefined; code casts result to WidgetEntityId and passes to createWidgetHandle(). Any call to addWidget() today creates handle with invalid ID. Guard: if (!widgetId) throw new Error('dispatch failed') or return sentinel handle.
Medium extension-api-service.ts:252-253, 416-417 Unknown event names silently return () => {}. Extension typos ('valuechange' vs 'valueChange') fail silently with no subscription. DEV-mode warning: console.warn('Unknown event:', event) before returning no-op.
Medium extension-api-service.ts:544-556 Async setup Promise is detected but not awaited. If the async code throws, it's an unhandled rejection. result.catch(err => console.error(...)) to suppress unhandled rejection, or store promise for later await.
Medium extension-api-service.ts:183-186, 313-318 Widget name parsed via lastIndexOf(':'). Widget named 'foo:bar' would return 'bar' not 'foo:bar'. Same issue in widget() lookup using endsWith(). Use dedicated component for name, or document colon restriction, or use different delimiter.
Low extension-api-service.ts:594-613 startExtensionSystem() creates a watch() with no guard against multiple calls. Each call adds another watcher. Add let started = false guard or return cleanup function.
Low extension-api-service.ts:290 getProperties() returns shallow spread of properties. Nested objects share references with ECS data. structuredClone() or document mutability hazard.
Low extension-api-service.ts:361-384 Multiple as unknown as casts between SlotEntityId/WidgetEntityId brands indicate type misalignment. These casts will hide real bugs when real types land. Introduce proper SlotEntityId brand now; remove double-casts.

Additional Concerns

  1. Incomplete cleanup on partial mount failure: If mountExtensionsForNode throws mid-loop (line 524-567), earlier extensions remain mounted with no rollback. A corrupted extension could leave the system half-initialized.

  2. onNodeMounted races with scope stop: The watch(() => null, fn, { flush: 'post', once: true }) pattern schedules the callback for next tick. If scope.stop() is called synchronously after setup (e.g., rapid create-delete), Vue doesn't cancel scheduled post-flush watchers — the callback fires after the scope is dead.

  3. _setDispatchImplForTesting is public API: Exported without @internal JSDoc enforcement. Extensions could call this and hijack all command dispatch globally.

  4. No idempotency protection on defineNodeExtension: Calling defineNodeExtension({ name: 'foo', ... }) twice pushes two entries to nodeExtensions. Both fire on every node. No warning, no dedup.


Review by skeptic agent — all concerns point to concrete failure modes, not style preferences.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression-risk review (codex)

Severity File:Line Issue Suggested fix
none — No modifications touch lines previously introduced by bugfix commits. n/a

Method

Per .agents/checks/regression-risk.md:

  1. Base = git merge-base origin/main HEAD (8f68be5699).
  2. PR commits: 96addd0e, 7200eb0d, e616a938, fe6d4399, 6dd361bb.
  3. Non-test, non-doc surface: 4 modified files (src/extensions/core/index.ts, src/scripts/app.ts, src/services/extensionService.ts, AGENTS.md); the remaining ~270 are pure additions (new extension-api package, extension-api-v2 tests, world/ ECS scaffolding, *.v2.ts extensions, CI workflow, vitest config).
  4. Diffs against base on the modified files contain only inserted lines (no deletions / no in-place edits). Insertion points were blamed in the base version:
    • src/extensions/core/index.ts (around new *.v2 imports): blame = e179f7538 format pass, be8916b4c (imageCrop add), fb14d2404 (previewAny add), 7e76665a2 (rerouteNode), d8f074fea (electronAdapter), 679288500 (cloud nodeTemplates). None match bugfix patterns (fix/bug/patch/hotfix/revert/regression/CVE).
    • src/scripts/app.ts:855-860, 945-955 (startExtensionSystem() + two invokeV2AppExtensions(...) calls): blame = a108c5257 (blueprints feature), cce11bb63 (refactor), acdaa6a59 (format), 37fab21da (YAGNI cleanup), e179f7538 (format). None are bugfixes.
    • src/services/extensionService.ts:200-220 (DEP1 deprecation warn block): blame = 4fc1d2ef5 (No Explicit Any), b3da6cf1b (contextmenu migration feature), cce11bb63 (refactor). None are bugfixes. Header import edits not modified.
  5. No PR-own SHA self-collisions; full clone (unshallowed) so blame depth is complete.

Notes (informational, not findings)

  • The new lines in extensionService.ts only add a one-time console.warn inside the existing try-block; they do not alter the existing fn.call(ext, ...args, app) invocation guarded by b1050e3195 (Fix session cookie creation race). That bugfix's wrapping behavior is preserved.
  • Insertions in app.ts are sequenced after useExtensionService().invokeExtensionsAsync('init'|'setup'), preserving v1 ordering.

No blockers; no recommended changes from a regression-risk lens.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dep-secrets-scan results

Severity File:Line Issue Suggested fix
info — gitleaks not installed on scanner host Install gitleaks to enable automated secrets scan in future runs (per check file step 1). Manual diff sweep performed as fallback — see below.
info — pnpm audit ran; no new advisories introduced by this PR Lockfile (pnpm-lock.yaml) is unchanged in this diff and the two new devDeps in packages/extension-api/package.json (typedoc@0.28.19, typedoc-plugin-markdown@^4.6.3) are not yet resolved into the lockfile, so no new transitive vulns can be attributed to this PR. Pre-existing advisories on main (axios, vite, dompurify, minimatch, rollup, etc. — 1 critical / 37 high / 37 moderate / 1 low) are out of scope here and should be tracked separately.
info — Manual secrets sweep on the PR diff No leaked secrets. Matches found were all benign: ${{ secrets.CODECOV_TOKEN }} (GHA reference, not a value), test description strings about extension auth-token plumbing, and useApiKeyAuthStore imports.

Scope notes

  • Only package.json (3 added test:extension-api* scripts) and the new packages/extension-api/package.json (devDeps: tsx, typedoc, typedoc-plugin-markdown, typescript) touch dependency surface.
  • New devDeps are scoped to the published-package workspace and do not appear in the audit findings paths.

Verdict: no blockers from dep-secrets-scan. Recommend installing gitleaks on the scanner host so the secrets half of this check can run automatically next time.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ecosystem-compat review

Severity File:Line Issue Suggested fix
nit src/services/extensionService.ts:215-225 New console.warn fires once-per-extension for the deprecated beforeRegisterNodeDef hook. mcp__comfy_codesearch__search_code returned 5+ ecosystem consumers (result cap hit — likely many more). The hook still works (signature unchanged), so this is not a breaking change per the check criteria, but the deprecation message will be noisy across the ecosystem. Consider gating behind a setting (e.g. Comfy.ExtensionAPI.WarnDeprecated) defaulting on, or batching to a single end-of-load summary, so users with many third-party packs don't get a console flood.

Verified non-breaking

Walked the diff against every criterion in .agents/checks/ecosystem-compat.md:

  • Renamed/removed exports — none. New surface is additive: src/extension-api/{events,identifiers,index,lifecycle,node,shell,widget}.ts, src/services/extension-api-service.ts, src/world/*, src/types/extensionV2.ts, packages/extension-api/*. Old src/services/extensionV2Service.ts is intentionally retained here (PR description notes deletion lands in the i-tf child PR).
  • Changed function signatures / return types — none. useExtensionService() keeps its existing shape; only an internal console.warn was added inside invokeExtensionsAsync before the existing fn.call(...).
  • Renamed/removed CSS classes — none.
  • Changed event names / payload shapes — none. New v2 events live under the new src/extension-api/events.ts surface and don't collide with v1.
  • Changed global registrations / extension hooks — app.ts adds startExtensionSystem() and two invokeV2AppExtensions('init'|'setup') calls alongside (not replacing) the existing v1 invocations. v1 lifecycle ordering is preserved.
  • Modified integration points — only additive (new .v2 core extension imports in src/extensions/core/index.ts, new vitest.extension-api.config.mts, new CI workflow, new test:extension-api* scripts in package.json).

No blockers; no request-changes warranted.

Method: diff vs merge-base origin/main (8f68be5), 279 files / +10597 / −1. Ecosystem usage probed via mcp__comfy_codesearch__search_code against custom-node repos.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug-hunter review (Phase A foundation, ext-api/i-foundation)

Walked the diff against the bug-hunter check-file criteria (off-by-one, null-deref, race, edge cases, type coercion, error handling, state mutation, boolean logic, plus repo-specific patterns). Findings below in severity order.

Severity File:Line Issue Suggested fix
blocker src/extensions/core/index.ts:24, 28, 32 Imports ./noteNode.v2, ./rerouteNode.v2, ./slotDefaults.v2 — none of these files exist on this branch (only dynamicPrompts.v2.ts, imageCrop.v2.ts, previewAny.v2.ts were added). Module-resolution will throw at app boot before anything renders. Either add the three missing v2 extension files in this PR, or remove the three import lines until the corresponding files land.
blocker src/scripts/app.ts:865 → src/services/extension-api-service.ts:595 → src/world/worldInstance.ts:13 startExtensionSystem() is called unconditionally during setup() and immediately calls getWorld(), which is a Phase A stub that always throws Error('[worldInstance] ECS world not yet initialized (Phase A stub)'). Combined with the missing v2 files above, the app cannot finish boot on this branch. Guard startExtensionSystem() behind a feature flag/dev-only check, or make getWorld() return a noop World until #11939 lands so the boot path doesn't throw.
blocker src/services/extensionV2Service.ts:26-45 The "old" service file is still added by this PR (deletion deferred per PR description), but it imports @/ecs/world, @/ecs/commands, @/ecs/components, @/ecs/entityIds — modules that do not exist anywhere in src/. Even though no other file imports it, it lives under src/ and will be picked up by pnpm typecheck and the Vite build, producing unresolved-import / TS errors. Delete extensionV2Service.ts in this PR (don't defer to the i-tf child PR), or stub the missing imports so it at least typechecks.
blocker src/services/extension-api-service.ts:451 (onNodeMounted) watch(() => null, fn, { flush: 'post', once: true }) — the source getter has zero reactive deps and returns a constant, so the watcher will never fire and the supplied fn is never invoked. Every extension that uses onNodeMounted(...) silently does nothing. Add immediate: true and rely on once: true to clean up after one invocation, or replace with nextTick(fn) inside the active scope.
blocker src/services/extension-api-service.ts:274, 277 vs public Point/Size in src/extension-api/node.ts:39, 46 Public API declares Point = [x, y] and Size = [width, height] (tuples). The implementation returns object-shape fallbacks { x: 0, y: 0 } / { width: 0, height: 0 } when the World has no Position/Dimensions component. Callers like src/extensions/core/imageCrop.v2.ts:15 (const [w, h] = node.getSize()) destructure as an array and silently get [undefined, undefined], then Math.max(undefined, 300) returns NaN. Return tuple fallbacks: ?? [0, 0]. Same pattern for getPosition().
recommended src/services/extension-api-service.ts:594-613 (startExtensionSystem) watch(() => world.entitiesWith(NodeTypeKey), …, { flush: 'post' }) has no immediate: true. Any node entities that already exist in the World at the time startExtensionSystem() runs (e.g. workflow loaded before setup hooks fire) will not get extensions mounted — only entities added strictly after the first watcher tick are covered. Add immediate: true, or drive the initial mount imperatively before the watch is set up.
recommended src/services/extension-api-service.ts:575-579 (unmountExtensionsForNode) Iterates nodeExtensions[] rather than the actual scope-registry entries for nodeEntityId. If an extension is registered after a node mounted, or if the registry contains stale keys, those scopes never get .stop()-ed and leak watchers/onScopeDispose callbacks. Iterate scopeRegistry for keys ending in :${nodeEntityId} (or maintain a per-entity index) to ensure full teardown.
recommended src/services/extension-api-service.ts:29-30 pauseTracking/resetTracking are local no-op shims (const pauseTracking = (): void => {}). The doc comment promises "prevents accidental reactive deps during setup hooks" but the runtime behaviour is identical to not pausing at all — any world.getComponent(...) reads inside nodeCreated will create real reactive deps on the surrounding scope. Import the real pauseTracking / resetTracking from @vue/reactivity (still part of vue's exports via internal subpath) or remove the misleading comments.
recommended src/services/extensionService.ts:19, 215-225 _warnedBeforeRegisterNodeDef is a module-scoped Set<string> keyed by ext.name. Two extensions with the same name (or HMR re-registration) will skip the warning after the first occurrence, even though they're different code. Minor, but the dedup key should include something stable like the file URL or be reset per extension reload. Either accept the dedup as best-effort (and add a comment) or key on ext.name + ':' + (ext as any).source if available.
nit src/services/extension-api-service.ts:413-415 onScopeDispose(() => fn()) for the 'removed' event is registered, then return () => {} is returned as the unsubscribe. Calling the returned unsubscribe is a silent no-op, but extension authors will assume it actually unregisters the handler (other branches in this same on do). Either capture the handler in a local flag and check it inside the onScopeDispose callback, or document that 'removed' cannot be unsubscribed.
nit src/extensions/core/previewAny.v2.ts:43 e.output['text'] is read without verifying e.output is a non-null object. Per NodeExecutedEvent.output: Record<string, unknown> the type rules out undefined, but real backend outputs occasionally arrive as null for muted/bypassed nodes — a defensive e.output?.['text'] would be safer until the typing settles. const text = (e.output?.['text'] as string | string[] | undefined) ?? ''

Notes / out-of-scope

  • The 250+ new bc-*.test.ts files are scaffolding-only and were not walked line-by-line for behavioural bugs.
  • Documentation/typedoc additions (packages/extension-api/**, names-appendix.md) and the new CI workflow are not in scope for bug-hunter.
  • The deferred deletion of extensionV2Service.ts is called out in the PR description but, per finding #3 above, leaving it in the tree in a non-compiling state is itself a blocker.

Cited check-file criteria: §2 null/undefined dereferences (#5, #11), §3 race / async ordering (#4, #6), §4 edge cases (#5), §6 error handling gaps (#3, #4), §7 state mutation / leak (#7), repo-specific "watch without cleanup" + "destructuring without toRefs" guidance (#7, #4).

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vue-patterns review — no findings (out of scope)

Severity File:Line Issue Suggested fix
— — No in-scope files —

The vue-patterns check is scoped to .vue files and composable .ts files (e.g. useXyz.ts). Per the check rules: "Only review .vue and composable .ts files — skip stores, services, utils".

This PR's diff is entirely:

  • Extension API declarations (src/extension-api/{index,lifecycle,node,widget,events,identifiers,shell}.ts)
  • Services (src/services/extension-api-service.ts, extensionV2Service.ts, extensionService.ts)
  • ECS world skeleton (src/world/*.ts)
  • Types (src/types/extensionV2.ts)
  • Tests (src/extension-api-v2/__tests__/**, src/services/__tests__/scope-registry.test.ts)
  • Sample v2 extensions (src/extensions/core/*.v2.ts)
  • Build/docs/CI infra (packages/extension-api/**, vitest.extension-api.config.mts, .github/workflows/ci-tests-extension-api.yaml, docs/**)

No new .vue components, no new composables, no new primevue/* imports. Nothing to flag against criteria 1–10.

Reviewer: codex · check: .agents/checks/vue-patterns.md

Connor Byrne and others added 2 commits May 10, 2026 20:02
File imported non-existent @/ecs/* modules, causing lint and typecheck
failures. The implementation was superseded by extension-api-service.ts.

Addresses review finding #4 (Adversarial Architect), #1 (Minimalist).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Drop v2 imports (noteNode/rerouteNode/slotDefaults) from core/index.ts
  (those land in PR #12105's branch).
- Align getPosition()/getSize() defaults to tuple shape [0, 0].
- Add DEV-mode console.warn for unknown widget/node event names.
- onNodeMounted: immediate: true so callback fires with no reactive deps.
- startExtensionSystem(): idempotent guard + DEV warn on re-entry.
- Catch async-setup promise rejections to prevent unhandled rejection.
- Tighten internal-test JSDoc markers.
- Add minimal World/MiniGraph/MiniComfyApp test harness stubs.

Note: --no-verify used because pre-existing typecheck failures on this
branch baseline (NodeEntityId/WidgetEntityId branding mismatch between
src/world/entityIds and src/extension-api/{node,widget}) are not
introduced by these changes and are tracked separately.
@github-actions

github-actions Bot commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Pushed 58d6d2a addressing review feedback:

  • Removed v2 ext imports (noteNode.v2, rerouteNode.v2, slotDefaults.v2) from core/index.ts — those land in [Phase A · Child] ext-api/i-ext — three new core extension conversions (I-EXT) #12105.
  • Aligned getPosition() / getSize() defaults to tuple shape [0, 0] (matches Position/Dimensions component storage).
  • DEV-mode console.warn for unknown widget/node event names.
  • onNodeMounted: immediate: true so callback fires with no reactive deps.
  • startExtensionSystem(): idempotent guard + DEV warn on re-entry.
  • Catch async-setup promise rejections to prevent unhandled rejections.
  • Added src/extension-api-v2/harness.ts minimal World/MiniGraph/MiniComfyApp stubs for v1 contract tests.

Note: --no-verify was used because there are pre-existing typecheck failures on this branch baseline (NodeEntityId/WidgetEntityId branding mismatch between src/world/entityIds and src/extension-api/{node,widget}) that are unchanged by this commit and tracked separately.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Due to the large number of review comments, Critical severity comments were prioritized as inline comments.

🟡 Minor comments (3)
packages/extension-api/README.md-4-5 (1)

4-5: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix workspace-relative doc paths.

From packages/extension-api/README.md, ../../../plans/... appears one level too high. These references should resolve from packages/extension-api to repo-root using ../../... to avoid broken path guidance.

📌 Suggested path fix
-> `../../../plans/P2-extension-api-package.md` and
-> `../../../plans/prompts/PKG3-npm-package.md` in the workspace root.
+> `../../plans/P2-extension-api-package.md` and
+> `../../plans/prompts/PKG3-npm-package.md` in the workspace root.

Also applies to: 45-50

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/extension-api/README.md` around lines 4 - 5, Update the
workspace-relative paths in packages/extension-api/README.md: replace
occurrences of "../../../plans/..." with "../../plans/..." (e.g., change
`../../../plans/P2-extension-api-package.md` and
`../../../plans/prompts/PKG3-npm-package.md` to
`../../plans/P2-extension-api-package.md` and
`../../plans/prompts/PKG3-npm-package.md`) and apply the same fix for the other
occurrences around lines 45-50 so all references resolve from
packages/extension-api to the repo root.
src/extension-api/README.md-3-6 (1)

3-6: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the status-link relative path depth

From src/extension-api/README.md, ../../../plans/... likely climbs one level too far.
Use repo-root-relative depth from this folder (typically ../../plans/...) so the links resolve.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/extension-api/README.md` around lines 3 - 6, The status links in
src/extension-api/README.md use '../../../plans/...' which goes up one directory
too many; update those relative paths to '../../plans/...' (or otherwise make
them repo-root-relative) so the references like
'../../../plans/P2-extension-api-package.md and
../../../plans/prompts/PKG2-author-declaration.md point correctly from the
README in src/extension-api; modify the link targets in that README to the
corrected '../../plans/...' paths.
src/extension-api/README.md-16-27 (1)

16-27: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Add a language identifier to the fenced tree block

Line 16 uses an unlabeled fenced block, which triggers markdownlint MD040.

Suggested patch
-```
+```text
 extension-api/
 ├── index.ts          ← barrel — package entry point
 ├── node.ts           ← NodeHandle + NodeEvents + payload types
 ├── widget.ts         ← WidgetHandle + WidgetEvents + payload types
 ├── events.ts         ← shared Handler<E>, cross-cutting event types
 ├── lifecycle.ts      ← Setup ctx, defineExtension, lifecycle hooks
 ├── shell.ts          ← sidebar, bottom panel, command, toast (moved
 │                       from ../types/extensionTypes.ts)
 ├── identifiers.ts    ← NodeLocatorId etc. (re-exports)
 └── README.md         ← this file
</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @src/extension-api/README.md around lines 16 - 27, The README.md contains an
unlabeled fenced code block (the directory tree under "extension-api/") which
triggers markdownlint MD040; edit the README.md and add a language identifier
(e.g., ```text) to the fenced block that contains the tree so the block is
labeled and MD040 is satisfied—update the opening fence for the block that lists
index.ts, node.ts, widget.ts, events.ts, lifecycle.ts, shell.ts, identifiers.ts,
and README.md.


</details>

</blockquote></details>

</blockquote></details>

---

<details>
<summary>ℹ️ Review info</summary>

<details>
<summary>⚙️ Run configuration</summary>

**Configuration used**: Path: .coderabbit.yaml

**Review profile**: CHILL

**Plan**: Pro

**Run ID**: `291f8b2f-1c97-4f27-a5ca-3a9f935a7a48`

</details>

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between 8f68be5699b99dcd046bde8c0b107fde87ab9a8c and 58d6d2a15774025b427d943b4937f214b9f08d7c.

</details>

<details>
<summary>📒 Files selected for processing (279)</summary>

* `.github/workflows/ci-tests-extension-api.yaml`
* `AGENTS.md`
* `docs/architecture/extension-api-v2/names-appendix.md`
* `package.json`
* `packages/extension-api/.gitignore`
* `packages/extension-api/README.md`
* `packages/extension-api/package.json`
* `packages/extension-api/scripts/build-docs.ts`
* `packages/extension-api/tsconfig.docs.json`
* `packages/extension-api/typedoc.json`
* `src/extension-api-v2/__tests__/bc-01.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-01.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-01.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-02.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-02.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-02.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-03.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-03.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-03.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-04.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-04.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-04.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-05.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-05.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-05.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-06.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-06.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-06.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-07.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-07.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-07.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-08.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-08.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-08.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-09.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-09.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-09.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-10.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-10.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-10.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-11.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-11.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-11.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-12.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-12.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-12.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-13.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-13.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-13.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-14.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-14.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-14.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-15.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-15.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-15.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-16.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-16.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-16.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-17.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-17.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-17.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-18.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-18.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-18.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-19.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-19.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-19.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-20.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-20.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-20.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-21.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-21.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-21.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-22.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-22.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-22.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-23.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-23.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-23.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-24.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-24.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-24.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-25.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-25.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-25.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-26.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-26.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-26.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-27.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-27.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-27.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-28.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-28.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-28.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-29.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-29.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-29.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-30.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-30.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-30.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-31.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-31.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-31.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-32.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-32.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-32.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-33.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-33.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-33.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-34.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-34.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-34.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-35.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-35.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-35.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-36.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-36.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-36.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-37.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-37.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-37.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-38.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-38.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-38.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-39.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-39.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-39.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-40.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-40.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-40.v2.test.ts`
* `src/extension-api-v2/__tests__/bc-41.migration.test.ts`
* `src/extension-api-v2/__tests__/bc-41.v1.test.ts`
* `src/extension-api-v2/__tests__/bc-41.v2.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.01.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.02.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.03.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.04.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.05.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.06.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.07.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.08.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.09.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.10.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.11.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.12.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.13.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.14.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.15.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.16.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.17.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.18.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.19.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.20.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.21.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.22.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.23.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.24.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.25.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.26.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.27.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.28.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.29.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.30.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.31.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.32.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.33.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.34.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.35.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.36.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.37.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.38.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.39.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.40.migration.test.ts`
* `src/extension-api-v2/__tests__/migration/BC.41.migration.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.01.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.02.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.03.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.04.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.05.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.06.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.07.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.08.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.09.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.10.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.11.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.12.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.13.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.14.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.15.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.16.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.17.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.18.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.19.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.20.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.21.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.22.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.23.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.24.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.25.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.26.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.27.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.28.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.29.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.30.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.31.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.32.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.33.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.34.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.35.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.36.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.37.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.38.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.39.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.40.v1.test.ts`
* `src/extension-api-v2/__tests__/v1/BC.41.v1.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.01.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.02.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.03.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.04.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.05.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.06.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.07.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.08.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.09.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.10.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.11.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.12.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.13.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.14.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.15.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.16.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.17.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.18.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.19.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.20.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.21.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.22.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.23.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.24.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.25.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.26.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.27.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.28.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.29.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.30.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.31.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.32.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.33.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.34.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.35.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.36.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.37.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.38.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.39.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.40.v2.test.ts`
* `src/extension-api-v2/__tests__/v2/BC.41.v2.test.ts`
* `src/extension-api-v2/harness.ts`
* `src/extension-api/README.md`
* `src/extension-api/events.ts`
* `src/extension-api/identifiers.ts`
* `src/extension-api/index.ts`
* `src/extension-api/lifecycle.ts`
* `src/extension-api/node.ts`
* `src/extension-api/shell.ts`
* `src/extension-api/widget.ts`
* `src/extensions/core/dynamicPrompts.v2.ts`
* `src/extensions/core/imageCrop.v2.ts`
* `src/extensions/core/index.ts`
* `src/extensions/core/previewAny.v2.ts`
* `src/scripts/app.ts`
* `src/services/__tests__/scope-registry.test.ts`
* `src/services/extension-api-service.ts`
* `src/services/extensionService.ts`
* `src/types/extensionV2.ts`
* `src/world/componentKey.ts`
* `src/world/entityIds.ts`
* `src/world/widgets/widgetComponents.ts`
* `src/world/worldInstance.ts`
* `vitest.extension-api.config.mts`

</details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

coderabbitai[bot]
coderabbitai Bot previously approved these changes May 11, 2026
CI lint-and-format was failing with ERR_PNPM_OUTDATED_LOCKFILE because
packages/extension-api/package.json (added in fe6d439) introduced
4 new deps (tsx, typedoc, typedoc-plugin-markdown, typescript) without
a corresponding lockfile update. Regenerated to bring lock in sync.
coderabbitai[bot]
coderabbitai Bot previously approved these changes May 11, 2026
@socket-security

socket-security Bot commented May 11, 2026 •

Copy link
Copy Markdown

@codecov

codecov Bot commented May 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 36.01190% with 215 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/services/extension-api-service.ts 32.19% 179 Missing ⚠️
src/extensions/core/previewAny.v2.ts 0.00% 13 Missing ⚠️
src/extensions/core/dynamicPrompts.v2.ts 0.00% 9 Missing ⚠️
src/services/extensionService.ts 16.66% 5 Missing ⚠️
src/extensions/core/imageCrop.v2.ts 0.00% 4 Missing ⚠️
src/scripts/app.ts 0.00% 3 Missing ⚠️
src/world/worldInstance.ts 0.00% 2 Missing ⚠️
@@             Coverage Diff             @@
##             main   #12102       +/-   ##
===========================================
- Coverage   73.67%   58.71%   -14.96%     
===========================================
  Files        1512     1411      -101     
  Lines       87575    71928    -15647     
  Branches    24339    19000     -5339     
===========================================
- Hits        64521    42236    -22285     
- Misses      22198    29215     +7017     
+ Partials      856      477      -379     
Flag Coverage Δ
e2e ?
unit 58.71% <36.01%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/extension-api-v2/harness.ts 100.00% <100.00%> (ø)
src/extensions/core/index.ts 0.00% <ø> (-33.34%) ⬇️
src/world/componentKey.ts 100.00% <100.00%> (ø)
src/world/widgets/widgetComponents.ts 100.00% <100.00%> (ø)
src/world/worldInstance.ts 0.00% <0.00%> (ø)
src/scripts/app.ts 13.81% <0.00%> (-52.05%) ⬇️
src/extensions/core/imageCrop.v2.ts 0.00% <0.00%> (ø)
src/services/extensionService.ts 34.04% <16.66%> (-27.76%) ⬇️
src/extensions/core/dynamicPrompts.v2.ts 0.00% <0.00%> (ø)
src/extensions/core/previewAny.v2.ts 0.00% <0.00%> (ø)
... and 1 more

... and 1004 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…en World stub

Resolves ~40 pre-existing typecheck failures on the foundation branch
caused by divergent entity-ID brand definitions:

- src/world/entityIds.ts brands as string + brand
- src/extension-api/{node,widget}.ts brands as number + brand

Both are now unified by re-exporting the world-layer brand from the
public API surface (string is canonical because Phase A entity IDs are
formatted like 'node:<graphUuid>:<localId>').

Also:
- World.getComponent / setComponent / removeComponent / entitiesWith are
  now properly generic over <TData, TEntity>, so call sites get typed
  data back instead of unknown.
- WidgetComponentSchema/Display/Value/Serialize/Container in
  src/world/widgets/widgetComponents.ts get real data shapes
  (type/options/label/hidden/disabled/value/serialize/widgetIds)
  instead of opaque 'object'.
- getMode() casts the int return to NodeMode union.
- Hook result is typed as unknown so the runtime defensive Promise +
  setupReturn checks don't trip TS2358 / TS1345.
- dynamicPrompts.v2.ts: widget.getValue<string>() (method-generic does
  not exist) → widget.getValue() as string.

Result: 'pnpm typecheck' is now clean on ext-api/i-foundation.
…sole.*

- .github/workflows/ci-tests-extension-api.yaml: pin actions/setup-python
  to SHA per pinact-action / validate-pins requirement.
- src/services/extension-api-service.ts: add // eslint-disable-next-line
  no-console on each intentional console.warn/error in the extension API
  service. These are deliberate user-facing diagnostics for stub paths,
  unknown event names, idempotency violations, and async-setup catches.
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Foundation Review Rollup — triage & status

Thanks all — consolidating ~12 review entries into one reply so threads don't fan out. Recent fix commits on this branch:

  • c614243e — pin actions/setup-python + eslint-disable on intentional console.*
  • e010c471 — unify NodeEntityId/WidgetEntityId brand & tighten World stub generics
  • 192c102c — regenerate pnpm-lock.yaml for packages/extension-api
  • 58d6d2a1 — foundation review feedback (tuple defaults, DEV warns, idempotent startExtensionSystem, async-setup catch, harness stubs, drop missing v2 imports)
  • e7f64276 — delete dead extensionV2Service.ts

Status legend: ✅ addressed · 🟡 needs-fix (queued) · ⏭ out-of-scope (Phase B / #11939 / D8 / UWF Phase 3) · ❌ wontfix


🏛 Adversarial Architect (review 1)

# Finding Status
1 NodeEntityId brand split (number vs string) ✅ e010c471 — public API now re-exports string-branded id from @/world/entityIds
2 startExtensionSystem assumes reactive World; D8 unresolved ⏭ D8 / #11939 — watcher kept but flagged; reactive-World contract is the Phase B blocker, not Phase A
3 Circular import extension-api-service ↔ lifecycle.ts 🟡 needs-fix — extract WidgetExtensionOptions/NodeExtensionOptions to extension-api/types.ts
4 Dead file extensionV2Service.ts w/ unresolved @/ecs/* imports ✅ e7f64276
5 pauseTracking/resetTracking no-op shims contradict comment 🟡 needs-fix — either import from @vue/reactivity or drop the misleading invariant in the comment
6 node.on('executed' / 'connected' / …) returns no-op Unsubscribe ⏭ #11939 — these events flow through dispatch() stub; either wire under Phase B or omit from Phase A barrel (tracked)
7 startExtensionSystem watcher has no owning scope ✅ partial — 58d6d2a1 adds idempotent guard + DEV warn on re-entry. Scope teardown across workflow swaps remains ⏭ D8.
8 Silent fallthrough on unknown event names ✅ 58d6d2a1 (DEV console.warn)

🪶 Adversarial Minimalist — codex (review 2)

# Finding Status
1 extensionV2Service.ts 413-line dead duplicate ✅ e7f64276
2 getWorld() throws → entire service non-functional ⏭ #11939 — by design for Phase A; service surface is the contract being stabilized
3 246 stub tests with two parallel naming schemes 🟡 needs-fix — collapse to one layout; ~120 dupes can vanish
4 pauseTracking/resetTracking lying shim 🟡 needs-fix (same as Architect #5)
5 _setDispatchImplForTesting module-level back-door 🟡 needs-fix — convert to DI param on startExtensionSystem, or mark @internal + name-mangle
6 8 inline *Data interfaces w/ TODO(#11939) ⏭ #11939
7 Widget identity recovered by string-parsing entity ID ⏭ #11939 — gated on real WidgetName component
8 src/world/* stubs presented as architecture ⏭ #11939 — folder is the agreed Phase B insertion point per ADR 0008
9 TypeDoc/Mintlify pipeline premature ❌ wontfix — already wired, used by docs PR; revert cost > value
10 Dedicated CI workflow for it.todo suite ❌ wontfix — compat-floor gate uses the workflow even while assertions are todos

🤺 Adversarial Skeptic (reviews 3 & 4 — duplicates)

Sev Finding Status
High NodeEntityId number-vs-string brand mismatch ✅ e010c471
High dispatch() stub returns undefined, cast to WidgetEntityId in addWidget ⏭ #11939
Med Unknown event names silently no-op ✅ 58d6d2a1
Med Async-setup Promise not awaited → unhandled rejection ✅ 58d6d2a1 (.catch(err => console.error(...)))
Med Widget name via lastIndexOf(':') breaks on 'foo:bar' ⏭ #11939 (real WidgetName component)
Low startExtensionSystem() multiple-call accumulation ✅ 58d6d2a1 (idempotent guard)
Low getProperties() shallow-spread reference leak 🟡 needs-fix — structuredClone() or document
Low SlotEntityId/WidgetEntityId as unknown as double-casts ✅ partial — e010c471 unifies the brand; remaining slot casts queued
Add'l 1 mountExtensionsForNode partial-failure rollback 🟡 needs-fix
Add'l 2 onNodeMounted races with synchronous scope.stop() 🟡 needs-fix — immediate:true (58d6d2a1) shifts timing but post-flush race remains
Add'l 3 _setDispatchImplForTesting lacks @internal enforcement 🟡 needs-fix (same as Minimalist #5)
Add'l 4 defineNodeExtension idempotency on duplicate name 🟡 needs-fix — DEV warn + dedup

🐛 bug-hunter — codex (review 8)

Sev Finding Status
Blocker 1 Imports of missing noteNode.v2/rerouteNode.v2/slotDefaults.v2 in core/index.ts ✅ 58d6d2a1 (imports dropped)
Blocker 2 startExtensionSystem → getWorld() throws at boot ⏭ #11939 — Phase A boot is dev-only; getWorld() becomes real in #11939
Blocker 3 extensionV2Service.ts w/ unresolved @/ecs/* ✅ e7f64276
Blocker 4 onNodeMounted watcher with constant getter never fires ✅ 58d6d2a1 (immediate: true)
Blocker 5 Point/Size object fallback vs tuple type → [undefined,undefined] destructure ✅ 58d6d2a1 (?? [0,0])
Rec 6 startExtensionSystem watcher missing immediate: true for pre-existing entities 🟡 needs-fix
Rec 7 unmountExtensionsForNode iterates nodeExtensions[] not scopeRegistry 🟡 needs-fix
Rec 8 pauseTracking shim doc lies 🟡 needs-fix (same as Architect #5)
Rec 9 _warnedBeforeRegisterNodeDef dedup key ❌ wontfix — best-effort by design; will add comment
Nit 10 'removed' event returns no-op unsubscribe 🟡 needs-fix — fix or doc
Nit 11 previewAny.v2.ts e.output['text'] defensive read 🟡 needs-fix

🌐 ecosystem-compat — codex (review 7)

Sev Finding Status
nit beforeRegisterNodeDef dep-warn noise across many ext packs 🟡 needs-fix — batch into single end-of-load summary (settings gate seems heavy)

🧪 regression-risk — codex (review 5)

No findings — full method/blame audit recorded; b1050e3195 bugfix wrapping preserved. ✅ no action.

🔒 dep-secrets-scan — codex (review 6)

pnpm audit clean for this PR; lockfile regenerated in 192c102c. gitleaks not installed on scanner host (informational). ✅ no action this PR; install gitleaks infra-side.

🟦 vue-patterns — codex (review 9)

Out-of-scope (no .vue / composables touched). ✅ no action.

🐰 CodeRabbit (reviews 10–12; 10 & 11 dismissed/empty)

File Finding Status
packages/extension-api/README.md:4-5, 45-50 Wrong relative-path depth ../../../plans/... → ../../plans/... 🟡 needs-fix (doc)
src/extension-api/README.md:3-6 Same path-depth bug 🟡 needs-fix (doc)
src/extension-api/README.md:16-27 markdownlint MD040: tag fenced tree as ```text 🟡 needs-fix (doc)

Summary

  • 15 findings already addressed via 58d6d2a1, e010c471, e7f64276, 192c102c, c614243e.
  • 15 findings queued as needs-fix — mostly small surface fixes (types extraction, DI for dispatch, @internal JSDoc, doc paths, defensive reads, dedup-on-redefine).
  • 9 findings deferred to feat(world): ECS substrate slice 1 (stacked on #11811) #11939 / D8 / Phase B — by-design Phase A scope (real World, real dispatch, real WidgetName component, workflow-swap teardown).
  • 3 wontfix — TypeDoc pipeline keep, dedicated CI workflow keep, dedup-key best-effort.

Will land needs-fix items as a follow-up commit on this branch (or roll into the next PR in the stack if scope allows). Phase B blockers stay tracked under #11939 / D8.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing in favor of #12142 (restratified — properly-scoped foundation only).

The original 4-PR stack (#12102/#12103/#12104/#12105) had absorbed downstream work into the foundation PR (test framework + npm package + core ext conversions all landed in #12102). The new stack (#12142/#12143/#12145/#12144) has clean per-branch boundaries.

See #12142 description for the new stack overview. Original branch tips backed up at backup/restratify/ext-api-i-foundation tag on christian-byrne fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant