Repository navigation
fix: account for panel width in fitView() viewport bounds - #11827
christian-byrne wants to merge 14 commits into
Conversation
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
📝 WalkthroughWalkthroughAdds viewport inset support for fit-to-bounds and animated fit-to-bounds, computes insets from the canvas and panel DOM rectangles, and wires those insets through the fit-view command and service. Tests cover inset calculation and inset-aware DragAndScale behavior. ChangesViewport inset fit-view support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
Suggested reviewers
Poem
Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 1 warning)
✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.26 MB gzip 🔴 +359 BDetailsSummary
Category Glance App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🔴 +74 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 82.3 kB (baseline 82.3 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.6 kB (baseline 17.6 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.05 MB (baseline 3.05 MB) • 🔴 +1.87 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 365 kB (baseline 365 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.82 MB (baseline 8.82 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 79 unchanged ⚡ Performance Report
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T23:40:59.853Z",
"gitSha": "1fa01cb7a268634963258764c3aab051cbccc6c8",
"branch": "cross-dispatch/issue-11154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2026.7639999999574,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.481000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 354.479,
"heapDeltaBytes": 22789020,
"heapUsedBytes": 71216284,
"domNodes": 16,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 16.48999999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.4510000000082,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.699999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.675,
"heapDeltaBytes": 22956332,
"heapUsedBytes": 71683296,
"domNodes": 18,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 15.32,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2045.2860000000328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.783000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.227,
"heapDeltaBytes": 23176472,
"heapUsedBytes": 72287868,
"domNodes": 20,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 23.408000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1851.6700000000128,
"styleRecalcs": 73,
"styleRecalcDurationMs": 42.387,
"layouts": 12,
"layoutDurationMs": 3.849,
"taskDurationMs": 855.785,
"heapDeltaBytes": -977688,
"heapUsedBytes": 47293496,
"domNodes": -265,
"jsHeapTotalBytes": 16904192,
"scriptDurationMs": 131.06199999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1843.1530000000294,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.970000000000006,
"layouts": 12,
"layoutDurationMs": 4.037,
"taskDurationMs": 808.482,
"heapDeltaBytes": 4491968,
"heapUsedBytes": 53179660,
"domNodes": -264,
"jsHeapTotalBytes": 16904192,
"scriptDurationMs": 120.752,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2047.247000000084,
"styleRecalcs": 82,
"styleRecalcDurationMs": 41.536,
"layouts": 12,
"layoutDurationMs": 3.698,
"taskDurationMs": 1023.026,
"heapDeltaBytes": 5142700,
"heapUsedBytes": 52796504,
"domNodes": -259,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 126.01200000000001,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.6130000000094,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.017,
"layouts": 6,
"layoutDurationMs": 0.6480000000000001,
"taskDurationMs": 288.743,
"heapDeltaBytes": 163432,
"heapUsedBytes": 48810824,
"domNodes": 76,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 17.984,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1728.4029999999575,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.942000000000005,
"layouts": 6,
"layoutDurationMs": 0.7969999999999997,
"taskDurationMs": 288.264,
"heapDeltaBytes": -32596,
"heapUsedBytes": 47992116,
"domNodes": 73,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 18.436000000000007,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1715.2859999999919,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.430999999999997,
"layouts": 6,
"layoutDurationMs": 0.6669999999999998,
"taskDurationMs": 288.213,
"heapDeltaBytes": 203748,
"heapUsedBytes": 48849512,
"domNodes": 75,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 18.435000000000006,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 646.8160000000012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.233999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.769,
"heapDeltaBytes": 9174988,
"heapUsedBytes": 58198872,
"domNodes": 12,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 59.568999999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 535.1190000000088,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.419000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.82,
"heapDeltaBytes": 8773936,
"heapUsedBytes": 57496664,
"domNodes": 18,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 52.634,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 583.9080000000649,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.167000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.225,
"heapDeltaBytes": 9496620,
"heapUsedBytes": 57163236,
"domNodes": 20,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 61.013,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2013.181999999972,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.531000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.258,
"heapDeltaBytes": 4087824,
"heapUsedBytes": 62319536,
"domNodes": -265,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 77.466,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2012.5280000000885,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.9479999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.9949999999999,
"heapDeltaBytes": 9915400,
"heapUsedBytes": 68222660,
"domNodes": -265,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 80.83599999999998,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.6340000000964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.861,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.492,
"heapDeltaBytes": 10401248,
"heapUsedBytes": 68594148,
"domNodes": -260,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 89.91500000000002,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2116.645999999946,
"styleRecalcs": 68,
"styleRecalcDurationMs": 17.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1083.984,
"heapDeltaBytes": 9393440,
"heapUsedBytes": 68799196,
"domNodes": -260,
"jsHeapTotalBytes": -290816,
"scriptDurationMs": 383.336,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2113.222999999948,
"styleRecalcs": 69,
"styleRecalcDurationMs": 18.582,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1058.962,
"heapDeltaBytes": 7964912,
"heapUsedBytes": 67219652,
"domNodes": -262,
"jsHeapTotalBytes": 1544192,
"scriptDurationMs": 367.131,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2134.4060000000127,
"styleRecalcs": 67,
"styleRecalcDurationMs": 17.685,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.654,
"heapDeltaBytes": 9900084,
"heapUsedBytes": 69570208,
"domNodes": -265,
"jsHeapTotalBytes": 757760,
"scriptDurationMs": 365.17299999999994,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3147.4609999999075,
"styleRecalcs": 65,
"styleRecalcDurationMs": 20.13,
"layouts": 60,
"layoutDurationMs": 8.395,
"taskDurationMs": 1365.099,
"heapDeltaBytes": -6806040,
"heapUsedBytes": 54042624,
"domNodes": -266,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 497.98199999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3164.8409999999103,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.415000000000003,
"layouts": 60,
"layoutDurationMs": 8.123,
"taskDurationMs": 1317.893,
"heapDeltaBytes": 8762548,
"heapUsedBytes": 69593396,
"domNodes": -265,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 487.212,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3134.7220000000107,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.116999999999997,
"layouts": 60,
"layoutDurationMs": 8.267,
"taskDurationMs": 1315.266,
"heapDeltaBytes": 15969584,
"heapUsedBytes": 78299784,
"domNodes": -267,
"jsHeapTotalBytes": 4280320,
"scriptDurationMs": 478.69200000000006,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2036.5840000000617,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.582999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 545.7189999999999,
"heapDeltaBytes": 14092836,
"heapUsedBytes": 72342524,
"domNodes": -262,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 89.84900000000002,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.3899999999967,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.3670000000001,
"heapDeltaBytes": 3822400,
"heapUsedBytes": 64248716,
"domNodes": -265,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 89.253,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2038.4250000000748,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.8530000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.265,
"heapDeltaBytes": 4349516,
"heapUsedBytes": 64557200,
"domNodes": -266,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 80.47500000000001,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.0130000000263,
"styleRecalcs": 50,
"styleRecalcDurationMs": 11.251000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.515,
"heapDeltaBytes": 8856188,
"heapUsedBytes": 57416196,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 117.16800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 533.6449999999786,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.101000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.734,
"heapDeltaBytes": 9010440,
"heapUsedBytes": 57772520,
"domNodes": 16,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 121.529,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 568.4270000000424,
"styleRecalcs": 49,
"styleRecalcDurationMs": 13.597999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.19800000000004,
"heapDeltaBytes": 9016788,
"heapUsedBytes": 57731188,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 125.777,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2004.9619999999777,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.92600000000004,
"heapDeltaBytes": 22491900,
"heapUsedBytes": 71528472,
"domNodes": 19,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 13.952999999999992,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.9299999999685,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.941999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.614,
"heapDeltaBytes": 22539736,
"heapUsedBytes": 71260768,
"domNodes": 18,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 13.605,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.9940000000106,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.526999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.897,
"heapDeltaBytes": 22463368,
"heapUsedBytes": 72246864,
"domNodes": 18,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 13.536000000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9909999999827,
"styleRecalcs": 62,
"styleRecalcDurationMs": 32.397000000000006,
"layouts": 16,
"layoutDurationMs": 4.774000000000001,
"taskDurationMs": 595.2950000000001,
"heapDeltaBytes": 13818392,
"heapUsedBytes": 62455448,
"domNodes": 59,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 76.256,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1696.5659999999616,
"styleRecalcs": 63,
"styleRecalcDurationMs": 33.963,
"layouts": 16,
"layoutDurationMs": 4.375,
"taskDurationMs": 613.504,
"heapDeltaBytes": 13795988,
"heapUsedBytes": 62618344,
"domNodes": 60,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 77.89299999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.6059999999989,
"styleRecalcs": 62,
"styleRecalcDurationMs": 34.348000000000006,
"layouts": 16,
"layoutDurationMs": 4.345,
"taskDurationMs": 660.529,
"heapDeltaBytes": 1075728,
"heapUsedBytes": 49750680,
"domNodes": -264,
"jsHeapTotalBytes": 15593472,
"scriptDurationMs": 79.739,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8461.795000000053,
"styleRecalcs": 248,
"styleRecalcDurationMs": 59.276,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3954.033,
"heapDeltaBytes": 23778008,
"heapUsedBytes": 82336764,
"domNodes": -260,
"jsHeapTotalBytes": 3117056,
"scriptDurationMs": 1286.978,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8138.547000000017,
"styleRecalcs": 250,
"styleRecalcDurationMs": 57.705999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3601.899,
"heapDeltaBytes": 11219800,
"heapUsedBytes": 69246764,
"domNodes": -259,
"jsHeapTotalBytes": 2854912,
"scriptDurationMs": 1187.981,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8193.589000000087,
"styleRecalcs": 249,
"styleRecalcDurationMs": 55.536,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3631.8579999999997,
"heapDeltaBytes": 10697752,
"heapUsedBytes": 68921404,
"domNodes": -261,
"jsHeapTotalBytes": 7835648,
"scriptDurationMs": 1198.9460000000001,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13190.618000000086,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13179.346999999998,
"heapDeltaBytes": -28667252,
"heapUsedBytes": 186322068,
"domNodes": -8331,
"jsHeapTotalBytes": 26275840,
"scriptDurationMs": 612.128,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13167.448000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13154.034,
"heapDeltaBytes": -35343440,
"heapUsedBytes": 171368788,
"domNodes": -8331,
"jsHeapTotalBytes": 23916544,
"scriptDurationMs": 598.4710000000001,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12959.324000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12946.203000000001,
"heapDeltaBytes": -44720956,
"heapUsedBytes": 171374124,
"domNodes": -8331,
"jsHeapTotalBytes": 23916544,
"scriptDurationMs": 586.015,
"eventListeners": -16464,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15577.05400000009,
"styleRecalcs": 81,
"styleRecalcDurationMs": 19.504999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15557.485,
"heapDeltaBytes": -66286468,
"heapUsedBytes": 153448960,
"domNodes": -8335,
"jsHeapTotalBytes": -2297856,
"scriptDurationMs": 842.741,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15285.175999999978,
"styleRecalcs": 72,
"styleRecalcDurationMs": 19.15800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15263.953,
"heapDeltaBytes": -43585964,
"heapUsedBytes": 164487392,
"domNodes": -8331,
"jsHeapTotalBytes": 1634304,
"scriptDurationMs": 891.231,
"eventListeners": -16458,
"totalBlockingTimeMs": 2,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15498.57899999995,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.040000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15470.775999999998,
"heapDeltaBytes": -18129280,
"heapUsedBytes": 180770276,
"domNodes": -8331,
"jsHeapTotalBytes": -4481024,
"scriptDurationMs": 904.2189999999999,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 458.0359999999928,
"styleRecalcs": 19,
"styleRecalcDurationMs": 24.776,
"layouts": 5,
"layoutDurationMs": 1.5220000000000002,
"taskDurationMs": 131.299,
"heapDeltaBytes": 5364708,
"heapUsedBytes": 56661496,
"domNodes": 172,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 23.595,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 127.59199999993598,
"styleRecalcs": 13,
"styleRecalcDurationMs": 19.438999999999997,
"layouts": 5,
"layoutDurationMs": 1.4840000000000002,
"taskDurationMs": 96.66499999999998,
"heapDeltaBytes": 3487468,
"heapUsedBytes": 53419060,
"domNodes": 148,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 21.884,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 463.1460000000516,
"styleRecalcs": 17,
"styleRecalcDurationMs": 24.255000000000003,
"layouts": 5,
"layoutDurationMs": 1.4229999999999998,
"taskDurationMs": 115.37800000000001,
"heapDeltaBytes": 5074252,
"heapUsedBytes": 55009288,
"domNodes": 155,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 25.094,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
}
]
}🎭 Playwright: ❌ 1879 passed, 5 failed · 3 flaky❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.67 MB gzip 🔴 +570 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.4 MB (baseline 1.4 MB) • 🔴 +85 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 13 added / 13 removed / 4 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 8 unchanged Data & Services — 3.58 MB (baseline 3.58 MB) • 🔴 +1.46 kBStores, services, APIs, and repositories
Status: 14 added / 14 removed / 3 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 17 added / 17 removed / 19 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.3 MB (baseline 16.3 MB) • ⚪ 0 BBundles that do not match a named category
Status: 70 added / 70 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-01T10:26:42.327Z",
"gitSha": "0349d11fd8f28745386bd752484aae8f2b2c94f1",
"branch": "cross-dispatch/issue-11154",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.5479999999725,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.377000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.38000000000005,
"heapDeltaBytes": 1291948,
"heapUsedBytes": 63692504,
"domNodes": 14,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 10.162999999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.1700000000365,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.081999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.995,
"heapDeltaBytes": 1378956,
"heapUsedBytes": 63893684,
"domNodes": 16,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 10.818999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2145.9750000000213,
"styleRecalcs": 81,
"styleRecalcDurationMs": 47.874,
"layouts": 14,
"layoutDurationMs": 5.191999999999999,
"taskDurationMs": 1119.925,
"heapDeltaBytes": -366524,
"heapUsedBytes": 62479336,
"domNodes": 65,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 237.974,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1943.0710000000317,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.425,
"layouts": 14,
"layoutDurationMs": 4.6370000000000005,
"taskDurationMs": 986.8109999999999,
"heapDeltaBytes": -855184,
"heapUsedBytes": 62266036,
"domNodes": 63,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 213.733,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.9379999999765,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.676000000000002,
"layouts": 6,
"layoutDurationMs": 1.2029999999999998,
"taskDurationMs": 395.34499999999997,
"heapDeltaBytes": 4379100,
"heapUsedBytes": 67057964,
"domNodes": 78,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 12.458,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1757.257999999979,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.953000000000003,
"layouts": 6,
"layoutDurationMs": 1.413,
"taskDurationMs": 472.487,
"heapDeltaBytes": 3206092,
"heapUsedBytes": 67162572,
"domNodes": 77,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 16.459999999999994,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 741.4200000000051,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.404000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 527.2529999999999,
"heapDeltaBytes": 18132280,
"heapUsedBytes": 82881584,
"domNodes": 16,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 181.597,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 726.079000000027,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.466000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.50600000000003,
"heapDeltaBytes": 18536476,
"heapUsedBytes": 81109436,
"domNodes": 20,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 168.709,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2020.7560000000058,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 645.5699999999998,
"heapDeltaBytes": 364600,
"heapUsedBytes": 92346360,
"domNodes": 18,
"jsHeapTotalBytes": 1871872,
"scriptDurationMs": 37.945,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2016.6110000000117,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.861000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 757.054,
"heapDeltaBytes": 24897352,
"heapUsedBytes": 99299272,
"domNodes": 10,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 37.232,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2289.9949999999762,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1671.4729999999997,
"heapDeltaBytes": -1986888,
"heapUsedBytes": 91190192,
"domNodes": 12,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 793.1840000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2481.988000000001,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.840999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.6560000000002,
"heapDeltaBytes": -6534056,
"heapUsedBytes": 86594024,
"domNodes": 6,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 811.19,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3729.015000000004,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.807000000000004,
"layouts": 60,
"layoutDurationMs": 14.381,
"taskDurationMs": 1836.8609999999999,
"heapDeltaBytes": -14569020,
"heapUsedBytes": 78965892,
"domNodes": 8,
"jsHeapTotalBytes": 2920448,
"scriptDurationMs": 799.957,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3961.3950000000386,
"styleRecalcs": 63,
"styleRecalcDurationMs": 15.141999999999996,
"layouts": 60,
"layoutDurationMs": 14.552000000000001,
"taskDurationMs": 1952.7740000000001,
"heapDeltaBytes": 11001144,
"heapUsedBytes": 83863884,
"domNodes": 8,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 855.297,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3137.593000000038,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.973000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2056.9300000000003,
"heapDeltaBytes": -3571336,
"heapUsedBytes": 74511972,
"domNodes": 6,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 990.6400000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3125.195000000076,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.654000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2132.288,
"heapDeltaBytes": 22327928,
"heapUsedBytes": 95684464,
"domNodes": 4,
"jsHeapTotalBytes": 3039232,
"scriptDurationMs": 1047.78,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2007.427000000007,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.381999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.6149999999999,
"heapDeltaBytes": 603400,
"heapUsedBytes": 94091488,
"domNodes": 12,
"jsHeapTotalBytes": 2658304,
"scriptDurationMs": 33.753,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.4809999999607,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.762999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.5620000000001,
"heapDeltaBytes": 22147416,
"heapUsedBytes": 94765668,
"domNodes": 8,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 39.12199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 721.7449999999985,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.797999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.35799999999995,
"heapDeltaBytes": 16781724,
"heapUsedBytes": 80295252,
"domNodes": 18,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 210.952,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 756.8310000000338,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.437,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.609,
"heapDeltaBytes": 16118764,
"heapUsedBytes": 79409856,
"domNodes": 18,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 215.63199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.5429999999888,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.093,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.587,
"heapDeltaBytes": 1978160,
"heapUsedBytes": 65749184,
"domNodes": 18,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.866,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.926999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.785999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.71,
"heapDeltaBytes": 1758244,
"heapUsedBytes": 65750492,
"domNodes": 18,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 10.327,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.4300000000026,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.537000000000006,
"layouts": 18,
"layoutDurationMs": 5.717,
"taskDurationMs": 917.7439999999999,
"heapDeltaBytes": 22266088,
"heapUsedBytes": 85595780,
"domNodes": 66,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 170.64200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.5770000000966,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.446000000000005,
"layouts": 18,
"layoutDurationMs": 6.399,
"taskDurationMs": 903.89,
"heapDeltaBytes": 22163772,
"heapUsedBytes": 85637268,
"domNodes": 65,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 169.99900000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1517.2710000000507,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.644999999999996,
"layouts": 16,
"layoutDurationMs": 16.027,
"taskDurationMs": 1186.722,
"heapDeltaBytes": -830224,
"heapUsedBytes": 90493328,
"domNodes": 11886,
"jsHeapTotalBytes": 10543104,
"scriptDurationMs": 37.849,
"eventListeners": 770,
"totalBlockingTimeMs": 147,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8688.216000000011,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.858999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6160.7970000000005,
"heapDeltaBytes": -24022092,
"heapUsedBytes": 68134832,
"domNodes": -281,
"jsHeapTotalBytes": -45056,
"scriptDurationMs": 2696.1400000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9178.699999999935,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.089999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6322.218999999999,
"heapDeltaBytes": -6464424,
"heapUsedBytes": 85676900,
"domNodes": -282,
"jsHeapTotalBytes": 2244608,
"scriptDurationMs": 2737.842,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18539.704000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18424.652000000002,
"heapDeltaBytes": -22084940,
"heapUsedBytes": 172076648,
"domNodes": -1568,
"jsHeapTotalBytes": 9990144,
"scriptDurationMs": 309.32099999999997,
"eventListeners": -7451,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18697.74099999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18650.954999999994,
"heapDeltaBytes": 7047352,
"heapUsedBytes": 191031956,
"domNodes": -1568,
"jsHeapTotalBytes": 13758464,
"scriptDurationMs": 322.2,
"eventListeners": -7451,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23744.625000000044,
"styleRecalcs": 182,
"styleRecalcDurationMs": 26.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23651.111999999997,
"heapDeltaBytes": -13074736,
"heapUsedBytes": 170030772,
"domNodes": -1568,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 941.136,
"eventListeners": -7445,
"totalBlockingTimeMs": 268,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24263.635000000024,
"styleRecalcs": 180,
"styleRecalcDurationMs": 27.454000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24228.755,
"heapDeltaBytes": 1547052,
"heapUsedBytes": 192715528,
"domNodes": -6548,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 974.402,
"eventListeners": -7443,
"totalBlockingTimeMs": 364,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6659.842999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.17800000000003,
"layouts": 20,
"layoutDurationMs": 25.321999999999996,
"taskDurationMs": 6640.893,
"heapDeltaBytes": 15263768,
"heapUsedBytes": 203726060,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 123.54799999999999,
"eventListeners": 16,
"totalBlockingTimeMs": 500,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6878.441000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.75200000000004,
"layouts": 20,
"layoutDurationMs": 27.864000000000015,
"taskDurationMs": 6860.958000000001,
"heapDeltaBytes": 8333224,
"heapUsedBytes": 198386640,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 128.61399999999998,
"eventListeners": 18,
"totalBlockingTimeMs": 625,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 473.7039999999979,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.509,
"layouts": 3,
"layoutDurationMs": 1.55,
"taskDurationMs": 124.612,
"heapDeltaBytes": 5301480,
"heapUsedBytes": 67737140,
"domNodes": 151,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 12.423000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 497.67399999996087,
"styleRecalcs": 16,
"styleRecalcDurationMs": 25.576,
"layouts": 4,
"layoutDurationMs": 2.1380000000000003,
"taskDurationMs": 124.56600000000002,
"heapDeltaBytes": 5167624,
"heapUsedBytes": 67425232,
"domNodes": 144,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.427999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/lib/litegraph/src/LGraphCanvas.ts (1)
8877-8915:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve the panel insets when callers pass extra padding.
options.insetcurrently overwritesthis.fitViewInsets, so any custom inset passed by a caller drops the panel-safe offsets and can put the original bug back. Merge the two inset objects instead of replacing one with the other.Proposed fix
- this.ds.animateToBounds(bounds, setDirty, { - inset: this.fitViewInsets, - ...options - }) + this.ds.animateToBounds(bounds, setDirty, { + ...options, + inset: { ...this.fitViewInsets, ...(options.inset ?? {}) } + }) ... - this.ds.fitToBounds(bounds, { inset: this.fitViewInsets, ...options }) + this.ds.fitToBounds(bounds, { + ...options, + inset: { ...this.fitViewInsets, ...(options.inset ?? {}) } + })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/lib/litegraph/src/LGraphCanvas.ts` around lines 8877 - 8915, The fit/animate methods (animateToBounds, fitToBounds, fitViewToSelectionAnimated) currently pass options with inset: this.fitViewInsets and then spread ...options which allows options.inset to replace the panel-safe this.fitViewInsets entirely; change the call sites to merge the two inset objects instead (e.g. construct inset by shallow-merging this.fitViewInsets with options.inset so panel insets are preserved while allowing callers to override specific fields), and pass the merged inset in the ds.animateToBounds / ds.fitToBounds calls while still spreading the rest of options.src/lib/litegraph/src/DragAndScale.ts (1)
306-357:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winUse the inset-adjusted viewport throughout the animation path.
animateToBounds()still computesstartX2/startY2,targetX2/targetY2, and the interpolated scale fromcw/chinstead of the reduced usable area. With a large sidebar or asymmetric overlays, the animated fit can still follow the wrong path and briefly place nodes under the panel before it settles.🛠️ Proposed fix
- const startX2 = startX - cw / this.scale - const startY2 = startY - ch / this.scale + const startX2 = startX - availableWidth / this.scale + const startY2 = startY - availableHeight / this.scale @@ - const scaledWidth = cw / targetScale + const scaledWidth = availableWidth / targetScale const targetX2 = targetX - scaledWidth - const scaledHeight = ch / targetScale + const scaledHeight = availableHeight / targetScale const targetY2 = targetY - scaledHeight @@ - this.scale = Math.min(cw / currentWidth, ch / currentHeight) + this.scale = Math.min( + availableWidth / currentWidth, + availableHeight / currentHeight + )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/lib/litegraph/src/DragAndScale.ts` around lines 306 - 357, In animateToBounds (function animateToBounds / method resolveViewport usage), the animation uses cw/ch when computing startX2/startY2, targetX2/targetY2 and current scale; update those calculations to use the inset-adjusted availableWidth and availableHeight returned from resolveViewport (availableWidth, availableHeight) instead of cw and ch so the interpolated currentWidth/currentHeight and this.scale respect sidebars/overlays throughout the animation; specifically replace uses of cw/ch in startX2/startY2, scaledWidth/scaledHeight, and the final this.scale calculation so the entire animation path is based on the reduced usable viewport.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/LiteGraphCanvasSplitterOverlay.vue`:
- Around line 291-319: The watch that re-measures insets after layout changes
currently listens to [splitterRefreshKey, sidebarPanelVisible, focusMode] but
omits bottomPanelVisible, so toggling the bottom panel leaves fitViewInsets
stale; update the watch call in LiteGraphCanvasSplitterOverlay.vue to include
bottomPanelVisible in the dependency array (alongside splitterRefreshKey,
sidebarPanelVisible, and focusMode) so that nextTick(measureInsets) runs when
the bottom panel opens or closes, ensuring measureInsets and
emit('update:fitViewInsets', ...) are refreshed.
In `@src/lib/litegraph/src/DragAndScale.test.ts`:
- Around line 109-131: The test for DragAndScale.animateToBounds uses
vi.useFakeTimers() but restores timers with vi.useRealTimers() only at the end,
which can leak if an assertion throws; wrap the body of the test (everything
after vi.useFakeTimers()) in a try/finally and call vi.useRealTimers() in the
finally block so timers are always restored (update the test around
createDragAndScale, dsFit.fitToBounds, dsAnimate.animateToBounds,
vi.advanceTimersByTime and the expect assertions to be inside the try, and move
vi.useRealTimers() into the finally).
---
Outside diff comments:
In `@src/lib/litegraph/src/DragAndScale.ts`:
- Around line 306-357: In animateToBounds (function animateToBounds / method
resolveViewport usage), the animation uses cw/ch when computing startX2/startY2,
targetX2/targetY2 and current scale; update those calculations to use the
inset-adjusted availableWidth and availableHeight returned from resolveViewport
(availableWidth, availableHeight) instead of cw and ch so the interpolated
currentWidth/currentHeight and this.scale respect sidebars/overlays throughout
the animation; specifically replace uses of cw/ch in startX2/startY2,
scaledWidth/scaledHeight, and the final this.scale calculation so the entire
animation path is based on the reduced usable viewport.
In `@src/lib/litegraph/src/LGraphCanvas.ts`:
- Around line 8877-8915: The fit/animate methods (animateToBounds, fitToBounds,
fitViewToSelectionAnimated) currently pass options with inset:
this.fitViewInsets and then spread ...options which allows options.inset to
replace the panel-safe this.fitViewInsets entirely; change the call sites to
merge the two inset objects instead (e.g. construct inset by shallow-merging
this.fitViewInsets with options.inset so panel insets are preserved while
allowing callers to override specific fields), and pass the merged inset in the
ds.animateToBounds / ds.fitToBounds calls while still spreading the rest of
options.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5f1bb89a-0c07-4656-8500-7f3099936682
📒 Files selected for processing (6)
src/components/LiteGraphCanvasSplitterOverlay.vuesrc/components/graph/GraphCanvas.vuesrc/lib/litegraph/src/DragAndScale.test.tssrc/lib/litegraph/src/DragAndScale.tssrc/lib/litegraph/src/LGraphCanvas.tssrc/services/litegraphService.ts
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #11827 +/- ##
=========================================
Coverage 82.25% 82.25%
=========================================
Files 2017 2018 +1
Lines 116536 116562 +26
Branches 31039 33346 +2307
=========================================
+ Hits 95856 95883 +27
+ Misses 20505 20504 -1
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
54d66b6 to
62ba3c3
Compare
AustinMroz
left a comment
There was a problem hiding this comment.
I'm super excited to see this bug fixed.
Math wasn't quite right on my computer. Nodes would 'jump' at the start of a fit animation and wouldn't be centered after fit operations complete.
fitView() and fitViewToSelectionAnimated() used the full canvas element dimensions when calculating viewport bounds, ignoring overlay panels (sidebar, right side panel). This caused fitted content to be partially obscured by open panels. Add ViewportInsets support to DragAndScale.fitToBounds() and animateToBounds(). The insets reduce the effective viewport area and shift the centering calculation so content is centered within the unobscured region. getCanvasViewportInsets() computes insets by comparing the canvas element's bounding rect with the graph-canvas-panel (visible area). Fixes #11154
Use VueUse useElementBounding (passive ResizeObserver + scroll listener) behind a singleton, mirroring useCanvasPositionConversion. Call sites read a cached computed instead of querying the DOM per fitView invocation.
62ba3c3 to
4356227
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/composables/canvas/useCanvasViewportInsets.ts (1)
7-35: ⚡ Quick winConsider using
createSharedComposableinstead of module-scoped singleton.The current pattern with
let sharedworks but has downsides for HMR and testability. VueUse'screateSharedComposablehandles lifecycle automatically while achieving the same singleton behavior.♻️ Suggested refactor using createSharedComposable
import { useElementBounding } from '@vueuse/core' +import { createSharedComposable } from '@vueuse/core' import type { ComputedRef } from 'vue' import { computed } from 'vue' import type { ViewportInsets } from '@/lib/litegraph/src/DragAndScale' -let shared: ComputedRef<ViewportInsets> | null = null - /** * Reactive insets representing the area of `#graph-canvas` obscured by the * `.graph-canvas-panel` overlay (sidebar, right panel, etc.) on each side. * * Backed by VueUse's `useElementBounding`, which uses passive observers and * caches reads, so call sites pay no per-call layout cost. Singleton — the * underlying observers attach once for the app's lifetime. */ -export function useCanvasViewportInsets(): ComputedRef<ViewportInsets> { - if (shared) return shared - +export const useCanvasViewportInsets = createSharedComposable((): ComputedRef<ViewportInsets> => { const canvas = useElementBounding(() => document.getElementById('graph-canvas') ) const panel = useElementBounding(() => document.querySelector<HTMLElement>('.graph-canvas-panel') ) - shared = computed<ViewportInsets>(() => ({ + return computed<ViewportInsets>(() => ({ left: Math.max(0, panel.left.value - canvas.left.value), right: Math.max(0, canvas.right.value - panel.right.value), top: Math.max(0, panel.top.value - canvas.top.value), bottom: Math.max(0, canvas.bottom.value - panel.bottom.value) })) - - return shared -} +})Based on learnings: "In the ComfyUI frontend Vue/TypeScript codebase, when implementing singleton composables inside src/composables/**, prefer createSharedComposable from VueUse over module-scoped let variables."
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/composables/canvas/useCanvasViewportInsets.ts` around lines 7 - 35, Replace the module-scoped singleton pattern (the shared variable and early-return in useCanvasViewportInsets) with VueUse's createSharedComposable: wrap the composable body that creates canvas and panel via useElementBounding and the computed<ViewportInsets> result inside createSharedComposable and export the returned composable; remove the top-level let shared and its control flow so lifecycle and HMR/testability are handled by createSharedComposable while keeping the same useElementBounding and computed logic inside the new factory.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/composables/canvas/useCanvasViewportInsets.ts`:
- Around line 7-35: Replace the module-scoped singleton pattern (the shared
variable and early-return in useCanvasViewportInsets) with VueUse's
createSharedComposable: wrap the composable body that creates canvas and panel
via useElementBounding and the computed<ViewportInsets> result inside
createSharedComposable and export the returned composable; remove the top-level
let shared and its control flow so lifecycle and HMR/testability are handled by
createSharedComposable while keeping the same useElementBounding and computed
logic inside the new factory.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b0322128-f920-4349-b723-01dede7cf6c4
📒 Files selected for processing (6)
src/composables/canvas/useCanvasViewportInsets.test.tssrc/composables/canvas/useCanvasViewportInsets.tssrc/composables/useCoreCommands.tssrc/lib/litegraph/src/DragAndScale.test.tssrc/lib/litegraph/src/DragAndScale.tssrc/services/litegraphService.ts
✅ Files skipped from review due to trivial changes (2)
- src/composables/canvas/useCanvasViewportInsets.test.ts
- src/lib/litegraph/src/DragAndScale.test.ts
useElementBounding returns 0s for a missing target, which previously made the right/bottom insets balloon to the full canvas size. With new menu disabled (no .graph-canvas-panel), fitView produced a degenerate viewport and broke screenshot-stable workflow loads.
The inset shift sign was inverted: subtracting insetLeft/insetTop placed content at the obscured panel edge instead of centering it within the unobscured viewport region. Per convertOffsetToCanvas (canvas_px = (graph + offset) * scale), centering the bounds at insetLeft + cw/2 requires adding insetLeft/targetScale. Applied to both fitToBounds and animateToBounds. Addresses review feedback: #11827 (comment)
The animation edge points (startX2/targetX2) span the full canvas width (fullCw/fullCh), so the per-frame scale recovery must divide by fullCw/fullCh. Using the inset-reduced cw/ch landed the animation on a scale that did not match fitToBounds with the same insets. Addresses review feedback: #11827 (comment)
Replace the directional inset-position assertions (which encoded the inverted-sign behavior) with precise centering invariants: the bounds center must map to the center of the visible region for left/right/top insets. Add a fit/animate parity test that locks in the full-canvas scale recovery during animation. Addresses review feedback: #11827 (comment)
|
Addressing pass is blocked before code changes: the PR is currently |
Addresses review feedback: #11827 (comment)
Addresses review feedback: #11827 (comment)
Addresses review feedback: #11827 (comment)
Addresses review feedback: #11827 (comment)
Addresses review feedback: #11827 (comment)
Addresses review feedback: #11827 (comment)
Follow-up for review feedback: #11827 (comment)
|
@coderabbitai review |
Rate Limit Exceeded
|
|
Checked for merge conflicts against GitHub reports (Note: a literal per-commit No branch or commit was mutated. |
…g#11420) ## Summary - make CanvasViewport the authority for CSS size, backing-store size, and DPR - serialize visibility-sensitive camera work through an identity-aware CanvasScheduler - reject malformed saved camera state and stale graph/subgraph operations - use one visible viewport rectangle for immediate and animated panel-aware framing - migrate litegraph, minimap, layout, hit testing, and canvas-center consumers to the applied DPR - cover the real App Mode template-loading product path This incorporates the viewport migration from [merged PR Comfy-Org#11498](Comfy-Org#11498) and supersedes the remaining work in [PR Comfy-Org#11827](Comfy-Org#11827) and [PR Comfy-Org#19095](Comfy-Org#19095). Those two fallback PRs will be closed after this PR merges. The panel work is adapted to the existing `visibleCanvasViewport` contract rather than introducing a second inset API. Related to Comfy-Org#11154: Fit View now excludes the docked agent panel, but it still does not subtract the right-side parameters panel, so that issue stays open. ## Validation - application and browser-test typechecks passed - ADR validation, formatting, and changed-file lint passed - production build passed - pre-commit and pre-push formatting, lint, knip, and changed-file fallow gates passed - [exact-head CI](https://github.com/Comfy-Org/ComfyUI_frontend/commit/a558de2719aff8b5546cb25f2b2ad413420928a5/checks) passed with 105 successful checks, 19 expected skips, and no failures - Playwright product-path and 0.5x DPR regressions passed in the hosted browser matrix ## Architecture The lifecycle is measure, apply atomically to both canvases, then frame and draw. Scheduled operations carry both a semantic key and an ownership predicate, so stale loads cannot clear or replace current camera work. Panel-aware fitting consumes a usable rectangle in CSS pixels, shared by immediate and animated paths. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org>
|
Closing as superseded by PR #11420, which merged the panel-aware viewport work through the existing |
Description
fitView()andfitViewToSelectionAnimated()used the full canvas element dimensions when calculating viewport bounds, ignoring overlay panels (sidebar, right side panel). This caused fitted content to be partially obscured by open panels, especially noticeable on smaller browser widths.Changes
ViewportInsetsinterface toDragAndScale— represents CSS-pixel insets from each edge of the canvasfitToBounds()andanimateToBounds()to accept optionalinsets, reducing the effective viewport area and shifting the centering calculationgetCanvasViewportInsets()utility that computes insets by comparing#graph-canvasbounding rect with the.graph-canvas-panelvisible arealitegraphService.fitView()and theComfy.Canvas.FitViewcommandTests
Unit tests for
DragAndScale.fitToBounds()with/without insets (scale reduction, offset shifting)Unit tests for
getCanvasViewportInsets()DOM measurement logicFixes fix: fitView() does not account for open parameters panel width #11154