Repository navigation
test: add FormattedNumberStepper coverage and TopUpCredits dialog E2E tests - #11458
christian-byrne wants to merge 10 commits into
Conversation
|
Warning Review limit reachedNext included review available in 52 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (3)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdded Playwright support and coverage for ChangesTop-up credits testing
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to This PR adds component and end-to-end test coverage without introducing production behavior changes; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: Description checkExplanation The description includes the required Summary, Changes, and Review Focus sections. It gives specific test coverage, implementation details, edge cases, and test assumptions. The optional Screenshots section is not needed for this test-focused pull request. Full details: End-To-End Regression Coverage For FixesExplanation The pull request changes files under Full details: Adr Compliance For Entity/Litegraph ChangesExplanation The changed-file list contains only ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
⚔️ Resolve merge conflicts 💡
🧪 Generate unit tests (beta)
Comment |
📦 Bundle: 5.26 MB gzip 🔴 +20 BDetailsSummary
Category Glance App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.24 MB (baseline 1.24 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed Views & Navigation — 81.8 kB (baseline 81.8 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 2 unchanged Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 11 unchanged User & Accounts — 17.5 kB (baseline 17.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 2 unchanged Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 4 added / 4 removed UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 BReusable component library chunks
Status: 5 added / 5 removed / 9 unchanged Data & Services — 3.05 MB (baseline 3.05 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 4 unchanged Utilities & Hooks — 365 kB (baseline 365 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 18 unchanged Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 8.84 MB (baseline 8.84 MB) • ⚪ 0 BBundles that do not match a named category
Status: 57 added / 57 removed / 78 unchanged ⚡ Performance Report
No regressions detected. All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-05-04T05:06:37.611Z",
"gitSha": "957ffa81fb6f685a4cf4372e749bfbadbae2a5fe",
"branch": "glary/formatted-number-stepper-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2089.2029999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.057,
"heapDeltaBytes": 2326476,
"heapUsedBytes": 67912732,
"domNodes": 20,
"jsHeapTotalBytes": 19755008,
"scriptDurationMs": 21.006999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2016.909999999939,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.7459999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.55400000000003,
"heapDeltaBytes": 23697324,
"heapUsedBytes": 72048324,
"domNodes": 16,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 16.932,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2029.6899999999596,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.409,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.015,
"heapDeltaBytes": 23154356,
"heapUsedBytes": 72134860,
"domNodes": 24,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 22.795999999999996,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1780.7280000000674,
"styleRecalcs": 72,
"styleRecalcDurationMs": 36.974999999999994,
"layouts": 12,
"layoutDurationMs": 3.3759999999999994,
"taskDurationMs": 762.6460000000001,
"heapDeltaBytes": -3878124,
"heapUsedBytes": 44627860,
"domNodes": -266,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 120.477,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1848.4129999999368,
"styleRecalcs": 73,
"styleRecalcDurationMs": 43.698,
"layouts": 12,
"layoutDurationMs": 3.615,
"taskDurationMs": 808.8779999999999,
"heapDeltaBytes": -700560,
"heapUsedBytes": 48034860,
"domNodes": -265,
"jsHeapTotalBytes": 16642048,
"scriptDurationMs": 133.10899999999998,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1964.913000000024,
"styleRecalcs": 80,
"styleRecalcDurationMs": 49.401,
"layouts": 12,
"layoutDurationMs": 3.4579999999999997,
"taskDurationMs": 891.855,
"heapDeltaBytes": 18402416,
"heapUsedBytes": 67362744,
"domNodes": 65,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 130.303,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.2320000000618,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.257,
"layouts": 6,
"layoutDurationMs": 0.6640000000000001,
"taskDurationMs": 295.283,
"heapDeltaBytes": 5049496,
"heapUsedBytes": 70978952,
"domNodes": 76,
"jsHeapTotalBytes": 19492864,
"scriptDurationMs": 16.803999999999995,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.2660000000005,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.755999999999997,
"layouts": 6,
"layoutDurationMs": 0.561,
"taskDurationMs": 281.186,
"heapDeltaBytes": 179444,
"heapUsedBytes": 48828396,
"domNodes": 78,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 16.889999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.84400000008,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.488,
"layouts": 6,
"layoutDurationMs": 0.6679999999999999,
"taskDurationMs": 275.245,
"heapDeltaBytes": 1524,
"heapUsedBytes": 49299076,
"domNodes": 76,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 16.658999999999992,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 535.9409999999798,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.285,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.811,
"heapDeltaBytes": 9754316,
"heapUsedBytes": 58724904,
"domNodes": 23,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 64.191,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 551.6810000000305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.03499999999997,
"heapDeltaBytes": 9126928,
"heapUsedBytes": 57470616,
"domNodes": 16,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 59.31,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 520.8030000000008,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.255,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.199,
"heapDeltaBytes": 8512048,
"heapUsedBytes": 57108316,
"domNodes": 20,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 57.072,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2020.1059999999416,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.349000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.01,
"heapDeltaBytes": 10548056,
"heapUsedBytes": 68617404,
"domNodes": -262,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 83.697,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.7080000000224,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.19199999999995,
"heapDeltaBytes": 15724740,
"heapUsedBytes": 75204056,
"domNodes": -260,
"jsHeapTotalBytes": 3756032,
"scriptDurationMs": 84.274,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2030.5290000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.346000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.845,
"heapDeltaBytes": 9735596,
"heapUsedBytes": 68012504,
"domNodes": -263,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 88.628,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2128.125000000068,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.447,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1040.4609999999998,
"heapDeltaBytes": -5794968,
"heapUsedBytes": 53417820,
"domNodes": -262,
"jsHeapTotalBytes": 6057984,
"scriptDurationMs": 385.042,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2127.9990000000453,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1051.024,
"heapDeltaBytes": 7855016,
"heapUsedBytes": 67638824,
"domNodes": -263,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 388.424,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2171.9590000000153,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.194,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1083.461,
"heapDeltaBytes": 23792580,
"heapUsedBytes": 82686984,
"domNodes": -262,
"jsHeapTotalBytes": 6524928,
"scriptDurationMs": 402.632,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3151.361999999949,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.291,
"layouts": 60,
"layoutDurationMs": 6.862000000000001,
"taskDurationMs": 1279.538,
"heapDeltaBytes": -8814044,
"heapUsedBytes": 53074688,
"domNodes": -265,
"jsHeapTotalBytes": 4804608,
"scriptDurationMs": 467.119,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3084.443999999962,
"styleRecalcs": 65,
"styleRecalcDurationMs": 17.203000000000003,
"layouts": 60,
"layoutDurationMs": 7.005000000000001,
"taskDurationMs": 1257.1650000000002,
"heapDeltaBytes": -6768916,
"heapUsedBytes": 54101180,
"domNodes": -268,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 471.621,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3126.8079999999827,
"styleRecalcs": 66,
"styleRecalcDurationMs": 18.624,
"layouts": 60,
"layoutDurationMs": 6.96,
"taskDurationMs": 1289.704,
"heapDeltaBytes": 8759708,
"heapUsedBytes": 69318592,
"domNodes": -264,
"jsHeapTotalBytes": 4747264,
"scriptDurationMs": 479.763,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2033.8900000000422,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.525999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.73999999999995,
"heapDeltaBytes": 6160024,
"heapUsedBytes": 66526664,
"domNodes": -266,
"jsHeapTotalBytes": 552960,
"scriptDurationMs": 84.571,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.6139999999423,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.389000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 531.1360000000001,
"heapDeltaBytes": 16678872,
"heapUsedBytes": 78036708,
"domNodes": -264,
"jsHeapTotalBytes": 4018176,
"scriptDurationMs": 87.293,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2025.350000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.560000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.45499999999987,
"heapDeltaBytes": 2010656,
"heapUsedBytes": 62681020,
"domNodes": -266,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 84.91399999999999,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.9649999999383,
"styleRecalcs": 47,
"styleRecalcDurationMs": 12.126999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.66900000000004,
"heapDeltaBytes": 9192484,
"heapUsedBytes": 57795756,
"domNodes": 20,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 121.201,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.3119999999662,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.518999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.95300000000003,
"heapDeltaBytes": 9115868,
"heapUsedBytes": 57856012,
"domNodes": 18,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 115.758,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 535.329000000047,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.846,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.43199999999996,
"heapDeltaBytes": 8799464,
"heapUsedBytes": 57441828,
"domNodes": 16,
"jsHeapTotalBytes": 15466496,
"scriptDurationMs": 117.619,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2013.90600000002,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.741000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.575,
"heapDeltaBytes": 23005676,
"heapUsedBytes": 70981716,
"domNodes": 20,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 17.549999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1996.3089999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.794,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.23100000000005,
"heapDeltaBytes": 22408196,
"heapUsedBytes": 70447460,
"domNodes": 20,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 16.944999999999997,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.2649999999421,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.089,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.41200000000003,
"heapDeltaBytes": 23324336,
"heapUsedBytes": 72854892,
"domNodes": 21,
"jsHeapTotalBytes": 14417920,
"scriptDurationMs": 16.114000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.3010000000058,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.23599999999999,
"layouts": 16,
"layoutDurationMs": 4.033,
"taskDurationMs": 696.995,
"heapDeltaBytes": -3575308,
"heapUsedBytes": 45077256,
"domNodes": -263,
"jsHeapTotalBytes": 14544896,
"scriptDurationMs": 88.146,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1673.4820000000354,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.949999999999996,
"layouts": 16,
"layoutDurationMs": 4.1049999999999995,
"taskDurationMs": 634.262,
"heapDeltaBytes": 14121460,
"heapUsedBytes": 62724468,
"domNodes": 60,
"jsHeapTotalBytes": 15204352,
"scriptDurationMs": 91.06599999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1703.2110000000102,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.731,
"layouts": 16,
"layoutDurationMs": 4.002,
"taskDurationMs": 682.965,
"heapDeltaBytes": -5497516,
"heapUsedBytes": 43164484,
"domNodes": -262,
"jsHeapTotalBytes": 15331328,
"scriptDurationMs": 88.332,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8159.064999999941,
"styleRecalcs": 250,
"styleRecalcDurationMs": 49.829,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3547.822,
"heapDeltaBytes": 12972452,
"heapUsedBytes": 69881192,
"domNodes": -262,
"jsHeapTotalBytes": 6787072,
"scriptDurationMs": 1227.4209999999998,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8169.266999999991,
"styleRecalcs": 251,
"styleRecalcDurationMs": 52.094,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3586.213,
"heapDeltaBytes": 13675896,
"heapUsedBytes": 70421520,
"domNodes": -257,
"jsHeapTotalBytes": 6000640,
"scriptDurationMs": 1238.1449999999998,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8142.56899999998,
"styleRecalcs": 249,
"styleRecalcDurationMs": 50.39099999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3560.753,
"heapDeltaBytes": 11406168,
"heapUsedBytes": 69891708,
"domNodes": -262,
"jsHeapTotalBytes": 6262784,
"scriptDurationMs": 1226.0570000000002,
"eventListeners": -113,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11655.529000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11645.558,
"heapDeltaBytes": -29551716,
"heapUsedBytes": 174415224,
"domNodes": -8335,
"jsHeapTotalBytes": 27848704,
"scriptDurationMs": 583.606,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11544.313999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11532.567000000001,
"heapDeltaBytes": -20041748,
"heapUsedBytes": 171992652,
"domNodes": -8331,
"jsHeapTotalBytes": 24702976,
"scriptDurationMs": 583.3629999999999,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11514.932000000044,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11503.176000000001,
"heapDeltaBytes": -22774276,
"heapUsedBytes": 173182924,
"domNodes": -8331,
"jsHeapTotalBytes": 24702976,
"scriptDurationMs": 600.5690000000001,
"eventListeners": -16465,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14027.550999999903,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.012999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14006.027000000002,
"heapDeltaBytes": -54262684,
"heapUsedBytes": 153619672,
"domNodes": -8331,
"jsHeapTotalBytes": -2035712,
"scriptDurationMs": 875.258,
"eventListeners": -16488,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14069.536999999968,
"styleRecalcs": 64,
"styleRecalcDurationMs": 15.435000000000032,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14048.507000000001,
"heapDeltaBytes": -32961992,
"heapUsedBytes": 167442124,
"domNodes": -8331,
"jsHeapTotalBytes": 25227264,
"scriptDurationMs": 889.387,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14480.958999999984,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.188000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14460.052,
"heapDeltaBytes": -33211628,
"heapUsedBytes": 174989452,
"domNodes": -8329,
"jsHeapTotalBytes": -1859584,
"scriptDurationMs": 880.4,
"eventListeners": -16490,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 467.2140000000127,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.046,
"layouts": 5,
"layoutDurationMs": 1.4040000000000001,
"taskDurationMs": 133.578,
"heapDeltaBytes": 5406576,
"heapUsedBytes": 55097140,
"domNodes": 168,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.444999999999997,
"eventListeners": 69,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 111.47500000004129,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.086999999999996,
"layouts": 4,
"layoutDurationMs": 1.365,
"taskDurationMs": 81.89399999999999,
"heapDeltaBytes": 3075156,
"heapUsedBytes": 54303016,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 14.799,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 138.12700000016775,
"styleRecalcs": 12,
"styleRecalcDurationMs": 22.109,
"layouts": 5,
"layoutDurationMs": 1.616,
"taskDurationMs": 108.91700000000002,
"heapDeltaBytes": 3554524,
"heapUsedBytes": 54799236,
"domNodes": 148,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 26.33,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1894 passed, 9 failed❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.68 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.74 kB (baseline 3.74 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.42 MB (baseline 1.42 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.59 MB (baseline 3.59 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 295 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-02T14:53:46.287Z",
"gitSha": "c52b7a74fb8b3dd45dbc0b15f98aaa975c85f09f",
"branch": "glary/formatted-number-stepper-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2055.572999999981,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.211999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.88400000000007,
"heapDeltaBytes": -5023500,
"heapUsedBytes": 63715236,
"domNodes": -280,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.433,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2037.5830000000406,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.252999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.56300000000005,
"heapDeltaBytes": 1008760,
"heapUsedBytes": 71441140,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.218000000000002,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1707.8939999999534,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.481000000000005,
"layouts": 14,
"layoutDurationMs": 4.2909999999999995,
"taskDurationMs": 716.191,
"heapDeltaBytes": -8268988,
"heapUsedBytes": 61786380,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 117.488,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.8990000000558,
"styleRecalcs": 76,
"styleRecalcDurationMs": 31.82,
"layouts": 14,
"layoutDurationMs": 4.159000000000001,
"taskDurationMs": 766.1340000000001,
"heapDeltaBytes": 1152160,
"heapUsedBytes": 70728312,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 125.89500000000001,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.648999999978,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.599,
"layouts": 6,
"layoutDurationMs": 0.99,
"taskDurationMs": 300.289,
"heapDeltaBytes": 5102300,
"heapUsedBytes": 75231748,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.337000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1670.0080000000526,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.709999999999999,
"layouts": 6,
"layoutDurationMs": 1.0270000000000001,
"taskDurationMs": 297.5,
"heapDeltaBytes": 5094052,
"heapUsedBytes": 75689288,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.008,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 533.5380000000214,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.046,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.09000000000003,
"heapDeltaBytes": -8065224,
"heapUsedBytes": 62697532,
"domNodes": 20,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 127.134,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 560.5940000000373,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 378.149,
"heapDeltaBytes": 18201016,
"heapUsedBytes": 87900848,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 128.65099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2020.6420000000094,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.549999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.82699999999994,
"heapDeltaBytes": -13480448,
"heapUsedBytes": 87366892,
"domNodes": -263,
"jsHeapTotalBytes": -1888256,
"scriptDurationMs": 29.119,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2032.703999999967,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.63,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.7010000000001,
"heapDeltaBytes": -13700336,
"heapUsedBytes": 87280764,
"domNodes": -266,
"jsHeapTotalBytes": -1888256,
"scriptDurationMs": 29.1,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2126.8360000000257,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.577,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1331.1580000000001,
"heapDeltaBytes": 21542816,
"heapUsedBytes": 87861340,
"domNodes": 6,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 638.7940000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2121.88900000001,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.609999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1311.2810000000002,
"heapDeltaBytes": 20386312,
"heapUsedBytes": 86386140,
"domNodes": 6,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 630.518,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3367.3329999999737,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.926000000000002,
"layouts": 60,
"layoutDurationMs": 12.373000000000003,
"taskDurationMs": 1487.086,
"heapDeltaBytes": 8121016,
"heapUsedBytes": 75199824,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 647.81,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3240.6890000000885,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.875999999999998,
"layouts": 60,
"layoutDurationMs": 12.155,
"taskDurationMs": 1442.281,
"heapDeltaBytes": 8792688,
"heapUsedBytes": 75877708,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 622.938,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2472.541999999976,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.549999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1597.3359999999998,
"heapDeltaBytes": 17833012,
"heapUsedBytes": 84851304,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 767.601,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2549.046999999973,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.529999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1645.7860000000003,
"heapDeltaBytes": 19029652,
"heapUsedBytes": 87967452,
"domNodes": 4,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 782.1579999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2002.5939999999878,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.3309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.3439999999999,
"heapDeltaBytes": 21816956,
"heapUsedBytes": 88039324,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.11599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2013.9649999999847,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.4179999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.8170000000002,
"heapDeltaBytes": 21904792,
"heapUsedBytes": 87019240,
"domNodes": -267,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.743999999999993,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 529.1090000000054,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.280000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.67099999999994,
"heapDeltaBytes": 14908188,
"heapUsedBytes": 87466232,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.616,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 541.4349999999786,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.282,
"heapDeltaBytes": 14887088,
"heapUsedBytes": 87584136,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 116.818,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2019.894000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.537999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.869,
"heapDeltaBytes": -6314400,
"heapUsedBytes": 65988368,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.614000000000003,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.1220000000758,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.636,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.63200000000006,
"heapDeltaBytes": -12760908,
"heapUsedBytes": 60007644,
"domNodes": -293,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.068,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.9699999999611,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.787999999999997,
"layouts": 18,
"layoutDurationMs": 4.573,
"taskDurationMs": 697.1590000000001,
"heapDeltaBytes": 1264132,
"heapUsedBytes": 72638740,
"domNodes": -295,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 89.891,
"eventListeners": -226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1687.7279999999928,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.976000000000006,
"layouts": 18,
"layoutDurationMs": 4.739999999999999,
"taskDurationMs": 692.049,
"heapDeltaBytes": -11187200,
"heapUsedBytes": 61484808,
"domNodes": -291,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 89.969,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1101.3530000000173,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.029,
"layouts": 16,
"layoutDurationMs": 12.76,
"taskDurationMs": 804.8850000000001,
"heapDeltaBytes": 26466200,
"heapUsedBytes": 99341408,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 27.060000000000002,
"eventListeners": 2381,
"totalBlockingTimeMs": 95,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8462.696999999991,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.878,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4802.1359999999995,
"heapDeltaBytes": -15377220,
"heapUsedBytes": 84886320,
"domNodes": -267,
"jsHeapTotalBytes": -1400832,
"scriptDurationMs": 2086.395,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8534.401000000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.928000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4889.438999999999,
"heapDeltaBytes": 28052632,
"heapUsedBytes": 93081208,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2122.766,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14872.606000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14558.206000000002,
"heapDeltaBytes": -26108016,
"heapUsedBytes": 183713824,
"domNodes": -6548,
"jsHeapTotalBytes": -4399104,
"scriptDurationMs": 226.15199999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15398.863000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14817.652000000002,
"heapDeltaBytes": -25086172,
"heapUsedBytes": 176619596,
"domNodes": -6548,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 241.12100000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17613.563,
"styleRecalcs": 135,
"styleRecalcDurationMs": 15.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17336.544,
"heapDeltaBytes": -25290904,
"heapUsedBytes": 179876996,
"domNodes": -6548,
"jsHeapTotalBytes": 1851392,
"scriptDurationMs": 737.4,
"eventListeners": -7471,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17751.85799999997,
"styleRecalcs": 128,
"styleRecalcDurationMs": 15.571000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17409.48,
"heapDeltaBytes": -30578648,
"heapUsedBytes": 173328768,
"domNodes": -6548,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 753.096,
"eventListeners": -7471,
"totalBlockingTimeMs": 15,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5356.746999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.95399999999998,
"layouts": 20,
"layoutDurationMs": 22.783000000000012,
"taskDurationMs": 5315.2480000000005,
"heapDeltaBytes": -37460028,
"heapUsedBytes": 184524492,
"domNodes": -6548,
"jsHeapTotalBytes": 13717504,
"scriptDurationMs": 90.97600000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 217,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5343.289000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.18100000000001,
"layouts": 20,
"layoutDurationMs": 22.41699999999999,
"taskDurationMs": 5299.27,
"heapDeltaBytes": -32510208,
"heapUsedBytes": 174280344,
"domNodes": -6552,
"jsHeapTotalBytes": 7929856,
"scriptDurationMs": 105.88,
"eventListeners": -7473,
"totalBlockingTimeMs": 218,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 95.11799999995674,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.546,
"layouts": 2,
"layoutDurationMs": 1.2550000000000001,
"taskDurationMs": 70.894,
"heapDeltaBytes": 3161432,
"heapUsedBytes": 71419760,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.734999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 94.25799999996798,
"styleRecalcs": 6,
"styleRecalcDurationMs": 10.688,
"layouts": 2,
"layoutDurationMs": 0.5839999999999999,
"taskDurationMs": 62.121999999999986,
"heapDeltaBytes": 3085232,
"heapUsedBytes": 71035368,
"domNodes": 107,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.069000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts (1)
6-9: Reduce brittle magic-number assertions for credits conversion.The suite repeats hardcoded derived values from the conversion rate. Consider defining a single
CREDITS_PER_USDconstant + helper function and deriving expected strings from it to make future rate changes a one-line update.♻️ Suggested refactor
+const CREDITS_PER_USD = 211 + +function expectedCredits(usd: number): string { + return (usd * CREDITS_PER_USD).toLocaleString('en-US') +} + test('preset buttons update both steppers', async () => { await dialog.getPresetButton(25).click() await expect(dialog.payInput).toHaveValue('25') - await expect(dialog.creditsInput).toHaveValue('5,275') + await expect(dialog.creditsInput).toHaveValue(expectedCredits(25)) })Also applies to: 36-37, 44-45, 52-53, 60-61
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts` around lines 6 - 9, Replace the repeated hard-coded credit calculations in the topUpCreditsDialog.spec.ts tests with a single CREDITS_PER_USD constant and a small helper (e.g., creditsForUsd(usd: number): number and formatCredits(credits: number): string) and use these to derive every expected string/assertion (instead of literal numbers); update the assertions that reference derived credit strings (the ones checking $5/$50/$100 step options and the multiple assertions around them) to call creditsForUsd and formatCredits so a single change to CREDITS_PER_USD will update all expectations.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts`:
- Around line 14-25: Update the Playwright route mock responses to be statically
typed using the API response types: import CloudSubscriptionStatusResponse from
"@/platform/cloud/subscription/composables/useSubscription" and
BillingBalanceResponse from "@/platform/workspace/api/workspaceApi", then apply
TypeScript's "satisfies" to each mocked JSON payload returned in the
comfyPage.page.route handlers (the '**/cloud-subscription-status**' mock should
end with "satisfies CloudSubscriptionStatusResponse" and the
'**/customers/balance**' mock should end with "satisfies
BillingBalanceResponse") so the mocked objects are checked against the real API
contracts at compile time.
---
Nitpick comments:
In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts`:
- Around line 6-9: Replace the repeated hard-coded credit calculations in the
topUpCreditsDialog.spec.ts tests with a single CREDITS_PER_USD constant and a
small helper (e.g., creditsForUsd(usd: number): number and
formatCredits(credits: number): string) and use these to derive every expected
string/assertion (instead of literal numbers); update the assertions that
reference derived credit strings (the ones checking $5/$50/$100 step options and
the multiple assertions around them) to call creditsForUsd and formatCredits so
a single change to CREDITS_PER_USD will update all expectations.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bbf7fa54-535a-4621-967c-802445b62fed
📒 Files selected for processing (3)
browser_tests/fixtures/components/TopUpCreditsDialog.tsbrowser_tests/tests/dialogs/topUpCreditsDialog.spec.tssrc/components/ui/stepper/FormattedNumberStepper.test.ts
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #11458 +/- ##
==========================================
+ Coverage 80.76% 82.41% +1.65%
==========================================
Files 2440 2031 -409
Lines 124596 117353 -7243
Branches 31154 29422 -1732
==========================================
- Hits 100629 96722 -3907
+ Misses 23465 20453 -3012
+ Partials 502 178 -324
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts (2)
79-85: Harden the max-boundary test with a synced credits assertion.Line 79 currently checks warning + pay clamp only. Add a credits clamp assertion so desync bugs are caught too.
➕ Suggested assertion hardening
test('max ceiling warning appears when exceeding max', async () => { await dialog.payInput.fill('') await dialog.payInput.pressSequentially('99999') + await dialog.payInput.blur() await expect(dialog.ceilingWarning).toBeVisible() await expect(dialog.payInput).toHaveValue('10,000') + await expect(dialog.creditsInput).toHaveValue(expectedCredits(10_000)) })🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts` around lines 79 - 85, The test currently verifies the ceiling warning and that payInput clamps to '10,000' but misses asserting that the actual displayed/ synced credits also clamp; after the existing expectations for dialog.ceilingWarning and dialog.payInput, add a strict assertion that the UI credits display element (e.g., dialog.creditsLabel or the component used elsewhere to show remaining/added credits) equals the clamped value ('10,000') so the pay input and credits display stay in sync.
55-77: Add one credits-driven sync test to cover the reverse path.Line 55 through Line 77 validate pay → credits updates, but not credits → pay. A regression in the credits-model setter could slip through.
➕ Suggested test addition
+ test('typing in credits stepper updates pay', async () => { + const credits = String(50 * CREDITS_PER_USD) + + await dialog.creditsInput.fill('') + await dialog.creditsInput.pressSequentially(credits) + await dialog.creditsInput.blur() + + await expect(dialog.payInput).toHaveValue('50') + })Based on learnings: Applies to **/*.test.ts : Aim for behavioral coverage of critical and new features in tests
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts` around lines 55 - 77, Add a new test that verifies credits → pay synchronization: create a test (e.g., 'typing in credits updates pay') that fills dialog.creditsInput with a numeric value (use dialog.creditsInput.fill('...') and blur), then assert dialog.payInput has updated to the corresponding pay value; use the existing expectedCredits helper in reverse (or add a small helper like expectedPayFromCredits if none exists) to calculate the expected pay and assert equality. Target the same spec file and UI controls (dialog.creditsInput, dialog.payInput, dialog.getPresetButton) so the test covers the reverse path from credits to pay.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts`:
- Around line 79-85: The test currently verifies the ceiling warning and that
payInput clamps to '10,000' but misses asserting that the actual displayed/
synced credits also clamp; after the existing expectations for
dialog.ceilingWarning and dialog.payInput, add a strict assertion that the UI
credits display element (e.g., dialog.creditsLabel or the component used
elsewhere to show remaining/added credits) equals the clamped value ('10,000')
so the pay input and credits display stay in sync.
- Around line 55-77: Add a new test that verifies credits → pay synchronization:
create a test (e.g., 'typing in credits updates pay') that fills
dialog.creditsInput with a numeric value (use dialog.creditsInput.fill('...')
and blur), then assert dialog.payInput has updated to the corresponding pay
value; use the existing expectedCredits helper in reverse (or add a small helper
like expectedPayFromCredits if none exists) to calculate the expected pay and
assert equality. Target the same spec file and UI controls (dialog.creditsInput,
dialog.payInput, dialog.getPresetButton) so the test covers the reverse path
from credits to pay.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: e3f8c2a2-05ea-4dac-bc63-b8206ab0711d
📒 Files selected for processing (1)
browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts
There was a problem hiding this comment.
🧹 Nitpick comments (1)
browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts (1)
79-83: Deduplicate credits conversion logic in the reverse-sync test.This test reimplements the conversion inline. Reusing a helper keeps conversion assumptions centralized and reduces drift risk if formatting/conversion behavior changes.
♻️ Optional refactor
function expectedCredits(usd: number): string { return (usd * CREDITS_PER_USD).toLocaleString('en-US') } + +function expectedCreditsInput(usd: number): string { + return expectedCredits(usd).replaceAll(',', '') +} @@ test('typing in credits stepper updates pay', async () => { - const credits = String(50 * CREDITS_PER_USD) + const credits = expectedCreditsInput(50) await dialog.creditsInput.fill('') await dialog.creditsInput.pressSequentially(credits)As per coding guidelines: "Watch out for Code Smells and refactor to avoid them."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts` around lines 79 - 83, The test 'typing in credits stepper updates pay' duplicates conversion logic by computing String(50 * CREDITS_PER_USD); replace that inline math with the project's central credits conversion helper (find the helper used elsewhere where CREDITS_PER_USD is referenced) and use it to produce the display string passed to dialog.creditsInput.pressSequentially so the test relies on the same conversion/formatting function as production code.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts`:
- Around line 79-83: The test 'typing in credits stepper updates pay' duplicates
conversion logic by computing String(50 * CREDITS_PER_USD); replace that inline
math with the project's central credits conversion helper (find the helper used
elsewhere where CREDITS_PER_USD is referenced) and use it to produce the display
string passed to dialog.creditsInput.pressSequentially so the test relies on the
same conversion/formatting function as production code.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 11f29c30-2c31-47d3-9af8-3fa74b9a838f
📒 Files selected for processing (1)
browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts
1f576de to
8df5ac9
Compare
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
273a4d7 to
d7a2cc9
Compare
|
Rebased onto current Full context for agent readersThe sole conflict was in |
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
d7a2cc9 to
8822313
Compare
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
|
Rebased onto current Full context for agent readers
|
… tests Add comprehensive Vitest component tests (24 cases) covering all 12 previously untested functions in FormattedNumberStepper.vue through behavioral user interactions. Add E2E integration smoke test for the TopUpCredits dialog with page object extending BaseDialog.
…elper Address CodeRabbit review: type route.fulfill() payloads using CloudSubscriptionStatusResponse and GetCustomerBalanceResponse with satisfies, and replace hardcoded credit values with expectedCredits() helper using imported CREDITS_PER_USD constant.
…tion Add credits-driven sync test covering the creditsModel setter reverse path. Harden max-boundary test with blur + credits clamp assertion to catch pay/credits desync bugs.
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
Addresses review feedback: #11458 (comment)
8822313 to
f4ca3ee
Compare
|
Rebased onto current Full context for agent readers
|
|
Rebase complete at Fresh E2E is not green: the new TopUpCredits tests cannot find the Full context for agent readers
|
|
Closing in favor of the current conversion carrier frontend #11953, whose exact head |
PR Created by the Glary-Bot Agent
Summary
Add full test coverage for FormattedNumberStepper.vue (24 Vitest component tests) and an E2E integration smoke test for the TopUpCredits dialog.
Changes
src/components/ui/stepper/FormattedNumberStepper.test.ts— 24 behavioral Vitest tests covering all 12 previously untested functions (rendering, handleStep, handleInputChange, handleInputBlur, handleInputFocus, v-model reactivity, formatNumber) via @testing-library/vue user interactionsbrowser_tests/fixtures/components/TopUpCreditsDialog.ts— Page object extending BaseDialog with locators for pay/credits steppers, preset buttons, warnings, and buy button (variant-aware: matches both legacy and workspace CTAs)browser_tests/tests/dialogs/topUpCreditsDialog.spec.ts— 9 E2E tests covering preset selection, increment/decrement sync, manual input, min/max boundary warnings, buy button validation, and dialog close. Includes defensive billing API stubs for environment independence.Review Focus
open()callsshowTopUpCreditsDialog()with billing API routes stubbed (cloud-subscription-status,customers/balance) so the billing gate is satisfied in any distribution.CREDITS_PER_USD = 211— these will need updating if the rate changes.BaseDialog.closeButtonto target the content's custom X icon button instead of PrimeVue's hidden header close.┆Issue is synchronized with this Notion page by Unito