Skip to content

Fix missing model direct download UI state - #11353

Open
benceruleanlu wants to merge 5 commits into
mainfrom
bl/missing-model-download-contract
Open

benceruleanlu wants to merge 5 commits into
mainfrom
bl/missing-model-download-contract

Conversation

@benceruleanlu

@benceruleanlu benceruleanlu commented Apr 17, 2026 •

Copy link
Copy Markdown
Member

Summary

  • store Electron missing-model refs with desktop downloadId when available, falling back to URL for older desktop builds
  • normalize the new desktop { ok, download, error? } start result while preserving legacy boolean bridge behavior
  • resolve missing-model status by downloadId first so same-URL rows do not steal each other's progress
  • pass the stable identifier through model-library pause/resume/cancel controls

Context

Direct desktop missing-model downloads were starting, but the UI only had URL-level correlation for Electron downloads. URL is source metadata, not a safe lifecycle identity. This frontend bridge consumes the desktop downloadId contract from Comfy-Org/desktop#1694, keeps older desktop builds working through URL fallback, and binds each missing-model row to the exact download returned by desktop.

Notes

@github-actions

github-actions Bot commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1496 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1477 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 16 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@coderabbitai

coderabbitai Bot commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The changes refactor download status tracking throughout the missing model system by introducing new lifecycle-based download types, replacing importTaskIds with downloadRefs in the store, and updating components, composables, and download functions to recognize and handle new status values (running, paused, completed, failed, cancelled) instead of prior status names.

Changes

Cohort / File(s) Summary
Download Lifecycle Types
src/platform/downloads/types.ts, src/platform/missingModel/types.ts
Added DownloadLifecycleStatus union type with statuses created, running, paused, completed, failed, cancelled; introduced DownloadLifecycleState interface; created MissingModelDownloadRef discriminated union for tracking asset-import and electron-download references.
Store State Migration
src/platform/missingModel/missingModelStore.ts, src/stores/electronDownloadStore.ts
Replaced importTaskIds with downloadRefs in missing model store; refactored ElectronDownload to normalize desktop download state into DownloadLifecycleState with computed progress and mapped status values; added upsertDownload normalization path.
Download Tracking & Resolution
src/platform/missingModel/composables/useMissingModelInteractions.ts, src/platform/missingModel/missingModelDownload.ts
Updated download tracking to use downloadRefs instead of importTaskIds; changed downloadModel to return Promise<boolean> indicating start success; modified getDownloadStatus to resolve refs from either asset-import or electron-download stores; updated confirmation/cancellation flows to clear downloadRefs.
Component UI Updates
src/components/sidebar/tabs/modelLibrary/DownloadItem.vue, src/platform/missingModel/components/MissingModelStatusCard.vue, src/platform/missingModel/components/MissingModelRow.vue
Updated DownloadItem template conditionals to recognize running, paused, failed, cancelled statuses; extended MissingModelStatusCard to display paused and cancelled states; refactored MissingModelRow to make handleDownload async, store download refs on success, and delegate library selection through new handleLibraryModelSelect wrapper.
Test Coverage
src/platform/missingModel/missingModelRow.test.ts, src/platform/missingModel/composables/useMissingModelInteractions.test.ts, src/platform/missingModel/missingModelDownload.test.ts, src/stores/electronDownloadStore.test.ts
Added comprehensive test suites validating download ref storage and status resolution, electron download store initialization and normalization of desktop snapshots, and downloadModel behavior across desktop/non-desktop modes.
Documentation Update
src/stores/executionErrorStore.ts
Updated comment example from importTaskIds to download refs in error clearing documentation.

Sequence Diagram

sequenceDiagram
    participant User
    participant MissingModelRow as MissingModelRow<br/>(Component)
    participant downloadModel as downloadModel<br/>(Function)
    participant ElectronDL as ElectronDownload<br/>Store
    participant MissingModelStore as MissingModel<br/>Store
    participant getDownloadStatus as getDownloadStatus<br/>(Composable)
    participant StatusCard as MissingModelStatusCard<br/>(Component)

    User->>MissingModelRow: Click Download
    MissingModelRow->>downloadModel: await downloadModel(model, paths)
    alt Desktop Mode
        downloadModel->>ElectronDL: start({ url, savePath, filename })
        ElectronDL-->>downloadModel: Promise<boolean>
    else Non-Desktop
        downloadModel->>User: Trigger browser download
    end
    downloadModel-->>MissingModelRow: true/false

    alt Download Started Successfully
        MissingModelRow->>MissingModelStore: downloadRefs[key] = { kind, url/taskId }
        MissingModelRow->>MissingModelRow: handleComboSelect(modelName)
    end

    StatusCard->>getDownloadStatus: Resolve status for key
    alt Asset Import Ref
        getDownloadStatus->>ElectronDL: Search downloadList by taskId
    else Electron Download Ref
        getDownloadStatus->>ElectronDL: findByUrl(url)
    end
    ElectronDL-->>getDownloadStatus: { progress, status, error? }
    getDownloadStatus-->>StatusCard: DownloadStatus
    StatusCard->>User: Render status (running/paused/completed/failed/cancelled)
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 A carrot's download never waits,
With states that cycle through the gates,
Running, paused, then done at last,
The refs now track what downloads passed!
From electron to asset's store,
We hop to status—and much more! 🥕


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error, 1 warning, 1 inconclusive)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❌ Error PR uses 'Fix' language and modifies UI state logic, but lacks browser_tests changes or explanation for why e2e regression testing is impractical. Add Playwright regression test under browser_tests/ to verify missing-model download active state displays immediately, or explain in PR description why e2e testing is not practical.
Docstring Coverage ⚠️ Warning Docstring coverage is 11.76% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ❓ Inconclusive The pull request description provides a clear summary, context, and notes, but lacks critical sections from the template such as 'What', 'Breaking', 'Dependencies' details, and 'Review Focus' guidance. Expand the description to include the standard template structure: a 'Changes' section with 'What' and any breaking/dependency details, and a 'Review Focus' section highlighting critical design decisions or edge cases requiring attention.
✅ Passed checks (2 passed)
Check name Status Explanation
Adr Compliance For Entity/Litegraph Changes ✅ Passed PR modifies only missing-model UI, downloads, and stores; no changes to litegraph, ECS, or graph entities.
Title check ✅ Passed The title directly reflects the main change: fixing the missing model direct download UI state by tracking downloads through explicit refs.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bl/missing-model-download-contract

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 05/05/2026, 09:15:45 AM UTC

Links

@github-actions

github-actions Bot commented Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle: 5.26 MB gzip 🔴 +1.14 kB

Details

Summary

  • Raw size: 24.2 MB baseline 24.2 MB — 🔴 +6.41 kB
  • Gzip: 5.26 MB baseline 5.26 MB — 🔴 +1.14 kB
  • Brotli: 4.07 MB baseline 4.07 MB — 🔴 +1.32 kB
  • Bundles: 259 current • 259 baseline • 121 added / 121 removed

Category Glance
Graph Workspace 🔴 +4 kB (1.24 MB) · Data & Services 🔴 +2.15 kB (3.06 MB) · Other 🔴 +263 B (8.82 MB) · Vendor & Third-Party ⚪ 0 B (9.94 MB) · Panels & Settings ⚪ 0 B (489 kB) · Utilities & Hooks ⚪ 0 B (365 kB) · + 5 more

App Entry Points — 22.6 kB (baseline 22.6 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-ag5oTlSm.js (new) — 22.6 kB 🔴 +22.6 kB 🔴 +8.01 kB 🔴 +6.86 kB
assets/index-DIvgf7Tn.js (removed) 22.6 kB — 🟢 -22.6 kB 🟢 -8.01 kB 🟢 -6.89 kB

Status: 1 added / 1 removed

Graph Workspace — 1.24 MB (baseline 1.24 MB) • 🔴 +4 kB

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-BtLPa76l.js (new) — 1.24 MB 🔴 +1.24 MB 🔴 +265 kB 🔴 +200 kB
assets/GraphView-BdNxhvEQ.js (removed) 1.24 MB — 🟢 -1.24 MB 🟢 -265 kB 🟢 -199 kB

Status: 1 added / 1 removed

Views & Navigation — 82.3 kB (baseline 82.3 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-B4hThro8.js (removed) 19.6 kB — 🟢 -19.6 kB 🟢 -5.14 kB 🟢 -4.58 kB
assets/CloudSurveyView-DzIpXgBT.js (new) — 19.6 kB 🔴 +19.6 kB 🔴 +5.14 kB 🔴 +4.58 kB
assets/CloudLoginView-D8u6nIfM.js (new) — 12.4 kB 🔴 +12.4 kB 🔴 +3.5 kB 🔴 +3.1 kB
assets/CloudLoginView-DFgfNIKb.js (removed) 12.4 kB — 🟢 -12.4 kB 🟢 -3.51 kB 🟢 -3.1 kB
assets/CloudSignupView-Bg2ZJWOE.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.01 kB 🟢 -2.65 kB
assets/CloudSignupView-Cz_nh5-s.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3 kB 🔴 +2.65 kB
assets/UserCheckView-BzKo-QqP.js (removed) 9.07 kB — 🟢 -9.07 kB 🟢 -2.33 kB 🟢 -2.04 kB
assets/UserCheckView-HsOBCMZ1.js (new) — 9.07 kB 🔴 +9.07 kB 🔴 +2.33 kB 🔴 +2.04 kB
assets/CloudLayoutView-CFZDk7eg.js (removed) 7.73 kB — 🟢 -7.73 kB 🟢 -2.45 kB 🟢 -2.15 kB
assets/CloudLayoutView-DlsS6Q6p.js (new) — 7.73 kB 🔴 +7.73 kB 🔴 +2.45 kB 🔴 +2.14 kB
assets/CloudForgotPasswordView-BtbT0ZuJ.js (removed) 6.14 kB — 🟢 -6.14 kB 🟢 -2.19 kB 🟢 -1.93 kB
assets/CloudForgotPasswordView-CZER6Wsr.js (new) — 6.14 kB 🔴 +6.14 kB 🔴 +2.18 kB 🔴 +1.92 kB
assets/CloudAuthTimeoutView-C2uS9GQp.js (removed) 5.5 kB — 🟢 -5.5 kB 🟢 -2.01 kB 🟢 -1.78 kB
assets/CloudAuthTimeoutView-Dvy_Z9Q9.js (new) — 5.5 kB 🔴 +5.5 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/CloudSubscriptionRedirectView-CI7ox3mY.js (new) — 5.28 kB 🔴 +5.28 kB 🔴 +1.99 kB 🔴 +1.79 kB
assets/CloudSubscriptionRedirectView-DgVxruK4.js (removed) 5.28 kB — 🟢 -5.28 kB 🟢 -2 kB 🟢 -1.79 kB
assets/UserSelectView-Bb6HEOdS.js (new) — 4.73 kB 🔴 +4.73 kB 🔴 +1.75 kB 🔴 +1.55 kB
assets/UserSelectView-BqWXAVpL.js (removed) 4.73 kB — 🟢 -4.73 kB 🟢 -1.75 kB 🟢 -1.56 kB

Status: 9 added / 9 removed / 2 unchanged

Panels & Settings — 489 kB (baseline 489 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-DJrvmT6G.js (new) — 46.7 kB 🔴 +46.7 kB 🔴 +9.62 kB 🔴 +8.55 kB
assets/KeybindingPanel-wX3jo2cE.js (removed) 46.7 kB — 🟢 -46.7 kB 🟢 -9.63 kB 🟢 -8.56 kB
assets/SecretsPanel-BN3qiN13.js (removed) 22.9 kB — 🟢 -22.9 kB 🟢 -5.55 kB 🟢 -4.88 kB
assets/SecretsPanel-Dg1-8c88.js (new) — 22.9 kB 🔴 +22.9 kB 🔴 +5.54 kB 🔴 +4.87 kB
assets/LegacyCreditsPanel-DuL1Gfus.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -5.91 kB 🟢 -5.23 kB
assets/LegacyCreditsPanel-DXb5HdB1.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +5.91 kB 🔴 +5.21 kB
assets/SubscriptionPanel-B489sQGw.js (new) — 20 kB 🔴 +20 kB 🔴 +5.11 kB 🔴 +4.49 kB
assets/SubscriptionPanel-ChwSPd5X.js (removed) 20 kB — 🟢 -20 kB 🟢 -5.11 kB 🟢 -4.5 kB
assets/AboutPanel-CcNJXcQQ.js (removed) 12 kB — 🟢 -12 kB 🟢 -3.32 kB 🟢 -2.99 kB
assets/AboutPanel-CnXKpDIl.js (new) — 12 kB 🔴 +12 kB 🔴 +3.32 kB 🔴 +2.98 kB
assets/ExtensionPanel-BMDl6UEO.js (removed) 9.97 kB — 🟢 -9.97 kB 🟢 -2.91 kB 🟢 -2.57 kB
assets/ExtensionPanel-CnbdhwL4.js (new) — 9.97 kB 🔴 +9.97 kB 🔴 +2.91 kB 🔴 +2.58 kB
assets/ServerConfigPanel-CysV11oQ.js (removed) 7.05 kB — 🟢 -7.05 kB 🟢 -2.36 kB 🟢 -2.1 kB
assets/ServerConfigPanel-CZ_1PvuB.js (new) — 7.05 kB 🔴 +7.05 kB 🔴 +2.36 kB 🔴 +2.11 kB
assets/UserPanel-BaNQtt-U.js (removed) 6.75 kB — 🟢 -6.75 kB 🟢 -2.24 kB 🟢 -1.97 kB
assets/UserPanel-CSbqCWg-.js (new) — 6.75 kB 🔴 +6.75 kB 🔴 +2.24 kB 🔴 +1.96 kB
assets/cloudRemoteConfig-a_O0OS9Y.js (removed) 2.05 kB — 🟢 -2.05 kB 🟢 -986 B 🟢 -850 B
assets/cloudRemoteConfig-DYzwOwkQ.js (new) — 2.05 kB 🔴 +2.05 kB 🔴 +987 B 🔴 +852 B
assets/refreshRemoteConfig-C_JDoypJ.js (new) — 1.45 kB 🔴 +1.45 kB 🔴 +646 B 🔴 +558 B
assets/refreshRemoteConfig-DIQQr5H6.js (removed) 1.45 kB — 🟢 -1.45 kB 🟢 -650 B 🟢 -557 B

Status: 10 added / 10 removed / 11 unchanged

User & Accounts — 17.6 kB (baseline 17.6 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/auth-7ynMWo-r.js (new) — 3.65 kB 🔴 +3.65 kB 🔴 +1.29 kB 🔴 +1.11 kB
assets/auth-GOit0MOZ.js (removed) 3.65 kB — 🟢 -3.65 kB 🟢 -1.29 kB 🟢 -1.1 kB
assets/SignUpForm-Bk10yYSa.js (removed) 3.19 kB — 🟢 -3.19 kB 🟢 -1.29 kB 🟢 -1.15 kB
assets/SignUpForm-DkU-8lws.js (new) — 3.19 kB 🔴 +3.19 kB 🔴 +1.29 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-B6wBKFxe.js (new) — 2.9 kB 🔴 +2.9 kB 🔴 +1.3 kB 🔴 +1.15 kB
assets/UpdatePasswordContent-svUxigUy.js (removed) 2.9 kB — 🟢 -2.9 kB 🟢 -1.3 kB 🟢 -1.17 kB
assets/authStore-0uH86Ssq.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -568 B 🟢 -504 B
assets/authStore-D2eX-XyF.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +565 B 🔴 +506 B
assets/auth-bDOG1Ah5.js (removed) 348 B — 🟢 -348 B 🟢 -214 B 🟢 -187 B
assets/auth-Cc_5ZiAR.js (new) — 348 B 🔴 +348 B 🔴 +213 B 🔴 +186 B

Status: 5 added / 5 removed / 2 unchanged

Editors & Dialogs — 112 kB (baseline 112 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-B1Vl6uxR.js (removed) 85.8 kB — 🟢 -85.8 kB 🟢 -18.6 kB 🟢 -15.9 kB
assets/ComfyHubPublishDialog-IWqlqKHJ.js (new) — 85.8 kB 🔴 +85.8 kB 🔴 +18.6 kB 🔴 +15.9 kB
assets/useShareDialog-cPG9u779.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +5.78 kB 🔴 +5.12 kB
assets/useShareDialog-DkiuYaYv.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -5.78 kB 🟢 -5.12 kB
assets/ComfyHubPublishDialog-Blq14Ygg.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +624 B 🔴 +549 B
assets/ComfyHubPublishDialog-D_Prsqnm.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -626 B 🟢 -551 B
assets/useSubscriptionDialog-DLCSek08.js (removed) 1.17 kB — 🟢 -1.17 kB 🟢 -558 B 🟢 -483 B
assets/useSubscriptionDialog-DoObWvst.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +554 B 🔴 +483 B

Status: 4 added / 4 removed

UI Components — 62.9 kB (baseline 62.9 kB) • ⚪ 0 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyQueueButton-C9LFgEcb.js (removed) 13.5 kB — 🟢 -13.5 kB 🟢 -3.79 kB 🟢 -3.38 kB
assets/ComfyQueueButton-CskMWxw7.js (new) — 13.5 kB 🔴 +13.5 kB 🔴 +3.79 kB 🔴 +3.38 kB
assets/useTerminalTabs-BE3knQmB.js (removed) 11 kB — 🟢 -11 kB 🟢 -3.74 kB 🟢 -3.28 kB
assets/useTerminalTabs-COiKLqOH.js (new) — 11 kB 🔴 +11 kB 🔴 +3.73 kB 🔴 +3.28 kB
assets/SubscribeButton-DbVU-Nfg.js (removed) 2.42 kB — 🟢 -2.42 kB 🟢 -1.05 kB 🟢 -929 B
assets/SubscribeButton-YPUlcZvg.js (new) — 2.42 kB 🔴 +2.42 kB 🔴 +1.05 kB 🔴 +929 B
assets/cloudFeedbackTopbarButton-8yBfXpy7.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +940 B 🔴 +828 B
assets/cloudFeedbackTopbarButton-DlAiUJ5v.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -941 B 🟢 -830 B
assets/ComfyQueueButton-Ci2JD23V.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +590 B 🔴 +522 B
assets/ComfyQueueButton-CNfzQQq9.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -594 B 🟢 -523 B

Status: 5 added / 5 removed / 9 unchanged

Data & Services — 3.06 MB (baseline 3.05 MB) • 🔴 +2.15 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/dialogService-SUoobqQf.js (new) — 1.99 MB 🔴 +1.99 MB 🔴 +459 kB 🔴 +348 kB
assets/dialogService-DJ_YMBHX.js (removed) 1.99 MB — 🟢 -1.99 MB 🟢 -459 kB 🟢 -348 kB
assets/api-BnHcJhnJ.js (removed) 887 kB — 🟢 -887 kB 🟢 -212 kB 🟢 -167 kB
assets/api-fAfrv3a3.js (new) — 887 kB 🔴 +887 kB 🔴 +212 kB 🔴 +167 kB
assets/load3dService-D9H2TARf.js (new) — 116 kB 🔴 +116 kB 🔴 +25.3 kB 🔴 +21.5 kB
assets/load3dService-Xm85q_Fj.js (removed) 116 kB — 🟢 -116 kB 🟢 -25.3 kB 🟢 -21.5 kB
assets/workflowShareService-CawLfL8X.js (new) — 16.6 kB 🔴 +16.6 kB 🔴 +4.89 kB 🔴 +4.33 kB
assets/workflowShareService-CCwfPG0b.js (removed) 16.6 kB — 🟢 -16.6 kB 🟢 -4.89 kB 🟢 -4.34 kB
assets/keybindingService-BnK0zsp3.js (new) — 13.8 kB 🔴 +13.8 kB 🔴 +3.67 kB 🔴 +3.21 kB
assets/keybindingService-Bte0se1S.js (removed) 13.8 kB — 🟢 -13.8 kB 🟢 -3.67 kB 🟢 -3.22 kB
assets/releaseStore-D19teq55.js (new) — 8.12 kB 🔴 +8.12 kB 🔴 +2.28 kB 🔴 +2 kB
assets/releaseStore-zlQ3AJGL.js (removed) 8.12 kB — 🟢 -8.12 kB 🟢 -2.28 kB 🟢 -2 kB
assets/electronDownloadStore-BpkixvJt.js (new) — 3.83 kB 🔴 +3.83 kB 🔴 +1.27 kB 🔴 +1.14 kB
assets/userStore-BArDFgVX.js (removed) 2.24 kB — 🟢 -2.24 kB 🟢 -871 B 🟢 -762 B
assets/userStore-CYyt4Fcp.js (new) — 2.24 kB 🔴 +2.24 kB 🔴 +867 B 🔴 +757 B
assets/electronDownloadStore-Dj0YTIBO.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -734 B 🟢 -652 B
assets/audioService-6c9pV5EY.js (removed) 1.8 kB — 🟢 -1.8 kB 🟢 -878 B 🟢 -764 B
assets/audioService-CeanxRND.js (new) — 1.8 kB 🔴 +1.8 kB 🔴 +872 B 🔴 +761 B
assets/releaseStore-c8eWzWEs.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -560 B 🟢 -496 B
assets/releaseStore-CVarDOqM.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +559 B 🔴 +498 B
assets/workflowDraftStore-CHqubVS5.js (new) — 1.17 kB 🔴 +1.17 kB 🔴 +553 B 🔴 +492 B
assets/workflowDraftStore-DPB8wInQ.js (removed) 1.17 kB — 🟢 -1.17 kB 🟢 -557 B 🟢 -487 B
assets/dialogService-B0jcVl2Y.js (new) — 1.16 kB 🔴 +1.16 kB 🔴 +546 B 🔴 +484 B
assets/dialogService-DjsWAdzt.js (removed) 1.16 kB — 🟢 -1.16 kB 🟢 -548 B 🟢 -485 B
assets/settingStore-3IO99S3L.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +548 B 🔴 +485 B
assets/settingStore-wF0fM8VF.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -551 B 🟢 -483 B
assets/assetsStore-BvyDnQ3J.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +548 B 🔴 +485 B
assets/assetsStore-CbptCE8_.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -551 B 🟢 -484 B

Status: 14 added / 14 removed / 3 unchanged

Utilities & Hooks — 365 kB (baseline 365 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-Ck6WhgXY.js (removed) 233 kB — 🟢 -233 kB 🟢 -51.8 kB 🟢 -42.3 kB
assets/useConflictDetection-fAsTSDAy.js (new) — 233 kB 🔴 +233 kB 🔴 +51.8 kB 🔴 +42.2 kB
assets/useLoad3d-Dt_JG6k4.js (removed) 22.5 kB — 🟢 -22.5 kB 🟢 -5.18 kB 🟢 -4.58 kB
assets/useLoad3d-DzbTY2Bu.js (new) — 22.5 kB 🔴 +22.5 kB 🔴 +5.17 kB 🔴 +4.57 kB
assets/useLoad3dViewer-Ru7Qijz3.js (removed) 21 kB — 🟢 -21 kB 🟢 -4.92 kB 🟢 -4.32 kB
assets/useLoad3dViewer-W1hVBCGN.js (new) — 21 kB 🔴 +21 kB 🔴 +4.92 kB 🔴 +4.32 kB
assets/useFeatureFlags-BI9JUflm.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +1.8 kB 🔴 +1.52 kB
assets/useFeatureFlags-BigPvYTT.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -1.79 kB 🟢 -1.52 kB
assets/useCopyToClipboard-BFR94tEH.js (removed) 5.29 kB — 🟢 -5.29 kB 🟢 -1.86 kB 🟢 -1.57 kB
assets/useCopyToClipboard-Bs46Mhe8.js (new) — 5.29 kB 🔴 +5.29 kB 🔴 +1.86 kB 🔴 +1.57 kB
assets/useWorkspaceUI-BWcnAZim.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +980 B 🔴 +809 B
assets/useWorkspaceUI-CycnaWdH.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -981 B 🟢 -807 B
assets/subscriptionCheckoutUtil-Bat4lu9I.js (new) — 3.31 kB 🔴 +3.31 kB 🔴 +1.36 kB 🔴 +1.18 kB
assets/subscriptionCheckoutUtil-DOCCKfN-.js (removed) 3.31 kB — 🟢 -3.31 kB 🟢 -1.36 kB 🟢 -1.19 kB
assets/assetPreviewUtil-CXLj6r--.js (removed) 2.27 kB — 🟢 -2.27 kB 🟢 -958 B 🟢 -832 B
assets/assetPreviewUtil-mcUgP-c2.js (new) — 2.27 kB 🔴 +2.27 kB 🔴 +955 B 🔴 +834 B
assets/useUpstreamValue-C-11QMnV.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -806 B 🟢 -713 B
assets/useUpstreamValue-nvK1JRuH.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +803 B 🔴 +713 B
assets/useLoad3d-BL_K74i6.js (removed) 1.33 kB — 🟢 -1.33 kB 🟢 -618 B 🟢 -570 B
assets/useLoad3d-bql5Wjfh.js (new) — 1.33 kB 🔴 +1.33 kB 🔴 +618 B 🔴 +556 B
assets/useLoad3dViewer-BpyiauFI.js (new) — 1.27 kB 🔴 +1.27 kB 🔴 +585 B 🔴 +522 B
assets/useLoad3dViewer-DG6_3e2B.js (removed) 1.27 kB — 🟢 -1.27 kB 🟢 -586 B 🟢 -527 B
assets/useCurrentUser-B30vPe4m.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +549 B 🔴 +485 B
assets/useCurrentUser-DAGYFNyL.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -553 B 🟢 -483 B
assets/useWorkspaceSwitch-B7w0HScA.js (removed) 747 B — 🟢 -747 B 🟢 -385 B 🟢 -334 B
assets/useWorkspaceSwitch-GR0E7ozR.js (new) — 747 B 🔴 +747 B 🔴 +384 B 🔴 +329 B

Status: 13 added / 13 removed / 18 unchanged

Vendor & Third-Party — 9.94 MB (baseline 9.94 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 16 unchanged

Other — 8.82 MB (baseline 8.82 MB) • 🔴 +263 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-Bw9hOW8O.js (removed) 77.1 kB — 🟢 -77.1 kB 🟢 -20 kB 🟢 -17.1 kB
assets/core-KzrA95PZ.js (new) — 77.1 kB 🔴 +77.1 kB 🔴 +20 kB 🔴 +17.1 kB
assets/groupNode-D774Hedf.js (new) — 74.9 kB 🔴 +74.9 kB 🔴 +18.7 kB 🔴 +16.5 kB
assets/groupNode-l-3xzmyJ.js (removed) 74.9 kB — 🟢 -74.9 kB 🟢 -18.7 kB 🟢 -16.5 kB
assets/WidgetSelect-BZLnRSoA.js (new) — 67.4 kB 🔴 +67.4 kB 🔴 +14.6 kB 🔴 +12.7 kB
assets/WidgetSelect-CdDYPq_N.js (removed) 67.4 kB — 🟢 -67.4 kB 🟢 -14.6 kB 🟢 -12.7 kB
assets/SubscriptionRequiredDialogContentWorkspace-CHReUgtC.js (new) — 48.8 kB 🔴 +48.8 kB 🔴 +9.52 kB 🔴 +8.2 kB
assets/SubscriptionRequiredDialogContentWorkspace-Cva2e_eT.js (removed) 48.8 kB — 🟢 -48.8 kB 🟢 -9.53 kB 🟢 -8.19 kB
assets/Load3DControls-D5_kZOfi.js (removed) 46.1 kB — 🟢 -46.1 kB 🟢 -7.51 kB 🟢 -6.54 kB
assets/Load3DControls-DGaHDx92.js (new) — 46.1 kB 🔴 +46.1 kB 🔴 +7.51 kB 🔴 +6.55 kB
assets/WorkspacePanelContent-DjFFRztw.js (removed) 34.2 kB — 🟢 -34.2 kB 🟢 -7.41 kB 🟢 -6.56 kB
assets/WorkspacePanelContent-DxcFAd-H.js (new) — 34.2 kB 🔴 +34.2 kB 🔴 +7.41 kB 🔴 +6.56 kB
assets/WidgetPainter-CI_01qQX.js (removed) 34 kB — 🟢 -34 kB 🟢 -8.3 kB 🟢 -7.36 kB
assets/WidgetPainter-DCQFF8yE.js (new) — 34 kB 🔴 +34 kB 🔴 +8.3 kB 🔴 +7.39 kB
assets/Load3dViewerContent-DzGVtP9M.js (removed) 28 kB — 🟢 -28 kB 🟢 -5.85 kB 🟢 -5.08 kB
assets/Load3dViewerContent-Dzy83ooQ.js (new) — 28 kB 🔴 +28 kB 🔴 +5.85 kB 🔴 +5.09 kB
assets/SubscriptionRequiredDialogContent-BNrS1_ly.js (new) — 27.5 kB 🔴 +27.5 kB 🔴 +6.98 kB 🔴 +6.18 kB
assets/SubscriptionRequiredDialogContent-CTI1aSY0.js (removed) 27.5 kB — 🟢 -27.5 kB 🟢 -6.98 kB 🟢 -6.16 kB
assets/WidgetImageCrop-CLi4O-4w.js (new) — 24.3 kB 🔴 +24.3 kB 🔴 +6.2 kB 🔴 +5.46 kB
assets/WidgetImageCrop-fIhbIpDu.js (removed) 24.3 kB — 🟢 -24.3 kB 🟢 -6.2 kB 🟢 -5.45 kB
assets/SubscriptionPanelContentWorkspace-B6eLH2Qh.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.18 kB 🔴 +4.56 kB
assets/SubscriptionPanelContentWorkspace-zabATUaN.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.18 kB 🟢 -4.56 kB
assets/SignInContent-COUWTjVZ.js (removed) 20.8 kB — 🟢 -20.8 kB 🟢 -5.44 kB 🟢 -4.76 kB
assets/SignInContent-XCVgbTc2.js (new) — 20.8 kB 🔴 +20.8 kB 🔴 +5.43 kB 🔴 +4.76 kB
assets/CurrentUserPopoverWorkspace-CPzyvyIs.js (new) — 20.6 kB 🔴 +20.6 kB 🔴 +4.91 kB 🔴 +4.4 kB
assets/CurrentUserPopoverWorkspace-hoOQVFTa.js (removed) 20.6 kB — 🟢 -20.6 kB 🟢 -4.91 kB 🟢 -4.39 kB
assets/WidgetInputNumber-BPRKaMGn.js (removed) 19.1 kB — 🟢 -19.1 kB 🟢 -4.84 kB 🟢 -4.29 kB
assets/WidgetInputNumber-DxBlb0P2.js (new) — 19.1 kB 🔴 +19.1 kB 🔴 +4.84 kB 🔴 +4.29 kB
assets/Load3D-COpqaGMY.js (removed) 18.5 kB — 🟢 -18.5 kB 🟢 -4.39 kB 🟢 -3.84 kB
assets/Load3D-YvIzLLYj.js (new) — 18.5 kB 🔴 +18.5 kB 🔴 +4.39 kB 🔴 +3.83 kB
assets/WidgetRecordAudio-By6XRoxc.js (removed) 17.5 kB — 🟢 -17.5 kB 🟢 -5.04 kB 🟢 -4.5 kB
assets/WidgetRecordAudio-DlG4PGU8.js (new) — 17.5 kB 🔴 +17.5 kB 🔴 +5.04 kB 🔴 +4.51 kB
assets/WidgetRange-DPiHe3gH.js (removed) 17.1 kB — 🟢 -17.1 kB 🟢 -4.61 kB 🟢 -4.12 kB
assets/WidgetRange-eYIzL5rv.js (new) — 17.1 kB 🔴 +17.1 kB 🔴 +4.61 kB 🔴 +4.14 kB
assets/load3d-CClGzvBU.js (new) — 15.8 kB 🔴 +15.8 kB 🔴 +4.59 kB 🔴 +3.98 kB
assets/load3d-CK6XPzM2.js (removed) 15.8 kB — 🟢 -15.8 kB 🟢 -4.59 kB 🟢 -3.98 kB
assets/WaveAudioPlayer-DI2w3E8c.js (new) — 13.4 kB 🔴 +13.4 kB 🔴 +3.69 kB 🔴 +3.23 kB
assets/WaveAudioPlayer-oZpL68zv.js (removed) 13.4 kB — 🟢 -13.4 kB 🟢 -3.69 kB 🟢 -3.23 kB
assets/WidgetCurve-DvEoR_5C.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -3.93 kB 🟢 -3.56 kB
assets/WidgetCurve-Ik5DmPiC.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +3.93 kB 🔴 +3.57 kB
assets/TeamWorkspacesDialogContent-ChZMvFSL.js (removed) 11.3 kB — 🟢 -11.3 kB 🟢 -3.42 kB 🟢 -3.06 kB
assets/TeamWorkspacesDialogContent-T5M4aWyS.js (new) — 11.3 kB 🔴 +11.3 kB 🔴 +3.42 kB 🔴 +3.05 kB
assets/nodeTemplates-CPoMgI0M.js (removed) 9.84 kB — 🟢 -9.84 kB 🟢 -3.48 kB 🟢 -3.06 kB
assets/nodeTemplates-CYpcWdsL.js (new) — 9.84 kB 🔴 +9.84 kB 🔴 +3.48 kB 🔴 +3.08 kB
assets/NightlySurveyController-Dt7spSMy.js (removed) 8.97 kB — 🟢 -8.97 kB 🟢 -3.15 kB 🟢 -2.79 kB
assets/NightlySurveyController-DTf7XS32.js (new) — 8.97 kB 🔴 +8.97 kB 🔴 +3.15 kB 🔴 +2.78 kB
assets/Load3DConfiguration-Ca3ogQ4o.js (removed) 8.61 kB — 🟢 -8.61 kB 🟢 -2.54 kB 🟢 -2.23 kB
assets/Load3DConfiguration-YlX2Etih.js (new) — 8.61 kB 🔴 +8.61 kB 🔴 +2.54 kB 🔴 +2.23 kB
assets/InviteMemberDialogContent-BkB4tKCo.js (removed) 7.94 kB — 🟢 -7.94 kB 🟢 -2.53 kB 🟢 -2.22 kB
assets/InviteMemberDialogContent-DmBGiAb4.js (new) — 7.94 kB 🔴 +7.94 kB 🔴 +2.53 kB 🔴 +2.23 kB
assets/onboardingCloudRoutes-g5LXzp7k.js (new) — 6.73 kB 🔴 +6.73 kB 🔴 +2.12 kB 🔴 +1.82 kB
assets/onboardingCloudRoutes-ofG2dNEb.js (removed) 6.73 kB — 🟢 -6.73 kB 🟢 -2.12 kB 🟢 -1.82 kB
assets/CreateWorkspaceDialogContent-B46I2mxg.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +2.24 kB 🔴 +1.96 kB
assets/CreateWorkspaceDialogContent-CmCtjOrX.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -2.24 kB 🟢 -1.95 kB
assets/WidgetWithControl-MfmIzcYU.js (new) — 6.09 kB 🔴 +6.09 kB 🔴 +2.44 kB 🔴 +2.18 kB
assets/WidgetWithControl-NAMyliDy.js (removed) 6.09 kB — 🟢 -6.09 kB 🟢 -2.45 kB 🟢 -2.17 kB
assets/FreeTierDialogContent-CMf63dfY.js (removed) 6.01 kB — 🟢 -6.01 kB 🟢 -2.13 kB 🟢 -1.88 kB
assets/FreeTierDialogContent-YsnxtWQy.js (new) — 6.01 kB 🔴 +6.01 kB 🔴 +2.13 kB 🔴 +1.88 kB
assets/EditWorkspaceDialogContent-C_SIkoqm.js (removed) 5.95 kB — 🟢 -5.95 kB 🟢 -2.2 kB 🟢 -1.93 kB
assets/EditWorkspaceDialogContent-CCdbwFKz.js (new) — 5.95 kB 🔴 +5.95 kB 🔴 +2.2 kB 🔴 +1.93 kB
assets/WidgetTextarea-CfskWg9e.js (new) — 5.76 kB 🔴 +5.76 kB 🔴 +2.27 kB 🔴 +2.02 kB
assets/WidgetTextarea-DYdUZkE_.js (removed) 5.76 kB — 🟢 -5.76 kB 🟢 -2.27 kB 🟢 -2.01 kB
assets/Preview3d-crAuXeYk.js (removed) 5.73 kB — 🟢 -5.73 kB 🟢 -1.92 kB 🟢 -1.68 kB
assets/Preview3d-DuWkNI6k.js (new) — 5.73 kB 🔴 +5.73 kB 🔴 +1.92 kB 🔴 +1.68 kB
assets/ValueControlPopover-BptuH9_-.js (removed) 5.53 kB — 🟢 -5.53 kB 🟢 -2.01 kB 🟢 -1.79 kB
assets/ValueControlPopover-DFmdDypo.js (new) — 5.53 kB 🔴 +5.53 kB 🔴 +2.01 kB 🔴 +1.81 kB
assets/CancelSubscriptionDialogContent-CuegLKU2.js (new) — 5.49 kB 🔴 +5.49 kB 🔴 +2.05 kB 🔴 +1.81 kB
assets/CancelSubscriptionDialogContent-dVQKkwg5.js (removed) 5.49 kB — 🟢 -5.49 kB 🟢 -2.06 kB 🟢 -1.8 kB
assets/DeleteWorkspaceDialogContent-BJEm2Bgf.js (new) — 4.85 kB 🔴 +4.85 kB 🔴 +1.87 kB 🔴 +1.64 kB
assets/DeleteWorkspaceDialogContent-C13MH7XA.js (removed) 4.85 kB — 🟢 -4.85 kB 🟢 -1.88 kB 🟢 -1.63 kB
assets/missingModelDownload-DkrcVCq-.js (new) — 4.78 kB 🔴 +4.78 kB 🔴 +1.84 kB 🔴 +1.62 kB
assets/LeaveWorkspaceDialogContent-AoHNFNf6.js (removed) 4.68 kB — 🟢 -4.68 kB 🟢 -1.82 kB 🟢 -1.59 kB
assets/LeaveWorkspaceDialogContent-BmJmWGwf.js (new) — 4.68 kB 🔴 +4.68 kB 🔴 +1.82 kB 🔴 +1.59 kB
assets/RemoveMemberDialogContent-D9WE-vKU.js (removed) 4.66 kB — 🟢 -4.66 kB 🟢 -1.78 kB 🟢 -1.56 kB
assets/RemoveMemberDialogContent-DhibvXY7.js (new) — 4.66 kB 🔴 +4.66 kB 🔴 +1.77 kB 🔴 +1.55 kB
assets/RevokeInviteDialogContent-BCRKx9N2.js (removed) 4.57 kB — 🟢 -4.57 kB 🟢 -1.79 kB 🟢 -1.58 kB
assets/RevokeInviteDialogContent-C8k1ka4G.js (new) — 4.57 kB 🔴 +4.57 kB 🔴 +1.78 kB 🔴 +1.57 kB
assets/missingModelDownload-7fDbn5MN.js (removed) 4.52 kB — 🟢 -4.52 kB 🟢 -1.77 kB 🟢 -1.55 kB
assets/InviteMemberUpsellDialogContent-DjCXsmzW.js (new) — 4.47 kB 🔴 +4.47 kB 🔴 +1.65 kB 🔴 +1.45 kB
assets/InviteMemberUpsellDialogContent-DY7uuYGP.js (removed) 4.47 kB — 🟢 -4.47 kB 🟢 -1.65 kB 🟢 -1.45 kB
assets/tierBenefits-B2XTkN07.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.58 kB 🔴 +1.36 kB
assets/tierBenefits-BP4zzMsO.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.58 kB 🟢 -1.36 kB
assets/cloudSessionCookie-C3xkv5hr.js (removed) 4.31 kB — 🟢 -4.31 kB 🟢 -1.57 kB 🟢 -1.37 kB
assets/cloudSessionCookie-DNFYrhDE.js (new) — 4.31 kB 🔴 +4.31 kB 🔴 +1.57 kB 🔴 +1.38 kB
assets/Media3DTop-BR7xwn69.js (new) — 4.04 kB 🔴 +4.04 kB 🔴 +1.71 kB 🔴 +1.51 kB
assets/Media3DTop-S3l4vPni.js (removed) 4.04 kB — 🟢 -4.04 kB 🟢 -1.71 kB 🟢 -1.5 kB
assets/saveMesh-Bn_fWzKL.js (new) — 4.03 kB 🔴 +4.03 kB 🔴 +1.76 kB 🔴 +1.56 kB
assets/saveMesh-KyThCwom.js (removed) 4.03 kB — 🟢 -4.03 kB 🟢 -1.76 kB 🟢 -1.56 kB
assets/GlobalToast-BIg9IuJY.js (removed) 3.05 kB — 🟢 -3.05 kB 🟢 -1.26 kB 🟢 -1.11 kB
assets/GlobalToast-DMGWJvdu.js (new) — 3.05 kB 🔴 +3.05 kB 🔴 +1.26 kB 🔴 +1.08 kB
assets/CloudRunButtonWrapper-C3JA5XiF.js (new) — 2.23 kB 🔴 +2.23 kB 🔴 +1.02 kB 🔴 +910 B
assets/CloudRunButtonWrapper-Djn--ujW.js (removed) 2.23 kB — 🟢 -2.23 kB 🟢 -1.02 kB 🟢 -911 B
assets/SubscribeToRun-B4_yfG50.js (new) — 2.13 kB 🔴 +2.13 kB 🔴 +983 B 🔴 +865 B
assets/SubscribeToRun-zo5QBSWW.js (removed) 2.13 kB — 🟢 -2.13 kB 🟢 -984 B 🟢 -881 B
assets/MediaAudioTop-CasWFavr.js (removed) 2.08 kB — 🟢 -2.08 kB 🟢 -1.01 kB 🟢 -858 B
assets/MediaAudioTop-DqqmOXdu.js (new) — 2.08 kB 🔴 +2.08 kB 🔴 +1.01 kB 🔴 +861 B
assets/cloudBadges-B9_O9u4c.js (removed) 1.96 kB — 🟢 -1.96 kB 🟢 -977 B 🟢 -850 B
assets/cloudBadges-Bs8TH3bO.js (new) — 1.96 kB 🔴 +1.96 kB 🔴 +976 B 🔴 +850 B
assets/cloudSubscription-BnQHHT1k.js (removed) 1.88 kB — 🟢 -1.88 kB 🟢 -897 B 🟢 -779 B
assets/cloudSubscription-DPzY8_iU.js (new) — 1.88 kB 🔴 +1.88 kB 🔴 +895 B 🔴 +777 B
assets/graphHasMissingNodes-BtL-6MPE.js (new) — 1.83 kB 🔴 +1.83 kB 🔴 +859 B 🔴 +775 B
assets/graphHasMissingNodes-BY1t18Qm.js (removed) 1.83 kB — 🟢 -1.83 kB 🟢 -861 B 🟢 -758 B
assets/Load3D-CfeCqFqU.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -710 B 🟢 -630 B
assets/Load3D-PwWRi6Dv.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +714 B 🔴 +629 B
assets/previousFullPath-DQpdekPc.js (new) — 1.53 kB 🔴 +1.53 kB 🔴 +692 B 🔴 +598 B
assets/previousFullPath-DRf2_8-T.js (removed) 1.53 kB — 🟢 -1.53 kB 🟢 -695 B 🟢 -594 B
assets/nightlyBadges-DPTOFbi8.js (new) — 1.49 kB 🔴 +1.49 kB 🔴 +742 B 🔴 +683 B
assets/nightlyBadges-On2Yo4iJ.js (removed) 1.49 kB — 🟢 -1.49 kB 🟢 -746 B 🟢 -654 B
assets/Load3dViewerContent-CSjrvgF3.js (new) — 1.46 kB 🔴 +1.46 kB 🔴 +662 B 🔴 +587 B
assets/Load3dViewerContent-DY0AoFG6.js (removed) 1.46 kB — 🟢 -1.46 kB 🟢 -663 B 🟢 -587 B
assets/SubscriptionPanelContentWorkspace-D9T1cU5N.js (removed) 1.35 kB — 🟢 -1.35 kB 🟢 -617 B 🟢 -537 B
assets/SubscriptionPanelContentWorkspace-gEav9QfH.js (new) — 1.35 kB 🔴 +1.35 kB 🔴 +613 B 🔴 +536 B
assets/WidgetLegacy-DhafT1TD.js (removed) 1.18 kB — 🟢 -1.18 kB 🟢 -564 B 🟢 -495 B
assets/WidgetLegacy-dkRjdvxW.js (new) — 1.18 kB 🔴 +1.18 kB 🔴 +560 B 🔴 +495 B
assets/changeTracker-1v99NhTK.js (new) — 1.15 kB 🔴 +1.15 kB 🔴 +549 B 🔴 +487 B
assets/changeTracker-BMqUDzs0.js (removed) 1.15 kB — 🟢 -1.15 kB 🟢 -552 B 🟢 -482 B
assets/missingModelDownload-B7Ov_LvR.js (new) — 386 B 🔴 +386 B 🔴 +226 B 🔴 +204 B
assets/missingModelDownload-CP68w0WJ.js (removed) 386 B — 🟢 -386 B 🟢 -227 B 🟢 -207 B

Status: 59 added / 59 removed / 77 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 44.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 46.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
vue-large-graph-idle: · 58.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.3 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 157.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 53.1 MB heap

No regressions detected.

All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=-0.1
canvas-idle: p95 frame time 17ms 17ms +1% —
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 8ms 8ms -3% z=-3.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 8 -11% z=-5.6
canvas-idle: task duration 372ms 352ms -5% z=-1.4
canvas-idle: script duration 21ms 15ms -25% z=-4.4
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 67.6 MB 68.7 MB +2% —
canvas-idle: DOM nodes 18 16 -11% z=-5.2
canvas-idle: event listeners 4 4 +0% z=-1.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=-0.4
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% —
canvas-mouse-sweep: layout duration 4ms 3ms -5% z=-1.0
canvas-mouse-sweep: style recalc duration 37ms 37ms -2% z=-1.9
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 72 73 +1% z=-2.4
canvas-mouse-sweep: task duration 797ms 786ms -1% z=-1.4
canvas-mouse-sweep: script duration 129ms 129ms -0% z=-1.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 45.6 MB 44.1 MB -3% —
canvas-mouse-sweep: DOM nodes -265 -263 -1% z=-125.8
canvas-mouse-sweep: event listeners -133 -133 +0% z=-33.9
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=0.5
canvas-zoom-sweep: p95 frame time 17ms 17ms +1% —
canvas-zoom-sweep: layout duration 1ms 1ms +14% z=-0.6
canvas-zoom-sweep: style recalc duration 18ms 18ms -2% z=-1.0
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 32 31 -3% z=-0.6
canvas-zoom-sweep: task duration 305ms 282ms -7% z=-1.9
canvas-zoom-sweep: script duration 22ms 18ms -18% z=-3.1
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 46.6 MB 46.5 MB -0% —
canvas-zoom-sweep: DOM nodes 77 77 +0% z=-2.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.9
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.6
dom-widget-clipping: p95 frame time 17ms 17ms -0% —
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 7ms 9ms +31% z=-1.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 10 12 +20% z=-2.2
dom-widget-clipping: task duration 339ms 356ms +5% z=-0.5
dom-widget-clipping: script duration 60ms 61ms +1% z=-2.0
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 54.9 MB 54.8 MB -0% —
dom-widget-clipping: DOM nodes 16 20 +25% z=-1.5
dom-widget-clipping: event listeners 0 0 +0% variance too high
large-graph-idle: avg frame time 17ms 17ms +0% z=-0.2
large-graph-idle: p95 frame time 17ms 17ms +0% —
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 10ms 9ms -10% z=-2.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 8 -11% z=-11.5
large-graph-idle: task duration 580ms 530ms -9% z=-0.2
large-graph-idle: script duration 105ms 88ms -17% z=-1.4
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 58.4 MB 65.5 MB +12% —
large-graph-idle: DOM nodes -263 -262 -0% z=-317.2
large-graph-idle: event listeners -127 -129 +2% z=-25.4
large-graph-pan: avg frame time 17ms 17ms +0% z=0.3
large-graph-pan: p95 frame time 17ms 17ms -1% —
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 18ms 19ms +3% z=1.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 68 -1% z=-2.4
large-graph-pan: task duration 1115ms 1133ms +2% z=1.2
large-graph-pan: script duration 401ms 414ms +3% z=0.3
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 57.6 MB 70.8 MB +23% —
large-graph-pan: DOM nodes -265 -264 -0% z=-171.5
large-graph-pan: event listeners -127 -127 +0% z=-159.3
large-graph-zoom: avg frame time 17ms 17ms +0% —
large-graph-zoom: p95 frame time 17ms 17ms -1% —
large-graph-zoom: layout duration 7ms 7ms -3% —
large-graph-zoom: style recalc duration 19ms 19ms -2% —
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 65 65 +0% —
large-graph-zoom: task duration 1357ms 1335ms -2% —
large-graph-zoom: script duration 499ms 489ms -2% —
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 67.2 MB 72.0 MB +7% —
large-graph-zoom: DOM nodes -267 -268 +0% —
large-graph-zoom: event listeners -127 -125 -2% —
minimap-idle: avg frame time 17ms 17ms +0% z=0.1
minimap-idle: p95 frame time 17ms 17ms -0% —
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 9ms 9ms +4% z=-0.5
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 9 +13% z=-0.8
minimap-idle: task duration 556ms 518ms -7% z=-0.2
minimap-idle: script duration 98ms 92ms -6% z=-0.6
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 73.2 MB 60.3 MB -18% —
minimap-idle: DOM nodes -265 -264 -0% z=-207.0
minimap-idle: event listeners -131 -129 -2% z=-202.3
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.1
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +1% —
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 11ms -3% z=-1.9
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 46 +0% z=-3.3
subgraph-dom-widget-clipping: task duration 356ms 349ms -2% z=-1.6
subgraph-dom-widget-clipping: script duration 121ms 119ms -2% z=-1.4
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 56.4 MB 54.9 MB -3% —
subgraph-dom-widget-clipping: DOM nodes 18 18 +0% z=-3.7
subgraph-dom-widget-clipping: event listeners 6 6 +0% z=-1.7
subgraph-idle: avg frame time 17ms 17ms -0% z=-0.7
subgraph-idle: p95 frame time 17ms 17ms -1% —
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 8ms -7% z=-2.5
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 9 8 -11% z=-4.4
subgraph-idle: task duration 371ms 347ms -6% z=-0.7
subgraph-idle: script duration 18ms 14ms -19% z=-2.2
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 67.9 MB 68.5 MB +1% —
subgraph-idle: DOM nodes 17 16 -6% z=-3.9
subgraph-idle: event listeners 4 4 +0% variance too high
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.4
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% —
subgraph-mouse-sweep: layout duration 5ms 5ms -4% z=-0.4
subgraph-mouse-sweep: style recalc duration 39ms 37ms -6% z=-1.7
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 76 75 -1% z=-2.7
subgraph-mouse-sweep: task duration 702ms 667ms -5% z=-1.4
subgraph-mouse-sweep: script duration 98ms 94ms -4% z=-1.0
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 60.1 MB 60.7 MB +1% —
subgraph-mouse-sweep: DOM nodes 62 60 -3% z=-3.1
subgraph-mouse-sweep: event listeners 4 4 +0% variance too high
viewport-pan-sweep: avg frame time 17ms 17ms +0% —
viewport-pan-sweep: p95 frame time 17ms 17ms +1% —
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 53ms 51ms -3% —
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 251 249 -1% —
viewport-pan-sweep: task duration 3931ms 3720ms -5% —
viewport-pan-sweep: script duration 1337ms 1260ms -6% —
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 67.3 MB 65.4 MB -3% —
viewport-pan-sweep: DOM nodes -260 -263 +1% —
viewport-pan-sweep: event listeners -113 -113 +0% —
vue-large-graph-idle: avg frame time 17ms 17ms +0% —
vue-large-graph-idle: p95 frame time 17ms 17ms +0% —
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 12463ms 12097ms -3% —
vue-large-graph-idle: script duration 606ms 581ms -4% —
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 163.9 MB 164.3 MB +0% —
vue-large-graph-idle: DOM nodes -8331 -8331 +0% —
vue-large-graph-idle: event listeners -16464 -16464 +0% —
vue-large-graph-pan: avg frame time 17ms 17ms +0% —
vue-large-graph-pan: p95 frame time 17ms 17ms +0% —
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 16ms -8% —
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 67 66 -1% —
vue-large-graph-pan: task duration 14762ms 14142ms -4% —
vue-large-graph-pan: script duration 889ms 869ms -2% —
vue-large-graph-pan: TBT 0ms 0ms +0% —
vue-large-graph-pan: heap used 155.6 MB 157.9 MB +1% —
vue-large-graph-pan: DOM nodes -8331 -8331 +0% —
vue-large-graph-pan: event listeners -16490 -16466 -0% —
workflow-execution: avg frame time 17ms 17ms +0% z=0.6
workflow-execution: p95 frame time 17ms 17ms +1% —
workflow-execution: layout duration 2ms 1ms -23% z=-0.8
workflow-execution: style recalc duration 25ms 26ms +2% z=0.7
workflow-execution: layout count 6 5 -17% z=0.1
workflow-execution: style recalc count 19 17 -11% z=-0.4
workflow-execution: task duration 132ms 127ms -4% z=0.4
workflow-execution: script duration 26ms 27ms +3% z=-0.7
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 52.7 MB 53.1 MB +1% —
workflow-execution: DOM nodes 168 159 -5% z=-0.3
workflow-execution: event listeners 69 69 +0% z=3.9
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 11ms 1ms 8.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 5.0%
canvas-idle: task duration 395ms 31ms 7.9%
canvas-idle: script duration 25ms 2ms 8.8%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: DOM nodes 23 1 5.6%
canvas-idle: event listeners 12 5 40.9%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: layout duration 4ms 0ms 5.4%
canvas-mouse-sweep: style recalc duration 43ms 3ms 7.4%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 79 2 3.0%
canvas-mouse-sweep: task duration 865ms 58ms 6.7%
canvas-mouse-sweep: script duration 136ms 6ms 4.8%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: DOM nodes 62 3 4.2%
canvas-mouse-sweep: event listeners 8 4 49.4%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: layout duration 1ms 0ms 7.0%
canvas-zoom-sweep: style recalc duration 19ms 2ms 8.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.5%
canvas-zoom-sweep: task duration 327ms 23ms 7.1%
canvas-zoom-sweep: script duration 27ms 3ms 11.1%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: DOM nodes 79 1 1.0%
canvas-zoom-sweep: event listeners 24 5 21.8%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 10ms 1ms 8.0%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 0 3.8%
dom-widget-clipping: task duration 365ms 16ms 4.5%
dom-widget-clipping: script duration 68ms 3ms 4.8%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: DOM nodes 22 1 6.4%
dom-widget-clipping: event listeners 8 6 81.2%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 12ms 1ms 8.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 12 0 2.7%
large-graph-idle: task duration 542ms 54ms 10.0%
large-graph-idle: script duration 102ms 11ms 10.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: DOM nodes 25 1 3.7%
large-graph-idle: event listeners 26 6 23.2%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 17ms 1ms 4.6%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 70 1 0.9%
large-graph-pan: task duration 1082ms 43ms 4.0%
large-graph-pan: script duration 408ms 20ms 4.8%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: DOM nodes 19 2 8.7%
large-graph-pan: event listeners 5 1 16.8%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 10ms 1ms 8.6%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 10 1 7.1%
minimap-idle: task duration 527ms 47ms 9.0%
minimap-idle: script duration 98ms 10ms 10.1%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: DOM nodes 19 1 7.1%
minimap-idle: event listeners 5 1 14.4%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 13ms 1ms 7.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.2%
subgraph-dom-widget-clipping: task duration 378ms 18ms 4.9%
subgraph-dom-widget-clipping: script duration 128ms 6ms 4.9%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.0%
subgraph-dom-widget-clipping: event listeners 16 6 36.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 10ms 1ms 7.5%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 6.0%
subgraph-idle: task duration 370ms 31ms 8.5%
subgraph-idle: script duration 20ms 3ms 13.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: DOM nodes 22 1 6.9%
subgraph-idle: event listeners 10 7 64.5%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: layout duration 5ms 0ms 6.8%
subgraph-mouse-sweep: style recalc duration 42ms 3ms 7.8%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 80 2 2.4%
subgraph-mouse-sweep: task duration 766ms 69ms 9.0%
subgraph-mouse-sweep: script duration 101ms 7ms 6.5%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.3%
subgraph-mouse-sweep: event listeners 8 4 52.6%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: layout duration 2ms 0ms 9.4%
workflow-execution: style recalc duration 24ms 2ms 9.1%
workflow-execution: layout count 5 1 11.0%
workflow-execution: style recalc count 18 2 11.5%
workflow-execution: task duration 123ms 11ms 8.8%
workflow-execution: script duration 29ms 3ms 10.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: DOM nodes 161 7 4.4%
workflow-execution: event listeners 52 4 8.4%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▃▆▁▆▃▆█▆▆▄▃▃▄▃ ➡️ 17ms
canvas-idle: p95 frame time ➡️ NaNms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▇▆▆▃█▄▃▄▃▇▄▁▆▇ ➡️ 11ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▃▅▂▅▆▃▁▂▁▂▅▆▅▆ ➡️ 12
canvas-idle: task duration ▃▃▃▆▂▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: script duration ▄▃▅▇▂▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ➡️ NaN MB
canvas-idle: DOM nodes █▇▆▅▃▇▃▁▂▂▅▆▆▆▇ ➡️ 24
canvas-idle: event listeners ▅█▅▄▁▅▁▁▁▄▅▅▁▅▄ 📉 11
canvas-mouse-sweep: avg frame time ▆█▆▃▁▃▁▆▆▁▃▆▆▃▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ➡️ NaNms
canvas-mouse-sweep: layout duration ▁▃▂▄▁▂▁▃▆▂█▇▆▄▃ ➡️ 4ms
canvas-mouse-sweep: style recalc duration ▄▄▂▄▁▂▃▃▅▄█▆▂▄▄ ➡️ 43ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▅▄▃▂▂▁▄▄▅▆▅▂▇▄ ➡️ 79
canvas-mouse-sweep: task duration █▆▄▂▂▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: script duration ▄▅▄▆▄▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ➡️ NaN MB
canvas-mouse-sweep: DOM nodes █▅▃▃▁▂▂▃▂▄▆▅▃▅▅ ➡️ 64
canvas-mouse-sweep: event listeners █▁▁▁▁▁▇▁▁▁██▇▁█ 📈 13
canvas-zoom-sweep: avg frame time ▅▅█▄▅▁▁▁▅▁▁▅▄▅▁ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ➡️ NaNms
canvas-zoom-sweep: layout duration ▆▅▅▄▁▁█▅▃▅▇▆▁▂▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▅▄▆▅▃█▆▇▅▇▄▁▃▅ ➡️ 20ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▁▃▄▆▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: task duration ▄▂▁▇▂▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: script duration ▃▃▂▇▂▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ➡️ NaN MB
canvas-zoom-sweep: DOM nodes ▄▃▁▅█▁▃▆▄▅▅▃▃▄▃ ➡️ 79
canvas-zoom-sweep: event listeners ▁▁▂▅█▂▁▅▁▅▅▄▁▅▁ ➡️ 19
dom-widget-clipping: avg frame time ▂▄▅▅▂▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
dom-widget-clipping: p95 frame time ➡️ NaNms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▆▂▆▄▃██▄▁▆▇▆▃▅ ➡️ 10ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇█▅█▅▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: task duration ▃▃▁▅▄▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: script duration ▅▄▄▆▆▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ➡️ NaN MB
dom-widget-clipping: DOM nodes ▇▇▄▇▅▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: event listeners ▅▅▅▅▁▅██▁▁▁▁█▁▁ 📉 2
large-graph-idle: avg frame time ▅▅▅▅▅▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-idle: p95 frame time ➡️ NaNms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▅▅▅▆▄▅▃▄▅▅▆█▁▄▆ ➡️ 13ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▆█▃▃▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: task duration ▂▃▂▆▂▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: script duration ▄▅▄▆▄▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ➡️ NaN MB
large-graph-idle: DOM nodes ▆█▅▂▅▃▁▂▃▅▅▆▂▆▅ ➡️ 25
large-graph-idle: event listeners ███▇██▄▁▄▇▇█▂█▇ ➡️ 29
large-graph-pan: avg frame time ▆▃▃▆█▃▁█▆▆▆▆█▁▆ ➡️ 17ms
large-graph-pan: p95 frame time ➡️ NaNms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▂▄▄▁▅▂▂▁▄▄█▃▁▂ ➡️ 17ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▆▃█▂▃▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: task duration ▄▃▄▆▄▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: script duration ▅▄▅▆▆▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ➡️ NaN MB
large-graph-pan: DOM nodes ▅▃▆▂▄▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: event listeners █▆█▁▁▆▁▁▃▆▁▃██▃ ➡️ 5
minimap-idle: avg frame time ▃▆▆▃█▁█▆▆▃▃▆█▆█ ➡️ 17ms
minimap-idle: p95 frame time ➡️ NaNms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▄█▁█▅▅█▅▅▃▅▁▁▄▆ ➡️ 10ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 9
minimap-idle: task duration ▃▄▁▅▁▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: script duration ▄▆▃▇▃▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ➡️ NaN MB
minimap-idle: DOM nodes ▃▅▂▄█▃▆▁▂▅▂▁▅▆▃ ➡️ 19
minimap-idle: event listeners ▃▃▆▁▁▁▃▁▁▆▁▃█▆▁ ➡️ 4
subgraph-dom-widget-clipping: avg frame time ▅▄▄▄▄▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ➡️ NaNms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▂▄▃▅▅▃▂▅▇▃▄█▁▄▆ ➡️ 14ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▇█▆▃▆▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: task duration ▂▃▃▆▅▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▃▃▃▄▅▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ➡️ NaN MB
subgraph-dom-widget-clipping: DOM nodes ▅▇▅▂▅▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: event listeners ▅▅▅▂▅▁▅██▁▁█▅█▅ 📈 16
subgraph-idle: avg frame time ▆▆█▁▆▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-idle: p95 frame time ➡️ NaNms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▁▇▃▆▂▄▂▃▃▆▆▄▃▇█ ➡️ 12ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▃▆▃▃▂▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: task duration ▁▃▁▇▁▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: script duration ▁▃▂▇▁▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ➡️ NaN MB
subgraph-idle: DOM nodes ▃▅▃▂▁▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: event listeners ▁▅▁▁▁▁▁▁▁▅▄▁███ 📈 21
subgraph-mouse-sweep: avg frame time ▅▄▁▃▃▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ➡️ NaNms
subgraph-mouse-sweep: layout duration ▁▄▄▄▃▃▅▅▅▂█▇▂▃▆ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▃▂▄▅▂▃▄▅█▃█▆▁▂▅ ➡️ 43ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count ▅▂▅▅▁▄▃▅█▅▆▄▂▄▅ ➡️ 81
subgraph-mouse-sweep: task duration ▃▂▄▅▂▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: script duration ▄▅▄▇▅▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ➡️ NaN MB
subgraph-mouse-sweep: DOM nodes ▅▁▄▅▁▄▃▃█▅▅▄▂▅▃ ➡️ 66
subgraph-mouse-sweep: event listeners ▇▁▂▇▁▂▂▂█▇▂▂▇▇▂ 📈 5
workflow-execution: avg frame time ▆▆▆▄▆▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
workflow-execution: p95 frame time ➡️ NaNms
workflow-execution: layout duration ▁▆▁▃▂▄▃▂▃▃▅█▄▂▅ ➡️ 2ms
workflow-execution: style recalc duration ▃▇▅▇▁▅▆▇█▁██▂▄▆ ➡️ 25ms
workflow-execution: layout count ▁█▂▃▂▃▃▁▃▃▄▃▂▃▂ ➡️ 5
workflow-execution: style recalc count ▃█▅▇▁▄▅▆▅▅▅▅▄▄▂ ➡️ 15
workflow-execution: task duration ▂▅▄▅▁▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: script duration ▄▃▄▄▃▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ➡️ NaN MB
workflow-execution: DOM nodes ▂█▃▆▁▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: event listeners ▅███▁▅███▁██▅█▅ ➡️ 49
Raw data
{
  "timestamp": "2026-05-05T09:28:19.665Z",
  "gitSha": "8d4263a1c8312b23c1cbdaa79fba0ba590fa338a",
  "branch": "bl/missing-model-download-contract",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2030.1979999999844,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.841999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 379.448,
      "heapDeltaBytes": 22751912,
      "heapUsedBytes": 71310400,
      "domNodes": 16,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 15.488000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2000.8720000000153,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.455,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 323.978,
      "heapDeltaBytes": 22784388,
      "heapUsedBytes": 72300760,
      "domNodes": 14,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 14.890000000000002,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.1220000000858,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.658,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 352.04999999999995,
      "heapDeltaBytes": 23474212,
      "heapUsedBytes": 72051504,
      "domNodes": 18,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 16.979,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1769.0519999999879,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 33.027,
      "layouts": 12,
      "layoutDurationMs": 3.3550000000000004,
      "taskDurationMs": 752.989,
      "heapDeltaBytes": -1040592,
      "heapUsedBytes": 47649016,
      "domNodes": -264,
      "jsHeapTotalBytes": 16117760,
      "scriptDurationMs": 125.90299999999999,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1869.4020000000364,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 39.839,
      "layouts": 12,
      "layoutDurationMs": 4.202000000000001,
      "taskDurationMs": 811.153,
      "heapDeltaBytes": -2324400,
      "heapUsedBytes": 46293912,
      "domNodes": -263,
      "jsHeapTotalBytes": 15593472,
      "scriptDurationMs": 129.837,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1875.8809999999357,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 36.586999999999996,
      "layouts": 12,
      "layoutDurationMs": 3.4050000000000002,
      "taskDurationMs": 785.794,
      "heapDeltaBytes": -2506804,
      "heapUsedBytes": 45783928,
      "domNodes": -263,
      "jsHeapTotalBytes": 15855616,
      "scriptDurationMs": 128.538,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1716.3639999999987,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.898,
      "layouts": 6,
      "layoutDurationMs": 0.575,
      "taskDurationMs": 282.15999999999997,
      "heapDeltaBytes": 212644,
      "heapUsedBytes": 48750312,
      "domNodes": 76,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 17.78,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1715.1250000000005,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.619,
      "layouts": 6,
      "layoutDurationMs": 0.6149999999999999,
      "taskDurationMs": 277.234,
      "heapDeltaBytes": 156168,
      "heapUsedBytes": 48844484,
      "domNodes": 77,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 17.124,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1752.9739999999947,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 19.227999999999994,
      "layouts": 6,
      "layoutDurationMs": 0.7509999999999999,
      "taskDurationMs": 301.093,
      "heapDeltaBytes": 185256,
      "heapUsedBytes": 48541604,
      "domNodes": 79,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 19.641,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 582.0410000000038,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.996000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.772,
      "heapDeltaBytes": 10059516,
      "heapUsedBytes": 59010468,
      "domNodes": 20,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 66.04299999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 553.1650000000354,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.068999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 335.24399999999997,
      "heapDeltaBytes": 8688984,
      "heapUsedBytes": 57404920,
      "domNodes": 18,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 58.579,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 553.6749999999984,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 9.378999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 357.381,
      "heapDeltaBytes": -10911852,
      "heapUsedBytes": 57482880,
      "domNodes": 23,
      "jsHeapTotalBytes": 20447232,
      "scriptDurationMs": 61.285,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2013.1119999999783,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.091999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.561,
      "heapDeltaBytes": 4265784,
      "heapUsedBytes": 62704576,
      "domNodes": -264,
      "jsHeapTotalBytes": 815104,
      "scriptDurationMs": 97.123,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2040.208000000007,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.339,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 522.6070000000001,
      "heapDeltaBytes": 15173276,
      "heapUsedBytes": 73564276,
      "domNodes": -262,
      "jsHeapTotalBytes": 290816,
      "scriptDurationMs": 86.752,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.9909999999336,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.497000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 529.802,
      "heapDeltaBytes": 9991908,
      "heapUsedBytes": 68699628,
      "domNodes": -260,
      "jsHeapTotalBytes": 3231744,
      "scriptDurationMs": 87.93699999999998,
      "eventListeners": -131,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2153.550999999993,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 17.719999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1111.364,
      "heapDeltaBytes": 18797536,
      "heapUsedBytes": 78790556,
      "domNodes": -264,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 413.71899999999994,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2158.294000000012,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 21.186999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1199.5900000000001,
      "heapDeltaBytes": 14332248,
      "heapUsedBytes": 74211196,
      "domNodes": -267,
      "jsHeapTotalBytes": 1282048,
      "scriptDurationMs": 476.03400000000005,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2123.8730000000032,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 18.503,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1133.1829999999998,
      "heapDeltaBytes": 203136,
      "heapUsedBytes": 59526336,
      "domNodes": -263,
      "jsHeapTotalBytes": 1282048,
      "scriptDurationMs": 408.70599999999996,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3133.186999999964,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 18.017,
      "layouts": 60,
      "layoutDurationMs": 7.239000000000001,
      "taskDurationMs": 1334.6740000000002,
      "heapDeltaBytes": 14779692,
      "heapUsedBytes": 75493596,
      "domNodes": -269,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 488.05699999999996,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3180.482999999981,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 18.873000000000005,
      "layouts": 60,
      "layoutDurationMs": 7.261,
      "taskDurationMs": 1298.6290000000001,
      "heapDeltaBytes": 9981736,
      "heapUsedBytes": 70568864,
      "domNodes": -268,
      "jsHeapTotalBytes": 1339392,
      "scriptDurationMs": 488.816,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3129.916000000094,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 19.441,
      "layouts": 60,
      "layoutDurationMs": 7.506,
      "taskDurationMs": 1378.538,
      "heapDeltaBytes": 15243932,
      "heapUsedBytes": 75853600,
      "domNodes": -267,
      "jsHeapTotalBytes": 28672,
      "scriptDurationMs": 500.69700000000006,
      "eventListeners": -125,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.9010000000285,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.139000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 544.867,
      "heapDeltaBytes": 4918332,
      "heapUsedBytes": 65514144,
      "domNodes": -264,
      "jsHeapTotalBytes": -233472,
      "scriptDurationMs": 92.74000000000002,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.3490000000006,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.982999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 513.7929999999999,
      "heapDeltaBytes": 5105160,
      "heapUsedBytes": 63247212,
      "domNodes": -264,
      "jsHeapTotalBytes": 552960,
      "scriptDurationMs": 92.364,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2054.390000000012,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.2860000000001,
      "heapDeltaBytes": 2756892,
      "heapUsedBytes": 61750952,
      "domNodes": -264,
      "jsHeapTotalBytes": 4485120,
      "scriptDurationMs": 89.98999999999998,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 525.7519999999545,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.401,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 346.97700000000003,
      "heapDeltaBytes": 9301164,
      "heapUsedBytes": 57839956,
      "domNodes": 16,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 116.229,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 562.6510000000167,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.630999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 364.30199999999996,
      "heapDeltaBytes": 9523452,
      "heapUsedBytes": 57535504,
      "domNodes": 20,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 134.05299999999997,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 555.3010000000995,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.875,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 348.57099999999997,
      "heapDeltaBytes": 8810932,
      "heapUsedBytes": 57529016,
      "domNodes": 18,
      "jsHeapTotalBytes": 16252928,
      "scriptDurationMs": 119.24399999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.037000000025,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.489,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 347.408,
      "heapDeltaBytes": 23166288,
      "heapUsedBytes": 71859988,
      "domNodes": 16,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 14.761999999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.2329999999852,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.688999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 376.293,
      "heapDeltaBytes": -3707844,
      "heapUsedBytes": 44926904,
      "domNodes": -262,
      "jsHeapTotalBytes": 14544896,
      "scriptDurationMs": 13.206,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.472000000088,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.789000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.51699999999994,
      "heapDeltaBytes": 22950744,
      "heapUsedBytes": 72547792,
      "domNodes": 16,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 14.410999999999992,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1677.3850000000152,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 36.68599999999999,
      "layouts": 16,
      "layoutDurationMs": 4.568,
      "taskDurationMs": 644.512,
      "heapDeltaBytes": 13955724,
      "heapUsedBytes": 63671760,
      "domNodes": 61,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 92.366,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.7680000000073,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.525,
      "layouts": 16,
      "layoutDurationMs": 4.364,
      "taskDurationMs": 705.191,
      "heapDeltaBytes": -738408,
      "heapUsedBytes": 47888056,
      "domNodes": -262,
      "jsHeapTotalBytes": 16117760,
      "scriptDurationMs": 94.109,
      "eventListeners": -133,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1699.1349999999557,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 36.718,
      "layouts": 16,
      "layoutDurationMs": 4.598,
      "taskDurationMs": 667.436,
      "heapDeltaBytes": 14795900,
      "heapUsedBytes": 64514608,
      "domNodes": 60,
      "jsHeapTotalBytes": 15204352,
      "scriptDurationMs": 94.734,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8168.606000000011,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 51.217,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3720.1439999999993,
      "heapDeltaBytes": 9490296,
      "heapUsedBytes": 67075776,
      "domNodes": -261,
      "jsHeapTotalBytes": 7311360,
      "scriptDurationMs": 1259.981,
      "eventListeners": -113,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8109.662000000015,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 49.43,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3625.114,
      "heapDeltaBytes": 10106036,
      "heapUsedBytes": 68548712,
      "domNodes": -267,
      "jsHeapTotalBytes": 2854912,
      "scriptDurationMs": 1234.005,
      "eventListeners": -113,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8182.5280000000475,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 52.05,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3944.2169999999996,
      "heapDeltaBytes": 22025500,
      "heapUsedBytes": 81841200,
      "domNodes": -263,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 1425.3580000000002,
      "eventListeners": -113,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12455.671999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12443.904999999997,
      "heapDeltaBytes": -31398448,
      "heapUsedBytes": 172244812,
      "domNodes": -8329,
      "jsHeapTotalBytes": -7540736,
      "scriptDurationMs": 580.9979999999999,
      "eventListeners": -16462,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.22666666666664,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11855.045000000018,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11844.819,
      "heapDeltaBytes": -31079512,
      "heapUsedBytes": 166245384,
      "domNodes": -8331,
      "jsHeapTotalBytes": 18149376,
      "scriptDurationMs": 577.4570000000001,
      "eventListeners": -16464,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 33.29999999999927
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12129.654999999957,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 12096.979,
      "heapDeltaBytes": -37919560,
      "heapUsedBytes": 174090820,
      "domNodes": -8339,
      "jsHeapTotalBytes": 19197952,
      "scriptDurationMs": 637.044,
      "eventListeners": -16466,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14167.624000000047,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 16.089999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14141.684000000001,
      "heapDeltaBytes": -50026604,
      "heapUsedBytes": 165519464,
      "domNodes": -8331,
      "jsHeapTotalBytes": -5267456,
      "scriptDurationMs": 869.322,
      "eventListeners": -16458,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14225.492999999915,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 16.46200000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14202.741999999998,
      "heapDeltaBytes": -58534480,
      "heapUsedBytes": 153608364,
      "domNodes": -8331,
      "jsHeapTotalBytes": -1773568,
      "scriptDurationMs": 860.66,
      "eventListeners": -16492,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14029.95999999996,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 15.996999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13984.184,
      "heapDeltaBytes": -25416828,
      "heapUsedBytes": 170107236,
      "domNodes": -8331,
      "jsHeapTotalBytes": 14655488,
      "scriptDurationMs": 877.3790000000001,
      "eventListeners": -16466,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 460.7869999999821,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 25.704,
      "layouts": 6,
      "layoutDurationMs": 1.689,
      "taskDurationMs": 127.28099999999998,
      "heapDeltaBytes": 5306584,
      "heapUsedBytes": 55672556,
      "domNodes": 164,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 26.439,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 464.3669999999247,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 25.887,
      "layouts": 5,
      "layoutDurationMs": 1.4349999999999998,
      "taskDurationMs": 128.255,
      "heapDeltaBytes": 5128260,
      "heapUsedBytes": 54990096,
      "domNodes": 159,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 26.982,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 465.1619999999639,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 23.032999999999998,
      "layouts": 5,
      "layoutDurationMs": 1.3349999999999997,
      "taskDurationMs": 122.90799999999999,
      "heapDeltaBytes": 5194328,
      "heapUsedBytes": 56373636,
      "domNodes": 157,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 29.522999999999996,
      "eventListeners": 69,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.799999999999727
    }
  ]
}

@codecov

codecov Bot commented Apr 17, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.48148% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/stores/electronDownloadStore.ts 80.70% 11 Missing ⚠️
...ponents/sidebar/tabs/modelLibrary/DownloadItem.vue 0.00% 10 Missing ⚠️
...missingModel/components/MissingModelStatusCard.vue 50.00% 3 Missing ⚠️
...idebar/tabs/modelLibrary/ElectronDownloadItems.vue 0.00% 2 Missing ⚠️
src/platform/missingModel/missingModelDownload.ts 77.77% 1 Missing and 1 partial ⚠️
...tform/missingModel/components/MissingModelCard.vue 93.33% 1 Missing ⚠️
...ngModel/composables/useMissingModelInteractions.ts 95.45% 1 Missing ⚠️
@@             Coverage Diff             @@
##             main   #11353       +/-   ##
===========================================
- Coverage   71.44%   57.50%   -13.95%     
===========================================
  Files        1492     1389      -103     
  Lines       86361    70880    -15481     
  Branches    24117    18895     -5222     
===========================================
- Hits        61703    40761    -20942     
- Misses      23763    29609     +5846     
+ Partials      895      510      -385     
Flag Coverage Δ
e2e ?
unit 57.50% <81.48%> (+1.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...atform/missingModel/components/MissingModelRow.vue 86.79% <100.00%> (+20.70%) ⬆️
src/platform/missingModel/missingModelStore.ts 88.95% <100.00%> (-3.59%) ⬇️
src/platform/missingModel/missingModelViewUtils.ts 100.00% <100.00%> (+4.76%) ⬆️
src/stores/executionErrorStore.ts 71.52% <ø> (-22.68%) ⬇️
...tform/missingModel/components/MissingModelCard.vue 98.00% <93.33%> (+16.96%) ⬆️
...ngModel/composables/useMissingModelInteractions.ts 83.41% <95.45%> (+21.23%) ⬆️
...idebar/tabs/modelLibrary/ElectronDownloadItems.vue 12.50% <0.00%> (-16.08%) ⬇️
src/platform/missingModel/missingModelDownload.ts 95.50% <77.77%> (+17.07%) ⬆️
...missingModel/components/MissingModelStatusCard.vue 67.74% <50.00%> (+40.15%) ⬆️
...ponents/sidebar/tabs/modelLibrary/DownloadItem.vue 5.71% <0.00%> (-3.38%) ⬇️
... and 1 more

... and 1002 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (2)
src/components/sidebar/tabs/modelLibrary/DownloadItem.vue (1)

6-14: ⚠️ Potential issue | 🟠 Major

Chip label is wrong for failed status — it currently says "cancelled" for both states.

The condition now matches 'cancelled' and 'failed', but the Chip body is hard-coded to t('electronFileDownload.cancelled'). A download that errored will be shown to the user as "cancelled," which is misleading and hides the real failure. Either split into two Chips or compute the label per status, and for failed surface download.error when available (mirroring how MissingModelStatusCard.vue handles the failed state).

🐛 Suggested fix
-    <div v-if="['cancelled', 'failed'].includes(download.status)">
-      <Chip
-        class="mt-2 h-6 bg-red-700 text-sm font-light"
-        removable
-        `@remove`="handleRemoveDownload"
-      >
-        {{ t('electronFileDownload.cancelled') }}
-      </Chip>
-    </div>
+    <div v-if="download.status === 'cancelled' || download.status === 'failed'">
+      <Chip
+        class="mt-2 h-6 bg-red-700 text-sm font-light"
+        removable
+        `@remove`="handleRemoveDownload"
+      >
+        {{
+          download.status === 'failed'
+            ? download.error || t('electronFileDownload.failed')
+            : t('electronFileDownload.cancelled')
+        }}
+      </Chip>
+    </div>

(Requires electronFileDownload.failed in src/locales/en/main.json.)

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/sidebar/tabs/modelLibrary/DownloadItem.vue` around lines 6 -
14, The Chip always shows t('electronFileDownload.cancelled') for both
'cancelled' and 'failed' statuses; update DownloadItem.vue to compute the label
based on download.status (e.g., if status === 'failed' use
t('electronFileDownload.failed') and include download.error when present,
otherwise use t('electronFileDownload.cancelled')), keeping the existing Chip
and `@remove`="handleRemoveDownload" behavior; mirror the pattern used in
MissingModelStatusCard.vue for showing the failure message and ensure you add
the new i18n key electronFileDownload.failed to locales/en/main.json.
src/stores/electronDownloadStore.ts (1)

29-57: ⚠️ Potential issue | 🟠 Major

!status guard is unsafe for numeric enums and returns overly pessimistic default.

The normalizeStatus function has two issues:

  1. Unsafe falsy check: if (!status) return 'failed' will short-circuit before the map lookup if status has a falsy runtime value. Numeric enums can have member 0 by default (e.g., DownloadStatus.PENDING = 0), and then !status returns true, causing the function to return 'failed' instead of using the map entry. Use status == null instead, which explicitly checks only for null and undefined and is safe for numeric enums.

  2. Incorrect fallback for legacy data: Returning 'failed' as the default for missing status contradicts the PR goal of tolerating legacy Electron snapshots that may omit the status field. Those should default to 'created' (initial lifecycle state), not be surfaced to the UI as a failure.

Proposed fix
   function normalizeStatus(
     status?: DownloadStatus,
     isPaused?: boolean
   ): ElectronDownload['status'] {
     if (isPaused || status === DownloadStatus.PAUSED) {
       return 'paused'
     }

-    if (!status) return 'failed'
+    if (status == null) return 'created'

     return desktopStatusToLifecycleStatus[status]
   }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/stores/electronDownloadStore.ts` around lines 29 - 57, The
normalizeStatus function incorrectly treats falsy numeric enum values (e.g.,
DownloadStatus.PENDING === 0) as missing and returns 'failed'; change the
missing-status check to use status == null (to only catch null/undefined) and,
for legacy/omitted status, return 'created' as the default lifecycle state;
ensure you still honor isPaused/DownloadStatus.PAUSED and then return
desktopStatusToLifecycleStatus[status] for valid enum values (refer to
normalizeStatus, desktopStatusToLifecycleStatus, and DownloadStatus).
🧹 Nitpick comments (9)
src/platform/missingModel/components/MissingModelStatusCard.vue (1)

6-11: Paused state doesn't show the progress fill.

isDownloadActive (derived in the parent as status === 'running' || status === 'created') is false while paused, so the progress bar fill at lines 7-11 disappears even though the text still shows X%. Minor UX inconsistency: consider also rendering the fill when downloadStatus?.status === 'paused' (possibly dimmed) so the user sees where the download is paused.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/components/MissingModelStatusCard.vue` around lines
6 - 11, The progress fill div is only rendered when isDownloadActive is true so
it disappears while paused; update the rendering condition to also show the fill
when downloadStatus?.status === 'paused' (e.g., change the v-if to include
paused) and add a conditional styling (class or inline style) to visually dim
the fill when paused (use downloadStatus?.status to toggle a muted class or
lower opacity) so the progress percentage and the bar remain consistent; target
the same element referencing isDownloadActive and downloadStatus to implement
this change.
src/platform/missingModel/components/MissingModelRow.vue (3)

287-305: Brief window between download start and UI update.

handleDownload awaits downloadModel(...) before writing store.downloadRefs[...]. On desktop, the electron runtime can emit the first onDownloadProgress callback (populating useElectronDownloadStore) before start() resolves. Between that emit and the downloadRefs write, the status card has no downloadRef to resolve against, so it stays hidden/inactive for a tick or two. If you want the "immediately active" UX described in the PR objectives to be truly immediate, consider writing downloadRefs optimistically before the await and rolling back on a falsy result:

💡 Suggested fix
 async function handleDownload() {
   const rep = model.representative
   if (rep.url && rep.directory) {
-    const started = await downloadModel(
-      { name: rep.name, url: rep.url, directory: rep.directory },
-      store.folderPaths
-    )
-
-    if (started) {
-      store.downloadRefs[modelKey.value] = {
-        kind: 'electron-download',
-        url: rep.url
-      }
-      handleComboSelect(modelKey.value, rep.name)
-    }
+    store.downloadRefs[modelKey.value] = {
+      kind: 'electron-download',
+      url: rep.url
+    }
+    handleComboSelect(modelKey.value, rep.name)
+    const started = await downloadModel(
+      { name: rep.name, url: rep.url, directory: rep.directory },
+      store.folderPaths
+    )
+    if (!started) {
+      delete store.downloadRefs[modelKey.value]
+    }
   } else {
     console.warn('[MissingModelRow] Cannot download: missing url or directory')
   }
 }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/components/MissingModelRow.vue` around lines 287 -
305, The handleDownload function can show a UI gap because it waits for
downloadModel(...) before setting store.downloadRefs; update handleDownload to
write an optimistic entry into store.downloadRefs[modelKey.value] (including
kind: 'electron-download' and url: rep.url and any minimal needed metadata)
immediately before calling await downloadModel(...), then call
handleComboSelect(modelKey.value, rep.name) as before; if downloadModel resolves
falsy or throws, remove/rollback that optimistic store.downloadRefs entry (and
handle errors) so the state stays consistent—use the existing symbols
handleDownload, downloadModel, store.downloadRefs, modelKey.value, rep.url, and
rep.name to locate and implement the change.

302-304: console.warn is user-invisible; missing url/directory should surface to the user.

If a user clicks Download and rep.url/rep.directory is unexpectedly missing, they currently get nothing but a dev-console warning. Consider surfacing an error state (e.g., via urlErrors[modelKey] or a toast) so the UX matches other failure paths, and/or asserting upstream that the Download button is only rendered when both are present (the downloadable computed already does this, so this branch should be unreachable — in which case the console.warn could be promoted to a thrown invariant).

As per coding guidelines: "Provide user-friendly and actionable error messages".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/components/MissingModelRow.vue` around lines 302 -
304, The branch logging with console.warn in MissingModelRow.vue when rep.url or
rep.directory are missing is user-invisible; replace it with a user-visible
failure path by either (A) setting a user-facing error state (e.g., populate
urlErrors[modelKey] or trigger the app's toast/notification) with a clear
message so the Download click shows feedback, or (B) if the downloadable
computed already guarantees this branch is unreachable, convert the console.warn
to a thrown invariant/error (throw new Error(...)) to fail fast. Update the
download handler (the function that checks rep.url/rep.directory and currently
logs via console.warn) to implement one of these two behaviors and reference the
downloadable computed and urlErrors[modelKey] when making the change.

307-310: Library-select while a direct download is in flight leaves the Electron download running.

handleLibraryModelSelect removes the downloadRefs entry, which hides the progress card, but the underlying Electron download (started via useElectronDownloadStore().start(...)) continues in the background. If the intent is for the user's new library selection to supersede the direct download, consider also calling useElectronDownloadStore().cancel(url) when the removed ref was of kind: 'electron-download'. If the intent is to leave it running (since the file will still land on disk), a brief inline comment would help future readers understand.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/components/MissingModelRow.vue` around lines 307 -
310, handleLibraryModelSelect currently deletes
store.downloadRefs[modelKey.value] which hides the UI but can leave an
underlying Electron download running; update handleLibraryModelSelect to first
capture the removed ref (from store.downloadRefs[modelKey.value]), and if that
ref exists and has kind === 'electron-download' call
useElectronDownloadStore().cancel(ref.url) before deleting the ref and then call
handleComboSelect(modelKey.value, value); alternatively if you intend to leave
the download running, add a brief inline comment in handleLibraryModelSelect
explaining that behavior.
src/stores/electronDownloadStore.test.ts (2)

48-51: flushStoreSetup's two awaits are brittle and under-documented.

The two-tick flush depends on the exact microtask shape of the store's async initialization (getAllDownloads().then(...) plus any awaited chain links). If that chain changes by even one tick, all three tests quietly see an empty downloads array and start producing misleading failures. Consider either:

  • awaiting a specific signal from the store (e.g., a ready promise / vi.waitFor(() => expect(mockGetAllDownloads).toHaveBeenCalled()) followed by resolution of that call), or
  • using vi.waitFor(() => expect(store.downloads.length).toBeGreaterThan(0)) in the normalization tests.

At minimum, add a short comment explaining what each tick accounts for so future readers don't have to reverse-engineer it.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/stores/electronDownloadStore.test.ts` around lines 48 - 51, The two
awaiting Promise.resolve() calls in flushStoreSetup are brittle; replace them
with a deterministic wait for the store's initialization instead of relying on
microtask ticks: update flushStoreSetup to await a specific readiness signal
(for example await store.ready or await vi.waitFor(() =>
expect(mockGetAllDownloads).toHaveBeenCalled())) or, if you choose the test-side
guard, use await vi.waitFor(() =>
expect(store.downloads.length).toBeGreaterThan(0)) in the normalization tests;
if you keep the two-tick approach at minimum add a concise comment inside
flushStoreSetup explaining which async steps each tick is waiting for (e.g.,
first tick waits for getAllDownloads() .then(), second tick waits for any
downstream awaits) and reference the getAllDownloads mock and store.downloads so
future readers can locate the relevant code.

12-25: Avoid duplicating the desktop download payload shape.

The inline shape for downloadProgressHandler's argument re-declares the DesktopDownloadSnapshot type already defined in electronDownloadStore.ts (which is itself derived from @comfyorg/comfyui-electron-types). If the store tightens or loosens its accepted shape, this test will drift silently. Prefer importing the real handler parameter type (or DesktopDownloadSnapshot) and using it here so the tests validate the actual contract.

Based on learnings: "In TypeScript test files, avoid duplicating interface/type definitions. Import real type definitions from the component modules under test and reference them directly, so there is a single source of truth and to prevent type drift."

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/stores/electronDownloadStore.test.ts` around lines 12 - 25, The test
currently re-declares the download payload shape for downloadProgressHandler;
instead import the real DesktopDownloadSnapshot (or the handler parameter type)
from the module where it's defined (electronDownloadStore.ts or its origin
`@comfyorg/comfyui-electron-types`) and use that imported type for
downloadProgressHandler's argument type so the test references the single
source-of-truth (e.g., replace the inline object type with
DesktopDownloadSnapshot and import it at top of the test).
src/platform/downloads/types.ts (1)

9-13: Document the progress contract.

The electron store normalizes progress to a 0..1 ratio (derived from receivedBytes/totalBytes when absent), while DownloadItem.vue multiplies by 100 to render a percentage. A short JSDoc on progress (e.g., @remarks 0..1) prevents future consumers from passing in a 0..100 percentage by mistake.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/downloads/types.ts` around lines 9 - 13, Add a short JSDoc to
the DownloadLifecycleState interface documenting the progress field's contract:
indicate progress is a ratio in the range 0..1 (derived from
receivedBytes/totalBytes by the electron store) and not a 0..100 percentage, and
mention that DownloadItem.vue expects this 0..1 value and multiplies by 100 for
display; annotate the progress property in DownloadLifecycleState to prevent
future consumers from passing percentages and clarify expected units and origin.
src/platform/missingModel/missingModelDownload.ts (1)

62-70: Non-desktop path returns true without knowing if the browser actually started the download.

The anchor-click pattern is fire-and-forget; the click may be suppressed (popup blockers, user gesture requirements, browser policy) without any observable signal. Returning an unconditional true is fine today because the non-desktop path doesn't rely on downloadRefs for progress, but it conflates "I dispatched the click" with "download started." Consider documenting this via the type or a comment so callers don't later use started to drive UI state that assumes real progress will follow.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/missingModelDownload.ts` around lines 62 - 70, The
non-desktop branch uses an anchor click and then returns Promise.resolve(true),
which conflates "click dispatched" with "download actually started"; update the
code around the isDesktop branch (where model is used and Promise.resolve(true)
is returned) to document this behavior—add a concise comment and/or JSDoc on the
surrounding function (and adjust the return type description) stating that the
boolean true only means the download click was dispatched and may not reflect an
actual started download (mention downloadRefs in the comment as not being relied
on in this path).
src/platform/missingModel/composables/useMissingModelInteractions.ts (1)

282-301: Consider symmetric field extraction between the two branches for consistency.

The asset-import branch explicitly projects to { progress, status, error }, while the electron-download branch returns the full ElectronDownload object (including url, filename, savePath). Functionally this works because the extra fields are ignored by the MissingModelDownloadStatus consumers, but the asymmetry can confuse readers and leaks store-internal fields through the composable. Projecting explicitly in both branches also makes the contract match the declared return type.

♻️ Proposed refactor
-    return electronDownloadStore.findByUrl(downloadRef.url) ?? null
+    const electronDownload = electronDownloadStore.findByUrl(downloadRef.url)
+    return electronDownload
+      ? {
+          progress: electronDownload.progress,
+          status: electronDownload.status,
+          error: electronDownload.error
+        }
+      : null
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/composables/useMissingModelInteractions.ts` around
lines 282 - 301, getDownloadStatus currently returns a projected
{progress,status,error} for the 'asset-import' branch but returns the full
ElectronDownload object for other branches, leaking extra fields; update the
non-asset branch in getDownloadStatus to map the
electronDownloadStore.findByUrl(...) result to the same
MissingModelDownloadStatus shape (explicitly return { progress:
electron.progress, status: electron.status, error: electron.error } or
equivalent) so both branches return the same projected fields and match the
declared return type.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/components/sidebar/tabs/modelLibrary/DownloadItem.vue`:
- Around line 15-18: The UI block in DownloadItem.vue currently only shows for
download.status values ['running','paused','completed'], leaving downloads in
the 'created' state (mapped from DownloadStatus.PENDING) invisible; update the
v-if logic to also handle 'created' (or DownloadStatus.PENDING) so newly created
downloads show UI — either by adding 'created' to the array or by branching to
render an indeterminate progress indicator when download.status === 'created'
(keep the same controls/progress block names so the DOM structure stays
consistent).

In `@src/platform/missingModel/missingModelDownload.ts`:
- Around line 72-79: The electronDownloadStore.start function currently has no
explicit return type; update its signature in electronDownloadStore (the start
method that calls DownloadManager.startDownload) to annotate the return type
explicitly—either as ReturnType<typeof DownloadManager.startDownload> or as
Promise<boolean>—so callers like MissingModelRow.vue (which checks if (started))
have a stable, enforced contract and TypeScript will catch any future drift from
the underlying DownloadManager.startDownload behavior.

---

Outside diff comments:
In `@src/components/sidebar/tabs/modelLibrary/DownloadItem.vue`:
- Around line 6-14: The Chip always shows t('electronFileDownload.cancelled')
for both 'cancelled' and 'failed' statuses; update DownloadItem.vue to compute
the label based on download.status (e.g., if status === 'failed' use
t('electronFileDownload.failed') and include download.error when present,
otherwise use t('electronFileDownload.cancelled')), keeping the existing Chip
and `@remove`="handleRemoveDownload" behavior; mirror the pattern used in
MissingModelStatusCard.vue for showing the failure message and ensure you add
the new i18n key electronFileDownload.failed to locales/en/main.json.

In `@src/stores/electronDownloadStore.ts`:
- Around line 29-57: The normalizeStatus function incorrectly treats falsy
numeric enum values (e.g., DownloadStatus.PENDING === 0) as missing and returns
'failed'; change the missing-status check to use status == null (to only catch
null/undefined) and, for legacy/omitted status, return 'created' as the default
lifecycle state; ensure you still honor isPaused/DownloadStatus.PAUSED and then
return desktopStatusToLifecycleStatus[status] for valid enum values (refer to
normalizeStatus, desktopStatusToLifecycleStatus, and DownloadStatus).

---

Nitpick comments:
In `@src/platform/downloads/types.ts`:
- Around line 9-13: Add a short JSDoc to the DownloadLifecycleState interface
documenting the progress field's contract: indicate progress is a ratio in the
range 0..1 (derived from receivedBytes/totalBytes by the electron store) and not
a 0..100 percentage, and mention that DownloadItem.vue expects this 0..1 value
and multiplies by 100 for display; annotate the progress property in
DownloadLifecycleState to prevent future consumers from passing percentages and
clarify expected units and origin.

In `@src/platform/missingModel/components/MissingModelRow.vue`:
- Around line 287-305: The handleDownload function can show a UI gap because it
waits for downloadModel(...) before setting store.downloadRefs; update
handleDownload to write an optimistic entry into
store.downloadRefs[modelKey.value] (including kind: 'electron-download' and url:
rep.url and any minimal needed metadata) immediately before calling await
downloadModel(...), then call handleComboSelect(modelKey.value, rep.name) as
before; if downloadModel resolves falsy or throws, remove/rollback that
optimistic store.downloadRefs entry (and handle errors) so the state stays
consistent—use the existing symbols handleDownload, downloadModel,
store.downloadRefs, modelKey.value, rep.url, and rep.name to locate and
implement the change.
- Around line 302-304: The branch logging with console.warn in
MissingModelRow.vue when rep.url or rep.directory are missing is user-invisible;
replace it with a user-visible failure path by either (A) setting a user-facing
error state (e.g., populate urlErrors[modelKey] or trigger the app's
toast/notification) with a clear message so the Download click shows feedback,
or (B) if the downloadable computed already guarantees this branch is
unreachable, convert the console.warn to a thrown invariant/error (throw new
Error(...)) to fail fast. Update the download handler (the function that checks
rep.url/rep.directory and currently logs via console.warn) to implement one of
these two behaviors and reference the downloadable computed and
urlErrors[modelKey] when making the change.
- Around line 307-310: handleLibraryModelSelect currently deletes
store.downloadRefs[modelKey.value] which hides the UI but can leave an
underlying Electron download running; update handleLibraryModelSelect to first
capture the removed ref (from store.downloadRefs[modelKey.value]), and if that
ref exists and has kind === 'electron-download' call
useElectronDownloadStore().cancel(ref.url) before deleting the ref and then call
handleComboSelect(modelKey.value, value); alternatively if you intend to leave
the download running, add a brief inline comment in handleLibraryModelSelect
explaining that behavior.

In `@src/platform/missingModel/components/MissingModelStatusCard.vue`:
- Around line 6-11: The progress fill div is only rendered when isDownloadActive
is true so it disappears while paused; update the rendering condition to also
show the fill when downloadStatus?.status === 'paused' (e.g., change the v-if to
include paused) and add a conditional styling (class or inline style) to
visually dim the fill when paused (use downloadStatus?.status to toggle a muted
class or lower opacity) so the progress percentage and the bar remain
consistent; target the same element referencing isDownloadActive and
downloadStatus to implement this change.

In `@src/platform/missingModel/composables/useMissingModelInteractions.ts`:
- Around line 282-301: getDownloadStatus currently returns a projected
{progress,status,error} for the 'asset-import' branch but returns the full
ElectronDownload object for other branches, leaking extra fields; update the
non-asset branch in getDownloadStatus to map the
electronDownloadStore.findByUrl(...) result to the same
MissingModelDownloadStatus shape (explicitly return { progress:
electron.progress, status: electron.status, error: electron.error } or
equivalent) so both branches return the same projected fields and match the
declared return type.

In `@src/platform/missingModel/missingModelDownload.ts`:
- Around line 62-70: The non-desktop branch uses an anchor click and then
returns Promise.resolve(true), which conflates "click dispatched" with "download
actually started"; update the code around the isDesktop branch (where model is
used and Promise.resolve(true) is returned) to document this behavior—add a
concise comment and/or JSDoc on the surrounding function (and adjust the return
type description) stating that the boolean true only means the download click
was dispatched and may not reflect an actual started download (mention
downloadRefs in the comment as not being relied on in this path).

In `@src/stores/electronDownloadStore.test.ts`:
- Around line 48-51: The two awaiting Promise.resolve() calls in flushStoreSetup
are brittle; replace them with a deterministic wait for the store's
initialization instead of relying on microtask ticks: update flushStoreSetup to
await a specific readiness signal (for example await store.ready or await
vi.waitFor(() => expect(mockGetAllDownloads).toHaveBeenCalled())) or, if you
choose the test-side guard, use await vi.waitFor(() =>
expect(store.downloads.length).toBeGreaterThan(0)) in the normalization tests;
if you keep the two-tick approach at minimum add a concise comment inside
flushStoreSetup explaining which async steps each tick is waiting for (e.g.,
first tick waits for getAllDownloads() .then(), second tick waits for any
downstream awaits) and reference the getAllDownloads mock and store.downloads so
future readers can locate the relevant code.
- Around line 12-25: The test currently re-declares the download payload shape
for downloadProgressHandler; instead import the real DesktopDownloadSnapshot (or
the handler parameter type) from the module where it's defined
(electronDownloadStore.ts or its origin `@comfyorg/comfyui-electron-types`) and
use that imported type for downloadProgressHandler's argument type so the test
references the single source-of-truth (e.g., replace the inline object type with
DesktopDownloadSnapshot and import it at top of the test).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c9480dcd-de0f-485d-bc30-ff5f324e5085

📥 Commits

Reviewing files that changed from the base of the PR and between ecb7fd4 and 03a8971.

📒 Files selected for processing (14)
  • src/components/sidebar/tabs/modelLibrary/DownloadItem.vue
  • src/platform/downloads/types.ts
  • src/platform/missingModel/components/MissingModelRow.test.ts
  • src/platform/missingModel/components/MissingModelRow.vue
  • src/platform/missingModel/components/MissingModelStatusCard.vue
  • src/platform/missingModel/composables/useMissingModelInteractions.test.ts
  • src/platform/missingModel/composables/useMissingModelInteractions.ts
  • src/platform/missingModel/missingModelDownload.test.ts
  • src/platform/missingModel/missingModelDownload.ts
  • src/platform/missingModel/missingModelStore.ts
  • src/platform/missingModel/types.ts
  • src/stores/electronDownloadStore.test.ts
  • src/stores/electronDownloadStore.ts
  • src/stores/executionErrorStore.ts

Comment on lines 15 to 18
<div
v-if="
['in_progress', 'paused', 'completed'].includes(download.status ?? '')
"
v-if="['running', 'paused', 'completed'].includes(download.status)"
class="mt-2 flex flex-row items-center gap-2"
>

@coderabbitai coderabbitai Bot Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

created downloads have no visible UI.

The controls/progress block now renders only for running, paused, and completed. A download in the created state (mapped from DownloadStatus.PENDING) will render nothing under the save-path row — no progress bar, no controls — which may confuse users who just initiated a download. If this is intentional (created is considered transient), consider rendering at least an indeterminate progress indicator; otherwise add 'created' to the list.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/sidebar/tabs/modelLibrary/DownloadItem.vue` around lines 15 -
18, The UI block in DownloadItem.vue currently only shows for download.status
values ['running','paused','completed'], leaving downloads in the 'created'
state (mapped from DownloadStatus.PENDING) invisible; update the v-if logic to
also handle 'created' (or DownloadStatus.PENDING) so newly created downloads
show UI — either by adding 'created' to the array or by branching to render an
indeterminate progress indicator when download.status === 'created' (keep the
same controls/progress block names so the DOM structure stays consistent).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in eaa09fa: created is now included in the active progress block condition, so pending Electron downloads render the progress UI instead of only showing the save-path row.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benceruleanlu, thanks for the update! Confirmed — adding 'created' to the v-if list ensures that downloads in the initial pending state immediately show the progress bar, giving users visual feedback as soon as a download is initiated.


🧠 Learnings used
Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 7297
File: src/components/actionbar/ComfyActionbar.vue:33-43
Timestamp: 2025-12-09T21:40:12.361Z
Learning: In Vue single-file components, allow inline Tailwind CSS class strings for static classes and avoid extracting them into computed properties solely for readability. Prefer keeping static class names inline for simplicity and performance. For dynamic or conditional classes, use Vue bindings (e.g., :class) to compose classes.

Applies to all Vue files in the repository (e.g., src/**/*.vue) where Tailwind utilities are used for static styling.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.vue:17-17
Timestamp: 2025-12-16T22:26:49.463Z
Learning: In Vue 3.5+ with <script setup>, when using defineProps<Props>() with partial destructuring (e.g., const { as = 'button', class: customClass = '' } = defineProps<Props>() ), props that are not destructured (e.g., variant, size) stay accessible by name in the template scope. This pattern is valid: you can destructure only a subset of props for convenience while referencing the remaining props directly in template expressions. Apply this guideline to Vue components across the codebase (all .vue files).

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7598
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:131-131
Timestamp: 2025-12-18T02:07:38.870Z
Learning: Tailwind CSS v4 safe utilities (e.g., items-center-safe, justify-*-safe, place-*-safe) are allowed in Vue components under src/ and in story files. Do not flag these specific safe variants as invalid when reviewing code in src/**/*.vue or related stories.

Learnt from: henrikvilhelmberglund
Repo: Comfy-Org/ComfyUI_frontend PR: 7617
File: src/components/actionbar/ComfyActionbar.vue:301-308
Timestamp: 2025-12-18T16:03:02.066Z
Learning: In the ComfyUI frontend queue system, useQueuePendingTaskCountStore().count indicates the number of tasks in the queue, where count = 1 means a single active/running task and count > 1 means there are pending tasks in addition to the active task. Therefore, in src/components/actionbar/ComfyActionbar.vue, enable the 'Clear Pending Tasks' button only when count > 1 to avoid clearing the currently running task. The active task should be canceled using the 'Cancel current run' button instead. This rule should be enforced via a conditional check on the queue count, with appropriate disabled/aria-disabled states for accessibility, and tests should verify behavior for count = 1 and count > 1.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7603
File: src/components/queue/QueueOverlayHeader.vue:49-59
Timestamp: 2025-12-18T21:15:46.862Z
Learning: In the ComfyUI_frontend repository, for Vue components, do not add aria-label to buttons that have visible text content (e.g., buttons containing <span> text). The visible text provides the accessible name. Use aria-label only for elements without visible labels (e.g., icon-only buttons). If a button has no visible label, provide a clear aria-label or associate with an aria-labelledby describing its action.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/components/graph/selectionToolbox/ColorPickerButton.vue:15-18
Timestamp: 2025-12-21T01:06:02.786Z
Learning: In Comfy-Org/ComfyUI_frontend, in Vue component files, when a filled icon is required (e.g., 'pi pi-circle-fill'), you may mix PrimeIcons with Lucide icons since Lucide lacks filled variants. This mixed usage is acceptable when one icon library does not provide an equivalent filled icon. Apply consistently across Vue components in the src directory where icons are used, and document the rationale when a mixed approach is chosen.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7649
File: src/platform/cloud/subscription/components/PricingTable.vue:185-201
Timestamp: 2025-12-22T21:36:08.369Z
Learning: In Vue components, avoid creating single-use variants for common UI components (e.g., Button and other shared components). Aim for reusable variants that cover multiple use cases. It’s acceptable to temporarily mix variant props with inline Tailwind classes when a styling need is unique to one place, but plan and consolidate into shared, reusable variants as patterns emerge across the codebase.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7893
File: src/components/button/IconGroup.vue:5-6
Timestamp: 2026-01-08T02:26:18.357Z
Learning: In components that use the cn utility from '@/utils/tailwindUtil' with tailwind-merge, rely on the behavior that conflicting Tailwind classes are resolved by keeping the last one. For example, cn('base-classes bg-default', propClass) will have any conflicting background class from propClass override bg-default. This additive pattern is intentional and aligns with the shadcn-ui convention; ensure you document or review expectations accordingly in Vue components.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8195
File: src/platform/assets/components/MediaAssetFilterBar.vue:16-16
Timestamp: 2026-01-21T01:28:27.626Z
Learning: In Vue templates (Vue 3.4+ with the build step), when binding to data or props that are camelCase (e.g., mediaTypeFilters), you can use kebab-case in the template bindings (e.g., :media-type-filters). This is acceptable and will resolve to the corresponding camelCase variable. Do not require CamelCase in template bindings.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8090
File: src/platform/assets/components/modelInfo/ModelInfoField.vue:8-11
Timestamp: 2026-01-22T02:28:58.105Z
Learning: In Vue 3 script setup, props defined with defineProps are automatically available by name in the template without destructuring. Destructuring the result of defineProps inside script can break reactivity; prefer accessing props by name in the template. If you need to use props in the script, reference them via the defined props object rather than destructuring, or use toRefs when you intend to destructure while preserving reactivity.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8497
File: src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDropdown.vue:223-236
Timestamp: 2026-02-01T21:10:29.567Z
Learning: In Vue single-file components, do not review or require edits to comments. Favor self-documenting code through clear naming, strong types, and explicit APIs. If a comment is misleading or outdated, consider removing it, but avoid suggesting adding or fixing comments. This guideline aligns with preferring code clarity over comment maintenance across all .vue files.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 8592
File: src/components/topbar/WorkflowExecutionIndicator.vue:28-28
Timestamp: 2026-02-03T21:35:40.889Z
Learning: In Vue single-file components where the i18n t function is only used within the template, prefer using the built-in $t in the template instead of importing useI18n and destructuring t in the script. This avoids unnecessary imports when t is not used in the script. If you need i18n in the script (Composition API), only then use useI18n and access t from its returned object. Ensure this pattern applies to all Vue components with template-only i18n usage.

Learnt from: Yourz
Repo: Comfy-Org/ComfyUI_frontend PR: 8548
File: src/components/common/TreeExplorerV2.vue:2-89
Timestamp: 2026-02-07T14:46:21.179Z
Learning: In Vue components (e.g., TreeExplorerV2.vue and similar Recka UI components) avoid wrapping ContextMenuRoot with a dynamic <component :is="..."> and rendering alternative branches. Use v-if / v-else to render separate ContextMenuRoot and non-ContextMenuRoot branches to ensure correct behavior with Reka UI, even if it duplicates some tree structure. This guideline applies to Vue components under src/components and can be checked by ensuring there is a dedicated render path for the ContextMenuRoot without dynamic component switching.

Learnt from: Yourz
Repo: Comfy-Org/ComfyUI_frontend PR: 8548
File: src/components/common/TreeExplorerV2Node.vue:9-47
Timestamp: 2026-02-07T14:47:06.751Z
Learning: In all Vue files that render Reka UI context menu components (ContextMenuRoot, ContextMenuTrigger, etc.), avoid dynamic component wrapping with <component :is="...">. Use conditional rendering with v-if / v-else to render separate branches, even if it results in some template duplication. This improves readability and maintainability across files that use these components.

Learnt from: Yourz
Repo: Comfy-Org/ComfyUI_frontend PR: 8548
File: src/components/common/TreeExplorerV2.vue:3-5
Timestamp: 2026-02-08T16:04:58.463Z
Learning: In TreeExplorerV2.vue and similar Re- ka UI Tree components, avoid defensive copies in bindings like :expanded="[...expandedKeys]". Use v-model:expanded="expandedKeys" instead. TreeRoot follows Vue's controlled component pattern and emits update:expanded with the new array; it does not mutate the passed array. Defensive copies break reactivity and can desynchronize state. Ensure components rely on update:expanded and do not mutate input arrays.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8753
File: src/renderer/extensions/vueNodes/widgets/components/WidgetDOM.vue:17-28
Timestamp: 2026-02-09T03:24:47.113Z
Learning: When destructuring reactive properties from Pinia stores in Vue components, use storeToRefs() to preserve reactivity. Example: const store = useCanvasStore(); const { canvas } = storeToRefs(store); access as canvas.value (e.g., canvas.value). Ensure you import storeToRefs from 'pinia' and use it wherever you destructure store properties in the setup function.

Learnt from: Myestery
Repo: Comfy-Org/ComfyUI_frontend PR: 8761
File: src/components/dialog/content/MissingModelsWarning.vue:21-27
Timestamp: 2026-02-10T00:58:07.904Z
Learning: In the ComfyUI_frontend Vue codebase, replace raw <button> HTML elements with the shared Button component located at src/components/ui/button/Button.vue. Import and use it with appropriate variants (e.g., variant="link") to align with the design system. Apply this pattern across Vue components under src/components, ensuring consistent styling and behavior instead of ad-hoc button markup.

Learnt from: pythongosssss
Repo: Comfy-Org/ComfyUI_frontend PR: 8775
File: src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue:62-68
Timestamp: 2026-02-10T17:59:25.893Z
Learning: In Vue 3 single-file components, code defined outside the script setup scope cannot access variables or helpers defined inside setup. If a default function (e.g., defineModel) is hoisted outside script setup, it will not be able to call setup helpers or reference setup-scoped variables. Place such logic inside setup or expose necessary values via returns/defineExpose to be accessible.

Learnt from: Yourz
Repo: Comfy-Org/ComfyUI_frontend PR: 9085
File: src/components/sidebar/tabs/NodeLibrarySidebarTabV2.vue:45-50
Timestamp: 2026-02-27T09:39:47.145Z
Learning: In Vue components that use Reka UI primitives such as DropdownMenuTrigger and SelectTrigger with as-child, it is acceptable to render a raw <button> when the styling is context-specific and there is no existing Button variant to map to. The as-child pattern preserves accessibility while enabling composition. Do not create single-use Button variants for these cases; prefer inline styling with a raw button for clarity and to avoid unnecessary abstraction. This guideline applies to all Vue components (files ending in .vue) in projects using Reka UI.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 9427
File: src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuFilter.vue:33-33
Timestamp: 2026-03-06T00:53:28.835Z
Learning: When reviewing code, note that the enforce-canonical-classes (better-tailwindcss) rule may auto-fix Tailwind v3 !class-name syntax by converting it to v4 class-name! syntax. Do not treat these auto-fixed class-name! instances as newly introduced issues; the perceived change is in syntax placement, not in usage or intent. This guidance applies across all .vue and .ts files in the repository.

Learnt from: sonnybox
Repo: Comfy-Org/ComfyUI_frontend PR: 9446
File: src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue:45-45
Timestamp: 2026-03-06T01:55:00.013Z
Learning: Treat wrap-break-word as a valid Tailwind CSS utility for overflow-wrap: break-word in Tailwind v4+ projects. Do not flag this class as invalid in any Vue (.vue) or TypeScript (.ts/.tsx) files within the repository (e.g., Comfy-Org/ComfyUI_frontend) or other Tailwind v4+ projects. When reviewing, verify that the class is used to enable word breaking in long text content and reference the Tailwind docs: https://tailwindcss.com/docs/overflow-wrap.

Learnt from: pythongosssss
Repo: Comfy-Org/ComfyUI_frontend PR: 9511
File: src/components/common/WorkflowActionsDropdown.vue:53-60
Timestamp: 2026-03-06T22:05:25.071Z
Learning: When using PrimeVue's v-tooltip in Vue components, be aware of a known bug where the tooltip centers on the trigger. If positioning requires a left-anchored placement, it may be acceptable and necessary to apply a deliberate workaround (e.g., adjust root transform with translateX(calc(50% - 16px)) and reposition the tooltip arrow with left utilities) rather than flagging as fragile or using !important. This pattern may appear in multiple Vue components under src/components/ that use v-tooltip; apply the same left-anchoring adjustment where appropriate and document the rationale so future maintainers understand the intentional workaround.

Learnt from: benceruleanlu
Repo: Comfy-Org/ComfyUI_frontend PR: 9749
File: src/platform/assets/components/MediaAssetContextMenu.vue:88-93
Timestamp: 2026-03-11T19:12:43.621Z
Learning: For Vue components using PrimeVue ContextMenu, the root element merges all passthrough attributes via v-bind="ptmi('root')". Passing an id through :pt="{ root: { id: someId } }" will reliably set the root element's id, allowing document.getElementById(someId) to reference the overlay. Do not flag this pattern as unreliable in reviews for components using PrimeVue ContextMenu with pt.root.id passthrough (e.g., src/platform/assets/components/MediaAssetContextMenu.vue).

Learnt from: Yourz
Repo: Comfy-Org/ComfyUI_frontend PR: 9965
File: src/platform/cloud/onboarding/CloudSubscriptionRedirectView.vue:77-79
Timestamp: 2026-03-15T15:24:17.291Z
Learning: Maintain narrowly scoped PRs by limiting changes to the stated fix within a single PR. Do not bundle cross-file refactors (e.g., adding concurrency guards across composables like useBillingContext) into a targeted bug-fix PR; instead propose these as separate follow-up issues or PRs. This guidance applies to Vue components (e.g., CloudSubscriptionRedirectView.vue) and other files across the repository. When a change touches multiple files or concerns broader architecture, split into separate, well-scoped PRs to improve reviewability and risk assessment.

Learnt from: jaeone94
Repo: Comfy-Org/ComfyUI_frontend PR: 10135
File: src/components/rightSidePanel/errors/TabErrors.vue:288-295
Timestamp: 2026-03-17T07:02:53.709Z
Learning: In TabErrors.vue, ensure the guard used for the singleRuntimeErrorGroup relies on some((e) => e.isRuntimeError) to detect a runtime error among the runtime/validation error cards. Do not switch to every() as that would be overly restrictive given the backend’s mutual exclusion: a run either yields a runtime error or a set of validation errors. This guidance applies to Vue components in the src/components directory (generalized to all .vue files under src/components).

Learnt from: eliheuer
Repo: Comfy-Org/ComfyUI_frontend PR: 11317
File: src/components/appMode/layout/cells/FeedbackCell.vue:0-0
Timestamp: 2026-04-28T07:02:16.613Z
Learning: In Vue SFCs (files under src/**/*.vue), avoid using Tailwind “important” modifiers (`!`, e.g., `!bg-*`, `!text-*`). For overrides that are truly needed, prefer defining/overriding styles in the component’s scoped <style> block using Vue’s `:deep()` selectors instead of relying on Tailwind `!` (e.g., follow the approach used in FeedbackCell.vue and ModeToggleCell.vue).

Learnt from: eliheuer
Repo: Comfy-Org/ComfyUI_frontend PR: 11317
File: src/components/appMode/layout/cells/IconCell.vue:8-37
Timestamp: 2026-04-28T07:02:32.365Z
Learning: For Vue components under src/components/**, prefer emitting events (e.g., this.$emit('activate')) to notify parents about state changes/interactions instead of using callback props (e.g., an onActivate prop). In parent components, bind listeners with the event syntax (activate), not with props-style binding (e.g., :on-activate).

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

Comment on lines 72 to 79
const modelPaths = paths[model.directory]
if (modelPaths?.[0]) {
void useElectronDownloadStore().start({
return useElectronDownloadStore().start({
url: model.url,
savePath: modelPaths[0],
filename: model.name
})
}

@coderabbitai coderabbitai Bot Apr 17, 2026 •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Inspect the electron-types declaration for DownloadManager.startDownload
fd -t f 'index.d.ts' -p 'comfyui-electron-types' 2>/dev/null | head
rg -nP --type=ts -C3 '\bstartDownload\s*\(' -g '!**/node_modules/**'
rg -nP -C5 'DownloadManager' -g 'package.json' | head -40
# Also check the store's start() usage in tests
rg -nP --type=ts -C4 '\.start\s*\(' -g 'src/stores/electronDownloadStore*.ts'
rg -nP --type=ts -C2 'mockStartDownload'

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1434


🏁 Script executed:

# First, examine electronDownloadStore.ts to see the start() method and its return type
head -150 src/stores/electronDownloadStore.ts | tail -40

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 949


🏁 Script executed:

# Check what DownloadManager types are and where they're imported from
rg -n 'DownloadManager' src/stores/electronDownloadStore.ts | head -20

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 618


🏁 Script executed:

# Look at the full start() method implementation
sed -n '120,140p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 539


🏁 Script executed:

# Check MissingModelRow.vue for the handleDownload usage
rg -n -A 10 'handleDownload' src/components/MissingModelRow.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 144


🏁 Script executed:

# Find MissingModelRow.vue
fd -t f 'MissingModelRow' src/

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 187


🏁 Script executed:

# Find where electronAPI is defined and what DownloadManager types are
rg -n 'electronAPI' src/stores/electronDownloadStore.ts -A 2 -B 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 519


🏁 Script executed:

# Search for DownloadManager type definition or `@comfyorg/comfyui-electron-types`
rg -n '@comfyorg/comfyui-electron-types' | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 566


🏁 Script executed:

# Check package.json for electron-types version
rg -n 'comfyui-electron-types' package.json

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 124


🏁 Script executed:

# Check MissingModelRow.vue to see handleDownload and how it uses started
rg -n -A 20 'handleDownload' src/platform/missingModel/components/MissingModelRow.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1534


🏁 Script executed:

# Look at the electronAPI setup in envUtil
fd -t f 'envUtil' src/ | xargs cat -n | head -100

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 842


🏁 Script executed:

# Check if there's a type declaration for DownloadManager in the repo
rg -n 'interface DownloadManager\|type DownloadManager' --type ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look for electronAPI type definition
rg -n 'interface ElectronAPI\|type ElectronAPI' --type ts | head -20

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Get the full downloadModel function to see its declared return type
sed -n '60,85p' src/platform/missingModel/missingModelDownload.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 660


🏁 Script executed:

# Search for the full function signature
rg -n -B 5 'const modelPaths = paths' src/platform/missingModel/missingModelDownload.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 223


🏁 Script executed:

# Look for any type stubs or d.ts files that might declare DownloadManager
fd -t f '\\.d\\.ts$' | xargs grep -l 'DownloadManager\|startDownload' 2>/dev/null | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check the actual electron-types package in node_modules or check catalog
rg -n 'startDownload' --type ts -g '*electron*' | head -20

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 257


🏁 Script executed:

# Check the test file to see what mockStartDownload is configured to return
cat -n src/stores/electronDownloadStore.test.ts | head -100

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3536


🏁 Script executed:

# Check if there's any tsconfig or type checking config that might affect electron-types
cat -n tsconfig.json | head -50

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1781


🏁 Script executed:

# Look for any setup or test utilities that mock DownloadManager
rg -n 'vi.fn\|mockStartDownload' src/stores/electronDownloadStore.test.ts -A 3

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check if start() is used/tested anywhere to see what callers expect it to return
rg -n 'store\.start\|\.start\(' src/platform/missingModel/ -A 2 -B 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look at the full test to see if mockStartDownload is set to return anything
cat -n src/stores/electronDownloadStore.test.ts | sed -n '1,200p'

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 5148


🏁 Script executed:

# Search for where start() is actually called and awaited to understand expected behavior
rg -n 'useElectronDownloadStore\(\)\.start\|store\.start' -A 3 -B 1

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check if there's a pnpm-lock or package-lock that shows electron-types version
rg -n '"@comfyorg/comfyui-electron-types"' pnpm-lock.yaml | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look for any other tests that use start() to see what return value is expected
rg -n '\.start\(' src/stores/electronDownloadStore.test.ts -A 5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check the full electronDownloadStore.ts file around the start() definition to see if there's a return type annotation
sed -n '125,145p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 589


🏁 Script executed:

# Get the entire return statement object to see if start is explicitly typed
sed -n '130,155p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 612


🏁 Script executed:

# Search for any .d.ts type definitions in src/types or similar
fd -t f '\\.d\\.ts' src/types/ 2>/dev/null | xargs cat

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check if electronAPI type is extended or typed anywhere in the repo
rg -n 'ElectronAPI\|DownloadManager' src/types/ -A 5 2>/dev/null

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check missingModelDownload.ts to see the complete downloadModel function and its return type
sed -n '55,85p' src/platform/missingModel/missingModelDownload.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 731


🏁 Script executed:

# Look for any return type issues - check if TypeScript reports errors on start() return
rg -n 'return.*start\(' src/platform/missingModel/ -B 2 -A 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 502


🏁 Script executed:

# Search for documentation or usage of startDownload that hints at its return type
rg -n 'startDownload\|DownloadManager' src/ --type ts -A 1 | head -50

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Try to find the actual electron-types installation to check startDownload signature
find . -path '*/node_modules/@comfyorg/comfyui-electron-types*' -name '*.d.ts' 2>/dev/null | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check how downloadModel is tested
rg -n 'downloadModel' src/platform/missingModel/ --type ts -A 5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3738


🏁 Script executed:

# Look for any test files for missingModelDownload
fd -t f 'missingModelDownload' src/

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 174


🏁 Script executed:

# Check if there's a test that covers the start() call and what value it should return
rg -n 'mockStartDownload\.mockResolvedValue\|mockStartDownload\.mockReturnValue' src/

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check the entire electronDownloadStore to see the full return type definition
cat -n src/stores/electronDownloadStore.ts | tail -100

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 3138


🏁 Script executed:

# Check the missingModelDownload test to see what mockStartElectronDownload is configured to return
sed -n '199,270p' src/platform/missingModel/missingModelDownload.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1949


🏁 Script executed:

# Look for mockStartElectronDownload setup
rg -n 'mockStartElectronDownload' src/platform/missingModel/missingModelDownload.test.ts -B 2 -A 5 | head -40

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 1192


🏁 Script executed:

# Check if DownloadManager is imported from `@comfyorg/comfyui-electron-types` in node_modules
cat pnpm-lock.yaml | grep -A 20 '@comfyorg/comfyui-electron-types' | head -30

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 848


🏁 Script executed:

# Search for any explicit return type annotation on start() in electronDownloadStore
rg -n 'start.*:' src/stores/electronDownloadStore.ts | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look for the exact type definition - check if there's a `@ts-expect-error` or type assertions
rg -n '@ts-' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Get the full test setup to understand what mockStartElectronDownload is mocking
sed -n '1,30p' src/platform/missingModel/missingModelDownload.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 790


🏁 Script executed:

# Check whether start() is explicitly typed in any way by looking at the full method definition with context
sed -n '120,150p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 716


🏁 Script executed:

# Check if there are any other usages of startDownload or the store.start() that hint at return type
rg -n 'await.*\.start\|store\.start' src/ --type ts -B 2 -A 2

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look for TypeScript error output or build logs that might indicate type mismatches
find . -name 'tsconfig*.json' -o -name '.tsbuildinfo' 2>/dev/null

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 8242


🏁 Script executed:

# Check if there's any documentation or comments about DownloadManager.startDownload
rg -n 'startDownload' src/ --type ts -B 5 | grep -A 5 -B 5 'return\|Promise\|boolean'

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Get a comprehensive view of all usages of store methods to understand expected return types
sed -n '124,150p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 690


🏁 Script executed:

# Check if electron-types is available in node_modules and inspect its type definitions
find node_modules -path '*comfyui-electron-types*' -name '*.d.ts' 2>/dev/null | head -5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Try a different approach - look at the actual package location
ls -la node_modules/@comfyorg/comfyui-electron-types/ 2>/dev/null | head -20

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check package.json to see where the types point to
cat node_modules/@comfyorg/comfyui-electron-types/package.json 2>/dev/null | grep -A 5 'types\|main'

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Try to check if the package is installed and where
find . -name 'comfyui-electron-types*' -type d 2>/dev/null | grep -v node_modules/.pnpm | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Look at how TypeScript actually reports any issues with the return type mismatch
rg -n 'Promise<boolean>' src/platform/missingModel/missingModelDownload.ts -B 5 -A 15

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 654


🏁 Script executed:

# Check if there's an explicit type cast or return statement that wraps the start() call
sed -n '70,85p' src/platform/missingModel/missingModelDownload.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 368


🏁 Script executed:

# Review the complete MissingModelRow.vue handleDownload function context
sed -n '285,310p' src/platform/missingModel/components/MissingModelRow.vue

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 748


🏁 Script executed:

# Check if there are any TypeScript compilation errors
npm run type-check 2>&1 | head -50

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 740


🏁 Script executed:

# Look for any git history or comments that might explain the startDownload return type
git log --all --oneline --grep='startDownload\|DownloadManager' 2>/dev/null | head -10

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check the actual test expectations more carefully - what does the test assert about started value?
sed -n '230,245p' src/platform/missingModel/missingModelDownload.test.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 508


🏁 Script executed:

# See if start() is used anywhere else in the codebase that might hint at its return type
rg -n '\.start\(' src/platform/missingModel/components/MissingModelRow.test.ts -B 5 -A 5

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Try using pnpm to find the package
pnpm list '@comfyorg/comfyui-electron-types' 2>/dev/null

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check if there's any type annotation or inference hint in how start is returned from the store
sed -n '137,150p' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 294


🏁 Script executed:

# Look for any evidence that startDownload returns void vs Promise<boolean>
rg -n 'void initialize\|Promise<void>\|Promise<boolean>' src/stores/electronDownloadStore.ts

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 52


🏁 Script executed:

# Check if there's TypeScript strict mode enabled which would catch return type mismatches
grep -n 'strict' tsconfig.json

Repository: Comfy-Org/ComfyUI_frontend

Length of output: 92


Add explicit return type annotation to electronDownloadStore.start().

The start() method (line 124 of electronDownloadStore.ts) lacks an explicit return type. While tests confirm it resolves to a truthy value as expected by MissingModelRow.vue's if (started) check, the implicit typing creates maintenance risk—future changes to electron-types could break the contract silently.

Annotate start() with (options) => ReturnType<typeof DownloadManager.startDownload> or explicitly as (options) => Promise<boolean> to make the intended contract clear and ensure TypeScript catches any type drift from the underlying electron API.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/platform/missingModel/missingModelDownload.ts` around lines 72 - 79, The
electronDownloadStore.start function currently has no explicit return type;
update its signature in electronDownloadStore (the start method that calls
DownloadManager.startDownload) to annotate the return type explicitly—either as
ReturnType<typeof DownloadManager.startDownload> or as Promise<boolean>—so
callers like MissingModelRow.vue (which checks if (started)) have a stable,
enforced contract and TypeScript will catch any future drift from the underlying
DownloadManager.startDownload behavior.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in eaa09fa: electronDownloadStore.start() now has an explicit Promise<boolean> return type, preserving the contract used by the missing-model download flow.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benceruleanlu, thanks for the update! Adding an explicit Promise<boolean> return type to electronDownloadStore.start() makes the contract clear and ensures TypeScript will catch any future drift from the underlying DownloadManager.startDownload behaviour.


🧠 Learnings used
Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7169
File: src/platform/remote/comfyui/jobs/jobTypes.ts:1-107
Timestamp: 2025-12-09T03:39:54.501Z
Learning: In the ComfyUI_frontend project, Zod is on v3.x. Do not suggest Zod v4 standalone validators (z.uuid, z.ulid, z.cuid2, z.nanoid) until an upgrade to Zod 4 is performed. When reviewing TypeScript files (e.g., src/platform/remote/comfyui/jobs/jobTypes.ts) validate against Zod 3 capabilities and avoid introducing v4-specific features; flag any proposal to upgrade or incorporate v4-only validators and propose staying with compatible 3.x patterns.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7358
File: src/components/dialog/content/signin/SignUpForm.vue:45-54
Timestamp: 2025-12-11T12:25:15.470Z
Learning: This repository uses CI automation to format code (pnpm format). Do not include manual formatting suggestions in code reviews for Comfy-Org/ComfyUI_frontend. If formatting issues are detected, rely on the CI formatter or re-run pnpm format. Focus reviews on correctness, readability, performance, accessibility, and maintainability rather than style formatting.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 7416
File: src/stores/imagePreviewStore.ts:5-7
Timestamp: 2025-12-13T11:03:11.264Z
Learning: In the ComfyUI_frontend repository, lint rules require keeping 'import type' statements separate from non-type imports, even if importing from the same module. Do not suggest consolidating them into a single import statement. Ensure type imports remain on their own line (import type { ... } from 'module') and regular imports stay on separate lines.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7537
File: src/components/ui/button/Button.stories.ts:45-55
Timestamp: 2025-12-17T00:40:09.635Z
Learning: Prefer pure function declarations over function expressions (e.g., use function foo() { ... } instead of const foo = () => { ... }) for pure functions in the repository. Function declarations are more functional-leaning, offer better hoisting clarity, and can improve readability and tooling consistency. Apply this guideline across TypeScript files in Comfy-Org/ComfyUI_frontend, including story and UI component code, except where a function expression is semantically required (e.g., callbacks, higher-order functions with closures).

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 7805
File: src/composables/useCoreCommands.ts:439-439
Timestamp: 2025-12-30T22:22:33.836Z
Learning: When accessing reactive properties from Pinia stores in TypeScript files, avoid using .value on direct property access (e.g., useStore().isOverlayExpanded). Pinia auto-wraps refs when accessed directly, returning the primitive value. The .value accessor is only needed when destructuring store properties or when using storeToRefs().

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 7906
File: src/components/sidebar/tabs/AssetsSidebarTab.vue:545-552
Timestamp: 2026-01-12T17:39:27.738Z
Learning: In Vue/TypeScript files (src/**/*.{ts,tsx,vue}), prefer if/else statements over ternary operators when performing side effects or actions (e.g., mutating state, calling methods with side effects). Ternaries should be reserved for computing and returning values.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8248
File: src/platform/assets/schemas/assetSchema.ts:109-118
Timestamp: 2026-01-22T23:44:59.888Z
Learning: Do not export declarations (e.g., schemas, constants, types) unless they are actually used elsewhere in the codebase. Keep the public API surface minimal by exporting only items with concrete usage. This reduces coupling and keeps imports explicit. In src/platform/assets/schemas/assetSchema.ts, ensure only necessary exports are exposed; remove unused exports or switch to non-exported/internal where appropriate.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8722
File: src/composables/maskeditor/useBrushDrawing.ts:5-5
Timestamp: 2026-02-08T03:19:12.009Z
Learning: Treat unresolved import warnings caused by pnpm workspace catalog mappings (pnpm-workspace.yaml) and unplugin-typegpu in vite.config.mts as false positives. Do not flag these in PR reviews; they are expected in sandboxes without node_modules and are not indicative of actual missing dependencies in the TS codebase.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 8966
File: src/extensions/core/load3d.ts:427-430
Timestamp: 2026-02-19T02:06:23.468Z
Learning: In TypeScript, you can use typeof SomeClass in type annotation positions (e.g., param: typeof LGraphNode) even when SomeClass is imported with import type. This is a type query that only exists at compile time and is erased in runtime, so it is safe to combine with type-only imports. Apply this pattern to TS files broadly when you need a type that references the shape of a class or constructor function without importing the value at runtime.

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 8966
File: src/extensions/core/uploadAudio.ts:91-94
Timestamp: 2026-02-19T02:06:38.395Z
Learning: In TypeScript files, you can use a type annotation like 'nodeType: typeof MyClass' even if MyClass is imported via 'import type'. Both the type-only import and 'typeof' operate at the type level and are erased at compile time. This pattern is commonly used for constructor types (e.g., 'nodeType: typeof LGraphNode'). Apply this pattern across TypeScript files in the repository (src/**/*.ts) as appropriate, ensuring the imported symbol is a type-only import when possible for clarity and to avoid runtime imports.

Learnt from: DrJKL
Repo: Comfy-Org/ComfyUI_frontend PR: 8992
File: src/lib/litegraph/src/widgets/GradientSliderWidget.ts:18-18
Timestamp: 2026-02-20T21:08:19.814Z
Learning: When drawing with CanvasRenderingContext2D in TypeScript/JavaScript, wrap the drawing logic with ctx.save() at the start and ctx.restore() at the end to preserve and restore the canvas state. Do not manually destructure and restore individual properties (e.g., fillStyle, strokeStyle); rely on save/restore to manage state changes in a scoped manner. This should be applied to all TS files that perform canvas drawing.

Learnt from: dante01yoon
Repo: Comfy-Org/ComfyUI_frontend PR: 9075
File: src/scripts/api.featureFlags.test.ts:237-268
Timestamp: 2026-02-22T04:27:33.379Z
Learning: In Vite/Vitest, import.meta.env.DEV is true for any mode that is not 'production' (i.e., DEV is the opposite of PROD, and can be true in 'test', 'development', etc.). Do not assume DEV implies only 'development' mode. When reviewing code and tests, treat DEV as a non-production flag and verify environment-specific logic accordingly. Reference: https://vite.dev/guide/env-and-mode#modes

Learnt from: christian-byrne
Repo: Comfy-Org/ComfyUI_frontend PR: 9427
File: src/renderer/extensions/vueNodes/widgets/components/form/dropdown/FormDropdownMenuFilter.vue:33-33
Timestamp: 2026-03-06T00:53:28.835Z
Learning: When reviewing code, note that the enforce-canonical-classes (better-tailwindcss) rule may auto-fix Tailwind v3 !class-name syntax by converting it to v4 class-name! syntax. Do not treat these auto-fixed class-name! instances as newly introduced issues; the perceived change is in syntax placement, not in usage or intent. This guidance applies across all .vue and .ts files in the repository.

Learnt from: sonnybox
Repo: Comfy-Org/ComfyUI_frontend PR: 9446
File: src/renderer/extensions/vueNodes/widgets/components/WidgetTextarea.vue:45-45
Timestamp: 2026-03-06T01:55:00.013Z
Learning: Treat wrap-break-word as a valid Tailwind CSS utility for overflow-wrap: break-word in Tailwind v4+ projects. Do not flag this class as invalid in any Vue (.vue) or TypeScript (.ts/.tsx) files within the repository (e.g., Comfy-Org/ComfyUI_frontend) or other Tailwind v4+ projects. When reviewing, verify that the class is used to enable word breaking in long text content and reference the Tailwind docs: https://tailwindcss.com/docs/overflow-wrap.

Learnt from: jaeone94
Repo: Comfy-Org/ComfyUI_frontend PR: 9921
File: src/platform/missingModel/components/MissingModelRow.vue:136-151
Timestamp: 2026-03-14T17:11:36.856Z
Learning: Do not suggest adding an or-detection guard (e.g., an isCloud check) or a destination-path check in MissingModelRow.vue or related OSS/TS files. This pattern applies to all files under src/platform/missingModel where the UI and scan logic already enforce relevant guards: verifyAssetSupportedCandidates surfaces only isAssetSupported: true in cloud builds, so isAssetSupported: false rows are never rendered in cloud; surfaceMissingModels is invoked inside getFolderPaths().finally() in the OSS path to ensure folderPaths settle before the UI renders. Apply reviews with this context across similar MissingModel components and related TS files.

Learnt from: kaili-yang
Repo: Comfy-Org/ComfyUI_frontend PR: 11531
File: src/composables/maskeditor/brushDrawingUtils.ts:14-14
Timestamp: 2026-04-22T04:06:01.353Z
Learning: In the Comfy-Org/ComfyUI_frontend codebase, `knip` is used to detect unused exports. When reviewing TypeScript/TSX code, avoid recommending or introducing exported types/functions/constants that have no concrete external consumers (e.g., they’re only used within the same module). Only recommend exporting when there is an actual external usage outside the module. If something might be needed externally later, keep it non-exported for now and defer exporting until an external consumer is added.

If you found this review helpful, would you consider giving us a shout-out on X?

Thank you for using CodeRabbit!

@benceruleanlu benceruleanlu changed the title [codex] Fix missing model direct download UI state Fix missing model direct download UI state May 3, 2026
@benceruleanlu
benceruleanlu force-pushed the bl/missing-model-download-contract branch from 03a8971 to eaa09fa Compare May 3, 2026 10:41
@benceruleanlu
benceruleanlu marked this pull request as ready for review May 3, 2026 10:47
@benceruleanlu
benceruleanlu requested a review from a team May 3, 2026 10:47
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: eaa09fa92c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +296 to +300
store.downloadRefs[modelKey.value] = {
kind: 'electron-download',
url: rep.url
}
handleComboSelect(modelKey.value, rep.name)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restrict download-tracking state to desktop flow

This branch now runs for every successful downloadModel() call, including non-desktop builds where downloadModel always returns true after opening a browser link. In that environment there is no Electron download lifecycle to track, so setting downloadRefs and selectedLibraryModel here makes the missing-model row look resolved and allows users to confirm selection before the file is actually installed in ComfyUI’s model path. That can incorrectly clear the missing-model error while the workflow is still broken.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@benceruleanlu benceruleanlu added needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch core/1.43 labels May 3, 2026

@jaeone94 jaeone94 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this stack together so quickly. I really like the
direction of introducing a more explicit download ref abstraction and making
the missing-model flow consume both cloud asset imports and desktop downloads
through a shared lifecycle shape. The way this reuses the existing
import/download UI model is elegant.

I checked out both this frontend PR and the paired desktop PR locally and
tested the flow in the actual desktop environment. Before doing a more
detailed line-by-line review, I think there are a few product/architecture
points worth discussing.

  1. URL-based matching still remains in the new contract

The new desktop download state contract is definitely cleaner: progress events
and getAllDownloads() now expose the same canonical DownloadState, and FE
no longer has to interpret two different payload shapes.

However, the missing-model row still tracks Electron downloads by URL:

{ kind: 'electron-download', url }

and resolves progress with findByUrl(url). So the issue you called out on
#11720 still exists: two missing model entries can share the same URL while
expecting different filenames / model names / target paths, and the UI can
incorrectly share download state between them.

That said, I think this is a relatively rare edge case, and I personally would
not block this PR on fixing it. The current user-facing issue, where starting a
desktop download from the missing-model row gives no visual feedback at all, is
more critical.

If you do want to address this as part of the contract work, I think the fix
should probably happen in the desktop download identity itself:
DownloadManager should not key active downloads only by URL, and
startDownload() should ideally return either a stable download/request id or
the canonical DownloadState that FE can track directly. A composite identity
based on URL + savePath/filename would also be an improvement, though an
explicit id would be cleaner.

  1. UX issues I found while testing

The main thing I found is that the cloud import progress UI and the desktop
download lifecycle are not quite equivalent, and a few behaviors feel mismatched
as a result.

  • In the missing-model row, the x button on the progress card looks like it
    should cancel the desktop download. But it does not actually cancel the
    Electron download. The download continues in the Model Library, while the
    missing-model row simply hides the progress UI and goes back to the
    Download button.

  • If I cancel the active download from the Model Library, the missing-model row
    correctly shows the cancelled state. That part is good. However, if I then
    dismiss/remove the cancelled row from the Model Library, the missing-model row
    switches to a Use from library-style state and enables the check button.
    Clicking the check button removes the missing-model row even though the model
    is still missing.

  • Desktop downloads support pause/resume through the Model Library, and the
    missing-model row does reflect the paused state. However, the missing-model
    row does not expose buttons to trigger pause/resume itself, so those actions
    are only available from the Model Library. I do not think this is necessarily
    a blocker, but it is another sign that the two UIs are representing the same
    desktop download with different capabilities.

I think this mismatch comes from reusing the cloud import-style status
component for a desktop download flow. There are probably two reasonable
directions:

  • Make the missing-model row progress UI purely informational for Electron
    downloads. In that case, it should only display state and should not show an
    x action that looks like cancel.
  • Or make the missing-model row expose the same desktop download actions as the
    Model Library: cancel, pause, resume, etc.

I lean toward the second option. A lot of users do not notice that the Model
Library has the active download progress row, so if we show download progress
directly in the missing-model row, I think it should behave consistently there
too.

In the earlier #11720 PR, I tried to solve this by extracting the Model Library
download progress UI into a reusable ElectronDownloadProgress component and
mounting the same component in both places, with some design cleanup. If useful,
feel free to cherry-pick from that PR. Alternatively, I can rework that
component against this new contract in a follow-up PR after this lands.

Either way, I trust your judgment on the right shape for this.

  1. Download all still has no missing-row feedback

When using Download all, the individual missing-model rows still do not show
desktop download progress. As before, progress only appears in the Model
Library.

I think this one should be handled in this PR, because it is the same UX problem
this PR is trying to solve: desktop downloads can start from the missing-model
flow, but the missing-model UI gives no local feedback. Even if the single-row
download path is fixed, users hitting Download all will still experience the
old behavior.

@jaeone94 jaeone94 assigned benceruleanlu and unassigned jaeone94 May 3, 2026
@benceruleanlu

Copy link
Copy Markdown
Member Author

Gah I missed that, did this one super late at night

Desktop PR is updated with persistent IDs, the x button... I just removed, planning to add more granular UI after the UI feedback issue is fixed here, download all was also fixed

@jaeone94 jaeone94 left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for pushing this through and for continuing to iterate so late. Sorry for the late extra pass, and I really appreciate all the care here. The new downloadId path looks like it addresses the URL identity issue I was worried about, and the Download all row tracking is a nice improvement as well. I left two small inline comments.

One remaining visual issue I still see while testing: if I cancel a download from the Model Library and then dismiss the cancelled label there, the missing-model row switches to Use from library even though the model is still missing. I think this can be handled separately if you prefer, but I wanted to call it out while the behavior is fresh.

Thanks again for the late work on this, and sorry for piling on another review pass.

2026-05-05.9.13.11.mov

Comment on lines +295 to +300
const electronDownload = downloadRef.downloadId
? electronDownloadStore.findByDownloadId(downloadRef.downloadId)
: null
const download =
electronDownload ?? electronDownloadStore.findByUrl(downloadRef.url)
return download

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the URL fallback is useful for legacy desktop payloads, but once a ref has a downloadId, falling back to URL after an id miss can attach this row to a different same-URL download. Since this status also controls isSelectionConfirmable(), a stale completed same-URL entry can enable the checkmark for the wrong target. If we intentionally want best-effort URL fallback for display, I think we should keep it out of confirmability, or only use URL lookup for refs without downloadId.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK fixed

Comment on lines +94 to +95
const getDownloadIdentifier = () =>
props.download.downloadId ?? props.download.url

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this item now correctly uses downloadId ?? url for actions/removal, I think the parent list key should use the same identity. The store can now hold multiple active downloads with the same URL but different downloadIds, but ElectronDownloadItems.vue still renders with :key="download.url". That gives duplicate keys for the exact case the new contract supports, so Vue can reuse the wrong DownloadItem instance or render updates incorrectly. Could we update the parent key to download.downloadId ?? download.url as well?

@jaeone94 jaeone94 assigned benceruleanlu and unassigned jaeone94 May 5, 2026

@jaeone94 jaeone94 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up. I checked the latest changes and the two previous concerns look addressed: id-bearing refs no longer fall back to URL lookup, and the Model Library list key now uses downloadId ?? url. The remaining cancelled/dismissed row behavior also looks covered by the new row cleanup logic and test.

I ran the targeted FE tests for the touched missing-model/download files locally: 6 files, 106 tests passed. Approving from my side. Thanks again for all the late iteration on this.

@benceruleanlu

Copy link
Copy Markdown
Member Author

Before merge I am taking another look at the desktop PR I moved pretty fast for both solutions since this is really a two week solution before desktop 2 goes GA, I'm doing some refactors there right now and the FE PR has a slight possibility of needing to change.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants