Repository navigation
feat: add eslint-plugin-playwright via oxlint JS plugins #11136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
117c473
252f8eb
28a51dd
f26800f
653e9d4
3d71c83
5911eac
91f8315
c7ecfab
c2d2c18
1daa15f
9605700
0a7037b
8746f94
fbe2614
c02a852
d4d588f
1898a24
705a613
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -117,13 +117,60 @@ | |
| }, | ||
| { | ||
| "files": ["browser_tests/**/*.ts"], | ||
| "jsPlugins": ["eslint-plugin-playwright"], | ||
| "rules": { | ||
| "typescript/no-explicit-any": "error", | ||
| "no-async-promise-executor": "error", | ||
| "no-control-regex": "error", | ||
| "no-useless-rename": "error", | ||
| "no-unused-private-class-members": "error", | ||
| "unicorn/no-empty-file": "error" | ||
| "unicorn/no-empty-file": "error", | ||
| "playwright/consistent-spacing-between-blocks": "error", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🏌️ 😢
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to add a bonk emoji... Someone call unicode. |
||
| "playwright/expect-expect": [ | ||
| "error", | ||
| { | ||
| "assertFunctionNames": [ | ||
| "recordMeasurement", | ||
| "logMeasurement", | ||
| "builderSaveAs" | ||
| ], | ||
| "assertFunctionPatterns": [ | ||
| "^expect", | ||
| "^assert", | ||
| "^verify", | ||
| "^searchAndExpect", | ||
| "waitForOpen", | ||
| "waitForClosed", | ||
| "waitForRequest" | ||
| ] | ||
| } | ||
| ], | ||
| "playwright/max-nested-describe": "error", | ||
| "playwright/no-duplicate-hooks": "error", | ||
| "playwright/no-element-handle": "error", | ||
| "playwright/no-eval": "error", | ||
| "playwright/no-focused-test": "error", | ||
| "playwright/no-force-option": "off", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm specifically concerned about this one, but I'll reserve judgement until seeing how you've handled it's usage.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That'll be coming soon™️ |
||
| "playwright/no-networkidle": "error", | ||
| "playwright/no-page-pause": "error", | ||
| "playwright/no-skipped-test": "error", | ||
| "playwright/no-unsafe-references": "error", | ||
| "playwright/no-unused-locators": "error", | ||
| "playwright/no-useless-await": "error", | ||
| "playwright/no-useless-not": "error", | ||
| "playwright/no-wait-for-navigation": "error", | ||
| "playwright/no-wait-for-selector": "error", | ||
| "playwright/no-wait-for-timeout": "error", | ||
| "playwright/prefer-hooks-on-top": "error", | ||
| "playwright/prefer-locator": "error", | ||
| "playwright/prefer-to-have-count": "error", | ||
| "playwright/prefer-to-have-length": "error", | ||
| "playwright/prefer-web-first-assertions": "error", | ||
| "playwright/prefer-native-locators": "error", | ||
| "playwright/require-to-pass-timeout": "error", | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm a little iffy on this one. We're reintroducing the ick of timeouts for marginal benefit on the uncommon case.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. toPass defaults to 0. Timeouts aren't bad, waiting arbitrary amounts of time with no groundtruth is the problem. |
||
| "playwright/valid-expect": "error", | ||
| "playwright/valid-expect-in-promise": "error", | ||
| "playwright/valid-title": "error" | ||
| } | ||
| } | ||
| ] | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.