Repository navigation
test: App mode - Improve unit test coverage - #11113
pythongosssss wants to merge 2 commits into
Conversation
- extract shared result item factory - more tests!
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎭 Playwright: ✅ 1043 passed, 0 failed📊 Browser Reports
|
🎨 Storybook: ✅ Built — View Storybook |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## pysssss/appmode/image-compare-tests #11113 +/- ##
=======================================================================
+ Coverage 43.21% 43.28% +0.06%
=======================================================================
Files 1332 1333 +1
Lines 68328 68335 +7
Branches 18873 18020 -853
=======================================================================
+ Hits 29531 29577 +46
+ Misses 38206 38169 -37
+ Partials 591 589 -2
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
📦 Bundle Size
⚡ Performance Report
No baseline found — showing absolute values.
Raw data{
"timestamp": "2026-04-10T12:00:45.109Z",
"gitSha": "899eb22b41d1f3b7127fe1195a018b23a329425a",
"branch": "pysssss/appmode/unit-test-coverage",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1998.4169999999892,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.298,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 363.10900000000004,
"heapDeltaBytes": 20087704,
"heapUsedBytes": 63194264,
"domNodes": 19,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 17.859999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.6630000000177,
"styleRecalcs": 13,
"styleRecalcDurationMs": 12.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.8539999999999,
"heapDeltaBytes": 21070756,
"heapUsedBytes": 63525024,
"domNodes": 25,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 25.372000000000007,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2025.3090000001066,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.231,
"heapDeltaBytes": 20432788,
"heapUsedBytes": 63184388,
"domNodes": 22,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 25.207,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2140.006999999997,
"styleRecalcs": 85,
"styleRecalcDurationMs": 53.864,
"layouts": 12,
"layoutDurationMs": 3.4869999999999997,
"taskDurationMs": 1130.2969999999998,
"heapDeltaBytes": 16311048,
"heapUsedBytes": 59096624,
"domNodes": 71,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 156.273,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2056.5349999999967,
"styleRecalcs": 83,
"styleRecalcDurationMs": 48.153,
"layouts": 12,
"layoutDurationMs": 3.756,
"taskDurationMs": 1015.8580000000002,
"heapDeltaBytes": 16380832,
"heapUsedBytes": 58884720,
"domNodes": 68,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 153.833,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.6879999999355,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.899,
"layouts": 12,
"layoutDurationMs": 3.2319999999999998,
"taskDurationMs": 743.6089999999999,
"heapDeltaBytes": 15796940,
"heapUsedBytes": 58820260,
"domNodes": 60,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 131.422,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.902999999998,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.679000000000002,
"layouts": 6,
"layoutDurationMs": 0.562,
"taskDurationMs": 336.62,
"heapDeltaBytes": 24781472,
"heapUsedBytes": 67237116,
"domNodes": 79,
"jsHeapTotalBytes": 20971520,
"scriptDurationMs": 28.567000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.5690000000027,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.132,
"layouts": 6,
"layoutDurationMs": 0.5690000000000001,
"taskDurationMs": 335.80299999999994,
"heapDeltaBytes": 24770944,
"heapUsedBytes": 67588812,
"domNodes": 78,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 28.773,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.2740000000367,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.386000000000003,
"layouts": 6,
"layoutDurationMs": 0.6789999999999999,
"taskDurationMs": 337.63699999999994,
"heapDeltaBytes": 24776560,
"heapUsedBytes": 67364536,
"domNodes": 80,
"jsHeapTotalBytes": 20709376,
"scriptDurationMs": 29.947000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 584.9190000000135,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.787999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.06300000000005,
"heapDeltaBytes": 6505276,
"heapUsedBytes": 49329964,
"domNodes": 18,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 75.54299999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 546.3219999999751,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.269000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.62199999999996,
"heapDeltaBytes": 7369696,
"heapUsedBytes": 50439640,
"domNodes": 20,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 62.332,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 559.8000000001093,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.353,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.16400000000004,
"heapDeltaBytes": 6846572,
"heapUsedBytes": 49317416,
"domNodes": 22,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 65.88,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.8250000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.020000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.9559999999999,
"heapDeltaBytes": 4328872,
"heapUsedBytes": 55911552,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 115.80799999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.3639999999973,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.740000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.82,
"heapDeltaBytes": 5044824,
"heapUsedBytes": 55879556,
"domNodes": -256,
"jsHeapTotalBytes": 16445440,
"scriptDurationMs": 116.03399999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2028.5649999999578,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.818,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 604.082,
"heapDeltaBytes": 4112912,
"heapUsedBytes": 55577296,
"domNodes": -258,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 111.15700000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2119.9439999999754,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1088.993,
"heapDeltaBytes": 15689528,
"heapUsedBytes": 68627924,
"domNodes": -259,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 390.539,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2166.435999999976,
"styleRecalcs": 68,
"styleRecalcDurationMs": 15.979999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1162.9830000000002,
"heapDeltaBytes": 14629320,
"heapUsedBytes": 68260980,
"domNodes": -263,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 413.68100000000004,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2143.3980000000474,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.342999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1059.1719999999998,
"heapDeltaBytes": 18220808,
"heapUsedBytes": 71578276,
"domNodes": -259,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 394.564,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3169.7039999999674,
"styleRecalcs": 66,
"styleRecalcDurationMs": 15.48,
"layouts": 60,
"layoutDurationMs": 6.841000000000001,
"taskDurationMs": 1279.818,
"heapDeltaBytes": 3567588,
"heapUsedBytes": 58770548,
"domNodes": -263,
"jsHeapTotalBytes": 17231872,
"scriptDurationMs": 484.93199999999996,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3180.025999999998,
"styleRecalcs": 66,
"styleRecalcDurationMs": 17.137999999999998,
"layouts": 60,
"layoutDurationMs": 7.524999999999999,
"taskDurationMs": 1378.571,
"heapDeltaBytes": 7468548,
"heapUsedBytes": 62482376,
"domNodes": -264,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 514.389,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3181.6860000000133,
"styleRecalcs": 65,
"styleRecalcDurationMs": 16.51,
"layouts": 60,
"layoutDurationMs": 7.101,
"taskDurationMs": 1375.1229999999998,
"heapDeltaBytes": 3930468,
"heapUsedBytes": 59133584,
"domNodes": -267,
"jsHeapTotalBytes": 17756160,
"scriptDurationMs": 521.6650000000001,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.6300000000115,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.576,
"heapDeltaBytes": 16117608,
"heapUsedBytes": 69748612,
"domNodes": -258,
"jsHeapTotalBytes": 15454208,
"scriptDurationMs": 119.248,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2032.1289999999976,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.371,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.9900000000001,
"heapDeltaBytes": 3265984,
"heapUsedBytes": 56860428,
"domNodes": -258,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 104.39499999999998,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2037.4500000000353,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.052,
"heapDeltaBytes": 4751216,
"heapUsedBytes": 56906132,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 112.41499999999999,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.5400000000132,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.39900000000006,
"heapDeltaBytes": 6525708,
"heapUsedBytes": 49608196,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 127.19800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 553.7560000000212,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.859000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.088,
"heapDeltaBytes": 6571284,
"heapUsedBytes": 49663664,
"domNodes": 20,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 129.07,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 565.2310000000398,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.659,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.32300000000004,
"heapDeltaBytes": 6178556,
"heapUsedBytes": 49303436,
"domNodes": 22,
"jsHeapTotalBytes": 13631488,
"scriptDurationMs": 125.331,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 1991.694999999993,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.234000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.46500000000003,
"heapDeltaBytes": -4426020,
"heapUsedBytes": 44870368,
"domNodes": 22,
"jsHeapTotalBytes": 24117248,
"scriptDurationMs": 19.624999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.2070000000313,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.615,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.41900000000004,
"heapDeltaBytes": 19988204,
"heapUsedBytes": 63068184,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 16.97,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.2299999999786,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.464999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.231,
"heapDeltaBytes": 20008740,
"heapUsedBytes": 63110340,
"domNodes": 23,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 23.17,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2016.8079999999975,
"styleRecalcs": 88,
"styleRecalcDurationMs": 49.51499999999999,
"layouts": 16,
"layoutDurationMs": 5.606,
"taskDurationMs": 947.522,
"heapDeltaBytes": 12293592,
"heapUsedBytes": 55409708,
"domNodes": 72,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 100.259,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2029.9440000000004,
"styleRecalcs": 86,
"styleRecalcDurationMs": 48.903,
"layouts": 16,
"layoutDurationMs": 4.692,
"taskDurationMs": 967.914,
"heapDeltaBytes": 7839660,
"heapUsedBytes": 54068920,
"domNodes": 77,
"jsHeapTotalBytes": 26738688,
"scriptDurationMs": 132.328,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.5079999999807,
"styleRecalcs": 83,
"styleRecalcDurationMs": 47.023999999999994,
"layouts": 16,
"layoutDurationMs": 4.707,
"taskDurationMs": 915.2409999999999,
"heapDeltaBytes": 11933620,
"heapUsedBytes": 55043688,
"domNodes": 72,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 103.41399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8168.708000000038,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.498000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3883.062,
"heapDeltaBytes": 20794892,
"heapUsedBytes": 71350536,
"domNodes": -256,
"jsHeapTotalBytes": 20058112,
"scriptDurationMs": 1294.4579999999999,
"eventListeners": -107,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8225.840000000006,
"styleRecalcs": 251,
"styleRecalcDurationMs": 45.729,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4100.774,
"heapDeltaBytes": 28460412,
"heapUsedBytes": 79077076,
"domNodes": -254,
"jsHeapTotalBytes": 22417408,
"scriptDurationMs": 1397.461,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8192.644999999971,
"styleRecalcs": 251,
"styleRecalcDurationMs": 44.814,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4010.5129999999995,
"heapDeltaBytes": 30323532,
"heapUsedBytes": 81228176,
"domNodes": -258,
"jsHeapTotalBytes": 21630976,
"scriptDurationMs": 1398.0750000000003,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12350.837000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12338.056999999999,
"heapDeltaBytes": -36168592,
"heapUsedBytes": 158434468,
"domNodes": -8331,
"jsHeapTotalBytes": 17391616,
"scriptDurationMs": 623.39,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12217.708000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12202.259,
"heapDeltaBytes": -52141084,
"heapUsedBytes": 145339248,
"domNodes": -8331,
"jsHeapTotalBytes": 17915904,
"scriptDurationMs": 587.496,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12601.214999999911,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12588.815,
"heapDeltaBytes": -32090432,
"heapUsedBytes": 165742128,
"domNodes": -8331,
"jsHeapTotalBytes": 27615232,
"scriptDurationMs": 625.816,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14476.730000000032,
"styleRecalcs": 67,
"styleRecalcDurationMs": 14.281000000000043,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14453.905,
"heapDeltaBytes": -33396576,
"heapUsedBytes": 160509512,
"domNodes": -8331,
"jsHeapTotalBytes": -5500928,
"scriptDurationMs": 849.56,
"eventListeners": -16458,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14229.194999999947,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.22100000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14199.319,
"heapDeltaBytes": -20332356,
"heapUsedBytes": 173174684,
"domNodes": -8331,
"jsHeapTotalBytes": 24645632,
"scriptDurationMs": 880.0500000000001,
"eventListeners": -16460,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14244.785999999976,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.373999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14223.932,
"heapDeltaBytes": -34028676,
"heapUsedBytes": 160044540,
"domNodes": -8331,
"jsHeapTotalBytes": -3141632,
"scriptDurationMs": 882.957,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.8780000000029,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.471999999999998,
"layouts": 5,
"layoutDurationMs": 1.4780000000000002,
"taskDurationMs": 123.78899999999999,
"heapDeltaBytes": 4728668,
"heapUsedBytes": 49294532,
"domNodes": 167,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.300000000000008,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 456.0340000000451,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.499000000000002,
"layouts": 5,
"layoutDurationMs": 1.2979999999999998,
"taskDurationMs": 128.94499999999996,
"heapDeltaBytes": 4500912,
"heapUsedBytes": 48837156,
"domNodes": 158,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 31.132,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 443.1409999999687,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.177999999999997,
"layouts": 5,
"layoutDurationMs": 1.28,
"taskDurationMs": 117.368,
"heapDeltaBytes": 4500508,
"heapUsedBytes": 48460080,
"domNodes": 159,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 27.976999999999993,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
Draft Review — Architectural FeedbackVerdict: 🟢 Direction looks good What's looking good
Architectural concernsNone blocking. Two optional thoughts for when this lands:
Suggested directionAlready approved — keep going. The shared factory + testid migration is the right shape; future linearMode tests should adopt both. Early-stage architectural review — detailed line-by-line feedback would come when marked ready. |
|
This remains an eight-file test child of draft #10990, not an independently landable |
Summary
Adds tests to areas missing coverage
Changes
┆Issue is synchronized with this Notion page by Unito