Repository navigation
[backport cloud/1.42] test: subgraph integration contracts and expanded Playwright coverage - #10329
Merged
Merged
Conversation
Resolve all lint warnings (3 oxlint + 1 eslint). ## Changes - Replace `it.todo` with `it.skip` in subgraph tests (`warn-todo`) - Move `vi.mock` to top-level in `firebaseAuthStore.test.ts` (`hoisted-apis-on-top`) - Rename `DOMPurify` default import to `dompurify` (`no-named-as-default`) --- ### The Villager Who Ignored the Warnings Once there lived a villager whose compiler whispered of lint. "They are only *warnings*," she said, and went about her day. One warning became three. Three became thirty. The yellow text grew like ivy across the terminal, until no one could tell the warnings from the errors. One morning a real error appeared — a misplaced mock, a shadowed import — but nobody noticed, for the village had long since learned to stop reading. The build shipped. The users wept. And the warning, faithful to the last, sat quietly in the log where it had always been. *Moral: Today's warning is tomorrow's incident report.* ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9972-fix-resolve-all-lint-warnings-3246d73d3650810a89cde5d05e79d948) by [Unito](https://www.unito.io) Co-authored-by: Amp <amp@ampcode.com>
## Summary Harden subgraph test coverage: remove low-value change-detector tests, consolidate fixtures, add behavioral coverage, and fix test infrastructure issues. Includes minor production code corrections discovered during test hardening. ## Changes - **What**: Comprehensive subgraph test suite overhaul across 6 phases - Removed change-detector tests and redundant assertions - Consolidated fixture helpers into `subgraphHelpers.ts` / `subgraphFixtures.ts` - Added Pinia initialization and fixture reset to all test files - Fixed barrel import violations (circular dependency prevention) - Added behavioral coverage for slot connections, events, edge cases - Added E2E helper and smoke test for subgraph promotion - Exported `SubgraphSlotBase` from litegraph barrel for test access - **Production code changes** (minor correctness fixes found during testing): - `resolveSubgraphInputLink.ts`: iterate forward (first-connected-wins) to match `_resolveLinkedPromotionBySubgraphInput` - `promotionSchema.ts`: return `[]` instead of throwing on invalid `proxyWidgets`; console.warn always (not DEV-only) - `LGraph.ts`: disconnect-after-veto ordering fix - `litegraph.ts`: barrel export swap for `SubgraphSlotBase` - **Stats**: 349 tests passing, 0 skipped across 26 test files ## Review Focus - Tests that merely asserted default property values were deleted (change detectors) - Fixture state is now reset via `resetSubgraphFixtureState()` in `beforeEach` - All imports use `@/lib/litegraph/src/litegraph` barrel to avoid circular deps - Production changes are small and directly motivated by test findings --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…#10123) Add integration contract tests (unit) and expanded Playwright coverage for subgraph promotion, hydration, navigation, and lifecycle edge behaviors. - **What**: 22 unit/integration tests across 9 files covering promotion store sync, widget view lifecycle, input link resolution, pseudo-widget cache, navigation viewport restore, and subgraph operations. 13 Playwright E2E tests covering proxyWidgets hydration stability, promoted source removal cleanup, pseudo-preview unpack/remove, multi-link representative round-trip, nested promotion retarget, and navigation state on workflow switch. - **Helpers**: Added `isPseudoPreviewEntry`, `getPseudoPreviewWidgets`, `getNonPreviewPromotedWidgets` to promotedWidgets helper. Added `SubgraphHelper.getNodeCount()`. - Test-only PR — no production code changes - Validates existing subgraph behaviors are covered by regression tests before further feature work - Phase 4 (unit/integration contracts) and Phase 5 (Playwright expansion) of the subgraph test coverage plan ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10123-test-subgraph-integration-contracts-and-expanded-Playwright-coverage-3256d73d365081258023e3a763859e00) by [Unito](https://www.unito.io) --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: GitHub Action <action@github.com>
Contributor
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Contributor
🎭 Playwright: ✅ 576 passed, 0 failed · 7 flaky📊 Browser Reports
|
Contributor
🎨 Storybook: ✅ Built — View Storybook |
DrJKL
enabled auto-merge (squash)
March 20, 2026 00:55
Contributor
📦 Bundle Size
⚡ Performance ReportNo baseline found — showing absolute values.
Raw data{
"timestamp": "2026-03-20T01:00:40.000Z",
"gitSha": "2fa98d2589187eaec25f041ce34f820cd0871ed3",
"branch": "backport-10123-to-cloud-1.42",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.236999999991,
"styleRecalcs": 12,
"styleRecalcDurationMs": 12.368999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.745,
"heapDeltaBytes": -5144104,
"domNodes": 27,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 26.033,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-idle",
"durationMs": 2031.2279999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.695,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.579,
"heapDeltaBytes": -5097992,
"domNodes": 22,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 25.527,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-idle",
"durationMs": 2025.0639999999862,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.796000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.98300000000006,
"heapDeltaBytes": -5474324,
"domNodes": 22,
"jsHeapTotalBytes": 24379392,
"scriptDurationMs": 24.695999999999994,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2005.3359999999998,
"styleRecalcs": 81,
"styleRecalcDurationMs": 45.39600000000001,
"layouts": 12,
"layoutDurationMs": 3.567,
"taskDurationMs": 975.519,
"heapDeltaBytes": -2890980,
"domNodes": 66,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 139.291,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1819.849999999974,
"styleRecalcs": 73,
"styleRecalcDurationMs": 36.657000000000004,
"layouts": 12,
"layoutDurationMs": 3.7040000000000006,
"taskDurationMs": 759.151,
"heapDeltaBytes": -3608244,
"domNodes": 56,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 127.276,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.321999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.963,
"layouts": 12,
"layoutDurationMs": 3.589,
"taskDurationMs": 783.223,
"heapDeltaBytes": -2620972,
"domNodes": 62,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 136.61299999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.344999999977,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.547,
"layouts": 6,
"layoutDurationMs": 0.6220000000000001,
"taskDurationMs": 316.186,
"heapDeltaBytes": 5836116,
"domNodes": 80,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 27.823,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1748.1779999999958,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.697,
"layouts": 6,
"layoutDurationMs": 0.539,
"taskDurationMs": 339.36599999999993,
"heapDeltaBytes": 5804668,
"domNodes": 79,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 30.578999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.29000000004,
"styleRecalcs": 33,
"styleRecalcDurationMs": 21.501999999999995,
"layouts": 6,
"layoutDurationMs": 0.7120000000000002,
"taskDurationMs": 349.508,
"heapDeltaBytes": 6308520,
"domNodes": 82,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 29.57,
"eventListeners": 45,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "dom-widget-clipping",
"durationMs": 567.6770000000033,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.327000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 344.7,
"heapDeltaBytes": 13221356,
"domNodes": 21,
"jsHeapTotalBytes": 13893632,
"scriptDurationMs": 64.654,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "dom-widget-clipping",
"durationMs": 613.5879999999929,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.354,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.151,
"heapDeltaBytes": 13414212,
"domNodes": 22,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 69.53,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "dom-widget-clipping",
"durationMs": 600.2719999999613,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.756,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 364.371,
"heapDeltaBytes": 12906160,
"domNodes": 22,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 65.096,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "large-graph-idle",
"durationMs": 2005.8779999999956,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.911000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.27599999999995,
"heapDeltaBytes": -10569676,
"domNodes": 27,
"jsHeapTotalBytes": 7458816,
"scriptDurationMs": 95.843,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947
},
{
"name": "large-graph-idle",
"durationMs": 2019.9160000000234,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.267999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.778,
"heapDeltaBytes": -10388092,
"domNodes": 29,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 98.59500000000001,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-idle",
"durationMs": 2035.5349999999817,
"styleRecalcs": 12,
"styleRecalcDurationMs": 13.106999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.298,
"heapDeltaBytes": -9395016,
"domNodes": 25,
"jsHeapTotalBytes": 8007680,
"scriptDurationMs": 109.016,
"eventListeners": 28,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "large-graph-pan",
"durationMs": 2109.3549999999937,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.153000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1040.225,
"heapDeltaBytes": 2223664,
"domNodes": 20,
"jsHeapTotalBytes": 10018816,
"scriptDurationMs": 385.232,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "large-graph-pan",
"durationMs": 2089.657999999986,
"styleRecalcs": 70,
"styleRecalcDurationMs": 17.402,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1048.2160000000001,
"heapDeltaBytes": 1745076,
"domNodes": 20,
"jsHeapTotalBytes": 8445952,
"scriptDurationMs": 389.052,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "large-graph-pan",
"durationMs": 2127.588000000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.705000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1088.386,
"heapDeltaBytes": 22476856,
"domNodes": 16,
"jsHeapTotalBytes": 6205440,
"scriptDurationMs": 403.351,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "minimap-idle",
"durationMs": 2003.1749999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 525.2520000000001,
"heapDeltaBytes": -12231956,
"domNodes": 18,
"jsHeapTotalBytes": 7483392,
"scriptDurationMs": 97.833,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "minimap-idle",
"durationMs": 2016.368,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.5649999999999,
"heapDeltaBytes": -10895860,
"domNodes": 22,
"jsHeapTotalBytes": 6410240,
"scriptDurationMs": 101.861,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "minimap-idle",
"durationMs": 2001.0110000000054,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.318999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.1179999999999,
"heapDeltaBytes": -11385564,
"domNodes": 22,
"jsHeapTotalBytes": 8245248,
"scriptDurationMs": 102.40199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000073
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.9510000000419,
"styleRecalcs": 49,
"styleRecalcDurationMs": 14.443999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.476,
"heapDeltaBytes": 12128380,
"domNodes": 25,
"jsHeapTotalBytes": 15990784,
"scriptDurationMs": 126.915,
"eventListeners": 32,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.0960000000073,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.655999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.984,
"heapDeltaBytes": 13047968,
"domNodes": 22,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 127.994,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 604.1819999999802,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.299999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 375.03600000000006,
"heapDeltaBytes": 12881384,
"domNodes": 20,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 127.17,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-idle",
"durationMs": 1995.5229999999915,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.09799999999996,
"heapDeltaBytes": 1735576,
"domNodes": 23,
"jsHeapTotalBytes": 17301504,
"scriptDurationMs": 21.816999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-idle",
"durationMs": 2022.6089999999886,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.932999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.409,
"heapDeltaBytes": 1115244,
"domNodes": 22,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 18.853,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-idle",
"durationMs": 2022.6810000000341,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.754000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.525,
"heapDeltaBytes": 885248,
"domNodes": 23,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 20.980999999999995,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1991.8030000000044,
"styleRecalcs": 88,
"styleRecalcDurationMs": 48.883,
"layouts": 16,
"layoutDurationMs": 4.931,
"taskDurationMs": 923.437,
"heapDeltaBytes": -7148660,
"domNodes": 73,
"jsHeapTotalBytes": 17563648,
"scriptDurationMs": 101.758,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.9929999999977,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.069,
"layouts": 16,
"layoutDurationMs": 4.62,
"taskDurationMs": 922.413,
"heapDeltaBytes": -6779768,
"domNodes": 75,
"jsHeapTotalBytes": 14680064,
"scriptDurationMs": 105.633,
"eventListeners": 30,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.9429999999775,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.775999999999996,
"layouts": 16,
"layoutDurationMs": 5.202,
"taskDurationMs": 714.545,
"heapDeltaBytes": -7084624,
"domNodes": 63,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 104.734,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "workflow-execution",
"durationMs": 436.46000000001095,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.004000000000005,
"layouts": 5,
"layoutDurationMs": 1.474,
"taskDurationMs": 125.01300000000002,
"heapDeltaBytes": 4628516,
"domNodes": 169,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 25.453000000000003,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000027
},
{
"name": "workflow-execution",
"durationMs": 458.93100000000686,
"styleRecalcs": 24,
"styleRecalcDurationMs": 25.312,
"layouts": 5,
"layoutDurationMs": 1.383,
"taskDurationMs": 124.194,
"heapDeltaBytes": 4550704,
"domNodes": 182,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 26.455999999999996,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036
},
{
"name": "workflow-execution",
"durationMs": 475.4169999999931,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.721,
"layouts": 5,
"layoutDurationMs": 1.385,
"taskDurationMs": 133.2,
"heapDeltaBytes": 4504452,
"domNodes": 157,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 30.198000000000004,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998
}
]
} |
AustinMroz
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10123, #9967, and #9972 to
cloud/1.42Includes three cherry-picks in dependency order:
fix: resolve all lint warnings(clean)test: harden subgraph test coverage and remove low-value tests(clean)test: subgraph integration contracts and expanded Playwright coverage(1 conflict, auto-resolved by rerere from [backport core/1.41] test: subgraph integration contracts and expanded Playwright coverage #10326)See #10326 for core/1.41 backport with detailed conflict resolution notes.
┆Issue is synchronized with this Notion page by Unito