Skip to content

[backport core/1.42] test: subgraph integration contracts and expanded Playwright coverage - #10327

Merged
DrJKL merged 3 commits into
core/1.42from
backport-10123-to-core-1.42
Mar 20, 2026
Merged

DrJKL merged 3 commits into
core/1.42from
backport-10123-to-core-1.42

Conversation

@DrJKL

@DrJKL DrJKL commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

Backport of #10123, #9967, and #9972 to core/1.42

Includes three cherry-picks in dependency order:

  1. fix: resolve all lint warnings #9972 — fix: resolve all lint warnings (clean)
  2. test: harden subgraph test coverage and remove low-value tests #9967 — test: harden subgraph test coverage and remove low-value tests (clean)
  3. test: subgraph integration contracts and expanded Playwright coverage #10123 — test: subgraph integration contracts and expanded Playwright coverage (1 conflict, auto-resolved by rerere from [backport core/1.41] test: subgraph integration contracts and expanded Playwright coverage #10326)

See #10326 for core/1.41 backport with detailed conflict resolution notes.

┆Issue is synchronized with this Notion page by Unito

DrJKL and others added 3 commits March 19, 2026 17:42
Resolve all lint warnings (3 oxlint + 1 eslint).

## Changes

- Replace `it.todo` with `it.skip` in subgraph tests (`warn-todo`)
- Move `vi.mock` to top-level in `firebaseAuthStore.test.ts`
(`hoisted-apis-on-top`)
- Rename `DOMPurify` default import to `dompurify`
(`no-named-as-default`)

---

### The Villager Who Ignored the Warnings

Once there lived a villager whose compiler whispered of lint. "They are
only *warnings*," she said, and went about her day. One warning became
three. Three became thirty. The yellow text grew like ivy across the
terminal, until no one could tell the warnings from the errors. One
morning a real error appeared — a misplaced mock, a shadowed import —
but nobody noticed, for the village had long since learned to stop
reading. The build shipped. The users wept. And the warning, faithful to
the last, sat quietly in the log where it had always been.

*Moral: Today's warning is tomorrow's incident report.*

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-9972-fix-resolve-all-lint-warnings-3246d73d3650810a89cde5d05e79d948)
by [Unito](https://www.unito.io)

Co-authored-by: Amp <amp@ampcode.com>
## Summary

Harden subgraph test coverage: remove low-value change-detector tests,
consolidate fixtures, add behavioral coverage, and fix test
infrastructure issues. Includes minor production code corrections
discovered during test hardening.

## Changes

- **What**: Comprehensive subgraph test suite overhaul across 6 phases
  - Removed change-detector tests and redundant assertions
- Consolidated fixture helpers into `subgraphHelpers.ts` /
`subgraphFixtures.ts`
  - Added Pinia initialization and fixture reset to all test files
  - Fixed barrel import violations (circular dependency prevention)
  - Added behavioral coverage for slot connections, events, edge cases
  - Added E2E helper and smoke test for subgraph promotion
  - Exported `SubgraphSlotBase` from litegraph barrel for test access
- **Production code changes** (minor correctness fixes found during
testing):
- `resolveSubgraphInputLink.ts`: iterate forward (first-connected-wins)
to match `_resolveLinkedPromotionBySubgraphInput`
- `promotionSchema.ts`: return `[]` instead of throwing on invalid
`proxyWidgets`; console.warn always (not DEV-only)
  - `LGraph.ts`: disconnect-after-veto ordering fix
  - `litegraph.ts`: barrel export swap for `SubgraphSlotBase`
- **Stats**: 349 tests passing, 0 skipped across 26 test files

## Review Focus

- Tests that merely asserted default property values were deleted
(change detectors)
- Fixture state is now reset via `resetSubgraphFixtureState()` in
`beforeEach`
- All imports use `@/lib/litegraph/src/litegraph` barrel to avoid
circular deps
- Production changes are small and directly motivated by test findings

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: bymyself <cbyrne@comfy.org>
…#10123)

Add integration contract tests (unit) and expanded Playwright coverage
for subgraph promotion, hydration, navigation, and lifecycle edge
behaviors.

- **What**: 22 unit/integration tests across 9 files covering promotion
store sync, widget view lifecycle, input link resolution, pseudo-widget
cache, navigation viewport restore, and subgraph operations. 13
Playwright E2E tests covering proxyWidgets hydration stability, promoted
source removal cleanup, pseudo-preview unpack/remove, multi-link
representative round-trip, nested promotion retarget, and navigation
state on workflow switch.
- **Helpers**: Added `isPseudoPreviewEntry`, `getPseudoPreviewWidgets`,
`getNonPreviewPromotedWidgets` to promotedWidgets helper. Added
`SubgraphHelper.getNodeCount()`.

- Test-only PR — no production code changes
- Validates existing subgraph behaviors are covered by regression tests
before further feature work
- Phase 4 (unit/integration contracts) and Phase 5 (Playwright
expansion) of the subgraph test coverage plan

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-10123-test-subgraph-integration-contracts-and-expanded-Playwright-coverage-3256d73d365081258023e3a763859e00)
by [Unito](https://www.unito.io)

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: GitHub Action <action@github.com>
@DrJKL
DrJKL requested a review from a team as a code owner March 20, 2026 00:54
@dosubot dosubot Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Mar 20, 2026
@coderabbitai

coderabbitai Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3ad2d5f3-2a99-4c54-a8e3-1fa844297c44

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch backport-10123-to-core-1.42
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@DrJKL DrJKL added the backport Backporting a PR onto a release candidate label Mar 20, 2026
@github-actions

github-actions Bot commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 03/20/2026, 12:55:46 AM UTC

Links

@github-actions

github-actions Bot commented Mar 20, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 581 passed, 0 failed · 5 flaky

📊 Browser Reports
  • chromium: View Report (✅ 567 / ❌ 0 / ⚠️ 5 / ⏭️ 10)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 11 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

@DrJKL
DrJKL enabled auto-merge (squash) March 20, 2026 00:55
@github-actions

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

⚠️ 2 regressions detected

Metric Baseline PR (n=3) Δ Sig
subgraph-dom-widget-clipping: DOM nodes 23 25 +10% ⚠️ z=2.3
workflow-execution: frame duration 17ms 17ms +3% ⚠️ z=147.8
All metrics
Metric Baseline PR (n=3) Δ Sig
canvas-idle: style recalcs 11 10 -6% z=-1.4
canvas-idle: layouts 0 0 +0% —
canvas-idle: task duration 377ms 377ms +0% z=-0.6
canvas-idle: DOM nodes 22 21 -6% z=-1.2
canvas-idle: script duration 22ms 25ms +11% z=-0.3
canvas-idle: event listeners 11 5 -53% z=-1.3
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: frame duration 17ms 17ms -0% z=-1.0
canvas-mouse-sweep: style recalcs 83 78 -6% z=-0.4
canvas-mouse-sweep: layouts 12 12 +0% —
canvas-mouse-sweep: task duration 1011ms 815ms -19% z=-0.9
canvas-mouse-sweep: DOM nodes 67 60 -10% z=-0.9
canvas-mouse-sweep: script duration 144ms 130ms -10% z=-0.9
canvas-mouse-sweep: event listeners 14 5 -67% z=-1.1
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: frame duration 17ms 17ms -0% z=-1.5
canvas-zoom-sweep: style recalcs 31 31 +1% z=-0.1
canvas-zoom-sweep: layouts 6 6 +0% —
canvas-zoom-sweep: task duration 327ms 298ms -9% z=-1.4
canvas-zoom-sweep: DOM nodes 78 78 -0% z=-1.9
canvas-zoom-sweep: script duration 27ms 25ms -6% z=-0.7
canvas-zoom-sweep: event listeners 19 20 +4% z=-0.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: frame duration 17ms 17ms +0% z=1.2
dom-widget-clipping: style recalcs 13 13 +0% z=0.1
dom-widget-clipping: layouts 0 0 +0% —
dom-widget-clipping: task duration 369ms 353ms -4% z=-0.9
dom-widget-clipping: DOM nodes 22 22 +2% z=0.3
dom-widget-clipping: script duration 70ms 66ms -5% z=-0.6
dom-widget-clipping: event listeners 10 10 +0% variance too high
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: frame duration 17ms 17ms +0% z=-0.1
large-graph-idle: style recalcs 12 11 -3% z=-0.7
large-graph-idle: layouts 0 0 +0% —
large-graph-idle: task duration 502ms 507ms +1% z=-0.8
large-graph-idle: DOM nodes 24 25 +4% z=0.7
large-graph-idle: script duration 97ms 95ms -2% z=-0.7
large-graph-idle: event listeners 21 30 +41% z=0.8
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: frame duration 17ms 17ms -0% z=0.8
large-graph-pan: style recalcs 70 70 +0% z=0.8
large-graph-pan: layouts 0 0 +0% —
large-graph-pan: task duration 1088ms 1066ms -2% z=-0.3
large-graph-pan: DOM nodes 19 19 +4% z=0.3
large-graph-pan: script duration 421ms 404ms -4% z=-0.0
large-graph-pan: event listeners 5 4 -14% z=-1.1
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: frame duration 17ms 17ms +0% z=0.3
minimap-idle: style recalcs 11 10 -12% z=0.3
minimap-idle: layouts 0 0 +0% —
minimap-idle: task duration 503ms 467ms -7% z=-1.3
minimap-idle: DOM nodes 22 19 -12% z=0.3
minimap-idle: script duration 99ms 87ms -12% z=-1.1
minimap-idle: event listeners 5 6 +29% z=1.9
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: frame duration 17ms 17ms +0% z=1.1
subgraph-dom-widget-clipping: style recalcs 49 49 +1% z=1.7
subgraph-dom-widget-clipping: layouts 0 0 +0% —
subgraph-dom-widget-clipping: task duration 381ms 363ms -5% z=-0.8
subgraph-dom-widget-clipping: DOM nodes 23 25 +10% ⚠️ z=2.3
subgraph-dom-widget-clipping: script duration 129ms 122ms -5% z=-0.9
subgraph-dom-widget-clipping: event listeners 16 24 +50% z=1.0
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: frame duration 17ms 17ms +0% z=0.2
subgraph-idle: style recalcs 11 11 +6% z=0.5
subgraph-idle: layouts 0 0 +0% —
subgraph-idle: task duration 341ms 351ms +3% z=-0.8
subgraph-idle: DOM nodes 21 23 +6% z=0.4
subgraph-idle: script duration 18ms 18ms +4% z=-0.9
subgraph-idle: event listeners 5 14 +163% variance too high
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: frame duration 17ms 17ms -0% z=0.5
subgraph-mouse-sweep: style recalcs 82 78 -5% z=-1.4
subgraph-mouse-sweep: layouts 16 16 +0% —
subgraph-mouse-sweep: task duration 784ms 672ms -14% z=-1.6
subgraph-mouse-sweep: DOM nodes 71 66 -6% z=-0.5
subgraph-mouse-sweep: script duration 102ms 99ms -3% z=-0.4
subgraph-mouse-sweep: event listeners 21 20 -3% variance too high
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: frame duration 17ms 17ms -0% z=-0.7
workflow-execution: style recalcs 18 16 -13% z=-1.7
workflow-execution: layouts 5 5 -7% z=-0.9
workflow-execution: task duration 125ms 107ms -14% z=-1.5
workflow-execution: DOM nodes 157 154 -2% z=-1.1
workflow-execution: script duration 32ms 27ms -14% z=-0.7
workflow-execution: event listeners 55 49 -11% z=-0.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: frame duration 17ms 17ms +3% ⚠️ z=147.8
Historical variance (last 10 runs)
Metric μ σ CV
canvas-idle: style recalcs 11 1 4.9%
canvas-idle: layouts 0 0 0.0%
canvas-idle: task duration 397ms 35ms 8.7%
canvas-idle: DOM nodes 22 1 5.9%
canvas-idle: script duration 26ms 2ms 8.9%
canvas-idle: event listeners 10 4 38.6%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: frame duration 17ms 0ms 0.0%
canvas-mouse-sweep: style recalcs 79 2 2.8%
canvas-mouse-sweep: layouts 12 0 0.0%
canvas-mouse-sweep: task duration 866ms 58ms 6.7%
canvas-mouse-sweep: DOM nodes 62 2 3.6%
canvas-mouse-sweep: script duration 136ms 7ms 5.5%
canvas-mouse-sweep: event listeners 9 4 46.3%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: frame duration 17ms 0ms 0.0%
canvas-zoom-sweep: style recalcs 31 0 1.5%
canvas-zoom-sweep: layouts 6 0 0.0%
canvas-zoom-sweep: task duration 330ms 23ms 7.1%
canvas-zoom-sweep: DOM nodes 79 1 0.8%
canvas-zoom-sweep: script duration 28ms 3ms 11.4%
canvas-zoom-sweep: event listeners 23 4 18.4%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: frame duration 17ms 0ms 0.0%
dom-widget-clipping: style recalcs 13 1 4.1%
dom-widget-clipping: layouts 0 0 0.0%
dom-widget-clipping: task duration 368ms 18ms 4.8%
dom-widget-clipping: DOM nodes 22 2 7.1%
dom-widget-clipping: script duration 68ms 4ms 5.6%
dom-widget-clipping: event listeners 8 8 99.9%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: frame duration 17ms 0ms 0.0%
large-graph-idle: style recalcs 12 0 2.7%
large-graph-idle: layouts 0 0 0.0%
large-graph-idle: task duration 554ms 59ms 10.6%
large-graph-idle: DOM nodes 24 1 3.3%
large-graph-idle: script duration 104ms 12ms 11.7%
large-graph-idle: event listeners 25 7 28.2%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: frame duration 17ms 0ms 0.0%
large-graph-pan: style recalcs 70 1 0.9%
large-graph-pan: layouts 0 0 0.0%
large-graph-pan: task duration 1084ms 50ms 4.7%
large-graph-pan: DOM nodes 19 2 9.7%
large-graph-pan: script duration 405ms 23ms 5.7%
large-graph-pan: event listeners 5 1 15.9%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: frame duration 17ms 0ms 0.0%
minimap-idle: style recalcs 9 1 6.9%
minimap-idle: layouts 0 0 0.0%
minimap-idle: task duration 535ms 51ms 9.5%
minimap-idle: DOM nodes 19 1 6.9%
minimap-idle: script duration 99ms 11ms 11.1%
minimap-idle: event listeners 5 1 15.9%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: frame duration 17ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalcs 48 1 1.4%
subgraph-dom-widget-clipping: layouts 0 0 0.0%
subgraph-dom-widget-clipping: task duration 380ms 21ms 5.5%
subgraph-dom-widget-clipping: DOM nodes 22 1 5.7%
subgraph-dom-widget-clipping: script duration 129ms 8ms 5.8%
subgraph-dom-widget-clipping: event listeners 17 7 41.7%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: frame duration 17ms 0ms 0.0%
subgraph-idle: style recalcs 11 1 6.9%
subgraph-idle: layouts 0 0 0.0%
subgraph-idle: task duration 375ms 31ms 8.3%
subgraph-idle: DOM nodes 22 2 7.8%
subgraph-idle: script duration 21ms 3ms 12.7%
subgraph-idle: event listeners 12 8 63.4%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: frame duration 17ms 0ms 0.0%
subgraph-mouse-sweep: style recalcs 80 2 2.2%
subgraph-mouse-sweep: layouts 16 0 0.0%
subgraph-mouse-sweep: task duration 784ms 70ms 9.0%
subgraph-mouse-sweep: DOM nodes 67 2 3.1%
subgraph-mouse-sweep: script duration 102ms 7ms 7.3%
subgraph-mouse-sweep: event listeners 8 4 51.6%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: frame duration 17ms 0ms 0.0%
workflow-execution: style recalcs 18 1 6.8%
workflow-execution: layouts 5 0 5.6%
workflow-execution: task duration 124ms 12ms 9.5%
workflow-execution: DOM nodes 161 6 3.8%
workflow-execution: script duration 30ms 4ms 11.8%
workflow-execution: event listeners 52 4 7.9%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: frame duration 17ms 0ms 0.0%
Trend (last 10 commits on main)
Metric Trend Dir Latest
canvas-idle: style recalcs █▅▁▃▁▃▆█▆█ ➡️ 12
canvas-idle: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: task duration ▃▃▅▆▂█▃▁▃▃ ➡️ 391ms
canvas-idle: DOM nodes █▄▁▂▂▅▆▆▇▇ ➡️ 24
canvas-idle: script duration ▅▃▆▇▅█▄▁▅▆ ➡️ 27ms
canvas-idle: event listeners █▂▁▂▇██▂█▆ 📈 11
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: frame duration ▁▆█▆▆▃▁▁▃▁ ➡️ 17ms
canvas-mouse-sweep: style recalcs ▂▁▄▄▆▇▆▃█▅ ➡️ 79
canvas-mouse-sweep: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: task duration ▃▂▄▄▅█▆▁▆▄ ➡️ 868ms
canvas-mouse-sweep: DOM nodes ▁▁▄▂▅█▇▃▆▆ ➡️ 64
canvas-mouse-sweep: script duration ▆▆▆▅▅█▆▁▅▆ ➡️ 139ms
canvas-mouse-sweep: event listeners ▁▇▁▁▁██▇▁█ 📈 13
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: frame duration ▄▁██▁▅██▅▄ ➡️ 17ms
canvas-zoom-sweep: style recalcs ▃▆█▄▄▆▁▆▁▆ ➡️ 32
canvas-zoom-sweep: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: task duration ▂▄▅▆▃█▄▁▁▅ ➡️ 338ms
canvas-zoom-sweep: DOM nodes ▁▄█▅▆▆▄▃▅▄ ➡️ 79
canvas-zoom-sweep: script duration ▂▅▇▆▅█▄▁▂▆ ➡️ 30ms
canvas-zoom-sweep: event listeners ▂▂█▁██▇▁█▁ ➡️ 19
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: frame duration ▁▁▁█▁▁███▁ ➡️ 17ms
dom-widget-clipping: style recalcs ▄█▇▇▁▇▄▇▂▅ ➡️ 13
dom-widget-clipping: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: task duration ▃▅▆▅▂▇█▁▅▅ ➡️ 371ms
dom-widget-clipping: DOM nodes ▄█▇▅▁▅▄▇▃▄ ➡️ 21
dom-widget-clipping: script duration ▅▇▇▆▃█▇▁▇▇ ➡️ 71ms
dom-widget-clipping: event listeners ▅██▁▁▁▁█▁▁ 📉 2
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: frame duration ▄█▇▅▇▇▅▅▁▇ ➡️ 17ms
large-graph-idle: style recalcs ▁▃▆▃▆▆▃▆██ ➡️ 12
large-graph-idle: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: task duration ▃▃▇▅▃██▁▂▅ ➡️ 569ms
large-graph-idle: DOM nodes ▃▁▂▃▆▆▇▂█▆ ➡️ 25
large-graph-idle: script duration ▅▅▇▆▅█▆▁▃▆ ➡️ 110ms
large-graph-idle: event listeners █▄▁▄▇▇█▂█▇ 📈 29
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: frame duration ▂▁▂▄▅▄▂▂▅█ ➡️ 17ms
large-graph-pan: style recalcs ▂▂▂▁▇▅▃█▆▃ ➡️ 69
large-graph-pan: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: task duration ▄▄▆▄▄█▆▁▂▅ ➡️ 1100ms
large-graph-pan: DOM nodes ▁▃▁▁▅▁▂█▅▂ ➡️ 18
large-graph-pan: script duration ▅▄▆▄▅█▄▁▄▅ ➡️ 413ms
large-graph-pan: event listeners ▆▁▁▃▆▁▃██▃ ➡️ 5
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: frame duration ▃▁█▆▆▆▆█▁▆ ➡️ 17ms
minimap-idle: style recalcs ▄█▁▂▇▂▁▇█▄ ➡️ 9
minimap-idle: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: task duration ▃▄▅▇▃█▅▁▁▅ ➡️ 547ms
minimap-idle: DOM nodes ▄█▁▂▇▂▁▇█▄ ➡️ 19
minimap-idle: script duration ▅▆▆▇▅█▅▁▃▆ ➡️ 106ms
minimap-idle: event listeners ▁▃▁▁▆▁▃█▆▁ ➡️ 4
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: frame duration ▁█▆▆▃▃▆█▆█ ➡️ 17ms
subgraph-dom-widget-clipping: style recalcs ▃▁▆█▇▃▆▇█▅ ➡️ 48
subgraph-dom-widget-clipping: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: task duration ▅▂▅█▂▆█▁▂▇ ➡️ 398ms
subgraph-dom-widget-clipping: DOM nodes ▂▁▅▅▅▁▇▅█▄ ➡️ 22
subgraph-dom-widget-clipping: script duration ▅▂▄█▂▅▇▁▂▅ ➡️ 131ms
subgraph-dom-widget-clipping: event listeners ▁▅██▁▁█▅█▅ 📈 16
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: frame duration ▄█▄▄▄▃▁▆▃▃ ➡️ 17ms
subgraph-idle: style recalcs ▅▁▂▁▆▃▃██▇ ➡️ 12
subgraph-idle: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: task duration ▁▃▆▅▂█▅▁▁▄ ➡️ 378ms
subgraph-idle: DOM nodes ▄▁▂▁▅▃▂▇█▇ ➡️ 24
subgraph-idle: script duration ▂▃▇▆▂█▅▂▁▅ ➡️ 22ms
subgraph-idle: event listeners ▁▁▁▁▅▄▁███ 📈 21
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: frame duration ▃▆▆▆▃▆▁▃▆█ ➡️ 17ms
subgraph-mouse-sweep: style recalcs ▄▂▄█▅▆▃▁▃▄ ➡️ 81
subgraph-mouse-sweep: layouts ▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: task duration ▄▄▅▇▄█▆▁▃▅ ➡️ 785ms
subgraph-mouse-sweep: DOM nodes ▃▂▃█▄▅▃▁▄▃ ➡️ 66
subgraph-mouse-sweep: script duration ▅▆▇▆▅██▁▄▆ ➡️ 105ms
subgraph-mouse-sweep: event listeners ▁▁▁█▇▂▁▇▇▁ ➡️ 5
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: frame duration ▄▆▄▆▃▃█▁▃▃ ➡️ 17ms
workflow-execution: style recalcs ▃▆█▇▆▆▇▃▄▁ ➡️ 15
workflow-execution: layouts ▆▆▁▆▆█▆▃▆▃ ➡️ 5
workflow-execution: task duration ▄▆▆▆▁▇█▁▃▃ ➡️ 120ms
workflow-execution: DOM nodes ▄▃▅▃█▃▃▄▃▁ ➡️ 152
workflow-execution: script duration ▅▄▅▆▂▇█▁▃▄ ➡️ 29ms
workflow-execution: event listeners ▄███▁██▄█▄ ➡️ 49
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: frame duration ▆▃▄▁▄█▆▅▄▆ ➡️ 17ms
Raw data
{
  "timestamp": "2026-03-20T01:00:40.497Z",
  "gitSha": "8e494035ac37e3e6e3e862d19f12d073049e52a6",
  "branch": "backport-10123-to-core-1.42",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2023.157000000026,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.485000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.93800000000005,
      "heapDeltaBytes": 2174792,
      "domNodes": 20,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 26.162000000000006,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "canvas-idle",
      "durationMs": 2024.1190000000415,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.507000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 350.732,
      "heapDeltaBytes": 1080140,
      "domNodes": 22,
      "jsHeapTotalBytes": 17563648,
      "scriptDurationMs": 23.205,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "canvas-idle",
      "durationMs": 2027.2879999999986,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.507,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 366.98900000000003,
      "heapDeltaBytes": 1365772,
      "domNodes": 20,
      "jsHeapTotalBytes": 17301504,
      "scriptDurationMs": 25.403999999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000036
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1792.0239999999694,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 35.724,
      "layouts": 12,
      "layoutDurationMs": 3.394,
      "taskDurationMs": 756.849,
      "heapDeltaBytes": -3244760,
      "domNodes": 57,
      "jsHeapTotalBytes": 18350080,
      "scriptDurationMs": 133.53799999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1781.5559999999664,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 35.956,
      "layouts": 12,
      "layoutDurationMs": 3.2169999999999996,
      "taskDurationMs": 713.6510000000001,
      "heapDeltaBytes": -2772744,
      "domNodes": 58,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 126.423,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2026.262000000031,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 42.428999999999995,
      "layouts": 12,
      "layoutDurationMs": 3.692,
      "taskDurationMs": 974.774,
      "heapDeltaBytes": -2818460,
      "domNodes": 66,
      "jsHeapTotalBytes": 16777216,
      "scriptDurationMs": 129.82200000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1760.7909999999833,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.046000000000003,
      "layouts": 6,
      "layoutDurationMs": 0.8050000000000002,
      "taskDurationMs": 308.093,
      "heapDeltaBytes": 5806232,
      "domNodes": 77,
      "jsHeapTotalBytes": 17563648,
      "scriptDurationMs": 27.224999999999994,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.2650000000363,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 19.503,
      "layouts": 6,
      "layoutDurationMs": 0.533,
      "taskDurationMs": 296.42400000000004,
      "heapDeltaBytes": 5728400,
      "domNodes": 80,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 23.905,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1747.6609999999937,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.251,
      "layouts": 6,
      "layoutDurationMs": 0.6349999999999999,
      "taskDurationMs": 289.691,
      "heapDeltaBytes": 5819664,
      "domNodes": 77,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 25.325,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 598.7510000000498,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 9.432,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 371.82800000000003,
      "heapDeltaBytes": 11623832,
      "domNodes": 22,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 69.339,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000027
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 575.3460000000246,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.667000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.495,
      "heapDeltaBytes": 13215920,
      "domNodes": 23,
      "jsHeapTotalBytes": 14942208,
      "scriptDurationMs": 65.03099999999999,
      "eventListeners": 26,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 564.2280000000142,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 8.186999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.976,
      "heapDeltaBytes": 13318144,
      "domNodes": 22,
      "jsHeapTotalBytes": 15466496,
      "scriptDurationMs": 63.745999999999995,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000036
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1995.0910000000022,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 13.419999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 549.6620000000001,
      "heapDeltaBytes": -10768416,
      "domNodes": 25,
      "jsHeapTotalBytes": 9318400,
      "scriptDurationMs": 100.982,
      "eventListeners": 30,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1999.6229999999855,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 11.888,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.63700000000006,
      "heapDeltaBytes": -10004936,
      "domNodes": 23,
      "jsHeapTotalBytes": 8769536,
      "scriptDurationMs": 90.001,
      "eventListeners": 30,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.290000000041,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 12.463999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.65099999999995,
      "heapDeltaBytes": -10657552,
      "domNodes": 27,
      "jsHeapTotalBytes": 8507392,
      "scriptDurationMs": 94.93499999999999,
      "eventListeners": 30,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2108.8530000000105,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 17.302999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1089.745,
      "heapDeltaBytes": 5862388,
      "domNodes": 20,
      "jsHeapTotalBytes": 8450048,
      "scriptDurationMs": 409.821,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2153.1590000000165,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 18.683,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1051.445,
      "heapDeltaBytes": 3697848,
      "domNodes": 22,
      "jsHeapTotalBytes": 9756672,
      "scriptDurationMs": 396.54699999999997,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2095.195999999987,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 15.955999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1057.8410000000001,
      "heapDeltaBytes": 2876044,
      "domNodes": 16,
      "jsHeapTotalBytes": 10805248,
      "scriptDurationMs": 406.581,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000036
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.8770000000218,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.629999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 461.59099999999995,
      "heapDeltaBytes": -12158676,
      "domNodes": 18,
      "jsHeapTotalBytes": 8769536,
      "scriptDurationMs": 82.819,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000036
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.0459999999694,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.584,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.202,
      "heapDeltaBytes": -9892444,
      "domNodes": 20,
      "jsHeapTotalBytes": 9056256,
      "scriptDurationMs": 90.873,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.680000000000017
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.63800000001,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.701,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.44800000000004,
      "heapDeltaBytes": -11858696,
      "domNodes": 20,
      "jsHeapTotalBytes": 6148096,
      "scriptDurationMs": 86.99399999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 557.4030000000221,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 11.921,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 354.745,
      "heapDeltaBytes": 12929912,
      "domNodes": 22,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 122.745,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.65999999999999
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 559.426999999971,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 14.584,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.233,
      "heapDeltaBytes": 13011200,
      "domNodes": 27,
      "jsHeapTotalBytes": 16515072,
      "scriptDurationMs": 123.16900000000001,
      "eventListeners": 32,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.7299999999786,
      "styleRecalcs": 50,
      "styleRecalcDurationMs": 13.649,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 370.072,
      "heapDeltaBytes": 11902076,
      "domNodes": 26,
      "jsHeapTotalBytes": 15990784,
      "scriptDurationMs": 120.43200000000002,
      "eventListeners": 32,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1999.6140000000082,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.383000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.112,
      "heapDeltaBytes": 1150196,
      "domNodes": 21,
      "jsHeapTotalBytes": 14680064,
      "scriptDurationMs": 21.068,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "subgraph-idle",
      "durationMs": 1989.7760000000062,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.129,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 333.27099999999996,
      "heapDeltaBytes": -2914900,
      "domNodes": 22,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 16.868,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000073
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.4760000000065,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 11.372,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 347.522,
      "heapDeltaBytes": -5529488,
      "domNodes": 25,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 17.226000000000006,
      "eventListeners": 30,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.254999999961,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 40.428000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.699,
      "taskDurationMs": 697.795,
      "heapDeltaBytes": -7134600,
      "domNodes": 64,
      "jsHeapTotalBytes": 17563648,
      "scriptDurationMs": 102.67499999999998,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.4729999999604,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 38.559000000000005,
      "layouts": 16,
      "layoutDurationMs": 4.151,
      "taskDurationMs": 676.538,
      "heapDeltaBytes": -6350752,
      "domNodes": 68,
      "jsHeapTotalBytes": 17301504,
      "scriptDurationMs": 99.44500000000001,
      "eventListeners": 28,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1681.4390000000117,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 37.303000000000004,
      "layouts": 16,
      "layoutDurationMs": 4.319,
      "taskDurationMs": 642.772,
      "heapDeltaBytes": 13120488,
      "domNodes": 67,
      "jsHeapTotalBytes": 24903680,
      "scriptDurationMs": 94.743,
      "eventListeners": 28,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.659999999999947
    },
    {
      "name": "workflow-execution",
      "durationMs": 99.71300000000838,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 16.52,
      "layouts": 5,
      "layoutDurationMs": 1.442,
      "taskDurationMs": 86.83299999999997,
      "heapDeltaBytes": 3005236,
      "domNodes": 151,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 25.059000000000005,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999973
    },
    {
      "name": "workflow-execution",
      "durationMs": 440.91299999996636,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.044999999999998,
      "layouts": 4,
      "layoutDurationMs": 1.008,
      "taskDurationMs": 111.52500000000002,
      "heapDeltaBytes": 4302144,
      "domNodes": 155,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 24.818000000000005,
      "eventListeners": 55,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    },
    {
      "name": "workflow-execution",
      "durationMs": 436.992000000032,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 24.215,
      "layouts": 5,
      "layoutDurationMs": 1.365,
      "taskDurationMs": 122.98400000000001,
      "heapDeltaBytes": 4433876,
      "domNodes": 155,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 31.903000000000002,
      "eventListeners": 55,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998
    }
  ]
}

@DrJKL
DrJKL merged commit fe489ec into core/1.42 Mar 20, 2026
42 checks passed
@DrJKL
DrJKL deleted the backport-10123-to-core-1.42 branch March 20, 2026 01:24
@comfy-pr-bot comfy-pr-bot added the released:core PR has been released to core label Mar 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate released:core PR has been released to core size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants