Skip to content

Deleting a DynamicGroup row leaves outer subgraph widgets and promotion links #20180

Closed

Description

@jaeone94

What happened?

Deleting a DynamicGroup row promoted through two nested subgraphs removes its immediate promotion, but leaves the outer host's combo, numeric input and switch visible. Three connections also remain between the outer subgraph inputs and the inner host. Real backend execution correctly omits the deleted row. Draft reload removes the stale outer controls, so this is an immediate cleanup/propagation failure rather than evidence that deleted rows execute.

Steps to reproduce

  1. Add three rows A/B/C to the DynamicGroup devtool node.
  2. Convert the node to a subgraph and promote row B's filename, strength and enabled widgets.
  3. Wrap that host in another subgraph and promote the same widgets again.
  4. Enter both subgraphs and delete row B.
  5. Return to the root: B's three controls remain on the outer host. The intermediate subgraph also retains three promotion connections.
  6. Queue the workflow: only A/C reach the backend. Reload the draft: the stale controls disappear.

Expected behavior

Removing B should immediately remove its promoted controls and connections at every boundary, without a reload. The surviving A/C rows and output connection must remain usable.

Acceptance criteria

  • Clear the deleted row's widget projections and promotion links through both boundaries.
  • Preserve surviving rows and the output connection.
  • Pass the existing removes promotion at both boundaries when the interior row is deleted E2E before and after reload, without weakening its assertions.

Environment and regression coverage

Reproduced locally with Node 2.0, headless Chrome on macOS, frontend commit c2ba6f397ec7fa0bd5d5b93562a1b9d141fc37c9, and core commit 2d2fa46e18d293ced1b958fe288730e2ef4b322e. The only custom node used is the repository's model-free DevToolsNodeWithDynamicGroup echo node. No model files are required.

Start from the DynamicGroup workflow fixture. The UI setup and a failing regression test are included in #17510 — test: verify DynamicGroup in a dedicated backend E2E job, in browser_tests/tests/vueNodes/widgets/dynamicGroup.spec.ts.

Activity

  1. added a commit that references this issue on Oct 6, 2026
    65d257e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions