Skip to content

DynamicGroup row labels stay stale through nested subgraph promotion #20179

Closed

Description

@jaeone94

What happened?

When a DynamicGroup row is promoted through two nested subgraphs, removing a preceding row leaves the outer host's labels at the old row number. The inner row moves correctly, and the edited values and real backend execution still refer to the intended row. The stale outer label also survives draft reload.

Steps to reproduce

  1. Add three rows A/B/C to the DynamicGroup devtool node.
  2. Convert the node to a subgraph and promote row B's filename, strength and enabled widgets.
  3. Wrap that host in another subgraph, then promote the same three widgets to the outer host.
  4. Edit the outer strength and enabled widgets. Enter both subgraphs and delete row A.
  5. Return to the root. The surviving B row is now row 1, but the outer controls still say LoRA #2.
  6. Refresh the tab and restore the unsaved draft; the stale labels remain.

Expected behavior

The outer labels should change to LoRA #1, remain bound to B's values, and retain that state after draft restoration.

Acceptance criteria

  • Propagate row-label changes through both promotion boundaries.
  • Keep the edited values and exported/executed prompt on the same surviving row.
  • Pass the existing keeps top-level edits on the same row after its index changes across two boundaries E2E without weakening its assertions.

Environment and regression coverage

Reproduced locally with Node 2.0, headless Chrome on macOS, frontend commit c2ba6f397ec7fa0bd5d5b93562a1b9d141fc37c9, and core commit 2d2fa46e18d293ced1b958fe288730e2ef4b322e. The only custom node used is the repository's model-free DevToolsNodeWithDynamicGroup echo node. No model files are required.

Start from the DynamicGroup workflow fixture. The UI setup and a failing regression test are included in #17510 — test: verify DynamicGroup in a dedicated backend E2E job, in browser_tests/tests/vueNodes/widgets/dynamicGroup.spec.ts.

Activity

  1. added a commit that references this issue on Oct 6, 2026
    65d257e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions