Repository navigation
Description
Source-first blocker discovered by the core/1.55 carrier gate
Frontend #19959 carries merged source #11420 faithfully, but the carrier's exact-head review panel found ten unresolved defects in the merged source. The carrier must remain held: fixing only core/1.55 would hide defects on main and strand the other release lines.
Source commit: 33095f79ee5b438021e7e9d5509d5590b9229355 (#11420)
Observed carrier head: 5eb5832247685c823f6fe03bf46d53496fbc74bd (#19959, core/1.55)
Required source fixes
- Restore the foreground 2D context DPR transform after
measureViewportFromElement()probeswidth/height, including same-rounded-backing-size measurements: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907716. - Reject a superseded graph load before its first destructive store/canvas mutation: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907719.
- Re-check graph-load ownership after awaited lifecycle hooks before workflow-binding or graph-derived side effects: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907723.
- Preserve CSS-pixel layout for legacy explicit-dimension
LGraphCanvas.resize(width, height)calls at DPR > 1: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907729. - Do not classify class/computed-size canvases as caller-unsized and pin them to inline pixels (especially 0x0): [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907736.
- Make
DragAndScale's cached viewport robust to cached 0x0, element replacement, and caller mutation: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907738. - Give fitting/framing a usable fallback when the visible Agent-panel subtraction produces an empty viewport: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907740.
- Cancel or visit-key a queued first-visit subgraph fit when an A→B→A cache hit restores A: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907745.
- Make concurrent graph-load loading state ownership-aware rather than allowing a stale load's
finallyto clear the shared boolean: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907749. - Recompute the canvas LOD threshold when
applyViewport()changes DPR: [backport core/1.55] refactor(canvas): centralize viewport lifecycle and framing #19959 discussion 4170907754.
Each finding is present in the source implementation, and none of these files is touched by #19959's carrier-only adaptation commit. The first three were also traced directly through the exact source/carrier control flow; they are not speculative carrier conflicts.
Closure and release dependency
Please fix on main with focused regression tests (user-visible browser coverage where applicable), then backport the merged source fix to core/1.55 before #19959 is merged. Re-run #19959's target-aware exact-head gate after the dependency lands or the carrier is rebuilt. The existing needs-backport / core/1.55 labels make this release dependency explicit.
Owner: @christian-byrne (source PR author and assignee). Carrier gate: #19959.
Activity
refactor: drop the justification comments flagged in review
fix(workflow): stop a superseded load activating inside afterLoadNewG…
fix(canvas): split viewport lifecycle and framing repairs (#20025)
fix(canvas): split viewport lifecycle and framing repairs (Comfy-Org#…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from #1…
fix(canvas): repair viewport and graph-load lifecycle defects from Co…