Skip to content

ComfyUI backport release v0.44.2 - #17583

Closed
comfyui-wiki wants to merge 24 commits into
masterfrom
backport/v0.44.2-full-patch
Closed

comfyui-wiki wants to merge 24 commits into
masterfrom
backport/v0.44.2-full-patch

Conversation

@comfyui-wiki

Copy link
Copy Markdown
Member

Backport for v0.44.2, cut from v0.44.1.

Cherry-picked from master, oldest first:

The two workflow-templates bumps (#17541, #17563) are skipped: v0.44.1 already pins comfyui-workflow-templates==0.11.103, so both picks would be empty. requirements.txt ends at the tag's pins plus the frontend and comfy-kitchen bumps above.

Version files untouched; the Backport Release workflow bumps them.

API Node PR Checklist

Scope

  • Is API Node Change

Pricing & Billing

  • Need pricing update
  • No pricing update

If Need pricing update:

  • Metronome rate cards updated
  • Auto-billing tests updated and passing

QA

  • QA done
  • QA not required

Comms

  • Informed Kosinkadink

bigcat88 and others added 24 commits November 6, 2026 10:47
…ideo nodes (#17509)

Signed-off-by: bigcat88 <bigcat88@icloud.com>
Signed-off-by: bigcat88 <bigcat88@icloud.com>
…ear Weights (#17361)

* Run optimize_for_gemv from pin_modules

Move the resident-weight relayout out of the cast miss path to a hit in
pin_modules, once per residency after the block's prefetch has fully
faulted and resolved. A weight is then never rewritten in place while
its transfer is in flight, and every forward in a step sees one layout.
The resident bytes already carry any baked lowvram patch and a fully
faulted block has no runtime weight functions, so the patch guards go.

* Combine compatible linears at first residency

Models declare comfy.ops.CombinedLinear groups over consecutive VBAR
linears; the dynamic loader loads a group's members back to back so
their allocations are consecutive. When a prefetched block fully hits,
pin_modules concatenates each group's resident weights in place with
cat_gathered, which saves the members' metadata, memmoves the codes
down over it and rewrites the metadata after them in the same layout
interpret_gathered_like would give one weight of the summed rows. The
members' weights are gone after that; the group then takes its turn in
the same optimize_for_gemv pass as a lone module, under its own
comfy_gemv_optimized flag that the model sets. The model executes the
group as one GEMM through CombinedLinear.forward or linear_input_act
and owns the split path when the group declines.

Combining moves bytes across member allocations, so a combined group
hits or misses as a whole: cast_modules_with_vbar faults all of a
group's members when it reaches the first one, and if any of them
missed, the group is dropped and every member reloads its canonical
weight in that same pass. A member's early fault is its pin for the
step, so no pin is taken twice and nothing is refaulted.

* Combine Qwen text-encoder projections with CombinedLinear

Qwen3 attention q/k/v and MLP gate/up, Qwen3.5 GatedDeltaNet qkv/z and GatedAttention q/k/v now run one combined GEMM when the resident weights share a quantized layout, falling back to the split projections otherwise.

* requirements: roll forward comfy-kitchen

* Make CombinedLinear follow its members' full precision setting

Text encoders load with full_precision_mm and CLIP.generate lifts it only
for the generation. The combined weight was built inside that window and
then kept running the quantized kernel for the following encode, which
emits the compute dtype into the encoder's float32 attention mask
("invalid dtype for bias" in SDPA) and silently skips full precision.
Read the flag live from the members and dequantize like they do.

* Resolve, combine and relayout a prefetched block on its first residency

pin_modules only resolved, combined and relaid out a block on a hit, so a
cold step ran the canonical layout eagerly and the first MMA decode of
the relaid weight was captured into the CUDA graph on the next hit.
Gate that work on every module having a VBAR slot and no runtime weight
function instead, and keep the hit requirement only for graph capture.
A miss is now resolved at pin time, so the eager warm pass runs the same
kernels the graph captures.

* Fault a combined group's members once when the group is dropped

cast_modules_with_vbar faults every member of a combined group when it
reaches the first one. If a member missed, the group was dropped in that
same iteration, so the later members saw an uncombined group and faulted
again. VBAR pins are counted and cleanup unpins once, so every partial
miss of a combined group leaked a pin and left those pages unevictable.

* Decline combining members the combined path cannot serve

A member with a per-call weight function or forced cast weights is transformed
on the split path every forward; the combined weight would skip that. A layout
without a linear_input_act kernel returns NotImplemented from the combined
forward, and the callers' split fallback then finds the members' weights gone.

* tests: cat_gathered, CombinedLinear residency combining and Qwen 3.5 decode paths
Makes `@comfyui-wiki` and `@purzbeats` code owners of
`/comfy_api_nodes/`, so the partner node team is eligible to approve
partner node PRs.
@comfyui-wiki

Copy link
Copy Markdown
Member Author

Closing: scope too broad for a partner-nodes patch. Re-cut as a partner-nodes-only backport.

@comfyui-wiki
comfyui-wiki deleted the backport/v0.44.2-full-patch branch November 6, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants