Skip to content

chore: fail the CodeRabbit status when the review did not run - #15382

Merged
alexisrolland merged 1 commit into
masterfrom
chore/coderabbit-fail-commit-status
Aug 7, 2026
Merged

alexisrolland merged 1 commit into
masterfrom
chore/coderabbit-fail-commit-status

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Aug 7, 2026 •

Copy link
Copy Markdown
Contributor

.coderabbit.yaml sets commit_status: true but leaves fail_commit_status at its default of false. Per the CodeRabbit v2 schema, fail_commit_status is what makes review errors fail the outward status surface; without it, a review that never ran still posts green.

Measured, on Comfy-Org/workflow_templates#1092:

$ gh api repos/.../commits/36659b8d/statuses
{"context":"CodeRabbit","state":"pending","description":"Review queued"}
{"context":"CodeRabbit","state":"pending","description":"Review in progress"}
{"context":"CodeRabbit","state":"success","description":"Review rate limited"}

state: success. A throttled review is indistinguishable from a clean one at a glance, and gh pr checks prints it as pass.

This is not theoretical on this repo. Five PRs in one recent batch ended with no automated review at all while showing green, and one PR needed four @coderabbitai review invocations before a review actually ran — the one that ran found a Critical.

Caveat, stated plainly: the schema documents fail_commit_status as applying to "review errors". Whether CodeRabbit classifies a rate limit as an error is not something I can prove from outside — the flag is the only relevant knob in the schema (review_status, commit_status, fail_commit_status are the complete set), and the failure mode is worth closing if it does apply. If it turns out not to cover rate limits, that is worth raising with CodeRabbit rather than living with a green check that means nothing.

Companion change for the frontend: Comfy-Org/ComfyUI_frontend#14880

reviews.fail_commit_status defaults to false, so when CodeRabbit is rate
limited it posts state=success with description "Review rate limited"
and an unreviewed PR is indistinguishable from a cleanly reviewed one.
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 59f7c382-1512-4911-a3bd-fabea44ad73d

📥 Commits

Reviewing files that changed from the base of the PR and between a464ac3 and 5e6a7b5.

📒 Files selected for processing (1)
  • .coderabbit.yaml
📜 Recent review details
⏰ Context from checks skipped due to timeout. (9)
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (windows-latest)
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test (macos-latest)
  • GitHub Check: test (ubuntu-latest)
  • GitHub Check: test (windows-2022)
  • GitHub Check: test
  • GitHub Check: Run Pylint
  • GitHub Check: Run Pylint
🧰 Additional context used
🧠 Learnings (9)
📚 Learning: 2026-03-31T08:02:32.334Z
Learnt from: KohakuBlueleaf
Repo: Comfy-Org/ComfyUI PR: 13135
File: comfy_extras/nodes_train.py:202-218
Timestamp: 2026-03-31T08:02:32.334Z
Learning: In `comfy_extras/nodes_train.py`, treat the `TrainSampler._vram_info()` method and the entire `--dev-mode`/`dev_run` training path as intentionally CUDA-only. These code paths are meant for CUDA memory profiling/debugging during training, and CPU-only environments are an unsupported configuration. Therefore, do not report `torch.cuda.is_available()` guard omissions or similar CUDA-availability checks in `_vram_info` or `_fwd_bwd_dev` as bugs for this feature/path.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-04-18T14:11:38.853Z
Learnt from: Haoming02
Repo: Comfy-Org/ComfyUI PR: 11571
File: comfy_extras/nodes_sage3.py:0-0
Timestamp: 2026-04-18T14:11:38.853Z
Learning: In `comfy_extras/nodes_sage3.py`, treat `sage3` as a local alias used only for readability/line width and do not flag it as a naming inconsistency with `attention3_sage`, the official attention function name registered in `comfy/ldm/modules/attention.py` (e.g., via `get_attention_function`).

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-04-22T17:54:32.715Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 13519
File: comfy_api_nodes/nodes_openai.py:360-361
Timestamp: 2026-04-22T17:54:32.715Z
Learning: In `comfy_api_nodes/nodes_openai.py`, `price_extractor`/price calculation functions should report the actual post-generation costs. When reviewing, do not require splitting/rounding out token-price differences that are smaller than what ComfyUI’s billing UI can show (it rounds to cents), e.g., modality splits whose impact is below roughly ~$0.001 for typical prompt sizes; such micro-differences are intentionally not separated for simplicity. If the UI threshold would make the difference visible, then it should be reflected in the reported prices.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-04-29T23:29:58.457Z
Learnt from: drozbay
Repo: Comfy-Org/ComfyUI PR: 13565
File: comfy_extras/nodes_lt.py:350-368
Timestamp: 2026-04-29T23:29:58.457Z
Learning: In `comfy_extras/nodes_lt.py` for the `LTXVAddGuide` node, treat the `dilated_mask` returned by `dilate_latent()` as intentional IC-LoRA grid-occupancy metadata: unsampled/filler cells are set to `-1.0` and sampled/grid positions to `1.0`. The downstream `append_keyframe` logic must interpret this `guide_mask` as occupancy (not the standard `[0,1]` denoise-strength-style `noise_mask`). Do not flag `-1.0` as a bug or normalization mistake in this path, as it matches the reference Lightricks ComfyUI-LTXVideo custom node behavior.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-05-04T17:10:08.058Z
Learnt from: rattus128
Repo: Comfy-Org/ComfyUI PR: 13701
File: comfy/model_management.py:731-732
Timestamp: 2026-05-04T17:10:08.058Z
Learning: In Comfy-Org/ComfyUI’s aimdo integration (comfy_aimdo) inside `load_models_gpu`, the model loaded last is treated as highest priority. When aimdo is involved, ensure the diffusion model (the one passed first by the caller) is loaded last by reversing the `models` list before the load loop. This is why `models.reverse()` in `comfy/model_management.py` is intentional and should not be removed or reordered without preserving the “loaded last = top priority” behavior.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-05-07T17:59:24.369Z
Learnt from: bigcat88
Repo: Comfy-Org/ComfyUI PR: 13753
File: comfy_api_nodes/nodes_gemini.py:1148-1157
Timestamp: 2026-05-07T17:59:24.369Z
Learning: In this repo’s ComfyUI frontend, `IO.PriceBadge` JSONata expressions that rely on widget values being lowercased before evaluation should not be flagged as a case-mismatch bug. If you see lookups like `$lookup($prices, $r)` where `$prices` keys are lowercase (e.g. "1k", "2k") but the combo widget options are uppercase (e.g. "1K", "2K"), treat it as correct behavior and do not report it as incorrect casing.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-05-09T02:08:09.260Z
Learnt from: MillerMedia
Repo: Comfy-Org/ComfyUI PR: 13806
File: openapi.yaml:2578-2582
Timestamp: 2026-05-09T02:08:09.260Z
Learning: In the ComfyUI cloud runtime, ensure the `GET /api/experiment/nodes` (`getNodeInfoSchema`) and `GET /api/experiment/nodes/{id}` (`getNodeByID`) endpoints return schemas rendered from a static template once at process/pod startup (with empty model/user-file context). Because custom nodes are baked into the container image at build time and there is no runtime install/uninstall mutation flow, the cached response bytes/ETag must remain valid for the entire pod lifetime—do not add request-scoped rendering or cache invalidation logic unless a runtime node mutation flow is introduced.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-05-19T19:15:34.710Z
Learnt from: Talmaj
Repo: Comfy-Org/ComfyUI PR: 13853
File: comfy/image_encoders/dino2.py:532-536
Timestamp: 2026-05-19T19:15:34.710Z
Learning: In comfy/image_encoders/dino2.py, within get_intermediate_layers_da3(), the export path for "export_feat_layers" in the da3 implementation should intentionally use `x` (current layer output, which may be global on odd alt-attention layers) rather than `local_x`. Treat this as matching the upstream Depth Anything 3 behavior; do not flag it as a bug or change it to `local_x` unless upstream behavior changes or there is a verified correctness issue.

Applied to files:

  • .coderabbit.yaml
📚 Learning: 2026-05-19T19:28:45.677Z
Learnt from: Talmaj
Repo: Comfy-Org/ComfyUI PR: 13853
File: comfy/ldm/depth_anything_3/camera.py:197-200
Timestamp: 2026-05-19T19:28:45.677Z
Learning: In `comfy/ldm/depth_anything_3/camera.py` (`CameraDec.forward()`), keep the intentional `.float()` casts immediately before the `fc_t`, `fc_qvec`, and `fc_fov` projection layers. This mirrors the upstream ByteDance DA3 implementation and is used to preserve numerical precision for pose-decoding outputs (translation, quaternion, FoV). ComfyUI’s `operations.Linear` wrapper handles dtype mismatches internally, so this cast should not be removed just to “simplify” types; treat it as a deliberate precision safeguard rather than a bug.

Applied to files:

  • .coderabbit.yaml
🔇 Additional comments (1)
.coderabbit.yaml (1)

14-17: LGTM!


📝 Walkthrough

Walkthrough

The review configuration adds fail_commit_status: true. Unsuccessful or throttled reviews now produce a failing commit status instead of a green status.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: enabling a failing CodeRabbit status when a review does not run.
Description check ✅ Passed The description directly explains the configuration change, its purpose, observed failure mode, and scope.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@alexisrolland
alexisrolland merged commit 0dd9b15 into master Aug 7, 2026
17 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 7, 2026
@comfyanonymous
comfyanonymous deleted the chore/coderabbit-fail-commit-status branch September 5, 2026 02:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants