Repository navigation
chore: fail the CodeRabbit status when the review did not run - #15382
Merged
Merged
Conversation
reviews.fail_commit_status defaults to false, so when CodeRabbit is rate limited it posts state=success with description "Review rate limited" and an unreviewed PR is indistinguishable from a cleanly reviewed one.
christian-byrne
requested review from
Kosinkadink,
alexisrolland,
comfyanonymous,
guill,
kijai and
rattus128
as code owners
August 7, 2026 03:39
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (9)
🧰 Additional context used🧠 Learnings (9)📚 Learning: 2026-03-31T08:02:32.334ZApplied to files:
📚 Learning: 2026-04-18T14:11:38.853ZApplied to files:
📚 Learning: 2026-04-22T17:54:32.715ZApplied to files:
📚 Learning: 2026-04-29T23:29:58.457ZApplied to files:
📚 Learning: 2026-05-04T17:10:08.058ZApplied to files:
📚 Learning: 2026-05-07T17:59:24.369ZApplied to files:
📚 Learning: 2026-05-09T02:08:09.260ZApplied to files:
📚 Learning: 2026-05-19T19:15:34.710ZApplied to files:
📚 Learning: 2026-05-19T19:28:45.677ZApplied to files:
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThe review configuration adds 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Comment |
alexisrolland
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.coderabbit.yamlsetscommit_status: truebut leavesfail_commit_statusat its default offalse. Per the CodeRabbit v2 schema,fail_commit_statusis what makes review errors fail the outward status surface; without it, a review that never ran still posts green.Measured, on Comfy-Org/workflow_templates#1092:
state: success. A throttled review is indistinguishable from a clean one at a glance, andgh pr checksprints it aspass.This is not theoretical on this repo. Five PRs in one recent batch ended with no automated review at all while showing green, and one PR needed four
@coderabbitai reviewinvocations before a review actually ran — the one that ran found a Critical.Caveat, stated plainly: the schema documents
fail_commit_statusas applying to "review errors". Whether CodeRabbit classifies a rate limit as an error is not something I can prove from outside — the flag is the only relevant knob in the schema (review_status,commit_status,fail_commit_statusare the complete set), and the failure mode is worth closing if it does apply. If it turns out not to cover rate limits, that is worth raising with CodeRabbit rather than living with a green check that means nothing.Companion change for the frontend: Comfy-Org/ComfyUI_frontend#14880