Repository navigation
New Lora nodes using DynamicGroup widget (CORE-186) #14655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| from __future__ import annotations | ||
|
|
||
| from typing_extensions import override | ||
|
|
||
| import comfy.sd | ||
| import comfy.utils | ||
| import folder_paths | ||
| from comfy_api.latest import ComfyExtension, io | ||
|
|
||
|
|
||
| def _load_lora_file(lora_name: str): | ||
| lora_path = folder_paths.get_full_path_or_raise("loras", lora_name) | ||
| return comfy.utils.load_torch_file(lora_path, safe_load=True, return_metadata=True) | ||
|
|
||
|
|
||
| def _lora_template() -> list[io.Input]: | ||
| return [ | ||
| io.Combo.Input("lora_name", options=folder_paths.get_filename_list("loras"), | ||
| tooltip="The name of the LoRA file to apply."), | ||
| io.Float.Input("strength", default=1.0, min=-100.0, max=100.0, step=0.01, | ||
| tooltip="How strongly to apply this LoRA. 0 = off, negative inverts the effect."), | ||
| ] | ||
|
|
||
|
|
||
| class LoadLoraModel(io.ComfyNode): | ||
| @classmethod | ||
| def define_schema(cls): | ||
| return io.Schema( | ||
| node_id="LoadLoraModel", | ||
| display_name="Load LoRA (Model)", | ||
| search_aliases=["lora", "load lora", "apply lora", "lora model", "lora stack"], | ||
| category="model/loaders", | ||
| description="Apply a stack of LoRAs to a diffusion model. Add one row per LoRA; " | ||
| "each row picks a LoRA file and its strength.", | ||
| inputs=[ | ||
| io.Model.Input("model", tooltip="The diffusion model the LoRAs will be applied to."), | ||
| io.DynamicGroup.Input( | ||
| "loras", | ||
| template=_lora_template(), | ||
| min=1, | ||
| max=50, | ||
| tooltip="Each row applies one LoRA to the model.", | ||
| group_name="LoRA", | ||
| ), | ||
| ], | ||
| outputs=[io.Model.Output(tooltip="The modified diffusion model.")], | ||
| ) | ||
|
|
||
| @classmethod | ||
| def execute(cls, model, loras: list[dict]) -> io.NodeOutput: | ||
| for row in loras: | ||
| lora_name = row.get("lora_name") | ||
| strength = row.get("strength", 1.0) | ||
| if not lora_name or lora_name == "none" or strength == 0: | ||
| continue | ||
| lora, metadata = _load_lora_file(lora_name) | ||
| model, _ = comfy.sd.load_lora_for_models(model, None, lora, strength, 0, lora_metadata=metadata) | ||
| return io.NodeOutput(model) | ||
|
|
||
|
|
||
| class LoadLoraTextEncoder(io.ComfyNode): | ||
| @classmethod | ||
| def define_schema(cls): | ||
| return io.Schema( | ||
| node_id="LoadLoraTextEncoder", | ||
| display_name="Load LoRA (Text Encoder)", | ||
| search_aliases=["lora", "load lora", "apply lora", "clip lora", "lora stack"], | ||
| category="model/loaders", | ||
| description="Apply a stack of LoRAs to a CLIP text encoder. Add one row per LoRA; " | ||
| "each row picks a LoRA file and its strength.", | ||
| inputs=[ | ||
| io.Clip.Input("clip", tooltip="The CLIP text encoder the LoRAs will be applied to."), | ||
| io.DynamicGroup.Input( | ||
| "loras", | ||
| template=_lora_template(), | ||
| min=1, | ||
| max=50, | ||
| tooltip="Each row applies one LoRA to the text encoder.", | ||
| group_name="LoRA", | ||
| ), | ||
| ], | ||
| outputs=[io.Clip.Output(tooltip="The modified CLIP text encoder.")], | ||
| ) | ||
|
|
||
| @classmethod | ||
| def execute(cls, clip, loras: list[dict]) -> io.NodeOutput: | ||
| for row in loras: | ||
| lora_name = row.get("lora_name") | ||
| strength = row.get("strength", 1.0) | ||
| if not lora_name or lora_name == "none" or strength == 0: | ||
| continue | ||
| lora, metadata = _load_lora_file(lora_name) | ||
| _, clip = comfy.sd.load_lora_for_models(None, clip, lora, 0, strength, lora_metadata=metadata) | ||
| return io.NodeOutput(clip) | ||
|
|
||
|
|
||
| class LoraStackExtension(ComfyExtension): | ||
| @override | ||
| async def get_node_list(self) -> list[type[io.ComfyNode]]: | ||
| return [ | ||
| LoadLoraModel, | ||
| LoadLoraTextEncoder, | ||
| ] | ||
|
|
||
|
|
||
| async def comfy_entrypoint() -> LoraStackExtension: | ||
| return LoraStackExtension() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | ⚡ Quick win
Normalize
Nonestrength values before applying LoRAs.DynamicGroup reconstruction can emit a row field with value
None; whenlora_nameis present butstrengthis omitted, this passesNoneintoload_lora_for_models.🐛 Proposed fix
Also applies to: 111-116
🤖 Prompt for AI Agents