Skip to content

[v4] replace PrimeVue styling with Manager-owned theme CSS (#3392) - #3549

Open
perfectmodelslab wants to merge 1 commit into
Comfy-Org:manager-v4from
perfectmodelslab:backport-3392-manager-v4
Open

perfectmodelslab wants to merge 1 commit into
Comfy-Org:manager-v4from
perfectmodelslab:backport-3392-manager-v4

Conversation

@perfectmodelslab

Copy link
Copy Markdown
Contributor

Backport of #3392 (merged on main) to manager-v4, so the legacy UI of the pip package (--enable-manager-legacy-ui) gets the same fix. Fixes #3545.

Why it is still needed

Since ComfyUI_frontend 1.57.1 the frontend no longer injects PrimeVue's dialog styles (Comfy-Org/ComfyUI_frontend#16352 replaced the PrimeVue Dialog), and the legacy Manager menu builds p-dialog markup by hand. On a current frontend the menu has no background at all - transparent dialog, buttons floating over the canvas (exactly the screenshot in #3545). The git-clone install looked fine only because it tracked main's fix; 4.4 shipped to pip on 2026-11-15 without the v4 backport.

What this port contains

Identical in substance to the closed #3457, applied to the current v4 tip (that PR went stale on 2026-11-05):

  • new comfyui_manager/js/comfyui-gui-builder.css with the Manager-owned cm-ui-* classes (overlay, dialog, header, content, muted, button, control, select, checkbox, empty, footer, range);
  • loadCss wiring in comfyui-manager.js / comfyui-gui-builder.js;
  • p-button/p-component/p-dialog/p-select/p-inputwrapper class removal across the eight legacy files, replaced by the semantic cm-ui-* equivalents with theme-variable fallbacks;
  • two hunks that had drifted on v4 (comfyui-manager.js share combo, snapshot.js restart button) applied by hand at their new locations;
  • no remaining PrimeVue class references in the touched files (verified by grep), and MANIFEST.in already ships comfyui_manager/js/*, so the new CSS lands in the wheel.

Verification

Happy to split the two hand-applied hunks into a separate commit if you prefer them isolated.

…3392)

Backport of Comfy-Org#3392 (merged on main) to manager-v4, so the legacy UI of
the pip package (--enable-manager-legacy-ui) stops depending on the
PrimeVue dialog styles the frontend no longer injects since 1.57.1.
Since ComfyUI_frontend#16352 replaced the PrimeVue Dialog, the
hand-built p-dialog markup of the Manager menu renders transparent -
the dialog, its buttons and filters float over the canvas.

Same change as Comfy-Org#3457, applied to the current v4 tip (that PR went
stale): semantic theme variables with legacy-variable fallbacks, the
new comfyui-gui-builder.css with cm-ui-* classes, loadCss wiring in
gui-builder, and the p-* class removal across the eight legacy files.
Two v4-drifted hunks (comfyui-manager.js share combo, snapshot.js
restart button) applied by hand at their new locations.

Fixes Comfy-Org#3545

Signed-off-by: perfectmodelslab <perfect.models.lab@gmail.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 5c87ada8-10af-4049-bf10-4348b29817ed

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant