Repository navigation
[v4] replace PrimeVue styling with Manager-owned theme CSS (#3392) - #3549
Open
perfectmodelslab wants to merge 1 commit into
Open
perfectmodelslab wants to merge 1 commit into
perfectmodelslab wants to merge 1 commit into
Conversation
…3392) Backport of Comfy-Org#3392 (merged on main) to manager-v4, so the legacy UI of the pip package (--enable-manager-legacy-ui) stops depending on the PrimeVue dialog styles the frontend no longer injects since 1.57.1. Since ComfyUI_frontend#16352 replaced the PrimeVue Dialog, the hand-built p-dialog markup of the Manager menu renders transparent - the dialog, its buttons and filters float over the canvas. Same change as Comfy-Org#3457, applied to the current v4 tip (that PR went stale): semantic theme variables with legacy-variable fallbacks, the new comfyui-gui-builder.css with cm-ui-* classes, loadCss wiring in gui-builder, and the p-* class removal across the eight legacy files. Two v4-drifted hunks (comfyui-manager.js share combo, snapshot.js restart button) applied by hand at their new locations. Fixes Comfy-Org#3545 Signed-off-by: perfectmodelslab <perfect.models.lab@gmail.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #3392 (merged on
main) tomanager-v4, so the legacy UI of the pip package (--enable-manager-legacy-ui) gets the same fix. Fixes #3545.Why it is still needed
Since ComfyUI_frontend 1.57.1 the frontend no longer injects PrimeVue's dialog styles (Comfy-Org/ComfyUI_frontend#16352 replaced the PrimeVue Dialog), and the legacy Manager menu builds
p-dialogmarkup by hand. On a current frontend the menu has no background at all - transparent dialog, buttons floating over the canvas (exactly the screenshot in #3545). The git-clone install looked fine only because it trackedmain's fix; 4.4 shipped to pip on 2026-11-15 without the v4 backport.What this port contains
Identical in substance to the closed #3457, applied to the current v4 tip (that PR went stale on 2026-11-05):
comfyui_manager/js/comfyui-gui-builder.csswith the Manager-ownedcm-ui-*classes (overlay, dialog, header, content, muted, button, control, select, checkbox, empty, footer, range);loadCsswiring incomfyui-manager.js/comfyui-gui-builder.js;p-button/p-component/p-dialog/p-select/p-inputwrapperclass removal across the eight legacy files, replaced by the semanticcm-ui-*equivalents with theme-variable fallbacks;comfyui-manager.jsshare combo,snapshot.jsrestart button) applied by hand at their new locations;MANIFEST.inalready shipscomfyui_manager/js/*, so the new CSS lands in the wheel.Verification
node --checkpasses on every modified JS file.#cmm-manager-dialogIDs, not the PrimeVue classes, so the legacy e2e specs need no locator migration (this is what the old P2 review note on [v4] fix: replace PrimeVue styling with Manager-owned theme CSS (#3392) #3457 was about).p-button p-component(grepped).Happy to split the two hand-applied hunks into a separate commit if you prefer them isolated.