Repository navigation
feat(titlebar): Home button in build windows, and the ☰ menu on the right (DESK-293) - #2146
Merged
Merged
Conversation
…ight (DESK-293) A build window's title bar now starts with a Home button. It brings the Desktop window to the front, or opens one when none is open. The Desktop window itself has no Home button. The ☰ menu moves to the right end of the title bar in every window, after Downloads, and refresh moves to the right with the other build controls. Why: once a build opened in the Desktop window there was no way back to Desktop (Alexis, 1.1.11 QA, Nov 12). Pablo and Alexis settled on Home in build windows only and the ☰ on the right. The layout follows Mar's title bar in the New-Home Figma (Components > Organisms/Title bar, and the M2 Apps title bars): house icon and "Home" at 13px, no fill at rest, a grey pill on hover, ☰ last on the right. Home skips a Desktop window that is turning into a build window (it has claimed a launch or is previewing one), so it never brings forward a window that is about to show ComfyUI. This redoes the title bar part of #2027 on main. That PR also opens every build in its own window; that is left for a separate change.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
benceruleanlu
added a commit
that referenced
this pull request
Nov 16, 2026
…idge-types One conflict, in src/renderer/src/comfyTitleBar/TitleBarApp.vue. Main (#2146) added clickHome to the screen's hand-written copy of the title bar bridge. This branch had deleted that copy: the screen reads the typed window.__comfyTitleBar. The typed global is kept, and clickHome reaches the screen through ComfyTitleBarBridge, which main extended in the preload in the same commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
DESK-293, from the M1+ test feedback (P1, not blocking 1.1.11).
The problem behind it: once ComfyUI opened in the Desktop window, there was no way back to Desktop (Alexis, 1.1.11 QA thread, Nov 12). Pablo and Alexis agreed on Home in build windows only, with the ☰ on the right "until we remove it completely".
Design
This follows Mar's title bar in the New-Home Figma: Components ›
Organisms/Title barand itsTitle bar · States(node 9:8101), and the M2 · Apps title bars, which put Home on the left and ☰ last on the right.How
TitleBarApp.vuerenders Home when the window is bound to a build and first-use lockdown is off. Clicking it calls the new bridge methodclickHome.comfyTitleBarPreload.tssendscomfy-window:show-home.index.tsaccepts that message only from a build window's title bar, and then callsopenOrFocusHomeHostWindow().registry.tsaddsopenOrFocusHomeHostWindow(). It focuses or restores a Desktop window that is not handing off to a build, or else opens a new Desktop window. A Desktop window that has claimed a launch, or is previewing one, is about to become a build window, so Home skips it.Relation to #2027
Pablo's #2027 shows the intent. It sits on nine unmerged PRs and is 171 commits ahead of
main. This redoes only the title bar part onmain. #2027 also makes every build open in its own window, which is a wider navigation change. That is not part of this PR.Tests
TitleBarApp.test.ts, a new suite "Home button and the ☰ on the right":registry.test.ts, a new suite "openOrFocusHomeHostWindow":aria-haspopup="menu", which does not depend on where the button sits.Screenshots
These come from the real
TitleBarAppin headless Chromium, with a stub bridge, at 2×. The macOS traffic lights and the Windows controls are drawn stand-ins for the native ones. "Before" ismainat c994b9c.Not tested
titlebar-area. The ☰ moves into the same right-side cluster that already handles them.