Repository navigation
refactor(install): remove the starter-template install pipeline - #2136
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
Base automatically changed from
bl/inconsistent-onboarding-starter-workflow-bd4021
to
main
November 16, 2026 06:13
No install path selects a starter workflow any more: first-run onboarding dropped the step, Install on Set up skipped it since #2072, and the New Build modal never asked. The main process still carried the whole per-install pipeline behind the standalone `bundledTemplate` field, so this removes it end to end: - standalone source: no `bundledTemplate` field, options or record fields - installation records: drop `bundledTemplateId`, `bundledTemplateSizeBytes`, `pendingTemplateOpen`, `downloadTemplateModels` and `clearPendingTemplateOpen`; attach no longer deep-links a template - install handler no longer starts or aborts a starter-model download; first open no longer auto-opens the Downloads tray for it - templateDownloadTask keeps only the task the performance test page runs, and now requires the workflow JSON it is given - drop the remote starter-templates reader, the built-in curated list, the starter catalog loader with its live-index substitution, and the install-based model and input-asset resolvers - retire the `skipTemplatePickerStep` setting through the removed-keys list - renderer setup plan and install wizard stop special-casing the field The performance test page keeps TemplatePickerStep, useTemplateTabs, hydrateTemplates and its example downloads. installations.json records that still carry the old template fields load, list and update as before.
benceruleanlu
force-pushed
the
bl/remove-starter-template-pipeline
branch
from
November 16, 2026 06:13
a653223 to
dd3c618
Compare
benceruleanlu
added a commit
that referenced
this pull request
Nov 16, 2026
…idge-types One conflict, in the popup import list of src/main/index.ts. Main (#2136) dropped openDownloadsTrayForInstall along with the starter-template tray auto-open. This branch dropped the InstancePickerInstall type import, because the type now comes from src/types/titlePopup. Both removals are kept, so the list is registerTitlePopupIpc and triggerPickerSnapshotBroadcast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2133. Once #2133 merges, GitHub retargets this to
main, and I'll mergemainin.Why
No install path picks a starter workflow any more. #2133 removed the first-run step, Install on Set up has skipped it since #2072, and the New Build modal never asked. But the main process still had the whole per-install pipeline: a standalone
bundledTemplatefield, four template fields on installation records, a model download started during install, a deep link on first open, and a Downloads tray that opened by itself. This PR removes all of it.What goes
bundledTemplatefield, no options for it, andbuildInstallationwrites no template fields, even when a selection still names a template.bundledTemplateId,bundledTemplateSizeBytes,pendingTemplateOpen,downloadTemplateModelsandclearPendingTemplateOpenare gone.attachloads the plain ComfyUI URL.openDownloadsTrayForInstallhad no other caller).templateDownloadTask: only the task the performance test page runs is left (startTemplateDownloadTask,subscribeTemplateDownload,forgetTemplateDownload,hasActiveTemplateDownloads). It now requires the workflow JSON, so the per-install lookup (resolveTemplateModels,resolveTemplateInputAssets) is gone.starter-templates.jsonreader,CURATED_TEMPLATES,loadTemplateCatalogwith its cache and live-index substitution, andbuildTemplateDeeplinkare gone.hydrateTemplatesstays.skipTemplatePickerStepis retired through the existing removed-keys list, so it gets cleaned out of existingsettings.jsonfiles.setupPlanandInstallWizardModalno longer special-case the field. The threestandalone.starterTemplate*strings are gone.launchStarterModels.integration.test.tsis deleted.What stays
TemplatePickerStep,useTemplateTabs,hydrateTemplates,toTemplateFieldOption, the example-workflow downloads, and the quit warning while they run.starter-templates.jsonpublish workflow (.github/workflows/starter-templates.yml,scripts/starter-templates.mjs,assets/starter-templates.json). This build no longer reads the file, but released builds that still show the step fetch it from R2. Removing the workflow would freeze that list for them, so it's a separate call.template_selected: falseprop oncomfy.desktop.install.dispatched. It's always false now; dropping it would change the event schema dashboards read.Existing data
installations.jsonrecords that still carry the old template fields load, list and update as before. Nothing reads those fields now. New test:installations.load (a build made when first run offered a starter workflow).Tests
startTemplateDownloadTaskwith a workflow JSON. They check that model jobs belong to the installation while the task is keyed separately, and that a task settles through a completed job.hydrateTemplates, and the model URL guards toresolveTemplateModelsFromJson. The input-asset parsing tests now go throughresolveTemplateInputAssetSnapshot.