Repository navigation
test(e2e): run the fake-ComfyUI e2e specs on macOS too - #2134
Conversation
The fake install refused every platform but Linux. Its python3 stub is a shell script, which macOS runs as well, so only Windows is refused now. Twelve spec files that use it are tagged @MacOS. process-ownership stays Linux-only. The apps-local Open step waits for the ComfyUI window to show the stub page, and the stub page has readable text, so its video shows the window.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 96 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit 4936f67 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
No activity TTL, 8 hours, merging on greenlight approval. |
The second test found the first test's error badge still on the tile, and the launch check passed before Desktop had registered the new launch. The click then landed while the new launch had swapped the badge for the progress spinner, and found no badge. The old badge is marked before each launch, and the test waits for a new one.
e4ce125 to
e043363
Compare
comfy-greenlight-bot
left a comment
There was a problem hiding this comment.
This pull request at head commit fa02b95 has been reviewed and approved by Swarmhost's agentic review process.
The detailed evaluation is available to employees in the internal Slack review thread.
|
No activity TTL, 8 hours, merging on greenlight approval. |
TL;DR: the end-to-end tests that start a fake ComfyUI now run on macOS as well as Linux.
Why These tests refused to run anywhere but Linux, so the Mac CI job skipped them and nobody could run them on a Mac. The fake ComfyUI is a shell script that stands in for
venv/bin/python3. macOS runs a shell script there the same way Linux does. Only Windows needspython.exe, so only Windows is refused now.Before / After
Before:
writeFakeComfyInstallthrew on macOS, and 12 spec files were tagged@linuxonly. After: those 12 files are tagged@linux @macos, and the Mac CI job runs them.Before: the apps-local "Open" step passed once the ComfyUI window existed, and ended before the window drew anything. After: it waits until the window shows the ComfyUI page, and holds it for a second when
E2E_VIDEO=1. The fake page's text is readable, so the video shows the window.Before:
assets-startup-failurefailed once in the macOS merge-queue run. Its second test clicked the first test's leftover error badge while the new launch had swapped it for the progress spinner. After: the test marks the old badge before each launch and waits for a new one.e2e/process-ownership.test.tsstays Linux-only. On a Mac it fails atlaunchInstallwith "the install never booted a new ComfyUI stub". The cause is not found yet.Seen in production by: not a product change.
Run:
E2E_VIDEO=1 pnpm exec playwright test e2e/apps-local.test.ts --project=macoson an Apple silicon Mac, 5 of 5 passed. The other 11 newly tagged files were run on the same Mac before the apps-local change and passed.e2e/assets-startup-failure.test.ts --project=macos --repeat-each=8 --retries=0: 16 of 16 passed after the fix. Not run: Windows, unchanged.Rule bent: none.
Ref DESK-305