Repository navigation
test(e2e): open Builds after Return to dashboard in the nightly lifecycle suite - #2092
Merged
Merged
Conversation
Return to dashboard closes the window's panel webContents and loads a fresh one. Until the new page commits its URL, no webContents matches panel.html, so WebContentsPage.evaluate throws "webContents not found". expect.poll rethrows a thrown predicate at once, so any waitFor that straddles the swap failed in about a second instead of waiting. stopAndReturnToDashboardViaUI used to hide this with its own .catch(() => false) poll. Once it waits through expectChooserVisible, the swap surfaced as a failure in the Manager test and in the retry of the stop test. waitFor now reads a missing or destroyed page as "not yet" and keeps polling until the timeout, so every waitForVisible and waitForSelector survives a panel swap. Any other error still fails at once.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
This was referenced Nov 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly Lifecycle Tests workflow has been red on
mainsince 10 Nov. On 14 Nov (run 43579192917,3c1bcbfd) it fails ine2e/lifecycle.test.ts:716, "update-comfyui drives the real updater and moves HEAD forward", on both attempts:selector [data-testid="dashboard-tile-inst-<id>"] did not become visible.This PR fixes that failure. It does not make the whole nightly green: the chain now runs 17 tests further and stops at a different failure, described under "What is still red".
Root cause
The product is right and the test is wrong.
PanelApp.vuestartsdashboardHomePageat'home'._detachInstallImplinsrc/main/host/detach.ts) destroys the window's panel webContents and creates a fresh one, so the dashboard opens on Home every time.ChooserViewstays mounted underv-showwhile Home is showing.stopAndReturnToDashboardViaUIonly checked that.chooser-viewexists in the DOM, so it passed on Home.openManageViaDashboardthen waited for a build tile to be visible. Tiles are only visible on the Builds page, so the wait timed out. The failure screenshot shows Home ("Welcome. Let's create!").The test last ran green on 9 Nov (
c8890334). From 10 Nov to 13 Nov the serial chain stopped earlier, in the setup tests, so this test did not run at all. #2072 and #2074 repaired the setup tests on 13 Nov, which exposed it. #2082, #2083, #2051, #2077 and #1993 are not involved.Fix
Two commits, test code only.
test(e2e): open Builds before managing installationsis cherry-picked unchanged from test(e2e): cover first-use Install with recommended settings #2078 (05091f73).openManageViaDashboardandstopAndReturnToDashboardViaUInow go throughexpectChooserVisible, which picks Builds in the sidebar when Home is showing. It also adds anav-matrix-dashboardtest for Home → Builds → Update settings.test(e2e): keep waiting while a window swaps its panel page. On test(e2e): cover first-use Install with recommended settings #2078 the first commit alone got past:716and then failed in the Manager test and in the retry of the stop test withwebContents not found (marker=panel.html)(run 43515629053). While the panel is being swapped no webContents matchespanel.html,WebContentsPage.evaluatethrows, andexpect.pollrethrows a thrown predicate at once. The old helper hid this with its own.catch(() => false).WebContentsPage.waitFornow reads a missing or destroyed page as "not yet" and keeps polling until its timeout. Every other error still fails at once.Validation
pnpm run typecheck,pnpm run lint,pnpm run format:checkpass.nav-matrix-dashboardtest passes.What is still red
Not caused by this PR and not fixed here. Both are in the
@sec-bootwindowtests and come from launch-on-card (#2074).lifecycle.test.ts:2011, "restart clicked during a FRESH chooser boot (unattached window) cancels it and applies the edited --port" fails withExpected substring: "Restart",Received string: "Switch". Since feat(launch): start a build on its card, then open ComfyUI in its own window #2074 a launch started from the dashboard runs on the build's card and the dashboard window no longer hosts it. The picker opened from the dashboard therefore sees the build as running elsewhere anddecideNavigationgivesdashboard | instance | running-elsewhere→ "Switch". The screenshot shows the "Restart to apply" badge next to Startup Arguments with a Switch button under it, so there is no way to restart a starting build from the dashboard picker. feat(launch): start a build on its card, then open ComfyUI in its own window #2074 moved this test from the title-bar pill to the dashboard picker and kept the "Restart" expectation, but the nightly never reached it. Whether the dashboard picker should offer Restart for a build that is starting is a product decision.lifecycle.test.ts:1933, "restart clicked during boot cancels the in-flight boot…" passed on the first pass and failed on the retry pass with "boot finished before the restart click". It races a real boot instead of holding the spawn witharmLaunchSpawnHold, as the test after it does.The 10 tests after
:2011(copy, untrack, remote connection, delete) have not run onmainsince 9 Nov.Overlap with open PRs
e2e/support/cdpPages.tsore2e/support/chooserHelpers.ts. test(e2e): rename the lifecycle suite to real-comfy #2011 renamese2e/lifecycle.test.ts; the only edit there is the one test(e2e): cover first-use Install with recommended settings #2078 already makes.