Repository navigation
fix(apps): show an app page as not loaded, never as loading forever, when it is sent off the site or retried with nothing to reload - #2085
Merged
Conversation
…when it is sent off the site or retried with nothing to reload Two ways an opened app could leave the person looking at the loading placeholder with no way out but All apps: - The site redirects the app's page to another site while it loads, as a www or locale redirect on comfy.org would. Desktop stopped the redirect, opened the other address in the browser unasked, and kept the status at loading, because the stopped load ends as an aborted navigation, which is ignored. Now a redirect off the apps site while the page loads stops it and reports the page as not loaded (telemetry reason "redirected"), so the panel offers Try again. A redirect after the page is up still opens in the browser, as before. - Try again on an app the window never loaded, because opening it was refused (Apps switched off, or the app gone from the list). Desktop had no page to reload and answered nothing. If the window still held another app, it reloaded that one out of sight and the panel showed a blank page. Try again now names the app it is for. Desktop reloads only that app's page, and otherwise tells the panel the app still did not load. Found in a read-through of the Apps hosting code before the release that turns Apps on (desktop_apps_enabled is at 100%). Neither happens with comfy.org as it answers today.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
…n every page status Review fixes on top of the redirect and retry change: - Try again now asks to show the app again, with a retry flag, instead of a separate reload channel. Opening the app already checks that Apps is on and the app is still listed, and it already reloads a failed page. So Try again no longer loads a page after Apps is switched off. An app refused for a reason that has since cleared now loads on Try again, instead of saying it failed every time. The retry is not counted as an app_opened event. The reload-page channel is gone. - Each page status sent to the panel names its app, and the panel uses only the status of the app it shows. Before this, if you left an app while it was still loading and then opened one that was refused, the first app finishing set the second app's panel to ready. The panel went blank with no Try again. - Adds a test that a redirect within the apps site while the page loads is still followed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two ways an opened app could leave someone on the loading placeholder forever. Neither happens with comfy.org as it answers today, but
desktop_apps_enabledis at 100%, so the next release turns Apps on for everyone.ELI5
When an app page can't load, Desktop is supposed to say "Remove Background didn't load" and offer Try again. In two cases it showed the grey loading boxes forever instead:
www.or language redirect on comfy.org would do this. Desktop stopped the redirect and opened the new address in the browser without being asked. Then it waited forever for a page that was never coming.What changed
redirected, so the team can see it. The panel shows Try again and All apps. Nothing opens in the browser. A redirect after the page is up still opens in the browser, as before.showAppPagewithretry: true, not through a separate reload channel. That path already checks that Apps is on and that the app is still listed, and it already reloads a failed page. So Try again loads nothing once Apps is switched off. An app refused earlier loads if the reason has cleared, and otherwise says again that it did not load. A retry is not counted asapp_opened. Theapps:reload-pagechannel is removed.Tests
appPageView.test.ts: two new journeys:https://www.comfy.org/apps/ends as failed with reasonredirected, the view stays hidden, and the browser is not opened.AppPageHost.test.ts: Try again asks to show the app withretry: true, only once. The panel keeps saying failed when another app's page reports ready.src/main/apps+src/main/lib/ipc(627) and the panel's Apps suites (127) pass. Typecheck, lint and prettier pass.Found while checking Apps for the release
I ran the website's app pages in headless Chromium against Desktop's real
localComfy.tsand a real ComfyUI 0.45:Three bugs on the website side of the same journey are fixed on Comfy-Org/comfy-website#457: