You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test(e2e): stabilize native clicks during title-bar layout changes - #2081
The desktop-update restart-prompt test intermittently times out in Windows CI after the click helper reports success (failure example). The helper can measure a button, let its layout change, and then send native input to the old coordinates.
Wait for the target element and its bounds to remain stable across two animation frames before dispatching native clicks. Preserve the existing hit test and timeout. Add a regression that moves the update pill after its first bounds measurement and verifies that the restart modal opens; it reproduces the timeout with the previous helper.
Validation:
Regression fails before the fix and passes afterward.
Update-pills suite repeated 20 times on macOS with retries disabled: 140 passed.
Related native-input, dropdown, and title-bar hover tests: 9 passed.
Full pnpm run typecheck, pnpm run lint, and pnpm run format:check passed.
No actionable comments were generated in the recent review.
Walkthrough
sendClick now requires a visible, unobstructed target to remain unchanged across two animation-frame checks. The update-pill end-to-end test simulates movement after reading the pill’s bounds and checks that the restart prompt appears.
sendClick waits for two consecutive checks with the same target and rectangle, using animation frames within the existing five-second deadline. The blocked-click error mentions a potentially moving element. An end-to-end test simulates pill movement and checks for the system-modal restart prompt.
Suggested reviewers:deepme987
Merge Risk: Minimal · up to b85f9
This change only makes a test-helper click wait for a stable target before sending native input. It has no production impact, and nothing blocks merging.
Pre-merge checks: 2
Check name
Status
Explanation
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Finishing Touches
Generate unit tests (beta)
Commit to this branch
Create a new PR
Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info
Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: c4b2a79b-c275-43d8-a939-d51253ba8912
Commits
Reviewing files that changed from the base of the PR and between b425688 and b85f999.
Files selected for processing: 2
e2e/support/cdpPages.ts
e2e/update-pills.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 1 remain after this review.
Closing as superseded by #2093, which checks the actual press target and suppresses missed gestures before re-aiming. The moving-pill regression will be carried forward there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop-update restart-prompt test intermittently times out in Windows CI after the click helper reports success (failure example). The helper can measure a button, let its layout change, and then send native input to the old coordinates.
Wait for the target element and its bounds to remain stable across two animation frames before dispatching native clicks. Preserve the existing hit test and timeout. Add a regression that moves the update pill after its first bounds measurement and verifies that the restart modal opens; it reproduces the timeout with the previous helper.
Validation:
pnpm run typecheck,pnpm run lint, andpnpm run format:checkpassed.Windows confirmation remains for CI.