Repository navigation
Conversation
…n to Production Cloud opens https://comfy.org/apps/ and staging Cloud opens the staging-built website preview. A development build still takes COMFY_APPS_URL or a .apps-url file over either.
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The Apps page now lives under /apps/ on the shared comfy.org site, so an origin-only check let any comfy.org page (for example /hub/) stay in the Apps view and call the Desktop bridge. isAppsFrameUrl now takes the Apps URL and requires the same origin and a path at or under its base path; navigation, bridge authorization and local event delivery all use it. A development override at a site root still allows its whole origin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: A released Desktop opens the app pages at
https://comfy.org/apps/, and a Desktop signed in to staging Cloud opens the staging site's pages.Why Released builds open
https://apps.comfy.org/, which does not resolve (measured 2026-11-12), and they ignoreCOMFY_APPS_URL, so no released Desktop can be pointed at staging's pages.Before / After
apps.comfy.organd shows nothing; a staging-signed Desktop still opens the production address.https://comfy.org/apps/, staging Cloud opens the staging site. Dev builds keepCOMFY_APPS_URL.Seen in production by:
curl https://apps.comfy.org/fails to resolve.Not run: Unit tests were written, not run locally (CI runs them).
comfy.org/apps/does not serve the pages yet; released builds keep the Apps tab off until the switch in the next PR goes on. Smoke-tested 2026-11-12 in a dev build of this chain merged into the Apps stack up to #2045: the Apps tab opened, Remove Background ran on This computer (on an existing ComfyUI 0.42.4) and on Comfy Cloud.Rule bent: none.
Ref BE-26260