Skip to content

feat(assets): see all assets from a Comfy Cloud app result - #2049

Closed
PabloWiedemann wants to merge 6 commits into
claude/assets-folder-cards-92eb1afrom
claude/app-see-all-assets-50cd41
Closed

PabloWiedemann wants to merge 6 commits into
claude/assets-folder-cards-92eb1afrom
claude/app-see-all-assets-50cd41

Conversation

@PabloWiedemann

Copy link
Copy Markdown
Contributor

What

For app results made on Comfy Cloud, the output preview button now says See all assets. Clicking it opens the Assets panel on the Comfy Cloud tab.

Stacked on #2045.

Changes

  • Label: assets.viewInAssets becomes assets.seeAllAssets ("See all assets") in en.json and zh.json.
  • The click no longer sends a file name. The old button also opened one file, which does not fit the new label.
  • AssetsView takes startOnCloud in place of focusName. The code that searched for one file by name is removed.
  • Tests updated to match.

Tested

  • Typecheck, lint, format and the src/renderer/src/panel tests pass.
  • Dev app on port 9342: a cloud result shown through the real showOutput bridge shows the button. The click opens Assets on Comfy Cloud and closes the preview.

Not tested

  • A real run on Comfy Cloud. The run did not start in my dev app. The apps storage was locked, most likely because another dev app shares the same userData.
  • The Chinese label in the app.

For app runs made on Comfy Cloud, the output preview button now says
"See all assets" and opens the Assets panel on the Comfy Cloud tab.

The old button was "View in Assets" and also opened one file by name.
That does not fit the new label, so the click no longer carries a name.
AssetsView takes a startOnCloud prop in place of focusName, and the
code that looked for one file by name is removed.
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@PabloWiedemann

Copy link
Copy Markdown
Contributor Author

Review comments checked.

Fixed

  • Nothing to fix. The only comment is the CodeRabbit notice that draft PRs are not reviewed. It has no findings.

Already fixed

  • Nothing.

Not changed

  • No code change. There are no unresolved review threads and no findings to act on.
  • A manual CodeRabbit review was not triggered. The PR stays a draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants