Repository navigation
feat(assets): see all assets from a Comfy Cloud app result - #2049
Closed
PabloWiedemann wants to merge 6 commits into
Closed
PabloWiedemann wants to merge 6 commits into
PabloWiedemann wants to merge 6 commits into
Conversation
For app runs made on Comfy Cloud, the output preview button now says "See all assets" and opens the Assets panel on the Comfy Cloud tab. The old button was "View in Assets" and also opened one file by name. That does not fit the new label, so the click no longer carries a name. AssetsView takes a startOnCloud prop in place of focusName, and the code that looked for one file by name is removed.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
|
Contributor
Author
|
Review comments checked. Fixed
Already fixed
Not changed
|
…all-assets-50cd41
…all-assets-50cd41
…all-assets-50cd41
…all-assets-50cd41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
For app results made on Comfy Cloud, the output preview button now says See all assets. Clicking it opens the Assets panel on the Comfy Cloud tab.
Stacked on #2045.
Changes
assets.viewInAssetsbecomesassets.seeAllAssets("See all assets") inen.jsonandzh.json.AssetsViewtakesstartOnCloudin place offocusName. The code that searched for one file by name is removed.Tested
src/renderer/src/paneltests pass.showOutputbridge shows the button. The click opens Assets on Comfy Cloud and closes the preview.Not tested