Skip to content

feat(ui): show the Home tab in the title bar when no build is running - #2048

Closed
PabloWiedemann wants to merge 5 commits into
claude/assets-folder-cards-92eb1afrom
claude/titlebar-tabs-no-build-d95cf9
Closed

PabloWiedemann wants to merge 5 commits into
claude/assets-folder-cards-92eb1afrom
claude/titlebar-tabs-no-build-d95cf9

Conversation

@PabloWiedemann

@PabloWiedemann PabloWiedemann commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: With no build running, the title bar shows the Home tab, selected, in the same tab style as a build window. It no longer shows the "Comfy Desktop" pill.
Why: The two window states showed two different components in the same place. The title bar should look the same with or without a build.
Can affect: only the left side of the title bar (tabs and the collapse measurement) in TitleBarApp.vue. It does not touch the main process, the picker popup, locales or the right-side buttons.
Part of the title bar build tabs work in #2027. Stacked on #2045.

Changes

  • Home tab with no build: the tab strip from feat(ui): open every build in its own window, with a Home button in the title bar #2027 now also shows in a window with no build. Home is the only tab and is selected.
  • Pill removed: the "Comfy Desktop" pill and its interactive styles are gone. The dashboard still opens the build picker from its Builds page, deep links and window.api.openInstancePicker.
  • Home click with no build: it does nothing on the dashboard. From a Home tool (benchmarks, performance test), it goes back to the dashboard.
  • Collapse measurement: measureFit now measures the left cluster, because the build tab may not exist.
  • Edge cases: first-use lockdown keeps its pill and label (covered by a unit test). When a build attaches, the build tab appears next to Home.
  • Noticed and left:
    • With no build, Home stays selected while an overlay such as feedback or new install is in front.
    • The e2e helper openPickerViaTitlePill has 23 callers, and its name no longer fits.
    • In titlePopup.ts, the 'full' layout branch for click-install-pill can no longer be reached from the title bar.

Screens

No-build state: before, a "Comfy Desktop" pill with a logo and a chevron. After, only the Home tab, selected. The build state is unchanged. Screenshots were taken in a dev app and shared with Pablo.

Testing

  • pnpm test: 345 files, 7,955 passed, 12 skipped.
  • pnpm run typecheck, pnpm run lint and pnpm run format:check pass.
  • New unit tests: Home alone with no build, the Home click with no build, the build tab appearing when a build attaches, and the lockdown pill label.
  • Dev app on macOS (dark theme): the no-build title bar, launching Comfy Cloud, and closing the build tab back to Home.
  • Not tested: E2E (it is not run locally in this repo). The specs in e2e/chooser.test.ts, lifecycle-cloud.test.ts and beta-activation-notice-lockdown.test.ts, and support/chooserHelpers.ts, were updated but not run. Also not tested: the light theme, and Windows or Linux.

The dashboard window used a different component in the title bar: a
"Comfy Desktop" pill. It now uses the same tabs as a build window. Home
is selected, and a "Choose a build" tab opens the same full picker that
the pill opened. First-use lockdown keeps its pill.

Follows #2027.
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The title bar updates navigation and install-pill behavior for windows without an installation. Home selects the comfy panel in install-less mode. The Build tab appears when first-use lockdown is inactive. End-to-end picker tests now use the Home tab and picker API.

Changes: Title bar navigation

Layer / File(s) Summary
Navigation, panel selection, and rendering
src/renderer/src/comfyTitleBar/TitleBarApp.vue, src/renderer/src/comfyTitleBar/TitleBarApp.test.ts
The title cluster now provides the fit-measurement reference. Home-tab activation selects comfy in install-less mode and home otherwise. The tab navigation renders outside first-use lockdown, while the install pill is omitted in install-less mode. Tests cover Home selection, panel changes, installation-ID updates, and lockdown display.
Picker helper and end-to-end checks
e2e/support/chooserHelpers.ts, e2e/chooser.test.ts, e2e/lifecycle-cloud.test.ts, e2e/beta-activation-notice-lockdown.test.ts
The picker helper waits for the Home tab and opens the picker through window.api.openInstancePicker(). End-to-end checks assert Home and Build tab state, wait for the Build tab, and detect lockdown by the absence of the Home tab.

Suggested reviewers: maanilverma, benceruleanlu, kosinkadink

Merge Risk: Minimal · up to 767ef

The title bar shows a selected Home tab when no build is running instead of the "Comfy Desktop" pill. No merge-blocking risk was identified; the light theme, Windows and Linux were not tested by the author.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0f96f17e-7310-446e-832e-b4792930d6a6
Commits

Reviewing files that changed from the base of the PR and between ce2391a and 767ef9d.

Files selected for processing: 6

  • e2e/beta-activation-notice-lockdown.test.ts
  • e2e/chooser.test.ts
  • e2e/lifecycle-cloud.test.ts
  • e2e/support/chooserHelpers.ts
  • src/renderer/src/comfyTitleBar/TitleBarApp.test.ts
  • src/renderer/src/comfyTitleBar/TitleBarApp.vue

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

With no build, the title bar no longer shows a "Choose a build" tab.
The dashboard window keeps the Home tab alone. The dashboard still opens
the picker on its own.

The title bar now measures its left cluster to decide when to collapse
buttons, so it no longer needs the build tab to be there.
@PabloWiedemann PabloWiedemann added the cursor-review Trigger multi-model Cursor code review label Nov 12, 2026
@PabloWiedemann PabloWiedemann changed the title feat(ui): Home tab in the title bar when no build is running feat(ui): show the Home tab in the title bar when no build is running Nov 12, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @PabloWiedemann.

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 5
🟢 Low 4

Panel: 8/8 reviewers contributed findings.


src/renderer/src/comfyTitleBar/TitleBarApp.vue:412 — 🟠 High — On an install-less host every dashboard sub-page (Builds, Apps, Assets, Home) maps to the same host panel comfy, so activePanel.value !== 'comfy' is false whenever the dashboard is on a non-Home sub-page and clicking the Home tab does nothing despite the tab rendering as an enabled button. Returning home needs something that resets the dashboard sub-page (e.g. navigatePanel('home')), since setPanel('comfy') cannot and main early-returns on an unchanged panel. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.test.ts:409 — 🟡 Medium — This assertion pins the Home-tab no-op as expected behavior while only covering activePanel === 'comfy', which is exactly the state the dashboard sits in for its Builds/Apps/Assets sub-pages, so it masks the dead-button case instead of catching it. Add a case where the dashboard is on a non-Home sub-page while the host panel is still comfy. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:603 — 🟡 Medium — isInstallLess now inserts/removes the build tab inside the measured .title-cluster, but fit recalculation only observes the fixed-size header and the title label, never isInstallLess or the cluster itself. If the label doesn't change across the transition (e.g. a build literally named Comfy Desktop), collapseMode stays stale and trailing controls can overlap or stay collapsed until the window is resized; add a ResizeObserver on the cluster or a watcher on isInstallLess that triggers the fit pass. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:623 — 🟡 Medium — Detaching an installation while the pill coachmark is up removes the installPill element but nothing tears down the popup: the [isInstallLess, isFirstUseLockdown, isLoadingLockdown] watcher calls bridge?.hideCoachmark() only when betaNotice.isShowing is true. The coachmark stays anchored to a removed element and coachmark.isShowing remains true, which keeps suppressing the beta-activation notice via isSuppressed. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max edge-case).

e2e/support/chooserHelpers.ts:115 — 🟡 Medium — The readiness gate weakened: title-home-tab renders as soon as the title bar mounts with isFirstUseLockdown false, independent of whether main has pushed the installation id, whereas the old BUILD_TAB || INSTALL_PILL poll implied installation state had arrived — so window.api.openInstancePicker() can now fire before the host window settles. The helper also no longer clicks any title-bar element, so despite its name it gives zero coverage of the user-reachable picker entry point. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:419 — 🟡 Medium — The build-tab click path keys off homeTabActive, which is now false for every non-home panel (new-install, track, load-snapshot, quick-install), not just when the build panel is already showing — so clicking the build tab from those takeover panels opens the instance picker instead of returning to comfy. Guard on activePanel.value !== 'comfy' instead. Raised by 1 of 8 reviewers (kimi-k2.7-code edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:262 — 🟢 Low — Math.max(...Array.from(cluster.children).map(...)) returns -Infinity for an empty child list, making gap Infinity, which evaluateFit discards and silently freezes collapseMode. The old code seeded Math.max with pill.getBoundingClientRect().right so it could never degenerate; add an explicit length guard that returns the { gap: Infinity, trailingWidth: NaN } bail-out. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:388 — 🟢 Low — isInstallLess.value || short-circuits the panel check, so on an install-less host the Home tab always renders aria-current="page" and the selected bg-accent style even while a takeover panel outside HOME_PANELS is displayed (new-install, track, load-snapshot, quick-install, announcement, feedback). The tab claims to be the current page in states where clicking it navigates elsewhere. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

e2e/beta-activation-notice-lockdown.test.ts:59 — 🟢 Low — lockdownEngaged now probes two elements gated by the identical !isFirstUseLockdown condition (the bell and the Home tab), so the second check is redundant and the helper effectively only asserts "the bell is hidden". The previous build-tab/interactive-pill selector was an independent signal that the build and picker affordances were suppressed during lockdown. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/renderer/src/comfyTitleBar/TitleBarApp.vue:608 — 🟢 Low — The tab nav is now gated only on !isFirstUseLockdown, which excludes loading-lockdown, so first-run install-less windows render a clickable Home tab during loading lockdown where no panel-switching control existed before. Main's comfy-window:set-panel handler only validates the key against VALID_PANELS and performs no lockdown check, so the renderer is the sole gate. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

(Inline comments could not be anchored to the diff; listed above instead.)

@PabloWiedemann
PabloWiedemann marked this pull request as ready for review November 12, 2026 21:07
@PabloWiedemann
PabloWiedemann requested review from a team as code owners November 12, 2026 21:07
@PabloWiedemann

Copy link
Copy Markdown
Contributor Author

Closing this. The title bar design changed: the home window shows nothing at the top left, a build window shows only a Home button, and every build opens in its own window. That change replaces most of #2027, so it goes into #2027 instead of a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant