Repository navigation
fix(ui): move through the ☰ menu with the keyboard - #2046
Merged
Merged
Conversation
Arrow keys, Home and End move between items, Enter or Space opens the focused one, and the focus clears when the popup closes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Contributor
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @mariana953.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 4 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
- ignore keys while focus is outside the menu or during IME composition - held Enter/Space opens the item once - focus resets whenever a new item list arrives - items map by index; rows without an id stay out of the focus ring - main ignores item activations from a hidden popup Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keeps main's menu item styling from #2016 with keyboard focus on it, and waits for the rendered ack in TitlePopupApp.test instead of a fixed 20ms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mariana953
added a commit
to mariana953/Comfy-Desktop
that referenced
this pull request
Nov 12, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
benceruleanlu
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ELI5
The ☰ menu in the title bar could only be used with a mouse. With the keyboard you could open it and close it with Escape, but not pick anything. Now the arrow keys move between the options and Enter opens the one you're on.
Summary
focus-visible).role="menu", to match itsmenuitemrows.Why now: #2016 moves Performance Tests and Benchmarks from the sidebar into this menu. In the sidebar they were reachable with the keyboard, so without this they wouldn't be. CodeRabbit flagged it on #2016. The gap was already there on
mainfor every item in the menu, so this fixes it for all of them.Before / After
Telemetry
No new events. Enter goes through the same
activatepath as a click, so whatever a menu item already logs is unchanged.Test plan
MenuView.test.ts(new): arrows move and wrap past the separator, Home and End, Enter and Space open the focused item, Enter with nothing focused does nothing, focus clears on blur. The title popup tests (113) pass 3 times in a row.typecheck:webare clean.