Skip to content

feat(home): draw a Windows laptop and a Linux monitor for local builds - #2031

Merged
benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/build-device-art
Nov 13, 2026
Merged

benceruleanlu merged 1 commit into
Comfy-Org:mainfrom
mariana953:mar/build-device-art

Conversation

@mariana953

@mariana953 mariana953 commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Merge order: this PR first, then #2025 (stacked on it, needs the device art), then retarget #2025 to main.

ELI5

On Home, every local build was drawn as a Mac laptop, even on Windows. Now Windows shows a Windows laptop and Linux shows a desktop monitor, using the illustrations already designed in Figma.

Summary

  • BuildDeviceArt gets two new kinds next to the Mac laptop and the cloud, ported from the Local Setup illustrations in Figma ("6.2 · Windows", "6.3 · Linux"):
    • pc-laptop: a graphite laptop, squarer, with a camera dot in the bezel.
    • monitor: a workstation display on its stand.
    • Both keep the Home style: the build's tone glows on the screen, with the same sheen and ground shadow.
  • buildDeviceKind(build) in homeBuild.ts picks the drawing: cloud builds stay the cloud; local builds follow the platform Desktop runs on (darwin laptop, win32 PC laptop, linux monitor). An unknown platform keeps the Mac laptop.
  • HomeBuildCard uses it. The Builds page cards from style(builds): Builds as tiles that match the Home build cards #2025 can use the same helper once both land.

Before / after

Before (Windows) After

After, left to right: Mac laptop, Windows laptop, Linux monitor, cloud.

No functionality added or removed

Only the illustration changes. Cards, tones, status and actions are the same.

Telemetry

Unchanged. No events added or changed.

Test plan

  • New homeBuild.test.ts: local builds draw the laptop, PC laptop or monitor per platform; cloud builds draw the cloud everywhere; an unknown platform falls back to the laptop.
  • src/renderer/src/panel tests: 175 passed.
  • npx vue-tsc --noEmit -p tsconfig.web.json, eslint, prettier
  • Rendered all four drawings in the test browser and compared them with the Figma frames.
  • Not checked on a Windows or Linux machine.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mariana953
mariana953 requested review from a team as code owners November 12, 2026 07:59
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

Build cards now select device artwork based on build type and platform. The artwork supports laptop, PC laptop, monitor, and cloud kinds.

Changes: Build device art

Layer / File(s) Summary
Device-kind mapping
src/renderer/src/panel/home/homeBuild.ts, src/renderer/src/panel/home/homeBuild.test.ts
Adds BuildDeviceKind and buildDeviceKind. Cloud builds map to cloud; local builds map to pc-laptop on Windows, monitor on Linux, and laptop on other platforms. Tests cover these mappings.
Card artwork selection and rendering
src/renderer/src/panel/home/HomeBuildCard.vue, src/renderer/src/panel/home/BuildDeviceArt.vue
The card passes the helper’s result to BuildDeviceArt. The component accepts the shared type and adds PC laptop and monitor artwork with shared gradients.

Possibly related PRs

Suggested reviewers: benceruleanlu, deepme987

Merge Risk: Minimal · up to 5349c

This change only selects different device illustrations for local builds by platform. Card content and behavior are unchanged, and no merge-blocking risk is evident.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Create a new PR
Simplify code

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 56e0ccbd-e9ff-4175-b699-d3c9d8d57d5f
Commits

Reviewing files that changed from the base of the PR and between 2c6e820 and 5349c9a.

Files selected for processing: 4

  • src/renderer/src/panel/home/BuildDeviceArt.vue
  • src/renderer/src/panel/home/HomeBuildCard.vue
  • src/renderer/src/panel/home/homeBuild.test.ts
  • src/renderer/src/panel/home/homeBuild.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

@mariana953 mariana953 added the cursor-review Trigger multi-model Cursor code review label Nov 12, 2026
@benceruleanlu
benceruleanlu added this pull request to the merge queue Nov 13, 2026
Merged via the queue into Comfy-Org:main with commit c272cff Nov 13, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants