Skip to content

fix(apps): load an opening app during its entrance and show a skeleton - #2024

Open
PabloWiedemann wants to merge 13 commits into
PabloWiedemann/apps-result-locationfrom
claude/apps-open-loading-99f753
Open

PabloWiedemann wants to merge 13 commits into
PabloWiedemann/apps-result-locationfrom
claude/apps-open-loading-99f753

Conversation

@PabloWiedemann

@PabloWiedemann PabloWiedemann commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: An app opened from the Apps gallery now loads and paints during its entrance, and a skeleton of the app page shows until the app appears. The entrance is now a 220 ms nudge and fade, with the sidebar folding at the same time.
Why: the app view waited off the window during the entrance. Chromium on macOS treats an off-window view as hidden, so the page did not paint, its timers were throttled, and its settle signal came late. Most apps appeared ~1.5 s after the click, over an empty surface.
Can affect: opening and closing an app on the Apps page, and the showApps rect (parked replaces x = innerWidth). It does not touch the output dialog or the hosted pages.

Stack: #1981 → #1993 → #1994 → #1997 → #2008 → #2021 → #2022 → #2023 → this PR

Changes

  • Parked below the panel (stackApps.ts, appsView.ts): until it is shown, the app view sits at its real place under the opaque panel view, so Chromium keeps it visible and it renders. When it is shown, it goes to the top and takes keyboard focus. A parked view does not take focus. If the panel is not in the window, the view stays hidden.
  • Entrance (AppsHost.vue): translateX 48 px plus a fade, 220 ms, using the theme's --ease-out-expo. It replaces the 480 ms slide. entered fires when the entrance starts, so the gallery hides and the sidebar folds while the surface fades in. With reduced motion, only the fade plays.
  • Skeleton (AppPageSkeleton.vue): uses the design-system Skeleton on card panels, in the hosted page's layout (360 px controls and a results area). It stays until 250 ms after the app is shown and does not pulse with reduced motion.
  • Reveal limit: the app is shown at most 4 s after it opens, also when the page never settles or the entrance stalls.
  • Noticed and left:
    • The skeleton sizes copy text-to-image, so other app layouts can jump when the page appears.
    • card is a little lighter than the hosted page's panels.
    • The gallery skeleton still pulses with reduced motion.
    • If the panel dies without unmounting, a parked view can show for up to 4 s.

Screens

Panel layer only. The composited window could not be recorded here.

App appears Page first paint
Before (6 opens) 684–1622 ms, mostly ~1.5 s after it appears
After (4 opens) ~670–700 ms ~200 ms, while parked

Testing

  • pnpm run typecheck, lint, format:check: pass.
  • vitest run src/main/apps src/renderer/src/panel: 372 pass, two runs in a row. New tests cover the stacking order, the skeleton, the reveal when the entrance ends, the 4 s limit (also with a stalled entrance), an invalid easing token and reduced motion.
  • Dev app over CDP: a closed app is hidden with 0 fps, also after a close mid-entrance. Reduced motion gives a fade only with no pulse.
  • Not tested: watching the full window by eye (no screen recording), Windows and Linux, and apps other than the four launch apps.
  • Reviews: a cold design review led to the shared fold timing, the reduced-motion fade, card panels and the token curve. A code review found no blockers. CodeRabbit could not run (coderabbit auth login needed).

An app view parked off the window is hidden for Chromium on macOS. The
page did not paint, its timers were throttled, and its settle signal
came late. The app showed ~1.5 s after the click. Park the view at its
real place below the panel instead, so the page renders and settles
during the slide-in. The view goes to the top when it is shown.

The sliding surface now shows a skeleton of the app page until the
app is shown, so the page never looks empty. The skeleton does not
pulse when motion is reduced.
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 0f3c1408-7d75-4f7d-a7dc-0a568585ba59
Commits

Reviewing files that changed from the base of the PR and between d4c167e and 9db5ebc.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The main process now supports parked app views positioned relative to the panel. The renderer shows a loading skeleton and animates app entry. It unparks the app after entrance completion and page settlement, or after a 4,000 ms reveal limit.

Changes: App entry flow

Layer / File(s) Summary
Parked app-view ordering
src/types/ipc.ts, src/main/apps/appsView.ts, src/main/apps/stackApps.ts, src/main/apps/stackApps.test.ts
showApps accepts an optional parked flag. stackApps positions parked app views relative to the panel and appends unparked views. The main process uses the stacking result to set visibility and controls focus based on parked and uncovered state. Tests cover ordering and panel-absent cases.
Skeleton and entrance lifecycle
src/renderer/src/panel/AppPageSkeleton.vue, src/renderer/src/panel/AppsHost.vue, src/renderer/src/panel/AppsView.test.ts
The renderer displays an accessible loading skeleton. The app fades for reduced-motion users and uses a horizontal nudge otherwise. It remains parked until both entrance completion and page settlement, or the 4,000 ms reveal limit. The skeleton is removed 250 ms after reveal.
Merge Risk: Minimal · previous review d4c16

Apps opened from the gallery now load while parked under the panel and show a skeleton until they appear. No concrete merge-blocking risk was found; the cross-platform visual behavior is reported as untested by the author but is not an established defect.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7ebf20ff-2fa1-42b8-b95e-65a78fcbb88a
Commits

Reviewing files that changed from the base of the PR and between 8fd2c27 and d4c167e.

Files selected for processing: 5

  • src/main/apps/appsView.ts
  • src/main/apps/stackApps.test.ts
  • src/main/apps/stackApps.ts
  • src/renderer/src/panel/AppsHost.vue
  • src/renderer/src/panel/AppsView.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 0 remain after this review.

… reduced motion

The app surface now enters with a 220 ms nudge and fade on the theme's
ease-out-expo curve, instead of a 480 ms slide from the right. The
sidebar folds at the same time, so the skeleton lands once instead of
fading in and then moving. With reduced motion the surface still fades
in, without the nudge. The skeleton panels use the card token.
A parked app view sits under the panel, so it must not take keyboard
focus when the output dialog closes before the app is shown. The
skeleton turns off its pulse for reduced motion with one rule on its
root. The entrance tests pause the animation while they check the
parked state, and pin the entrance keyframes and duration.
@PabloWiedemann PabloWiedemann changed the title fix(apps): render an opening app behind the panel and show a skeleton fix(apps): load an opening app during its entrance and show a skeleton Nov 11, 2026
@PabloWiedemann
PabloWiedemann marked this pull request as ready for review November 11, 2026 23:57
@PabloWiedemann
PabloWiedemann requested review from a team as code owners November 11, 2026 23:57
@PabloWiedemann PabloWiedemann added the cursor-review Trigger multi-model Cursor code review label Nov 11, 2026
@PabloWiedemann
PabloWiedemann changed the base branch from PabloWiedemann/apps-output-modal to PabloWiedemann/apps-result-location November 12, 2026 00:02
@PabloWiedemann PabloWiedemann added cursor-review Trigger multi-model Cursor code review and removed cursor-review Trigger multi-model Cursor code review labels Nov 12, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @PabloWiedemann.

✅ No high-signal findings.

Panel: 4/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (empty), gpt-5.6-sol-max:adversarial (empty), claude-opus-5-thinking-max:edge-case (empty), gpt-5.6-sol-max:edge-case (empty)

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @PabloWiedemann.

Found 8 finding(s).

Severity Count
🟠 High 1
🟡 Medium 4
🟢 Low 2
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.


src/main/apps/appsView.ts:234 — 🟠 High — Adding && r.parked !== true can permanently skip focus for an app session: uncovered is computed from !view.getVisible(), and the parked report already called view.setVisible(true), so the later unpark report sees uncovered === false and view.webContents.focus() never runs. Consider tracking focus-pending state across the park/unpark pair, or focusing on the transition from parked to unparked rather than on first visibility.
Raised by 2 of 8 reviewers (gemini-3.1-pro edge-case, claude-opus-5-thinking-max edge-case).

src/main/apps/appsView.ts:230 — 🟡 Medium — Parking no longer moves the view off screen (it previously used x = window.innerWidth); the unsettled app page is now painted at its final on-screen rect and concealed only by the panel view stacked above it. The app view is still setVisible(true) and sits above comfyView, so if the panel view is hidden, resized to 0x0, or destroyed before the renderer's hideApps() round-trip lands (e.g. layoutViews() switching body mode back to comfy, or a chooser-host handoff), the loading page is exposed over the canvas.
Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).

src/main/apps/stackApps.ts:10 — 🟡 Medium — stackApps relies on addChildView(view, index) relocating a view that is already a child. Every other restack in this repo (embeddedPopupView.ts, titlePopup.ts, checkoutBackdrop.ts) calls removeChildView first, and embeddedPopupView.test.ts's fake models addChildView as a plain append. If Electron appends rather than moves, content.children accumulates duplicates on each report() and indexOf(view) returns the stale first index, so at > below is false and the app is never re-parked. The new unit test can't catch this because its fake hard-codes remove-then-insert semantics.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/renderer/src/panel/AppsHost.vue:111 — 🟡 Medium — The reveal chain await enter() → await settled → parked = false is now gated on animation.finished, which has no timeout; only settled has the REVEAL_MAX_MS watchdog. If the entrance animation stalls (window minimized or occluded so the document timeline stops advancing), the app stays parked behind the skeleton indefinitely even after the page reports settled. The new test that pauses the animation and observes parked stay true exercises exactly this state.
Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

src/renderer/src/panel/AppsHost.vue:63 — 🟡 Medium — The easing string is read at runtime from the --ease-out-expo CSS custom property and passed unvalidated to Element.animate, which throws TypeError on a malformed value. The throw rejects the async onMounted callback as an unhandled rejection, so settled is never awaited, parked is never cleared, and the skeleton never tears down — leaving a loaded but invisible app view behind the panel. Wrap the animate call or validate the token before use.
Raised by 2 of 8 reviewers (kimi-k2.7-code edge-case, claude-opus-5-thinking-max adversarial).

src/renderer/src/panel/AppsHost.vue:117 — 🟢 Low — The unpark is a one-shot edge: report() returns early while covered is true, so if the page settles with an output dialog open the main process never receives parked: false. Meanwhile lingerTimer clears the skeleton 250ms later regardless, leaving an empty surface with the app still parked until some later report() happens to fire.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/main/apps/stackApps.ts:8 — 🟢 Low — stackApps fails open: when the panel is missing from content.children (below === -1), a parked: true request still calls addChildView(view), placing the view on top of every sibling — the inverse of the caller's intent, and exactly in the case where the concealing view is absent. Leaving the view where it is would fail closed.
Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

src/renderer/src/panel/AppsHost.vue:83 — ⚪ Nit — When settled resolves before REVEAL_MAX_MS, revealTimer is never cleared, so the fallback fires later as a no-op and keeps its closure alive until unmount.
Raised by 1 of 8 reviewers (kimi-k2.7-code edge-case).

(Inline comments could not be anchored to the diff; listed above instead.)

- Main remembers which app views are parked, so the report that unparks
  a view gives it keyboard focus. Before, the parked report had already
  made the view visible, so the reveal never focused it.
- stackApps returns false when the panel is not in the window, and the
  view is hidden instead of going on top of every sibling.
- The 4 s reveal limit now starts at mount and does not wait for the
  entrance, so a stalled animation cannot keep a settled app parked.
  The limit timer is cleared once the app is revealed.
- The entrance easing comes from --ease-out-expo only when CSS.supports
  accepts it; otherwise it uses ease-out, so a bad token cannot throw.
@PabloWiedemann

Copy link
Copy Markdown
Contributor Author

Cursor Review follow-up, in fa50568.

Fixed

  • High, appsView.ts:234, no focus on reveal: main now remembers which app views are parked. The report that unparks a view gives it keyboard focus. A parked view still does not take focus.
  • Medium, AppsHost.vue:111, a stalled entrance blocks the reveal: the 4 s limit now starts at mount and does not wait for the entrance. New test: a settled app is shown at 4 s while its entrance is paused.
  • Medium, AppsHost.vue:63, a bad easing token throws: the curve from --ease-out-expo is used only when CSS.supports('animation-timing-function', …) accepts it. Otherwise it is ease-out. New test with an invalid token.
  • Low, stackApps.ts:8, fails open with no panel: stackApps returns false when the panel is not in the window. showApps then hides the view, so it no longer goes on top.
  • Nit, AppsHost.vue:83, limit timer not cleared: the reveal clears it.

Left

  • Medium, appsView.ts:230, page exposed if the panel goes away: an open (unparked) app on main has the same exposure, because layoutViews() hides the panel but not the apps view when the body switches to comfy. Parking adds at most the settle window, up to 4 s. The fix belongs in layoutViews(): hide the apps view with the panel. That is a separate change to createHostWindow.ts.
  • Medium, stackApps.ts:10, addChildView may append: Electron documents that adding a view the parent already holds reorders it. With an index, View::AddChildViewAt calls ReorderChildView. I checked it in the running app: the children list keeps one entry, and a closed app is hidden at 0 fps. Calling removeChildView first would hide and re-show the page on every resize.
  • Low, AppsHost.vue:117, unpark skipped while covered: the output dialog opens from inside the app page, and a parked page sits under the panel, so it cannot open the dialog. If the host is ever covered while parked, the covered watcher calls report() when it uncovers, and that sends parked: false.

CI: the E2E (windows) failure is lifecycle-snapshot-restore.test.ts:204 (modal-confirm-button did not become visible). It passed on retry, and failOnFlakyTests fails the job on any flaky test. That spec does not touch the Apps page. No E2E spec covers the Apps page.

Checks: typecheck, lint and format pass. vitest run src/main/apps src/renderer/src/panel passes: 372 tests, two runs.

@cursor

cursor Bot commented Nov 12, 2026

Copy link
Copy Markdown

Skipping Bugbot: Bugbot could not find a matching SCM installation for this repository. Please reinstall the GitHub/GitLab installation and/or remove the installation from non-Bugbot accounts. Visit the Bugbot dashboard to update your settings.

PabloWiedemann and others added 2 commits November 12, 2026 14:15
…pen-loading-99f753

# Conflicts:
#	src/renderer/src/panel/AppsHost.vue
#	src/renderer/src/panel/AppsView.test.ts
…pen-loading-99f753

# Conflicts:
#	src/main/apps/appsView.ts
@vqt123
vqt123 removed this pull request from stack #1995 November 12, 2026 23:02
@vqt123
vqt123 added this pull request to stack #2058 November 12, 2026 23:03
@PabloWiedemann

Copy link
Copy Markdown
Contributor Author

Review follow-up.

Branch: merged #2023 with the review fixes below it (d4c167e). Typecheck, lint and format pass. No open review threads.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants